rs3gw 0.2.1

High-Performance AI/HPC Object Storage Gateway powered by scirs2-io
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
//! REST API handlers for Distributed Training Integration
//!
//! This module provides HTTP endpoints for managing training experiments,
//! checkpoints, metrics, and hyperparameter searches.
//!
//! # Endpoints
//!
//! ## Experiment Management
//! - `POST /api/training/experiments` - Create new experiment
//! - `GET /api/training/experiments/:id` - Get experiment details
//! - `GET /api/training/experiments` - List all experiments
//! - `PUT /api/training/experiments/:id/status` - Update experiment status
//!
//! ## Checkpoint Management
//! - `POST /api/training/experiments/:id/checkpoints` - Save checkpoint
//! - `GET /api/training/checkpoints/:checkpoint_id` - Load checkpoint
//! - `GET /api/training/experiments/:id/checkpoints` - List checkpoints
//!
//! ## Metrics
//! - `POST /api/training/experiments/:id/metrics` - Log metrics
//! - `GET /api/training/experiments/:id/metrics` - Get metrics history
//!
//! ## Hyperparameter Search
//! - `POST /api/training/searches` - Create hyperparameter search
//! - `POST /api/training/searches/:id/trials` - Add trial result
//! - `GET /api/training/searches/:id` - Get search results

use crate::storage::distributed_training::{
    Checkpoint, Experiment, ExperimentConfig, ExperimentStatus, HyperparameterSearchResult,
    MetricsEntry, TrialStatus,
};
use axum::{
    extract::{Path, State},
    http::StatusCode,
    response::{IntoResponse, Response},
    Json,
};
use base64::Engine;
use serde::{Deserialize, Serialize};
use serde_json::Value as JsonValue;

/// Request to create a new experiment
#[derive(Debug, Deserialize, Serialize)]
pub struct CreateExperimentRequest {
    /// Experiment name (must be unique)
    pub name: String,
    /// Optional description
    pub description: Option<String>,
    /// Tags for categorization
    #[serde(default)]
    pub tags: Vec<String>,
    /// Hyperparameters as JSON
    pub hyperparameters: JsonValue,
}

/// Response with experiment details
#[derive(Debug, Serialize)]
pub struct ExperimentResponse {
    pub experiment: Experiment,
}

/// Request to update experiment status
#[derive(Debug, Deserialize)]
pub struct UpdateStatusRequest {
    pub status: ExperimentStatus,
}

/// Request to save a checkpoint
#[derive(Debug, Deserialize)]
pub struct SaveCheckpointRequest {
    /// Epoch number
    pub epoch: u64,
    /// Model state (base64 encoded)
    pub model_state: String,
    /// Optimizer state (base64 encoded, optional)
    pub optimizer_state: Option<String>,
    /// Metrics at this checkpoint
    pub metrics: JsonValue,
}

/// Response with checkpoint details
#[derive(Debug, Serialize)]
pub struct CheckpointResponse {
    pub checkpoint: Checkpoint,
}

/// Response with loaded checkpoint (includes data)
#[derive(Debug, Serialize)]
pub struct LoadedCheckpointResponse {
    pub checkpoint: Checkpoint,
    /// Model state (base64 encoded)
    pub model_state: String,
    /// Optimizer state (base64 encoded, optional)
    pub optimizer_state: Option<String>,
}

/// Request to log metrics
#[derive(Debug, Deserialize)]
pub struct LogMetricsRequest {
    /// Step number
    pub step: u64,
    /// Metrics as JSON
    pub metrics: JsonValue,
}

/// Response with metrics history
#[derive(Debug, Serialize)]
pub struct MetricsResponse {
    pub metrics: Vec<MetricsEntry>,
    pub count: usize,
}

/// Request to create hyperparameter search
#[derive(Debug, Deserialize)]
pub struct CreateSearchRequest {
    /// Search space definition
    pub search_space: JsonValue,
    /// Metric to optimize
    pub optimization_metric: String,
}

/// Request to add a trial
#[derive(Debug, Deserialize)]
pub struct AddTrialRequest {
    /// Hyperparameters used
    pub params: JsonValue,
    /// Result metrics
    pub metrics: JsonValue,
    /// Trial status
    pub status: TrialStatus,
}

/// Response with search results
#[derive(Debug, Serialize)]
pub struct SearchResponse {
    pub search: HyperparameterSearchResult,
}

/// List experiments response
#[derive(Debug, Serialize)]
pub struct ListExperimentsResponse {
    pub experiments: Vec<Experiment>,
    pub count: usize,
}

/// List checkpoints response
#[derive(Debug, Serialize)]
pub struct ListCheckpointsResponse {
    pub checkpoints: Vec<Checkpoint>,
    pub count: usize,
}

/// Error response
#[derive(Debug, Serialize)]
pub struct ErrorResponse {
    pub error: String,
}

impl IntoResponse for ErrorResponse {
    fn into_response(self) -> Response {
        (StatusCode::BAD_REQUEST, Json(self)).into_response()
    }
}

/// Create a new training experiment
pub async fn create_experiment(
    State(state): State<crate::AppState>,
    Json(req): Json<CreateExperimentRequest>,
) -> Result<Json<ExperimentResponse>, (StatusCode, Json<ErrorResponse>)> {
    let config = ExperimentConfig {
        name: req.name,
        description: req.description,
        tags: req.tags,
        hyperparameters: req.hyperparameters,
    };

    match state.training_manager.create_experiment(config).await {
        Ok(experiment) => Ok(Json(ExperimentResponse { experiment })),
        Err(e) => Err((
            StatusCode::BAD_REQUEST,
            Json(ErrorResponse {
                error: e.to_string(),
            }),
        )),
    }
}

/// Get experiment by ID
pub async fn get_experiment(
    State(state): State<crate::AppState>,
    Path(experiment_id): Path<String>,
) -> Result<Json<ExperimentResponse>, (StatusCode, Json<ErrorResponse>)> {
    match state.training_manager.get_experiment(&experiment_id).await {
        Ok(experiment) => Ok(Json(ExperimentResponse { experiment })),
        Err(e) => Err((
            StatusCode::NOT_FOUND,
            Json(ErrorResponse {
                error: e.to_string(),
            }),
        )),
    }
}

/// Update experiment status
pub async fn update_experiment_status(
    State(state): State<crate::AppState>,
    Path(experiment_id): Path<String>,
    Json(req): Json<UpdateStatusRequest>,
) -> Result<Json<ExperimentResponse>, (StatusCode, Json<ErrorResponse>)> {
    match state
        .training_manager
        .update_experiment_status(&experiment_id, req.status)
        .await
    {
        Ok(_) => {
            // Fetch the updated experiment to return
            match state.training_manager.get_experiment(&experiment_id).await {
                Ok(experiment) => Ok(Json(ExperimentResponse { experiment })),
                Err(e) => Err((
                    StatusCode::INTERNAL_SERVER_ERROR,
                    Json(ErrorResponse {
                        error: e.to_string(),
                    }),
                )),
            }
        }
        Err(e) => Err((
            StatusCode::BAD_REQUEST,
            Json(ErrorResponse {
                error: e.to_string(),
            }),
        )),
    }
}

/// Save a checkpoint
pub async fn save_checkpoint(
    State(state): State<crate::AppState>,
    Path(experiment_id): Path<String>,
    Json(req): Json<SaveCheckpointRequest>,
) -> Result<Json<CheckpointResponse>, (StatusCode, Json<ErrorResponse>)> {
    // Decode base64 model state
    let model_state = match base64::engine::general_purpose::STANDARD.decode(&req.model_state) {
        Ok(data) => data,
        Err(e) => {
            return Err((
                StatusCode::BAD_REQUEST,
                Json(ErrorResponse {
                    error: format!("Invalid base64 model_state: {}", e),
                }),
            ))
        }
    };

    // Decode base64 optimizer state if present
    let optimizer_state = if let Some(opt_state_b64) = req.optimizer_state {
        match base64::engine::general_purpose::STANDARD.decode(&opt_state_b64) {
            Ok(data) => Some(data),
            Err(e) => {
                return Err((
                    StatusCode::BAD_REQUEST,
                    Json(ErrorResponse {
                        error: format!("Invalid base64 optimizer_state: {}", e),
                    }),
                ))
            }
        }
    } else {
        None
    };

    match state
        .training_manager
        .save_checkpoint(
            &experiment_id,
            req.epoch,
            model_state,
            optimizer_state,
            req.metrics,
        )
        .await
    {
        Ok(checkpoint) => Ok(Json(CheckpointResponse { checkpoint })),
        Err(e) => Err((
            StatusCode::BAD_REQUEST,
            Json(ErrorResponse {
                error: e.to_string(),
            }),
        )),
    }
}

/// Load a checkpoint
pub async fn load_checkpoint(
    State(state): State<crate::AppState>,
    Path(checkpoint_id): Path<String>,
) -> Result<Json<LoadedCheckpointResponse>, (StatusCode, Json<ErrorResponse>)> {
    match state.training_manager.load_checkpoint(&checkpoint_id).await {
        Ok(loaded) => {
            // Encode to base64
            let model_state = base64::engine::general_purpose::STANDARD.encode(&loaded.model_state);
            let optimizer_state = loaded
                .optimizer_state
                .as_ref()
                .map(|s| base64::engine::general_purpose::STANDARD.encode(s));

            Ok(Json(LoadedCheckpointResponse {
                checkpoint: loaded.checkpoint,
                model_state,
                optimizer_state,
            }))
        }
        Err(e) => Err((
            StatusCode::NOT_FOUND,
            Json(ErrorResponse {
                error: e.to_string(),
            }),
        )),
    }
}

/// List checkpoints for an experiment
pub async fn list_checkpoints(
    State(state): State<crate::AppState>,
    Path(experiment_id): Path<String>,
) -> Result<Json<ListCheckpointsResponse>, (StatusCode, Json<ErrorResponse>)> {
    match state
        .training_manager
        .list_checkpoints(&experiment_id)
        .await
    {
        Ok(checkpoints) => {
            let count = checkpoints.len();
            Ok(Json(ListCheckpointsResponse { checkpoints, count }))
        }
        Err(e) => Err((
            StatusCode::BAD_REQUEST,
            Json(ErrorResponse {
                error: e.to_string(),
            }),
        )),
    }
}

/// Log training metrics
pub async fn log_metrics(
    State(state): State<crate::AppState>,
    Path(experiment_id): Path<String>,
    Json(req): Json<LogMetricsRequest>,
) -> Result<StatusCode, (StatusCode, Json<ErrorResponse>)> {
    match state
        .training_manager
        .log_metrics(&experiment_id, req.step, req.metrics)
        .await
    {
        Ok(_) => Ok(StatusCode::CREATED),
        Err(e) => Err((
            StatusCode::BAD_REQUEST,
            Json(ErrorResponse {
                error: e.to_string(),
            }),
        )),
    }
}

/// Get metrics for an experiment
pub async fn get_metrics(
    State(state): State<crate::AppState>,
    Path(experiment_id): Path<String>,
) -> Result<Json<MetricsResponse>, (StatusCode, Json<ErrorResponse>)> {
    match state.training_manager.get_metrics(&experiment_id).await {
        Ok(metrics) => {
            let count = metrics.len();
            Ok(Json(MetricsResponse { metrics, count }))
        }
        Err(e) => Err((
            StatusCode::BAD_REQUEST,
            Json(ErrorResponse {
                error: e.to_string(),
            }),
        )),
    }
}

/// Create hyperparameter search
pub async fn create_search(
    State(state): State<crate::AppState>,
    Json(req): Json<CreateSearchRequest>,
) -> Result<Json<SearchResponse>, (StatusCode, Json<ErrorResponse>)> {
    match state
        .training_manager
        .create_search(req.search_space, req.optimization_metric)
        .await
    {
        Ok(search) => Ok(Json(SearchResponse { search })),
        Err(e) => Err((
            StatusCode::BAD_REQUEST,
            Json(ErrorResponse {
                error: e.to_string(),
            }),
        )),
    }
}

/// Add trial to hyperparameter search
pub async fn add_trial(
    State(state): State<crate::AppState>,
    Path(search_id): Path<String>,
    Json(req): Json<AddTrialRequest>,
) -> Result<Json<SearchResponse>, (StatusCode, Json<ErrorResponse>)> {
    match state
        .training_manager
        .add_trial(&search_id, req.params, req.metrics, req.status)
        .await
    {
        Ok(_) => {
            // Fetch the updated search to return
            match state.training_manager.get_search(&search_id).await {
                Ok(search) => Ok(Json(SearchResponse { search })),
                Err(e) => Err((
                    StatusCode::INTERNAL_SERVER_ERROR,
                    Json(ErrorResponse {
                        error: e.to_string(),
                    }),
                )),
            }
        }
        Err(e) => Err((
            StatusCode::BAD_REQUEST,
            Json(ErrorResponse {
                error: e.to_string(),
            }),
        )),
    }
}

/// Get hyperparameter search by ID
pub async fn get_search(
    State(state): State<crate::AppState>,
    Path(search_id): Path<String>,
) -> Result<Json<SearchResponse>, (StatusCode, Json<ErrorResponse>)> {
    match state.training_manager.get_search(&search_id).await {
        Ok(search) => Ok(Json(SearchResponse { search })),
        Err(e) => Err((
            StatusCode::NOT_FOUND,
            Json(ErrorResponse {
                error: e.to_string(),
            }),
        )),
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::storage::distributed_training::TrainingManager;
    use serde_json::json;
    use std::sync::Arc;
    use tempfile::TempDir;

    fn setup_manager() -> (Arc<TrainingManager>, TempDir) {
        let temp_dir = TempDir::new().expect("failed to create temp dir");
        let manager: Arc<TrainingManager> =
            Arc::new(TrainingManager::new(temp_dir.path().to_path_buf()));
        (manager, temp_dir)
    }

    fn create_test_app_state(manager: Arc<TrainingManager>) -> crate::AppState {
        let temp_dir = TempDir::new().expect("failed to create temp dir");
        let storage_root = temp_dir.path().to_path_buf();
        let storage = Arc::new(
            crate::storage::StorageEngine::new(storage_root.clone())
                .expect("failed to create storage engine"),
        );
        // Use shared test metrics handle to avoid conflicts with other test modules
        let metrics_handle = crate::test_helpers::get_test_metrics_handle();
        let preprocessing_path = temp_dir.path().join("preprocessing");
        let preprocessing_manager = Arc::new(
            crate::storage::preprocessing::PreprocessingManager::new(preprocessing_path),
        );
        let predictive_analytics = Arc::new(crate::observability::PredictiveAnalytics::new(
            10_000,
            0.023,
            0.09,
            0.0004,
            1_000_000_000_000,
        ));
        let metrics_tracker = Arc::new(crate::observability::MetricsTracker::new());
        let select_result_cache =
            Arc::new(crate::api::SelectResultCache::new(100, 10 * 1024 * 1024));
        let query_intelligence = Arc::new(crate::api::QueryIntelligence::new());

        let config = crate::Config {
            bind_addr: "127.0.0.1:9000"
                .parse()
                .expect("failed to parse bind address"),
            storage_root,
            default_bucket: "default".to_string(),
            access_key: String::new(),
            secret_key: String::new(),
            compression: crate::storage::CompressionMode::None,
            request_timeout_secs: 0,
            max_concurrent_requests: 0,
            tls: crate::TlsConfig::default(),
            connection_pool: crate::ConnectionPoolConfig::default(),
            cluster: crate::cluster::ClusterConfig::default(),
            dedup: crate::storage::DedupConfig::disabled(),
            zerocopy: crate::storage::ZeroCopyConfig::default(),
            select_cache: crate::SelectCacheConfig::default(),
            multipart_retention_hours: 168,
            fsync: false,
        };

        crate::AppState {
            config,
            storage,
            metrics_handle,
            cache: None,
            throttle: None,
            quota: None,
            event_broadcaster: crate::api::EventBroadcaster::new(),
            query_plan_cache: None,
            select_result_cache,
            query_intelligence,
            advanced_replication: None,
            preprocessing_manager,
            predictive_analytics,
            metrics_tracker,
            training_manager: manager,
            start_time: std::time::Instant::now(),
            verifier: None,
            auth_failure_counts: std::sync::Arc::new(std::sync::Mutex::new(
                std::collections::HashMap::new(),
            )),
            in_flight: crate::InFlightTracker::new(),
            encryption: std::sync::Arc::new(crate::storage::encryption::EncryptionService::new(
                std::sync::Arc::new(crate::storage::encryption::LocalKeyProvider::default()),
            )),
        }
    }

    #[tokio::test]
    async fn test_create_experiment_handler() {
        let (manager, _temp) = setup_manager();
        let state = create_test_app_state(manager);

        let req = CreateExperimentRequest {
            name: "test-exp".to_string(),
            description: Some("Test".to_string()),
            tags: vec!["test".to_string()],
            hyperparameters: json!({"lr": 0.001}),
        };

        let result = create_experiment(State(state), Json(req)).await;
        assert!(result.is_ok());

        let response = result.expect("create_experiment should succeed").0;
        assert_eq!(response.experiment.name, "test-exp");
    }

    #[tokio::test]
    async fn test_save_and_load_checkpoint_handler() {
        let (manager, _temp) = setup_manager();
        let state = create_test_app_state(manager.clone());

        // Create experiment first
        let exp_config = ExperimentConfig {
            name: "ckpt-test".to_string(),
            description: None,
            tags: vec![],
            hyperparameters: json!({}),
        };
        let exp = manager
            .create_experiment(exp_config)
            .await
            .expect("create experiment should succeed");

        // Save checkpoint
        let model_data = b"model_data";
        let model_state_b64 = base64::engine::general_purpose::STANDARD.encode(model_data);

        let save_req = SaveCheckpointRequest {
            epoch: 1,
            model_state: model_state_b64.clone(),
            optimizer_state: None,
            metrics: json!({"loss": 0.5}),
        };

        let save_result =
            save_checkpoint(State(state.clone()), Path(exp.id.clone()), Json(save_req)).await;
        assert!(save_result.is_ok());

        let checkpoint_id = save_result
            .expect("save_checkpoint should succeed")
            .0
            .checkpoint
            .id;

        // Load checkpoint
        let load_result = load_checkpoint(State(state), Path(checkpoint_id)).await;
        assert!(load_result.is_ok());

        let loaded = load_result.expect("load_checkpoint should succeed").0;
        let decoded = base64::engine::general_purpose::STANDARD
            .decode(&loaded.model_state)
            .expect("base64 decode should succeed");
        assert_eq!(decoded, model_data);
    }

    #[tokio::test]
    async fn test_log_and_get_metrics_handler() {
        let (manager, _temp) = setup_manager();
        let state = create_test_app_state(manager.clone());

        let exp_config = ExperimentConfig {
            name: "metrics-test".to_string(),
            description: None,
            tags: vec![],
            hyperparameters: json!({}),
        };
        let exp = manager
            .create_experiment(exp_config)
            .await
            .expect("create experiment should succeed");

        // Log metrics
        let log_req = LogMetricsRequest {
            step: 1,
            metrics: json!({"loss": 0.5}),
        };

        let log_result =
            log_metrics(State(state.clone()), Path(exp.id.clone()), Json(log_req)).await;
        assert!(log_result.is_ok());

        // Get metrics
        let get_result = get_metrics(State(state), Path(exp.id)).await;
        assert!(get_result.is_ok());

        let response = get_result.expect("get_metrics should succeed").0;
        assert_eq!(response.count, 1);
        assert_eq!(response.metrics[0].step, 1);
    }

    #[tokio::test]
    async fn test_update_status_handler() {
        let (manager, _temp) = setup_manager();
        let state = create_test_app_state(manager.clone());

        let exp_config = ExperimentConfig {
            name: "status-test".to_string(),
            description: None,
            tags: vec![],
            hyperparameters: json!({}),
        };
        let exp = manager
            .create_experiment(exp_config)
            .await
            .expect("create experiment should succeed");

        let update_req = UpdateStatusRequest {
            status: ExperimentStatus::Completed,
        };

        let result =
            update_experiment_status(State(state), Path(exp.id.clone()), Json(update_req)).await;
        assert!(result.is_ok());

        // Verify status was updated
        let updated = manager
            .get_experiment(&exp.id)
            .await
            .expect("get experiment should succeed");
        assert_eq!(updated.status, ExperimentStatus::Completed);
    }

    #[tokio::test]
    async fn test_list_checkpoints_handler() {
        let (manager, _temp) = setup_manager();
        let state = create_test_app_state(manager.clone());

        let exp_config = ExperimentConfig {
            name: "list-test".to_string(),
            description: None,
            tags: vec![],
            hyperparameters: json!({}),
        };
        let exp = manager
            .create_experiment(exp_config)
            .await
            .expect("create experiment should succeed");

        // Save 2 checkpoints
        for epoch in 1..=2 {
            manager
                .save_checkpoint(
                    &exp.id,
                    epoch,
                    b"model".to_vec(),
                    None,
                    json!({"epoch": epoch}),
                )
                .await
                .expect("save_checkpoint should succeed");
        }

        let result = list_checkpoints(State(state), Path(exp.id)).await;
        assert!(result.is_ok());

        let response = result.expect("list_checkpoints should succeed").0;
        assert_eq!(response.count, 2);
    }

    #[tokio::test]
    async fn test_create_search_handler() {
        let (manager, _temp) = setup_manager();
        let state = create_test_app_state(manager);

        let req = CreateSearchRequest {
            search_space: json!({"lr": [0.001, 0.01]}),
            optimization_metric: "accuracy".to_string(),
        };

        let result = create_search(State(state), Json(req)).await;
        assert!(result.is_ok());

        let response = result.expect("create_search should succeed").0;
        assert_eq!(response.search.optimization_metric, "accuracy");
    }
}