rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36

//! Detect whether `self.` is redundant on a call.

use tree_sitter::Node;

use crate::cop::shared::call_method_name;
use crate::parse::source::SourceFile;

use super::shadow::name_is_shadowed;

pub(super) fn self_is_redundant(source: &SourceFile, node: Node<'_>) -> bool {
    let Some(method) = call_method_name(source, node) else {
        return false;
    };
    if excluded_method(method) {
        return false;
    }
    !name_is_shadowed(source, node, method)
}

fn excluded_method(method: &[u8]) -> bool {
    method == b"class"
        || method.starts_with(b"[")
        || method.first().is_some_and(|b| b.is_ascii_uppercase())
        || is_setter_name(method)
        || !is_simple_method_name(method)
}

fn is_setter_name(method: &[u8]) -> bool {
    method.ends_with(b"=") && method != b"==" && method != b"!=" && method != b"=~" && method != b"!~"
}

fn is_simple_method_name(method: &[u8]) -> bool {
    method
        .iter()
        .all(|b| b.is_ascii_alphanumeric() || matches!(*b, b'_' | b'!' | b'?' | b'='))
}