rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91

//! RSpec/EmptyLineAfterHook — blank line after `before`/`after`/`around` blocks.

use tree_sitter::Node;

use crate::cop::shared::{call_method_name, push_replace};
use crate::cop::{Cop, CopConfig};
use crate::correction::Correction;
use crate::diagnostic::Diagnostic;
use crate::parse::source::SourceFile;

pub struct EmptyLineAfterHook;

const HOOKS: &[&[u8]] = &[b"before", b"after", b"around"];

fn hook_block(node: Node<'_>) -> Option<Node<'_>> {
    let p = node.parent()?;
    matches!(p.kind(), "block" | "do_block").then_some(p)
}

fn has_blank_or_end(source: &SourceFile, end_node: Node<'_>) -> bool {
    let end_line = source.offset_to_line_col(end_node.end_byte()).0;
    let Some(next_start) = source.line_start(end_line + 1) else {
        return true;
    };
    let bytes = source.as_bytes();
    let next = std::str::from_utf8(
        &bytes[next_start..source.line_start(end_line + 2).unwrap_or(bytes.len())],
    )
    .unwrap_or("")
    .trim();
    next.is_empty() || next == "end"
}

impl Cop for EmptyLineAfterHook {
    fn name(&self) -> &'static str {
        "RSpec/EmptyLineAfterHook"
    }

    fn default_include(&self) -> &'static [&'static str] {
        &["**/*_spec.rb", "**/spec/**/*"]
    }

    fn supports_autocorrect(&self) -> bool {
        true
    }

    fn interested_node_kinds(&self) -> &'static [&'static str] {
        &["call", "command"]
    }

    fn check_node(
        &self,
        source: &SourceFile,
        node: Node<'_>,
        _config: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        mut corrections: Option<&mut Vec<Correction>>,
    ) {
        let Some(method) = call_method_name(source, node) else {
            return;
        };
        if !HOOKS.contains(&method) {
            return;
        }
        let Some(end_node) = hook_block(node) else {
            return;
        };
        if has_blank_or_end(source, end_node) {
            return;
        }
        let insert_at = end_node.end_byte();
        let (line, col) = source.offset_to_line_col(insert_at);
        let name = std::str::from_utf8(method).unwrap_or("hook");
        let mut diag = self.diagnostic(
            source,
            line,
            col,
            format!("Add an empty line after `{name}`."),
        );
        if push_replace(
            &mut corrections,
            insert_at,
            insert_at,
            "\n",
            self.name(),
        ) {
            diag.corrected = true;
        }
        diagnostics.push(diag);
    }
}