rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118

//! Layout/MultilineOperationIndentation.

mod check;
mod context;
mod indent;
mod line_scan;

use tree_sitter::Node;

use crate::cop::{Cop, CopConfig};
use crate::correction::Correction;
use crate::diagnostic::Diagnostic;
use crate::parse::source::SourceFile;

pub(crate) use indent::aligned_method_call_col;

pub struct MultilineOperationIndentation;

impl Cop for MultilineOperationIndentation {
    fn name(&self) -> &'static str {
        "Layout/MultilineOperationIndentation"
    }
    fn supports_autocorrect(&self) -> bool {
        true
    }
    fn interested_node_kinds(&self) -> &'static [&'static str] {
        &["binary"]
    }

    fn check_node(
        &self,
        source: &SourceFile,
        node: Node<'_>,
        config: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        mut corrections: Option<&mut Vec<Correction>>,
    ) {
        check::check_binary(self, source, node, config, diagnostics, &mut corrections);
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::testutil::run_cop_full_with_config;
    use std::collections::HashMap;

    crate::cop_fixture_tests!(
        MultilineOperationIndentation,
        "cops/layout/multiline_operation_indentation"
    );

    fn indented_config() -> CopConfig {
        CopConfig {
            options: HashMap::from([(
                "EnforcedStyle".into(),
                serde_yml::Value::String("indented".into()),
            )]),
            ..CopConfig::default()
        }
    }

    #[test]
    fn indented_if_or_chain_no_offense() {
        let diags = run_cop_full_with_config(
            &MultilineOperationIndentation,
            b"        if currency_id.blank? || !Currency.exists?(id: currency_id) ||\n            StringIdVersion.exists?(item_type: 'Currency')\n          stats[:skipped] += 1\n        end\n",
            indented_config(),
        );
        assert!(
            diags.is_empty(),
            "indented if-condition || continuation: {:?}",
            diags
        );
    }

    #[test]
    fn indented_return_unless_or_chain_no_offense() {
        let diags = run_cop_full_with_config(
            &MultilineOperationIndentation,
            b"      return unless ::Merchants::Firekassa::MERCHANT_TIDS.present? &&\n        merchant_tids.all? { |tid| withdraw_tids.include?(tid) }\n",
            indented_config(),
        );
        assert!(
            diags.is_empty(),
            "return unless || continuation: {:?}",
            diags
        );
    }

    #[test]
    fn indented_assignment_or_continuation_no_offense() {
        let diags = run_cop_full_with_config(
            &MultilineOperationIndentation,
            b"    wallet = Wallet.fee.find_by(blockchain_key: blockchain.real_key, tag: tag) ||\n      Wallet.deposit.find_by(blockchain_key: blockchain.real_key, tag: tag)\n",
            indented_config(),
        );
        assert!(
            diags.is_empty(),
            "indented assignment || continuation: {:?}",
            diags
        );
    }

    #[test]
    fn indented_assignment_plus_chain_no_offense() {
        let diags = run_cop_full_with_config(
            &MultilineOperationIndentation,
            b"    line = headers['TS-API-TIMESTAMP'].to_s +\n      headers['TS-API-API-KEY'].to_s +\n      payload\n",
            indented_config(),
        );
        assert!(
            diags.is_empty(),
            "indented assignment + chain: {:?}",
            diags
        );
    }
}