rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89

//! GraphQL/MultipleFieldDefinitions — group duplicate-named field definitions.

use tree_sitter::Node;

use super::helpers::{
    class_body_stmts, enclosing_class, field_name, is_field_call, nested_class, CALL_KINDS,
    DEPT_INCLUDE,
};
use crate::cop::{Cop, CopConfig};
use crate::diagnostic::Diagnostic;
use crate::parse::source::SourceFile;

pub struct MultipleFieldDefinitions;

impl Cop for MultipleFieldDefinitions {
    fn name(&self) -> &'static str {
        "GraphQL/MultipleFieldDefinitions"
    }

    fn default_include(&self) -> &'static [&'static str] {
        DEPT_INCLUDE
    }

    fn interested_node_kinds(&self) -> &'static [&'static str] {
        CALL_KINDS
    }

    fn check_node(
        &self,
        source: &SourceFile,
        node: Node<'_>,
        _config: &CopConfig,
        diagnostics: &mut Vec<Diagnostic>,
        _corrections: Option<&mut Vec<crate::correction::Correction>>,
    ) {
        if !is_field_call(source, node) {
            return;
        }
        let Some(class) = enclosing_class(node) else {
            return;
        };
        if nested_class(class) {
            return;
        }
        let Some(name) = field_name(source, node) else {
            return;
        };
        if !ungrouped_last_def(source, class, node, &name) {
            return;
        }
        let (line, col) = source.offset_to_line_col(node.start_byte());
        diagnostics.push(self.diagnostic(
            source,
            line,
            col,
            "Group multiple field definitions together.".into(),
        ));
    }
}

fn ungrouped_last_def(
    source: &SourceFile,
    class: Node<'_>,
    node: Node<'_>,
    name: &str,
) -> bool {
    is_last_ungrouped(&same_name_defs(source, class, name), node)
}

fn same_name_defs<'a>(
    source: &SourceFile,
    class: Node<'a>,
    name: &str,
) -> Vec<(usize, Node<'a>)> {
    class_body_stmts(class)
        .into_iter()
        .enumerate()
        .filter(|(_, n)| {
            is_field_call(source, *n) && field_name(source, *n).as_deref() == Some(name)
        })
        .map(|(i, n)| (i, n))
        .collect()
}

fn is_last_ungrouped(defs: &[(usize, Node<'_>)], node: Node<'_>) -> bool {
    defs.len() > 1
        && defs.last().map(|(_, n)| n.id()) == Some(node.id())
        && defs.windows(2).any(|w| w[1].0 - w[0].0 > 1)
}