rrubocop 0.8.15

10x faster RuboCop drop-in. Same output format and configs, without maintaining RuboCop gems.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115

//! Cache tests spanning facade bootstrap and the entry store.

use super::*;

fn temp_cache_dir(tag: &str) -> PathBuf {
    let dir =
        std::env::temp_dir().join(format!("rrubocop-cache-test-{}-{tag}", std::process::id()));
    let _ = std::fs::remove_dir_all(&dir);
    dir
}

fn sample_diag() -> crate::diagnostic::Diagnostic {
    crate::diagnostic::Diagnostic {
        path: "a.rb".into(),
        location: crate::diagnostic::Location { line: 1, column: 0 },
        severity: crate::diagnostic::Severity::Convention,
        cop_name: "Layout/TrailingWhitespace".into(),
        message: "Trailing whitespace detected.".into(),
        corrected: false,
        correctable: true,
        source_line: String::new(),
        highlight_length: 1,
    }
}

#[test]
fn roundtrip_returns_stored_diagnostics() {
    let cache = Cache::open_at(&temp_cache_dir("roundtrip")).expect("cache opens");
    let diags = vec![sample_diag()];
    let key = "a".repeat(64);
    cache.store(&key, &diags);
    let hit = cache.get(&key).expect("cache hit");
    assert_eq!(hit.len(), 1);
    assert_eq!(hit[0].cop_name, "Layout/TrailingWhitespace");
}

#[test]
fn miss_on_other_key_is_none() {
    let cache = Cache::open_at(&temp_cache_dir("miss")).expect("cache opens");
    cache.store(&"a".repeat(64), &[sample_diag()]);
    assert!(cache.get(&"b".repeat(64)).is_none());
}

#[test]
fn prune_keeps_newest_max_entries() {
    use crate::cache::store::MAX_ENTRIES;

    fn seed_entries(cache: &Cache, count: u64) {
        for i in 0..count {
            let payload = format!(r#"{{"ts":{i},"diagnostics":[]}}"#);
            cache
                .store_ref()
                .raw_insert(&format!("{i:064}"), payload.as_bytes());
        }
    }
    let cache = Cache::open_at(&temp_cache_dir("prune")).expect("cache opens");
    seed_entries(&cache, MAX_ENTRIES as u64 + 10);
    cache.prune();

    assert_eq!(cache.store_ref().raw_len(), MAX_ENTRIES);
    assert!(
        (0..=9).all(|i| cache.store_ref().raw_get(&format!("{i:064}")).is_none()),
        "oldest ten pruned"
    );
    let newest = format!("{:064}", MAX_ENTRIES as u64 + 9);
    assert!(cache.store_ref().raw_get(&newest).is_some());
}

#[test]
fn corrupt_entry_is_a_miss_not_a_crash() {
    let cache = Cache::open_at(&temp_cache_dir("corrupt")).expect("cache opens");
    let key = "c".repeat(64);
    cache.store_ref().raw_insert(&key, b"{not json");
    assert!(cache.get(&key).is_none());
}

#[test]
fn legacy_json_files_are_removed_on_open() {
    let dir = temp_cache_dir("legacy");
    std::fs::create_dir_all(&dir).unwrap();
    std::fs::write(dir.join("deadbeef.json"), b"{}").unwrap();
    std::fs::write(dir.join("keepme.txt"), b"x").unwrap();
    Cache::open_at(&dir).expect("cache opens");
    assert!(!dir.join("deadbeef.json").exists(), "legacy entry removed");
    assert!(dir.join("keepme.txt").exists(), "non-json untouched");
}

#[test]
fn file_key_separates_adjacent_variable_fields() {
    let cache = Cache::open_at(&temp_cache_dir("keysep")).expect("cache opens");
    let path = Path::new("a.rb");
    let body = b"x = 1\n";
    let fp = [0u8; 32];
    let a = CacheSettings {
        only: "ab",
        except: "c",
        ignore_disable: false,
        force_default_config: false,
        rubocop_version: "",
        config_fingerprint: &fp,
    };
    let b = CacheSettings {
        only: "a",
        except: "bc",
        ignore_disable: false,
        force_default_config: false,
        rubocop_version: "",
        config_fingerprint: &fp,
    };
    assert_ne!(
        cache.file_key(path, body, a),
        cache.file_key(path, body, b),
        "length-prefix must disambiguate only/except split"
    );
}