routecore 0.7.1

use core::hash::Hash;
use core::str::FromStr;
use std::cmp;
use std::fmt::{self, Debug};


use crate::typeenum; // from util::macros

#[cfg(feature = "serde")]
use serde::{Serialize, Deserialize};

// notes:
// - move in and adapt all remaining stuff from bgp/message/nlri.rs
// - can we do PartialEq impls in macro?
// - eventually rename this to bgp/nlri.rs ?
// - remove bgp/message/nlri.rs  
// - pub use Afi/Nlri/etc from bgp::types 
// - clean up / remove bgp/workshop/afisafi_nlri.rs 

use inetnum::addr::Prefix;
use super::common::{compose_len_prefix, compose_prefix, parse_v4_prefix, parse_v6_prefix};
use super::common::{PathId, prefix_bits_to_bytes};
use crate::util::parser::ParseError;
use paste::paste;


use octseq::{Octets, OctetsBuilder, Parser};

use super::evpn::*;
use super::flowspec::*;
use super::mpls::*;
use super::mpls_vpn::*;
use super::routetarget::*;
use super::vpls::*;

// The addpath! macro creates Addpath versions of Nlri types.
//
// Because some Nlri types are generic over Octets, the 'first part' of the
// macro is split up. This way we can derive more traits (most notably, Copy)
// on the simpler AddpathNlri.
// After this 'first part' where the structs are generated, both patterns call
// the generic pattern via `addpath!(@generic $nlri)` to generate all the
// other parts which are not hindered by the optional generic Octs parameter.

macro_rules! addpath {
    ($nlri:ident ) => { paste! {
    #[derive(Copy, Clone, Debug, Hash, PartialEq, Ord, PartialOrd)]
    #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
    #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
    pub struct [<$nlri AddpathNlri>](PathId, [<$nlri Nlri>]);
    impl AfiSafiNlri for [<$nlri AddpathNlri>] {
        type Nlri = <[<$nlri Nlri>] as AfiSafiNlri>::Nlri;
        fn nlri(&self) -> &Self::Nlri {
            &self.1.nlri()
        }
    }

    addpath!(@generic $nlri);

    }};

    ($nlri:ident <$gen:ident>) => { paste! {
    #[allow(clippy::derived_hash_with_manual_eq)]
    #[derive(Clone, Debug, Hash)]
    #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
    #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
    pub struct [<$nlri AddpathNlri>]<$gen>(PathId, [<$nlri Nlri>]<$gen>);
    impl<$gen> AfiSafiNlri for [<$nlri AddpathNlri>]<$gen> {
        type Nlri = <[<$nlri Nlri>]<$gen> as AfiSafiNlri>::Nlri;
        fn nlri(&self) -> &Self::Nlri {
            &self.1.nlri()
        }
    }

    impl<$gen: AsRef<[u8]>> Ord for [<$nlri AddpathNlri>]<$gen> {
        fn cmp(&self, other: &Self) -> cmp::Ordering {
            self.1.cmp(&other.1).then(self.0.cmp(&other.0))
        }
    }
    impl<$gen: AsRef<[u8]>> PartialOrd for [<$nlri AddpathNlri>]<$gen> {
        fn partial_cmp(&self, other: &Self) -> Option<cmp::Ordering> {
            Some(self.cmp(&other))
        }
    }

    addpath!(@generic $nlri<$gen>);

    }};

    (@generic $nlri:ident $(<$gen:ident>)?) => { paste! {

    impl$(<$gen>)? AfiSafi for [<$nlri AddpathNlri>]$(<$gen>)? {
        fn afi() -> Afi { <[<$nlri Nlri>]$(<$gen>)? as AfiSafi>::afi() }
        fn afi_safi() -> AfiSafiType { <[<$nlri Nlri>]$(<$gen>)? as AfiSafi>::afi_safi() }
    }

    impl<'a, Octs, P> NlriParse<'a, Octs, P> for [<$nlri AddpathNlri>]$(<$gen>)?
    where
        Octs: Octets,
        P: 'a + Octets<Range<'a> = Octs>
    {
        type Output = Self;
        fn parse(parser: &mut Parser<'a, P>) -> Result<Self::Output, ParseError> {
            let path_id = PathId(parser.parse_u32_be()?);
            let inner = [<$nlri Nlri>]::parse(parser)?;
            Ok(
                Self(path_id, inner)
            )
        }
    }

    impl$(<$gen>)? NlriCompose for [<$nlri AddpathNlri>]$(<$gen>)?
    $(where 
        $gen: AsRef<[u8]>
    )?
    {
        fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
            -> Result<(), Target::AppendError>
        {
                target.append_slice(&self.0.0.to_be_bytes())?;
                self.1.compose(target)
        }

        fn compose_len(&self) -> usize {
            4 + self.1.compose_len()
        }
    }

    impl$(<$gen>)? IsNlri for [<$nlri AddpathNlri>]$(<$gen>)? { 
        fn nlri_type() -> NlriType {
            NlriType::[<$nlri Addpath>]
        }
    }

    impl$(<$gen>)? Addpath for [<$nlri AddpathNlri>]$(<$gen>)? {
        fn path_id(&self) -> PathId {
            self.0
        }
    }

    impl$(<$gen: AsRef<[u8]>>)? Eq for [<$nlri AddpathNlri>]$(<$gen>)? { }

    impl$(<$gen>)? fmt::Display for [<$nlri AddpathNlri>]$(<$gen>)? {
        fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
            write!(f, "[{}] ", self.0)?;
            fmt::Display::fmt(&self.1, f)
        }
    }
    }};
}

// For Nlri generic over anything, use <Octs> literally. Using another name,
// e.g. <O>, does not work. This is a limitation of the macro.
macro_rules! afisafi {
    (
        $(
            $afi_code:expr => $afi_name:ident [ $( $safi_code:expr => $safi_name:ident$(<$gen:ident>)? ),+ $(,)* ]
        ),+ $(,)*
    ) =>
{
    typeenum!(
        /// AFI as used in BGP OPEN and UPDATE messages.
        #[cfg_attr(feature = "serde", serde(from = "u16"))]
        Afi, u16,
        {
            $($afi_code => $afi_name),+
        });

paste! {
    #[derive(Clone, Copy, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)]
    #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
    #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
    pub enum AfiSafiType {
        $( $( [<$afi_name $safi_name>] ,)+)+
        Unsupported(u16, u8),
    }

    impl From<(u16, u8)> for AfiSafiType {
        fn from(t: (u16, u8)) -> Self {
            match t {
            $($(
                ($afi_code, $safi_code) => Self::[<$afi_name $safi_name>],
            )+)+
                _ => Self::Unsupported(t.0, t.1)
            }
        }
    }

    impl From<AfiSafiType> for (u16, u8) {
        fn from(afisafi: AfiSafiType) -> (u16, u8) {
            match afisafi {
            $($(
                AfiSafiType::[<$afi_name $safi_name>] => ($afi_code, $safi_code),
            )+)+
                AfiSafiType::Unsupported(a, s) => (a, s)
            }
        }
    }

    impl AfiSafiType {
        pub const fn afi(self) -> Afi {
            match self {
            $($(
                Self::[<$afi_name $safi_name>] => Afi::$afi_name,
            )+)+
                Self::Unsupported(a, _s) => Afi::Unimplemented(a)
            }
        }

        pub const fn as_bytes(self) -> [u8; 3] {
            match self {
            $($(
                Self::[<$afi_name $safi_name>] => {
                    let afi = $afi_code.to_be_bytes();
                    [afi[0], afi[1], $safi_code]
                }
            )+)+
                AfiSafiType::Unsupported(a, s) => {
                    let afi = a.to_be_bytes();
                    [afi[0], afi[1], s]
                }
            }
        }
    }


    impl fmt::Display for AfiSafiType {
        fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
            match self {
            $($(
                Self::[<$afi_name $safi_name>] => {
                    write!(f, stringify!([<$afi_name $safi_name>]))
                }
            )+)+
                Self::Unsupported(a, s) => {
                    write!(f, "UnsupportedAfiSafi({}, {})", a, s)
                }
            }
        }
    }

    // this enforces these derives on all *Nlri structs.
    #[derive(Clone, Debug, Hash)]
    #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
    #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
    pub enum Nlri<Octs> {
    $($(
        [<$afi_name $safi_name>]([<$afi_name $safi_name Nlri>]$(<$gen>)?),
        [<$afi_name $safi_name Addpath>]([<$afi_name $safi_name AddpathNlri>]$(<$gen>)?)
    ,)+)+
    }

    impl<Octs> Nlri<Octs> {
        pub const fn afi_safi(&self) -> AfiSafiType {
            match self {
            $($(
                Self::[<$afi_name $safi_name>](..) => AfiSafiType::[<$afi_name $safi_name >],
                Self::[<$afi_name $safi_name Addpath>](..) => AfiSafiType::[<$afi_name $safi_name >],
            )+)+
            }
        }

        pub const fn nlri_type(&self) -> NlriType {
            match self {
            $($(
                Self::[<$afi_name $safi_name>](..) => NlriType::[<$afi_name $safi_name >],
                Self::[<$afi_name $safi_name Addpath>](..) => NlriType::[<$afi_name $safi_name Addpath>],
            )+)+
            }
        }
    }

    impl<Octs> Nlri<Octs>
    where
        Octs: AsRef<[u8]>
    {
        pub fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
            -> Result<(), Target::AppendError> {
            match self {
            $($(
                Nlri::[<$afi_name $safi_name>](n) => n.compose(target),
                Nlri::[<$afi_name $safi_name Addpath>](n) => n.compose(target),
            )+)+
            }
        }
    }


    impl<Octs, Other> PartialEq<Nlri<Other>> for Nlri<Octs>
    where Octs: AsRef<[u8]>,
          Other: AsRef<[u8]>
    {
        fn eq(&self, other: &Nlri<Other>) -> bool {
            match (self, other) {
            $($(
                (Nlri::[<$afi_name $safi_name>](p1), Nlri::[<$afi_name $safi_name>](p2)) => p1 == p2,
                (Nlri::[<$afi_name $safi_name Addpath>](p1), Nlri::[<$afi_name $safi_name Addpath>](p2)) => p1 == p2,
            )+)+
            _ => false
            }
        }
    }

    impl<Octs> Ord for Nlri<Octs>
    where Octs: AsRef<[u8]>
    {
        fn cmp(&self, other: &Nlri<Octs>) -> cmp::Ordering {
            match (self, other) {
            $($(
                (Nlri::[<$afi_name $safi_name>](p1), Nlri::[<$afi_name $safi_name>](p2)) => p1.cmp(p2),
                (Nlri::[<$afi_name $safi_name Addpath>](p1), Nlri::[<$afi_name $safi_name Addpath>](p2)) => p1.cmp(p2),
            )+)+
                (a, b) => a.nlri_type().cmp(&b.nlri_type()),
            }
        }
    }

    impl<T> fmt::Display for Nlri<T> {
        fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
            match self {
            $($(
                Self::[<$afi_name $safi_name>](i) => fmt::Display::fmt(i, f),
                Self::[<$afi_name $safi_name Addpath>](i) => {
                    fmt::Display::fmt(i, f)
                }
            )+)+
            }
        }
    }

    #[derive(Clone, Copy, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)]
    #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
    #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
    pub enum NlriType {
    $($(
        [<$afi_name $safi_name>],
        [<$afi_name $safi_name Addpath>],
    )+)+
        Unsupported(u16, u8),
    }

    impl NlriType {
        pub const fn afi_safi(&self) -> AfiSafiType {
            match self {
            $($(
                Self::[<$afi_name $safi_name>] => AfiSafiType::[<$afi_name $safi_name >],
                Self::[<$afi_name $safi_name Addpath>] => AfiSafiType::[<$afi_name $safi_name >],
            )+)+
                Self::Unsupported(a, s) => AfiSafiType::Unsupported(*a, *s)
            }
        }
    }


    impl From<(AfiSafiType, bool)> for NlriType {
        fn from(t: (AfiSafiType, bool)) -> Self {
            match (t.0, t.1) {
                $($(
                    (AfiSafiType::[<$afi_name $safi_name>], false) => NlriType::[<$afi_name $safi_name >],
                    (AfiSafiType::[<$afi_name $safi_name>], true)  => NlriType::[<$afi_name $safi_name Addpath>],
                )+)+
                    (AfiSafiType::Unsupported(a, s), _)  => NlriType::Unsupported(a, s),
            }
        }
    }

    impl From<NlriType> for AfiSafiType {
        fn from(n: NlriType) -> Self {
            n.afi_safi()
        }
    }


$($(
    // Instead of doing:
    //pub struct [<$afi_name $safi_name Nlri>];
    //
    // .. we rely on the impl below, forcing us to actually create the
    // $Afi$SafiNlri struct, along with all its basic or exotic data fields
    // and whatnot. We can not do that in a generic way in this macro.
    impl$(<$gen>)? AfiSafi for [<$afi_name $safi_name Nlri>]$(<$gen>)? { 
        fn afi() -> Afi { Afi::$afi_name }
        fn afi_safi() -> AfiSafiType {
            AfiSafiType::[<$afi_name $safi_name>]
        }
    }

    impl$(<$gen>)? IsNlri for [<$afi_name $safi_name Nlri>]$(<$gen>)? { 
        fn nlri_type() -> NlriType {
            NlriType::[<$afi_name $safi_name>]
        }
    }

    impl$(<$gen>)? fmt::Display for [<$afi_name $safi_name Nlri>]$(<$gen>)?
    where <[<$afi_name $safi_name Nlri>]$(<$gen>)? as AfiSafiNlri>::Nlri: fmt::Display {
        fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
            write!(f, "{}", self.nlri())
        }
    }

    impl<Octs> From<[<$afi_name $safi_name Nlri>]$(<$gen>)?> for Nlri<Octs> {
        fn from(n: [<$afi_name $safi_name Nlri>]$(<$gen>)?) -> Self {
            Nlri::[<$afi_name $safi_name>](n)
        }
    }

    impl<Octs> From<[<$afi_name $safi_name AddpathNlri>]$(<$gen>)?> for Nlri<Octs> {
        fn from(n: [<$afi_name $safi_name AddpathNlri>]$(<$gen>)?) -> Self {
            Nlri::[<$afi_name $safi_name Addpath>](n)
        }
    }

    impl$(<$gen>)? From<[<$afi_name $safi_name AddpathNlri>]$(<$gen>)?> for [<$afi_name $safi_name Nlri>]$(<$gen>)? {
        fn from(n: [<$afi_name $safi_name AddpathNlri>]$(<$gen>)?) -> Self {
            n.1
        }
    }

    impl$(<$gen: AsRef<[u8]>>)? Eq for [<$afi_name $safi_name Nlri>]$(<$gen>)? { }

    //--- NlriIter

    impl<'a, Octs, P> NlriIter<'a, Octs, P, [<$afi_name $safi_name Nlri>]$(<$gen>)?>
    where
        Octs: Octets,
        P: Octets<Range<'a> = Octs>
    {
        pub const fn [<$afi_name:lower _ $safi_name:lower>](parser: Parser<'a, P>) -> Self {
            NlriIter::<'a, Octs, P, [<$afi_name $safi_name Nlri>]$(<$gen>)?>::new(parser)
        }
    }

    impl<'a, Octs, P> NlriIter<'a, Octs, P, [<$afi_name $safi_name AddpathNlri>]$(<$gen>)?>
    where
        Octs: Octets,
        P: Octets<Range<'a> = Octs>
    {
        pub const fn [<$afi_name:lower _ $safi_name:lower _ addpath>](parser: Parser<'a, P>) -> Self {
            NlriIter::<'a, Octs, P, [<$afi_name $safi_name AddpathNlri>]$(<$gen>)?>::new(parser)
        }
    }

    // Some attempts to add fn iter() to the Nlri structs below.
    // Problem is that we can only act on _presence_ of $gen , but not on its
    // absence. So when we have the <Octs> on the struct, the fn iter can not
    // define it again, though we need it there for the non <Octs> structs.
    
    /*
    impl [<$afi_name $safi_name Nlri>]  {
        pub fn iter1<'a, Octs, P>(parser: Parser<'a, P>) -> NlriIter<'a, Octs, P, Self>
        where
            Octs: Octets,
            P: 'a + Octets<Range<'a> = Octs>
        {
            NlriIter::[<$afi_name:lower _ $safi_name:lower>](parser)
        }
    }
    */

    /*
    // <Octs> structs only
    $(
    impl<$gen> [<$afi_name $safi_name Nlri>]<$gen>  {
        pub fn iter2<'a, P>(parser: Parser<'a, P>) -> NlriIter<'a, Octs, P, Self>
        where
            Octs: Octets,
            P: 'a + Octets<Range<'a> = Octs>
        {
            NlriIter::[<$afi_name:lower _ $safi_name:lower>](parser)
        }
    }
    )?
    */

    impl$(<$gen>)?  [<$afi_name $safi_name Nlri>]$(<$gen>)?  {
        pub const fn into_addpath(self, path_id: PathId) -> [<$afi_name $safi_name AddpathNlri>]$(<$gen>)? {
            [<$afi_name $safi_name AddpathNlri>](path_id, self)
        }
    }

    // Create the Addpath version
    addpath!([<$afi_name $safi_name>]$(<$gen>)?);
)+)+

}}
}

//--- Trait implementations for macro generated types

impl<Octs: AsRef<[u8]>> Eq for Nlri<Octs> {}

impl<Octs> PartialOrd for Nlri<Octs>
where Octs: AsRef<[u8]>,
{
    fn partial_cmp(&self, other: &Nlri<Octs>) -> Option<cmp::Ordering> {
        Some(self.cmp(other))
    }
}


// While Nlri<()> might make more sense, it clashes with trait bounds
// like Vec<u8>: OctetsFrom<T> elsewhere, as, From<()> is not implemented for
// Vec<u8>. Similarly, () is not AsRef<[u8]>.
impl Nlri<&[u8]> {
    /// Creates a `Nlri::Unicast` for `prefix`.
    ///
    /// This returns the error thrown by `Prefix::from_str` if `prefix` does
    /// not represent a valid IPv6 or IPv4 prefix.
    pub fn unicast_from_str(prefix: &str)
        -> Result<Nlri<&[u8]>, <Prefix as FromStr>::Err>
    {
        let p = Prefix::from_str(prefix)?;
        if p.is_v4() {
            Ok(Nlri::Ipv4Unicast(Ipv4UnicastNlri(p)))
        } else {
            Ok(Nlri::Ipv6Unicast(Ipv6UnicastNlri(p)))
        }
    }
}

//------------ Traits ---------------------------------------------------------

/// A type characterized by an AFI and SAFI.
pub trait AfiSafi {
    fn afi() -> Afi;
    fn afi_safi() -> AfiSafiType;
}

pub trait IsNlri {
    fn nlri_type() -> NlriType;
}

/// A type representing an NLRI for a certain AFI+SAFI.
pub trait AfiSafiNlri: AfiSafi + IsNlri { // + Clone + Hash + Debug {
    type Nlri;
    fn nlri(&self) -> &Self::Nlri;

    // TODO
    //fn nexthop_compatible(&self, nh: &super::nexthop::NextHop) -> bool;
}

pub trait NlriParse<'a, O, P>: Sized + IsNlri
    where P: 'a + Octets<Range<'a> = O>
{
    type Output: AfiSafi;
    fn parse(parser: &mut Parser<'a, P>) -> Result<Self::Output, ParseError>;
}

pub trait NlriCompose: AfiSafiNlri {
    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError>;

    fn compose_len(&self) -> usize;
}


/// A type containing nothing more than a (v4 or v6) Prefix.
pub trait IsPrefix: AfiSafiNlri {
    fn prefix(&self) -> Prefix;
    
    fn path_id(&self) -> Option<PathId> {
        None
    }
}

// with this blanket impl we can't distinguish addpath from non-addpath
/*
impl <T, B>IsPrefix for T where T: AfiSafiNlri<Nlri = B>, B: Into<Prefix> {
    fn prefix(&self) -> Prefix {
        self.nlri().into()
    }
}
*/

macro_rules! is_prefix {
    ($nlri:ident) => { paste! {
        impl IsPrefix for [<$nlri Nlri>] {
            fn prefix(&self) -> Prefix {
                (*self.nlri()).into()
            }
        }
        impl IsPrefix for [<$nlri AddpathNlri>] {
            fn prefix(&self) -> Prefix {
                (*self.nlri()).into()
            }
            fn path_id(&self) -> Option<PathId> {
                Some(<Self as Addpath>::path_id(&self))
            }
        }
    }}
}
is_prefix!(Ipv4Unicast);
is_prefix!(Ipv4Multicast);
is_prefix!(Ipv6Unicast);
is_prefix!(Ipv6Multicast);

/// An Nlri containing a Path Id.
pub trait Addpath: AfiSafiNlri {
    fn path_id(&self) -> PathId;
}


//------------ Implementations -----------------------------------------------

// adding AFI/SAFIs here requires some manual labor:
// - at the least, add a struct for $Afi$SafiNlri , deriving Clone,Debug,Hash
// - impl AfiSafiNlri, NlriParse and Display

afisafi! {
    1_u16 => Ipv4 [
        1 => Unicast,
        2 => Multicast,
        4 => MplsUnicast<Octs>,
        128 => MplsVpnUnicast<Octs>,
        132 => RouteTarget<Octs>,
        133 => FlowSpec<Octs>,
        //134 => FlowSpecVpn<Octs>,

    ],
    2_u16 => Ipv6 [
        1 => Unicast,
        2 => Multicast,
        4 => MplsUnicast<Octs>,
        128 => MplsVpnUnicast<Octs>,
        133 => FlowSpec<Octs>,
        //134 => FlowSpecVpn<Octs>,
    ],
    25_u16 => L2Vpn [
        65 => Vpls,
        70 => Evpn<Octs>,
    ]
}


//------------ Ipv4 ----------------------------------------------------------


// --- Ipv4Unicast

#[derive(Copy, Clone, Debug, Hash, PartialEq, Ord, PartialOrd)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Ipv4UnicastNlri(Prefix);

impl AfiSafiNlri for Ipv4UnicastNlri {
    type Nlri = Prefix;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl FromStr for Ipv4UnicastNlri {
    type Err = &'static str;
    fn from_str(s: &str) -> Result<Self, Self::Err> {
        let p = Prefix::from_str(s).map_err(|_| "could not parse prefix")?;
        p.try_into()
    }
}

impl TryFrom<Prefix> for Ipv4UnicastNlri {
    type Error = &'static str;
    fn try_from(p: Prefix) -> Result<Self, Self::Error> {
        if p.is_v4() {
            Ok( Self(p) )
        } else {
            Err("prefix is not IPv4")
        }
    }
}

impl TryFrom<(Prefix, PathId)> for Ipv4UnicastAddpathNlri {
    type Error = &'static str;

    fn try_from((prefix, path_id): (Prefix, PathId)) -> Result<Self, Self::Error> {
        Ok(Ipv4UnicastNlri::try_from(prefix)?.into_addpath(path_id))
    }
}


impl<'a, O, P> NlriParse<'a, O, P> for Ipv4UnicastNlri
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;
    fn parse(parser: &mut Parser<'a, P>) -> Result<Self::Output, ParseError> {
        Ok(
            Self(parse_v4_prefix(parser)?)
        )
    }
}

impl NlriCompose for Ipv4UnicastNlri {
    fn compose_len(&self) -> usize {
        // 1 byte for the length itself
        1 + compose_len_prefix(self.prefix())
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError>
    {
        compose_prefix(self.prefix(), target)
    }
}

//--- Ipv4Multicast

#[derive(Copy, Clone, Debug, Hash, PartialEq, Ord, PartialOrd)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Ipv4MulticastNlri(Prefix);

impl AfiSafiNlri for Ipv4MulticastNlri {
    type Nlri = Prefix;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl FromStr for Ipv4MulticastNlri {
    type Err = &'static str;
    fn from_str(s: &str) -> Result<Self, Self::Err> {
        let p = Prefix::from_str(s).map_err(|_| "err")?;
        p.try_into()
    }
}

impl TryFrom<Prefix> for Ipv4MulticastNlri {
    type Error = &'static str;
    fn try_from(p: Prefix) -> Result<Self, Self::Error> {
        if p.is_v4() {
            Ok( Self(p) )
        } else {
            Err("prefix is not IPv4")
        }
    }
}

impl TryFrom<(Prefix, PathId)> for Ipv4MulticastAddpathNlri {
    type Error = &'static str;

    fn try_from((prefix, path_id): (Prefix, PathId)) -> Result<Self, Self::Error> {
        Ok(Ipv4MulticastNlri::try_from(prefix)?.into_addpath(path_id))
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for Ipv4MulticastNlri
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;
    fn parse(parser: &mut Parser<'a, P>) -> Result<Self::Output, ParseError> {
        Ok(
            Self(parse_v4_prefix(parser)?)
        )
    }
}

impl NlriCompose for Ipv4MulticastNlri {
    fn compose_len(&self) -> usize {
        // 1 byte for the length itself
        1 + compose_len_prefix(self.prefix())
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError>
    {
        compose_prefix(self.prefix(), target)
    }
}

//--- Ipv4MplsUnicast

#[derive(Copy, Clone, Debug, Hash)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Ipv4MplsUnicastNlri<Octs>(MplsNlri<Octs>);

impl<Octs> AfiSafiNlri for Ipv4MplsUnicastNlri<Octs> {
    type Nlri = MplsNlri<Octs>;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for Ipv4MplsUnicastNlri<O>
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;

    fn parse(parser: &mut Parser<'a, P>)
        -> Result<Self::Output, ParseError>
    {
        Ok(
            Self(MplsNlri::parse(parser, Afi::Ipv4)?)
        )
    }
}

impl<Octs: AsRef<[u8]>> NlriCompose for Ipv4MplsUnicastNlri<Octs> {
    fn compose_len(&self) -> usize {
        // 1 byte for the length itself
        1 + self.nlri().compose_len()
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError> {
            self.nlri().compose(target)
    }
}

impl<Octs, Other> PartialEq<Ipv4MplsUnicastNlri<Other>> for Ipv4MplsUnicastNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv4MplsUnicastNlri<Other>) -> bool {
        self.0 == other.0
    }
}


impl<Octs, Other> PartialEq<Ipv4MplsUnicastAddpathNlri<Other>> for Ipv4MplsUnicastAddpathNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv4MplsUnicastAddpathNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs> PartialOrd for Ipv4MplsUnicastNlri<Octs>
where Octs: AsRef<[u8]>,
{
    fn partial_cmp(&self, other: &Ipv4MplsUnicastNlri<Octs>) -> Option<cmp::Ordering> {
        Some(self.cmp(other))
    }
}

impl<Octs: AsRef<[u8]>> Ord for Ipv4MplsUnicastNlri<Octs> {
    fn cmp(&self, other: &Self) -> cmp::Ordering {
        self.0.cmp(&other.0)
    }
}

//--- Ipv4MplsVpnUnicastNlri

#[derive(Copy, Clone, Debug, Hash)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Ipv4MplsVpnUnicastNlri<Octs>(MplsVpnNlri<Octs>);

impl<Octs> AfiSafiNlri for Ipv4MplsVpnUnicastNlri<Octs> {
    type Nlri = MplsVpnNlri<Octs>;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for Ipv4MplsVpnUnicastNlri<O>
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;

    fn parse(parser: &mut Parser<'a, P>)
        -> Result<Self::Output, ParseError>
    {
        let (labels, rd, prefix) =
            parse_labels_rd_prefix(parser, Afi::Ipv4)?;

        Ok(Self(MplsVpnNlri::new(prefix, labels, rd)))
    }
}

impl<Octs: AsRef<[u8]>> NlriCompose for Ipv4MplsVpnUnicastNlri<Octs> {
    fn compose_len(&self) -> usize {
        1 + self.nlri().compose_len()
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError> {
            self.nlri().compose(target)
    }
}

impl<Octs, Other> PartialEq<Ipv4MplsVpnUnicastNlri<Other>> for Ipv4MplsVpnUnicastNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv4MplsVpnUnicastNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs, Other> PartialEq<Ipv4MplsVpnUnicastAddpathNlri<Other>> for Ipv4MplsVpnUnicastAddpathNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv4MplsVpnUnicastAddpathNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs> PartialOrd for Ipv4MplsVpnUnicastNlri<Octs>
where Octs: AsRef<[u8]>,
{
    fn partial_cmp(&self, other: &Ipv4MplsVpnUnicastNlri<Octs>) -> Option<cmp::Ordering> {
        Some(self.cmp(other))
    }
}

impl<Octs: AsRef<[u8]>> Ord for Ipv4MplsVpnUnicastNlri<Octs> {
    fn cmp(&self, other: &Self) -> cmp::Ordering {
        self.0.cmp(&other.0)
    }
}

//--- Ipv4RouteTarget

#[derive(Clone, Debug, Hash)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Ipv4RouteTargetNlri<Octs>(RouteTargetNlri<Octs>);

impl<Octs> AfiSafiNlri for Ipv4RouteTargetNlri<Octs> {
    type Nlri = RouteTargetNlri<Octs>;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for Ipv4RouteTargetNlri<O>
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;

    fn parse(parser: &mut Parser<'a, P>)
        -> Result<Self::Output, ParseError>
    {

        Ok(Self(RouteTargetNlri::parse(parser)?))
    }
}

impl<Octs: AsRef<[u8]>> NlriCompose for Ipv4RouteTargetNlri<Octs> {
    fn compose_len(&self) -> usize {
        self.nlri().compose_len()
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError> {
            self.nlri().compose(target)
    }
}

impl<Octs, Other> PartialEq<Ipv4RouteTargetNlri<Other>> for Ipv4RouteTargetNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv4RouteTargetNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs, Other> PartialEq<Ipv4RouteTargetAddpathNlri<Other>> for Ipv4RouteTargetAddpathNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv4RouteTargetAddpathNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs> PartialOrd for Ipv4RouteTargetNlri<Octs>
where Octs: AsRef<[u8]>,
{
    fn partial_cmp(&self, other: &Ipv4RouteTargetNlri<Octs>) -> Option<cmp::Ordering> {
        Some(self.cmp(other))
    }
}

impl<Octs: AsRef<[u8]>> Ord for Ipv4RouteTargetNlri<Octs> {
    fn cmp(&self, other: &Self) -> cmp::Ordering {
        self.0.cmp(&other.0)
    }
}

//--- Ipv4FlowSpec

#[derive(Clone, Debug, Hash)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Ipv4FlowSpecNlri<Octs>(FlowSpecNlri<Octs>);

impl<Octs> AfiSafiNlri for Ipv4FlowSpecNlri<Octs> {
    type Nlri = FlowSpecNlri<Octs>;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for Ipv4FlowSpecNlri<O>
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;

    fn parse(parser: &mut Parser<'a, P>)
        -> Result<Self::Output, ParseError>
    {

        Ok(Self(FlowSpecNlri::parse(parser, Afi::Ipv4)?))
    }
}

impl<Octs: AsRef<[u8]>> NlriCompose for Ipv4FlowSpecNlri<Octs> {
    fn compose_len(&self) -> usize {
        // for lenghts of >= 240, the lenght is described in two bytes
        let len = self.nlri().compose_len();
        if len >= 240 {
            2 + len
        } else {
            1 + len
        }
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError> {
            self.nlri().compose(target)
    }
}

impl<T> From<Ipv4FlowSpecNlri<T>> for FlowSpecNlri<T> {
    fn from(value: Ipv4FlowSpecNlri<T>) -> Self {
        value.0
    }
}

impl<Octs, Other> PartialEq<Ipv4FlowSpecNlri<Other>> for Ipv4FlowSpecNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv4FlowSpecNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs, Other> PartialEq<Ipv4FlowSpecAddpathNlri<Other>> for Ipv4FlowSpecAddpathNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv4FlowSpecAddpathNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs> PartialOrd for Ipv4FlowSpecNlri<Octs>
where Octs: AsRef<[u8]>,
{
    fn partial_cmp(&self, other: &Ipv4FlowSpecNlri<Octs>) -> Option<cmp::Ordering> {
        Some(self.cmp(other))
    }
}

impl<Octs: AsRef<[u8]>> Ord for Ipv4FlowSpecNlri<Octs> {
    fn cmp(&self, other: &Self) -> cmp::Ordering {
        self.0.cmp(&other.0)
    }
}

//------------ Ipv6 ----------------------------------------------------------

//--- Ipv6Unicast

#[derive(Copy, Clone, Debug, Hash, PartialEq, Ord, PartialOrd)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Ipv6UnicastNlri(Prefix);
impl AfiSafiNlri for Ipv6UnicastNlri {
    type Nlri = Prefix;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl FromStr for Ipv6UnicastNlri {
    type Err = &'static str;
    fn from_str(s: &str) -> Result<Self, Self::Err> {
        let p = Prefix::from_str(s).map_err(|_| "could not parse prefix")?;
        p.try_into()
    }
}

impl TryFrom<Prefix> for Ipv6UnicastNlri {
    type Error = &'static str;
    fn try_from(p: Prefix) -> Result<Self, Self::Error> {
        if p.is_v6() {
            Ok( Self(p) )
        } else {
            Err("prefix is not IPv6")
        }
    }
}

impl TryFrom<(Prefix, PathId)> for Ipv6UnicastAddpathNlri {
    type Error = &'static str;

    fn try_from((prefix, path_id): (Prefix, PathId)) -> Result<Self, Self::Error> {
        Ok(Ipv6UnicastNlri::try_from(prefix)?.into_addpath(path_id))
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for Ipv6UnicastNlri
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;
    fn parse(parser: &mut Parser<'a, P>) -> Result<Self::Output, ParseError> {
        Ok(
            Self(parse_v6_prefix(parser)?)
        )
    }
}

impl NlriCompose for Ipv6UnicastNlri {
    fn compose_len(&self) -> usize {
        // 1 byte for the length itself
        1 + compose_len_prefix(self.prefix())
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError>
    {
        compose_prefix(self.prefix(), target)
    }
}

//--- Ipv6Multicast

#[derive(Copy, Clone, Debug, Hash, PartialEq, Ord, PartialOrd)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Ipv6MulticastNlri(Prefix);

impl FromStr for Ipv6MulticastNlri {
    type Err = &'static str;
    fn from_str(s: &str) -> Result<Self, Self::Err> {
        let p = Prefix::from_str(s).map_err(|_| "could not parse prefix")?;
        p.try_into()
    }
}

impl TryFrom<Prefix> for Ipv6MulticastNlri {
    type Error = &'static str;
    fn try_from(p: Prefix) -> Result<Self, Self::Error> {
        if p.is_v6() {
            Ok( Self(p) )
        } else {
            Err("prefix is not IPv6")
        }
    }
}

impl TryFrom<(Prefix, PathId)> for Ipv6MulticastAddpathNlri {
    type Error = &'static str;

    fn try_from((prefix, path_id): (Prefix, PathId)) -> Result<Self, Self::Error> {
        Ok(Ipv6MulticastNlri::try_from(prefix)?.into_addpath(path_id))
    }
}

impl AfiSafiNlri for Ipv6MulticastNlri {
    type Nlri = Prefix;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for Ipv6MulticastNlri
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;
    fn parse(parser: &mut Parser<'a, P>) -> Result<Self::Output, ParseError> {
        Ok(
            Self(parse_v6_prefix(parser)?)
        )
    }
}

impl NlriCompose for Ipv6MulticastNlri {
    fn compose_len(&self) -> usize {
        // 1 byte for the length itself
        1 + compose_len_prefix(self.prefix())
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError>
    {
        compose_prefix(self.prefix(), target)
    }
}

//--- Ipv6MplsUnicast

#[derive(Copy, Clone, Debug, Hash)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Ipv6MplsUnicastNlri<Octs>(MplsNlri<Octs>);

impl<Octs> AfiSafiNlri for Ipv6MplsUnicastNlri<Octs> {
    type Nlri = MplsNlri<Octs>;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for Ipv6MplsUnicastNlri<O>
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;

    fn parse(parser: &mut Parser<'a, P>)
        -> Result<Self::Output, ParseError>
    {
        Ok(
            Self(MplsNlri::parse(parser, Afi::Ipv6)?)
        )
    }
}

impl<Octs: AsRef<[u8]>> NlriCompose for Ipv6MplsUnicastNlri<Octs> {
    fn compose_len(&self) -> usize {
        // 1 byte for the length itself
        1 + self.nlri().labels().len() +
            prefix_bits_to_bytes(self.nlri().prefix().len())
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError> {
            self.nlri().compose(target)
    }
}

impl<Octs, Other> PartialEq<Ipv6MplsUnicastNlri<Other>> for Ipv6MplsUnicastNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv6MplsUnicastNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs, Other> PartialEq<Ipv6MplsUnicastAddpathNlri<Other>> for Ipv6MplsUnicastAddpathNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv6MplsUnicastAddpathNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs> PartialOrd for Ipv6MplsUnicastNlri<Octs>
where Octs: AsRef<[u8]>,
{
    fn partial_cmp(&self, other: &Ipv6MplsUnicastNlri<Octs>) -> Option<cmp::Ordering> {
        Some(self.cmp(other))
    }
}

impl<Octs: AsRef<[u8]>> Ord for Ipv6MplsUnicastNlri<Octs> {
    fn cmp(&self, other: &Self) -> cmp::Ordering {
        self.0.cmp(&other.0)
    }
}


//--- Ipv6MplsVpnUnicastNlri

#[derive(Clone, Debug, Hash)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Ipv6MplsVpnUnicastNlri<Octs>(MplsVpnNlri<Octs>);

impl<Octs> AfiSafiNlri for Ipv6MplsVpnUnicastNlri<Octs> {
    type Nlri = MplsVpnNlri<Octs>;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for Ipv6MplsVpnUnicastNlri<O>
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;

    fn parse(parser: &mut Parser<'a, P>)
        -> Result<Self::Output, ParseError>
    {
        let (labels, rd, prefix) =
            parse_labels_rd_prefix(parser, Afi::Ipv6)?;

        Ok(Self(MplsVpnNlri::new(prefix, labels, rd)))
    }
}

impl<Octs: AsRef<[u8]>> NlriCompose for Ipv6MplsVpnUnicastNlri<Octs> {
    fn compose_len(&self) -> usize {
        1 + self.nlri().compose_len()
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError> {
            self.nlri().compose(target)
    }
}


impl<Octs, Other> PartialEq<Ipv6MplsVpnUnicastNlri<Other>> for Ipv6MplsVpnUnicastNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv6MplsVpnUnicastNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs, Other> PartialEq<Ipv6MplsVpnUnicastAddpathNlri<Other>> for Ipv6MplsVpnUnicastAddpathNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv6MplsVpnUnicastAddpathNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs> PartialOrd for Ipv6MplsVpnUnicastNlri<Octs>
where Octs: AsRef<[u8]>,
{
    fn partial_cmp(&self, other: &Ipv6MplsVpnUnicastNlri<Octs>) -> Option<cmp::Ordering> {
        Some(self.cmp(other))
    }
}

impl<Octs: AsRef<[u8]>> Ord for Ipv6MplsVpnUnicastNlri<Octs> {
    fn cmp(&self, other: &Self) -> cmp::Ordering {
        self.0.cmp(&other.0)
    }
}

//--- Ipv6FlowSpec

#[derive(Clone, Debug, Hash)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Ipv6FlowSpecNlri<Octs>(FlowSpecNlri<Octs>);

impl<Octs> AfiSafiNlri for Ipv6FlowSpecNlri<Octs> {
    type Nlri = FlowSpecNlri<Octs>;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for Ipv6FlowSpecNlri<O>
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;

    fn parse(parser: &mut Parser<'a, P>)
        -> Result<Self::Output, ParseError>
    {

        Ok(Self(FlowSpecNlri::parse(parser, Afi::Ipv6)?))
    }
}

impl<Octs: AsRef<[u8]>> NlriCompose for Ipv6FlowSpecNlri<Octs> {
    fn compose_len(&self) -> usize {
        // for lenghts of >= 240, the lenght is described in two bytes
        let len = self.nlri().compose_len();
        if len >= 240 {
            2 + len
        } else {
            1 + len
        }
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError> {
            self.nlri().compose(target)
    }
}

impl<T> From<Ipv6FlowSpecNlri<T>> for FlowSpecNlri<T> {
    fn from(value: Ipv6FlowSpecNlri<T>) -> Self {
        value.0
    }
}

impl<Octs, Other> PartialEq<Ipv6FlowSpecNlri<Other>> for Ipv6FlowSpecNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv6FlowSpecNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs, Other> PartialEq<Ipv6FlowSpecAddpathNlri<Other>> for Ipv6FlowSpecAddpathNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &Ipv6FlowSpecAddpathNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs> PartialOrd for Ipv6FlowSpecNlri<Octs>
where Octs: AsRef<[u8]>,
{
    fn partial_cmp(&self, other: &Ipv6FlowSpecNlri<Octs>) -> Option<cmp::Ordering> {
        Some(self.cmp(other))
    }
}

impl<Octs: AsRef<[u8]>> Ord for Ipv6FlowSpecNlri<Octs> {
    fn cmp(&self, other: &Self) -> cmp::Ordering {
        self.0.cmp(&other.0)
    }
}

/*
impl Ipv6UnicastAddpathNlri {
    pub fn iter<'a, O, P>(parser: Parser<'a, P>) -> NlriIter<'a, O, P, Self>
    where
        O: Octets,
        P: 'a + Octets<Range<'a> = O>
    {
        NlriIter::ipv6_unicast_addpath(parser)
    }
}

impl<Octs> Ipv4MplsUnicastNlri<Octs> {
    pub fn iter<'a, P>(parser: Parser<'a, P>) -> NlriIter<'a, Octs, P, Self>
    where
        Octs: Octets,
        P: 'a + Octets<Range<'a> = Octs>
    {
        NlriIter::ipv4_mplsunicast(parser)
    }
}
*/

//------------ L2Vpn ----------------------------------------------------------

//--- L2VpnVpls

#[derive(Copy, Clone, Debug, Hash, PartialEq, Ord, PartialOrd)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct L2VpnVplsNlri(VplsNlri);

impl AfiSafiNlri for L2VpnVplsNlri {
    type Nlri = VplsNlri;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for L2VpnVplsNlri
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;

    fn parse(parser: &mut Parser<'a, P>)
        -> Result<Self::Output, ParseError>
    {

        Ok(Self(VplsNlri::parse(parser)?))
    }
}

impl NlriCompose for L2VpnVplsNlri {
    fn compose_len(&self) -> usize {
        self.nlri().compose_len()
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError> {
            self.nlri().compose(target)
    }
}

//--- Evpn

#[derive(Clone, Debug, Hash)]
#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct L2VpnEvpnNlri<Octs>(EvpnNlri<Octs>);

impl<Octs> AfiSafiNlri for L2VpnEvpnNlri<Octs> {
    type Nlri = EvpnNlri<Octs>;
    fn nlri(&self) -> &Self::Nlri {
        &self.0
    }
}

impl<'a, O, P> NlriParse<'a, O, P> for L2VpnEvpnNlri<O>
where
    O: Octets,
    P: 'a + Octets<Range<'a> = O>
{
    type Output = Self;

    fn parse(parser: &mut Parser<'a, P>)
        -> Result<Self::Output, ParseError>
    {

        Ok(Self(EvpnNlri::parse(parser)?))
    }
}

impl<Octs: AsRef<[u8]>> NlriCompose for L2VpnEvpnNlri<Octs> {
    fn compose_len(&self) -> usize {
        // EPVN uses typed NLRI with embedded the length field 
        self.nlri().compose_len()
    }

    fn compose<Target: OctetsBuilder>(&self, target: &mut Target)
        -> Result<(), Target::AppendError> {
            self.nlri().compose(target)
    }
}

impl<Octs, Other> PartialEq<L2VpnEvpnNlri<Other>> for L2VpnEvpnNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &L2VpnEvpnNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs, Other> PartialEq<L2VpnEvpnAddpathNlri<Other>> for L2VpnEvpnAddpathNlri<Octs>
where Octs: AsRef<[u8]>,
      Other: AsRef<[u8]>
{
    fn eq(&self, other: &L2VpnEvpnAddpathNlri<Other>) -> bool {
        self.0 == other.0
    }
}

impl<Octs> PartialOrd for L2VpnEvpnNlri<Octs>
where Octs: AsRef<[u8]>,
{
    fn partial_cmp(&self, other: &L2VpnEvpnNlri<Octs>) -> Option<cmp::Ordering> {
        Some(self.cmp(other))
    }
}

impl<Octs: AsRef<[u8]>> Ord for L2VpnEvpnNlri<Octs> {
    fn cmp(&self, other: &Self) -> cmp::Ordering {
        self.0.cmp(&other.0)
    }
}

//------------ Iteration ------------------------------------------------------

// Iterating over NLRI likely mostly happens when ingesting UPDATE PDUs, i.e.
// one or more (possibly >1000) NLRI of one single AfiSafiType. We therefore
// want type specific iterators, yielding exact types (e.g. Ipv6UnicastNlri)
// instead of the Nlri enum, as that would require the user to match/unpack
// every single item returned by next() (which would/should always be of the
// same type, anyway).
//
// For convenience or whatever other use cases, we might still want to provide
// an iterator yielding variants of the Nlri enum, probably based on the
// type-specific ones.
// Because of the From impls generated in the macro call, we can already do:
//
//     NlriIter::ipv4_mplsunicast(parser).map(Nlri::<_>::from)
//
// .. to turn a specific iterator into a generic one, returning the Nlri enum
// type.
//
// Seems that creating the convenience constructors involves a lot of typy
// typy which could also become part of the afisafi! macro.


pub struct NlriIter<'a, O, P, ASP> {
    parser: Parser<'a, P>,
    asp: std::marker::PhantomData<ASP>,
    output: std::marker::PhantomData<O>,
}

impl<'a, O, P, ASP> NlriIter<'a, O, P, ASP>
where
    O: Octets,
    P: Octets<Range<'a> = O>,
    ASP: NlriParse<'a, O, P>
{
    pub const fn new(parser: Parser<'a, P>) -> Self {
        NlriIter {
            parser,
            asp: std::marker::PhantomData,
            output: std::marker::PhantomData
        }
    }

    pub fn afi_safi(&self) -> AfiSafiType {
        ASP::Output::afi_safi()
    }

    pub fn nlri_type(&self) -> NlriType {
        ASP::nlri_type()
    }

    // Validate the entire parser so we can safely return items from this
    // iterator, instead of returning Option<Result<Nlri>, ParseError>
    //
    pub fn validate(&self) -> Result<(), ParseError> {
        let mut parser = self.parser;
        while parser.remaining() > 0 {
            // TODO replace this ::parse with a cheaper ::check, if available
            ASP::parse(&mut parser)?;
        }
        Ok(())
    }
}


impl<'a, O, P, ASP: NlriParse<'a, O, P>> Iterator for NlriIter<'a, O, P, ASP>
where 
    P: Octets<Range<'a> = O>
{
    type Item = Result<ASP::Output, ParseError>;

    fn next(&mut self) -> Option<Self::Item> {
        if self.parser.remaining() == 0 {
            return None;
        }
        Some(ASP::parse(&mut self.parser))
    }
}

/// Generic iterator returning Nlri enum variants instead of specific Nlri
/// structs.
pub struct NlriEnumIter<'a, P> {
    parser: Parser<'a, P>,
    ty: NlriType,
}

impl<'a, P> NlriEnumIter<'a, P> {
    pub const fn new(parser: Parser<'a, P>, ty: NlriType) -> Self {
        Self { parser, ty }
    }

    pub const fn nlri_type(&self) -> NlriType {
        self.ty
    }

    pub const fn afi_safi(&self) -> AfiSafiType {
        self.ty.afi_safi()
    }
}

impl<'a, O, P> Iterator for NlriEnumIter<'a, P>
where 
    O: Octets,
    P: Octets<Range<'a> = O>,
{
    type Item = Result<Nlri<O>, ParseError>;

    fn next(&mut self) -> Option<Self::Item> {
        if self.parser.remaining() == 0 {
            return None
        }
        
        let res = match self.ty {
            NlriType::Ipv4Unicast => Ipv4UnicastNlri::parse(&mut self.parser).map(Nlri::Ipv4Unicast),
            NlriType::Ipv4UnicastAddpath => Ipv4UnicastAddpathNlri::parse(&mut self.parser).map(Nlri::Ipv4UnicastAddpath),
            NlriType::Ipv4Multicast => Ipv4MulticastNlri::parse(&mut self.parser).map(Nlri::Ipv4Multicast),
            NlriType::Ipv4MulticastAddpath => Ipv4MulticastAddpathNlri::parse(&mut self.parser).map(Nlri::Ipv4MulticastAddpath),
            NlriType::Ipv4MplsUnicast => Ipv4MplsUnicastNlri::parse(&mut self.parser).map(Nlri::Ipv4MplsUnicast),
            NlriType::Ipv4MplsUnicastAddpath => Ipv4MplsUnicastAddpathNlri::parse(&mut self.parser).map(Nlri::Ipv4MplsUnicastAddpath),
            NlriType::Ipv4MplsVpnUnicast => Ipv4MplsVpnUnicastNlri::parse(&mut self.parser).map(Nlri::Ipv4MplsVpnUnicast),
            NlriType::Ipv4MplsVpnUnicastAddpath => Ipv4MplsVpnUnicastAddpathNlri::parse(&mut self.parser).map(Nlri::Ipv4MplsVpnUnicastAddpath),
            NlriType::Ipv4RouteTarget => Ipv4RouteTargetNlri::parse(&mut self.parser).map(Nlri::Ipv4RouteTarget),
            NlriType::Ipv4RouteTargetAddpath => Ipv4RouteTargetAddpathNlri::parse(&mut self.parser).map(Nlri::Ipv4RouteTargetAddpath),
            NlriType::Ipv4FlowSpec => Ipv4FlowSpecNlri::parse(&mut self.parser).map(Nlri::Ipv4FlowSpec),
            NlriType::Ipv4FlowSpecAddpath => Ipv4FlowSpecAddpathNlri::parse(&mut self.parser).map(Nlri::Ipv4FlowSpecAddpath),
            NlriType::Ipv6Unicast => Ipv6UnicastNlri::parse(&mut self.parser).map(Nlri::Ipv6Unicast),
            NlriType::Ipv6UnicastAddpath => Ipv6UnicastAddpathNlri::parse(&mut self.parser).map(Nlri::Ipv6UnicastAddpath),
            NlriType::Ipv6Multicast => Ipv6MulticastNlri::parse(&mut self.parser).map(Nlri::Ipv6Multicast),
            NlriType::Ipv6MulticastAddpath => Ipv6MulticastAddpathNlri::parse(&mut self.parser).map(Nlri::Ipv6MulticastAddpath),
            NlriType::Ipv6MplsUnicast => Ipv6MplsUnicastNlri::parse(&mut self.parser).map(Nlri::Ipv6MplsUnicast),
            NlriType::Ipv6MplsUnicastAddpath => Ipv6MplsUnicastAddpathNlri::parse(&mut self.parser).map(Nlri::Ipv6MplsUnicastAddpath),
            NlriType::Ipv6MplsVpnUnicast => Ipv6MplsVpnUnicastNlri::parse(&mut self.parser).map(Nlri::Ipv6MplsVpnUnicast),
            NlriType::Ipv6MplsVpnUnicastAddpath => Ipv6MplsVpnUnicastAddpathNlri::parse(&mut self.parser).map(Nlri::Ipv6MplsVpnUnicastAddpath),
            NlriType::Ipv6FlowSpec => Ipv6FlowSpecNlri::parse(&mut self.parser).map(Nlri::Ipv6FlowSpec),
            NlriType::Ipv6FlowSpecAddpath => Ipv6FlowSpecAddpathNlri::parse(&mut self.parser).map(Nlri::Ipv6FlowSpecAddpath),
            NlriType::L2VpnVpls => L2VpnVplsNlri::parse(&mut self.parser).map(Nlri::L2VpnVpls),
            NlriType::L2VpnVplsAddpath => L2VpnVplsAddpathNlri::parse(&mut self.parser).map(Nlri::L2VpnVplsAddpath),
            NlriType::L2VpnEvpn => L2VpnEvpnNlri::parse(&mut self.parser).map(Nlri::L2VpnEvpn),
            NlriType::L2VpnEvpnAddpath => L2VpnEvpnAddpathNlri::parse(&mut self.parser).map(Nlri::L2VpnEvpnAddpath),
            NlriType::Unsupported(..) => { return None; }
        };

        Some(res)
    }
}

impl<'a, O, P, ASP> From<NlriIter<'a, O, P, ASP>> for NlriEnumIter<'a, P>
where 
    O: Octets,
    ASP: NlriParse<'a, O, P>,
    P: Octets<Range<'a> = O>,
{
    fn from(iter: NlriIter<'a, O, P, ASP>) -> Self {
        Self {
            parser: iter.parser,
            ty: ASP::nlri_type() 
        }
    }
}

impl<'a, O, P, ASP: NlriParse<'a, O, P>> NlriIter<'a, O, P, ASP>
where
    O: Octets,
    P: Octets<Range<'a> = O>
{
    pub fn next_with<T, F: FnOnce(<Self as Iterator>::Item) -> T>(&mut self, fmap: F) -> Option<T> {
        self.next().map(fmap)
    }
}

impl<'a, O, P> NlriEnumIter<'a, P>
where 
    O: Octets,
    P: Octets<Range<'a> = O>,
{
    pub fn next_with<T, F: FnOnce(<Self as Iterator>::Item) -> T>(&mut self, fmap: F) -> Option<T> {
        self.next().map(fmap)
    }
}

#[cfg(test)]
mod tests {

    use super::*;
    use inetnum::addr::Prefix;
    use std::str::FromStr;

    #[test]
    fn parse_ipv4unicast() {
        let raw = vec![24,1,2,3];
        let mut parser = Parser::from_ref(&raw);
        let n = Ipv4UnicastNlri::parse(&mut parser).unwrap();

        assert_eq!(n.prefix(), Prefix::from_str("1.2.3.0/24").unwrap());
    }

    #[test]
    fn parse_ipv4mplsunicast() {
        // Label 8000 10.0.0.9/32
        let raw = vec![0x38, 0x01, 0xf4, 0x01, 0x0a, 0x00, 0x00, 0x09];
        let mut parser = Parser::from_ref(&raw);
        let n = Ipv4MplsUnicastNlri::parse(&mut parser).unwrap();
        eprintln!("{}", &n);

        let raw = bytes::Bytes::from_static(&[0x38, 0x01, 0xf4, 0x01, 0x0a, 0x00, 0x00, 0x09]);
        let mut parser = Parser::from_ref(&raw);
        let n2 = Ipv4MplsUnicastNlri::parse(&mut parser).unwrap();
        eprintln!("{}", &n2);

        assert_eq!(n, n2);

        let _n: Nlri<_> = n.into();
        let _n2: Nlri<_> = n2.into();
    }

    #[test]
    fn display() {
        let p =  Prefix::from_str("1.2.3.0/24").unwrap();
        let n: Nlri<()> = Ipv4UnicastNlri(p).into();
        assert_eq!(n.to_string(), p.to_string());
    }

    #[test]
    fn iter() {
        let raw = vec![
            0x38, 0x01, 0xf4, 0x01, 0x0a, 0x00, 0x00, 0x09,
            0x38, 0x01, 0xf4, 0x01, 0x0a, 0x00, 0x00, 0x0a,
        ];
        let parser = Parser::from_ref(&raw);
        let iter = NlriIter::ipv4_mplsunicast(parser);
        assert_eq!(iter.count(), 2);
    }

    #[test]
    fn iter_generic() {
        let mpls_raw = vec![
            0x38, 0x01, 0xf4, 0x01, 0x0a, 0x00, 0x00, 0x09,
            0x38, 0x01, 0xf4, 0x01, 0x0a, 0x00, 0x00, 0x0a,
        ];
        let parser = Parser::from_ref(&mpls_raw);
        let mpls_iter = NlriIter::ipv4_mplsunicast(parser);

        let v4_raw = vec![24, 1, 2, 3];
        let parser = Parser::from_ref(&v4_raw);
        let v4_iter = NlriIter::ipv4_unicast(parser); 


        for n in NlriEnumIter::from(v4_iter)
            .chain(NlriEnumIter::from(mpls_iter))
        {
            dbg!(&n);
        }
    }

    #[test]
    fn iter_addpath() {
        let raw = vec![
            0, 0, 0, 1, 24, 1, 2, 1,
            0, 0, 0, 2, 24, 1, 2, 2,
            0, 0, 0, 3, 24, 1, 2, 3,
            0, 0, 0, 4, 24, 1, 2, 4,
        ];

        let parser = Parser::from_ref(&raw);
        let iter = NlriIter::ipv4_unicast_addpath(parser);
        assert_eq!(iter.count(), 4);

        let iter = NlriIter::ipv4_unicast_addpath(parser);
        for n in iter.map(|e| e.unwrap().prefix()) {
            dbg!(&n);
        }
    }

    #[test]
    fn iter_addpath_alternative() {
        let raw = vec![
            0, 0, 0, 1, 24, 1, 2, 1,
            0, 0, 0, 2, 24, 1, 2, 2,
            0, 0, 0, 3, 24, 1, 2, 3,
            0, 0, 0, 4, 24, 1, 2, 4,
        ];

        let parser = Parser::from_ref(&raw);
        let iter = NlriIter::ipv6_unicast_addpath(parser);
        //assert_eq!(iter.count(), 4);
        for n in iter {
            eprintln!("{}", n.unwrap());
        }
    }

    #[test]
    fn iter_with() {
        let raw = vec![
            0, 0, 0, 1, 24, 1, 2, 1,
            0, 0, 0, 2, 24, 1, 2, 2,
            0, 0, 0, 3, 24, 1, 2, 3,
            0, 0, 0, 4, 24, 1, 2, 4,
        ];

        let parser = Parser::from_ref(&raw);
        let iter = NlriIter::ipv6_unicast_addpath(parser);
        //while let Some(x) = iter.next_with(|e| format!("IPv6!!!: {:?}", e).to_string()) {
        //    dbg!(x);
        //}

        for x in  iter.map(|e| format!("IPv6!!!: {:?}", e).to_string()) {
            dbg!(x);
        }

    }

    #[test]
    fn roundtrip_into_from_addpath() {
        let raw = vec![
            24, 1, 2, 1,
            24, 1, 2, 2,
            24, 1, 2, 3,
            24, 1, 2, 4,
        ];

        let parser = Parser::from_ref(&raw);
        let iter = NlriIter::ipv6_unicast(parser);
        for (idx, n) in iter.enumerate() {
            dbg!(
                Ipv6UnicastNlri::from(
                    dbg!(n.unwrap().into_addpath(PathId(idx.try_into().unwrap())))
                )
            );
        }
    }

}