roboticus-db 0.11.1

SQLite persistence layer with 28 tables, FTS5 search, WAL mode, and migration system
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
use rusqlite::OptionalExtension;

use crate::{Database, DbResultExt};
use roboticus_core::Result;

#[derive(Debug, Clone)]
pub struct CronJob {
    pub id: String,
    pub name: String,
    pub description: Option<String>,
    pub enabled: bool,
    pub schedule_kind: String,
    pub schedule_expr: Option<String>,
    pub schedule_every_ms: Option<i64>,
    pub schedule_tz: Option<String>,
    pub agent_id: String,
    pub session_target: String,
    pub payload_json: String,
    pub delivery_mode: Option<String>,
    pub delivery_channel: Option<String>,
    pub last_run_at: Option<String>,
    pub last_status: Option<String>,
    pub last_duration_ms: Option<i64>,
    pub consecutive_errors: i64,
    pub next_run_at: Option<String>,
    pub last_error: Option<String>,
    pub lease_holder: Option<String>,
    pub lease_expires_at: Option<String>,
}

#[derive(Debug, Clone)]
pub struct CronRun {
    pub id: String,
    pub job_id: String,
    pub status: String,
    pub duration_ms: Option<i64>,
    pub error: Option<String>,
    pub output_text: Option<String>,
    pub created_at: String,
}

pub fn create_job(
    db: &Database,
    name: &str,
    agent_id: &str,
    schedule_kind: &str,
    schedule_expr: Option<&str>,
    payload_json: &str,
) -> Result<String> {
    let conn = db.conn();
    let id = uuid::Uuid::new_v4().to_string();
    conn.execute(
        "INSERT INTO cron_jobs (id, name, agent_id, schedule_kind, schedule_expr, payload_json) \
         VALUES (?1, ?2, ?3, ?4, ?5, ?6)",
        rusqlite::params![
            id,
            name,
            agent_id,
            schedule_kind,
            schedule_expr,
            payload_json
        ],
    )
    .db_err()?;
    Ok(id)
}

pub fn list_jobs(db: &Database) -> Result<Vec<CronJob>> {
    let conn = db.conn();
    let mut stmt = conn
        .prepare(
            "SELECT id, name, description, enabled, schedule_kind, schedule_expr, \
             schedule_every_ms, schedule_tz, agent_id, session_target, payload_json, \
             delivery_mode, delivery_channel, last_run_at, last_status, last_duration_ms, \
             consecutive_errors, next_run_at, last_error, lease_holder, lease_expires_at \
             FROM cron_jobs ORDER BY name ASC",
        )
        .db_err()?;

    let rows = stmt
        .query_map([], |row| {
            Ok(CronJob {
                id: row.get(0)?,
                name: row.get(1)?,
                description: row.get(2)?,
                enabled: row.get::<_, i32>(3)? != 0,
                schedule_kind: row.get(4)?,
                schedule_expr: row.get(5)?,
                schedule_every_ms: row.get(6)?,
                schedule_tz: row.get(7)?,
                agent_id: row.get(8)?,
                session_target: row.get(9)?,
                payload_json: row.get(10)?,
                delivery_mode: row.get(11)?,
                delivery_channel: row.get(12)?,
                last_run_at: row.get(13)?,
                last_status: row.get(14)?,
                last_duration_ms: row.get(15)?,
                consecutive_errors: row.get(16)?,
                next_run_at: row.get(17)?,
                last_error: row.get(18)?,
                lease_holder: row.get(19)?,
                lease_expires_at: row.get(20)?,
            })
        })
        .db_err()?;

    rows.collect::<std::result::Result<Vec<_>, _>>().db_err()
}

pub fn get_job(db: &Database, id: &str) -> Result<Option<CronJob>> {
    let conn = db.conn();
    conn.query_row(
        "SELECT id, name, description, enabled, schedule_kind, schedule_expr, \
         schedule_every_ms, schedule_tz, agent_id, session_target, payload_json, \
         delivery_mode, delivery_channel, last_run_at, last_status, last_duration_ms, \
         consecutive_errors, next_run_at, last_error, lease_holder, lease_expires_at \
         FROM cron_jobs WHERE id = ?1",
        [id],
        |row| {
            Ok(CronJob {
                id: row.get(0)?,
                name: row.get(1)?,
                description: row.get(2)?,
                enabled: row.get::<_, i32>(3)? != 0,
                schedule_kind: row.get(4)?,
                schedule_expr: row.get(5)?,
                schedule_every_ms: row.get(6)?,
                schedule_tz: row.get(7)?,
                agent_id: row.get(8)?,
                session_target: row.get(9)?,
                payload_json: row.get(10)?,
                delivery_mode: row.get(11)?,
                delivery_channel: row.get(12)?,
                last_run_at: row.get(13)?,
                last_status: row.get(14)?,
                last_duration_ms: row.get(15)?,
                consecutive_errors: row.get(16)?,
                next_run_at: row.get(17)?,
                last_error: row.get(18)?,
                lease_holder: row.get(19)?,
                lease_expires_at: row.get(20)?,
            })
        },
    )
    .optional()
    .db_err()
}

pub fn delete_job(db: &Database, id: &str) -> Result<bool> {
    fn quote_ident(s: &str) -> String {
        format!("\"{}\"", s.replace('"', "\"\""))
    }

    let conn = db.conn();
    let tx = conn.unchecked_transaction().db_err()?;

    // Delete dependent rows from every table that has an FK to cron_jobs.
    // This keeps delete robust across schema versions/custom local tables.
    let mut table_stmt = tx
        .prepare(
            "SELECT name FROM sqlite_master \
             WHERE type = 'table' AND name NOT LIKE 'sqlite_%'",
        )
        .db_err()?;
    let table_names = table_stmt
        .query_map([], |row| row.get::<_, String>(0))
        .db_err()?
        .collect::<std::result::Result<Vec<_>, _>>()
        .db_err()?;
    drop(table_stmt);

    for table in table_names {
        let pragma_sql = format!("PRAGMA foreign_key_list({})", quote_ident(&table));
        let mut fk_stmt = tx.prepare(&pragma_sql).db_err()?;
        let fk_cols = fk_stmt
            .query_map([], |row| {
                let ref_table: String = row.get(2)?;
                let from_col: String = row.get(3)?;
                Ok((ref_table, from_col))
            })
            .db_err()?
            .collect::<std::result::Result<Vec<_>, _>>()
            .db_err()?;
        drop(fk_stmt);

        for (ref_table, from_col) in fk_cols {
            if ref_table == "cron_jobs" {
                let delete_sql = format!(
                    "DELETE FROM {} WHERE {} = ?1",
                    quote_ident(&table),
                    quote_ident(&from_col)
                );
                tx.execute(&delete_sql, [id]).db_err()?;
            }
        }
    }

    let changed = tx
        .execute("DELETE FROM cron_jobs WHERE id = ?1", [id])
        .db_err()?;
    tx.commit().db_err()?;
    Ok(changed > 0)
}

pub fn update_job(
    db: &Database,
    id: &str,
    name: Option<&str>,
    schedule_kind: Option<&str>,
    schedule_expr: Option<&str>,
    enabled: Option<bool>,
) -> Result<bool> {
    let conn = db.conn();
    let mut sets = Vec::new();
    let mut params: Vec<Box<dyn rusqlite::types::ToSql>> = Vec::new();

    if let Some(v) = name {
        sets.push("name = ?");
        params.push(Box::new(v.to_string()));
    }
    if let Some(v) = schedule_kind {
        sets.push("schedule_kind = ?");
        params.push(Box::new(v.to_string()));
    }
    if let Some(v) = schedule_expr {
        sets.push("schedule_expr = ?");
        params.push(Box::new(v.to_string()));
    }
    if let Some(v) = enabled {
        sets.push("enabled = ?");
        params.push(Box::new(v as i32));
    }

    if sets.is_empty() {
        return Ok(false);
    }

    // Renumber placeholders: ?1, ?2, ... ?N, id = ?N+1
    let numbered: Vec<String> = sets
        .iter()
        .enumerate()
        .map(|(i, s)| s.replace('?', &format!("?{}", i + 1)))
        .collect();
    let id_param = params.len() + 1;
    let sql = format!(
        "UPDATE cron_jobs SET {} WHERE id = ?{id_param}",
        numbered.join(", ")
    );
    params.push(Box::new(id.to_string()));

    let param_refs: Vec<&dyn rusqlite::types::ToSql> = params.iter().map(|b| b.as_ref()).collect();
    let changed = conn.execute(&sql, param_refs.as_slice()).db_err()?;
    Ok(changed > 0)
}

pub fn update_job_description(db: &Database, id: &str, description: Option<&str>) -> Result<bool> {
    let conn = db.conn();
    let changed = conn
        .execute(
            "UPDATE cron_jobs SET description = ?1 WHERE id = ?2",
            rusqlite::params![description, id],
        )
        .db_err()?;
    Ok(changed > 0)
}

/// Attempts to acquire a 60-second lease for `instance_id` on the given job.
/// Returns `true` if the lease was acquired (no existing valid lease or expired).
pub fn acquire_lease(db: &Database, job_id: &str, instance_id: &str) -> Result<bool> {
    let conn = db.conn();
    let changed = conn
        .execute(
            "UPDATE cron_jobs SET lease_holder = ?1, lease_expires_at = datetime('now', '+60 seconds') \
             WHERE id = ?2 AND (lease_holder IS NULL OR lease_expires_at < datetime('now'))",
            rusqlite::params![instance_id, job_id],
        )
        .db_err()?;
    Ok(changed > 0)
}

pub fn release_lease(db: &Database, job_id: &str, lease_holder: &str) -> Result<()> {
    let conn = db.conn();
    conn.execute(
        "UPDATE cron_jobs SET lease_holder = NULL, lease_expires_at = NULL \
         WHERE id = ?1 AND lease_holder = ?2",
        rusqlite::params![job_id, lease_holder],
    )
    .db_err()?;
    Ok(())
}

/// Update the `next_run_at` field for a cron job.
pub fn update_next_run_at(db: &Database, job_id: &str, next_run_at: Option<&str>) -> Result<()> {
    let conn = db.conn();
    conn.execute(
        "UPDATE cron_jobs SET next_run_at = ?1 WHERE id = ?2",
        rusqlite::params![next_run_at, job_id],
    )
    .db_err()?;
    Ok(())
}

pub fn record_run(
    db: &Database,
    job_id: &str,
    status: &str,
    duration_ms: Option<i64>,
    error: Option<&str>,
    output_text: Option<&str>,
) -> Result<String> {
    let conn = db.conn();
    let tx = conn.unchecked_transaction().db_err()?;

    let id = uuid::Uuid::new_v4().to_string();
    tx.execute(
        "INSERT INTO cron_runs (id, job_id, status, duration_ms, error, output_text) \
         VALUES (?1, ?2, ?3, ?4, ?5, ?6)",
        rusqlite::params![id, job_id, status, duration_ms, error, output_text],
    )
    .db_err()?;

    if status == "success" {
        tx.execute(
            "UPDATE cron_jobs SET last_run_at = strftime('%Y-%m-%dT%H:%M:%SZ', 'now'), last_status = ?1, \
             last_duration_ms = ?2, consecutive_errors = 0, last_error = NULL WHERE id = ?3",
            rusqlite::params![status, duration_ms, job_id],
        )
        .db_err()?;
    } else {
        tx.execute(
            "UPDATE cron_jobs SET last_run_at = strftime('%Y-%m-%dT%H:%M:%SZ', 'now'), last_status = ?1, \
             last_duration_ms = ?2, consecutive_errors = consecutive_errors + 1, \
             last_error = ?3 WHERE id = ?4",
            rusqlite::params![status, duration_ms, error, job_id],
        )
        .db_err()?;
    }

    tx.commit().db_err()?;
    Ok(id)
}

pub fn list_runs(
    db: &Database,
    from: Option<&str>,
    to: Option<&str>,
    job_id: Option<&str>,
    limit: i64,
) -> Result<Vec<CronRun>> {
    let conn = db.conn();
    let sql = "SELECT id, job_id, status, duration_ms, error, output_text, created_at
               FROM cron_runs
               WHERE (?1 IS NULL OR created_at >= ?1)
                 AND (?2 IS NULL OR created_at <= ?2)
                 AND (?3 IS NULL OR job_id = ?3)
               ORDER BY created_at DESC
               LIMIT ?4";
    let mut stmt = conn.prepare(sql).db_err()?;
    let rows = stmt
        .query_map(rusqlite::params![from, to, job_id, limit], |row| {
            Ok(CronRun {
                id: row.get(0)?,
                job_id: row.get(1)?,
                status: row.get(2)?,
                duration_ms: row.get(3)?,
                error: row.get(4)?,
                output_text: row.get(5)?,
                created_at: row.get(6)?,
            })
        })
        .db_err()?;
    rows.collect::<std::result::Result<Vec<_>, _>>().db_err()
}

#[cfg(test)]
mod tests {
    use super::*;

    fn test_db() -> Database {
        Database::new(":memory:").unwrap()
    }

    #[test]
    fn create_and_list_jobs() {
        let db = test_db();
        create_job(
            &db,
            "heartbeat",
            "agent-1",
            "every",
            None,
            r#"{"action":"ping"}"#,
        )
        .unwrap();
        create_job(
            &db,
            "daily-report",
            "agent-1",
            "cron",
            Some("0 9 * * *"),
            r#"{"action":"report"}"#,
        )
        .unwrap();

        let jobs = list_jobs(&db).unwrap();
        assert_eq!(jobs.len(), 2);
        assert_eq!(jobs[0].name, "daily-report");
        assert_eq!(jobs[1].name, "heartbeat");
    }

    #[test]
    fn lease_acquisition_and_release() {
        let db = test_db();
        let job_id = create_job(&db, "task", "a1", "every", None, "{}").unwrap();

        assert!(acquire_lease(&db, &job_id, "instance-1").unwrap());
        // Second acquire by a different instance should fail (lease not expired)
        assert!(!acquire_lease(&db, &job_id, "instance-2").unwrap());

        release_lease(&db, &job_id, "instance-1").unwrap();
        assert!(acquire_lease(&db, &job_id, "instance-2").unwrap());
    }

    #[test]
    fn get_and_delete_job() {
        let db = test_db();
        let job_id = create_job(&db, "to-delete", "a1", "every", None, "{}").unwrap();

        let job = get_job(&db, &job_id).unwrap().expect("job should exist");
        assert_eq!(job.name, "to-delete");
        assert_eq!(job.agent_id, "a1");

        assert!(delete_job(&db, &job_id).unwrap());
        assert!(get_job(&db, &job_id).unwrap().is_none());
        assert!(!delete_job(&db, &job_id).unwrap());
    }

    #[test]
    fn record_run_updates_job() {
        let db = test_db();
        let job_id = create_job(&db, "task", "a1", "every", None, "{}").unwrap();

        record_run(&db, &job_id, "success", Some(150), None, None).unwrap();
        let jobs = list_jobs(&db).unwrap();
        assert_eq!(jobs[0].last_status.as_deref(), Some("success"));
        assert_eq!(jobs[0].consecutive_errors, 0);

        record_run(&db, &job_id, "error", Some(50), Some("timeout"), None).unwrap();
        let jobs = list_jobs(&db).unwrap();
        assert_eq!(jobs[0].consecutive_errors, 1);
        assert_eq!(jobs[0].last_error.as_deref(), Some("timeout"));
    }

    #[test]
    fn get_job_nonexistent_returns_none() {
        let db = test_db();
        assert!(get_job(&db, "does-not-exist").unwrap().is_none());
    }

    #[test]
    fn list_jobs_empty_db() {
        let db = test_db();
        let jobs = list_jobs(&db).unwrap();
        assert!(jobs.is_empty());
    }

    #[test]
    fn create_job_defaults() {
        let db = test_db();
        let id = create_job(&db, "j1", "a1", "every", None, "{}").unwrap();
        let job = get_job(&db, &id).unwrap().unwrap();
        assert!(job.enabled);
        assert!(job.last_run_at.is_none());
        assert!(job.last_status.is_none());
        assert_eq!(job.consecutive_errors, 0);
        assert!(job.last_error.is_none());
        assert!(job.lease_holder.is_none());
    }

    #[test]
    fn create_job_with_schedule_expr() {
        let db = test_db();
        let id = create_job(
            &db,
            "cron-job",
            "a1",
            "cron",
            Some("0 */5 * * *"),
            r#"{"a":1}"#,
        )
        .unwrap();
        let job = get_job(&db, &id).unwrap().unwrap();
        assert_eq!(job.schedule_kind, "cron");
        assert_eq!(job.schedule_expr.as_deref(), Some("0 */5 * * *"));
    }

    #[test]
    fn record_run_success_clears_last_error() {
        let db = test_db();
        let job_id = create_job(&db, "task", "a1", "every", None, "{}").unwrap();

        record_run(&db, &job_id, "error", Some(10), Some("oops"), None).unwrap();
        let job = get_job(&db, &job_id).unwrap().unwrap();
        assert_eq!(job.consecutive_errors, 1);
        assert_eq!(job.last_error.as_deref(), Some("oops"));

        record_run(&db, &job_id, "success", Some(20), None, None).unwrap();
        let job = get_job(&db, &job_id).unwrap().unwrap();
        assert_eq!(job.consecutive_errors, 0);
        assert!(job.last_error.is_none());
    }

    #[test]
    fn record_run_with_none_duration() {
        let db = test_db();
        let job_id = create_job(&db, "task", "a1", "every", None, "{}").unwrap();
        let run_id = record_run(&db, &job_id, "error", None, Some("crash"), None).unwrap();
        assert!(!run_id.is_empty());
        let job = get_job(&db, &job_id).unwrap().unwrap();
        assert!(job.last_duration_ms.is_none());
    }

    #[test]
    fn consecutive_errors_compound() {
        let db = test_db();
        let job_id = create_job(&db, "task", "a1", "every", None, "{}").unwrap();
        for i in 1..=5 {
            record_run(
                &db,
                &job_id,
                "error",
                Some(10),
                Some(&format!("err-{i}")),
                None,
            )
            .unwrap();
            let job = get_job(&db, &job_id).unwrap().unwrap();
            assert_eq!(job.consecutive_errors, i);
        }
    }

    #[test]
    fn acquire_lease_nonexistent_job() {
        let db = test_db();
        let acquired = acquire_lease(&db, "no-such-job", "inst-1").unwrap();
        assert!(!acquired);
    }

    #[test]
    fn release_lease_nonexistent_job() {
        let db = test_db();
        release_lease(&db, "no-such-job", "inst-1").unwrap();
    }

    #[test]
    fn record_run_persists_output_text() {
        let db = test_db();
        let job_id = create_job(
            &db,
            "job-output",
            "agent-1",
            "cron",
            Some("0 * * * *"),
            "{}",
        )
        .unwrap();
        let run_id =
            record_run(&db, &job_id, "success", Some(5), None, Some("hello world")).unwrap();
        let runs = list_runs(&db, None, None, Some(&job_id), 10).unwrap();
        assert_eq!(runs[0].id, run_id);
        assert_eq!(runs[0].output_text.as_deref(), Some("hello world"));
    }

    #[test]
    fn record_run_returns_unique_ids() {
        let db = test_db();
        let job_id = create_job(&db, "task", "a1", "every", None, "{}").unwrap();
        let r1 = record_run(&db, &job_id, "success", Some(10), None, None).unwrap();
        let r2 = record_run(&db, &job_id, "success", Some(20), None, None).unwrap();
        assert_ne!(r1, r2);
    }

    #[test]
    fn update_job_name_only() {
        let db = test_db();
        let id = create_job(&db, "old-name", "a1", "every", None, "{}").unwrap();
        let changed = update_job(&db, &id, Some("new-name"), None, None, None).unwrap();
        assert!(changed);
        let job = get_job(&db, &id).unwrap().unwrap();
        assert_eq!(job.name, "new-name");
    }

    #[test]
    fn update_job_schedule() {
        let db = test_db();
        let id = create_job(&db, "j", "a1", "every", None, "{}").unwrap();
        let changed = update_job(&db, &id, None, Some("cron"), Some("0 9 * * *"), None).unwrap();
        assert!(changed);
        let job = get_job(&db, &id).unwrap().unwrap();
        assert_eq!(job.schedule_kind, "cron");
        assert_eq!(job.schedule_expr.as_deref(), Some("0 9 * * *"));
    }

    #[test]
    fn update_job_enabled_flag() {
        let db = test_db();
        let id = create_job(&db, "j", "a1", "every", None, "{}").unwrap();

        let changed = update_job(&db, &id, None, None, None, Some(false)).unwrap();
        assert!(changed);
        let job = get_job(&db, &id).unwrap().unwrap();
        assert!(!job.enabled);

        let changed = update_job(&db, &id, None, None, None, Some(true)).unwrap();
        assert!(changed);
        let job = get_job(&db, &id).unwrap().unwrap();
        assert!(job.enabled);
    }

    #[test]
    fn update_job_empty_returns_false() {
        let db = test_db();
        let id = create_job(&db, "j", "a1", "every", None, "{}").unwrap();
        let changed = update_job(&db, &id, None, None, None, None).unwrap();
        assert!(!changed);
    }

    #[test]
    fn update_job_nonexistent_returns_false() {
        let db = test_db();
        let changed = update_job(&db, "no-such-id", Some("new-name"), None, None, None).unwrap();
        assert!(!changed);
    }

    #[test]
    fn update_job_all_fields() {
        let db = test_db();
        let id = create_job(&db, "j", "a1", "every", None, "{}").unwrap();
        let changed = update_job(
            &db,
            &id,
            Some("updated"),
            Some("cron"),
            Some("*/5 * * * *"),
            Some(false),
        )
        .unwrap();
        assert!(changed);
        let job = get_job(&db, &id).unwrap().unwrap();
        assert_eq!(job.name, "updated");
        assert_eq!(job.schedule_kind, "cron");
        assert_eq!(job.schedule_expr.as_deref(), Some("*/5 * * * *"));
        assert!(!job.enabled);
    }

    #[test]
    fn list_runs_empty() {
        let db = test_db();
        let runs = list_runs(&db, None, None, None, 100).unwrap();
        assert!(runs.is_empty());
    }

    #[test]
    fn list_runs_all() {
        let db = test_db();
        let jid = create_job(&db, "task", "a1", "every", None, "{}").unwrap();
        record_run(&db, &jid, "success", Some(100), None, None).unwrap();
        record_run(&db, &jid, "error", Some(50), Some("boom"), None).unwrap();
        record_run(&db, &jid, "success", Some(200), None, None).unwrap();

        let runs = list_runs(&db, None, None, None, 100).unwrap();
        assert_eq!(runs.len(), 3);
    }

    #[test]
    fn list_runs_by_job_id() {
        let db = test_db();
        let j1 = create_job(&db, "job1", "a1", "every", None, "{}").unwrap();
        let j2 = create_job(&db, "job2", "a1", "every", None, "{}").unwrap();
        record_run(&db, &j1, "success", Some(10), None, None).unwrap();
        record_run(&db, &j1, "success", Some(20), None, None).unwrap();
        record_run(&db, &j2, "success", Some(30), None, None).unwrap();

        let runs = list_runs(&db, None, None, Some(&j1), 100).unwrap();
        assert_eq!(runs.len(), 2);
        for run in &runs {
            assert_eq!(run.job_id, j1);
        }
    }

    #[test]
    fn list_runs_respects_limit() {
        let db = test_db();
        let jid = create_job(&db, "task", "a1", "every", None, "{}").unwrap();
        for _ in 0..10 {
            record_run(&db, &jid, "success", Some(10), None, None).unwrap();
        }
        let runs = list_runs(&db, None, None, None, 3).unwrap();
        assert_eq!(runs.len(), 3);
    }

    #[test]
    fn list_runs_fields_populated() {
        let db = test_db();
        let jid = create_job(&db, "task", "a1", "every", None, "{}").unwrap();
        let run_id = record_run(&db, &jid, "error", Some(42), Some("timeout"), None).unwrap();
        let runs = list_runs(&db, None, None, None, 10).unwrap();
        assert_eq!(runs.len(), 1);
        assert_eq!(runs[0].id, run_id);
        assert_eq!(runs[0].job_id, jid);
        assert_eq!(runs[0].status, "error");
        assert_eq!(runs[0].duration_ms, Some(42));
        assert_eq!(runs[0].error.as_deref(), Some("timeout"));
        assert!(!runs[0].created_at.is_empty());
    }

    #[test]
    fn delete_job_cascades_cron_runs() {
        let db = test_db();
        let jid = create_job(&db, "task", "a1", "every", None, "{}").unwrap();
        record_run(&db, &jid, "success", Some(10), None, None).unwrap();
        record_run(&db, &jid, "error", Some(5), Some("oops"), None).unwrap();

        assert!(delete_job(&db, &jid).unwrap());

        // Verify runs were cascade-deleted
        let runs = list_runs(&db, None, None, Some(&jid), 100).unwrap();
        assert!(runs.is_empty());
    }

    #[test]
    fn release_lease_wrong_holder_is_noop() {
        let db = test_db();
        let jid = create_job(&db, "task", "a1", "every", None, "{}").unwrap();
        acquire_lease(&db, &jid, "inst-1").unwrap();

        // Releasing with wrong holder should not clear the lease
        release_lease(&db, &jid, "inst-2").unwrap();
        let job = get_job(&db, &jid).unwrap().unwrap();
        assert_eq!(job.lease_holder.as_deref(), Some("inst-1"));
    }
}