roadster 0.7.0-beta

A "Batteries Included" web framework for rust designed to get you moving fast.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
use crate::app::context::AppContext;
use crate::app::App;
use crate::config::service::worker::sidekiq::StaleCleanUpBehavior;
use crate::error::RoadsterResult;
use crate::service::worker::sidekiq::app_worker::{AppWorker, AppWorkerConfig};
#[cfg_attr(test, mockall_double::double)]
use crate::service::worker::sidekiq::processor_wrapper::ProcessorWrapper;
use crate::service::worker::sidekiq::roadster_worker::RoadsterWorker;
use crate::service::worker::sidekiq::service::{enabled, SidekiqWorkerService, NAME};
use crate::service::AppServiceBuilder;
use anyhow::anyhow;
use async_trait::async_trait;
use axum_core::extract::FromRef;
use itertools::Itertools;
use num_traits::ToPrimitive;
use serde::Serialize;
use sidekiq::{periodic, ProcessorConfig, ServerMiddleware, Worker};
use std::collections::HashSet;
use tracing::{debug, info};

pub(crate) const PERIODIC_KEY: &str = "periodic";

pub struct SidekiqWorkerServiceBuilder<S>
where
    S: Clone + Send + Sync + 'static,
    AppContext: FromRef<S>,
{
    state: BuilderState<S>,
}

#[allow(clippy::large_enum_variant)]
enum BuilderState<S>
where
    S: Clone + Send + Sync + 'static,
    AppContext: FromRef<S>,
{
    Enabled {
        processor: ProcessorWrapper,
        state: S,
        registered_workers: HashSet<String>,
        registered_periodic_workers: HashSet<String>,
    },
    Disabled,
}

#[async_trait]
impl<A, S> AppServiceBuilder<A, S, SidekiqWorkerService> for SidekiqWorkerServiceBuilder<S>
where
    S: Clone + Send + Sync + 'static,
    AppContext: FromRef<S>,
    A: App<S> + 'static,
{
    fn name(&self) -> String {
        NAME.to_string()
    }

    fn enabled(&self, state: &S) -> bool {
        match self.state {
            BuilderState::Enabled { .. } => enabled(&AppContext::from_ref(state)),
            BuilderState::Disabled => false,
        }
    }

    async fn build(self, _state: &S) -> RoadsterResult<SidekiqWorkerService> {
        let service = match self.state {
            BuilderState::Enabled {
                processor,
                registered_periodic_workers,
                ..
            } => SidekiqWorkerService {
                registered_periodic_workers,
                processor: processor.into_sidekiq_processor(),
            },
            BuilderState::Disabled => {
                return Err(anyhow!(
                    "This builder is not enabled; it's build method should not have been called."
                )
                .into());
            }
        };

        Ok(service)
    }
}

impl<S> SidekiqWorkerServiceBuilder<S>
where
    S: Clone + Send + Sync + 'static,
    AppContext: FromRef<S>,
{
    pub async fn with_processor(state: &S, processor: sidekiq::Processor) -> RoadsterResult<Self> {
        Self::new(state.clone(), Some(ProcessorWrapper::new(processor))).await
    }

    pub async fn with_default_processor(
        state: &S,
        worker_queues: Option<Vec<String>>,
    ) -> RoadsterResult<Self> {
        let context = AppContext::from_ref(state);
        let processor = if !enabled(&context) {
            debug!("Sidekiq service not enabled, not creating the Sidekiq processor");
            None
        } else if let Some(redis_fetch) = context.redis_fetch() {
            Self::auto_clean_periodic(&context).await?;
            let queues = context
                .config()
                .service
                .sidekiq
                .custom
                .queues
                .clone()
                .into_iter()
                .chain(worker_queues.unwrap_or_default())
                .collect_vec();
            info!(
                "Creating Sidekiq.rs (rusty-sidekiq) processor with {} queues",
                queues.len()
            );
            debug!("Sidekiq.rs queues: {queues:?}");
            let processor = {
                let config = context.config().service.sidekiq.custom.clone();
                let num_workers = config.num_workers.to_usize().ok_or_else(|| {
                    anyhow!(
                        "Unable to convert num_workers `{}` to usize",
                        context.config().service.sidekiq.custom.num_workers
                    )
                })?;
                let processor_config: ProcessorConfig = Default::default();
                let processor_config = processor_config
                    .num_workers(num_workers)
                    .balance_strategy(config.balance_strategy.into());

                let processor_config = context
                    .config()
                    .service
                    .sidekiq
                    .custom
                    .queue_config
                    .iter()
                    .fold(processor_config, |processor_config, (queue, config)| {
                        processor_config.queue_config(queue.clone(), config.into())
                    });

                let processor = sidekiq::Processor::new(redis_fetch.inner.clone(), queues.clone())
                    .with_config(processor_config);
                ProcessorWrapper::new(processor)
            };

            Some(processor)
        } else {
            debug!(
                "No 'redis fetch' connection pool configured, not creating the Sidekiq processor"
            );
            None
        };

        Self::new(state.clone(), processor).await
    }

    async fn new(state: S, processor: Option<ProcessorWrapper>) -> RoadsterResult<Self> {
        let context = AppContext::from_ref(&state);
        let processor = if enabled(&context) { processor } else { None };

        let state = if let Some(processor) = processor {
            BuilderState::Enabled {
                processor,
                state,
                registered_workers: Default::default(),
                registered_periodic_workers: Default::default(),
            }
        } else {
            BuilderState::Disabled
        };

        Ok(Self { state })
    }

    async fn auto_clean_periodic(context: &AppContext) -> RoadsterResult<()> {
        if context
            .config()
            .service
            .sidekiq
            .custom
            .periodic
            .stale_cleanup
            == StaleCleanUpBehavior::AutoCleanAll
        {
            // Periodic jobs are not removed automatically. Remove any periodic jobs that were
            // previously added. They should be re-added by `App::worker`.
            info!("Auto-cleaning periodic jobs");
            periodic::destroy_all(context.redis_enqueue().inner.clone()).await?;
        }

        Ok(())
    }

    /// Remove previously-registered periodic jobs from Sidekiq/Redis. This should be called
    /// before registering any new periodic jobs. If this method is called after a periodic job is
    /// registered, it will return an error.
    ///
    /// Periodic jobs can also be cleaned up automatically by setting the
    /// [service.sidekiq.periodic.stale-cleanup][crate::config::service::worker::sidekiq::StaleCleanUpBehavior]
    /// to `auto-clean-all` or `auto-clean-stale`.
    pub async fn clean_up_periodic_jobs(self) -> RoadsterResult<Self> {
        if let BuilderState::Enabled {
            registered_periodic_workers,
            state: context,
            ..
        } = &self.state
        {
            if !registered_periodic_workers.is_empty() {
                return Err(anyhow!("Can only clean up previous periodic jobs if no periodic jobs have been registered yet.").into());
            }
            let context = AppContext::from_ref(context);
            periodic::destroy_all(context.redis_enqueue().inner.clone()).await?;
        }

        Ok(self)
    }

    /// Register a [`Worker`] to handle Sidekiq.rs jobs.
    ///
    /// The worker will be wrapped by internal logic which provides some common behavior, such
    /// as enforcing a timeout/max duration of worker jobs. Note that this internal logic my not
    /// use the values of [`Worker::disable_argument_coercion`] and [`Worker::max_retries`] -- if
    /// the respective fields are set in the app's [`AppWorkerConfig`], that will be used first.
    /// It's recommended to use [`Self::register_worker_with_config`] to override the
    /// fields from the app's config as needed instead.
    pub fn register_worker<Args, W>(self, worker: W) -> RoadsterResult<Self>
    where
        Args: Sync + Send + Serialize + for<'de> serde::Deserialize<'de> + 'static,
        W: Worker<Args> + 'static,
    {
        self.register_worker_inner(worker, None)
    }

    /// Register a [`Worker`] to handle Sidekiq.rs jobs.
    ///
    /// The worker will be wrapped by internal logic which provides some common behavior, such
    /// as enforcing a timeout/max duration of worker jobs. Note that this internal logic my not
    /// use the values of [`Worker::disable_argument_coercion`] and [`Worker::max_retries`] -- if
    /// the respective fields are set in the app's [`AppWorkerConfig`], that will be used first.
    /// It's recommended to use this method to override the fields from the app's config as needed
    /// instead.
    pub fn register_worker_with_config<Args, W>(
        self,
        worker: W,
        config: AppWorkerConfig,
    ) -> RoadsterResult<Self>
    where
        Args: Sync + Send + Serialize + for<'de> serde::Deserialize<'de> + 'static,
        W: Worker<Args> + 'static,
    {
        self.register_worker_inner(worker, Some(config))
    }

    fn register_worker_inner<Args, W>(
        mut self,
        worker: W,
        config: Option<AppWorkerConfig>,
    ) -> RoadsterResult<Self>
    where
        Args: Sync + Send + Serialize + for<'de> serde::Deserialize<'de> + 'static,
        W: Worker<Args> + 'static,
    {
        if let BuilderState::Enabled {
            processor,
            registered_workers,
            state,
            ..
        } = &mut self.state
        {
            let context = AppContext::from_ref(state);
            let class_name = W::class_name();
            debug!(worker = %class_name, "Registering worker");
            if !registered_workers.insert(class_name.clone()) {
                return Err(anyhow!("Worker `{class_name}` was already registered").into());
            }
            let roadster_worker = RoadsterWorker::new(&context, worker, config);
            processor.register(roadster_worker);
        }

        Ok(self)
    }

    /// Register a periodic [`Worker`] that will run with the provided args. The cadence
    /// of the periodic worker, the worker's queue name, and other attributes are specified using
    /// the [builder][periodic::Builder]. However, to help ensure type-safety the args are provided
    /// to this method instead of the [builder][periodic::Builder].
    ///
    /// The worker will be wrapped by internal logic which provides some common behavior, such
    /// as enforcing a timeout/max duration of worker jobs. Note that this internal logic my not
    /// use the values of [`Worker::disable_argument_coercion`] and [`Worker::max_retries`] -- if
    /// the respective fields are set in the app's [`AppWorkerConfig`], that will be used first.
    /// It's recommended to use [`Self::register_periodic_worker_with_config`] to override the
    /// fields from the app's config as needed instead.
    pub async fn register_periodic_worker<Args, W>(
        self,
        builder: periodic::Builder,
        worker: W,
        args: Args,
    ) -> RoadsterResult<Self>
    where
        Args: Sync + Send + Serialize + for<'de> serde::Deserialize<'de> + 'static,
        W: AppWorker<S, Args> + 'static,
    {
        self.register_periodic_worker_inner(builder, worker, args, None)
            .await
    }

    /// Register a periodic [`Worker`] that will run with the provided args. The cadence
    /// of the periodic worker, the worker's queue name, and other attributes are specified using
    /// the [builder][periodic::Builder]. However, to help ensure type-safety the args are provided
    /// to this method instead of the [builder][periodic::Builder].
    ///
    /// The worker will be wrapped by internal logic which provides some common behavior, such
    /// as enforcing a timeout/max duration of worker jobs. Note that this internal logic my not
    /// use the values of [`Worker::disable_argument_coercion`] and [`Worker::max_retries`] -- if
    /// the respective fields are set in the app's [`AppWorkerConfig`], that will be used first.
    /// It's recommended to use this method to override the fields from the app's config as needed
    /// instead.
    pub async fn register_periodic_worker_with_config<Args, W>(
        self,
        builder: periodic::Builder,
        worker: W,
        args: Args,
        config: AppWorkerConfig,
    ) -> RoadsterResult<Self>
    where
        Args: Sync + Send + Serialize + for<'de> serde::Deserialize<'de> + 'static,
        W: AppWorker<S, Args> + 'static,
    {
        self.register_periodic_worker_inner(builder, worker, args, Some(config))
            .await
    }

    async fn register_periodic_worker_inner<Args, W>(
        mut self,
        builder: periodic::Builder,
        worker: W,
        args: Args,
        config: Option<AppWorkerConfig>,
    ) -> RoadsterResult<Self>
    where
        Args: Sync + Send + Serialize + for<'de> serde::Deserialize<'de> + 'static,
        W: AppWorker<S, Args> + 'static,
    {
        if let BuilderState::Enabled {
            processor,
            state,
            registered_periodic_workers,
            ..
        } = &mut self.state
        {
            let context = AppContext::from_ref(state);
            let class_name = W::class_name();
            debug!(worker = %class_name, "Registering periodic worker");
            let roadster_worker = RoadsterWorker::new(&context, worker, config);
            let builder = builder.args(args)?;
            let job_json = serde_json::to_string(&builder.into_periodic_job(class_name.clone())?)?;
            if !registered_periodic_workers.insert(job_json.clone()) {
                return Err(anyhow!(
                    "Periodic worker `{class_name}` was already registered; full job: {job_json}"
                )
                .into());
            }
            processor
                .register_periodic(builder, roadster_worker)
                .await?;
        }

        Ok(self)
    }

    pub async fn middleware<M>(mut self, middleware: M) -> RoadsterResult<Self>
    where
        M: ServerMiddleware + Send + Sync + 'static,
    {
        if let BuilderState::Enabled { processor, .. } = &mut self.state {
            processor.middleware(middleware).await;
        }
        Ok(self)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::app::context::AppContext;
    use crate::config::AppConfig;
    use crate::service::worker::sidekiq::processor_wrapper::MockProcessorWrapper;
    use bb8::Pool;
    use futures::StreamExt;
    use rstest::rstest;
    use sidekiq::{RedisConnectionManager, Worker};

    #[rstest]
    #[case(true, 1, vec![MockTestAppWorker::class_name()])]
    #[case(false, 0, Default::default())]
    #[tokio::test]
    #[cfg_attr(coverage_nightly, coverage(off))]
    async fn register_app_worker(
        #[case] enabled: bool,
        #[case] expected_size: usize,
        #[case] expected_class_names: Vec<String>,
    ) {
        // Arrange
        let builder = setup(enabled, expected_size, 0).await;

        // Act
        let builder = builder
            .register_worker(MockTestAppWorker::default())
            .unwrap();

        // Assert
        validate_registered_workers(&builder, enabled, expected_size, expected_class_names);
        validate_registered_periodic_workers(&builder, enabled, 0, Default::default());
    }

    #[tokio::test]
    #[should_panic]
    #[cfg_attr(coverage_nightly, coverage(off))]
    async fn register_app_worker_register_twice() {
        // Arrange
        let builder = setup(true, 2, 0).await;

        // Act
        builder
            .register_worker(MockTestAppWorker::default())
            .unwrap()
            .register_worker(MockTestAppWorker::default())
            .unwrap();
    }

    #[rstest]
    #[case(true, vec!["foo".to_string()])]
    #[case(true, vec!["foo".to_string(), "bar".to_string()])]
    #[tokio::test]
    #[cfg_attr(coverage_nightly, coverage(off))]
    async fn register_periodic_app_worker(#[case] enabled: bool, #[case] job_names: Vec<String>) {
        // Arrange
        let builder = setup(true, 0, job_names.len()).await;

        // Act
        let builder = futures::stream::iter(job_names.clone())
            .fold(builder, |builder, name| async move {
                builder
                    .register_periodic_worker(
                        periodic::builder("* * * * * *").unwrap().name(name),
                        MockTestAppWorker::default(),
                        (),
                    )
                    .await
                    .unwrap()
            })
            .await;

        // Assert
        validate_registered_workers(&builder, enabled, 0, Default::default());
        validate_registered_periodic_workers(&builder, enabled, job_names.len(), job_names)
    }

    mockall::mock! {
        TestAppWorker{}

        #[async_trait]
        impl Worker<()> for TestAppWorker {
            async fn perform(&self, args: ()) -> sidekiq::Result<()>;
        }
    }

    #[cfg_attr(coverage_nightly, coverage(off))]
    async fn setup(
        enabled: bool,
        register_count: usize,
        periodic_count: usize,
    ) -> SidekiqWorkerServiceBuilder<AppContext> {
        let mut config = AppConfig::test(None).unwrap();
        config.service.default_enable = enabled;
        config.service.sidekiq.custom.num_workers = 1;
        config.service.sidekiq.custom.queues = vec!["foo".to_string()];

        let redis_fetch = RedisConnectionManager::new("redis://invalid_host:1234").unwrap();
        let pool = Pool::builder().build_unchecked(redis_fetch);
        let context = AppContext::test(Some(config), None, Some(pool)).unwrap();

        let mut processor = MockProcessorWrapper::default();
        processor
            .expect_register::<(), MockTestAppWorker>()
            .times(register_count)
            .returning(|_| ());
        processor
            .expect_register_periodic::<(), MockTestAppWorker>()
            .times(periodic_count)
            .returning(|_, _| Ok(()));

        SidekiqWorkerServiceBuilder::new(context, Some(processor))
            .await
            .unwrap()
    }

    #[cfg_attr(coverage_nightly, coverage(off))]
    fn validate_registered_workers(
        builder: &SidekiqWorkerServiceBuilder<AppContext>,
        enabled: bool,
        size: usize,
        class_names: Vec<String>,
    ) {
        match &builder.state {
            BuilderState::Enabled {
                registered_workers, ..
            } => {
                assert!(enabled, "Builder should be disabled!");
                assert_eq!(registered_workers.len(), size);
                class_names
                    .iter()
                    .for_each(|class_name| assert!(registered_workers.contains(class_name)));
            }
            BuilderState::Disabled => {
                assert!(!enabled, "Builder should not be disabled!");
            }
        }
    }

    #[cfg_attr(coverage_nightly, coverage(off))]
    fn validate_registered_periodic_workers(
        builder: &SidekiqWorkerServiceBuilder<AppContext>,
        enabled: bool,
        size: usize,
        job_names: Vec<String>,
    ) {
        match &builder.state {
            BuilderState::Enabled {
                registered_periodic_workers,
                ..
            } => {
                assert!(enabled, "Builder should be disabled!");
                assert_eq!(registered_periodic_workers.len(), size);
                job_names.iter().for_each(|job_string| {
                    assert!(registered_periodic_workers
                        .iter()
                        .any(|registered| registered.contains(job_string)));
                });
            }
            BuilderState::Disabled => {
                assert!(!enabled, "Builder should not be disabled!");
            }
        }
    }

    #[rstest]
    #[case(true, true)]
    #[case(false, false)]
    #[tokio::test]
    #[cfg_attr(coverage_nightly, coverage(off))]
    async fn clean_up_periodic_jobs_already_registered(
        #[case] enabled: bool,
        #[case] expect_err: bool,
    ) {
        // Arrange
        let register_count = if enabled { 1 } else { 0 };
        let builder = setup(enabled, 0, register_count).await;
        let builder = if enabled {
            builder
                .register_periodic_worker(
                    periodic::builder("* * * * * *").unwrap().name("foo"),
                    MockTestAppWorker::default(),
                    (),
                )
                .await
                .unwrap()
        } else {
            builder
        };

        // Act
        let result = builder.clean_up_periodic_jobs().await;

        // Assert
        assert_eq!(result.is_err(), expect_err);
    }
}