rmux-server 0.1.1

Tokio daemon and request dispatcher for the RMUX terminal multiplexer.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
use std::io;
#[cfg(unix)]
use std::os::unix::fs::FileTypeExt;
#[cfg(unix)]
use std::path::Path;
use std::path::PathBuf;
use std::sync::Arc;
use std::time::Duration;

use rmux_core::events::SubscriptionLimits;
use rmux_ipc::{wait_for_peer_close, LocalListener, LocalStream, PeerIdentity};
use rmux_proto::{encode_frame, ErrorResponse, FrameDecoder, Request, Response, WaitForMode};
use tokio::io::{AsyncReadExt, AsyncWriteExt};
use tokio::sync::{oneshot, watch};
use tokio::task::{JoinError, JoinSet};
use tracing::{debug, warn};

use crate::control::{self, ControlLifecycle, ControlServerEvent};
use crate::daemon::ShutdownHandle;
use crate::handler::{attach_support::AttachRegistration, ControlRegistration, RequestHandler};
use crate::pane_io;
use crate::server_access::apply_access_policy;
use crate::ConfigLoadOptions;

/// Accept loop: spawns a per-connection task for each incoming client.
pub(crate) async fn serve(
    listener: LocalListener,
    socket_path: PathBuf,
    shutdown_handle: ShutdownHandle,
    mut shutdown: oneshot::Receiver<()>,
    config_load: ConfigLoadOptions,
    subscription_limits: SubscriptionLimits,
    owner_uid: u32,
) -> io::Result<()> {
    let _cleanup_on_drop = SocketCleanup::new(socket_path.clone());
    let handler = Arc::new(RequestHandler::with_owner_uid_and_subscription_limits(
        owner_uid,
        subscription_limits,
    ));
    handler.install_shutdown_handle(shutdown_handle.clone());
    handler.set_socket_path(&socket_path);
    handler.load_startup_config(config_load).await;
    let (connection_shutdown, connection_shutdown_rx) = watch::channel(());
    let mut connection_tasks = JoinSet::new();
    let hook_handler = Arc::clone(&handler);
    let hook_events = handler.subscribe_lifecycle_events();
    let hook_shutdown = connection_shutdown_rx.clone();
    let hook_task = tokio::spawn(async move {
        hook_handler
            .consume_lifecycle_hooks(hook_events, hook_shutdown)
            .await;
    });

    loop {
        drain_finished_connection_tasks(&mut connection_tasks);

        tokio::select! {
            result = listener.accept() => {
                let (stream, requester) = match result {
                    Ok(accepted) => accepted,
                    Err(error) => {
                        warn!("client accept failed; keeping server accept loop alive: {error}");
                        tokio::time::sleep(Duration::from_millis(25)).await;
                        continue;
                    }
                };
                let handler = Arc::clone(&handler);
                let connection_shutdown = connection_shutdown_rx.clone();
                let shutdown_handle = shutdown_handle.clone();

                connection_tasks.spawn(async move {
                    let connection_id = handler.allocate_connection_id();
                    let result = serve_connection(stream, requester, Arc::clone(&handler), connection_id, connection_shutdown, shutdown_handle).await;
                    handler.cleanup_connection_subscriptions(connection_id).await;
                    handler.cleanup_connection_sdk_waits(connection_id).await;
                    result
                });
            }
            _ = &mut shutdown => {
                debug!("shutdown requested");
                break;
            }
        }
    }

    drop(connection_shutdown);

    while let Some(result) = connection_tasks.join_next().await {
        log_connection_task_result(result);
    }
    if let Err(error) = hook_task.await {
        warn!("lifecycle hook task failed: {error}");
    }

    Ok(())
}

/// Read-dispatch-write loop for a single client connection.
async fn serve_connection(
    stream: LocalStream,
    requester: PeerIdentity,
    handler: Arc<RequestHandler>,
    connection_id: u64,
    mut shutdown: watch::Receiver<()>,
    shutdown_handle: ShutdownHandle,
) -> io::Result<()> {
    let Some(access_mode) = handler.access_mode_for_peer(&requester) else {
        let mut conn = Connection::new(stream);
        conn.write_response(&Response::Error(ErrorResponse {
            error: rmux_proto::RmuxError::Server("access not allowed".to_owned()),
        }))
        .await?;
        return Ok(());
    };
    let mut conn = Connection::new(stream);

    loop {
        tokio::select! {
            request = conn.read_request() => {
                let Some(request) = request? else {
                    return Ok(());
                };
                let request = match apply_access_policy(request, access_mode.can_write()) {
                    Ok(request) => request,
                    Err(error) => {
                        conn.write_response(&Response::Error(ErrorResponse { error })).await?;
                        continue;
                    }
                };

                let cancel_on_peer_disconnect = request_cancels_on_peer_disconnect(&request);
                debug!("dispatching {}", request.command_name());
                let outcome = tokio::select! {
                    outcome = handler.dispatch_for_connection(requester.pid, connection_id, request) => outcome,
                    result = shutdown.changed() => {
                        if result.is_ok() {
                            debug!("closing client connection during shutdown");
                        }
                        return Ok(());
                    }
                    result = wait_for_peer_close(&conn.stream), if cancel_on_peer_disconnect => {
                        result?;
                        debug!("closing client connection after peer disconnect");
                        return Ok(());
                    }
                };
                conn.write_response(&outcome.response).await?;
                if handler.request_shutdown_if_pending() {
                    return Ok(());
                }

                if let Some(attach) = outcome.attach {
                    let Response::AttachSession(response) = &outcome.response else {
                        return Err(io::Error::other(
                            "attach upgrade requires an attach-session response",
                        ));
                    };
                    let session_name = response.session_name.clone();
                    let terminal_context = attach.target.outer_terminal.context().clone();
                    let attach_id = handler
                        .register_attach_with_access(
                            requester.pid,
                            session_name.clone(),
                            AttachRegistration {
                                control_tx: attach.control_tx,
                                closing: attach.closing.clone(),
                                persistent_overlay_epoch: attach.persistent_overlay_epoch.clone(),
                                terminal_context,
                                flags: attach.flags,
                                uid: requester.uid,
                                user: requester.user.clone(),
                                can_write: access_mode.can_write(),
                                client_size: attach.client_size,
                            },
                        )
                        .await;
                    handler.emit_client_attached(requester.pid, session_name).await;
                    let (stream, buffered_bytes) = conn.into_raw_parts();
                    if !buffered_bytes.is_empty() {
                        warn!(
                            buffered = buffered_bytes.len(),
                            "preserving buffered bytes at attach upgrade boundary"
                        );
                    }
                    let result = pane_io::forward_attach(
                        stream,
                        attach.target,
                        buffered_bytes,
                        shutdown,
                        attach.control_rx,
                        attach.closing,
                        attach.persistent_overlay_epoch,
                        pane_io::LiveAttachInputContext {
                            handler: Arc::clone(&handler),
                            attach_pid: requester.pid,
                        },
                    )
                    .await;
                    handler.finish_attach(requester.pid, attach_id).await;
                    return result;
                }
                if let Some(control_upgrade) = outcome.control {
                    let (server_event_tx, server_event_rx) = tokio::sync::mpsc::unbounded_channel::<ControlServerEvent>();
                    let closing = Arc::new(std::sync::atomic::AtomicBool::new(false));
                    let control_id = handler
                        .register_control_with_access(
                            requester.pid,
                            control_upgrade,
                            ControlRegistration {
                                event_tx: server_event_tx,
                                closing: closing.clone(),
                                uid: requester.uid,
                                user: requester.user.clone(),
                                can_write: access_mode.can_write(),
                            },
                        )
                        .await;
                    let (stream, buffered_bytes) = conn.into_raw_parts();
                    let result = control::forward_control(
                        stream,
                        Arc::clone(&handler),
                        requester.pid,
                        buffered_bytes,
                        shutdown,
                        server_event_rx,
                        ControlLifecycle {
                            closing,
                            shutdown_handle: shutdown_handle.clone(),
                        },
                    )
                    .await;
                    handler.finish_control(requester.pid, control_id).await;
                    return result;
                }
            }
            result = shutdown.changed() => {
                if result.is_ok() {
                    debug!("closing client connection during shutdown");
                }
                return Ok(());
            }
        }
    }
}

fn request_cancels_on_peer_disconnect(request: &Request) -> bool {
    matches!(
        request,
        Request::WaitFor(wait)
            if matches!(wait.mode, WaitForMode::Wait | WaitForMode::Lock)
    ) || matches!(request, Request::SdkWaitForOutput(_))
}

fn drain_finished_connection_tasks(tasks: &mut JoinSet<io::Result<()>>) {
    while let Some(result) = tasks.try_join_next() {
        log_connection_task_result(result);
    }
}

fn log_connection_task_result(result: Result<io::Result<()>, JoinError>) {
    match result {
        Ok(Ok(())) => {}
        Ok(Err(error)) => warn!("connection error: {error}"),
        Err(error) => warn!("connection task failed: {error}"),
    }
}

struct Connection {
    stream: LocalStream,
    decoder: FrameDecoder,
    read_buffer: [u8; 8192],
}

impl Connection {
    fn new(stream: LocalStream) -> Self {
        Self {
            stream,
            decoder: FrameDecoder::new(),
            read_buffer: [0; 8192],
        }
    }

    async fn read_request(&mut self) -> io::Result<Option<Request>> {
        loop {
            match self.decoder.next_frame::<Request>() {
                Ok(Some(request)) => return Ok(Some(request)),
                Ok(None) => {}
                Err(error) => {
                    let response = Response::Error(ErrorResponse { error });
                    self.write_response(&response).await?;
                    return Ok(None);
                }
            }

            let bytes_read = self.stream.read(&mut self.read_buffer).await?;
            if bytes_read == 0 {
                return Ok(None);
            }

            self.decoder.push_bytes(&self.read_buffer[..bytes_read]);
        }
    }

    async fn write_response(&mut self, response: &Response) -> io::Result<()> {
        let frame = encode_frame(response).map_err(io::Error::other)?;
        self.stream.write_all(&frame).await
    }

    fn into_raw_parts(self) -> (LocalStream, Vec<u8>) {
        let buffered_bytes = self.decoder.remaining_bytes().to_vec();
        (self.stream, buffered_bytes)
    }
}

#[cfg(unix)]
struct SocketCleanup {
    socket_path: PathBuf,
}

#[cfg(unix)]
impl SocketCleanup {
    fn new(socket_path: PathBuf) -> Self {
        Self { socket_path }
    }
}

#[cfg(unix)]
impl Drop for SocketCleanup {
    fn drop(&mut self) {
        let _ = remove_socket_file_if_present(&self.socket_path);
        for lock_path in startup_lock_paths(&self.socket_path) {
            let _ = remove_regular_file_if_present(&lock_path);
        }
    }
}

#[cfg(windows)]
struct SocketCleanup;

#[cfg(windows)]
impl SocketCleanup {
    fn new(_socket_path: PathBuf) -> Self {
        Self
    }
}

#[cfg(unix)]
fn remove_socket_file_if_present(path: &Path) -> io::Result<()> {
    match std::fs::symlink_metadata(path) {
        Ok(metadata) if metadata.file_type().is_socket() => std::fs::remove_file(path),
        Ok(_) => Ok(()),
        Err(error) if error.kind() == io::ErrorKind::NotFound => Ok(()),
        Err(error) => Err(error),
    }
}

#[cfg(unix)]
fn startup_lock_paths(socket_path: &Path) -> Vec<PathBuf> {
    let Some(parent) = socket_path.parent() else {
        return Vec::new();
    };
    let Some(file_name) = socket_path.file_name() else {
        return Vec::new();
    };

    let mut startup_lock_name = file_name.to_os_string();
    startup_lock_name.push(".startup-lock");
    let mut legacy_lock_name = file_name.to_os_string();
    legacy_lock_name.push(".lock");

    vec![
        parent.join(startup_lock_name),
        parent.join(legacy_lock_name),
    ]
}

#[cfg(unix)]
fn remove_regular_file_if_present(path: &Path) -> io::Result<()> {
    match std::fs::symlink_metadata(path) {
        Ok(metadata) if metadata.file_type().is_file() => std::fs::remove_file(path),
        Ok(_) => Ok(()),
        Err(error) if error.kind() == io::ErrorKind::NotFound => Ok(()),
        Err(error) => Err(error),
    }
}

#[cfg(all(test, unix))]
mod tests {
    use super::*;
    use rmux_proto::{
        ErrorResponse, HandshakeRequest, RmuxError, WaitForMode, WaitForRequest, WaitForResponse,
        RMUX_WIRE_VERSION,
    };

    #[tokio::test]
    async fn client_disconnect_cancels_plain_waiter() -> io::Result<()> {
        let handler = Arc::new(RequestHandler::new());
        let (mut client, _shutdown_tx, connection_task) = spawn_test_connection(&handler)?;

        write_test_request(&mut client, wait_for("disconnect-plain", WaitForMode::Wait)).await?;
        yield_until_counts(&handler, "disconnect-plain", (1, 0, false)).await;

        drop(client);

        yield_until_counts(&handler, "disconnect-plain", (0, 0, false)).await;
        connection_task.await.expect("connection task")?;
        Ok(())
    }

    #[tokio::test]
    async fn client_disconnect_cancels_queued_lock_waiter() -> io::Result<()> {
        let handler = Arc::new(RequestHandler::new());
        assert_eq!(
            handler
                .handle(wait_for("disconnect-lock", WaitForMode::Lock))
                .await,
            Response::WaitFor(WaitForResponse)
        );
        let (mut client, _shutdown_tx, connection_task) = spawn_test_connection(&handler)?;

        write_test_request(&mut client, wait_for("disconnect-lock", WaitForMode::Lock)).await?;
        yield_until_counts(&handler, "disconnect-lock", (0, 1, true)).await;

        drop(client);

        yield_until_counts(&handler, "disconnect-lock", (0, 0, true)).await;
        connection_task.await.expect("connection task")?;
        assert_eq!(
            handler
                .handle(wait_for("disconnect-lock", WaitForMode::Unlock))
                .await,
            Response::WaitFor(WaitForResponse)
        );
        assert!(matches!(
            handler
                .handle(wait_for("disconnect-lock", WaitForMode::Unlock))
                .await,
            Response::Error(ErrorResponse {
                error: RmuxError::Message(_),
            })
        ));
        Ok(())
    }

    #[tokio::test]
    async fn read_request_sends_framed_error_for_unsupported_wire_version() -> io::Result<()> {
        let (server, mut client) = LocalStream::pair()?;
        let mut connection = Connection::new(server);
        let read_task = tokio::spawn(async move { connection.read_request().await });

        let mut frame = encode_frame(&wait_for("bad-wire-version", WaitForMode::Signal))
            .map_err(io::Error::other)?;
        assert_eq!(frame.get(1).copied(), Some(RMUX_WIRE_VERSION as u8));
        frame[1] = RMUX_WIRE_VERSION.saturating_add(1) as u8;
        client.write_all(&frame).await?;

        let response = read_test_response(&mut client).await?;
        assert!(matches!(
            response,
            Response::Error(ErrorResponse {
                error: RmuxError::UnsupportedWireVersion { .. },
            })
        ));
        assert!(read_task.await.expect("read task")?.is_none());
        Ok(())
    }

    #[tokio::test]
    async fn read_request_sends_framed_error_for_decode_mismatch() -> io::Result<()> {
        let (server, mut client) = LocalStream::pair()?;
        let mut connection = Connection::new(server);
        let read_task = tokio::spawn(async move { connection.read_request().await });

        let payload = 255_u32.to_le_bytes();
        let mut frame = vec![rmux_proto::RMUX_FRAME_MAGIC, RMUX_WIRE_VERSION as u8];
        frame.extend_from_slice(&(payload.len() as u32).to_le_bytes());
        frame.extend_from_slice(&payload);
        client.write_all(&frame).await?;

        let response = read_test_response(&mut client).await?;
        assert!(matches!(
            response,
            Response::Error(ErrorResponse {
                error: RmuxError::Decode(_),
            })
        ));
        assert!(read_task.await.expect("read task")?.is_none());
        Ok(())
    }

    #[tokio::test]
    async fn handshake_rejects_unsupported_wire_version_range() -> io::Result<()> {
        let handler = Arc::new(RequestHandler::new());
        let (mut client, _shutdown_tx, connection_task) = spawn_test_connection(&handler)?;

        write_test_request(
            &mut client,
            Request::Handshake(HandshakeRequest {
                minimum_wire_version: RMUX_WIRE_VERSION + 1,
                maximum_wire_version: RMUX_WIRE_VERSION + 1,
                required_capabilities: Vec::new(),
            }),
        )
        .await?;

        let response = read_test_response(&mut client).await?;
        assert!(matches!(
            response,
            Response::Error(ErrorResponse {
                error: RmuxError::UnsupportedWireVersion { .. },
            })
        ));

        drop(client);
        connection_task.await.expect("connection task")?;
        Ok(())
    }

    #[tokio::test]
    async fn handshake_rejects_unsupported_required_capability() -> io::Result<()> {
        let handler = Arc::new(RequestHandler::new());
        let (mut client, _shutdown_tx, connection_task) = spawn_test_connection(&handler)?;

        write_test_request(
            &mut client,
            Request::Handshake(HandshakeRequest::requiring(["capability.future"])),
        )
        .await?;

        let response = read_test_response(&mut client).await?;
        match response {
            Response::Error(ErrorResponse {
                error: RmuxError::UnsupportedCapability { feature, supported },
            }) => {
                assert_eq!(feature, "capability.future");
                assert!(supported
                    .iter()
                    .any(|capability| capability == "rpc.detached"));
            }
            response => panic!("expected unsupported capability error, got {response:?}"),
        }

        drop(client);
        connection_task.await.expect("connection task")?;
        Ok(())
    }

    fn spawn_test_connection(
        handler: &Arc<RequestHandler>,
    ) -> io::Result<(
        LocalStream,
        watch::Sender<()>,
        tokio::task::JoinHandle<io::Result<()>>,
    )> {
        let (server, client) = LocalStream::pair()?;
        let handler = Arc::clone(handler);
        let (shutdown_tx, shutdown_rx) = watch::channel(());
        let (shutdown_handle, _shutdown_request_rx) = ShutdownHandle::new();
        let connection_id = handler.allocate_connection_id();
        let task = tokio::spawn(async move {
            let result = serve_connection(
                server,
                PeerIdentity {
                    pid: std::process::id(),
                    uid: rmux_os::identity::real_user_id(),
                    user: rmux_os::identity::UserIdentity::Uid(rmux_os::identity::real_user_id()),
                },
                Arc::clone(&handler),
                connection_id,
                shutdown_rx,
                shutdown_handle,
            )
            .await;
            handler
                .cleanup_connection_subscriptions(connection_id)
                .await;
            handler.cleanup_connection_sdk_waits(connection_id).await;
            result
        });
        Ok((client, shutdown_tx, task))
    }

    fn wait_for(channel: &str, mode: WaitForMode) -> Request {
        Request::WaitFor(WaitForRequest {
            channel: channel.to_owned(),
            mode,
        })
    }

    async fn write_test_request(stream: &mut LocalStream, request: Request) -> io::Result<()> {
        let frame = encode_frame(&request).map_err(io::Error::other)?;
        stream.write_all(&frame).await
    }

    async fn read_test_response(stream: &mut LocalStream) -> io::Result<Response> {
        let mut decoder = FrameDecoder::new();
        let mut buffer = [0_u8; 512];

        loop {
            if let Some(response) = decoder.next_frame::<Response>().map_err(io::Error::other)? {
                return Ok(response);
            }

            let bytes_read = stream.read(&mut buffer).await?;
            if bytes_read == 0 {
                return Err(io::Error::new(
                    io::ErrorKind::UnexpectedEof,
                    "server closed before response frame",
                ));
            }
            decoder.push_bytes(&buffer[..bytes_read]);
        }
    }

    async fn yield_until_counts(
        handler: &RequestHandler,
        channel: &str,
        expected: (usize, usize, bool),
    ) {
        for _ in 0..200 {
            if handler.wait_for_counts(channel) == expected {
                return;
            }
            tokio::time::sleep(std::time::Duration::from_millis(1)).await;
        }

        assert_eq!(handler.wait_for_counts(channel), expected);
    }
}