rmcl 0.4.0

A fully featured Minecraft TUI launcher
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167

use super::*;
use crate::instance::models::ModLoader;
use tempfile::TempDir;

// tmp owns the temp directory; its Drop impl cleans up everything when
// the test ends. the returned InstanceManager points at tmp.path() so
// tests can join("name") off of either to refer to the same locations.
fn test_manager() -> (InstanceManager, TempDir) {
    let tmp = tempfile::tempdir().unwrap();
    let meta = tmp.path().join("meta");
    std::fs::create_dir_all(&meta).unwrap();
    (InstanceManager::new(tmp.path().to_path_buf(), meta), tmp)
}

fn dummy_config(name: &str) -> InstanceConfig {
    InstanceConfig {
        name: name.to_string(),
        game_version: "1.20.1".to_string(),
        loader: ModLoader::Vanilla,
        loader_version: None,
        created: chrono::Utc::now(),
        last_played: None,
        java_path: None,
        memory_max: None,
        memory_min: None,
        jvm_args: vec![],
        resolution: None,
        config_sync_profile: None,
        modpack_source: None,
    }
}

#[test]
fn validate_name_accepts_safe_names() {
    assert!(validate_name("my-instance").is_ok());
    assert!(validate_name("test_world").is_ok());
}

#[test]
fn validate_name_rejects_empty_traversal_and_hidden() {
    assert!(validate_name("").is_err());
    assert!(validate_name("path/traversal").is_err());
    assert!(validate_name(".hidden").is_err());
}

#[test]
fn delete_missing_instance_returns_not_found() {
    let (manager, _tmp) = test_manager();
    let result = manager.delete("ghost-instance");
    assert!(matches!(result, Err(InstanceError::NotFound(_))));
}

#[test]
fn save_then_load_all_round_trips_config() {
    let (manager, tmp) = test_manager();
    std::fs::create_dir_all(tmp.path().join("test-save")).unwrap();
    manager.save(&dummy_config("test-save")).expect("save");

    let all = manager.load_all();
    assert_eq!(all.len(), 1);
    assert_eq!(all[0].name, "test-save");
    assert_eq!(all[0].game_version, "1.20.1");
}

#[test]
fn load_all_accepts_numeric_memory() {
    let (manager, tmp) = test_manager();
    let instance_dir = tmp.path().join("test-memory");
    std::fs::create_dir_all(&instance_dir).unwrap();
    std::fs::write(
        instance_dir.join("instance.json"),
        r#"{
  "name": "test-memory",
  "game_version": "1.7.10",
  "loader": "forge",
  "loader_version": "10.13.4.1614",
  "created": "2026-04-20T18:04:25.567993893Z",
  "memory_max": 8,
  "memory_min": 512
}"#,
    )
    .expect("write config");

    let all = manager.load_all();
    assert_eq!(all.len(), 1);
    assert_eq!(all[0].memory_max.as_deref(), Some("8G"));
    assert_eq!(all[0].memory_min.as_deref(), Some("512M"));
}

#[test]
fn load_one_missing_returns_not_found() {
    let (manager, _tmp) = test_manager();
    let result = manager.load_one("ghost-instance");
    assert!(matches!(result, Err(InstanceError::NotFound(_))));
}

#[test]
fn rename_moves_dir_and_updates_config_name() {
    let (manager, tmp) = test_manager();
    let old_dir = tmp.path().join("old-name");
    std::fs::create_dir_all(&old_dir).unwrap();
    manager.save(&dummy_config("old-name")).expect("save");

    manager.rename("old-name", "new-name").expect("rename");

    assert!(!old_dir.exists(), "old dir should be gone");
    let new_dir = tmp.path().join("new-name");
    assert!(new_dir.exists(), "new dir should exist");
    let reloaded = manager.load_one("new-name").expect("load_one new-name");
    assert_eq!(reloaded.name, "new-name");
}

#[test]
fn rename_to_same_name_is_noop() {
    let (manager, tmp) = test_manager();
    let dir = tmp.path().join("same");
    std::fs::create_dir_all(&dir).unwrap();
    manager.save(&dummy_config("same")).expect("save");
    manager.rename("same", "same").expect("noop rename");
    assert!(dir.exists());
}

#[test]
fn rename_empty_target_rejects() {
    let (manager, tmp) = test_manager();
    std::fs::create_dir_all(tmp.path().join("orig")).unwrap();
    manager.save(&dummy_config("orig")).expect("save");
    let err = manager.rename("orig", "   ").unwrap_err();
    assert!(matches!(err, InstanceError::InvalidName(_)));
}

#[test]
fn rename_missing_source_errors() {
    let (manager, _tmp) = test_manager();
    let err = manager.rename("ghost", "anything").unwrap_err();
    assert!(matches!(err, InstanceError::NotFound(_)));
}

#[test]
fn rename_target_exists_errors() {
    let (manager, tmp) = test_manager();
    std::fs::create_dir_all(tmp.path().join("source")).unwrap();
    std::fs::create_dir_all(tmp.path().join("collision")).unwrap();
    manager.save(&dummy_config("source")).expect("save src");
    manager.save(&dummy_config("collision")).expect("save dst");
    let err = manager.rename("source", "collision").unwrap_err();
    assert!(matches!(err, InstanceError::AlreadyExists(_)));
}

#[test]
fn touch_last_played_updates_field() {
    let (manager, tmp) = test_manager();
    std::fs::create_dir_all(tmp.path().join("ticker")).unwrap();
    manager.save(&dummy_config("ticker")).expect("save");
    assert!(manager.load_one("ticker").unwrap().last_played.is_none());

    manager.touch_last_played("ticker").expect("touch");
    let reloaded = manager.load_one("ticker").unwrap();
    let stamp = reloaded
        .last_played
        .expect("last_played should be Some now");
    let age = chrono::Utc::now() - stamp;
    assert!(
        age.num_seconds().abs() < 5,
        "last_played should be roughly now, got age {age:?}"
    );
}