rlsp-yaml 0.9.0

A fast, lightweight YAML language server
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
// SPDX-License-Identifier: MIT

use std::collections::HashMap;

use rlsp_yaml_parser::node::{Document, Node};
use rlsp_yaml_parser::{Pos, Span};
use tower_lsp::lsp_types::{Position, Range, TextEdit, Url, WorkspaceEdit};

/// Prepare rename: validates cursor is on anchor/alias, returns name range.
///
/// Returns `None` if the cursor is not on an anchor or alias, or `docs` is empty.
#[must_use]
pub fn prepare_rename(docs: &[Document<Span>], position: Position) -> Option<Range> {
    let cursor = lsp_to_pos(position);
    let doc = containing_document(docs, cursor)?;
    let (anchors, aliases) = collect_anchor_alias_entries(doc);

    anchors
        .iter()
        .find(|(_, loc)| span_contains(*loc, cursor))
        .or_else(|| aliases.iter().find(|(_, loc)| span_contains(*loc, cursor)))
        .map(|(_, loc)| span_to_range(*loc))
}

/// Rename: returns edits for all occurrences of anchor and aliases.
///
/// Returns `None` if the cursor is not on an anchor or alias, the new name
/// is invalid, or `docs` is empty.
#[must_use]
pub fn rename(
    docs: &[Document<Span>],
    uri: &Url,
    position: Position,
    new_name: &str,
) -> Option<WorkspaceEdit> {
    if !is_valid_anchor_name(new_name) {
        return None;
    }

    let cursor = lsp_to_pos(position);
    let doc = containing_document(docs, cursor)?;
    let (anchors, aliases) = collect_anchor_alias_entries(doc);

    let name = anchors
        .iter()
        .find(|(_, loc)| span_contains(*loc, cursor))
        .map(|(n, _)| n.as_str())
        .or_else(|| {
            aliases
                .iter()
                .find(|(_, loc)| span_contains(*loc, cursor))
                .map(|(n, _)| n.as_str())
        })?;

    let anchor_edits = anchors
        .iter()
        .filter(|(n, _)| n == name)
        .map(|(_, loc)| TextEdit {
            range: span_to_range(*loc),
            new_text: format!("&{new_name}"),
        });

    let alias_edits = aliases
        .iter()
        .filter(|(n, _)| n == name)
        .map(|(_, loc)| TextEdit {
            range: span_to_range(*loc),
            new_text: format!("*{new_name}"),
        });

    let edits: Vec<TextEdit> = anchor_edits.chain(alias_edits).collect();

    let mut changes = HashMap::new();
    changes.insert(uri.clone(), edits);

    Some(WorkspaceEdit {
        changes: Some(changes),
        ..WorkspaceEdit::default()
    })
}

/// Validate that a proposed new anchor name is valid.
fn is_valid_anchor_name(name: &str) -> bool {
    !name.is_empty() && name.len() <= 256 && name.chars().all(is_anchor_name_char)
}

/// Check if a character is valid in a YAML anchor/alias name.
const fn is_anchor_name_char(ch: char) -> bool {
    ch.is_ascii_alphanumeric() || ch == '-' || ch == '_' || ch == '.'
}

type NamedSpans = Vec<(String, Span)>;

/// Walk a single document and collect `(name, span)` pairs for every anchor
/// token and every alias token.
fn collect_anchor_alias_entries(doc: &Document<Span>) -> (NamedSpans, NamedSpans) {
    let mut anchors = Vec::new();
    let mut aliases = Vec::new();
    collect_node(&doc.root, &mut anchors, &mut aliases);
    (anchors, aliases)
}

fn collect_node(node: &Node<Span>, anchors: &mut NamedSpans, aliases: &mut NamedSpans) {
    match node {
        Node::Scalar {
            anchor, anchor_loc, ..
        }
        | Node::Mapping {
            anchor, anchor_loc, ..
        }
        | Node::Sequence {
            anchor, anchor_loc, ..
        } => {
            if let (Some(name), Some(loc)) = (anchor, anchor_loc) {
                anchors.push((name.clone(), *loc));
            }
        }
        Node::Alias { name, loc, .. } => {
            aliases.push((name.clone(), *loc));
        }
    }
    match node {
        Node::Mapping { entries, .. } => {
            for (k, v) in entries {
                collect_node(k, anchors, aliases);
                collect_node(v, anchors, aliases);
            }
        }
        Node::Sequence { items, .. } => {
            for item in items {
                collect_node(item, anchors, aliases);
            }
        }
        Node::Scalar { .. } | Node::Alias { .. } => {}
    }
}

/// Find the document whose root span contains the cursor.
fn containing_document(docs: &[Document<Span>], cursor: Pos) -> Option<&Document<Span>> {
    docs.iter()
        .find(|doc| span_contains(node_loc(&doc.root), cursor))
}

const fn node_loc(node: &Node<Span>) -> Span {
    match node {
        Node::Scalar { loc, .. }
        | Node::Mapping { loc, .. }
        | Node::Sequence { loc, .. }
        | Node::Alias { loc, .. } => *loc,
    }
}

fn span_contains(span: Span, cursor: Pos) -> bool {
    let start = (span.start.line, span.start.column);
    let end = (span.end.line, span.end.column);
    let pos = (cursor.line, cursor.column);
    pos >= start && pos < end
}

/// Convert an LSP `Position` (0-based line, 0-based character) to a parser `Pos`
/// (1-based line, 0-based column).
const fn lsp_to_pos(position: Position) -> Pos {
    Pos {
        byte_offset: 0,
        line: position.line as usize + 1,
        column: position.character as usize,
    }
}

/// Convert a parser `Span` to an LSP `Range`.
fn span_to_range(loc: Span) -> Range {
    #[expect(
        clippy::cast_possible_truncation,
        reason = "LSP line/col are u32; always fits"
    )]
    Range::new(
        Position::new(
            loc.start.line.saturating_sub(1) as u32,
            loc.start.column as u32,
        ),
        Position::new(loc.end.line.saturating_sub(1) as u32, loc.end.column as u32),
    )
}

#[cfg(test)]
#[expect(clippy::expect_used, reason = "test code")]
mod tests {
    use rstest::rstest;

    use super::*;
    use crate::test_utils::{parse_docs, test_uri};

    fn parse(yaml: &str) -> Vec<Document<Span>> {
        parse_docs(yaml)
    }

    fn pos(line: u32, character: u32) -> Position {
        Position::new(line, character)
    }

    // ---- prepare_rename: Happy Path ----

    // PR-1
    #[test]
    fn should_return_range_when_cursor_on_anchor() {
        let docs = parse("key: &myanchor value\n");
        let result = prepare_rename(&docs, pos(0, 6));

        let range = result.expect("should return a range");
        assert_eq!(range.start.line, 0);
        assert_eq!(range.start.character, 5, "&myanchor starts at column 5");
        assert_eq!(range.end.character, 14, "&myanchor ends at column 14");
    }

    // PR-2
    #[test]
    fn should_return_range_when_cursor_on_alias() {
        let docs = parse("defaults: &defaults\n  key: val\nproduction:\n  <<: *defaults\n");
        let result = prepare_rename(&docs, pos(3, 7));

        let range = result.expect("should return a range");
        assert_eq!(range.start.line, 3);
        assert!(range.start.character <= 7);
        assert!(range.end.character > 7);
    }

    // PR-3
    #[test]
    fn should_return_range_when_cursor_at_end_of_anchor_name() {
        let docs = parse("key: &anchor value\n");
        // &anchor is at col [5,12) — col 11 is the last char inside the span
        let result = prepare_rename(&docs, pos(0, 11));

        let range = result.expect("should return a range");
        assert_eq!(range.start.line, 0);
        assert_eq!(range.start.character, 5);
    }

    // PR-4
    #[test]
    fn prepare_rename_cursor_at_first_char_of_anchor() {
        let docs = parse("x: &anchor\n");
        // &anchor at col [3,10)
        let result = prepare_rename(&docs, pos(0, 3));
        assert!(result.is_some());
    }

    // PR-5
    #[test]
    fn prepare_rename_cursor_one_past_anchor_token_returns_none() {
        let docs = parse("x: &anchor\n");
        // &anchor is at cols [3,10) — col 10 is past the end (half-open)
        let result = prepare_rename(&docs, pos(0, 10));
        assert!(result.is_none());
    }

    // PR-6
    #[test]
    fn prepare_rename_cursor_in_middle_of_anchor_name_returns_full_range() {
        let docs = parse("key: &longname value\n");
        // &longname starts at col 5, ends at col 13 (8 chars: & + longname)
        let result = prepare_rename(&docs, pos(0, 8));

        let range = result.expect("should return a range");
        assert_eq!(range.start.character, 5, "&longname starts at col 5");
        assert_eq!(
            range.end.character, 14,
            "&longname ends at col 14 (& + 8 chars)"
        );
    }

    // PR-7 — Edge cases
    #[rstest]
    #[case::not_on_anchor_or_alias("key: value\n", 0, 0)]
    #[case::empty_document("", 0, 0)]
    #[case::beyond_document_lines("key: &anchor value\n", 10, 0)]
    #[case::beyond_line_length("key: &anchor value\n", 0, 100)]
    #[case::anchor_in_comment("# &fake\nkey: value\n", 0, 2)]
    #[case::cursor_at_exact_end_of_line_not_in_token("key: &anchor\n", 0, 12)]
    #[case::cursor_at_document_end_not_in_token("key: &anchor", 0, 12)]
    fn prepare_rename_returns_none(#[case] text: &str, #[case] line: u32, #[case] character: u32) {
        let docs = parse(text);
        let result = prepare_rename(&docs, pos(line, character));
        assert!(result.is_none());
    }

    // ---- rename: Happy Path ----

    // RN-1
    #[rstest]
    #[case::anchor_and_single_alias(
        "defaults: &old\n  key: val\nproduction:\n  <<: *old\n",
        0,
        10,
        "new",
        2
    )]
    #[case::anchor_and_multiple_aliases(
        "defaults: &shared\n  key: val\ndev:\n  <<: *shared\nprod:\n  <<: *shared\n",
        0,
        10,
        "common",
        3
    )]
    #[case::cursor_on_alias(
        "defaults: &old\n  key: val\nproduction:\n  <<: *old\n",
        3,
        7,
        "new",
        2
    )]
    #[case::anchor_with_no_aliases("key: &lonely value\n", 0, 5, "orphan", 1)]
    #[case::not_across_document_boundaries(
        "doc1: &name\n  ref: *name\n---\ndoc2: &name\n  ref: *name\n",
        0,
        6,
        "renamed",
        2
    )]
    #[case::within_second_document(
        "doc1: &name\n---\ndoc2: &name\n  ref: *name\n",
        2,
        6,
        "other",
        2
    )]
    fn rename_returns_edits_len(
        #[case] text: &str,
        #[case] line: u32,
        #[case] character: u32,
        #[case] new_name: &str,
        #[case] expected_len: usize,
    ) {
        let uri = test_uri();
        let docs = parse(text);
        let result = rename(&docs, &uri, pos(line, character), new_name);
        let edit = result.expect("should return WorkspaceEdit");
        let changes = edit.changes.expect("should have changes");
        let edits = changes.get(&uri).expect("should have edits for uri");
        assert_eq!(edits.len(), expected_len);
    }

    // RN-2
    #[test]
    fn should_produce_correct_edit_ranges() {
        let text = "key: &old value\nref: *old\n";
        let uri = test_uri();
        let docs = parse(text);
        let result = rename(&docs, &uri, pos(0, 5), "new");

        let edit = result.expect("should return WorkspaceEdit");
        let changes = edit.changes.expect("should have changes");
        let edits = changes.get(&uri).expect("should have edits for uri");
        assert_eq!(edits.len(), 2);

        // anchor edit
        let anchor_edit = edits
            .iter()
            .find(|e| e.new_text == "&new")
            .expect("anchor edit");
        assert_eq!(anchor_edit.range.start.line, 0);
        assert_eq!(anchor_edit.range.start.character, 5);
        assert_eq!(anchor_edit.range.end.line, 0);
        assert_eq!(anchor_edit.range.end.character, 9);

        // alias edit
        let alias_edit = edits
            .iter()
            .find(|e| e.new_text == "*new")
            .expect("alias edit");
        assert_eq!(alias_edit.range.start.line, 1);
        assert_eq!(alias_edit.range.start.character, 5);
        assert_eq!(alias_edit.range.end.line, 1);
        assert_eq!(alias_edit.range.end.character, 9);
    }

    // RN-3
    #[test]
    fn rename_anchor_on_mapping_collection_edits_token_span_not_body() {
        // &d annotates a mapping; anchor_loc must be the &d token, not the mapping body
        let text = "defaults: &d\n  k: v\nref: *d\n";
        let uri = test_uri();
        let docs = parse(text);
        // anchor_loc for &d: col 10-12 on line 0
        let result = rename(&docs, &uri, pos(0, 10), "renamed");

        let edit = result.expect("should return WorkspaceEdit");
        let changes = edit.changes.expect("should have changes");
        let edits = changes.get(&uri).expect("should have edits for uri");
        assert_eq!(edits.len(), 2);

        let anchor_edit = edits
            .iter()
            .find(|e| e.new_text == "&renamed")
            .expect("anchor edit");
        // token &d is on line 0
        assert_eq!(
            anchor_edit.range.start.line, 0,
            "anchor edit must be on line 0 (token), not the mapping body"
        );
        assert_eq!(anchor_edit.range.start.character, 10, "&d starts at col 10");
        assert_eq!(anchor_edit.range.end.character, 12, "&d ends at col 12");
    }

    // RN-4
    #[test]
    fn rename_anchor_on_sequence_edits_token_span_not_body() {
        // &seq annotates a sequence; anchor_loc must be the &seq token, not the sequence body
        let text = "items: &seq\n  - a\n  - b\nref: *seq\n";
        let uri = test_uri();
        let docs = parse(text);
        // anchor_loc for &seq: col 7-11 on line 0
        let result = rename(&docs, &uri, pos(0, 7), "renamed");

        let edit = result.expect("should return WorkspaceEdit");
        let changes = edit.changes.expect("should have changes");
        let edits = changes.get(&uri).expect("should have edits for uri");
        assert_eq!(edits.len(), 2);

        let anchor_edit = edits
            .iter()
            .find(|e| e.new_text == "&renamed")
            .expect("anchor edit");
        assert_eq!(
            anchor_edit.range.start.line, 0,
            "anchor edit must be on line 0 (token)"
        );
        assert_eq!(anchor_edit.range.start.character, 7, "&seq starts at col 7");
        assert_eq!(anchor_edit.range.end.character, 11, "&seq ends at col 11");
    }

    // RN-5
    #[test]
    fn rename_does_not_cross_document_boundary_to_second_doc() {
        let text = "doc1: &name\n  ref: *name\n---\ndoc2: &name\n  ref: *name\n";
        let uri = test_uri();
        let docs = parse(text);
        let result = rename(&docs, &uri, pos(0, 6), "renamed");

        let edit = result.expect("should return WorkspaceEdit");
        let changes = edit.changes.expect("should have changes");
        let edits = changes.get(&uri).expect("should have edits for uri");
        assert_eq!(edits.len(), 2, "only doc 1 edits");
        for e in edits {
            assert!(
                e.range.start.line < 3,
                "no edit should be on doc 2 lines (line {})",
                e.range.start.line
            );
        }
    }

    // RN-6
    #[test]
    fn rename_does_not_cross_document_boundary_to_first_doc() {
        let text = "doc1: &name\n  ref: *name\n---\ndoc2: &name\n  ref: *name\n";
        let uri = test_uri();
        let docs = parse(text);
        let result = rename(&docs, &uri, pos(3, 6), "renamed");

        let edit = result.expect("should return WorkspaceEdit");
        let changes = edit.changes.expect("should have changes");
        let edits = changes.get(&uri).expect("should have edits for uri");
        assert_eq!(edits.len(), 2, "only doc 2 edits");
        for e in edits {
            assert!(
                e.range.start.line >= 3,
                "no edit should be on doc 1 lines (line {})",
                e.range.start.line
            );
        }
    }

    // RN-7
    #[test]
    fn rename_utf8_anchor_name_produces_correct_column_ranges() {
        // x: &résumé\nref: *résumé\n
        // anchor_loc: start col=3, end col=10 (& + résumé = 7 codepoints)
        // alias loc: start col=5, end col=12
        let text = "x: &résumé\nref: *résumé\n";
        let uri = test_uri();
        let docs = parse(text);
        let result = rename(&docs, &uri, pos(0, 3), "newname");

        let edit = result.expect("should return WorkspaceEdit");
        let changes = edit.changes.expect("should have changes");
        let edits = changes.get(&uri).expect("should have edits for uri");
        assert_eq!(edits.len(), 2);

        let anchor_edit = edits
            .iter()
            .find(|e| e.new_text == "&newname")
            .expect("anchor edit");
        assert_eq!(
            anchor_edit.range.start.character, 3,
            "anchor starts at col 3"
        );
        assert_eq!(
            anchor_edit.range.end.character, 10,
            "anchor ends at col 10 (3 + 7 codepoints)"
        );

        let alias_edit = edits
            .iter()
            .find(|e| e.new_text == "*newname")
            .expect("alias edit");
        assert_eq!(alias_edit.range.start.character, 5, "alias starts at col 5");
        assert_eq!(
            alias_edit.range.end.character, 12,
            "alias ends at col 12 (5 + 7 codepoints)"
        );
    }

    // ---- rename: Invalid Position Cases ----

    // RN-8
    #[rstest]
    #[case::cursor_not_on_anchor_or_alias("key: value\n", 0, 0, "anything")]
    #[case::empty_document("", 0, 0, "anything")]
    #[case::beyond_document_lines("key: &anchor value\n", 10, 0, "anything")]
    #[case::beyond_line_length("key: &anchor value\n", 0, 100, "anything")]
    fn rename_returns_none_invalid_position(
        #[case] text: &str,
        #[case] line: u32,
        #[case] character: u32,
        #[case] new_name: &str,
    ) {
        let uri = test_uri();
        let docs = parse(text);
        let result = rename(&docs, &uri, pos(line, character), new_name);
        assert!(result.is_none());
    }

    // ---- rename: Invalid new_name Validation (Security Cases) ----

    // RN-9
    #[rstest]
    #[case::empty_name("")]
    #[case::spaces("has space")]
    #[case::open_bracket("bad[name")]
    #[case::close_bracket("bad]name")]
    #[case::open_brace("bad{name")]
    #[case::close_brace("bad}name")]
    #[case::colon("bad:name")]
    #[case::comma("bad,name")]
    #[case::whitespace_only("   ")]
    #[case::hash("name#comment")]
    #[case::newline("name\n")]
    #[case::tab("name\t")]
    #[case::carriage_return("name\r")]
    #[case::ampersand("name&other")]
    #[case::asterisk("name*other")]
    #[case::exclamation("name!tag")]
    fn rename_rejects_invalid_new_name(#[case] new_name: &str) {
        let text = "key: &anchor value\n";
        let uri = test_uri();
        let docs = parse(text);
        let result = rename(&docs, &uri, pos(0, 5), new_name);
        assert!(result.is_none());
    }

    // ---- rename: Valid new_name Validation ----

    // RN-10
    #[rstest]
    #[case::hyphen("valid-name")]
    #[case::underscore("valid_name")]
    #[case::dot("valid.name")]
    #[case::starts_with_digit("123abc")]
    fn rename_accepts_valid_new_name(#[case] new_name: &str) {
        let text = "key: &anchor value\n";
        let uri = test_uri();
        let docs = parse(text);
        let result = rename(&docs, &uri, pos(0, 5), new_name);
        assert!(result.is_some());
    }

    // RN-11
    #[test]
    fn should_reject_new_name_exceeding_max_length() {
        let text = "key: &anchor value\n";
        let uri = test_uri();
        let docs = parse(text);
        let long_name = "a".repeat(257);
        let result = rename(&docs, &uri, pos(0, 5), &long_name);
        assert!(
            result.is_none(),
            "name longer than 256 chars must be rejected"
        );
    }

    // RN-12
    #[test]
    fn should_accept_new_name_at_exactly_max_length() {
        let text = "key: &anchor value\n";
        let uri = test_uri();
        let docs = parse(text);
        let max_name = "a".repeat(256);
        let result = rename(&docs, &uri, pos(0, 5), &max_name);
        assert!(
            result.is_some(),
            "name of exactly 256 chars must be accepted"
        );
    }
}