rightkit-sync 0.1.1

Brand-neutral desktop/mobile cloud sync engine: change tokens, tombstones, last-writer-wins conflicts, resumable batches, offline queue, retry/backoff.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
//! The sync pass. One `run_pass` mirrors the iOS `sync()` actor method and the
//! desktop `Coordinator::sync_pass`; see API.md for the shared contract.

use std::collections::{BTreeMap, BTreeSet, HashSet};
use std::sync::Arc;
use std::time::{Duration, Instant};

use crate::backoff::BackoffPolicy;
use crate::error::{SyncError, SyncResult};
use crate::ledger::{LedgerStore, RemoteVersion};
use crate::record::{field, read_tombstone, write_tombstone, FieldValue, RawRecord};
use crate::storage::LedgerStorage;
use crate::traits::*;

#[derive(Debug, Clone)]
pub struct SyncConfig {
    /// Upload chunk size for edits to records that already exist remotely.
    pub batch_size: usize,
    /// Tombstone write chunk size.
    pub tombstone_batch: usize,
    /// Publish never-seen items one record per save, oldest first, and stop
    /// new publication for the pass after the first failure (preserves
    /// history order: CloudKit gives no ordering inside one operation).
    pub ordered_new_publication: bool,
    /// Treat a known-published item that vanished from the local store as a
    /// local deletion (desktop). Apps with explicit `note_deleted` calls
    /// (iOS) leave this off.
    pub infer_local_deletions: bool,
    pub backoff: BackoffPolicy,
}

impl Default for SyncConfig {
    fn default() -> Self {
        Self {
            batch_size: 200,
            tombstone_batch: 50,
            ordered_new_publication: true,
            infer_local_deletions: false,
            backoff: BackoffPolicy::default(),
        }
    }
}

#[derive(Debug, Clone, PartialEq)]
pub enum PassOutcome {
    /// Everything applied; token advanced; no pending work.
    Synced,
    /// Token advanced but some uploads/tombstones/applies remain queued.
    Pending(String),
    /// Backoff window still open; nothing was attempted.
    Deferred {
        secs: f64,
    },
    Unavailable(String),
    Disabled,
    /// Auth generation changed or sync was switched off mid-pass.
    Cancelled,
    Failed(String),
}

#[derive(Debug, Clone, PartialEq)]
pub struct PassReport {
    pub outcome: PassOutcome,
    pub uploaded: usize,
    pub downloaded: usize,
    pub tombstones_applied: usize,
    pub tombstones_written: usize,
    pub quarantined: usize,
    pub blocked_reuploads: usize,
    /// Seconds until the next pass should run, when one is scheduled.
    pub retry_after_secs: Option<f64>,
}

impl PassReport {
    fn new() -> Self {
        Self {
            outcome: PassOutcome::Synced,
            uploaded: 0,
            downloaded: 0,
            tombstones_applied: 0,
            tombstones_written: 0,
            quarantined: 0,
            blocked_reuploads: 0,
            retry_after_secs: None,
        }
    }
}

/// Cumulative engine counters and current ledger queue sizes, from [`SyncEngine::metrics`].
/// Queue sizes are the figures that grow resident memory: the ledger keeps one remote
/// version per record and is serialized in full on every durable write.
#[derive(Debug, Clone, Copy, Default, PartialEq, Eq)]
pub struct SyncMetrics {
    /// Passes run since the engine was built (including deferred ones).
    pub passes: u64,
    /// Passes that ended `Failed` or `Unavailable`.
    pub failed_passes: u64,
    /// Wall-clock duration of the most recent pass, in milliseconds.
    pub last_pass_ms: u64,
    pub downloaded_total: u64,
    pub uploaded_total: u64,
    pub tombstones_applied_total: u64,
    pub tombstones_written_total: u64,
    /// Remote versions cached in the ledger (one per known record).
    pub remote_versions: u64,
    /// Tombstones the ledger blocks re-import of, forever.
    pub tombstones: u64,
    pub pending_uploads: u64,
    pub pending_tombstones: u64,
    /// Downloaded records whose local apply was deferred.
    pub pending_apply: u64,
}

/// Runtime figures of the engine, computed on call by [`SyncEngine::status`].
#[derive(Debug, Clone, Copy, PartialEq)]
pub struct SyncStatus {
    /// Pass counters and the ledger queue sizes (`pending_*`, `remote_versions`).
    pub metrics: SyncMetrics,
    /// Resident memory, CPU time and I/O counters of the whole process (the engine runs in it and
    /// has no thread of its own), or `None` when the host cannot report them. See
    /// `rightkit_child_process::ProcessUsage`.
    pub process: Option<rightkit_child_process::ProcessUsage>,
}

#[derive(Debug, Default)]
struct Counters {
    passes: u64,
    failed_passes: u64,
    last_pass_ms: u64,
    downloaded: u64,
    uploaded: u64,
    tombstones_applied: u64,
    tombstones_written: u64,
}

const MAX_CONFLICT_ROUNDS: usize = 4;

enum Resolved {
    /// Re-saved on top of the server's version.
    Saved,
    /// The server version stands (applied locally, tombstoned, or equal).
    RemoteWon,
    Failed(String),
}

enum RemoteState<T> {
    Live(T),
    Tombstone,
}

struct RemoteEntry<T> {
    id: String,
    record_name: String,
    /// updatedAt for live records, deletedAt for tombstones.
    version_ms: i64,
    state: RemoteState<T>,
    record: RawRecord,
}

impl<T> RemoteEntry<T> {
    fn is_tombstone(&self) -> bool {
        matches!(self.state, RemoteState::Tombstone)
    }
    /// Total order for alias reduction: tombstone > live, then newer
    /// version, then larger record name (deterministic on every device).
    fn rank(&self) -> (bool, i64, &str) {
        (
            self.is_tombstone(),
            self.version_ms,
            self.record_name.as_str(),
        )
    }
}

pub struct SyncEngine<M: RecordMapper> {
    mapper: Arc<M>,
    backend: Arc<dyn Backend>,
    auth: Arc<dyn AuthProvider>,
    local: Arc<dyn LocalStore<M::Item>>,
    policy: Box<dyn ConflictPolicy<M::Item>>,
    clock: Arc<dyn Clock>,
    observer: Arc<dyn SyncObserver>,
    hooks: Arc<dyn PassHooks>,
    config: SyncConfig,
    store: LedgerStore,
    replay_flags: Vec<String>,
    counters: Counters,
}

pub struct SyncEngineBuilder<M: RecordMapper> {
    mapper: Arc<M>,
    backend: Arc<dyn Backend>,
    local: Arc<dyn LocalStore<M::Item>>,
    storage: Box<dyn LedgerStorage>,
    auth: Arc<dyn AuthProvider>,
    policy: Box<dyn ConflictPolicy<M::Item>>,
    clock: Arc<dyn Clock>,
    observer: Arc<dyn SyncObserver>,
    hooks: Arc<dyn PassHooks>,
    config: SyncConfig,
}

impl<M: RecordMapper + 'static> SyncEngineBuilder<M> {
    pub fn new(
        mapper: Arc<M>,
        backend: Arc<dyn Backend>,
        local: Arc<dyn LocalStore<M::Item>>,
        storage: Box<dyn LedgerStorage>,
    ) -> Self
    where
        M::Item: 'static,
    {
        Self {
            mapper,
            backend,
            local,
            storage,
            auth: Arc::new(AlwaysAvailable),
            policy: Box::new(LastWriterWins),
            clock: Arc::new(SystemClock),
            observer: Arc::new(NullObserver),
            hooks: Arc::new(NoHooks),
            config: SyncConfig::default(),
        }
    }
    pub fn auth(mut self, v: Arc<dyn AuthProvider>) -> Self {
        self.auth = v;
        self
    }
    pub fn policy(mut self, v: Box<dyn ConflictPolicy<M::Item>>) -> Self {
        self.policy = v;
        self
    }
    pub fn clock(mut self, v: Arc<dyn Clock>) -> Self {
        self.clock = v;
        self
    }
    pub fn observer(mut self, v: Arc<dyn SyncObserver>) -> Self {
        self.observer = v;
        self
    }
    pub fn hooks(mut self, v: Arc<dyn PassHooks>) -> Self {
        self.hooks = v;
        self
    }
    pub fn config(mut self, v: SyncConfig) -> Self {
        self.config = v;
        self
    }
    pub fn build(self) -> SyncResult<SyncEngine<M>> {
        let store = LedgerStore::open(self.storage)?;
        if store.recovered_from_corruption {
            self.observer
                .event("ledger_recovered", "ledger unreadable; full replay");
        }
        Ok(SyncEngine {
            mapper: self.mapper,
            backend: self.backend,
            auth: self.auth,
            local: self.local,
            policy: self.policy,
            clock: self.clock,
            observer: self.observer,
            hooks: self.hooks,
            config: self.config,
            store,
            replay_flags: Vec::new(),
            counters: Counters::default(),
        })
    }
}

struct Fetched {
    records: Vec<RawRecord>,
    deleted: Vec<String>,
    token: Option<Vec<u8>>,
}

impl<M: RecordMapper + 'static> SyncEngine<M>
where
    M::Item: 'static,
{
    pub fn ledger(&self) -> &crate::ledger::Ledger {
        self.store.ledger()
    }

    /// Offline queue: record that `id` changed locally. Durable immediately.
    pub fn note_changed(&mut self, id: &str) -> SyncResult<()> {
        let id = id.to_string();
        self.store.mutate(|l| {
            if !l.tombstones.contains_key(&id) {
                l.pending_uploads.insert(id);
            }
        })
    }

    /// Local deletion: block the id and queue a tombstone write. Durable.
    pub fn note_deleted(&mut self, id: &str) -> SyncResult<()> {
        let now = self.clock.now_ms();
        let id = id.to_string();
        self.store.mutate(|l| {
            l.bury(&id, now);
            l.pending_tombstones.insert(id);
        })
    }

    /// Replay the whole zone once for `flag` (one-shot repair migrations).
    pub fn request_full_replay_once(&mut self, flag: &str) {
        if !self.store.ledger().flags.contains(flag) {
            self.replay_flags.push(flag.to_string());
        }
    }

    /// Runs one sync pass and records it in [`SyncEngine::metrics`].
    pub fn run_pass(&mut self) -> PassReport {
        let started = Instant::now();
        let rep = self.run_pass_once();
        self.record_pass(&rep, started.elapsed());
        rep
    }

    fn record_pass(&mut self, rep: &PassReport, elapsed: Duration) {
        let c = &mut self.counters;
        c.passes += 1;
        if matches!(
            rep.outcome,
            PassOutcome::Failed(_) | PassOutcome::Unavailable(_)
        ) {
            c.failed_passes += 1;
        }
        c.last_pass_ms = elapsed.as_millis() as u64;
        c.downloaded += rep.downloaded as u64;
        c.uploaded += rep.uploaded as u64;
        c.tombstones_applied += rep.tombstones_applied as u64;
        c.tombstones_written += rep.tombstones_written as u64;
    }

    /// Pass counters, ledger queue sizes and process resource usage, read now. No polling thread
    /// runs for this.
    pub fn status(&self) -> SyncStatus {
        SyncStatus {
            metrics: self.metrics(),
            process: rightkit_child_process::process_usage().ok(),
        }
    }

    /// Cumulative pass counters and current ledger queue sizes.
    pub fn metrics(&self) -> SyncMetrics {
        let l = self.store.ledger();
        let c = &self.counters;
        SyncMetrics {
            passes: c.passes,
            failed_passes: c.failed_passes,
            last_pass_ms: c.last_pass_ms,
            downloaded_total: c.downloaded,
            uploaded_total: c.uploaded,
            tombstones_applied_total: c.tombstones_applied,
            tombstones_written_total: c.tombstones_written,
            remote_versions: l.remote_versions.len() as u64,
            tombstones: l.tombstones.len() as u64,
            pending_uploads: l.pending_uploads.len() as u64,
            pending_tombstones: l.pending_tombstones.len() as u64,
            pending_apply: l.pending_apply.len() as u64,
        }
    }

    fn run_pass_once(&mut self) -> PassReport {
        let mut rep = PassReport::new();
        if !self.auth.enabled() {
            rep.outcome = PassOutcome::Disabled;
            return rep;
        }
        let now = self.clock.now_ms();
        if let Some(until) = self.store.ledger().retry_after_ms {
            if until > now {
                let secs = (until - now) as f64 / 1000.0;
                rep.outcome = PassOutcome::Deferred { secs };
                rep.retry_after_secs = Some(secs);
                return rep;
            }
        }
        let generation = self.auth.generation();
        match self.pass_inner(generation, &mut rep) {
            Ok(pending) => {
                let result = self.store.mutate(|l| {
                    if pending.is_none() {
                        l.consecutive_failures = 0;
                        l.retry_after_ms = None;
                    }
                });
                match (result, pending) {
                    (Err(e), _) => self.fail(e, &mut rep),
                    (Ok(()), None) => rep.outcome = PassOutcome::Synced,
                    (Ok(()), Some(why)) => {
                        let secs = self.config.backoff.pending_floor_secs;
                        let until = self.clock.now_ms() + (secs * 1000.0) as i64;
                        let _ = self.store.mutate(|l| l.retry_after_ms = Some(until));
                        rep.retry_after_secs = Some(secs);
                        rep.outcome = PassOutcome::Pending(why);
                    }
                }
            }
            Err(e) => self.fail(e, &mut rep),
        }
        rep
    }

    fn fail(&mut self, e: SyncError, rep: &mut PassReport) {
        if e == SyncError::Cancelled {
            rep.outcome = PassOutcome::Cancelled;
            return;
        }
        self.observer.event("pass_failed", &e.to_string());
        let failures = self.store.ledger().consecutive_failures.saturating_add(1);
        let secs = self
            .config
            .backoff
            .delay_secs(failures, e.retry_hint_secs());
        let until = self.clock.now_ms() + (secs * 1000.0) as i64;
        let _ = self.store.mutate(|l| {
            l.consecutive_failures = failures;
            l.retry_after_ms = Some(until);
        });
        rep.retry_after_secs = Some(secs);
        rep.outcome = match e {
            SyncError::Unavailable(d) => PassOutcome::Unavailable(d),
            other => PassOutcome::Failed(other.to_string()),
        };
    }

    /// A conditional save lost a race. Read the server record, decide with
    /// the conflict policy (tombstone always wins) and either re-save on top
    /// of the server's change tag, take the remote, or keep both unchanged.
    /// Bounded: a record that keeps changing under us stays pending.
    fn resolve_conflict(
        &mut self,
        header: &ItemHeader,
        item: &M::Item,
        name: &str,
        mut server: Option<RawRecord>,
        generation: u64,
        rep: &mut PassReport,
    ) -> SyncResult<Resolved> {
        for _ in 0..MAX_CONFLICT_ROUNDS {
            self.check_current(generation)?;
            let server_rec = match server.take() {
                Some(r) => r,
                None => match self.backend.fetch_record(name)? {
                    Some(r) => r,
                    None => return Ok(Resolved::Failed("conflicting record vanished".into())),
                },
            };
            self.observer.event("save_conflict", name);
            if let Some((id, deleted_at)) = read_tombstone(&server_rec) {
                self.local.remove(&id)?;
                self.store.mutate(|l| l.bury(&id, deleted_at))?;
                rep.tombstones_applied += 1;
                return Ok(Resolved::RemoteWon);
            }
            let remote_item = match self.mapper.decode(&server_rec) {
                Ok(i) => i,
                Err(e) => {
                    rep.quarantined += 1;
                    return Ok(Resolved::Failed(format!("server record undecodable: {e}")));
                }
            };
            let rh = self.mapper.header(&remote_item);
            if self
                .policy
                .upload_local_over_remote(header, item, &rh, &remote_item)
            {
                let mut rec = server_rec;
                rec.set(field::ID, FieldValue::Text(header.id.clone()));
                rec.set(field::CREATED_AT, FieldValue::Date(header.created_at_ms));
                rec.set(field::UPDATED_AT, FieldValue::Date(header.updated_at_ms));
                rec.fields.remove(field::DELETED_AT);
                self.mapper.encode(item, &mut rec);
                let outcomes = self
                    .backend
                    .save_records(&[rec], SavePolicy::IfServerUnchanged)?;
                let Some(o) = outcomes.into_iter().next() else {
                    return Ok(Resolved::Failed("no save outcome".into()));
                };
                match o.result {
                    Ok(()) => return Ok(Resolved::Saved),
                    Err(SyncError::Conflict) => server = o.server_record,
                    Err(e) => return Ok(Resolved::Failed(e.to_string())),
                }
                continue;
            }
            let version = RemoteVersion {
                record_name: name.to_string(),
                updated_at_ms: rh.updated_at_ms,
            };
            if self.policy.accept_remote_over_local(header, &rh) {
                self.check_current(generation)?;
                match self.local.apply_remote(&[remote_item])?.into_iter().next() {
                    Some(ApplyOutcome::Deferred(_)) => {
                        let id = header.id.clone();
                        self.store.mutate(|l| {
                            l.pending_apply.insert(id, server_rec);
                        })?;
                    }
                    _ => rep.downloaded += 1,
                }
            }
            let id = header.id.clone();
            self.store.mutate(|l| {
                l.pending_uploads.remove(&id);
                l.remote_versions.insert(id, version);
            })?;
            return Ok(Resolved::RemoteWon);
        }
        Ok(Resolved::Failed("conflict retries exhausted".into()))
    }

    /// Bind the ledger to the signed-in account scope; reset it when the
    /// scope changed so one account's cursor, versions and queued deletions
    /// are never applied to another.
    fn bind_account(&mut self, generation: u64) -> SyncResult<()> {
        self.check_current(generation)?;
        let Some(scope) = self.auth.account_scope() else {
            return Ok(());
        };
        match self.store.ledger().scope.clone() {
            Some(bound) if bound == scope => Ok(()),
            None => {
                // Ledger from before scoping: keep tombstones (they only
                // suppress local copies); never import its cursor, versions,
                // aliases or queued deletions into this account.
                let dropped = {
                    let l = self.store.ledger();
                    l.change_token.is_some()
                        || !l.remote_versions.is_empty()
                        || !l.aliases.is_empty()
                        || !l.pending_tombstones.is_empty()
                };
                self.store.mutate(|l| {
                    l.scope = Some(scope);
                    l.change_token = None;
                    l.remote_versions.clear();
                    l.aliases.clear();
                    l.pending_tombstones.clear();
                    l.has_synced = false;
                })?;
                if dropped {
                    self.observer
                        .event("legacy_ledger_unscoped", "pre-scope ledger state dropped");
                }
                Ok(())
            }
            Some(bound) => {
                self.hooks.on_account_switch(&bound, &scope);
                self.store.mutate(|l| {
                    *l = crate::ledger::Ledger::default();
                    l.scope = Some(scope.clone());
                })?;
                self.observer.event("account_switched", "ledger reset");
                Ok(())
            }
        }
    }

    fn check_current(&self, generation: u64) -> SyncResult<()> {
        if self.auth.enabled() && self.auth.generation() == generation {
            Ok(())
        } else {
            Err(SyncError::Cancelled)
        }
    }

    /// Returns `Some(reason)` when the pass finished with queued work left.
    fn pass_inner(&mut self, generation: u64, rep: &mut PassReport) -> SyncResult<Option<String>> {
        self.auth.availability()?;
        // `availability` refreshes the account identity, which may bump the
        // generation; the pass belongs to the generation observed after it.
        let generation = self.auth.generation().max(generation);
        self.bind_account(generation)?;
        self.backend.prepare()?;
        self.check_current(generation)?;

        // Domain announce-style records go first; failure fails the pass.
        let mut extras = self.store.ledger().extras.clone();
        let outbound = self.hooks.outbound(&mut extras);
        if !outbound.is_empty() {
            self.check_current(generation)?;
            self.write_required(&outbound)?;
        }
        self.check_current(generation)?;
        self.store.mutate(|l| l.extras = extras)?;

        // One-shot full replays (repair migrations) reset only the cursor.
        if !self.replay_flags.is_empty() {
            self.store.mutate(|l| l.change_token = None)?;
        }

        let fetched = self.fetch_all(generation)?;
        let mapper_type = self.mapper.record_type().to_string();
        let mut entries: Vec<RemoteEntry<M::Item>> = Vec::new();
        let mut foreign: Vec<RawRecord> = Vec::new();
        for record in fetched.records {
            if record.record_type != mapper_type {
                foreign.push(record);
                continue;
            }
            if let Some((id, deleted_at)) = read_tombstone(&record) {
                entries.push(RemoteEntry {
                    id,
                    record_name: record.record_name.clone(),
                    version_ms: deleted_at,
                    state: RemoteState::Tombstone,
                    record,
                });
                continue;
            }
            match self.mapper.decode(&record) {
                Ok(item) => {
                    let h = self.mapper.header(&item);
                    entries.push(RemoteEntry {
                        id: h.id,
                        record_name: record.record_name.clone(),
                        version_ms: h.updated_at_ms,
                        state: RemoteState::Live(item),
                        record,
                    });
                }
                Err(why) => {
                    // A bad record never blocks the page (both platforms).
                    rep.quarantined += 1;
                    self.observer.event(
                        "record_quarantined",
                        &format!("{}: {why}", record.record_name),
                    );
                }
            }
        }
        // Server-side hard deletions of records we know behave as tombstones.
        for name in &fetched.deleted {
            let known = self
                .store
                .ledger()
                .aliases
                .iter()
                .find(|(_, names)| names.contains(name))
                .map(|(id, _)| id.clone())
                .or_else(|| {
                    self.store
                        .ledger()
                        .remote_versions
                        .contains_key(name)
                        .then(|| name.clone())
                });
            if let Some(id) = known {
                if !entries.iter().any(|e| e.id == id && e.is_tombstone()) {
                    let mut record = RawRecord::new(&mapper_type, name);
                    let now = self.clock.now_ms();
                    write_tombstone(&mut record, &id, now, &[]);
                    entries.push(RemoteEntry {
                        id,
                        record_name: name.clone(),
                        version_ms: now,
                        state: RemoteState::Tombstone,
                        record,
                    });
                }
            }
        }
        if rep.quarantined > 0 {
            let n = rep.quarantined as u64;
            self.store.mutate(|l| l.quarantined_total += n)?;
        }

        // Aliases: every record name ever seen for a logical id.
        {
            let seen: Vec<(String, String)> = entries
                .iter()
                .map(|e| (e.id.clone(), e.record_name.clone()))
                .collect();
            self.store.mutate(|l| {
                for (id, name) in seen {
                    l.aliases.entry(id).or_default().insert(name);
                }
            })?;
        }

        // Reduce duplicate records of one logical id.
        let mut canonical: BTreeMap<String, RemoteEntry<M::Item>> = BTreeMap::new();
        for entry in entries {
            match canonical.get(&entry.id) {
                Some(cur) if cur.rank() >= entry.rank() => {}
                _ => {
                    canonical.insert(entry.id.clone(), entry);
                }
            }
        }

        // Domain-owned record types (queue requests etc.).
        if !foreign.is_empty() {
            let mut extras = self.store.ledger().extras.clone();
            let responses = self.hooks.on_foreign_records(&foreign, &mut extras);
            // Responses are durable on the zone BEFORE the extras that record
            // them are persisted, and a failed write aborts the pass before
            // the change token can pass the request: the delta replays and
            // the idempotent hook answers again. Never acknowledge a request
            // whose response never landed.
            if !responses.is_empty() {
                self.check_current(generation)?;
                if let Err(e) = self.write_required(&responses) {
                    self.observer.event("foreign_write_failed", &e.to_string());
                    return Err(e);
                }
            }
            self.check_current(generation)?;
            self.store.mutate(|l| l.extras = extras)?;
        }

        // Remote tombstones are authoritative: delete locally, block id.
        let tombs: Vec<(String, i64)> = canonical
            .values()
            .filter(|e| e.is_tombstone())
            .map(|e| (e.id.clone(), e.version_ms))
            .collect();
        for (id, at) in &tombs {
            self.check_current(generation)?;
            self.local.remove(id)?;
            let (id, at) = (id.clone(), *at);
            self.store.mutate(|l| {
                l.bury(&id, at);
                l.pending_tombstones.remove(&id);
            })?;
        }
        rep.tombstones_applied = tombs.len();
        self.check_current(generation)?;

        let mut pending: Vec<String> = Vec::new();

        // Our own queued deletions.
        match self.flush_tombstones(&canonical, generation, rep) {
            Ok(true) => {}
            Ok(false) => pending.push("tombstones pending".into()),
            Err(e) => return Err(e),
        }

        // Inferred deletions (desktop): published item vanished locally.
        let local_items = self.local.all()?;
        let mut local_ids: HashSet<String> = HashSet::new();
        let mut locals: Vec<(ItemHeader, M::Item)> = Vec::new();
        for item in local_items {
            let h = self.mapper.header(&item);
            local_ids.insert(h.id.clone());
            locals.push((h, item));
        }
        if self.config.infer_local_deletions {
            let gone: Vec<String> = self
                .store
                .ledger()
                .remote_versions
                .keys()
                .filter(|id| !local_ids.contains(*id))
                .filter(|id| !self.store.ledger().tombstones.contains_key(*id))
                .filter(|id| !self.store.ledger().pending_apply.contains_key(*id))
                .cloned()
                .collect();
            if !gone.is_empty() {
                let now = self.clock.now_ms();
                self.store.mutate(|l| {
                    for id in gone {
                        l.bury(&id, now);
                        l.pending_tombstones.insert(id);
                    }
                })?;
                if !self.flush_tombstones(&canonical, generation, rep)? {
                    pending.push("tombstones pending".into());
                }
            }
        }

        // ---- Uploads ----
        let blocked: BTreeSet<String> = self.store.ledger().tombstones.keys().cloned().collect();
        // Drop queued ids whose item no longer exists locally.
        let stale: Vec<String> = self
            .store
            .ledger()
            .pending_uploads
            .iter()
            .filter(|id| !local_ids.contains(*id))
            .cloned()
            .collect();
        if !stale.is_empty() {
            self.store.mutate(|l| {
                for id in stale {
                    l.pending_uploads.remove(&id);
                }
            })?;
        }

        struct Upload<I> {
            header: ItemHeader,
            item: I,
            base: Option<RawRecord>,
            is_new: bool,
        }
        let mut uploads: Vec<Upload<M::Item>> = Vec::new();
        let mut failed_uploads = 0usize;
        for (header, item) in &locals {
            if blocked.contains(&header.id) {
                rep.blocked_reuploads += 1;
                continue;
            }
            let queued = self.store.ledger().pending_uploads.contains(&header.id);
            match canonical.get(&header.id) {
                Some(RemoteEntry {
                    state: RemoteState::Live(remote_item),
                    record,
                    ..
                }) => {
                    let rh = self.mapper.header(remote_item);
                    if self
                        .policy
                        .upload_local_over_remote(header, item, &rh, remote_item)
                    {
                        uploads.push(Upload {
                            header: header.clone(),
                            item: item.clone(),
                            base: Some(record.clone()),
                            is_new: false,
                        });
                    }
                }
                Some(_) => {}
                None => {
                    if let Some(known) =
                        self.store.ledger().remote_versions.get(&header.id).cloned()
                    {
                        // Cursor delta did not include it: unchanged remotely.
                        if known.updated_at_ms < header.updated_at_ms || queued {
                            match self.backend.fetch_record(&known.record_name) {
                                Ok(base) => uploads.push(Upload {
                                    header: header.clone(),
                                    item: item.clone(),
                                    base,
                                    is_new: false,
                                }),
                                Err(e) => {
                                    failed_uploads += 1;
                                    self.observer.event("record_fetch_failed", &e.to_string());
                                }
                            }
                        }
                    } else {
                        uploads.push(Upload {
                            header: header.clone(),
                            item: item.clone(),
                            base: None,
                            is_new: true,
                        });
                    }
                }
            }
        }
        // Oldest origin first, ties by record name: deterministic history.
        uploads.sort_by(|a, b| {
            (
                a.header.created_at_ms,
                self.mapper.record_name(&a.header.id),
            )
                .cmp(&(
                    b.header.created_at_ms,
                    self.mapper.record_name(&b.header.id),
                ))
        });
        let (new_ones, existing): (Vec<_>, Vec<_>) = uploads.into_iter().partition(|u| u.is_new);
        let size = self.config.batch_size.min(self.backend.max_batch()).max(1);
        let mut chunks: Vec<(bool, Vec<Upload<M::Item>>)> = Vec::new();
        if self.config.ordered_new_publication {
            chunks.extend(new_ones.into_iter().map(|u| (true, vec![u])));
            let mut it = existing.into_iter().peekable();
            while it.peek().is_some() {
                chunks.push((false, it.by_ref().take(size).collect()));
            }
        } else {
            let mut it = new_ones.into_iter().chain(existing).peekable();
            while it.peek().is_some() {
                chunks.push((false, it.by_ref().take(size).collect()));
            }
        }

        let mut blocked_new = false;
        for (ordered_new, chunk) in chunks {
            if ordered_new && blocked_new {
                continue;
            }
            self.check_current(generation)?;
            let mut records = Vec::with_capacity(chunk.len());
            let mut by_name: BTreeMap<String, (String, i64)> = BTreeMap::new();
            for u in &chunk {
                let name = self.mapper.record_name(&u.header.id);
                let mut rec = u
                    .base
                    .clone()
                    .unwrap_or_else(|| RawRecord::new(self.mapper.record_type(), &name));
                rec.set(field::ID, FieldValue::Text(u.header.id.clone()));
                rec.set(field::CREATED_AT, FieldValue::Date(u.header.created_at_ms));
                rec.set(field::UPDATED_AT, FieldValue::Date(u.header.updated_at_ms));
                rec.fields.remove(field::DELETED_AT);
                self.mapper.encode(&u.item, &mut rec);
                by_name.insert(
                    rec.record_name.clone(),
                    (u.header.id.clone(), u.header.updated_at_ms),
                );
                records.push(rec);
            }
            // Conditional: an edit based on a stale change tag (or an insert of
            // a name that now exists) is refused, never overwritten.
            let outcomes = self
                .backend
                .save_records(&records, SavePolicy::IfServerUnchanged)?;
            let mut saved: Vec<(String, String, i64)> = Vec::new();
            let mut chunk_failed = false;
            for o in outcomes {
                let Some((id, version)) = by_name.get(&o.record_name) else {
                    continue;
                };
                match o.result {
                    Ok(()) => saved.push((id.clone(), o.record_name.clone(), *version)),
                    Err(SyncError::Conflict) => {
                        let upload = chunk
                            .iter()
                            .find(|u| self.mapper.record_name(&u.header.id) == o.record_name)
                            .expect("outcome names an upload of this chunk");
                        let (header, item) = (upload.header.clone(), upload.item.clone());
                        match self.resolve_conflict(
                            &header,
                            &item,
                            &o.record_name,
                            o.server_record,
                            generation,
                            rep,
                        )? {
                            Resolved::Saved => {
                                saved.push((id.clone(), o.record_name.clone(), *version))
                            }
                            Resolved::RemoteWon => {}
                            Resolved::Failed(why) => {
                                chunk_failed = true;
                                failed_uploads += 1;
                                self.observer.event(
                                    "record_save_failed",
                                    &format!("{}: {why}", o.record_name),
                                );
                            }
                        }
                    }
                    Err(e) => {
                        chunk_failed = true;
                        failed_uploads += 1;
                        self.observer
                            .event("record_save_failed", &format!("{}: {e}", o.record_name));
                    }
                }
            }
            if ordered_new && chunk_failed {
                blocked_new = true;
            }
            // Persist progress per chunk: a crash resumes from here.
            rep.uploaded += saved.len();
            self.store.mutate(|l| {
                for (id, name, version) in saved {
                    l.pending_uploads.remove(&id);
                    l.aliases
                        .entry(id.clone())
                        .or_default()
                        .insert(name.clone());
                    l.remote_versions.insert(
                        id,
                        RemoteVersion {
                            record_name: name,
                            updated_at_ms: version,
                        },
                    );
                }
            })?;
        }
        if failed_uploads > 0 {
            pending.push(format!("{failed_uploads} upload(s) pending"));
        }

        // ---- Downloads ----
        let mut downloads: Vec<(ItemHeader, M::Item, RawRecord)> = Vec::new();
        let mut seen_ids: HashSet<String> = HashSet::new();
        for entry in canonical.values() {
            let RemoteState::Live(item) = &entry.state else {
                continue;
            };
            if self.store.ledger().tombstones.contains_key(&entry.id) {
                continue;
            }
            let rh = self.mapper.header(item);
            let take = match locals.iter().find(|(h, _)| h.id == entry.id) {
                None => true,
                Some((lh, _)) => self.policy.accept_remote_over_local(lh, &rh),
            };
            if take {
                seen_ids.insert(entry.id.clone());
                downloads.push((rh, item.clone(), entry.record.clone()));
            }
        }
        // Retry records whose local apply was deferred earlier.
        let stashed: Vec<(String, RawRecord)> = self
            .store
            .ledger()
            .pending_apply
            .iter()
            .map(|(k, v)| (k.clone(), v.clone()))
            .collect();
        for (id, record) in stashed {
            if seen_ids.contains(&id) || self.store.ledger().tombstones.contains_key(&id) {
                continue;
            }
            if let Ok(item) = self.mapper.decode(&record) {
                downloads.push((self.mapper.header(&item), item, record));
            }
        }
        downloads.sort_by(|a, b| {
            (a.0.created_at_ms, a.0.id.as_str()).cmp(&(b.0.created_at_ms, b.0.id.as_str()))
        });
        if !downloads.is_empty() {
            self.check_current(generation)?;
            let items: Vec<M::Item> = downloads.iter().map(|d| d.1.clone()).collect();
            let outcomes = self.local.apply_remote(&items)?;
            if outcomes.len() != downloads.len() {
                return Err(SyncError::Persistence(
                    "apply_remote returned wrong outcome count".into(),
                ));
            }
            let mut deferred = 0usize;
            let mut applied_ids: Vec<String> = Vec::new();
            let mut stash: Vec<(String, RawRecord)> = Vec::new();
            for ((h, _, record), out) in downloads.into_iter().zip(outcomes) {
                match out {
                    ApplyOutcome::Applied => {
                        rep.downloaded += 1;
                        applied_ids.push(h.id);
                    }
                    ApplyOutcome::Deferred(why) => {
                        deferred += 1;
                        self.observer
                            .event("apply_deferred", &format!("{}: {why}", h.id));
                        stash.push((h.id, record));
                    }
                }
            }
            self.store.mutate(|l| {
                for id in applied_ids {
                    l.pending_apply.remove(&id);
                }
                for (id, rec) in stash {
                    l.pending_apply.insert(id, rec);
                }
            })?;
            if deferred > 0 {
                pending.push(format!("{deferred} download(s) deferred"));
            }
        }

        // Remote versions + advance the token: only now, after everything
        // above applied (or was durably queued).
        let versions: Vec<(String, RemoteVersion)> = canonical
            .values()
            .map(|e| {
                (
                    e.id.clone(),
                    RemoteVersion {
                        record_name: e.record_name.clone(),
                        updated_at_ms: e.version_ms,
                    },
                )
            })
            .collect();
        // Final guard: a pass whose account/enable generation changed during
        // I/O must not advance the cursor or mark the ledger synced.
        self.check_current(generation)?;
        let flags = std::mem::take(&mut self.replay_flags);
        let token = fetched.token;
        self.store.mutate(|l| {
            for (id, v) in versions {
                // A local upload this pass may already hold a newer version.
                let keep = l
                    .remote_versions
                    .get(&id)
                    .is_some_and(|k| k.updated_at_ms > v.updated_at_ms);
                if !keep {
                    l.remote_versions.insert(id, v);
                }
            }
            if token.is_some() {
                l.change_token = token;
            }
            l.has_synced = true;
            for f in flags {
                l.flags.insert(f);
            }
        })?;
        if rep.blocked_reuploads > 0 {
            self.observer
                .event("blocked_reupload", &rep.blocked_reuploads.to_string());
        }
        Ok(if pending.is_empty() {
            None
        } else {
            Some(pending.join("; "))
        })
    }

    /// Fetch every page; reset the token once on expiry and re-prepare the
    /// zone once if it vanished.
    fn fetch_all(&mut self, generation: u64) -> SyncResult<Fetched> {
        let mut reset_token = false;
        let mut recreated = false;
        'restart: loop {
            let mut token = self.store.ledger().change_token.clone();
            let mut out = Fetched {
                records: Vec::new(),
                deleted: Vec::new(),
                token: None,
            };
            loop {
                self.check_current(generation)?;
                match self.backend.fetch_changes(token.as_deref()) {
                    Ok(page) => {
                        out.records.extend(page.records);
                        out.deleted.extend(page.deleted_record_names);
                        if page.new_token.is_some() {
                            token = page.new_token.clone();
                            out.token = page.new_token;
                        }
                        if !page.more_coming {
                            return Ok(out);
                        }
                    }
                    Err(SyncError::TokenExpired) if !reset_token && token.is_some() => {
                        reset_token = true;
                        self.observer
                            .event("token_reset", "change token expired; full replay");
                        self.store.mutate(|l| l.change_token = None)?;
                        continue 'restart;
                    }
                    Err(SyncError::ZoneMissing) if !recreated => {
                        recreated = true;
                        self.observer
                            .event("zone_recreated", "zone missing; re-preparing");
                        // Every remote record is gone: what the ledger believes is
                        // published no longer exists, so local items must
                        // re-publish (donor: acknowledgements are invalidated).
                        self.store.mutate(|l| {
                            l.change_token = None;
                            l.remote_versions.clear();
                            l.aliases.clear();
                        })?;
                        self.backend.prepare()?;
                        continue 'restart;
                    }
                    Err(e) => return Err(e),
                }
            }
        }
    }

    /// Write queued tombstones to every alias record. Returns true when the
    /// queue drained.
    fn flush_tombstones(
        &mut self,
        canonical: &BTreeMap<String, RemoteEntry<M::Item>>,
        generation: u64,
        rep: &mut PassReport,
    ) -> SyncResult<bool> {
        let ids: Vec<String> = self
            .store
            .ledger()
            .pending_tombstones
            .iter()
            .cloned()
            .collect();
        if ids.is_empty() {
            return Ok(true);
        }
        struct Write {
            id: String,
            record: RawRecord,
        }
        let mut writes: Vec<Write> = Vec::new();
        let mut never_remote: Vec<String> = Vec::new();
        for id in &ids {
            let mut names: BTreeSet<String> = self
                .store
                .ledger()
                .aliases
                .get(id)
                .cloned()
                .unwrap_or_default();
            let known =
                self.store.ledger().remote_versions.contains_key(id) || canonical.contains_key(id);
            if names.is_empty() && !known {
                never_remote.push(id.clone());
                continue;
            }
            names.insert(self.mapper.record_name(id));
            let at = self
                .store
                .ledger()
                .tombstones
                .get(id)
                .copied()
                .unwrap_or_else(|| self.clock.now_ms());
            for name in names {
                let mut record = match canonical.get(id).filter(|e| e.record_name == name) {
                    Some(e) => e.record.clone(),
                    None => self
                        .backend
                        .fetch_record(&name)
                        .ok()
                        .flatten()
                        .unwrap_or_else(|| RawRecord::new(self.mapper.record_type(), &name)),
                };
                write_tombstone(&mut record, id, at, self.mapper.tombstone_keep_fields());
                writes.push(Write {
                    id: id.clone(),
                    record,
                });
            }
        }
        if !never_remote.is_empty() {
            // Created and deleted before ever reaching the zone: nothing to write.
            self.store.mutate(|l| {
                for id in never_remote {
                    l.pending_tombstones.remove(&id);
                }
            })?;
        }
        let mut failed: BTreeSet<String> = BTreeSet::new();
        let size = self
            .config
            .tombstone_batch
            .min(self.backend.max_batch())
            .max(1);
        for chunk in writes.chunks(size) {
            self.check_current(generation)?;
            let records: Vec<RawRecord> = chunk.iter().map(|w| w.record.clone()).collect();
            let outcomes = self.backend.save_records(&records, SavePolicy::Overwrite)?;
            for w in chunk {
                let ok = outcomes
                    .iter()
                    .find(|o| o.record_name == w.record.record_name)
                    .is_some_and(|o| o.result.is_ok());
                if !ok {
                    failed.insert(w.id.clone());
                    self.observer
                        .event("tombstone_save_failed", &w.record.record_name);
                }
            }
        }
        let acked: Vec<String> = writes
            .iter()
            .map(|w| w.id.clone())
            .collect::<BTreeSet<_>>()
            .into_iter()
            .filter(|id| !failed.contains(id))
            .collect();
        rep.tombstones_written += acked.len();
        self.store.mutate(|l| {
            for id in &acked {
                l.pending_tombstones.remove(id);
            }
        })?;
        Ok(failed.is_empty())
    }

    /// Save records whose failure must fail the pass.
    fn write_required(&self, records: &[RawRecord]) -> SyncResult<()> {
        for chunk in records.chunks(self.backend.max_batch().max(1)) {
            for o in self.backend.save_records(chunk, SavePolicy::Overwrite)? {
                o.result?;
            }
        }
        Ok(())
    }
}