rho-coding-agent 2.2.0

A lightweight agent harness inspired by Pi
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162

use pretty_assertions::assert_eq;

use super::{
    classify_gh_pr_view, paint_for_current_branch, parse_gh_pr_view, GithubPr, GithubPrLookup,
    GithubPrPaint, GithubPrProbe, GithubPrTone,
};

#[test]
fn parse_gh_pr_view_maps_ready_and_issue_tones() {
    // Covers: statusline color is ready vs issues vs ambient from gh JSON
    // Owner: github pr probe
    let cases = [
        (
            r#"{"number":12,"reviewDecision":null,"mergeStateStatus":"CLEAN","statusCheckRollup":[]}"#,
            Some(GithubPr {
                number: 12,
                tone: Some(GithubPrTone::Ready),
            }),
        ),
        (
            r#"{"number":4,"reviewDecision":"CHANGES_REQUESTED","mergeStateStatus":"BLOCKED","statusCheckRollup":[]}"#,
            Some(GithubPr {
                number: 4,
                tone: Some(GithubPrTone::Issues),
            }),
        ),
        (
            r#"{"number":8,"reviewDecision":null,"mergeStateStatus":"DIRTY","statusCheckRollup":[]}"#,
            Some(GithubPr {
                number: 8,
                tone: Some(GithubPrTone::Issues),
            }),
        ),
        (
            r#"{"number":9,"reviewDecision":null,"mergeStateStatus":"UNSTABLE","statusCheckRollup":[{"conclusion":"FAILURE","state":""}]}"#,
            Some(GithubPr {
                number: 9,
                tone: Some(GithubPrTone::Issues),
            }),
        ),
        (
            r#"{"number":3,"reviewDecision":null,"mergeStateStatus":"BLOCKED","statusCheckRollup":null}"#,
            Some(GithubPr {
                number: 3,
                tone: None,
            }),
        ),
        (
            r#"{"number":5,"reviewDecision":null,"mergeStateStatus":"CLEAN","statusCheckRollup":{"not":"an array"}}"#,
            Some(GithubPr {
                number: 5,
                tone: Some(GithubPrTone::Ready),
            }),
        ),
        ("not json", None),
        (r#"{"reviewDecision":null}"#, None),
    ];
    for (json, expected) in cases {
        assert_eq!(parse_gh_pr_view(json.as_bytes()), expected, "{json}");
    }
}

#[test]
fn classify_gh_pr_view_separates_absence_from_transient_failure() {
    // Covers: gh stderr "no pull requests found" clears; other failures do not
    // Owner: github pr probe
    let ready =
        r#"{"number":12,"reviewDecision":null,"mergeStateStatus":"CLEAN","statusCheckRollup":[]}"#;
    let cases = [
        (
            true,
            ready.as_bytes(),
            b"" as &[u8],
            GithubPrProbe::Found(GithubPr {
                number: 12,
                tone: Some(GithubPrTone::Ready),
            }),
        ),
        (
            false,
            b"",
            b"no pull requests found for branch \"feat\"\n",
            GithubPrProbe::Absent,
        ),
        (
            false,
            b"",
            b"GraphQL: no open pull requests found for branch \"feat\"\n",
            GithubPrProbe::Absent,
        ),
        (
            false,
            b"",
            b"gh: To get started with GitHub CLI, please run: gh auth login\n",
            GithubPrProbe::Unavailable,
        ),
        (true, b"not json", b"", GithubPrProbe::Unavailable),
    ];
    for (success, stdout, stderr, expected) in cases {
        assert_eq!(
            classify_gh_pr_view(success, stdout, stderr),
            expected,
            "success={success} stderr={}",
            String::from_utf8_lossy(stderr)
        );
    }
}

#[test]
fn paint_for_current_branch_clears_confirmed_absence_only() {
    // Covers: found paints; no-PR clears; stale/unavailable keep the chip
    // Owner: github pr probe
    let pr = GithubPr {
        number: 7,
        tone: Some(GithubPrTone::Ready),
    };
    let cases = [
        (
            Some("main"),
            GithubPrLookup {
                branch: Some("main".into()),
                probe: GithubPrProbe::Found(pr.clone()),
            },
            GithubPrPaint::Show(pr.clone()),
        ),
        (
            Some("main"),
            GithubPrLookup {
                branch: Some("feature".into()),
                probe: GithubPrProbe::Found(pr.clone()),
            },
            GithubPrPaint::Keep,
        ),
        (
            Some("main"),
            GithubPrLookup {
                branch: Some("main".into()),
                probe: GithubPrProbe::Unavailable,
            },
            GithubPrPaint::Keep,
        ),
        (
            Some("main"),
            GithubPrLookup {
                branch: Some("main".into()),
                probe: GithubPrProbe::Absent,
            },
            GithubPrPaint::Clear,
        ),
        (
            Some("main"),
            GithubPrLookup {
                branch: Some("feature".into()),
                probe: GithubPrProbe::Absent,
            },
            GithubPrPaint::Keep,
        ),
    ];
    for (current, lookup, expected) in cases {
        assert_eq!(paint_for_current_branch(current, lookup), expected);
    }
}