rho-coding-agent 2.3.1

A fast Rust agent harness with a small footprint and opinionated defaults
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
use super::*;

// Covers: every selectable edit schema routes through file-diff presentation
// Owner: interactive presenter
#[test]
fn selected_edit_tool_names_share_the_edit_presentation_kind() {
    assert_eq!(
        ToolKind::from_name("apply_patch"),
        ToolKind::Edit(rho_tools::EditFormat::ApplyPatch)
    );
    assert_eq!(
        ToolKind::from_name("edit"),
        ToolKind::Edit(rho_tools::EditFormat::Hashline)
    );
    assert_eq!(
        ToolKind::from_name("str_replace"),
        ToolKind::Edit(rho_tools::EditFormat::StrReplace)
    );
}

// Covers: started keeps str_replace identity from the unique tool name
// Owner: interactive presenter
#[test]
fn started_keeps_str_replace_kind_from_tool_name() {
    let mut presenter = InteractiveToolPresenter::new(std::path::PathBuf::from("."));
    let call = ToolCall {
        id: "call-1".into(),
        name: "str_replace".into(),
        arguments: serde_json::json!({
            "path": "a.rs",
            "old_string": "a",
            "new_string": "b"
        }),
    };
    let _ = presenter.proposed(call);
    let presented = presenter.started(
        ToolCallId::from_string("call-1").unwrap(),
        "str_replace".into(),
        ToolMetadata::default(),
    );
    match &presented.card.header {
        rho_tools::tool_card::ToolHeader::Call { verb, primary } => {
            assert_eq!(verb, "str_replace");
            assert_eq!(primary.as_deref(), Some("a.rs"));
        }
        other => panic!("expected call header, got {other:?}"),
    }
}

// Covers: large edit preview checkpoints grow with buffer size
// Owner: interactive presenter
#[test]
fn edit_preview_stride_grows_with_input_size() {
    let limit = EDIT_STREAM_PREVIEW_LIMIT;
    let min_stride = EDIT_STREAM_PREVIEW_STRIDE;

    assert_eq!(
        ToolKind::Edit(rho_tools::EditFormat::Hashline).preview_parse_stride(limit),
        limit.max(min_stride)
    );
    assert_eq!(
        ToolKind::Edit(rho_tools::EditFormat::Hashline).preview_parse_stride(limit * 2),
        (limit * 2).max(min_stride)
    );
    assert_eq!(
        ToolKind::Edit(rho_tools::EditFormat::Hashline).preview_parse_stride(limit * 3),
        (limit * 3).max(min_stride)
    );

    // Geometric checkpoints: each interval is at least as large as the last.
    let mut size = limit;
    let mut previous_stride = 0usize;
    for _ in 0..4 {
        let stride = ToolKind::Edit(rho_tools::EditFormat::Hashline).preview_parse_stride(size);
        assert!(stride >= min_stride);
        assert!(stride >= previous_stride);
        previous_stride = stride;
        size = size.saturating_add(stride);
    }
}

// Covers: below the edit limit, cadence matches the generic policy
// Owner: interactive presenter
#[test]
fn edit_preview_uses_generic_cadence_below_stream_limit() {
    assert_eq!(
        ToolKind::Edit(rho_tools::EditFormat::Hashline).preview_parse_stride(0),
        0
    );
    assert_eq!(
        ToolKind::Edit(rho_tools::EditFormat::Hashline)
            .preview_parse_stride(PREVIEW_FULL_PARSE_LIMIT - 1),
        0
    );
    assert_eq!(
        ToolKind::Edit(rho_tools::EditFormat::Hashline)
            .preview_parse_stride(PREVIEW_FULL_PARSE_LIMIT),
        PREVIEW_LARGE_PARSE_STRIDE
    );
    assert_eq!(
        ToolKind::Edit(rho_tools::EditFormat::Hashline)
            .preview_parse_stride(EDIT_STREAM_PREVIEW_LIMIT - 1),
        PREVIEW_LARGE_PARSE_STRIDE
    );
}

// Covers: approval cards must flag document-only fallback and keep pure CUT as
// content stats, never file-delete
// Owner: interactive presenter
#[test]
fn edit_planned_card_surfaces_unverified_document_fallback() {
    let dir = tempfile::TempDir::new().unwrap();
    let view = ToolView {
        kind: ToolKind::Edit(rho_tools::EditFormat::Hashline),
        name: "edit".into(),
        arguments: serde_json::json!({
            "input": "[missing.txt#AAAA]\nCUT 1.=2\n"
        }),
        metadata: Default::default(),
    };
    let card = start_card(&view, dir.path());
    assert!(
        card.facts.iter().any(|fact| matches!(
            fact,
            rho_tools::tool_card::ToolFact::Meta { text }
                if text.as_str() == rho_tools::hashline::EDIT_DOCUMENT_ONLY_NOTICE
        )),
        "expected unverified notice in facts: {:?}",
        card.facts
    );
    assert!(
        card.facts.iter().any(|fact| matches!(
            fact,
            rho_tools::tool_card::ToolFact::DiffStat {
                added: 0,
                removed: 2,
                ..
            }
        )),
        "pure CUT must keep DiffStat, not file-delete: {:?}",
        card.facts
    );
    assert!(
        !card.facts.iter().any(|fact| matches!(
            fact,
            rho_tools::tool_card::ToolFact::Meta { text } if text.starts_with("delete")
        )),
        "must not render file-delete meta for line CUT: {:?}",
        card.facts
    );
}

// Covers: advisor cards keep phase on the header and body as plain guidance
// Owner: interactive presenter
#[test]
fn advisor_cards_use_status_first_headers() {
    use rho_tools::tool_card::{ToolBody, ToolHeader, ToolStatus};

    let dir = tempfile::TempDir::new().unwrap();
    let view = ToolView {
        kind: ToolKind::Advisor,
        name: "advisor".into(),
        arguments: serde_json::json!({}),
        metadata: Default::default(),
    };

    let start = start_card(&view, dir.path());
    assert_eq!(start.status, ToolStatus::Running);
    assert_eq!(
        start.header,
        ToolHeader::status_first(
            "advisor",
            crate::agent::OneShotPhase::WaitingForProvider.label()
        )
    );

    let progress = progress_card(
        Some((&view, dir.path())),
        &rho_sdk::tool::ToolProgress::message("try the simpler path")
            .metadata(rho_sdk::tool::ToolMetadata::new().command_summary("responding")),
    );
    assert_eq!(
        progress.header,
        ToolHeader::status_first("advisor", "responding")
    );
    assert_eq!(
        progress.body,
        ToolBody::Lines(vec!["try the simpler path".into()])
    );

    let progress_fallback = progress_card(
        Some((&view, dir.path())),
        &rho_sdk::tool::ToolProgress::message(""),
    );
    assert_eq!(
        progress_fallback.header,
        ToolHeader::status_first(
            "advisor",
            crate::agent::OneShotPhase::WaitingForProvider.label()
        )
    );

    let interrupted = interrupted_card(&view, "", dir.path());
    assert_eq!(interrupted.status, ToolStatus::Interrupted);
    assert_eq!(
        interrupted.header,
        ToolHeader::status_first("advisor", "interrupted")
    );

    let finished = finished_card(&view, "final guidance", true, dir.path());
    assert_eq!(finished.status, ToolStatus::Ok);
    assert_eq!(
        finished.header,
        ToolHeader::status_first("advisor", "completed")
    );
    assert_eq!(
        finished.body,
        ToolBody::Lines(vec!["final guidance".into()])
    );

    let failed = finished_card(&view, "advisor blew up", false, dir.path());
    assert_eq!(failed.status, ToolStatus::Error);
    assert_eq!(failed.header, ToolHeader::status_first("advisor", "failed"));
}

// Covers: shell start cards must expose the typed timeout budget fact
// Owner: interactive presenter
#[test]
fn shell_start_card_includes_timeout_fact() {
    use rho_tools::tool_card::{ToolFact, ToolHeader, ToolStatus};

    let dir = tempfile::TempDir::new().unwrap();
    let with_timeout = ToolView {
        kind: ToolKind::Bash,
        name: "bash".into(),
        arguments: serde_json::json!({
            "command": "sleep 1",
            "timeout_seconds": 30
        }),
        metadata: Default::default(),
    };
    let card = start_card(&with_timeout, dir.path());
    assert_eq!(card.status, ToolStatus::Running);
    assert_eq!(card.header, ToolHeader::shell("$", Some("sleep 1".into())));
    assert_eq!(card.facts, vec![ToolFact::Timeout { seconds: Some(30) }]);

    let no_timeout = ToolView {
        kind: ToolKind::Bash,
        name: "bash".into(),
        arguments: serde_json::json!({ "command": "true" }),
        metadata: Default::default(),
    };
    let card = start_card(&no_timeout, dir.path());
    assert_eq!(card.facts, vec![ToolFact::Timeout { seconds: None }]);
}

// Covers: MCP start cards decode the tool verb and show server + remaining
// args, not the raw exported name or JSON blob
// Owner: interactive presenter
#[test]
fn mcp_proposed_and_started_cards_use_decoded_verb_and_argument_facts() {
    use rho_tools::tool_card::{ToolCard, ToolFact, ToolFamily, ToolHeader, ToolStatus};

    let mut presenter = InteractiveToolPresenter::new(std::path::PathBuf::from("."));
    let call = ToolCall {
        id: "call-mcp".into(),
        name: "mcp__olive_salmon__increase_grep".into(),
        arguments: serde_json::json!({
            "path": "crates",
            "output_mode": "files_with_matches",
            "max_results": 50
        }),
    };
    let expected = ToolCard::new(
        ToolStatus::Running,
        ToolFamily::Default,
        ToolHeader::call("increase_grep", Some("crates".into())),
    )
    .with_facts(vec![
        ToolFact::Meta {
            text: "mcp · olive_salmon".into(),
        },
        ToolFact::Text {
            text: "output_mode files_with_matches · max_results 50".into(),
        },
    ]);

    let proposed = presenter.proposed(call);
    assert_eq!(proposed.card, expected);
    assert_eq!(
        ToolKind::from_name("mcp__olive_salmon__increase_grep"),
        ToolKind::Mcp
    );

    let started = presenter.started(
        ToolCallId::from_string("call-mcp").unwrap(),
        "mcp__olive_salmon__increase_grep".into(),
        ToolMetadata::default(),
    );
    assert_eq!(started.card, expected);
}

// Covers: successful MCP results keep provenance/args and add a line count
// plus the output body
// Owner: interactive presenter
#[test]
fn mcp_finished_ok_card_counts_lines_and_keeps_body() {
    use rho_tools::tool_card::{ToolBody, ToolCard, ToolFact, ToolFamily, ToolHeader, ToolStatus};

    let dir = tempfile::TempDir::new().unwrap();
    let view = ToolView {
        kind: ToolKind::Mcp,
        name: "mcp__olive_salmon__increase_grep".into(),
        arguments: serde_json::json!({
            "path": "crates",
            "output_mode": "files_with_matches",
            "max_results": 50
        }),
        metadata: Default::default(),
    };
    let content = "crates/rho/src/lib.rs\ncrates/rho/src/app.rs\n";
    let card = finished_card(&view, content, true, dir.path());
    assert_eq!(
        card,
        ToolCard::new(
            ToolStatus::Ok,
            ToolFamily::Default,
            ToolHeader::call("increase_grep", Some("crates".into())),
        )
        .with_facts(vec![
            ToolFact::Meta {
                text: "mcp · olive_salmon".into(),
            },
            ToolFact::Text {
                text: "output_mode files_with_matches · max_results 50".into(),
            },
            ToolFact::Count {
                label: "lines".into(),
                value: 2,
                detail: None,
            },
        ])
        .with_body(ToolBody::Lines(vec![
            "crates/rho/src/lib.rs".into(),
            "crates/rho/src/app.rs".into(),
        ]))
    );
}

// Covers: failed MCP results keep server provenance and use the shared error fact
// Owner: interactive presenter
#[test]
fn mcp_finished_error_card_keeps_server_fact_and_error_summary() {
    use rho_tools::tool_card::{ToolCard, ToolFact, ToolFamily, ToolHeader, ToolStatus};

    let dir = tempfile::TempDir::new().unwrap();
    let view = ToolView {
        kind: ToolKind::Mcp,
        name: "mcp__olive_salmon__increase_grep".into(),
        arguments: serde_json::json!({ "path": "crates" }),
        metadata: Default::default(),
    };
    let card = finished_card(&view, "server unavailable", false, dir.path());
    assert_eq!(
        card,
        ToolCard::new(
            ToolStatus::Error,
            ToolFamily::Default,
            ToolHeader::call("increase_grep", Some("crates".into())),
        )
        .with_facts(vec![
            ToolFact::Meta {
                text: "mcp · olive_salmon".into(),
            },
            ToolFact::Error {
                text: "server unavailable".into(),
            },
        ])
    );
}

// Covers: `_rho_` hex-escaped MCP names render decoded server and tool
// Owner: interactive presenter
#[test]
fn mcp_escaped_exported_name_renders_decoded_server_and_tool() {
    use rho_tools::tool_card::{ToolCard, ToolFact, ToolFamily, ToolHeader, ToolStatus};

    let dir = tempfile::TempDir::new().unwrap();
    let name = "mcp___rho_6769742d687562___rho_6973737565732f6c697374";
    let view = ToolView {
        kind: ToolKind::from_name(name),
        name: name.into(),
        arguments: serde_json::json!({ "path": "crates" }),
        metadata: Default::default(),
    };
    let card = start_card(&view, dir.path());
    assert_eq!(view.kind, ToolKind::Mcp);
    assert_eq!(
        card,
        ToolCard::new(
            ToolStatus::Running,
            ToolFamily::Default,
            ToolHeader::call("issues/list", Some("crates".into())),
        )
        .with_facts(vec![ToolFact::Meta {
            text: "mcp · git-hub".into(),
        }])
    );
}