rho-coding-agent 2.19.0

A fast Rust agent harness with a small footprint and opinionated defaults
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98

use pretty_assertions::assert_eq;

use super::super::{tests::test_app, ComposerMode, UiPicker};
use super::{delete_target, AgentDeleteTarget};
use crate::agent::{AgentCatalog, AgentOrigin};
use crate::app::interactive_runtime::test_runtime;

// Covers: only the user's own agents (`~/.rho/agents`, project) can be
// deleted; shared, built-in, and internal rows must never offer a delete.
// Owner: tui agent delete
#[test]
fn only_user_agents_are_delete_targets() {
    let home = tempfile::tempdir().expect("home");
    let cwd = tempfile::tempdir().expect("cwd");
    let agent = "---\ndescription: d\n---\nbody\n";
    for (dir, id) in [
        (home.path().join(".rho/agents"), "mine"),
        (home.path().join(".agents/agents"), "shared"),
        (cwd.path().join(".agents/agents"), "project"),
    ] {
        std::fs::create_dir_all(&dir).expect("agents dir");
        std::fs::write(dir.join(format!("{id}.md")), agent).expect("write agent");
    }
    let catalog = AgentCatalog::discover_with_home(cwd.path(), Some(home.path())).expect("catalog");

    let origins = ["mine", "project", "shared", "reviewer", "goal-judge"]
        .map(|id| delete_target(&catalog, id).map(|target| target.origin));

    assert_eq!(
        origins,
        [
            Some(AgentOrigin::RhoHome),
            Some(AgentOrigin::Project),
            None,
            None,
            None,
        ]
    );
}

// Covers: cancelling the confirmation keeps the file and returns to the
// agents picker.
// Owner: tui agent delete
#[tokio::test]
async fn cancelled_delete_keeps_agent() {
    let project = tempfile::tempdir().expect("project");
    let agents = project.path().join(".agents/agents");
    std::fs::create_dir_all(&agents).expect("agents dir");
    let path = agents.join("demo.md");
    std::fs::write(&path, "---\ndescription: demo\n---\nbody\n").expect("write agent");
    let mut app = test_app();
    app.info.runtime.cwd = project.path().to_path_buf();

    let mut agent = test_runtime(Vec::new()).await;
    app.submit_delete_agent_choice(
        "cancel",
        AgentDeleteTarget {
            id: "demo".into(),
            origin: AgentOrigin::Project,
            path: path.clone(),
        },
        Some(Box::new(UiPicker::view_agent("Loaded agents", Vec::new()))),
        &mut agent,
    );

    assert!(path.exists());
    assert!(matches!(
        app.input_ui.composer(),
        ComposerMode::Picker(picker) if picker.is_view_agent()
    ));
}

// Covers: a target outside an editable agent root is refused at confirm time,
// so a stale or forged path cannot delete arbitrary files.
// Owner: tui agent delete
#[tokio::test]
async fn delete_agent_refuses_path_outside_agent_root() {
    let project = tempfile::tempdir().expect("project");
    let path = project.path().join("not-an-agent.md");
    std::fs::write(&path, "keep me").expect("write file");
    let mut app = test_app();
    app.info.runtime.cwd = project.path().to_path_buf();

    let mut agent = test_runtime(Vec::new()).await;
    app.submit_delete_agent_choice(
        "delete",
        AgentDeleteTarget {
            id: "demo".into(),
            origin: AgentOrigin::Project,
            path: path.clone(),
        },
        Some(Box::new(UiPicker::view_agent("Loaded agents", Vec::new()))),
        &mut agent,
    );

    assert!(path.exists());
    assert_eq!(app.status(), "agent delete failed");
}