rho-coding-agent 2.11.0

A fast Rust agent harness with a small footprint and opinionated defaults
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
//! Delegated agent tools backed by in-process SDK runtimes.

pub(crate) mod message_receipt;

use std::{
    future::Future,
    path::{Path, PathBuf},
    pin::Pin,
    sync::Arc,
};

use serde::Deserialize;
use serde_json::{json, Value};

use {
    crate::agent::AgentCatalog,
    crate::app::subagent_manager::ValidatedMessage,
    rho_sdk::tool::{
        OperationKind, PreparedToolInvocation, Tool, ToolError, ToolErrorKind, ToolInvocation,
        ToolMetadata, ToolOutput, ToolPreparationContext, ToolPrepareFuture, ToolResource,
        ToolResourceAccess, ToolSecurity,
    },
};

use super::agent_output::{
    format_background_start, format_list_entry, format_snapshot, SnapshotFormat,
};

const SUBAGENT_MANAGER: &str = "subagents";
const AGENT_TOOL: &str = "agent";
const AGENTS_TOOL: &str = "agents";

pub use crate::app::subagent_manager::{SubagentManager, SubagentNotification, SubagentSnapshot};

pub(crate) use super::agent_output::merge_notification_context;
pub(crate) use super::agent_output::notification_prompt;
#[cfg(test)]
pub(crate) use super::agent_output::MODEL_NOTIFICATION_BYTES as NOTIFICATION_CONTEXT_BYTES;

pub struct AgentTool {
    manager: SubagentManager,
    catalog: Arc<AgentCatalog>,
    agent_summaries: Vec<(String, String)>,
    mutation_observer: Arc<dyn rho_tools::WorkspaceMutationObserver>,
}

impl AgentTool {
    pub(super) fn new(
        manager: SubagentManager,
        cwd: &Path,
        catalog: Option<Arc<AgentCatalog>>,
    ) -> Self {
        let catalog = catalog.unwrap_or_else(|| {
            Arc::new(AgentCatalog::discover(cwd).expect("agent catalog was validated at startup"))
        });
        let agent_summaries = catalog
            .iter()
            .filter(|entry| entry.definition.id.as_str() != "default")
            .map(|entry| {
                (
                    entry.definition.id.to_string(),
                    entry.definition.description.clone(),
                )
            })
            .collect();
        Self {
            manager,
            catalog,
            agent_summaries,
            mutation_observer: Arc::new(()),
        }
    }

    fn with_mutation_observer(
        mut self,
        mutation_observer: Arc<dyn rho_tools::WorkspaceMutationObserver>,
    ) -> Self {
        self.mutation_observer = mutation_observer;
        self
    }

    async fn execute(
        &self,
        args: AgentArgs,
        context: &rho_sdk::tool::AuthorizedToolContext,
    ) -> Result<ToolOutput, ToolError> {
        let definition = self
            .catalog
            .find(&args.agent_id)
            .map_err(|error| ToolError::new(ToolErrorKind::InvalidArguments, error.to_string()))?
            .definition
            .clone();
        let definition_id = definition.id.to_string();
        self.mutation_observer
            .mark_untracked_effect(rho_tools::UntrackedWorkspaceEffect::MutatingTool, "agent");
        let cwd = context
            .workspace_root()
            .map(Path::to_path_buf)
            .or_else(|| std::env::current_dir().ok())
            .unwrap_or_default();

        let spawn = self.manager.spawn(&definition, &args.prompt, &cwd);
        tokio::pin!(spawn);
        let (run_id, _log_file) = tokio::select! {
            result = &mut spawn => result.map_err(|error| {
                ToolError::new(
                    ToolErrorKind::Execution,
                    format!("failed to start delegated agent: {error}"),
                )
            })?,
            () = context.cancellation().cancelled() => {
                // Finish registration so the manager retains ownership and
                // host shutdown can cancel the delegated task.
                let _ = spawn.await;
                return Err(ToolError::cancelled());
            }
        };

        // Registration is the start receipt; instant failures still reach
        // the parent through automatic completion delivery.
        Ok(
            ToolOutput::text(format_background_start(&run_id, &definition_id))
                .metadata(agent_metadata()),
        )
    }
}

#[derive(Deserialize)]
struct AgentArgs {
    agent_id: String,
    prompt: String,
}

impl Tool for AgentTool {
    fn spec(&self) -> rho_sdk::model::ToolSpec {
        let names: Vec<&str> = self
            .agent_summaries
            .iter()
            .map(|(name, _)| name.as_str())
            .collect();
        // Deliberately model-free. Which model an agent runs on can change after
        // this list is written - the conversation model switches, a catalog name
        // arrives - and rewriting the list would change what the caller was
        // already told. Each run reports its own model when it starts instead.
        let summaries = self
            .agent_summaries
            .iter()
            .map(|(name, description)| format!("{name}: {description}"))
            .collect::<Vec<_>>()
            .join("\n");
        let properties = json!({
            "agent_id": {
                "type": "string",
                "enum": names,
                "description": "Agent ID"
            },
            "prompt": {
                "type": "string",
                "description": "Self-contained task and all context the agent needs"
            }
        });
        let parallel_guidance =
            " Independent agent calls in the same batch run together - issue them in one turn for parallel work.";
        let background_guidance = " Every call starts a background run and returns its id immediately. Completions arrive automatically at safe provider boundaries and wake an idle parent. Continue independent work, or end your turn to wait for required results. Never sleep or poll for results, and do not declare the task complete before required agents finish.";
        rho_sdk::model::ToolSpec {
            name: AGENT_TOOL.into(),
            description: format!(
                "Delegate a substantial, self-contained task to a fresh agent.{parallel_guidance}{background_guidance}\n\nAgents:\n{summaries}"
            ),
            input_schema: json!({
                "type": "object",
                "properties": properties,
                "required": ["agent_id", "prompt"],
                "additionalProperties": false
            }),
        }
    }

    fn security(&self) -> ToolSecurity {
        ToolSecurity::built_in([])
    }

    fn prepare<'a>(
        &'a self,
        invocation: ToolInvocation,
        _context: ToolPreparationContext,
    ) -> ToolPrepareFuture<'a> {
        let args = parse_agent_args(invocation.into_arguments());
        Box::pin(async move {
            let args = args?;
            // Registry ops are mutex-protected and short. Shared access lets
            // several launches in one batch overlap.
            Ok(PreparedToolInvocation::resource_aware(
                [ToolResourceAccess::shared(ToolResource::manager_state(
                    SUBAGENT_MANAGER,
                ))],
                [],
                agent_metadata(),
                move |context| Box::pin(async move { self.execute(args, &context).await }),
            ))
        })
    }
}

pub struct AgentsTool {
    manager: SubagentManager,
}

impl AgentsTool {
    pub fn new(manager: SubagentManager) -> Self {
        Self { manager }
    }

    async fn execute(&self, args: AgentsArgs) -> Result<ToolOutput, ToolError> {
        let content = match args.action.as_str() {
            "list" => {
                let agents = self.manager.list();
                if agents.is_empty() {
                    "no delegated agents".to_string()
                } else {
                    agents
                        .iter()
                        .map(format_list_entry)
                        .collect::<Vec<_>>()
                        .join("\n")
                }
            }
            "status" => {
                let id = required_id(&args)?;
                let snapshot = self.manager.observe(id).ok_or_else(|| {
                    ToolError::new(
                        ToolErrorKind::InvalidArguments,
                        format!("unknown delegated run '{id}'"),
                    )
                })?;
                // A finished run hands over its full result here and counts
                // as delivered; a running run reports progress only.
                let format = if snapshot.done {
                    SnapshotFormat::Completion
                } else {
                    SnapshotFormat::Status
                };
                format_snapshot(&snapshot, format)
            }
            "stop" => {
                let id = required_id(&args)?;
                let snapshot =
                    self.manager.stop(id).await.map_err(|error| {
                        ToolError::new(ToolErrorKind::Execution, error.to_string())
                    })?;
                format_snapshot(&snapshot, SnapshotFormat::Completion)
            }
            "message" => {
                let id = required_id(&args)?;
                let text = args.message.as_deref().ok_or_else(|| {
                    ToolError::new(
                        ToolErrorKind::InvalidArguments,
                        "message action requires message text",
                    )
                })?;
                // Parse at this argument boundary so an empty or over-budget
                // body reads as invalid arguments, not an execution failure.
                let message = ValidatedMessage::parse(text).map_err(|error| {
                    ToolError::new(ToolErrorKind::InvalidArguments, error.to_string())
                })?;
                self.manager
                    .message(id, &message)
                    .await
                    .map_err(|error| ToolError::new(ToolErrorKind::Execution, error.to_string()))?;
                match self.manager.task_identity(id) {
                    Some(identity) => message_receipt::MessageReceipt {
                        run_id: identity.run_id,
                        agent_id: identity.agent_id,
                        task: identity.task,
                    }
                    .content(),
                    None => format!("queued parent message for delegated run '{id}'"),
                }
            }
            other => {
                return Err(ToolError::new(
                    ToolErrorKind::InvalidArguments,
                    format!("unknown action '{other}': expected list, status, stop, or message"),
                ))
            }
        };
        Ok(ToolOutput::text(content).metadata(agents_metadata()))
    }
}

#[derive(Deserialize)]
struct AgentsArgs {
    action: String,
    #[serde(default)]
    id: Option<String>,
    #[serde(default)]
    message: Option<String>,
}

impl Tool for AgentsTool {
    fn spec(&self) -> rho_sdk::model::ToolSpec {
        rho_sdk::model::ToolSpec {
            name: AGENTS_TOOL.into(),
            description: "Check on, stop, or message a delegated background run. Completions and child notices are delivered automatically at safe provider boundaries during work and before final completion. Completions and requests for parent action can wake an idle parent; informational child notices cannot. Waiting for a result means ending your turn, not polling status. While a run is in progress, status reports progress only and never partial output - do not act on a run's result before it finishes. Once a run has finished, status or stop returns its final result with pending notices as earlier context and counts as delivery, so it will not be redelivered automatically. Use action=message to steer a running child with plain text: Rho-runtime children apply it at the next provider turn; claude-cli children receive it as a queued stream-json user turn; cursor children cannot be messaged (process-per-turn).".into(),
            input_schema: json!({
                "type": "object",
                "properties": {
                    "action": {
                        "type": "string",
                        "enum": ["list", "status", "stop", "message"],
                        "description": "Operation to perform"
                    },
                    "id": {
                        "type": "string",
                        "description": "Delegated run ID (required for status, stop, and message)"
                    },
                    "message": {
                        "type": "string",
                        "description": "Plain-text parent message (required for message). Rho children apply it at the next provider turn; Claude-cli children queue it as the next stdin user turn; cursor children cannot be messaged (process-per-turn)."
                    }
                },
                "required": ["action"],
                "additionalProperties": false
            }),
        }
    }

    fn security(&self) -> ToolSecurity {
        ToolSecurity::built_in([])
    }

    fn prepare<'a>(
        &'a self,
        invocation: ToolInvocation,
        _context: ToolPreparationContext,
    ) -> ToolPrepareFuture<'a> {
        let args = parse_agents_args(invocation.into_arguments());
        Box::pin(async move {
            let args = args?;
            // list/status/stop all touch the mutex-backed registry briefly.
            // Shared access keeps lifecycle ops from serializing launches.
            Ok(PreparedToolInvocation::resource_aware(
                [ToolResourceAccess::shared(ToolResource::manager_state(
                    SUBAGENT_MANAGER,
                ))],
                [],
                agents_metadata(),
                move |_context| Box::pin(async move { self.execute(args).await }),
            ))
        })
    }
}

fn parse_agent_args(arguments: Value) -> Result<AgentArgs, ToolError> {
    serde_json::from_value(arguments)
        .map_err(|error| ToolError::new(ToolErrorKind::InvalidArguments, error.to_string()))
}

fn parse_agents_args(arguments: Value) -> Result<AgentsArgs, ToolError> {
    serde_json::from_value(arguments)
        .map_err(|error| ToolError::new(ToolErrorKind::InvalidArguments, error.to_string()))
}

fn agent_metadata() -> ToolMetadata {
    ToolMetadata::new().operation(OperationKind::Other(AGENT_TOOL.into()))
}

fn agents_metadata() -> ToolMetadata {
    ToolMetadata::new().operation(OperationKind::Other(AGENTS_TOOL.into()))
}

fn required_id(args: &AgentsArgs) -> Result<&str, ToolError> {
    args.id
        .as_deref()
        .filter(|id| !id.is_empty())
        .ok_or_else(|| {
            ToolError::new(
                ToolErrorKind::InvalidArguments,
                "this action requires a delegated run id",
            )
        })
}

#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub(super) enum DelegationToolSelection {
    Launch,
    Manage,
    LaunchAndManage,
}

impl DelegationToolSelection {
    pub(super) fn from_capabilities(
        capabilities: &crate::agent::AgentCapabilities,
    ) -> Option<Self> {
        use crate::agent::ToolCapability;

        match (
            capabilities.contains(&ToolCapability::Agent),
            capabilities.contains(&ToolCapability::Agents),
        ) {
            (true, true) => Some(Self::LaunchAndManage),
            (true, false) => Some(Self::Launch),
            (false, true) => Some(Self::Manage),
            (false, false) => None,
        }
    }

    fn launches(self) -> bool {
        matches!(self, Self::Launch | Self::LaunchAndManage)
    }

    fn manages(self) -> bool {
        matches!(self, Self::Manage | Self::LaunchAndManage)
    }
}

pub(super) struct DelegationBundleOptions {
    pub cwd: PathBuf,
    pub tools: DelegationToolSelection,
    pub config_path: PathBuf,
    /// Catalog already discovered for `cwd`; rediscovered when absent.
    pub catalog: Option<Arc<AgentCatalog>>,
}

pub(super) struct SdkDelegationBundle {
    tools: Vec<Arc<dyn rho_sdk::tool::Tool>>,
    manager: SubagentManager,
}

impl SdkDelegationBundle {
    pub(super) fn manager_handle(&self) -> SubagentManager {
        self.manager.clone()
    }
}

impl super::sdk_registry::ToolBundle for SdkDelegationBundle {
    fn tools(&self) -> &[Arc<dyn rho_sdk::tool::Tool>] {
        &self.tools
    }

    fn shutdown(&self) -> Pin<Box<dyn Future<Output = ()> + Send + '_>> {
        Box::pin(self.manager.shutdown())
    }
}

pub(super) fn sdk_bundle(
    config: &crate::config::Config,
    options: DelegationBundleOptions,
    mutation_observer: Arc<dyn rho_tools::WorkspaceMutationObserver>,
) -> SdkDelegationBundle {
    let manager = SubagentManager::new(config.clone(), options.config_path, options.cwd.clone());
    let mut tools = Vec::<Arc<dyn rho_sdk::tool::Tool>>::new();
    if options.tools.launches() {
        tools.push(Arc::new(
            AgentTool::new(manager.clone(), &options.cwd, options.catalog)
                .with_mutation_observer(mutation_observer),
        ));
    }
    if options.tools.manages() {
        tools.push(Arc::new(AgentsTool::new(manager.clone())));
    }
    SdkDelegationBundle { tools, manager }
}

#[cfg(test)]
#[path = "agent_tests.rs"]
mod tests;