rho-coding-agent 1.48.0

A lightweight agent harness inspired by Pi
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133

use super::*;

use std::path::PathBuf;

use rho_sdk::CancellationToken;

// Covers: Claude one-shot advisor must spawn with Claude dontAsk, not plan
// (plan scaffolding poisons guidance). Asserts the spawn-plan argv that
// run_one_shot builds, not only the constant, so a production wiring drift
// fails this test.
// Owner: Claude one-shot adapter.
#[test]
fn one_shot_spawn_plan_uses_claude_dont_ask() {
    let request = ClaudeOneShotRequest {
        system_prompt: "rho advisor prompt",
        input: "session transcript".into(),
        model: Some("opus".into()),
        reasoning: None,
        cwd: PathBuf::from("/tmp/project"),
        cancellation: CancellationToken::new(),
    };
    let plan = spawn::build_spawn_plan(&one_shot_spawn_request(&request));

    assert_eq!(ONE_SHOT_PERMISSION_MODE, ClaudePermissionMode::DontAsk);
    assert!(
        plan.args
            .windows(2)
            .any(|pair| pair == ["--permission-mode", "dontAsk"]),
        "one-shot argv must use dontAsk: {:?}",
        plan.args
    );
    assert!(
        !plan
            .args
            .windows(2)
            .any(|pair| pair == ["--permission-mode", "plan"]),
        "one-shot argv must not use plan: {:?}",
        plan.args
    );
    assert!(
        plan.args.windows(2).any(|pair| pair == ["--tools", ""]),
        "one-shot argv must expose no tools: {:?}",
        plan.args
    );
    assert!(
        plan.args
            .windows(2)
            .any(|pair| pair == ["--setting-sources", ""]),
        "one-shot dontAsk must not load Claude setting sources: {:?}",
        plan.args
    );
    assert!(
        plan.args
            .iter()
            .any(|arg| arg == "--no-session-persistence"),
        "one-shot argv must discard the session: {:?}",
        plan.args
    );
}

fn exit_status() -> std::process::ExitStatus {
    #[cfg(unix)]
    {
        std::process::Command::new("false").status().unwrap()
    }
    #[cfg(windows)]
    {
        std::process::Command::new("cmd")
            .args(["/C", "exit 1"])
            .status()
            .unwrap()
    }
}

// Covers: advisor callers receive the shared unsupported-flag diagnosis, not
// a generic missing-result error.
// Owner: Claude one-shot adapter.
#[test]
fn unsupported_max_turns_uses_shared_terminal_diagnosis() {
    let result = finish(
        String::new(),
        None,
        "error: unknown option '--max-turns'",
        exit_status(),
    );
    let Err(error) = result else {
        panic!("unsupported --max-turns must fail");
    };

    assert_eq!(
        error,
        "claude code: this claude binary rejected --max-turns; upgrade Claude Code or remove the turn cap"
    );
}

// Covers: Claude Code safeguard / API errors arrive as stream-json result text
// with exit 1 and empty stderr; the advisor tool error must carry that text.
// Owner: Claude one-shot adapter.
#[test]
fn safeguard_stream_failure_surfaces_in_one_shot_error() {
    use crate::claude_runtime::stream::{TerminalClassification, TerminalResult};

    let terminal = TerminalResult {
        classification: TerminalClassification::Failure {
            subtype: "success".into(),
            is_error: true,
        },
        result_text: Some(
            "API Error: Fable 5's safeguards flagged this message (https://www.anthropic.com/legal/aup). Claude Code can't respond to this message with Fable 5. Try rephrasing the request in a new session or change your model."
                .into(),
        ),
        error: Some(
            "API Error: Fable 5's safeguards flagged this message (https://www.anthropic.com/legal/aup). Claude Code can't respond to this message with Fable 5. Try rephrasing the request in a new session or change your model."
                .into(),
        ),
        session_id: Some("s".into()),
        num_turns: Some(1),
        usage: None,
        context: None,
        total_cost_usd: None,
        permission_denials: Vec::new(),
        stop_reason: None,
    };

    let result = finish(String::new(), Some(terminal), "", exit_status());
    let Err(error) = result else {
        panic!("safeguard failure must error");
    };
    assert!(
        error.contains("safeguards flagged") && error.contains("change your model"),
        "advisor one-shot must return the stream API error, got: {error}"
    );
}