rho-coding-agent 0.8.0

A lightweight agent harness inspired by Pi
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
use std::{
    collections::VecDeque,
    sync::{Arc, Mutex},
};

use async_trait::async_trait;

use super::*;
use crate::model::{ContextUsageSource, ModelProvider, ModelRequest, ModelResponse};
use crate::tool::{Tool, ToolCall, ToolSpec};

type RecordedRequests = Arc<Mutex<Vec<(String, Vec<Message>)>>>;

#[derive(Clone, Default)]
struct RecordingHistorySink {
    appended: Arc<Mutex<Vec<Message>>>,
    replaced: Arc<Mutex<Vec<Message>>>,
}

impl RecordingHistorySink {
    fn append_target(target: Arc<Mutex<Vec<Message>>>) -> Self {
        Self {
            appended: target,
            replaced: Arc::default(),
        }
    }

    fn replace_target(target: Arc<Mutex<Vec<Message>>>) -> Self {
        Self {
            appended: Arc::default(),
            replaced: target,
        }
    }
}

impl HistorySink for RecordingHistorySink {
    fn append_message(&mut self, message: &Message) -> anyhow::Result<()> {
        self.appended.lock().unwrap().push(message.clone());
        Ok(())
    }

    fn replace_history(&mut self, messages: &[Message]) -> anyhow::Result<()> {
        self.replaced
            .lock()
            .unwrap()
            .extend(messages.iter().cloned());
        Ok(())
    }
}

#[derive(Clone, Default)]
struct RecordingProvider {
    requests: Arc<Mutex<Vec<Vec<Message>>>>,
    tools: Arc<Mutex<Vec<Vec<ToolSpec>>>>,
    prompt_cache_keys: Arc<Mutex<Vec<Option<String>>>>,
    response: Option<ModelResponse>,
}

#[async_trait(?Send)]
impl ModelProvider for RecordingProvider {
    async fn send_turn(&self, request: ModelRequest) -> Result<ModelResponse, ModelError> {
        self.prompt_cache_keys
            .lock()
            .unwrap()
            .push(request.prompt_cache_key.clone());
        self.tools.lock().unwrap().push(request.tools.clone());
        self.requests.lock().unwrap().push(request.messages);
        Ok(self
            .response
            .clone()
            .unwrap_or_else(|| ModelResponse::Assistant(vec![ContentBlock::Text("ok".into())])))
    }
}

fn test_agent(provider: RecordingProvider) -> Agent {
    test_agent_with_tools(provider, ToolRegistry::new())
}

fn test_agent_with_tools(provider: impl ModelProvider + 'static, tools: ToolRegistry) -> Agent {
    Agent::new(
        Box::new(provider),
        tools,
        ToolContext {
            cwd: std::env::current_dir().unwrap(),
            max_output_bytes: 12000,
        },
    )
}

struct FailingProvider {
    requests: Arc<Mutex<usize>>,
    error: ModelError,
}

#[async_trait(?Send)]
impl ModelProvider for FailingProvider {
    async fn send_turn(&self, _request: ModelRequest) -> Result<ModelResponse, ModelError> {
        *self.requests.lock().unwrap() += 1;
        Err(match &self.error {
            ModelError::MissingApiKey => ModelError::MissingApiKey,
            ModelError::InvalidResponse(message) => ModelError::InvalidResponse(message.clone()),
            _ => unreachable!("test only clones selected errors"),
        })
    }
}

struct TransientInvalidResponseProvider {
    requests: Arc<Mutex<usize>>,
}

#[async_trait(?Send)]
impl ModelProvider for TransientInvalidResponseProvider {
    async fn send_turn(&self, _request: ModelRequest) -> Result<ModelResponse, ModelError> {
        let mut requests = self.requests.lock().unwrap();
        *requests += 1;
        if *requests == 1 {
            return Err(ModelError::InvalidResponse(
                "temporary parse failure".into(),
            ));
        }
        Ok(ModelResponse::Assistant(vec![ContentBlock::Text(
            "ok".into(),
        )]))
    }
}

struct SequencedProvider {
    requests: Arc<Mutex<Vec<Vec<Message>>>>,
    responses: Mutex<VecDeque<ModelResponse>>,
}

#[async_trait(?Send)]
impl ModelProvider for SequencedProvider {
    async fn send_turn(&self, request: ModelRequest) -> Result<ModelResponse, ModelError> {
        self.requests.lock().unwrap().push(request.messages);
        Ok(self.responses.lock().unwrap().pop_front().unwrap())
    }
}

struct UsageStreamingProvider;

#[async_trait(?Send)]
impl ModelProvider for UsageStreamingProvider {
    async fn send_turn(&self, _request: ModelRequest) -> Result<ModelResponse, ModelError> {
        unreachable!("streaming provider should use send_turn_stream")
    }

    async fn send_turn_stream(
        &self,
        _request: ModelRequest,
        on_event: &mut dyn FnMut(ModelEvent) -> Result<(), ModelError>,
    ) -> Result<ModelResponse, ModelError> {
        on_event(ModelEvent::Usage(ModelUsage {
            input_tokens: Some(300),
            cache_read_tokens: Some(700),
            context_window: Some(10_000),
            ..ModelUsage::default()
        }))?;
        Ok(ModelResponse::Assistant(vec![ContentBlock::Text(
            "ok".into(),
        )]))
    }
}

struct CompactingProvider {
    requests: RecordedRequests,
}

#[async_trait(?Send)]
impl ModelProvider for CompactingProvider {
    async fn send_turn(&self, request: ModelRequest) -> Result<ModelResponse, ModelError> {
        self.requests
            .lock()
            .unwrap()
            .push(("summary".into(), request.messages));
        Ok(ModelResponse::Assistant(vec![ContentBlock::Text(
            "compacted summary".into(),
        )]))
    }

    async fn send_turn_stream(
        &self,
        request: ModelRequest,
        on_event: &mut dyn FnMut(ModelEvent) -> Result<(), ModelError>,
    ) -> Result<ModelResponse, ModelError> {
        let is_summary_request = matches!(
            request.messages.first(),
            Some(Message::System(text)) if text.starts_with("Summarize the conversation history")
        );
        if is_summary_request {
            self.requests
                .lock()
                .unwrap()
                .push(("summary".into(), request.messages));
            on_event(ModelEvent::Usage(ModelUsage {
                input_tokens: Some(100),
                output_tokens: Some(20),
                ..ModelUsage::default()
            }))?;
            return Ok(ModelResponse::Assistant(vec![ContentBlock::Text(
                "compacted summary".into(),
            )]));
        }
        self.requests
            .lock()
            .unwrap()
            .push(("normal".into(), request.messages));
        on_event(ModelEvent::Usage(ModelUsage {
            input_tokens: Some(900),
            ..ModelUsage::default()
        }))?;
        Ok(ModelResponse::Assistant(vec![ContentBlock::Text(
            "ok".into(),
        )]))
    }
}

struct OkTool;

#[async_trait]
impl Tool for OkTool {
    fn spec(&self) -> ToolSpec {
        ToolSpec {
            name: "ok_tool".into(),
            description: "test tool".into(),
            input_schema: serde_json::json!({"type": "object"}),
        }
    }

    async fn call(
        &self,
        _args: serde_json::Value,
        _ctx: ToolContext,
        id: String,
    ) -> Result<ToolResult, ToolError> {
        Ok(ToolResult {
            id,
            ok: true,
            content: "tool ok".into(),
        })
    }
}

struct FailingTool;

#[async_trait]
impl Tool for FailingTool {
    fn spec(&self) -> ToolSpec {
        ToolSpec {
            name: "failing_tool".into(),
            description: "test failing tool".into(),
            input_schema: serde_json::json!({"type": "object"}),
        }
    }

    async fn call(
        &self,
        _args: serde_json::Value,
        _ctx: ToolContext,
        _id: String,
    ) -> Result<ToolResult, ToolError> {
        Err(ToolError::Message("tool failed".into()))
    }
}

#[tokio::test]
async fn does_not_retry_non_recoverable_provider_errors() {
    let requests = Arc::new(Mutex::new(0));
    let mut agent = Agent::new(
        Box::new(FailingProvider {
            requests: requests.clone(),
            error: ModelError::MissingApiKey,
        }),
        ToolRegistry::new(),
        ToolContext {
            cwd: std::env::current_dir().unwrap(),
            max_output_bytes: 12000,
        },
    );

    let err = agent.run("hello".into()).await.unwrap_err();

    assert!(matches!(
        err,
        AgentError::Provider(ModelError::MissingApiKey)
    ));
    assert_eq!(*requests.lock().unwrap(), 1);
}

#[tokio::test]
async fn retries_recoverable_invalid_response_errors() {
    let requests = Arc::new(Mutex::new(0));
    let mut agent = Agent::new(
        Box::new(TransientInvalidResponseProvider {
            requests: requests.clone(),
        }),
        ToolRegistry::new(),
        ToolContext {
            cwd: std::env::current_dir().unwrap(),
            max_output_bytes: 12000,
        },
    );

    let output = agent.run("hello".into()).await.unwrap();

    assert_eq!(output, "ok");
    assert_eq!(*requests.lock().unwrap(), 2);
}

#[test]
fn load_skill_truncates_contents_before_persisting() {
    let root = tempfile::tempdir().unwrap();
    let skill = crate::skills::Skill {
        name: "long-skill".into(),
        description: "long skill".into(),
        path: root.path().join(".agents/skills/long-skill/SKILL.md"),
        contents: "abcdefghijklmnopqrstuvwxyz".into(),
    };
    let persisted = Arc::new(Mutex::new(Vec::new()));
    let mut agent = Agent::new(
        Box::new(RecordingProvider::default()),
        ToolRegistry::new(),
        ToolContext {
            cwd: root.path().to_path_buf(),
            max_output_bytes: 8,
        },
    );
    agent.set_history_sink(RecordingHistorySink::append_target(persisted.clone()));

    agent.load_skill(&skill).unwrap();

    let persisted = persisted.lock().unwrap();
    let Message::User(blocks) = persisted.last().unwrap() else {
        panic!("expected persisted user message");
    };
    let [ContentBlock::Text(text)] = blocks.as_slice() else {
        panic!("expected single text block");
    };
    assert!(text.contains("abcdefgh\n[truncated]"));
    assert!(!text.contains("ijklmnopqrstuvwxyz"));
}

#[tokio::test]
async fn includes_session_derived_prompt_cache_key_in_model_requests() {
    let provider = RecordingProvider::default();
    let prompt_cache_keys = provider.prompt_cache_keys.clone();
    let mut agent = test_agent(provider);

    agent.set_session_id(Some("session / one".into()));
    agent.run("first".into()).await.unwrap();
    agent.set_session_id(None);
    agent.run("second".into()).await.unwrap();

    assert_eq!(
        *prompt_cache_keys.lock().unwrap(),
        vec![Some("rho:session-one".into()), None]
    );
}

#[tokio::test]
async fn emits_estimated_context_usage_before_provider_call() {
    let mut agent = test_agent(RecordingProvider::default());
    let mut context_events = Vec::new();

    agent
        .run_with_events("hello".into(), |event| {
            if let AgentEvent::ContextUsage(usage) = event {
                context_events.push(usage);
            }
            Ok(())
        })
        .await
        .unwrap();

    assert_eq!(context_events.len(), 1);
    assert_eq!(context_events[0].source, ContextUsageSource::Estimated);
    assert!(context_events[0].tokens.unwrap() > 0);
}

#[tokio::test]
async fn emits_provider_reported_context_usage_from_model_usage() {
    let mut agent = test_agent_with_tools(UsageStreamingProvider, ToolRegistry::new());
    let mut context_events = Vec::new();

    agent
        .run_with_events("hello".into(), |event| {
            if let AgentEvent::ContextUsage(usage) = event {
                context_events.push(usage);
            }
            Ok(())
        })
        .await
        .unwrap();

    assert_eq!(context_events.len(), 2);
    assert_eq!(context_events[0].source, ContextUsageSource::Estimated);
    assert_eq!(
        context_events[1].source,
        ContextUsageSource::ProviderReported
    );
    assert_eq!(context_events[1].tokens, Some(1_000));
    assert_eq!(context_events[1].context_window, Some(10_000));
}

#[tokio::test]
async fn compacts_history_before_normal_provider_call_when_threshold_is_exceeded_with_configured_context_window(
) {
    let requests = Arc::new(Mutex::new(Vec::new()));
    let mut agent = test_agent_with_tools(
        CompactingProvider {
            requests: requests.clone(),
        },
        ToolRegistry::new(),
    );
    agent.set_compaction_config(CompactionConfig {
        auto_compact: true,
        threshold_percent: 1,
        recent_messages: 1,
    });
    agent.set_context_window(Some(1_000));

    agent.run("first".into()).await.unwrap();
    agent.run("second".into()).await.unwrap();

    let requests = requests.lock().unwrap();
    assert_eq!(requests.len(), 3);
    assert_eq!(requests[0].0, "normal");
    assert_eq!(requests[1].0, "summary");
    assert_eq!(requests[2].0, "normal");
    assert!(matches!(
        requests[1].1.as_slice(),
        [Message::System(_), Message::User(_)]
    ));
    assert!(requests[2].1.iter().any(|message| {
        matches!(message, Message::User(blocks) if matches!(blocks.as_slice(), [ContentBlock::Text(text)] if text.contains("compacted summary")))
    }));
    assert!(
        matches!(requests[2].1.last(), Some(Message::User(blocks)) if matches!(blocks.as_slice(), [ContentBlock::Text(text)] if text == "second"))
    );
}

#[tokio::test]
async fn emits_usage_for_compaction_summary_request() {
    let requests = Arc::new(Mutex::new(Vec::new()));
    let mut agent = test_agent_with_tools(
        CompactingProvider {
            requests: requests.clone(),
        },
        ToolRegistry::new(),
    );
    agent.set_compaction_config(CompactionConfig {
        auto_compact: true,
        threshold_percent: 1,
        recent_messages: 1,
    });
    agent.set_context_window(Some(1_000));
    let mut usage_events = Vec::new();

    agent
        .run_with_events("first".into(), |_| Ok(()))
        .await
        .unwrap();
    agent
        .run_with_events("second".into(), |event| {
            if let AgentEvent::Usage(usage) = event {
                usage_events.push(usage);
            }
            Ok(())
        })
        .await
        .unwrap();

    assert!(usage_events
        .iter()
        .any(|usage| { usage.input_tokens == Some(100) && usage.output_tokens == Some(20) }));
}

#[tokio::test]
async fn compacts_after_tool_results_before_next_provider_call() {
    let requests = Arc::new(Mutex::new(Vec::new()));
    let response = ModelResponse::Assistant(vec![ContentBlock::ToolCall(ToolCall {
        id: "call_1".into(),
        name: "ok_tool".into(),
        arguments: serde_json::json!({}),
    })]);
    let provider = SequencedProvider {
        requests: requests.clone(),
        responses: Mutex::new(VecDeque::from([
            response,
            ModelResponse::Assistant(vec![ContentBlock::Text("summary".into())]),
            ModelResponse::Assistant(vec![ContentBlock::Text("recovered".into())]),
        ])),
    };
    let mut tools = ToolRegistry::new();
    tools.register(OkTool);
    let mut agent = test_agent_with_tools(provider, tools);
    agent.set_compaction_config(CompactionConfig {
        auto_compact: true,
        threshold_percent: 1,
        recent_messages: 1,
    });
    agent.set_context_window(Some(1));

    let output = agent.run("run tool".into()).await.unwrap();

    assert_eq!(output, "recovered");
    let requests = requests.lock().unwrap();
    assert_eq!(requests.len(), 3);
    assert!(matches!(
        requests[1].as_slice(),
        [Message::System(_), Message::User(_)]
    ));
    assert!(requests[2].iter().any(|message| {
        matches!(message, Message::User(blocks) if matches!(blocks.as_slice(), [ContentBlock::Text(text)] if text.contains("summary")))
    }));
}

#[tokio::test]
async fn unknown_after_compaction_is_not_overwritten_by_estimate_before_provider_usage() {
    let mut agent = test_agent_with_tools(
        SequencedProvider {
            requests: Arc::new(Mutex::new(Vec::new())),
            responses: Mutex::new(VecDeque::from(vec![
                ModelResponse::Assistant(vec![ContentBlock::Text("first ok".into())]),
                ModelResponse::Assistant(vec![ContentBlock::Text("summary".into())]),
                ModelResponse::Assistant(vec![ContentBlock::Text("second ok".into())]),
            ])),
        },
        ToolRegistry::new(),
    );
    agent.set_compaction_config(CompactionConfig {
        auto_compact: true,
        threshold_percent: 1,
        recent_messages: 1,
    });
    agent.set_context_window(Some(1_000));
    let mut context_events = Vec::new();

    agent
        .run_with_events("first".into(), |event| {
            if let AgentEvent::ContextUsage(usage) = event {
                context_events.push(usage);
            }
            Ok(())
        })
        .await
        .unwrap();
    agent
        .run_with_events("second".into(), |event| {
            if let AgentEvent::ContextUsage(usage) = event {
                context_events.push(usage);
            }
            Ok(())
        })
        .await
        .unwrap();

    assert_eq!(context_events.len(), 2);
    assert_eq!(context_events[0].source, ContextUsageSource::Estimated);
    assert_eq!(context_events[0].context_window, Some(1_000));
    assert_eq!(
        context_events[1].source,
        ContextUsageSource::UnknownAfterCompaction
    );
    assert_eq!(context_events[1].context_window, Some(1_000));
}

#[test]
fn compaction_persists_replacement_history_without_initial_system_message() {
    let persisted = Arc::new(Mutex::new(Vec::new()));
    let mut agent = test_agent(RecordingProvider::default());
    agent.set_history_sink(RecordingHistorySink::replace_target(persisted.clone()));
    agent.messages = vec![
        Message::System("system".into()),
        Message::user_text("summary"),
        Message::user_text("recent"),
    ];

    agent.persist_history_replacement().unwrap();

    let persisted = persisted.lock().unwrap();
    assert_eq!(persisted.len(), 2);
    assert!(matches!(persisted[0], Message::User(_)));
    assert!(matches!(persisted[1], Message::User(_)));
}

#[tokio::test]
async fn preserves_history_across_runs() {
    let provider = RecordingProvider::default();
    let requests = provider.requests.clone();
    let mut agent = test_agent(provider);

    agent.run("first".into()).await.unwrap();
    agent.run("second".into()).await.unwrap();

    let requests = requests.lock().unwrap();
    assert_eq!(requests.len(), 2);
    assert!(matches!(requests[1][0], Message::System(_)));
    assert!(
        matches!(requests[1][1], Message::User(ref blocks) if matches!(blocks.as_slice(), [ContentBlock::Text(s)] if s == "first"))
    );
    assert!(
        matches!(requests[1][2], Message::Assistant(ref blocks) if matches!(blocks.as_slice(), [ContentBlock::Text(s)] if s == "ok"))
    );
    assert!(
        matches!(requests[1][3], Message::User(ref blocks) if matches!(blocks.as_slice(), [ContentBlock::Text(s)] if s == "second"))
    );
}

#[tokio::test]
async fn interrupting_before_tools_leaves_no_unmatched_tool_call() {
    let persisted = Arc::new(Mutex::new(Vec::new()));
    let response = ModelResponse::Assistant(vec![ContentBlock::ToolCall(ToolCall {
        id: "call_1".into(),
        name: "ok_tool".into(),
        arguments: serde_json::json!({}),
    })]);
    let provider = RecordingProvider {
        requests: Arc::default(),
        tools: Arc::default(),
        prompt_cache_keys: Arc::default(),
        response: Some(response),
    };
    let mut tools = ToolRegistry::new();
    tools.register(OkTool);
    let mut agent = test_agent_with_tools(provider, tools);
    agent.set_history_sink(RecordingHistorySink::append_target(persisted.clone()));

    let err = agent
        .run_with_events("run tools".into(), |event| match event {
            AgentEvent::ToolStarted => Err(ModelError::Interrupted),
            _ => Ok(()),
        })
        .await
        .unwrap_err();

    assert!(matches!(err, AgentError::Provider(ModelError::Interrupted)));
    let persisted = persisted.lock().unwrap();
    assert!(persisted
        .iter()
        .all(|message| !matches!(message, Message::Assistant(_) | Message::ToolResult(_))));
}

#[tokio::test]
async fn persists_all_tool_results_before_interrupting_tool_events() {
    let persisted = Arc::new(Mutex::new(Vec::new()));
    let response = ModelResponse::Assistant(vec![
        ContentBlock::ToolCall(ToolCall {
            id: "call_1".into(),
            name: "ok_tool".into(),
            arguments: serde_json::json!({}),
        }),
        ContentBlock::ToolCall(ToolCall {
            id: "call_2".into(),
            name: "ok_tool".into(),
            arguments: serde_json::json!({}),
        }),
    ]);
    let provider = RecordingProvider {
        requests: Arc::default(),
        tools: Arc::default(),
        prompt_cache_keys: Arc::default(),
        response: Some(response),
    };
    let mut tools = ToolRegistry::new();
    tools.register(OkTool);
    let mut agent = test_agent_with_tools(provider, tools);
    agent.set_history_sink(RecordingHistorySink::append_target(persisted.clone()));

    let err = agent
        .run_with_events("run tools".into(), |event| match event {
            AgentEvent::ToolFinished { .. } => Err(ModelError::Interrupted),
            _ => Ok(()),
        })
        .await
        .unwrap_err();

    assert!(matches!(err, AgentError::Provider(ModelError::Interrupted)));
    let persisted = persisted.lock().unwrap();
    let tool_result_count = persisted
        .iter()
        .filter(|message| matches!(message, Message::ToolResult(_)))
        .count();
    assert_eq!(tool_result_count, 2);
}

#[tokio::test]
async fn tool_errors_are_returned_to_model_without_stopping_loop() {
    let requests = Arc::new(Mutex::new(Vec::new()));
    let response = ModelResponse::Assistant(vec![ContentBlock::ToolCall(ToolCall {
        id: "call_1".into(),
        name: "failing_tool".into(),
        arguments: serde_json::json!({}),
    })]);
    let provider = SequencedProvider {
        requests: requests.clone(),
        responses: Mutex::new(VecDeque::from([
            response,
            ModelResponse::Assistant(vec![ContentBlock::Text("recovered".into())]),
        ])),
    };
    let mut tools = ToolRegistry::new();
    tools.register(FailingTool);
    let mut agent = test_agent_with_tools(provider, tools);
    let mut tool_events = Vec::new();

    let output = agent
        .run_with_events("run tool".into(), |event| {
            if let AgentEvent::ToolFinished { ok, content, .. } = event {
                tool_events.push((ok, content));
            }
            Ok(())
        })
        .await
        .unwrap();

    assert_eq!(output, "recovered");
    assert_eq!(tool_events, vec![(false, "tool failed".into())]);
    let requests = requests.lock().unwrap();
    assert_eq!(requests.len(), 2);
    assert!(matches!(
        requests[1].last(),
        Some(Message::ToolResult(ToolResult { ok: false, content, .. })) if content == "tool failed"
    ));
}

#[tokio::test]
async fn unknown_tools_are_returned_to_model_without_stopping_loop() {
    let requests = Arc::new(Mutex::new(Vec::new()));
    let response = ModelResponse::Assistant(vec![ContentBlock::ToolCall(ToolCall {
        id: "call_1".into(),
        name: "missing_tool".into(),
        arguments: serde_json::json!({}),
    })]);
    let provider = SequencedProvider {
        requests: requests.clone(),
        responses: Mutex::new(VecDeque::from([
            response,
            ModelResponse::Assistant(vec![ContentBlock::Text("recovered".into())]),
        ])),
    };
    let mut agent = test_agent_with_tools(provider, ToolRegistry::new());

    let output = agent.run("run tool".into()).await.unwrap();

    assert_eq!(output, "recovered");
    let requests = requests.lock().unwrap();
    assert_eq!(requests.len(), 2);
    assert!(matches!(
        requests[1].last(),
        Some(Message::ToolResult(ToolResult { ok: false, content, .. })) if content == "Unknown tool: missing_tool"
    ));
}

#[test]
fn read_file_event_content_shows_requested_line_range() {
    let cwd = std::env::current_dir().unwrap();
    let content = crate::tools::read_file::ReadFile
        .display_content(
            &serde_json::json!({"path": "src/main.rs", "offset": 10, "limit": 15}),
            &ToolContext {
                cwd,
                max_output_bytes: 12000,
            },
        )
        .unwrap();

    assert_eq!(content, "src/main.rs:10-24");
}

#[test]
fn skill_event_content_shows_skill_name_without_full_content() {
    let cwd = std::env::current_dir().unwrap();
    let content = crate::tools::skill::Skill
        .display_content(
            &serde_json::json!({"name": "caveman"}),
            &ToolContext {
                cwd,
                max_output_bytes: 12000,
            },
        )
        .unwrap();

    assert_eq!(content, "skill caveman");
}

#[test]
fn read_file_event_content_keeps_plain_path_without_range() {
    let cwd = std::env::current_dir().unwrap();
    let content = crate::tools::read_file::ReadFile
        .display_content(
            &serde_json::json!({"path": "src/main.rs"}),
            &ToolContext {
                cwd,
                max_output_bytes: 12000,
            },
        )
        .unwrap();

    assert_eq!(content, "src/main.rs");
}

#[test]
fn read_file_event_content_uses_default_range_bounds() {
    let cwd = std::env::current_dir().unwrap();
    let context = ToolContext {
        cwd,
        max_output_bytes: 12000,
    };

    let from_offset = crate::tools::read_file::ReadFile
        .display_content(
            &serde_json::json!({"path": "src/main.rs", "offset": 10}),
            &context,
        )
        .unwrap();
    let from_limit = crate::tools::read_file::ReadFile
        .display_content(
            &serde_json::json!({"path": "src/main.rs", "limit": 20}),
            &context,
        )
        .unwrap();

    assert_eq!(from_offset, "src/main.rs:10-end");
    assert_eq!(from_limit, "src/main.rs:1-20");
}

#[test]
fn replace_history_keeps_initial_system_message() {
    let mut agent = test_agent(RecordingProvider::default());

    agent.replace_history(vec![
        Message::user_text("previous user"),
        Message::assistant_text("previous assistant"),
    ]);

    assert_eq!(agent.messages.len(), 3);
    assert!(matches!(agent.messages[0], Message::System(_)));
    assert!(
        matches!(agent.messages[1], Message::User(ref blocks) if matches!(blocks.as_slice(), [ContentBlock::Text(s)] if s == "previous user"))
    );
    assert!(
        matches!(agent.messages[2], Message::Assistant(ref blocks) if matches!(blocks.as_slice(), [ContentBlock::Text(s)] if s == "previous assistant"))
    );
}

#[tokio::test]
async fn empty_tool_registry_sends_no_tool_specs() {
    let provider = RecordingProvider::default();
    let tools = provider.tools.clone();
    let mut agent = test_agent_with_tools(provider, ToolRegistry::new());

    agent.run("hello".into()).await.unwrap();

    let tools = tools.lock().unwrap();
    assert!(tools.last().unwrap().is_empty());
}

#[tokio::test]
async fn without_system_prompt_sends_only_user_message() {
    let provider = RecordingProvider::default();
    let requests = provider.requests.clone();
    let mut agent = test_agent(provider).without_system_prompt();

    assert!(agent.messages().is_empty());

    agent.run("hello".into()).await.unwrap();

    let requests = requests.lock().unwrap();
    let request = requests.last().unwrap();
    assert_eq!(request.len(), 1);
    assert!(matches!(request[0], Message::User(_)));
}

#[test]
fn replace_history_without_system_prompt_keeps_history_only() {
    let mut agent = test_agent(RecordingProvider::default()).without_system_prompt();

    agent.replace_history(vec![Message::user_text("previous user")]);

    assert_eq!(agent.messages().len(), 1);
    assert!(matches!(agent.messages()[0], Message::User(_)));
}

#[tokio::test]
async fn reset_clears_history_back_to_system_prompt() {
    let provider = RecordingProvider::default();
    let requests = provider.requests.clone();
    let mut agent = test_agent(provider);

    agent.run("first".into()).await.unwrap();
    agent.reset();
    agent.run("after reset".into()).await.unwrap();

    let requests = requests.lock().unwrap();
    let last = requests.last().unwrap();
    assert_eq!(last.len(), 2);
    assert!(matches!(last[0], Message::System(_)));
    assert!(
        matches!(last[1], Message::User(ref blocks) if matches!(blocks.as_slice(), [ContentBlock::Text(s)] if s == "after reset"))
    );
}