rhei-flight 1.5.0

Arrow Flight SQL server for Rhei HTAP engine OLAP queries
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
//! Integration tests for the Arrow Flight SQL server.
//!
//! Starts a FlightSQL gRPC server backed by each OLAP engine, then connects
//! with `FlightSqlServiceClient` to execute queries and verify results.
//!
//! Run:
//!   cargo test -p rhei-flight --all-features

use std::net::SocketAddr;
use std::sync::Arc;
use std::time::Duration;

use arrow::array::Array;
use arrow::datatypes::{DataType, Field, Schema};
use arrow::record_batch::RecordBatch;
use arrow_flight::sql::client::FlightSqlServiceClient;
use futures::TryStreamExt;
use rhei_core::OlapEngine;
use rhei_olap::OlapBackend;
use tonic::transport::Channel;

/// Start a FlightSQL server on an ephemeral port and return the address.
async fn start_server(olap: OlapBackend) -> SocketAddr {
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
    let addr = listener.local_addr().unwrap();

    let service = rhei_flight::RheiFlightSqlService::new(olap);
    let svc = arrow_flight::flight_service_server::FlightServiceServer::new(service);

    tokio::spawn(async move {
        tonic::transport::Server::builder()
            .add_service(svc)
            .serve_with_incoming(tokio_stream::wrappers::TcpListenerStream::new(listener))
            .await
            .unwrap();
    });

    // Give the server a moment to start
    tokio::time::sleep(Duration::from_millis(50)).await;
    addr
}

/// Connect a FlightSqlServiceClient to the given address.
async fn connect(addr: SocketAddr) -> FlightSqlServiceClient<Channel> {
    let channel = Channel::from_shared(format!("http://{addr}"))
        .unwrap()
        .connect()
        .await
        .unwrap();
    FlightSqlServiceClient::new(channel)
}

/// Collect all RecordBatches from a FlightInfo response.
async fn collect_batches(
    client: &mut FlightSqlServiceClient<Channel>,
    info: arrow_flight::FlightInfo,
) -> Vec<RecordBatch> {
    let mut batches = Vec::new();
    for endpoint in info.endpoint {
        if let Some(ticket) = endpoint.ticket {
            let stream = client.do_get(ticket).await.unwrap();
            let flight_batches: Vec<RecordBatch> = stream.try_collect().await.unwrap();
            batches.extend(flight_batches);
        }
    }
    batches
}

// ---------------------------------------------------------------------------
// DataFusion backend tests
// ---------------------------------------------------------------------------

#[cfg(feature = "datafusion-backend")]
mod datafusion_tests {
    use super::*;
    use rhei_olap::{DataFusionEngine, SharedDataFusionEngine};

    async fn setup() -> (SocketAddr, OlapBackend) {
        let engine = SharedDataFusionEngine::new(DataFusionEngine::new());
        let olap = OlapBackend::DataFusion(engine.clone());

        // Create test table with data
        let schema = Arc::new(Schema::new(vec![
            Field::new("id", DataType::Int64, false),
            Field::new("name", DataType::Utf8, false),
            Field::new("score", DataType::Float64, true),
        ]));
        engine.create_table("students", &schema, &[]).await.unwrap();

        // Insert test data via load_arrow (DataFusion INSERT requires column list)
        let batch = RecordBatch::try_new(
            schema,
            vec![
                Arc::new(arrow::array::Int64Array::from(vec![1, 2, 3, 4])),
                Arc::new(arrow::array::StringArray::from(vec![
                    "Alice", "Bob", "Carol", "Dave",
                ])),
                Arc::new(arrow::array::Float64Array::from(vec![
                    Some(95.5),
                    Some(87.3),
                    Some(92.1),
                    None,
                ])),
            ],
        )
        .unwrap();
        engine.load_arrow("students", &[batch]).await.unwrap();

        let addr = start_server(olap.clone()).await;
        (addr, olap)
    }

    #[tokio::test]
    async fn test_handshake() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;
        // Handshake should succeed (no-auth)
        let result = client.handshake("user", "pass").await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_simple_select() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        let info = client
            .execute("SELECT * FROM students".into(), None)
            .await
            .unwrap();
        let batches = collect_batches(&mut client, info).await;

        let total_rows: usize = batches.iter().map(|b| b.num_rows()).sum();
        assert_eq!(total_rows, 4);
        assert_eq!(batches[0].num_columns(), 3);
    }

    #[tokio::test]
    async fn test_select_with_where() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        let info = client
            .execute("SELECT name FROM students WHERE id = 1".into(), None)
            .await
            .unwrap();
        let batches = collect_batches(&mut client, info).await;

        let total_rows: usize = batches.iter().map(|b| b.num_rows()).sum();
        assert_eq!(total_rows, 1);

        let col = batches[0]
            .column(0)
            .as_any()
            .downcast_ref::<arrow::array::StringArray>()
            .unwrap();
        assert_eq!(col.value(0), "Alice");
    }

    #[tokio::test]
    async fn test_aggregate_query() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        let info = client
            .execute(
                "SELECT COUNT(*) as cnt, AVG(score) as avg_score FROM students".into(),
                None,
            )
            .await
            .unwrap();
        let batches = collect_batches(&mut client, info).await;

        assert_eq!(batches[0].num_rows(), 1);

        let cnt = batches[0]
            .column(0)
            .as_any()
            .downcast_ref::<arrow::array::Int64Array>()
            .unwrap();
        assert_eq!(cnt.value(0), 4);
    }

    #[tokio::test]
    async fn test_null_handling() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        let info = client
            .execute("SELECT score FROM students WHERE id = 4".into(), None)
            .await
            .unwrap();
        let batches = collect_batches(&mut client, info).await;

        let col = batches[0]
            .column(0)
            .as_any()
            .downcast_ref::<arrow::array::Float64Array>()
            .unwrap();
        assert!(col.is_null(0));
    }

    #[tokio::test]
    async fn test_empty_result() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        let info = client
            .execute("SELECT * FROM students WHERE id = 999".into(), None)
            .await
            .unwrap();
        let batches = collect_batches(&mut client, info).await;

        let total_rows: usize = batches.iter().map(|b| b.num_rows()).sum();
        assert_eq!(total_rows, 0);
    }

    #[tokio::test]
    async fn test_schema_from_results() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        // Schema is provided in the DoGet response (not in FlightInfo)
        let info = client
            .execute("SELECT * FROM students".into(), None)
            .await
            .unwrap();
        let batches = collect_batches(&mut client, info).await;

        let schema = batches[0].schema();
        assert_eq!(schema.fields().len(), 3);
        assert_eq!(schema.field(0).name(), "id");
        assert_eq!(schema.field(1).name(), "name");
        assert_eq!(schema.field(2).name(), "score");
    }

    #[tokio::test]
    async fn test_prepared_statement() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        // Create prepared statement
        let mut stmt = client
            .prepare(
                "SELECT name, score FROM students WHERE score > 90".into(),
                None,
            )
            .await
            .unwrap();

        // Execute it
        let info = stmt.execute().await.unwrap();
        let batches = collect_batches(&mut client, info).await;

        let total_rows: usize = batches.iter().map(|b| b.num_rows()).sum();
        assert_eq!(total_rows, 2); // Alice (95.5) and Carol (92.1)

        // Close it
        stmt.close().await.unwrap();
    }

    #[tokio::test]
    async fn test_write_rejected() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        let result = client
            .execute_update("INSERT INTO students VALUES (5, 'Eve', 88.0)".into(), None)
            .await;
        assert!(result.is_err());
    }

    #[tokio::test]
    async fn test_invalid_sql() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        // get_flight_info succeeds (deferred execution), error surfaces at do_get
        let info = client
            .execute("SELECT * FROM nonexistent_table".into(), None)
            .await
            .unwrap();

        // do_get should fail when the query actually executes
        for endpoint in info.endpoint {
            if let Some(ticket) = endpoint.ticket {
                let result = client.do_get(ticket).await;
                assert!(result.is_err(), "do_get should fail for invalid SQL");
            }
        }
    }

    #[tokio::test]
    async fn test_concurrent_queries() {
        let (addr, _) = setup().await;

        let mut handles = Vec::new();
        for i in 0..8 {
            let addr = addr;
            handles.push(tokio::spawn(async move {
                let mut client = connect(addr).await;
                let sql = format!("SELECT * FROM students WHERE id >= {}", i % 4);
                let info = client.execute(sql, None).await.unwrap();
                let batches = collect_batches(&mut client, info).await;
                let rows: usize = batches.iter().map(|b| b.num_rows()).sum();
                assert!(rows > 0);
            }));
        }

        for h in handles {
            h.await.unwrap();
        }
    }

    #[tokio::test]
    async fn test_multiple_tables() {
        let engine = SharedDataFusionEngine::new(DataFusionEngine::new());
        let olap = OlapBackend::DataFusion(engine.clone());

        // Create two tables
        let schema1 = Arc::new(Schema::new(vec![
            Field::new("id", DataType::Int64, false),
            Field::new("name", DataType::Utf8, false),
        ]));
        let schema2 = Arc::new(Schema::new(vec![
            Field::new("id", DataType::Int64, false),
            Field::new("value", DataType::Int64, false),
        ]));
        engine.create_table("users", &schema1, &[]).await.unwrap();
        engine.create_table("scores", &schema2, &[]).await.unwrap();

        let users_batch = RecordBatch::try_new(
            schema1,
            vec![
                Arc::new(arrow::array::Int64Array::from(vec![1])),
                Arc::new(arrow::array::StringArray::from(vec!["Alice"])),
            ],
        )
        .unwrap();
        engine.load_arrow("users", &[users_batch]).await.unwrap();

        let scores_batch = RecordBatch::try_new(
            schema2,
            vec![
                Arc::new(arrow::array::Int64Array::from(vec![1])),
                Arc::new(arrow::array::Int64Array::from(vec![100])),
            ],
        )
        .unwrap();
        engine.load_arrow("scores", &[scores_batch]).await.unwrap();

        let addr = start_server(olap).await;
        let mut client = connect(addr).await;

        // Join query
        let info = client
            .execute(
                "SELECT u.name, s.value FROM users u JOIN scores s ON u.id = s.id".into(),
                None,
            )
            .await
            .unwrap();
        let batches = collect_batches(&mut client, info).await;

        assert_eq!(batches[0].num_rows(), 1);
        let name = batches[0]
            .column(0)
            .as_any()
            .downcast_ref::<arrow::array::StringArray>()
            .unwrap();
        assert_eq!(name.value(0), "Alice");
    }
}

// ---------------------------------------------------------------------------
// DuckDB backend tests
// ---------------------------------------------------------------------------

#[cfg(feature = "duckdb-backend")]
mod duckdb_tests {
    use super::*;
    use rhei_olap::{DuckDbEngine, SharedDuckDbEngine};

    async fn setup() -> (SocketAddr, OlapBackend) {
        let engine = SharedDuckDbEngine::new(DuckDbEngine::in_memory().unwrap());
        let olap = OlapBackend::DuckDb(engine.clone());

        let schema = Arc::new(Schema::new(vec![
            Field::new("id", DataType::Int64, false),
            Field::new("name", DataType::Utf8, false),
            Field::new("score", DataType::Float64, true),
        ]));
        engine.create_table("students", &schema, &[]).await.unwrap();

        engine
            .execute("INSERT INTO students VALUES (1, 'Alice', 95.5)")
            .await
            .unwrap();
        engine
            .execute("INSERT INTO students VALUES (2, 'Bob', 87.3)")
            .await
            .unwrap();
        engine
            .execute("INSERT INTO students VALUES (3, 'Carol', 92.1)")
            .await
            .unwrap();

        let addr = start_server(olap.clone()).await;
        (addr, olap)
    }

    #[tokio::test]
    async fn test_simple_select() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        let info = client
            .execute("SELECT * FROM students".into(), None)
            .await
            .unwrap();
        let batches = collect_batches(&mut client, info).await;

        let total_rows: usize = batches.iter().map(|b| b.num_rows()).sum();
        assert_eq!(total_rows, 3);
    }

    #[tokio::test]
    async fn test_aggregate_query() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        let info = client
            .execute("SELECT SUM(score) as total FROM students".into(), None)
            .await
            .unwrap();
        let batches = collect_batches(&mut client, info).await;
        assert_eq!(batches[0].num_rows(), 1);
    }

    #[tokio::test]
    async fn test_prepared_statement() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        let mut stmt = client
            .prepare("SELECT name FROM students ORDER BY name".into(), None)
            .await
            .unwrap();
        let info = stmt.execute().await.unwrap();
        let batches = collect_batches(&mut client, info).await;

        let total_rows: usize = batches.iter().map(|b| b.num_rows()).sum();
        assert_eq!(total_rows, 3);
        stmt.close().await.unwrap();
    }

    #[tokio::test]
    async fn test_write_rejected() {
        let (addr, _) = setup().await;
        let mut client = connect(addr).await;

        let result = client
            .execute_update("DELETE FROM students WHERE id = 1".into(), None)
            .await;
        assert!(result.is_err());
    }
}

// ---------------------------------------------------------------------------
// Bearer-token authentication tests (DataFusion backend)
// ---------------------------------------------------------------------------

#[cfg(feature = "datafusion-backend")]
mod auth_tests {
    use super::*;
    use rhei_olap::{DataFusionEngine, SharedDataFusionEngine};

    /// Start a FlightSQL server that requires the given bearer token.
    async fn start_authed_server(token: &str) -> SocketAddr {
        let engine = SharedDataFusionEngine::new(DataFusionEngine::new());
        let olap = OlapBackend::DataFusion(engine.clone());

        // Seed a minimal table so queries have something to hit.
        let schema = Arc::new(Schema::new(vec![
            Field::new("id", DataType::Int64, false),
            Field::new("val", DataType::Int64, false),
        ]));
        engine.create_table("t", &schema, &[]).await.unwrap();
        let batch = RecordBatch::try_new(
            schema,
            vec![
                Arc::new(arrow::array::Int64Array::from(vec![1_i64])),
                Arc::new(arrow::array::Int64Array::from(vec![42_i64])),
            ],
        )
        .unwrap();
        engine.load_arrow("t", &[batch]).await.unwrap();

        let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
        let addr = listener.local_addr().unwrap();

        let service =
            rhei_flight::RheiFlightSqlService::new(olap).with_auth_token(token.to_string());
        let svc = arrow_flight::flight_service_server::FlightServiceServer::new(service);

        tokio::spawn(async move {
            tonic::transport::Server::builder()
                .add_service(svc)
                .serve_with_incoming(tokio_stream::wrappers::TcpListenerStream::new(listener))
                .await
                .unwrap();
        });

        tokio::time::sleep(Duration::from_millis(50)).await;
        addr
    }

    /// Build a client and pre-load it with the given bearer token.
    async fn connect_with_token(addr: SocketAddr, token: &str) -> FlightSqlServiceClient<Channel> {
        let mut client = connect(addr).await;
        client.set_token(token.to_string());
        client
    }

    // ------------------------------------------------------------------
    // Test: valid token — all operations succeed
    // ------------------------------------------------------------------

    #[tokio::test]
    async fn test_valid_token_allows_query() {
        let addr = start_authed_server("secret").await;
        let mut client = connect_with_token(addr, "secret").await;

        let info = client
            .execute("SELECT * FROM t".into(), None)
            .await
            .expect("query with valid token should succeed");
        let batches = collect_batches(&mut client, info).await;
        let rows: usize = batches.iter().map(|b| b.num_rows()).sum();
        assert_eq!(rows, 1);
    }

    // ------------------------------------------------------------------
    // Test: missing token — get_flight_info returns Unauthenticated
    // ------------------------------------------------------------------

    #[tokio::test]
    async fn test_missing_token_rejected() {
        let addr = start_authed_server("secret").await;
        // Connect without setting a token
        let mut client = connect(addr).await;

        let result = client.execute("SELECT * FROM t".into(), None).await;
        assert!(result.is_err(), "request without token should be rejected");
        let err = result.unwrap_err().to_string().to_lowercase();
        assert!(
            err.contains("unauthenticated") || err.contains("bearer"),
            "error should mention unauthenticated/bearer, got: {err}"
        );
    }

    // ------------------------------------------------------------------
    // Test: wrong token — get_flight_info returns Unauthenticated
    // ------------------------------------------------------------------

    #[tokio::test]
    async fn test_wrong_token_rejected() {
        let addr = start_authed_server("secret").await;
        let mut client = connect_with_token(addr, "wrong-token").await;

        let result = client.execute("SELECT * FROM t".into(), None).await;
        assert!(
            result.is_err(),
            "request with wrong token should be rejected"
        );
        let err = result.unwrap_err().to_string().to_lowercase();
        assert!(
            err.contains("unauthenticated") || err.contains("bearer"),
            "error should mention unauthenticated/bearer, got: {err}"
        );
    }

    // ------------------------------------------------------------------
    // Test: no-auth server still works (backward compat)
    // ------------------------------------------------------------------

    #[tokio::test]
    async fn test_no_auth_server_accepts_any_request() {
        // Reuse the unauthenticated start_server helper from the top-level module
        let engine = SharedDataFusionEngine::new(DataFusionEngine::new());
        let olap = OlapBackend::DataFusion(engine.clone());
        let schema = Arc::new(Schema::new(vec![Field::new("id", DataType::Int64, false)]));
        engine.create_table("empty", &schema, &[]).await.unwrap();

        let addr = start_server(olap).await;
        // Connect with no token
        let mut client = connect(addr).await;
        let info = client
            .execute("SELECT * FROM empty".into(), None)
            .await
            .expect("no-auth server should accept requests without a token");
        let batches = collect_batches(&mut client, info).await;
        let rows: usize = batches.iter().map(|b| b.num_rows()).sum();
        assert_eq!(rows, 0);
    }

    // ------------------------------------------------------------------
    // Test: do_get is also protected (token validated at each hop)
    // ------------------------------------------------------------------

    #[tokio::test]
    async fn test_do_get_also_protected() {
        let addr = start_authed_server("s3cr3t").await;

        // Step 1: get FlightInfo with the correct token — should succeed
        let mut auth_client = connect_with_token(addr, "s3cr3t").await;
        let info = auth_client
            .execute("SELECT * FROM t".into(), None)
            .await
            .expect("get_flight_info with correct token should succeed");

        // Step 2: attempt do_get with a client that has NO token
        let mut unauth_client = connect(addr).await;
        for endpoint in info.endpoint {
            if let Some(ticket) = endpoint.ticket {
                let result = unauth_client.do_get(ticket).await;
                assert!(result.is_err(), "do_get without token should be rejected");
            }
        }
    }
}

// ---------------------------------------------------------------------------
// OLAP Benchmark: Local vs FlightSQL
// ---------------------------------------------------------------------------
// Compares direct OLAP query performance with FlightSQL over the network.
// Gated behind RHEI_TEST_BENCH=1 to avoid slowing down regular test runs.

#[cfg(feature = "datafusion-backend")]
mod bench {
    use super::*;
    use rhei_olap::{DataFusionEngine, SharedDataFusionEngine};
    use std::time::Instant;

    /// Create a large test dataset: `orders` table with N rows.
    async fn setup_large(n: usize) -> (SocketAddr, OlapBackend) {
        let engine = SharedDataFusionEngine::new(DataFusionEngine::new());
        let olap = OlapBackend::DataFusion(engine.clone());

        let schema = Arc::new(Schema::new(vec![
            Field::new("id", DataType::Int64, false),
            Field::new("user_id", DataType::Int64, false),
            Field::new("amount", DataType::Float64, false),
            Field::new("category", DataType::Utf8, false),
            Field::new("region", DataType::Utf8, false),
        ]));
        engine.create_table("orders", &schema, &[]).await.unwrap();

        // Load in batches of 10,000
        let categories = ["electronics", "clothing", "food", "books", "sports"];
        let regions = ["north", "south", "east", "west"];
        let batch_size = 10_000.min(n);
        let mut loaded = 0;

        while loaded < n {
            let chunk = batch_size.min(n - loaded);
            let ids: Vec<i64> = (loaded..loaded + chunk).map(|i| i as i64).collect();
            let user_ids: Vec<i64> = ids.iter().map(|i| i % 1000).collect();
            let amounts: Vec<f64> = ids.iter().map(|i| (*i as f64) * 1.23 % 999.99).collect();
            let cats: Vec<&str> = ids.iter().map(|i| categories[*i as usize % 5]).collect();
            let regs: Vec<&str> = ids.iter().map(|i| regions[*i as usize % 4]).collect();

            let batch = RecordBatch::try_new(
                schema.clone(),
                vec![
                    Arc::new(arrow::array::Int64Array::from(ids)),
                    Arc::new(arrow::array::Int64Array::from(user_ids)),
                    Arc::new(arrow::array::Float64Array::from(amounts)),
                    Arc::new(arrow::array::StringArray::from(cats)),
                    Arc::new(arrow::array::StringArray::from(regs)),
                ],
            )
            .unwrap();
            engine.load_arrow("orders", &[batch]).await.unwrap();
            loaded += chunk;
        }

        let addr = start_server(olap.clone()).await;
        (addr, olap)
    }

    fn total_rows(batches: &[RecordBatch]) -> usize {
        batches.iter().map(|b| b.num_rows()).sum()
    }

    fn total_bytes(batches: &[RecordBatch]) -> usize {
        batches.iter().map(|b| b.get_array_memory_size()).sum()
    }

    /// Run a benchmark comparing local OLAP and FlightSQL for the same query.
    async fn bench_query(
        olap: &OlapBackend,
        client: &mut FlightSqlServiceClient<Channel>,
        sql: &str,
        label: &str,
        iterations: usize,
    ) {
        // Warmup
        let _ = olap.query(sql).await.unwrap();
        let info = client.execute(sql.to_string(), None).await.unwrap();
        let _ = collect_batches(client, info).await;

        // Local OLAP benchmark
        let start = Instant::now();
        let mut local_rows = 0;
        let mut local_bytes = 0;
        for _ in 0..iterations {
            let batches = olap.query(sql).await.unwrap();
            local_rows += total_rows(&batches);
            local_bytes += total_bytes(&batches);
        }
        let local_elapsed = start.elapsed();

        // FlightSQL benchmark
        let start = Instant::now();
        let mut flight_rows = 0;
        let mut flight_bytes = 0;
        for _ in 0..iterations {
            let info = client.execute(sql.to_string(), None).await.unwrap();
            let batches = collect_batches(client, info).await;
            flight_rows += total_rows(&batches);
            flight_bytes += total_bytes(&batches);
        }
        let flight_elapsed = start.elapsed();

        let local_qps = iterations as f64 / local_elapsed.as_secs_f64();
        let flight_qps = iterations as f64 / flight_elapsed.as_secs_f64();
        let local_mbps = local_bytes as f64 / local_elapsed.as_secs_f64() / 1_048_576.0;
        let flight_mbps = flight_bytes as f64 / flight_elapsed.as_secs_f64() / 1_048_576.0;
        let overhead = flight_elapsed.as_secs_f64() / local_elapsed.as_secs_f64();

        eprintln!("  {label}:");
        eprintln!(
            "    Local:  {local_qps:>8.0} q/s  {local_mbps:>8.1} MB/s  ({local_rows} rows in {:.1}ms)",
            local_elapsed.as_secs_f64() * 1000.0
        );
        eprintln!(
            "    Flight: {flight_qps:>8.0} q/s  {flight_mbps:>8.1} MB/s  ({flight_rows} rows in {:.1}ms)",
            flight_elapsed.as_secs_f64() * 1000.0
        );
        eprintln!("    Overhead: {overhead:.2}x");
    }

    #[tokio::test]
    async fn bench_olap_vs_flight() {
        if std::env::var("RHEI_TEST_BENCH").is_err() {
            eprintln!("skipping OLAP benchmark (set RHEI_TEST_BENCH=1 to run)");
            return;
        }

        let n = 100_000;
        eprintln!("\n=== OLAP Benchmark: Local vs FlightSQL ({n} rows) ===\n");

        let (addr, olap) = setup_large(n).await;
        let mut client = connect(addr).await;

        // 1. Full table scan — measures data transfer throughput
        bench_query(
            &olap,
            &mut client,
            "SELECT * FROM orders",
            "Full scan (100K rows, 5 cols)",
            10,
        )
        .await;

        // 2. Aggregate — small result, measures query overhead
        bench_query(
            &olap,
            &mut client,
            "SELECT category, COUNT(*) as cnt, AVG(amount) as avg_amt FROM orders GROUP BY category",
            "GROUP BY aggregate (5 result rows)",
            100,
        )
        .await;

        // 3. Filtered scan — moderate result set
        bench_query(
            &olap,
            &mut client,
            "SELECT * FROM orders WHERE region = 'north' AND amount > 500.0",
            "Filtered scan (~6K rows)",
            50,
        )
        .await;

        // 4. Top-N — ORDER BY + LIMIT
        bench_query(
            &olap,
            &mut client,
            "SELECT user_id, SUM(amount) as total FROM orders GROUP BY user_id ORDER BY total DESC LIMIT 10",
            "Top-10 users by spend",
            100,
        )
        .await;

        // 5. Window function — complex analytical query
        bench_query(
            &olap,
            &mut client,
            "SELECT category, region, SUM(amount) as total, \
             RANK() OVER (PARTITION BY category ORDER BY SUM(amount) DESC) as rank \
             FROM orders GROUP BY category, region",
            "Window function (rank by category)",
            50,
        )
        .await;

        eprintln!("\n=== Benchmark complete ===\n");
    }
}