1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
/// Top-level tickets per owning plan file. Only top-level tickets are
/// independently schedulable — a subtask always executes inside its ticket's
/// slot — so descendants never add to a file's count. §FS-rhei-run.2.5
fn ticket_file_counts(loaded: &LoadedPlan) -> BTreeMap<&Path, usize> {
let mut counts: BTreeMap<&Path, usize> = BTreeMap::new();
for task in &loaded.rhei.tasks {
if let Some(path) = loaded.task_sources.get(&task.id.to_string()) {
*counts.entry(path.as_path()).or_default() += 1;
}
}
counts
}
/// Every execution root a run locks: its own plus each rhei's, so project
/// and member-rhei runs contend on the same lock. Canonicalized and sorted —
/// one global acquisition order, no lock-order deadlock. §FS-rhei-run.2.6
fn run_lock_roots(loaded: &LoadedPlan, workspace_root: &Path) -> BTreeSet<PathBuf> {
// Dedup is what keeps this set safe to lock: `flock` on a second
// descriptor for an inode this process already holds blocks forever. A
// ticket root can arrive as the empty path — `parent()` of a bare
// relative filename — which canonicalizes to nothing and so slips past
// dedup as a second name for the run's own directory.
let canonical = |root: &Path| {
let root = if root.as_os_str().is_empty() { Path::new(".") } else { root };
root.canonicalize().unwrap_or_else(|_| root.to_path_buf())
};
let mut roots = BTreeSet::new();
roots.insert(canonical(workspace_root));
for root in loaded.task_roots.values() {
roots.insert(canonical(root));
}
roots
}
/// One run's identity: the id it is named by everywhere, and when it began.
/// Computed once, as soon as the run holds its locks, so the run report, the
/// descriptor, and `rhei attach <id>` all speak about the same run by the same
/// name — rather than each execution mode deriving its own. Stamping it before
/// the locks made `started_at` the time the command was typed, which is not
/// when a queued run began.
// §FS-rhei-run.2.7
struct RunIdentity {
id: String,
started: Instant,
started_wall: std::time::SystemTime,
/// Whether this process is the detached child of a `--headless` launch.
headless: bool,
}
impl RunIdentity {
fn new() -> Self {
let started_wall = std::time::SystemTime::now();
Self {
id: short_run_id(started_wall),
started: Instant::now(),
started_wall,
headless: is_headless_child(),
}
}
}
/// Take the run lock of every involved execution root.
///
/// A **detached child** must not wait: its launcher is holding a handshake
/// open, and a blocked child turns a lock refusal into a 30-second "did not
/// report itself ready" for a run that never had a chance. It fails fast with
/// the same diagnostic the launcher's own pre-check gives — which is what
/// catches the case a per-workspace launch lock cannot: two launches on
/// different member plans that share a root.
///
/// A **foreground** run keeps blocking, because waiting on a contended lock is
/// a queueing idiom people use on purpose. It says whose run it is waiting for
/// first: silent blocking is indistinguishable from a hang.
// §FS-rhei-run.2.6 §FS-rhei-run-headless.1.1
fn acquire_run_locks(
loaded: &LoadedPlan,
workspace_root: &Path,
opts: &RunOptions,
) -> MietteResult<Vec<HeldRunLock>> {
let mut locks = Vec::new();
for root in run_lock_roots(loaded, workspace_root) {
match try_acquire_run_lock(&root)? {
Some(lock) => locks.push(lock),
None if is_headless_child() => return Err(run_lock_conflict(&root)),
None => {
announce_run_lock_wait(&root, opts.json());
locks.push(wait_for_run_lock(&root)?);
}
}
}
Ok(locks)
}
/// How often a queued run re-tries the lock it is waiting for.
const RUN_LOCK_WAIT_POLL: Duration = Duration::from_millis(200);
/// Wait for a contended run lock the way the rest of the run waits: in slices
/// the interrupt handler can end.
///
/// A blocking `flock` is not one of them. The handler sets a flag and returns,
/// so a process parked inside `flock` goes straight back into the syscall and
/// the operator's Ctrl+C does nothing at all — which is what turned the wait
/// this run now announces into a wait it could not cancel. The queueing
/// behaviour is unchanged: it still blocks until the lock frees.
// §FS-rhei-run.2.6 §FS-rhei-run.3.2
fn wait_for_run_lock(root: &Path) -> MietteResult<HeldRunLock> {
loop {
if let Some(lock) = try_acquire_run_lock(root)? {
return Ok(lock);
}
if interrupt_requested() {
return Err(miette!(
help = "the run that holds it is untouched; `rhei runs` shows what is live",
"stopped waiting for the run lock on {}",
root.display()
));
}
interruptible_sleep(RUN_LOCK_WAIT_POLL);
}
}
/// One line naming the holder before a foreground run blocks on its lock.
// §FS-rhei-run.2.6 §FS-rhei-run-json.1
fn announce_run_lock_wait(root: &Path, json: bool) {
let holder = read_descriptor(&run_descriptor_path(root))
.filter(|run| !run.liveness().has_ended())
.map(|run| format!("run {} (pid {})", run.id, run.pid))
.unwrap_or_else(|| "another run".to_string());
let line = format!("Waiting for {holder} to release the run lock on {}...", root.display());
if json || stdout_carries_json_records() {
eprintln!("{line}");
} else {
println!("{line}");
}
}
/// Execute the `run` subcommand: advance tasks through the state machine
/// in dependency order.
///
/// In agent mode (the default when an agent is configured), spawns coding
/// agents for each task. In callback-only mode (`--no-agent`), advances
/// tasks through transition callbacks only.
fn run_command(
input: &Path,
state_machine_path: Option<&Path>,
opts: RunOptions,
) -> MietteResult<()> {
// `--headless` re-executes this same command in a detached session and
// returns its id; everything below then runs in the *child*. Checked first
// so a launch takes no locks and starts no frontend of its own.
// §FS-rhei-run-headless.1
if opts.headless() && !is_headless_child() {
return launch_headless_run(input, opts.json(), opts.announces_dashboard());
}
// From here on, a human-oriented line goes to stderr. §FS-rhei-run-json.1
if opts.json() {
reserve_stdout_for_json_records();
}
// Installed for every `run`, before anything can be spawned: from here on a
// SIGINT/SIGTERM/SIGHUP interrupts the run instead of killing the
// supervisor out from under its subprocesses. §FS-rhei-run.3.2
install_interrupt_handlers();
let input_buf = normalize_workspace_input(input);
let input = input_buf.as_path();
let loaded = load_plan(input)?;
let rhei_scope = resolve_rhei_scope(&loaded, opts.rhei_scope())?;
report_panta_scope_narrowed(&loaded, "run", &rhei_scope);
let resolved = resolve_state_machines_for_loaded_plan(input, &loaded, state_machine_path)?;
let machines =
ExecutionMachines::build(&resolved, input)?.with_state_machine_override(state_machine_path);
let callback_paths = machines.default_callbacks.clone();
let workspace_root = execution_workspace_root(&callback_paths.plan_path);
let settings = load_merged_settings(&workspace_root)?;
// §FS-rhei-run.2.6: one live run per rhei — lock every involved
// execution root, not just the run's own.
let _run_locks =
if opts.dry_run() { Vec::new() } else { acquire_run_locks(&loaded, &workspace_root, &opts)? };
// Stamped only now: a run that queued behind someone else's lock began
// when it got the lock, not when it was typed, and `rhei runs` orders by
// this. §FS-rhei-run.2.7
let identity = RunIdentity::new();
// §FS-rhei-run.3.1: detect subprocess commits that leave run-owned state dirty.
let git_consistency = RunGitConsistencyGuard::capture(&workspace_root, input, !opts.dry_run());
// §FS-rhei-run.2.5: when every ticket lives in one plan file, parallelism
// can only schedule same-file tickets against one checkout — fall back to
// sequential, as for a bare single-file plan.
let ticket_counts = ticket_file_counts(&loaded);
let shared_file =
ticket_counts.iter().find(|(_, count)| **count > 1).map(|(path, _)| (*path).to_path_buf());
let single_shared_file = ticket_counts.len() == 1 && shared_file.is_some();
let effective_parallel = if opts.parallel() > 1 && single_shared_file {
eprintln!(
"warning: --parallel > 1 is not supported when every ticket lives in one \
plan file (risk of conflicting edits). Falling back to sequential execution."
);
1
} else {
// A project keeps parallelism, but two tickets of one rhei file are
// still concurrent work against a single checkout — say so instead
// of silently dropping the single-file warning. §FS-rhei-run.2.5
if opts.parallel() > 1 {
if let Some(shared) = &shared_file {
eprintln!(
"warning: --parallel > 1 schedules tickets from the same rhei file \
concurrently ({}); plan-file writes serialize on the file lock, but \
agents may still collide in the shared checkout.",
shared.display()
);
}
}
opts.parallel()
};
// Initial validation pass.
let mut report = rhei_validator::validate_with_machine_set(&loaded.rhei, &machines.set);
for machine in machines.set.distinct() {
report.errors.extend(validate_machine_settings_references(machine, &settings));
}
report
.errors
.extend(validate_task_execution_override_settings_references(&loaded.rhei, &settings));
report.errors.extend(validate_snapshot_plan_context(&loaded, &resolved));
if report.has_errors() {
return Err(validation_report(
input,
resolved.default.path.as_deref(),
&report.errors,
&report.help,
));
}
// A machine that warns is legal, so the run proceeds — but the operator
// heard it only if they happened to validate first.
// §FS-rhei-validate.4 §FS-rhei-run.3
report.warnings.dedup();
for warning in &report.warnings {
eprintln!("warning: {warning}");
}
let use_standalone_mode =
should_use_agent_mode(&loaded.rhei, &machines.set, &settings, &opts, &workspace_root)?;
let result = if use_standalone_mode {
run_agent_mode(input, &machines, &settings, &opts, effective_parallel, &identity)
} else {
run_callback_mode(input, &machines, &opts, effective_parallel, &identity)
};
result?;
// An interrupted run made no claim of durable success, so the commit
// postcondition has nothing to check; a run torn down by its own failure
// still owes it. §FS-rhei-run.3.1 §FS-rhei-run.3.2
if interrupted_by_signal() {
return Ok(());
}
git_consistency.verify_after_success()
}
fn should_use_agent_mode(
rhei: &rhei_core::ast::Rhei,
machines: &rhei_validator::MachineSet,
settings: &RheiSettings,
opts: &RunOptions,
workspace_root: &Path,
) -> MietteResult<bool> {
if !opts.no_agent()
&& machines.distinct().iter().any(|machine| {
machine
.states
.values()
.any(|def| !def.terminal && !def.gating && state_declares_autonomous_agent_work(def))
})
{
return Ok(true);
}
for task in narrow_to_rhei_scope(
find_runnable_tasks(rhei, machines, workspace_root, &HashSet::new()),
&rhei_scope_set(opts.rhei_scope()),
) {
let machine = machines.for_task(&task.id);
let state_name = normalized_state_name(task.state.as_str(), machine);
let Some(def) = machine.states.get(&state_name) else {
continue;
};
if def.terminal || def.gating {
continue;
}
if def.program.is_some() && !opts.no_program() {
return Ok(true);
}
if !opts.no_agent() {
let invocations = resolve_agent_invocations_for_task(
machine,
&state_name,
settings,
opts,
Some(task),
)?;
if !invocations.is_empty() || state_declares_autonomous_agent_work(def) {
return Ok(true);
}
}
}
Ok(false)
}