rez-next-version 0.3.6

Ultra-fast version parsing and comparison with 117x performance improvement - core component of Rez-Next
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
//! Version implementation

use once_cell::sync::Lazy;
use regex::Regex;
use rez_next_common::RezCoreError;
use serde::{Deserialize, Serialize};
use std::cmp::Ordering;
use std::hash::{Hash, Hasher};

/// Pre-compiled regex for token extraction (compiled once, reused across all parse calls)
static TOKEN_REGEX: Lazy<Regex> = Lazy::new(|| Regex::new(r"[a-zA-Z0-9_]+").unwrap());

/// High-performance version representation compatible with rez
#[derive(Debug)]
pub struct Version {
    /// Version tokens
    tokens: Vec<String>,
    /// Separators between tokens
    separators: Vec<String>,
    /// Cached string representation
    pub string_repr: String,
    /// Cached hash value
    cached_hash: Option<u64>,
}

impl Serialize for Version {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: serde::Serializer,
    {
        // Serialize as string representation for simplicity
        self.string_repr.serialize(serializer)
    }
}

impl std::fmt::Display for Version {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "{}", self.as_str())
    }
}

impl<'de> Deserialize<'de> for Version {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: serde::Deserializer<'de>,
    {
        let s = String::deserialize(deserializer)?;
        Self::parse(&s).map_err(serde::de::Error::custom)
    }
}

impl Version {
    pub fn new(version_str: Option<&str>) -> Result<Self, RezCoreError> {
        let version_str = version_str.unwrap_or("");
        Self::parse(version_str)
    }

    pub fn as_str(&self) -> &str {
        &self.string_repr
    }

    /// Return whether this version begins with every token in `prefix`.
    pub fn has_prefix(&self, prefix: &Version) -> bool {
        self.tokens.len() >= prefix.tokens.len()
            && self
                .tokens
                .iter()
                .zip(&prefix.tokens)
                .all(|(token, prefix_token)| {
                    Self::compare_single_token(token, prefix_token) == Ordering::Equal
                })
    }
}

impl Version {
    /// Internal parsing function that runs without GIL
    /// Returns (tokens, separators) as pure Rust data
    fn parse_internal_gil_free(s: &str) -> Result<(Vec<String>, Vec<String>), RezCoreError> {
        // Validate version format - reject obvious invalid patterns
        if s.starts_with('v') || s.starts_with('V') {
            return Err(RezCoreError::VersionParse(format!(
                "Version prefixes not supported: '{s}'"
            )));
        }

        // Check for invalid characters or patterns
        if s.contains("..") || s.starts_with('.') || s.ends_with('.') {
            return Err(RezCoreError::VersionParse(format!(
                "Invalid version syntax: '{s}'"
            )));
        }

        // Use pre-compiled regex to find tokens (alphanumeric + underscore)
        let tokens: Vec<&str> = TOKEN_REGEX.find_iter(s).map(|m| m.as_str()).collect();

        if tokens.is_empty() {
            return Err(RezCoreError::VersionParse(format!(
                "Invalid version syntax: '{s}'"
            )));
        }

        // Check for too many numeric-only tokens (reject versions like 1.2.3.4.5.6)
        let numeric_tokens: Vec<_> = tokens
            .iter()
            .filter(|t| t.chars().all(|c| c.is_ascii_digit()))
            .collect();
        if numeric_tokens.len() > 5 {
            return Err(RezCoreError::VersionParse(format!(
                "Version too complex: '{s}'"
            )));
        }

        // Check for too many tokens overall
        if tokens.len() > 10 {
            return Err(RezCoreError::VersionParse(format!(
                "Version too complex: '{s}'"
            )));
        }

        // Extract separators
        let separators: Vec<&str> = TOKEN_REGEX.split(s).collect();

        // Validate separators (should be empty at start/end, single char in middle)
        if !separators[0].is_empty() || !separators[separators.len() - 1].is_empty() {
            return Err(RezCoreError::VersionParse(format!(
                "Invalid version syntax: '{s}'"
            )));
        }

        for sep in &separators[1..separators.len() - 1] {
            if sep.len() > 1 {
                return Err(RezCoreError::VersionParse(format!(
                    "Invalid version syntax: '{s}'"
                )));
            }
            // Only allow specific separators
            if !matches!(*sep, "." | "-" | "_" | "+") {
                return Err(RezCoreError::VersionParse(format!(
                    "Invalid separator '{sep}' in version: '{s}'"
                )));
            }
        }

        // Validate tokens before creating them
        for token_str in &tokens {
            // Check if token contains only valid characters
            if !token_str.chars().all(|c| c.is_alphanumeric() || c == '_') {
                return Err(RezCoreError::VersionParse(format!(
                    "Invalid characters in token: '{token_str}'"
                )));
            }

            // Check for invalid patterns
            if token_str.starts_with('_') || token_str.ends_with('_') {
                return Err(RezCoreError::VersionParse(format!(
                    "Invalid token format: '{token_str}'"
                )));
            }

            // Reject tokens that are purely alphabetic and don't look like version components
            if token_str.chars().all(|c| c.is_alphabetic()) && token_str.len() > 10 {
                return Err(RezCoreError::VersionParse(format!(
                    "Invalid version token: '{token_str}'"
                )));
            }

            // Reject common invalid patterns
            if *token_str == "not" || *token_str == "version" {
                return Err(RezCoreError::VersionParse(format!(
                    "Invalid version token: '{token_str}'"
                )));
            }
        }

        // Convert to owned strings
        let token_strings: Vec<String> = tokens.into_iter().map(ToString::to_string).collect();
        let sep_strings: Vec<String> = separators[1..separators.len() - 1]
            .iter()
            .map(ToString::to_string)
            .collect();

        Ok((token_strings, sep_strings))
    }

    /// Create the infinite version (largest possible version)
    #[must_use]
    pub fn inf() -> Self {
        Self {
            tokens: vec![],
            separators: vec![],
            string_repr: "inf".to_string(),
            cached_hash: None,
        }
    }

    /// Check if this is the infinite version
    #[must_use]
    pub fn is_inf(&self) -> bool {
        self.string_repr == "inf"
    }

    /// Create an empty version (smallest possible version)
    #[must_use]
    pub fn empty() -> Self {
        Self {
            tokens: vec![],
            separators: vec![],
            string_repr: String::new(),
            cached_hash: None,
        }
    }

    /// Create the epsilon version (alias for empty, smallest possible version)
    #[must_use]
    pub fn epsilon() -> Self {
        Self::empty()
    }

    /// Check if this is an empty version
    pub fn is_empty(&self) -> bool {
        self.tokens.is_empty() && self.string_repr.is_empty()
    }

    /// Number of version tokens (components)
    pub fn len(&self) -> usize {
        self.tokens.len()
    }

    /// Get the major version component (first token as u64), if available
    pub fn major(&self) -> Option<u64> {
        self.tokens.first().and_then(|t| t.parse::<u64>().ok())
    }

    /// Get the minor version component (second token as u64), if available
    pub fn minor(&self) -> Option<u64> {
        self.tokens.get(1).and_then(|t| t.parse::<u64>().ok())
    }

    /// Get the patch version component (third token as u64), if available
    pub fn patch(&self) -> Option<u64> {
        self.tokens.get(2).and_then(|t| t.parse::<u64>().ok())
    }

    /// Check if this is the epsilon version (alias for is_empty)
    pub fn is_epsilon(&self) -> bool {
        self.is_empty()
    }

    /// Check if this version is a prerelease version
    pub fn is_prerelease(&self) -> bool {
        if self.is_empty() || self.is_inf() {
            return false;
        }

        // Check if any token contains alphabetic characters that indicate prerelease
        for token in &self.tokens {
            let s_lower = token.to_lowercase();
            // Common prerelease indicators
            if s_lower.contains("alpha")
                || s_lower.contains("beta")
                || s_lower.contains("rc")
                || s_lower.contains("dev")
                || s_lower.contains("pre")
                || s_lower.contains("snapshot")
            {
                return true;
            }
        }
        false
    }

    /// Parse a version string into a Version object
    pub fn parse(s: &str) -> Result<Self, RezCoreError> {
        let s = s.trim();

        // Handle empty version (epsilon version)
        if s.is_empty() {
            return Ok(Self::empty());
        }

        // Handle infinite version
        if s == "inf" {
            return Ok(Self::inf());
        }

        // Handle epsilon version explicitly
        if s == "epsilon" {
            return Ok(Self::epsilon());
        }

        // Parse using the GIL-free method
        let (tokens, separators) = Self::parse_internal_gil_free(s)?;

        Ok(Self {
            tokens,
            separators,
            string_repr: s.to_string(),
            cached_hash: None,
        })
    }

    /// Compare two versions using rez-compatible rules
    fn compare_rez(&self, other: &Self) -> Ordering {
        // Handle infinite versions (inf is largest)
        match (self.is_inf(), other.is_inf()) {
            (true, true) => return Ordering::Equal,
            (true, false) => return Ordering::Greater,
            (false, true) => return Ordering::Less,
            (false, false) => {} // Continue with normal comparison
        }

        // Handle empty/epsilon versions (epsilon version is smallest)
        match (self.is_empty(), other.is_empty()) {
            (true, true) => return Ordering::Equal,
            (true, false) => return Ordering::Less,
            (false, true) => return Ordering::Greater,
            (false, false) => {} // Continue with normal comparison
        }

        // Compare tokens using string comparison for now
        Self::compare_token_strings(&self.tokens, &other.tokens)
    }

    /// Compare a single token, handling mixed alphanumeric strings.
    ///
    /// Rez token comparison rules:
    /// 1. Both numeric: numeric integer comparison.
    /// 2. Both alpha: lexicographic comparison.
    /// 3. Mixed (alpha vs numeric segment): **alpha < numeric** — alphabetic segments
    ///    sort *before* numeric ones, matching rez semantics where `1.0.alpha < 1.0.0`.
    /// 4. Mixed alphanumeric tokens (e.g. "alpha10"): split into alternating segments and
    ///    apply rules 1–3 per segment pair.
    fn compare_single_token(t1: &str, t2: &str) -> Ordering {
        // Fast path: both purely numeric
        if let (Ok(n1), Ok(n2)) = (t1.parse::<i64>(), t2.parse::<i64>()) {
            return n1.cmp(&n2);
        }
        // Fast path: equal strings
        if t1 == t2 {
            return Ordering::Equal;
        }

        // Fast path: purely alpha vs purely numeric → alpha is Less (rez spec)
        let t1_all_alpha = t1.chars().all(|c| c.is_alphabetic() || c == '_');
        let t2_all_alpha = t2.chars().all(|c| c.is_alphabetic() || c == '_');
        let t1_all_num = t1.chars().all(|c| c.is_ascii_digit());
        let t2_all_num = t2.chars().all(|c| c.is_ascii_digit());
        if t1_all_alpha && t2_all_num {
            return Ordering::Less;
        }
        if t1_all_num && t2_all_alpha {
            return Ordering::Greater;
        }
        // Both purely alpha: lexicographic
        if t1_all_alpha && t2_all_alpha {
            return t1.cmp(t2);
        }

        // Mixed alphanumeric tokens: split into segments and compare segment-by-segment.
        // Within a segment pair: alpha segment < numeric segment (rez spec).
        let seg1 = Self::split_token_segments(t1);
        let seg2 = Self::split_token_segments(t2);

        for (s1, s2) in seg1.iter().zip(seg2.iter()) {
            let s1_is_num = s1.parse::<u64>().is_ok();
            let s2_is_num = s2.parse::<u64>().is_ok();
            let cmp = match (s1_is_num, s2_is_num) {
                (true, true) => {
                    let n1: u64 = s1.parse().unwrap();
                    let n2: u64 = s2.parse().unwrap();
                    n1.cmp(&n2)
                }
                (false, false) => s1.as_str().cmp(s2.as_str()),
                (false, true) => Ordering::Less, // alpha segment < numeric segment
                (true, false) => Ordering::Greater, // numeric segment > alpha segment
            };
            if cmp != Ordering::Equal {
                return cmp;
            }
        }
        seg1.len().cmp(&seg2.len())
    }

    /// Split a token into alternating alpha/numeric segments.
    /// E.g. "alpha10" → ["alpha", "10"], "rc2" → ["rc", "2"]
    fn split_token_segments(s: &str) -> Vec<String> {
        let mut segments = Vec::new();
        let mut current = String::new();
        let mut in_digits = false;

        for ch in s.chars() {
            let is_digit = ch.is_ascii_digit();
            if current.is_empty() {
                in_digits = is_digit;
                current.push(ch);
            } else if is_digit == in_digits {
                current.push(ch);
            } else {
                segments.push(current.clone());
                current.clear();
                in_digits = is_digit;
                current.push(ch);
            }
        }
        if !current.is_empty() {
            segments.push(current);
        }
        segments
    }

    /// Compare token arrays using rez-compatible rules.
    /// In rez, trailing zeros are implicit: 1.0 == 1.0.0 == 1.0.0.0
    /// Rez epoch semantics: shorter version = higher epoch
    /// - If extra tokens are all zeros → equal (trailing zeros implicit)
    /// - If extra tokens start with non-zero numeric → shorter is greater (higher epoch)
    /// - If extra tokens start with alpha → shorter is LESS (pre-release, so longer is greater)
    fn compare_token_strings(tokens1: &[String], tokens2: &[String]) -> Ordering {
        for (t1, t2) in tokens1.iter().zip(tokens2.iter()) {
            let cmp = Self::compare_single_token(t1, t2);
            if cmp != Ordering::Equal {
                return cmp;
            }
        }

        // If all compared tokens are equal, check extra tokens
        // Rez semantics: trailing zeros are implicit
        // - 2 == 2.0.0 (extra tokens are all "0")
        // - 1.0.1 > 1.0 (shorter has implicit Z+ which is > any digit)
        // - 1.0 > 1.0.alpha (release > pre-release)
        if tokens1.len() < tokens2.len() {
            // tokens1 is shorter, tokens2 has extra tokens
            let extra_tokens = &tokens2[tokens1.len()..];
            if extra_tokens.iter().all(|t| t == "0") {
                // Trailing zeros implicit → equal
                Ordering::Equal
            } else {
                // Check first extra token
                let first_extra = &tokens2[tokens1.len()];
                if first_extra.chars().all(|c| c.is_ascii_digit()) {
                    // Extra token is numeric and non-zero
                    // Shorter has implicit Z+ which is > any digit
                    Ordering::Greater
                } else {
                    // Extra token is alpha → tokens2 is pre-release
                    // Release (tokens1) > pre-release (tokens2)
                    Ordering::Greater
                }
            }
        } else if tokens2.len() < tokens1.len() {
            // tokens2 is shorter, tokens1 has extra tokens
            let extra_tokens = &tokens1[tokens2.len()..];
            if extra_tokens.iter().all(|t| t == "0") {
                // Trailing zeros implicit → equal
                Ordering::Equal
            } else {
                // Check first extra token
                let first_extra = &tokens1[tokens2.len()];
                if first_extra.chars().all(|c| c.is_ascii_digit()) {
                    // Extra token is numeric and non-zero
                    // tokens2 has implicit Z+ which is > any digit
                    // So tokens2 > tokens1, meaning tokens1 < tokens2
                    Ordering::Less
                } else {
                    // Extra token is alpha → tokens1 is pre-release
                    // tokens2 is release, Release > pre-release
                    // So tokens2 > tokens1, meaning tokens1 < tokens2
                    Ordering::Less
                }
            }
        } else {
            Ordering::Equal
        }
    }
}

impl PartialEq for Version {
    fn eq(&self, other: &Self) -> bool {
        self.compare_rez(other) == Ordering::Equal
    }
}

impl Eq for Version {}

impl Ord for Version {
    fn cmp(&self, other: &Self) -> Ordering {
        self.compare_rez(other)
    }
}

impl PartialOrd for Version {
    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
        Some(self.cmp(other))
    }
}

impl Hash for Version {
    fn hash<H: Hasher>(&self, state: &mut H) {
        self.string_repr.hash(state);
    }
}

impl Clone for Version {
    fn clone(&self) -> Self {
        Self {
            tokens: self.tokens.clone(),
            separators: self.separators.clone(),
            string_repr: self.string_repr.clone(),
            cached_hash: self.cached_hash,
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    fn ver(s: &str) -> Version {
        Version::parse(s).unwrap()
    }

    #[test]
    fn test_version_creation() {
        let version = Version::parse("1.2.3").unwrap();
        assert_eq!(version.as_str(), "1.2.3");
        assert_eq!(version.tokens.len(), 3);
        assert!(!version.is_empty());
    }

    #[test]
    fn test_empty_version() {
        let version = Version::parse("").unwrap();
        assert_eq!(version.as_str(), "");
        assert_eq!(version.tokens.len(), 0);
        assert!(version.is_empty());
    }

    #[test]
    fn test_version_inf() {
        let version = Version::inf();
        assert_eq!(version.as_str(), "inf");
        assert!(version.is_inf());
    }

    #[test]
    fn test_version_epsilon() {
        let version = Version::epsilon();
        assert_eq!(version.as_str(), "");
        assert!(version.is_epsilon());
        assert!(version.is_empty());
    }

    #[test]
    fn test_version_empty() {
        let version = Version::empty();
        assert_eq!(version.as_str(), "");
        assert!(version.is_empty());
        assert!(version.is_epsilon());
    }

    #[test]
    fn test_version_parsing_special() {
        // Test parsing empty version
        let empty = Version::parse("").unwrap();
        assert!(empty.is_empty());

        // Test parsing inf version
        let inf = Version::parse("inf").unwrap();
        assert!(inf.is_inf());

        // Test parsing epsilon version
        let epsilon = Version::parse("epsilon").unwrap();
        assert!(epsilon.is_epsilon());
    }

    #[test]
    fn test_version_comparison_boundaries() {
        let empty = Version::empty();
        let epsilon = Version::epsilon();
        let normal = Version::parse("1.0.0").unwrap();
        let inf = Version::inf();

        // Test epsilon/empty equivalence
        assert_eq!(empty.cmp(&epsilon), Ordering::Equal);

        // Test ordering: epsilon < normal < inf
        assert_eq!(epsilon.cmp(&normal), Ordering::Less);
        assert_eq!(normal.cmp(&inf), Ordering::Less);
        assert_eq!(epsilon.cmp(&inf), Ordering::Less);

        // Test reverse ordering
        assert_eq!(inf.cmp(&normal), Ordering::Greater);
        assert_eq!(normal.cmp(&epsilon), Ordering::Greater);
        assert_eq!(inf.cmp(&epsilon), Ordering::Greater);
    }

    #[test]
    fn test_version_prerelease_comparison() {
        // Test that release versions are greater than pre-release versions
        let release = Version::parse("2").unwrap();
        let prerelease = Version::parse("2.alpha1").unwrap();

        // "2" should be greater than "2.alpha1"
        assert_eq!(release.cmp(&prerelease), Ordering::Greater);
        assert_eq!(prerelease.cmp(&release), Ordering::Less);

        // Test with comparison operators
        assert!(release >= prerelease); // "2" < "2.alpha1" should be false
        assert!(prerelease < release); // "2.alpha1" < "2" should be true
    }

    #[test]
    fn test_version_copy() {
        let version = Version::parse("1.2.3").unwrap();
        let copied = version.clone();
        assert_eq!(version.as_str(), copied.as_str());
        assert_eq!(version.tokens.len(), copied.tokens.len());
    }

    #[test]
    fn test_version_ord_basic() {
        let v1 = ver("1.0.0");
        let v2 = ver("1.0.0");
        assert!(v1 >= v2, "1.0.0 >= 1.0.0 should be true");
        assert!(v1 <= v2, "1.0.0 <= 1.0.0 should be true");
    }

    #[test]
    fn test_version_ord_greater() {
        let v1 = ver("2.0.0");
        let v2 = ver("1.0.0");
        assert!(v1 > v2, "2.0.0 > 1.0.0 should be true");
        assert!(v2 < v1, "1.0.0 < 2.0.0 should be true");
    }

    #[test]
    fn test_range_contains_ge() {
        // Test if VersionRange::contains() bug is fixed
        let range = crate::VersionRange::parse(">=1.0.0").unwrap();
        assert!(
            range.contains(&ver("1.0.0")),
            ">=1.0.0 should contain 1.0.0"
        );
    }

    #[test]
    fn test_version_trim() {
        let version = Version::parse("1.2.3.4").unwrap();
        // Create a trimmed version by taking only first 2 tokens
        let mut trimmed_tokens = version.tokens.clone();
        trimmed_tokens.truncate(2);
        assert_eq!(trimmed_tokens.len(), 2);
    }

    // ─── Pre-release token ordering chain tests (Cycle 29) ──────────────

    #[test]
    fn test_prerelease_alpha_beta_rc_ordering() {
        // Standard prerelease ordering: alpha < beta < rc < release
        let alpha = Version::parse("1.0.alpha").unwrap();
        let beta = Version::parse("1.0.beta").unwrap();
        let rc = Version::parse("1.0.rc").unwrap();
        let release = Version::parse("1.0").unwrap();

        assert!(alpha < beta, "alpha should be less than beta");
        assert!(beta < rc, "beta should be less than rc");
        assert!(rc < release, "rc should be less than release");
        assert!(alpha < release, "alpha should be less than release");
    }

    #[test]
    fn test_prerelease_alpha_numbered_variants() {
        // Numbered alpha variants: alpha1 < alpha2 < alpha10
        let a1 = Version::parse("1.0.alpha1").unwrap();
        let a2 = Version::parse("1.0.alpha2").unwrap();
        let a10 = Version::parse("1.0.alpha10").unwrap();

        assert!(a1 < a2, "alpha1 < alpha2");
        assert!(a2 < a10, "alpha2 < alpha10 (numeric comparison)");
    }

    #[test]
    fn test_prerelease_dev_pre_snapshot_ordering() {
        // In rez, token comparison is lexicographic for alphabetic tokens.
        // "dev" (d...) > "alpha" (a...) by dictionary order.
        // The key property is that all these sort BELOW the base release (shorter token list).
        let dev = Version::parse("1.0.dev").unwrap();
        let alpha = Version::parse("1.0.alpha").unwrap();
        let pre = Version::parse("1.0.pre").unwrap();
        let snapshot = Version::parse("1.0.snapshot").unwrap();
        let release = Version::parse("1.0").unwrap();

        // All prerelease variants are less than the base release (shorter = greater in rez)
        assert!(dev < release, "1.0.dev < 1.0");
        assert!(alpha < release, "1.0.alpha < 1.0");
        assert!(pre < release, "1.0.pre < 1.0");
        assert!(snapshot < release, "1.0.snapshot < 1.0");

        // Lexicographic order among prerelease labels
        assert!(alpha < dev, "alpha < dev (a < d)");
        assert!(dev < pre, "dev < pre (d < p)");
        assert!(pre < snapshot, "pre < snapshot (p < s)");

        // is_prerelease detection
        assert!(dev.is_prerelease(), "dev is detected as prerelease");
        assert!(pre.is_prerelease(), "pre is detected as prerelease");
        assert!(
            snapshot.is_prerelease(),
            "snapshot is detected as prerelease"
        );
    }

    #[test]
    fn test_prerelease_mixed_with_numeric_tokens() {
        // Versions like 2.0.0-alpha vs 2.0.0-beta
        let v_alpha = Version::parse("2.0.0-alpha").unwrap();
        let v_beta = Version::parse("2.0.0-beta").unwrap();
        let v_stable = Version::parse("2.0.0").unwrap();

        assert!(v_alpha < v_beta, "2.0.0-alpha < 2.0.0-beta");
        assert!(v_beta < v_stable, "2.0.0-beta < 2.0.0");
        assert!(v_alpha.is_prerelease());
        assert!(v_beta.is_prerelease());
        assert!(!v_stable.is_prerelease());
    }

    #[test]
    fn test_prerelease_rc_vs_stable_same_prefix() {
        // RC versions sort below their corresponding release
        let rc1 = Version::parse("3.0.rc1").unwrap();
        let stable = Version::parse("3.0").unwrap();
        let rc2 = Version::parse("3.0.rc2").unwrap();

        assert!(rc1 < stable, "rc1 < stable 3.0");
        assert!(rc2 < stable, "rc2 < stable 3.0");
        assert!(rc1 < rc2, "rc1 < rc2");
    }

    #[test]
    fn test_prerelease_is_prerelease_detection() {
        // Verify all known prerelease markers are detected
        assert!(Version::parse("1.alpha").unwrap().is_prerelease());
        assert!(Version::parse("1.beta").unwrap().is_prerelease());
        assert!(Version::parse("1.rc").unwrap().is_prerelease());
        assert!(Version::parse("1.dev").unwrap().is_prerelease());
        assert!(Version::parse("1.pre").unwrap().is_prerelease());
        assert!(Version::parse("1.snapshot").unwrap().is_prerelease());

        // Non-prerelease versions
        assert!(!Version::parse("1.0").unwrap().is_prerelease());
        assert!(!Version::parse("1.0.0").unwrap().is_prerelease());
        assert!(!Version::parse("2024.5").unwrap().is_prerelease());

        // Edge cases: empty/inf are not prerelease
        assert!(!Version::empty().is_prerelease());
        assert!(!Version::inf().is_prerelease());
    }

    // ─── Edge Case Tests (Cycle 190) ─────────────────────────────

    #[test]
    fn test_version_very_large_numbers() {
        // Test parsing version with large numbers
        let v1 = Version::parse("999999999.1").unwrap();
        assert_eq!(v1.as_str(), "999999999.1");

        let v2 = Version::parse("1.999999999").unwrap();
        assert_eq!(v2.as_str(), "1.999999999");

        // Compare large numbers
        let v_small = Version::parse("1.0").unwrap();
        assert!(v_small < v1);
    }

    #[test]
    fn test_version_borderline_token_count() {
        // 10 tokens should pass (boundary) - use non-numeric to avoid numeric token limit
        let v10 = Version::parse("a.b.c.d.e.f.g.h.i.j").unwrap();
        assert_eq!(v10.tokens.len(), 10);

        // 11 tokens should fail
        let v11_result = Version::parse("a.b.c.d.e.f.g.h.i.j.k");
        assert!(v11_result.is_err(), "Version with 11 tokens should fail");
    }

    #[test]
    fn test_version_borderline_numeric_token_count() {
        // 5 numeric tokens should pass (boundary)
        let v5 = Version::parse("1.2.3.4.5").unwrap();
        assert_eq!(v5.as_str(), "1.2.3.4.5");

        // 6 numeric tokens should fail
        let v6_result = Version::parse("1.2.3.4.5.6");
        assert!(
            v6_result.is_err(),
            "Version with 6 numeric tokens should fail"
        );
    }

    #[test]
    fn test_version_underscore_in_tokens() {
        // Test underscores in tokens (valid per regex [a-zA-Z0-9_]+)
        let v = Version::parse("1_0.2_0").unwrap();
        assert_eq!(v.as_str(), "1_0.2_0");
        assert_eq!(v.tokens.len(), 2);
    }

    #[test]
    fn test_version_single_token() {
        // Single token version
        let v = Version::parse("123").unwrap();
        assert_eq!(v.as_str(), "123");
        assert_eq!(v.tokens.len(), 1);
    }

    #[test]
    fn test_version_hash_consistency() {
        // Same version string should produce same hash
        let v1 = Version::parse("1.2.3").unwrap();
        let v2 = Version::parse("1.2.3").unwrap();

        let mut hasher1 = std::collections::hash_map::DefaultHasher::new();
        let mut hasher2 = std::collections::hash_map::DefaultHasher::new();
        v1.hash(&mut hasher1);
        v2.hash(&mut hasher2);

        assert_eq!(hasher1.finish(), hasher2.finish());
    }

    #[test]
    fn test_version_equality_different_instances() {
        // Different instances with same version string should be equal
        let v1 = Version::parse("1.0").unwrap();
        let v2 = Version::parse("1.0").unwrap();
        assert_eq!(v1, v2);
    }

    #[test]
    fn test_version_ordering_transitivity() {
        // If a < b and b < c, then a < c
        let a = Version::parse("1.0").unwrap();
        let b = Version::parse("2.0").unwrap();
        let c = Version::parse("3.0").unwrap();

        assert!(a < b);
        assert!(b < c);
        assert!(a < c);
    }

    #[test]
    fn test_version_invalid_prefix() {
        // Versions starting with 'v' or 'V' should fail
        assert!(Version::parse("v1.0").is_err());
        assert!(Version::parse("V1.0").is_err());
    }

    #[test]
    fn test_version_invalid_syntax() {
        // Versions with ".." should fail
        assert!(Version::parse("1..2").is_err());

        // Versions starting/ending with '.' should fail
        assert!(Version::parse(".1.2").is_err());
        assert!(Version::parse("1.2.").is_err());
    }

    #[test]
    fn test_version_no_tokens() {
        // String with no valid tokens should fail
        assert!(Version::parse("...").is_err());
        assert!(Version::parse("---").is_err());
    }

    #[test]
    fn test_version_alphanumeric_mixed() {
        // Mixed alphanumeric tokens
        let v = Version::parse("1a.2b.3c").unwrap();
        assert_eq!(v.as_str(), "1a.2b.3c");
        assert_eq!(v.tokens.len(), 3);
    }
}