rez-next-solver 0.3.0

Intelligent dependency resolution with A* heuristic algorithms and 3-5x performance improvement
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
//! Dependency graph implementation

use rez_next_common::RezCoreError;
use rez_next_package::{Package, PackageRequirement};
use rez_next_version::Version;
use serde::{Deserialize, Serialize};
use std::collections::{HashMap, HashSet, VecDeque};

/// Dependency graph node
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct GraphNode {
    /// Package information
    pub package: Package,
    /// Direct dependencies (package names)
    pub dependencies: HashSet<String>,
    /// Packages that depend on this one
    pub dependents: HashSet<String>,
    /// Node metadata
    pub metadata: HashMap<String, String>,
}

impl GraphNode {
    /// Create a new graph node
    pub fn new(package: Package) -> Self {
        Self {
            package,
            dependencies: HashSet::new(),
            dependents: HashSet::new(),
            metadata: HashMap::new(),
        }
    }

    /// Get the package key (name-version)
    pub fn key(&self) -> String {
        match &self.package.version {
            Some(version) => format!("{}-{}", self.package.name, version.as_str()),
            None => self.package.name.clone(),
        }
    }

    /// Add a dependency
    pub fn add_dependency(&mut self, dependency_key: String) {
        self.dependencies.insert(dependency_key);
    }

    /// Add a dependent
    pub fn add_dependent(&mut self, dependent_key: String) {
        self.dependents.insert(dependent_key);
    }

    /// Remove a dependency
    pub fn remove_dependency(&mut self, dependency_key: &str) {
        self.dependencies.remove(dependency_key);
    }

    /// Remove a dependent
    pub fn remove_dependent(&mut self, dependent_key: &str) {
        self.dependents.remove(dependent_key);
    }
}

/// Dependency conflict information
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct DependencyConflict {
    /// Package name that has conflicting requirements
    pub package_name: String,
    /// Conflicting requirements
    pub conflicting_requirements: Vec<PackageRequirement>,
    /// Packages that introduced these requirements
    pub source_packages: Vec<String>,
    /// Conflict severity
    pub severity: ConflictSeverity,
}

/// Conflict severity levels
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, PartialOrd)]
pub enum ConflictSeverity {
    /// Minor version conflict
    Minor,
    /// Major version conflict
    Major,
    /// Incompatible requirements
    Incompatible,
}

/// Conflict resolution
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ConflictResolution {
    /// Package name being resolved
    pub package_name: String,
    /// Selected package version
    pub selected_version: Option<Version>,
    /// Resolution strategy used
    pub strategy: String,
    /// Packages that were modified/removed
    pub modified_packages: Vec<String>,
}

/// High-performance dependency graph
#[derive(Debug, Clone)]
pub struct DependencyGraph {
    /// Graph nodes indexed by package key
    nodes: HashMap<String, GraphNode>,
    /// Requirements indexed by package name
    requirements: HashMap<String, Vec<PackageRequirement>>,
    /// Constraints that must be satisfied
    constraints: Vec<PackageRequirement>,
    /// Packages to exclude
    exclusions: HashSet<String>,
    /// Graph metadata
    metadata: HashMap<String, String>,
}

impl DependencyGraph {
    /// Create a new dependency graph
    pub fn new() -> Self {
        Self {
            nodes: HashMap::new(),
            requirements: HashMap::new(),
            constraints: Vec::new(),
            exclusions: HashSet::new(),
            metadata: HashMap::new(),
        }
    }

    /// Clear the graph
    pub fn clear(&mut self) {
        self.nodes.clear();
        self.requirements.clear();
        self.constraints.clear();
        self.exclusions.clear();
        self.metadata.clear();
    }

    /// Add a package to the graph
    pub fn add_package(&mut self, package: Package) -> Result<(), RezCoreError> {
        let key = match &package.version {
            Some(version) => format!("{}-{}", package.name, version.as_str()),
            None => package.name.clone(),
        };

        // Check if package is excluded
        if self.exclusions.contains(&package.name) {
            return Err(RezCoreError::Solver(format!(
                "Package {} is excluded",
                package.name
            )));
        }

        let node = GraphNode::new(package);
        self.nodes.insert(key, node);

        Ok(())
    }

    /// Add a requirement to the graph
    pub fn add_requirement(&mut self, requirement: PackageRequirement) -> Result<(), RezCoreError> {
        self.requirements
            .entry(requirement.name.clone())
            .or_default()
            .push(requirement);

        Ok(())
    }

    /// Add a constraint
    pub fn add_constraint(&mut self, constraint: PackageRequirement) -> Result<(), RezCoreError> {
        self.constraints.push(constraint);
        Ok(())
    }

    /// Add an exclusion
    pub fn add_exclusion(&mut self, package_name: String) -> Result<(), RezCoreError> {
        self.exclusions.insert(package_name);
        Ok(())
    }

    /// Add a dependency edge between two packages
    pub fn add_dependency_edge(
        &mut self,
        from_key: &str,
        to_key: &str,
    ) -> Result<(), RezCoreError> {
        // Add dependency to the from node
        if let Some(from_node) = self.nodes.get_mut(from_key) {
            from_node.add_dependency(to_key.to_string());
        } else {
            return Err(RezCoreError::Solver(format!(
                "Package {} not found in graph",
                from_key
            )));
        }

        // Add dependent to the to node
        if let Some(to_node) = self.nodes.get_mut(to_key) {
            to_node.add_dependent(from_key.to_string());
        } else {
            return Err(RezCoreError::Solver(format!(
                "Package {} not found in graph",
                to_key
            )));
        }

        Ok(())
    }

    /// Remove a package from the graph
    pub fn remove_package(&mut self, package_key: &str) -> Result<(), RezCoreError> {
        if let Some(node) = self.nodes.remove(package_key) {
            // Remove all edges involving this package
            for dep_key in &node.dependencies {
                if let Some(dep_node) = self.nodes.get_mut(dep_key) {
                    dep_node.remove_dependent(package_key);
                }
            }

            for dependent_key in &node.dependents {
                if let Some(dependent_node) = self.nodes.get_mut(dependent_key) {
                    dependent_node.remove_dependency(package_key);
                }
            }
        }

        Ok(())
    }

    /// Detect conflicts in the dependency graph
    pub fn detect_conflicts(&self) -> Vec<DependencyConflict> {
        let mut conflicts = Vec::new();

        // Group requirements by package name
        for (package_name, requirements) in &self.requirements {
            if requirements.len() > 1 {
                // Check if requirements are compatible via version range intersection
                let mut incompatible_groups = Vec::new();

                for (i, req1) in requirements.iter().enumerate() {
                    for req2 in requirements.iter().skip(i + 1) {
                        if !requirements_compatible(req1, req2) {
                            incompatible_groups.push((req1.clone(), req2.clone()));
                        }
                    }
                }

                if !incompatible_groups.is_empty() {
                    let severity = self.determine_conflict_severity(&incompatible_groups);
                    let source_packages = self.find_requirement_sources(package_name);

                    conflicts.push(DependencyConflict {
                        package_name: package_name.clone(),
                        conflicting_requirements: requirements.clone(),
                        source_packages,
                        severity,
                    });
                }
            }
        }

        conflicts
    }

    /// Determine the severity of a conflict
    fn determine_conflict_severity(
        &self,
        incompatible_groups: &[(PackageRequirement, PackageRequirement)],
    ) -> ConflictSeverity {
        // Simple heuristic: if any requirements are completely incompatible, it's incompatible
        // If major versions differ, it's major
        // Otherwise, it's minor

        // Use range intersection to determine severity
        for (req1, req2) in incompatible_groups {
            let range1 = req1.version_spec.as_deref().unwrap_or("");
            let range2 = req2.version_spec.as_deref().unwrap_or("");
            // Both have ranges and they don't intersect → Incompatible
            if !range1.is_empty() && !range2.is_empty() {
                if let (Ok(r1), Ok(r2)) = (
                    rez_next_version::VersionRange::parse(range1),
                    rez_next_version::VersionRange::parse(range2),
                ) {
                    if r1.intersect(&r2).is_none() {
                        return ConflictSeverity::Incompatible;
                    }
                }
            }
        }

        ConflictSeverity::Major
    }

    /// Find which packages introduced requirements for a given package
    fn find_requirement_sources(&self, package_name: &str) -> Vec<String> {
        let mut sources = Vec::new();

        for node in self.nodes.values() {
            for req_str in &node.package.requires {
                if let Ok(req) = PackageRequirement::parse(req_str) {
                    if req.name == package_name {
                        sources.push(node.key());
                        break;
                    }
                }
            }
        }

        sources
    }

    /// Apply a conflict resolution to the graph
    pub fn apply_conflict_resolution(
        &mut self,
        resolution: ConflictResolution,
    ) -> Result<(), RezCoreError> {
        // Remove packages that were modified
        for package_key in &resolution.modified_packages {
            self.remove_package(package_key)?;
        }

        // Update requirements for the resolved package
        if let Some(requirements) = self.requirements.get_mut(&resolution.package_name) {
            // Create a new requirement based on the resolution
            if let Some(ref version) = resolution.selected_version {
                let new_requirement = PackageRequirement::with_version(
                    resolution.package_name.clone(),
                    version.as_str().to_string(),
                );
                requirements.clear();
                requirements.push(new_requirement);
            }
        }

        Ok(())
    }

    /// Get all resolved packages in topological order
    pub fn get_resolved_packages(&self) -> Result<Vec<Package>, RezCoreError> {
        let sorted_keys = self.topological_sort()?;
        let mut packages = Vec::new();

        for key in sorted_keys {
            if let Some(node) = self.nodes.get(&key) {
                packages.push(node.package.clone());
            }
        }

        Ok(packages)
    }

    /// Perform topological sort of the dependency graph
    fn topological_sort(&self) -> Result<Vec<String>, RezCoreError> {
        let mut in_degree: HashMap<String, usize> = HashMap::new();
        let mut result = Vec::new();
        let mut queue = VecDeque::new();

        // Calculate in-degrees
        for (key, node) in &self.nodes {
            in_degree.insert(key.clone(), node.dependents.len());
        }

        // Find nodes with no incoming edges
        for (key, &degree) in &in_degree {
            if degree == 0 {
                queue.push_back(key.clone());
            }
        }

        // Process nodes
        while let Some(current_key) = queue.pop_front() {
            result.push(current_key.clone());

            if let Some(current_node) = self.nodes.get(&current_key) {
                // Reduce in-degree of dependent nodes
                for dep_key in &current_node.dependencies {
                    if let Some(degree) = in_degree.get_mut(dep_key) {
                        *degree -= 1;
                        if *degree == 0 {
                            queue.push_back(dep_key.clone());
                        }
                    }
                }
            }
        }

        // Check for cycles
        if result.len() != self.nodes.len() {
            return Err(RezCoreError::Solver(
                "Circular dependency detected in package graph".to_string(),
            ));
        }

        Ok(result)
    }

    /// Get graph statistics
    pub fn get_stats(&self) -> GraphStats {
        let mut total_dependencies = 0;
        let mut max_depth = 0;

        for node in self.nodes.values() {
            total_dependencies += node.dependencies.len();
            let depth = self.calculate_node_depth(&node.key());
            max_depth = max_depth.max(depth);
        }

        GraphStats {
            node_count: self.nodes.len(),
            edge_count: total_dependencies,
            max_depth,
            conflict_count: self.detect_conflicts().len(),
            constraint_count: self.constraints.len(),
            exclusion_count: self.exclusions.len(),
        }
    }

    /// Calculate the depth of a node in the graph
    fn calculate_node_depth(&self, node_key: &str) -> usize {
        let mut visited = HashSet::new();
        self.calculate_depth_recursive(node_key, &mut visited)
    }

    /// Recursive helper for depth calculation
    fn calculate_depth_recursive(&self, node_key: &str, visited: &mut HashSet<String>) -> usize {
        if visited.contains(node_key) {
            return 0; // Avoid infinite recursion
        }

        visited.insert(node_key.to_string());

        if let Some(node) = self.nodes.get(node_key) {
            let mut max_dep_depth = 0;
            for dep_key in &node.dependencies {
                let dep_depth = self.calculate_depth_recursive(dep_key, visited);
                max_dep_depth = max_dep_depth.max(dep_depth);
            }
            max_dep_depth + 1
        } else {
            0
        }
    }
}

/// Graph statistics
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct GraphStats {
    /// Number of nodes in the graph
    pub node_count: usize,
    /// Number of edges in the graph
    pub edge_count: usize,
    /// Maximum depth of the graph
    pub max_depth: usize,
    /// Number of conflicts detected
    pub conflict_count: usize,
    /// Number of constraints
    pub constraint_count: usize,
    /// Number of exclusions
    pub exclusion_count: usize,
}

impl Default for DependencyGraph {
    fn default() -> Self {
        Self::new()
    }
}

/// Check if two PackageRequirements for the same package are compatible.
/// Two requirements are compatible if their version ranges have a non-empty intersection.
fn requirements_compatible(req1: &PackageRequirement, req2: &PackageRequirement) -> bool {
    let spec1 = req1.version_spec.as_deref().unwrap_or("");
    let spec2 = req2.version_spec.as_deref().unwrap_or("");

    // If either has no version constraint, they're compatible
    if spec1.is_empty() || spec2.is_empty() {
        return true;
    }

    // Parse both ranges and check for intersection
    match (
        rez_next_version::VersionRange::parse(spec1),
        rez_next_version::VersionRange::parse(spec2),
    ) {
        (Ok(r1), Ok(r2)) => r1.intersect(&r2).is_some(),
        _ => true, // If parsing fails, assume compatible (don't false-flag)
    }
}

#[cfg(test)]
mod graph_tests {
    use super::*;

    fn make_pkg(name: &str, ver: &str) -> Package {
        let mut p = Package::new(name.to_string());
        p.version = Some(Version::parse(ver).unwrap());
        p
    }

    /// New graph starts empty
    #[test]
    fn test_graph_new_is_empty() {
        let g = DependencyGraph::new();
        let stats = g.get_stats();
        assert_eq!(stats.node_count, 0);
        assert_eq!(stats.edge_count, 0);
        assert_eq!(stats.conflict_count, 0);
    }

    /// Adding a package increases node count
    #[test]
    fn test_graph_add_package_increments_nodes() {
        let mut g = DependencyGraph::new();
        g.add_package(make_pkg("python", "3.9.0")).unwrap();
        let stats = g.get_stats();
        assert_eq!(stats.node_count, 1);
    }

    /// Adding duplicate package is idempotent (no error, same count)
    #[test]
    fn test_graph_add_duplicate_package_no_error() {
        let mut g = DependencyGraph::new();
        g.add_package(make_pkg("maya", "2023.0")).unwrap();
        // Adding same package again should be ok (update or ignore)
        let result = g.add_package(make_pkg("maya", "2023.0"));
        assert!(result.is_ok(), "Re-adding same package should not error");
    }

    /// clear() resets graph to empty
    #[test]
    fn test_graph_clear_resets_state() {
        let mut g = DependencyGraph::new();
        g.add_package(make_pkg("houdini", "20.0")).unwrap();
        g.add_package(make_pkg("python", "3.10.0")).unwrap();
        g.clear();
        let stats = g.get_stats();
        assert_eq!(stats.node_count, 0);
        assert_eq!(stats.conflict_count, 0);
    }

    /// get_resolved_packages returns packages with no conflicts
    #[test]
    fn test_graph_get_resolved_packages_no_conflicts() {
        let mut g = DependencyGraph::new();
        g.add_package(make_pkg("nuke", "14.0")).unwrap();
        g.add_package(make_pkg("ocio", "2.1")).unwrap();
        let resolved = g.get_resolved_packages().unwrap();
        assert_eq!(resolved.len(), 2);
    }

    /// requirements_compatible: unconstrained requirements are always compatible
    #[test]
    fn test_requirements_compatible_unconstrained() {
        let r1 = PackageRequirement::parse("python").unwrap();
        let r2 = PackageRequirement::parse("python").unwrap();
        assert!(
            requirements_compatible(&r1, &r2),
            "Two unconstrained requirements for same package should be compatible"
        );
    }
}