repotoire 0.5.3

Graph-powered code analysis CLI. 106 detectors for security, architecture, and code quality.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
//! Python parser using tree-sitter
//!
//! Extracts functions, classes, imports, and call relationships from Python source code.

use crate::models::{Class, Function};
use crate::parsers::{ImportInfo, ParseResult};
use anyhow::{Context, Result};
use std::cell::RefCell;
use std::collections::{HashMap, HashSet};
use std::path::Path;
use std::sync::OnceLock;
use tree_sitter::{Node, Parser, Query, QueryCursor, StreamingIterator};

thread_local! {
    static PY_PARSER: RefCell<Parser> = RefCell::new({
        let mut p = Parser::new();
        p.set_language(&tree_sitter_python::LANGUAGE.into()).expect("Python language");
        p
    });
}

/// Query string for module-level function definitions (sync and decorated)
const PY_FUNC_QUERY_STR: &str = r#"
    (module
        (function_definition
            name: (identifier) @func_name
            parameters: (parameters) @params
            return_type: (type)? @return_type
        ) @func
    )
    (module
        (decorated_definition
            (function_definition
                name: (identifier) @func_name
                parameters: (parameters) @params
                return_type: (type)? @return_type
            ) @func
        )
    )
"#;

/// Cached function query for Python
static PY_FUNC_QUERY: OnceLock<Query> = OnceLock::new();

/// Extract decorator names from a `decorated_definition` node.
fn extract_decorators(node: &Node, source: &[u8]) -> Vec<String> {
    let mut decorators = Vec::new();
    let mut cursor = node.walk();
    for child in node.children(&mut cursor) {
        if child.kind() == "decorator" {
            let mut inner_cursor = child.walk();
            for inner in child.children(&mut inner_cursor) {
                if inner.kind() != "@" && inner.kind() != "comment" {
                    let text = inner.utf8_text(source).unwrap_or("");
                    let name = text.split('(').next().unwrap_or(text).trim();
                    if !name.is_empty() {
                        decorators.push(name.to_string());
                    }
                    break;
                }
            }
        }
    }
    decorators
}

/// Parse a Python file and extract all code entities
#[allow(dead_code)]
pub fn parse(path: &Path) -> Result<ParseResult> {
    let source = std::fs::read_to_string(path)
        .with_context(|| format!("Failed to read file: {}", path.display()))?;

    parse_source(&source, path)
}

/// Parse Python source code directly (useful for testing)
pub fn parse_source(source: &str, path: &Path) -> Result<ParseResult> {
    parse_source_with_tree(source, path).map(|(r, _)| r)
}

/// Parse Python source code and return both the ParseResult and the tree-sitter Tree.
/// Used by the pipeline to extract structural fingerprints without re-parsing.
pub fn parse_source_with_tree(source: &str, path: &Path) -> Result<(ParseResult, tree_sitter::Tree)> {
    let tree = PY_PARSER.with(|cell| {
        cell.borrow_mut().parse(source, None)
    }).context("Failed to parse Python source")?;

    let root = tree.root_node();
    let source_bytes = source.as_bytes();

    let mut result = ParseResult::default();

    // Extract all entities
    extract_functions(&root, source_bytes, path, &mut result)?;
    let class_nodes = extract_classes(&root, source_bytes, path, &mut result)?;
    extract_class_methods(&class_nodes, source_bytes, path, &mut result)?;
    extract_imports(&root, source_bytes, &mut result)?;
    extract_calls(&root, source_bytes, path, &mut result)?;

    // Annotate exported functions and classes
    annotate_exports(&root, source_bytes, &mut result);

    Ok((result, tree))
}

/// Determine which functions/classes are exported and annotate them.
///
/// If `__all__` is defined, only names listed in it are exported.
/// Otherwise, all module-level names not starting with `_` are exported.
fn annotate_exports(root: &Node, source: &[u8], result: &mut ParseResult) {
    let all_names = extract_dunder_all(root, source);

    for func in &mut result.functions {
        // Skip class methods — they're not individually importable.
        // Methods have qualified names like "path::ClassName.method:line".
        let name_part = func.qualified_name.rsplit("::").next().unwrap_or("");
        if name_part.contains('.') {
            continue;
        }

        let is_exported = if let Some(ref names) = all_names {
            names.contains(&func.name)
        } else {
            !func.name.starts_with('_')
        };
        if is_exported && !func.annotations.contains(&"exported".to_string()) {
            func.annotations.push("exported".to_string());
        }
    }

    for class in &mut result.classes {
        let is_exported = if let Some(ref names) = all_names {
            names.contains(&class.name)
        } else {
            !class.name.starts_with('_')
        };
        if is_exported && !class.annotations.contains(&"exported".to_string()) {
            class.annotations.push("exported".to_string());
        }
    }
}

/// Extract names from `__all__ = [...]` if present.
///
/// Returns `Some(HashSet)` if `__all__` is defined, `None` otherwise.
fn extract_dunder_all(root: &Node, source: &[u8]) -> Option<HashSet<String>> {
    let mut cursor = root.walk();

    for node in root.children(&mut cursor) {
        if node.kind() == "expression_statement" {
            // Look for assignment: __all__ = [...]
            for child in node.children(&mut node.walk()) {
                if child.kind() == "assignment" {
                    let left = child.child_by_field_name("left");
                    let right = child.child_by_field_name("right");
                    if let (Some(left_node), Some(right_node)) = (left, right) {
                        let left_text = left_node.utf8_text(source).unwrap_or("");
                        if left_text == "__all__" {
                            return Some(extract_string_list(&right_node, source));
                        }
                    }
                }
            }
        }
    }

    None
}

/// Extract string values from a list literal node `['a', 'b', 'c']`.
fn extract_string_list(node: &Node, source: &[u8]) -> HashSet<String> {
    let mut names = HashSet::new();

    if node.kind() == "list" || node.kind() == "tuple" {
        for child in node.children(&mut node.walk()) {
            if child.kind() == "string" {
                let text = child.utf8_text(source).unwrap_or("");
                // Strip quotes: 'name' or "name"
                let stripped = text
                    .trim_start_matches(['\'', '"'])
                    .trim_end_matches(['\'', '"']);
                if !stripped.is_empty() {
                    names.insert(stripped.to_string());
                }
            }
        }
    }

    names
}

/// Extract function definitions from the AST
fn extract_functions(
    root: &Node,
    source: &[u8],
    path: &Path,
    result: &mut ParseResult,
) -> Result<()> {
    // Query for function definitions at module level (handles both sync and async)
    let query = PY_FUNC_QUERY.get_or_init(|| {
        Query::new(&tree_sitter_python::LANGUAGE.into(), PY_FUNC_QUERY_STR)
            .expect("valid Python function query")
    });

    let mut cursor = QueryCursor::new();
    let mut matches = cursor.matches(query, *root, source);

    while let Some(m) = matches.next() {
        let mut func_node = None;
        let mut name = String::new();
        let mut params_node = None;
        let mut return_type_node = None;

        for capture in m.captures.iter() {
            let capture_name = query.capture_names()[capture.index as usize];
            match capture_name {
                "func" => func_node = Some(capture.node),
                "func_name" => {
                    name = capture.node.utf8_text(source).unwrap_or("").to_string();
                }
                "params" => params_node = Some(capture.node),
                "return_type" => return_type_node = Some(capture.node),
                _ => {}
            }
        }

        if let Some(node) = func_node {
            // Check for async: check if the line starts with "async def"
            let line_text = {
                let start = node.start_byte();
                let line_start = source[..start]
                    .iter()
                    .rposition(|&b| b == b'\n')
                    .map_or(0, |i| i + 1);
                std::str::from_utf8(&source[line_start..start + 10.min(source.len() - start)])
                    .unwrap_or("")
            };
            let is_async = line_text.trim_start().starts_with("async");

            let parameters = extract_parameters(params_node, source);
            let return_type =
                return_type_node.map(|n| n.utf8_text(source).unwrap_or("").to_string());

            let line_start = node.start_position().row as u32 + 1;
            let line_end = node.end_position().row as u32 + 1;
            let qualified_name = format!("{}::{}:{}", path.display(), name, line_start);

            let annotations = if let Some(parent) = node.parent() {
                if parent.kind() == "decorated_definition" {
                    extract_decorators(&parent, source)
                } else {
                    vec![]
                }
            } else {
                vec![]
            };

            result.functions.push(Function {
                name: name.clone(),
                qualified_name,
                file_path: path.to_path_buf(),
                line_start,
                line_end,
                parameters,
                return_type,
                is_async,
                complexity: Some(calculate_complexity(&node, source)),
                max_nesting: None,
                doc_comment: None,
                annotations,
            });
        }
    }

    // Also handle async functions specifically
    extract_async_functions(root, source, path, result)?;

    Ok(())
}

/// Extract async function definitions
fn extract_async_functions(
    root: &Node,
    source: &[u8],
    path: &Path,
    result: &mut ParseResult,
) -> Result<()> {
    let mut cursor = root.walk();

    for node in root.children(&mut cursor) {
        if node.kind() == "async_function_definition" {
            if let Some(func) = parse_function_node(&node, source, path, true) {
                // Check if we already have this function (from the query)
                if !result
                    .functions
                    .iter()
                    .any(|f| f.qualified_name == func.qualified_name)
                {
                    result.functions.push(func);
                }
            }
        } else if node.kind() == "decorated_definition" {
            // Check if the decorated definition contains an async function
            for child in node.children(&mut node.walk()) {
                if child.kind() == "async_function_definition" {
                    if let Some(func) = parse_function_node(&child, source, path, true) {
                        if !result
                            .functions
                            .iter()
                            .any(|f| f.qualified_name == func.qualified_name)
                        {
                            result.functions.push(func);
                        }
                    }
                }
            }
        }
    }

    Ok(())
}

/// Parse a single function node into a Function struct
fn parse_function_node(
    node: &Node,
    source: &[u8],
    path: &Path,
    is_async: bool,
) -> Option<Function> {
    let name_node = node.child_by_field_name("name")?;
    let name = name_node.utf8_text(source).ok()?.to_string();

    let params_node = node.child_by_field_name("parameters");
    let parameters = extract_parameters(params_node, source);

    let return_type = node
        .child_by_field_name("return_type")
        .and_then(|n| n.utf8_text(source).ok())
        .map(|s| s.to_string());

    let line_start = node.start_position().row as u32 + 1;
    let line_end = node.end_position().row as u32 + 1;
    let qualified_name = format!("{}::{}:{}", path.display(), name, line_start);

    let annotations = if let Some(parent) = node.parent() {
        if parent.kind() == "decorated_definition" {
            extract_decorators(&parent, source)
        } else {
            vec![]
        }
    } else {
        vec![]
    };

    Some(Function {
        name,
        qualified_name,
        file_path: path.to_path_buf(),
        line_start,
        line_end,
        parameters,
        return_type,
        is_async,
        complexity: Some(calculate_complexity(node, source)),
        max_nesting: None,
        doc_comment: None,
        annotations,
    })
}

/// Extract parameter names from a parameters node
fn extract_parameters(params_node: Option<Node>, source: &[u8]) -> Vec<String> {
    let Some(node) = params_node else {
        return vec![];
    };

    let mut params = Vec::new();
    let mut cursor = node.walk();

    for child in node.children(&mut cursor) {
        match child.kind() {
            "identifier" => {
                if let Ok(text) = child.utf8_text(source) {
                    params.push(text.to_string());
                }
            }
            "typed_parameter" | "default_parameter" | "typed_default_parameter" => {
                // Get the parameter name (first identifier child)
                if let Some(name_node) = child.child_by_field_name("name") {
                    if let Ok(text) = name_node.utf8_text(source) {
                        params.push(text.to_string());
                    }
                } else {
                    // Fallback: first identifier child
                    for grandchild in child.children(&mut child.walk()) {
                        if grandchild.kind() == "identifier" {
                            if let Ok(text) = grandchild.utf8_text(source) {
                                params.push(text.to_string());
                                break;
                            }
                        }
                    }
                }
            }
            "list_splat_pattern" | "dictionary_splat_pattern" => {
                // *args or **kwargs
                for grandchild in child.children(&mut child.walk()) {
                    if grandchild.kind() == "identifier" {
                        if let Ok(text) = grandchild.utf8_text(source) {
                            let prefix = if child.kind() == "list_splat_pattern" {
                                "*"
                            } else {
                                "**"
                            };
                            params.push(format!("{}{}", prefix, text));
                            break;
                        }
                    }
                }
            }
            _ => {}
        }
    }

    params
}

/// Extract class definitions from the AST
fn extract_classes<'a>(
    root: &Node<'a>,
    source: &[u8],
    path: &Path,
    result: &mut ParseResult,
) -> Result<Vec<(String, Node<'a>)>> {
    let mut cursor = root.walk();
    let mut class_nodes = Vec::new();

    for node in root.children(&mut cursor) {
        let class_node = if node.kind() == "class_definition" {
            Some(node)
        } else if node.kind() == "decorated_definition" {
            // Find class_definition inside decorated_definition
            node.children(&mut node.walk())
                .find(|c| c.kind() == "class_definition")
        } else {
            None
        };

        if let Some(class_node) = class_node {
            if let Some(class) = parse_class_node(&class_node, source, path) {
                let name = class.name.clone();
                result.classes.push(class);
                class_nodes.push((name, class_node));
            }
        }
    }

    Ok(class_nodes)
}

/// Parse a single class node into a Class struct
fn parse_class_node(node: &Node, source: &[u8], path: &Path) -> Option<Class> {
    let name_node = node.child_by_field_name("name")?;
    let name = name_node.utf8_text(source).ok()?.to_string();

    let line_start = node.start_position().row as u32 + 1;
    let line_end = node.end_position().row as u32 + 1;
    let qualified_name = format!("{}::{}:{}", path.display(), name, line_start);

    // Extract base classes
    let bases = extract_bases(node, source);

    // Extract method names
    let methods = extract_methods(node, source);

    let annotations = if let Some(parent) = node.parent() {
        if parent.kind() == "decorated_definition" {
            extract_decorators(&parent, source)
        } else {
            vec![]
        }
    } else {
        vec![]
    };

    Some(Class {
        name,
        qualified_name,
        file_path: path.to_path_buf(),
        line_start,
        line_end,
        methods,
        field_count: 0,
        bases,
        doc_comment: None,
        annotations,
    })
}

/// Extract base class names from a class definition
fn extract_bases(class_node: &Node, source: &[u8]) -> Vec<String> {
    let mut bases = Vec::new();

    // Find the argument_list (superclasses) or superclasses node
    for child in class_node.children(&mut class_node.walk()) {
        if child.kind() == "argument_list" {
            // Each argument is a base class
            for arg in child.children(&mut child.walk()) {
                if let Some(base_name) = extract_base_name(&arg, source) {
                    bases.push(base_name);
                }
            }
        }
    }

    bases
}

/// Extract a base class name from various node types
fn extract_base_name(node: &Node, source: &[u8]) -> Option<String> {
    match node.kind() {
        "identifier" => node.utf8_text(source).ok().map(|s| s.to_string()),
        "attribute" => {
            // module.ClassName
            node.utf8_text(source).ok().map(|s| s.to_string())
        }
        "subscript" => {
            // Generic[T] - just get the base
            node.child_by_field_name("value")
                .and_then(|n| extract_base_name(&n, source))
        }
        "keyword_argument" => None, // Skip keyword args like metaclass=...
        "(" | ")" | "," => None,    // Skip punctuation
        _ => None,
    }
}

/// Extract method names from a class body
fn extract_methods(class_node: &Node, source: &[u8]) -> Vec<String> {
    let mut methods = Vec::new();

    // Find the block (class body)
    let body = class_node.child_by_field_name("body").or_else(|| {
        class_node
            .children(&mut class_node.walk())
            .find(|c| c.kind() == "block")
    });

    if let Some(body) = body {
        for child in body.children(&mut body.walk()) {
            let func_node = if child.kind() == "function_definition"
                || child.kind() == "async_function_definition"
            {
                Some(child)
            } else if child.kind() == "decorated_definition" {
                child.children(&mut child.walk()).find(|c| {
                    c.kind() == "function_definition" || c.kind() == "async_function_definition"
                })
            } else {
                None
            };

            if let Some(func) = func_node {
                if let Some(name_node) = func.child_by_field_name("name") {
                    if let Ok(name) = name_node.utf8_text(source) {
                        methods.push(name.to_string());
                    }
                }
            }
        }
    }

    methods
}

/// Extract methods from all classes as full Function entries.
///
/// This ensures class methods are first-class citizens in the graph,
/// making them visible to all detectors (dead code, complexity, etc.).
fn extract_class_methods(
    class_nodes: &[(String, Node)],
    source: &[u8],
    path: &Path,
    result: &mut ParseResult,
) -> Result<()> {
    for (class_name, class_node) in class_nodes {
        let Some(body) = class_node.child_by_field_name("body") else {
            continue;
        };

        for child in body.children(&mut body.walk()) {
            let func_node = if child.kind() == "function_definition"
                || child.kind() == "async_function_definition"
            {
                Some(child)
            } else if child.kind() == "decorated_definition" {
                child.children(&mut child.walk()).find(|c| {
                    c.kind() == "function_definition" || c.kind() == "async_function_definition"
                })
            } else {
                None
            };

            let Some(func) = func_node else {
                continue;
            };

            // Detect async: check node kind first, then fall back to source text.
            // tree-sitter Python may fold `async def` into `function_definition`.
            let is_async = func.kind() == "async_function_definition"
                || func
                    .utf8_text(source)
                    .is_ok_and(|t| t.trim_start().starts_with("async"));
            let Some(name_node) = func.child_by_field_name("name") else {
                continue;
            };
            let Ok(name) = name_node.utf8_text(source) else {
                continue;
            };

            let params_node = func.child_by_field_name("parameters");
            let parameters = extract_parameters(params_node, source);
            let return_type = func
                .child_by_field_name("return_type")
                .and_then(|n| n.utf8_text(source).ok())
                .map(|s| s.to_string());

            let line_start = func.start_position().row as u32 + 1;
            let line_end = func.end_position().row as u32 + 1;
            let qualified_name =
                format!("{}::{}.{}:{}", path.display(), class_name, name, line_start);

            let annotations = if let Some(parent) = func.parent() {
                if parent.kind() == "decorated_definition" {
                    extract_decorators(&parent, source)
                } else {
                    vec![]
                }
            } else {
                vec![]
            };

            result.functions.push(Function {
                name: name.to_string(),
                qualified_name,
                file_path: path.to_path_buf(),
                line_start,
                line_end,
                parameters,
                return_type,
                is_async,
                complexity: Some(calculate_complexity(&func, source)),
                max_nesting: None,
                doc_comment: None,
                annotations,
            });
        }
    }

    Ok(())
}

/// Extract import statements from the AST
fn extract_imports(root: &Node, source: &[u8], result: &mut ParseResult) -> Result<()> {
    let mut cursor = root.walk();

    for node in root.children(&mut cursor) {
        match node.kind() {
            "import_statement" => {
                // import module1, module2
                for child in node.children(&mut node.walk()) {
                    if child.kind() == "dotted_name" {
                        if let Ok(text) = child.utf8_text(source) {
                            result.imports.push(ImportInfo::runtime(text.to_string()));
                        }
                    } else if child.kind() == "aliased_import" {
                        // import module as alias
                        if let Some(name_node) = child.child_by_field_name("name") {
                            if let Ok(text) = name_node.utf8_text(source) {
                                result.imports.push(ImportInfo::runtime(text.to_string()));
                            }
                        }
                    }
                }
            }
            "import_from_statement" => {
                // from module import name1, name2
                // Get the module name
                if let Some(module_node) = node.child_by_field_name("module_name") {
                    if let Ok(module) = module_node.utf8_text(source) {
                        result.imports.push(ImportInfo::runtime(module.to_string()));
                    }
                } else {
                    // Try to find dotted_name directly
                    for child in node.children(&mut node.walk()) {
                        if child.kind() == "dotted_name" || child.kind() == "relative_import" {
                            if let Ok(text) = child.utf8_text(source) {
                                result.imports.push(ImportInfo::runtime(text.to_string()));
                            }
                            break;
                        }
                    }
                }
            }
            _ => {}
        }
    }

    Ok(())
}

/// Extract function calls from the AST
fn extract_calls(root: &Node, source: &[u8], path: &Path, result: &mut ParseResult) -> Result<()> {
    // Build a map of function/method locations for call extraction.
    // Both module-level functions AND class methods are in result.functions.
    let mut scope_map: HashMap<(u32, u32), String> = HashMap::new();

    for func in &result.functions {
        scope_map.insert(
            (func.line_start, func.line_end),
            func.qualified_name.clone(),
        );
    }

    // Now walk the tree to find all calls
    extract_calls_recursive(root, source, path, &scope_map, result);

    Ok(())
}

/// Recursively extract calls from the AST
fn extract_calls_recursive(
    node: &Node,
    source: &[u8],
    path: &Path,
    scope_map: &HashMap<(u32, u32), String>,
    result: &mut ParseResult,
) {
    if node.kind() == "call" {
        // Get the line number of this call
        let call_line = node.start_position().row as u32 + 1;

        // Find which function/method contains this call
        // For top-level calls (outside any function), use the file path as the caller
        let caller = find_containing_scope(call_line, scope_map)
            .unwrap_or_else(|| path.display().to_string());

        // Get the function being called
        if let Some(func_node) = node.child_by_field_name("function") {
            if let Some(callee) = extract_call_target(&func_node, source) {
                // Skip self.method calls where caller and callee are in same class
                // (these are tracked differently in the Python version)
                if !callee.starts_with("self.") || !caller.contains(&callee.replace("self.", "")) {
                    result.calls.push((caller, callee));
                }
            }
        }
    }

    // Recurse into children
    for child in node.children(&mut node.walk()) {
        extract_calls_recursive(&child, source, path, scope_map, result);
    }
}

/// Find which scope (function/method) contains a given line
fn find_containing_scope(line: u32, scope_map: &HashMap<(u32, u32), String>) -> Option<String> {
    super::find_containing_scope(line, scope_map)
}

/// Extract the target of a function call
fn extract_call_target(node: &Node, source: &[u8]) -> Option<String> {
    match node.kind() {
        "identifier" => node.utf8_text(source).ok().map(|s| s.to_string()),
        "attribute" => {
            // obj.method or module.func
            node.utf8_text(source).ok().map(|s| s.to_string())
        }
        "subscript" => {
            // func[T]() - get the function name
            node.child_by_field_name("value")
                .and_then(|n| extract_call_target(&n, source))
        }
        "call" => {
            // Chained call: func()() - get the inner function
            node.child_by_field_name("function")
                .and_then(|n| extract_call_target(&n, source))
        }
        _ => None,
    }
}

/// Calculate cyclomatic complexity of a function
fn calculate_complexity(node: &Node, _source: &[u8]) -> u32 {
    let mut complexity = 1; // Base complexity

    fn count_branches(node: &Node, complexity: &mut u32) {
        match node.kind() {
            // Control flow
            "if_statement" | "elif_clause" | "while_statement" | "for_statement" => {
                *complexity += 1;
            }
            // Exception handling
            "except_clause" => {
                *complexity += 1;
            }
            // Boolean operators (each 'and'/'or' adds a branch)
            "boolean_operator" => {
                *complexity += 1;
            }
            // Ternary/conditional expression
            "conditional_expression" => {
                *complexity += 1;
            }
            // List/dict/set comprehensions with conditions
            "list_comprehension" | "dictionary_comprehension" | "set_comprehension" => {
                // Count 'if' clauses inside
                for child in node.children(&mut node.walk()) {
                    if child.kind() == "if_clause" {
                        *complexity += 1;
                    }
                }
            }
            // Match statement (Python 3.10+)
            "match_statement" => {
                // Each case adds to complexity
                for child in node.children(&mut node.walk()) {
                    if child.kind() == "case_clause" {
                        *complexity += 1;
                    }
                }
            }
            // Try blocks don't add complexity themselves, but except clauses do
            "try_statement" => {}
            // With statement
            "with_statement" => {
                *complexity += 1;
            }
            // Assert
            "assert_statement" => {
                *complexity += 1;
            }
            _ => {}
        }

        // Recurse into children
        for child in node.children(&mut node.walk()) {
            count_branches(&child, complexity);
        }
    }

    count_branches(node, &mut complexity);
    complexity
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::path::PathBuf;

    #[test]
    fn test_parse_simple_function() {
        let source = r#"
def hello(name: str) -> str:
    """Greet someone."""
    return f"Hello, {name}!"
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse simple function");

        assert_eq!(result.functions.len(), 1);
        let func = &result.functions[0];
        assert_eq!(func.name, "hello");
        assert_eq!(func.parameters, vec!["name"]);
        assert!(!func.is_async);
        assert_eq!(func.line_start, 2);
    }

    #[test]
    fn test_parse_async_function() {
        let source = r#"
async def fetch_data(url: str) -> bytes:
    return await http.get(url)
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse async function");

        assert_eq!(result.functions.len(), 1);
        let func = &result.functions[0];
        assert_eq!(func.name, "fetch_data");
        assert!(func.is_async);
    }

    #[test]
    fn test_parse_class() {
        let source = r#"
class MyClass(BaseClass, Mixin):
    def __init__(self):
        pass

    def method(self, x):
        return x * 2
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse class");

        assert_eq!(result.classes.len(), 1);
        let class = &result.classes[0];
        assert_eq!(class.name, "MyClass");
        assert_eq!(class.bases, vec!["BaseClass", "Mixin"]);
        assert_eq!(class.methods, vec!["__init__", "method"]);
    }

    #[test]
    fn test_parse_imports() {
        let source = r#"
import os
import sys
from pathlib import Path
from typing import List, Optional
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse imports");

        assert!(result.imports.iter().any(|i| i.path == "os"));
        assert!(result.imports.iter().any(|i| i.path == "sys"));
        assert!(result.imports.iter().any(|i| i.path == "pathlib"));
        assert!(result.imports.iter().any(|i| i.path == "typing"));
    }

    #[test]
    fn test_parse_calls() {
        let source = r#"
def caller():
    result = some_function()
    other_function(result)
    return result

def some_function():
    return 42

def other_function(x):
    print(x)
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse calls");

        // Should have calls from caller to some_function and other_function
        assert!(!result.calls.is_empty());

        let call_targets: Vec<&str> = result.calls.iter().map(|(_, t)| t.as_str()).collect();
        assert!(call_targets.contains(&"some_function"));
        assert!(call_targets.contains(&"other_function"));
    }

    #[test]
    fn test_complexity_calculation() {
        let source = r#"
def complex_function(x):
    if x > 0:
        if x > 10:
            return "big"
        else:
            return "small positive"
    elif x < 0:
        return "negative"
    else:
        return "zero"
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse complex function");

        let func = &result.functions[0];
        // Base (1) + if (1) + if (1) + elif (1) = 4
        assert!(func.complexity.expect("should have complexity") >= 4);
    }

    #[test]
    fn test_parse_decorated_function() {
        let source = r#"
@decorator
def decorated():
    pass

@property
def prop(self):
    return self._value
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse decorated function");

        assert_eq!(result.functions.len(), 2);
    }

    #[test]
    fn test_parse_star_args() {
        let source = r#"
def varargs(*args, **kwargs):
    pass
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse star args");

        let func = &result.functions[0];
        assert!(func.parameters.contains(&"*args".to_string()));
        assert!(func.parameters.contains(&"**kwargs".to_string()));
    }

    #[test]
    fn test_method_count_excludes_nested() {
        // Issue #18: Parser should not count nested functions/lambdas as class methods
        let source = r#"
class DataProcessor:
    def __init__(self):
        self.handlers = []
    
    def process(self, items):
        # These should NOT be counted as methods:
        inner_helper = lambda x: x * 2
        results = list(map(lambda item: item.strip(), items))
        
        def local_transform(val):
            return val.upper()
        
        return [local_transform(r) for r in results]
    
    def register(self, handler):
        self.handlers.append(handler)
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse nested methods");

        assert_eq!(result.classes.len(), 1);
        let class = &result.classes[0];
        assert_eq!(class.name, "DataProcessor");

        // Should have exactly 3 methods: __init__, process, register
        // NOT: inner_helper lambda, map lambda, local_transform
        assert_eq!(
            class.methods.len(),
            3,
            "Expected 3 methods (__init__, process, register), got {:?}",
            class.methods
        );
        assert!(class.methods.contains(&"__init__".to_string()));
        assert!(class.methods.contains(&"process".to_string()));
        assert!(class.methods.contains(&"register".to_string()));
    }

    #[test]
    fn test_decorated_methods_counted_correctly() {
        let source = r#"
class MyClass:
    @property
    def value(self):
        return self._value

    @staticmethod
    def create():
        return MyClass()

    @classmethod
    def from_string(cls, s):
        return cls()
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse decorated methods");

        let class = &result.classes[0];
        assert_eq!(
            class.methods.len(),
            3,
            "Expected 3 methods (value, create, from_string), got {:?}",
            class.methods
        );
    }

    #[test]
    fn test_export_detection_python() {
        let code = r#"
__all__ = ['public_func', 'PublicClass']

def public_func():
    pass

def _private_func():
    pass

class PublicClass:
    pass
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(code, &path).expect("should parse exports");

        let public = result
            .functions
            .iter()
            .find(|f| f.name == "public_func")
            .unwrap();
        assert!(
            public.annotations.iter().any(|a| a == "exported"),
            "public_func should be exported, annotations: {:?}",
            public.annotations
        );

        let private = result
            .functions
            .iter()
            .find(|f| f.name == "_private_func")
            .unwrap();
        assert!(
            !private.annotations.iter().any(|a| a == "exported"),
            "_private_func should NOT be exported"
        );

        let public_class = result
            .classes
            .iter()
            .find(|c| c.name == "PublicClass")
            .unwrap();
        assert!(
            public_class.annotations.iter().any(|a| a == "exported"),
            "PublicClass should be exported, annotations: {:?}",
            public_class.annotations
        );
    }

    #[test]
    fn test_export_detection_python_no_all() {
        // When __all__ is not defined, non-underscore module-level names are exported
        let code = r#"
def public_func():
    pass

def _private_func():
    pass

class PublicClass:
    pass

class _PrivateClass:
    pass
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(code, &path).expect("should parse exports without __all__");

        let public = result
            .functions
            .iter()
            .find(|f| f.name == "public_func")
            .unwrap();
        assert!(
            public.annotations.iter().any(|a| a == "exported"),
            "public_func should be exported (no __all__), annotations: {:?}",
            public.annotations
        );

        let private = result
            .functions
            .iter()
            .find(|f| f.name == "_private_func")
            .unwrap();
        assert!(
            !private.annotations.iter().any(|a| a == "exported"),
            "_private_func should NOT be exported"
        );

        let public_class = result
            .classes
            .iter()
            .find(|c| c.name == "PublicClass")
            .unwrap();
        assert!(
            public_class.annotations.iter().any(|a| a == "exported"),
            "PublicClass should be exported (no __all__), annotations: {:?}",
            public_class.annotations
        );

        let private_class = result
            .classes
            .iter()
            .find(|c| c.name == "_PrivateClass")
            .unwrap();
        assert!(
            !private_class.annotations.iter().any(|a| a == "exported"),
            "_PrivateClass should NOT be exported"
        );
    }

    #[test]
    fn test_decorator_extraction() {
        let code = r#"
@app.route('/users')
def get_users():
    return []

@login_required
@cache(timeout=300)
def admin_page():
    pass

class MyModel:
    pass

@dataclass
class UserDTO:
    name: str
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(code, &path).expect("should parse decorators");

        // get_users should have annotation "app.route"
        let get_users = result
            .functions
            .iter()
            .find(|f| f.name == "get_users")
            .unwrap();
        assert!(
            get_users
                .annotations
                .iter()
                .any(|a| a.contains("app.route")),
            "get_users should have app.route annotation, got: {:?}",
            get_users.annotations
        );

        // admin_page should have two annotations
        let admin = result
            .functions
            .iter()
            .find(|f| f.name == "admin_page")
            .unwrap();
        assert!(
            admin.annotations.len() >= 2,
            "admin_page should have 2+ annotations, got: {:?}",
            admin.annotations
        );

        // MyModel should have no decorator annotations (only "exported")
        let my_model = result
            .classes
            .iter()
            .find(|c| c.name == "MyModel")
            .unwrap();
        assert!(
            my_model
                .annotations
                .iter()
                .all(|a| a == "exported"),
            "MyModel should only have 'exported' annotation (no decorators), got: {:?}",
            my_model.annotations
        );

        // UserDTO should have @dataclass annotation
        let user_dto = result
            .classes
            .iter()
            .find(|c| c.name == "UserDTO")
            .unwrap();
        assert!(
            user_dto
                .annotations
                .iter()
                .any(|a| a.contains("dataclass")),
            "UserDTO should have dataclass annotation, got: {:?}",
            user_dto.annotations
        );
    }

    #[test]
    fn test_class_methods_as_function_entries() {
        let source = r#"
class MyClass:
    def __init__(self, value):
        self._value = value

    def process(self, data):
        return data * self._value

    async def fetch(self, url):
        return await http.get(url)
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse class methods");

        // Methods should appear in result.functions
        let method_names: Vec<&str> = result.functions.iter().map(|f| f.name.as_str()).collect();
        assert!(
            method_names.contains(&"__init__"),
            "missing __init__, got: {:?}",
            method_names
        );
        assert!(
            method_names.contains(&"process"),
            "missing process, got: {:?}",
            method_names
        );
        assert!(
            method_names.contains(&"fetch"),
            "missing fetch, got: {:?}",
            method_names
        );

        // Check qualified name format: path::ClassName.method:line
        let init = result
            .functions
            .iter()
            .find(|f| f.name == "__init__")
            .unwrap();
        assert!(
            init.qualified_name.contains("MyClass.__init__"),
            "expected ClassName.method format, got: {}",
            init.qualified_name
        );

        // Check async detection
        let fetch = result
            .functions
            .iter()
            .find(|f| f.name == "fetch")
            .unwrap();
        assert!(fetch.is_async, "fetch should be async");

        // Check parameters include self
        assert!(init.parameters.contains(&"self".to_string()));
        assert!(init.parameters.contains(&"value".to_string()));
    }

    #[test]
    fn test_decorated_class_methods_as_function_entries() {
        let source = r#"
class MyView:
    @property
    def value(self):
        return self._value

    @staticmethod
    def create():
        return MyView()

    @app.route('/api')
    async def handle(self):
        pass
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse decorated methods");

        let value = result
            .functions
            .iter()
            .find(|f| f.name == "value")
            .unwrap();
        assert!(
            value.annotations.iter().any(|a| a == "property"),
            "value should have @property, got: {:?}",
            value.annotations
        );

        let create = result
            .functions
            .iter()
            .find(|f| f.name == "create")
            .unwrap();
        assert!(
            create.annotations.iter().any(|a| a == "staticmethod"),
            "create should have @staticmethod, got: {:?}",
            create.annotations
        );

        let handle = result
            .functions
            .iter()
            .find(|f| f.name == "handle")
            .unwrap();
        assert!(handle.is_async, "handle should be async");
        assert!(
            handle.annotations.iter().any(|a| a.contains("app.route")),
            "handle should have @app.route, got: {:?}",
            handle.annotations
        );
    }

    #[test]
    fn test_class_methods_not_individually_exported() {
        let source = r#"
__all__ = ['MyClass']

class MyClass:
    def process(self):
        pass

    def _internal(self):
        pass
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse");

        // Class methods should NOT be marked as exported individually
        let process = result
            .functions
            .iter()
            .find(|f| f.name == "process")
            .unwrap();
        assert!(
            !process.annotations.iter().any(|a| a == "exported"),
            "class method 'process' should not be individually exported, got: {:?}",
            process.annotations
        );
    }

    #[test]
    fn test_class_methods_have_complexity() {
        let source = r#"
class Handler:
    def handle(self, request):
        if request.method == "GET":
            if request.user:
                return self.get(request)
            else:
                return self.unauthorized()
        elif request.method == "POST":
            return self.post(request)
        return self.not_found()
"#;
        let path = PathBuf::from("test.py");
        let result = parse_source(source, &path).expect("should parse");

        let handle = result
            .functions
            .iter()
            .find(|f| f.name == "handle")
            .unwrap();
        let complexity = handle.complexity.expect("method should have complexity");
        // Base(1) + if(1) + if(1) + elif(1) = 4 minimum
        assert!(
            complexity >= 4,
            "handle should have complexity >= 4, got: {}",
            complexity
        );
    }
}