repotoire 0.3.112

Graph-powered code analysis CLI. 114 detectors for security, architecture, and code quality.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88

use crate::detectors::base::Detector;
use crate::models::{deterministic_finding_id, Finding, Severity};
use anyhow::Result;
use std::path::PathBuf;
use tracing::info;

use super::mutex_unwrap;

pub struct MutexPoisoningRiskDetector {
    repository_path: PathBuf,
    max_findings: usize,
}

impl MutexPoisoningRiskDetector {
    pub fn new(repository_path: impl Into<PathBuf>) -> Self {
        Self {
            repository_path: repository_path.into(),
            max_findings: 50,
        }
    }
}

impl Detector for MutexPoisoningRiskDetector {
    fn name(&self) -> &'static str { "rust-mutex-poisoning-risk" }
    fn description(&self) -> &'static str { "Detects Mutex poisoning risks from panic-prone lock handling" }

    fn detect(&self, _graph: &dyn crate::graph::GraphQuery) -> Result<Vec<Finding>> {
        let mut findings = vec![];
        let walker = ignore::WalkBuilder::new(&self.repository_path)
            .hidden(false).git_ignore(true).build();

        for entry in walker.filter_map(|e| e.ok()) {
            if findings.len() >= self.max_findings { break; }
            let path = entry.path();
            if !path.is_file() { continue; }
            if path.extension().and_then(|e| e.to_str()) != Some("rs") { continue; }

            let Some(content) = crate::cache::global_cache().get_content(path) else { continue };
            let mut in_test_module = false;

            for (i, line) in content.lines().enumerate() {
                if line.contains("#[cfg(test)]") { in_test_module = true; }
                if in_test_module { continue; }

                let trimmed = line.trim();
                if trimmed.starts_with("//") || trimmed.starts_with('"') || trimmed.starts_with("r#\"") {
                    continue;
                }

                // Skip lines where the pattern appears inside a string literal
                if trimmed.ends_with('\\')
                    || trimmed.ends_with(".to_string(),")
                    || trimmed.ends_with(".to_string()")
                    || (trimmed.contains('"') && trimmed.contains(".lock()"))
                {
                    continue;
                }

                if !mutex_unwrap().is_match(line) { continue; }

                let file_str = path.to_string_lossy();
                let line_num = (i + 1) as u32;
                findings.push(Finding {
                    id: deterministic_finding_id("MutexPoisoningRiskDetector", &file_str, line_num, "mutex lock unwrap"),
                    detector: "MutexPoisoningRiskDetector".to_string(),
                    severity: Severity::Medium,
                    title: "Mutex poisoning risk".to_string(),
                    description: "Using .lock().unwrap() will panic if the mutex is poisoned. \
                        Consider handling the PoisonError or using parking_lot::Mutex.".to_string(),
                    affected_files: vec![path.to_path_buf()],
                    line_start: Some(line_num),
                    line_end: Some(line_num),
                    suggested_fix: Some(
                        "Handle poisoning: `mutex.lock().unwrap_or_else(|e| e.into_inner())`\n\
                        Or use `parking_lot::Mutex` which has no poisoning.".to_string()
                    ),
                    estimated_effort: Some("15 minutes".to_string()),
                    category: Some("reliability".to_string()),
                    cwe_id: Some("CWE-667".to_string()),
                    why_it_matters: Some("Poisoned mutexes cause cascading panics across threads.".to_string()),
                    ..Default::default()
                });
            }
        }
        info!("MutexPoisoningRiskDetector found {} findings", findings.len());
        Ok(findings)
    }
}