reovim-server 0.14.4

Reovim server - the editing engine
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
use super::*;

fn test_registry() -> Arc<SessionRegistry> {
    let (registry, _) = test_registry_with_session();
    registry
}

/// Create a registry with a session and return both.
/// This allows tests to add clients to the session.
fn test_registry_with_session() -> (Arc<SessionRegistry>, Arc<Session>) {
    let registry = Arc::new(SessionRegistry::new());
    let session = Arc::new(Session::new(SessionId::new("test")));
    registry.insert(&session);
    (registry, session)
}

/// Create a registry with a session that has a real buffer manager.
fn test_registry_with_buffer_manager() -> (Arc<SessionRegistry>, Arc<Session>) {
    use {
        parking_lot::RwLock as ParkingLotRwLock,
        reovim_driver_buffer::TestBufferManager,
        reovim_kernel::api::v1::{
            EventBus, KernelContext, MarkBank, MotionEngine, OptionRegistry, ServiceRegistry,
            TextObjectEngine,
        },
    };

    // Create a KernelContext with a real buffer manager
    let kernel = KernelContext::new(
        Arc::new(EventBus::new()),
        Arc::new(TestBufferManager::new()),
        Arc::new(MotionEngine),
        Arc::new(TextObjectEngine),
        Arc::new(ParkingLotRwLock::new(MarkBank::new())),
        Arc::new(OptionRegistry::new()),
        Arc::new(ServiceRegistry::new()),
    );

    let state = crate::session::SessionState::with_kernel(kernel);
    let session = Arc::new(Session::from_state(SessionId::new("test"), state));

    let registry = Arc::new(SessionRegistry::new());
    registry.insert(&session);

    (registry, session)
}

/// Helper: build a request with token-authenticated `ClientId` in extensions.
fn authed_request<T>(body: T, client_id: ClientId) -> Request<T> {
    let mut request = Request::new(body);
    request.extensions_mut().insert(client_id);
    request
}

#[tokio::test]
async fn test_get_mode_returns_current_mode() {
    let (registry, session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    // Create a client first (client_id=1)
    session.add_client(ClientId::new(1));

    let request = authed_request(GetModeRequest { client_id: 1 }, ClientId::new(1));
    let response = service.get_mode(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    // Default mode is "normal" from SessionState::default()
    assert_eq!(resp.name, "normal");
    assert_eq!(resp.display, "NORMAL");
    assert!(!resp.is_insert);
}

#[tokio::test]
async fn test_get_mode_rejects_unauthenticated() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // No token in extensions → Unauthenticated (#483)
    let request = Request::new(GetModeRequest { client_id: 0 });
    let response = service.get_mode(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::Unauthenticated);
}

#[tokio::test]
async fn test_get_mode_unknown_client_returns_not_found() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // Non-existent client should return NotFound
    // Authenticated as client 999, targeting self (client_id=999 in body)
    let request = authed_request(GetModeRequest { client_id: 999 }, ClientId::new(999));
    let response = service.get_mode(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_cursor_rejects_unauthenticated() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // No token in extensions → Unauthenticated (#483)
    let request = Request::new(GetCursorRequest {
        window_id: None,
        client_id: 0,
    });
    let response = service.get_cursor(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::Unauthenticated);
}

#[tokio::test]
async fn test_get_cursor_no_active_window() {
    let (registry, session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    // Create a client but don't add any windows
    session.add_client(ClientId::new(1));

    let request = authed_request(
        GetCursorRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_cursor(request).await;

    // Client exists but no active window = NotFound
    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_cursor_with_buffer() {
    let (registry, session) = test_registry_with_buffer_manager();

    // Create a buffer using the real buffer manager
    session
        .with_state_mut(|state| {
            state.create_buffer("hello world");
        })
        .await;

    // Create a client - this initializes per-client state with initial window
    session.add_client(ClientId::new(1));

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetCursorRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_cursor(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert!(resp.position.is_some());
    let pos = resp.position.unwrap();
    assert_eq!(pos.line, 0);
    assert_eq!(pos.column, 0);
}

#[tokio::test]
async fn test_get_options_returns_ok() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = Request::new(GetOptionsRequest { names: vec![] });
    let response = service.get_options(request).await;

    assert!(response.is_ok());
}

#[tokio::test]
async fn test_get_layout_rejects_unauthenticated() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // No token in extensions → Unauthenticated (#483)
    let request = Request::new(GetLayoutRequest { client_id: 0 });
    let response = service.get_layout(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::Unauthenticated);
}

#[tokio::test]
async fn test_get_layout_empty() {
    // Session with a client but no windows
    let (registry, session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    // Create a client
    session.add_client(ClientId::new(1));

    let request = authed_request(GetLayoutRequest { client_id: 1 }, ClientId::new(1));
    let response = service.get_layout(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    // Empty layout: no root node
    assert!(resp.root.is_none());
    assert_eq!(resp.focused_window_id, None);
}

#[tokio::test]
async fn test_get_layout_single_window() {
    let (registry, session) = test_registry_with_buffer_manager();

    // Create a buffer (active buffer is set in SessionShared)
    session
        .with_state_mut(|state| {
            let _buffer_id = state.create_buffer("hello world");
        })
        .await;

    // Create a client - this creates per-client windows in EditingState (#491)
    // The client will have a window with the active buffer
    session.add_client(ClientId::new(1));

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(GetLayoutRequest { client_id: 1 }, ClientId::new(1));
    let response = service.get_layout(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();

    // Should have a root node (single leaf) from per-client state
    assert!(resp.root.is_some());
    let root = resp.root.unwrap();

    // Check it's a leaf with default viewport dimensions
    match root.node {
        Some(reovim_protocol::v2::window_node::Node::Leaf(leaf)) => {
            // Default viewport is 80x24
            assert_eq!(leaf.rect.as_ref().unwrap().width, 80);
            assert_eq!(leaf.rect.as_ref().unwrap().height, 24);
        }
        _ => panic!("Expected a leaf node"),
    }
}

#[tokio::test]
async fn test_get_visible_lines_rejects_unauthenticated() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // No token in extensions → Unauthenticated (#483)
    let request = Request::new(GetVisibleLinesRequest {
        window_id: None,
        client_id: 0,
    });
    let response = service.get_visible_lines(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::Unauthenticated);
}

#[tokio::test]
async fn test_get_visible_lines_no_window() {
    // Session with a client but no windows
    let (registry, session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    session.add_client(ClientId::new(1));

    let request = authed_request(
        GetVisibleLinesRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_visible_lines(request).await;

    // Client exists but no window = NotFound
    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_visible_lines_with_window() {
    let (registry, session) = test_registry_with_buffer_manager();

    // Create a buffer (active buffer is set in SessionShared)
    session
        .with_state_mut(|state| {
            let _buffer_id = state.create_buffer("line0\nline1\nline2\nline3");
        })
        .await;

    // Create a client - this creates per-client windows in EditingState (#491)
    session.add_client(ClientId::new(1));

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetVisibleLinesRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_visible_lines(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();

    assert_eq!(resp.first_line, 0);
    assert_eq!(resp.last_line, 23); // scroll_top(0) + height(24) - 1
    assert_eq!(resp.viewport_height, 24);
}

#[tokio::test]
async fn test_get_visible_lines_with_scroll() {
    use reovim_driver_session::Viewport;

    let (registry, session) = test_registry_with_buffer_manager();

    // Create buffer first
    session
        .with_state_mut(|state| {
            state.create_buffer("content");
        })
        .await;

    // Create a client
    let client_id = ClientId::new(1);
    session.add_client(client_id);

    // Modify the CLIENT's per-client viewport with scroll
    session.update_client_state(client_id, |state| {
        if let Some(window) = state.windows.active_mut() {
            let mut viewport = Viewport::new(80, 24);
            viewport.scroll_top = 10; // Scrolled down 10 lines
            window.viewport = viewport;
        }
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetVisibleLinesRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_visible_lines(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();

    assert_eq!(resp.first_line, 10);
    assert_eq!(resp.last_line, 33); // scroll_top(10) + height(24) - 1
    assert_eq!(resp.viewport_height, 24);
}

#[tokio::test]
async fn test_get_mode_no_session() {
    let registry = Arc::new(SessionRegistry::new());
    let service = StateServiceImpl::new(registry, SessionId::new("nonexistent"));

    let request = Request::new(GetModeRequest { client_id: 0 });
    let response = service.get_mode(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_registers_empty() {
    let (registry, session) = test_registry_with_session();
    session.add_client(ClientId::new(1));
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetRegistersRequest {
            names: vec![],
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_registers(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    // Empty by default
    assert!(resp.registers.is_empty());
}

#[tokio::test]
async fn test_get_registers_with_content() {
    use reovim_kernel::api::v1::RegisterContent;

    let (registry, session) = test_registry_with_buffer_manager();
    session.add_client(ClientId::new(1));

    // Set a register on the per-client state (#515)
    session.update_client_state(ClientId::new(1), |state| {
        state.registers.set(RegisterContent::characterwise("hello"));
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetRegistersRequest {
            names: vec![],
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_registers(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert_eq!(resp.registers.len(), 1);
    assert_eq!(resp.registers[0].name, "\"");
    assert_eq!(resp.registers[0].content, "hello");
    assert_eq!(resp.registers[0].yank_type, "char");
}

#[tokio::test]
async fn test_get_registers_specific_register() {
    use reovim_kernel::api::v1::RegisterContent;

    let (registry, session) = test_registry_with_buffer_manager();
    session.add_client(ClientId::new(1));

    // Set multiple registers on per-client state (#515)
    session.update_client_state(ClientId::new(1), |state| {
        state
            .registers
            .set(RegisterContent::characterwise("unnamed"));
        state
            .registers
            .set_named('a', RegisterContent::linewise("alpha"));
        state
            .registers
            .set_named('b', RegisterContent::characterwise("beta"));
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // Query only register 'a'
    let request = authed_request(
        GetRegistersRequest {
            names: vec!["a".to_string()],
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_registers(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert_eq!(resp.registers.len(), 1);
    assert_eq!(resp.registers[0].name, "a");
    assert_eq!(resp.registers[0].content, "alpha");
    assert_eq!(resp.registers[0].yank_type, "line");
}

// Phase 9.1: GetSelection RPC tests

#[tokio::test]
async fn test_get_selection_rejects_unauthenticated() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // No token in extensions → Unauthenticated (#483)
    let request = Request::new(GetSelectionRequest {
        window_id: None,
        client_id: 0,
    });
    let response = service.get_selection(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::Unauthenticated);
}

#[tokio::test]
async fn test_get_selection_no_selection() {
    let (registry, session) = test_registry_with_buffer_manager();

    // Create a buffer but don't start selection
    session
        .with_state_mut(|state| {
            state.create_buffer("hello world");
        })
        .await;

    // Create a client
    session.add_client(ClientId::new(1));

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetSelectionRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_selection(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert!(!resp.has_selection);
    assert!(resp.selection.is_none());
    assert!(resp.visual_mode.is_none());
}

#[tokio::test]
async fn test_get_selection_no_active_window() {
    // Session with a client but no windows
    let (registry, session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    session.add_client(ClientId::new(1));

    let request = authed_request(
        GetSelectionRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_selection(request).await;

    // Client exists but no active window = NotFound
    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_selection_with_char_selection() {
    use {
        reovim_driver_session::{Viewport, api::Selection},
        reovim_kernel::api::v1::Position as KernelPosition,
    };

    let (registry, session) = test_registry_with_buffer_manager();

    // Create buffer first
    session
        .with_state_mut(|state| {
            state.create_buffer("hello world");
        })
        .await;

    // Create a client - this initializes per-client state
    let client_id = ClientId::new(1);
    session.add_client(client_id);

    // Modify the CLIENT's per-client state (not shared state)
    session.update_client_state(client_id, |state| {
        if let Some(window) = state.windows.active_mut() {
            window.viewport = Viewport::new(80, 24);
            // Set selection for "hello" (0,0 to 0,5 exclusive)
            window.selection =
                Some(Selection::character(KernelPosition::new(0, 0), KernelPosition::new(0, 5)));
        }
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetSelectionRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_selection(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert!(resp.has_selection);
    assert!(resp.selection.is_some());

    let sel = resp.selection.unwrap();
    assert_eq!(sel.start.as_ref().unwrap().line, 0);
    assert_eq!(sel.start.as_ref().unwrap().column, 0);
    assert_eq!(sel.end.as_ref().unwrap().line, 0);
    assert_eq!(sel.end.as_ref().unwrap().column, 5); // exclusive end
    assert_eq!(resp.visual_mode, Some("char".to_string()));
}

#[tokio::test]
async fn test_get_selection_line_mode() {
    use {
        reovim_driver_session::{Viewport, api::Selection},
        reovim_kernel::api::v1::Position as KernelPosition,
    };

    let (registry, session) = test_registry_with_buffer_manager();

    // Create buffer first
    session
        .with_state_mut(|state| {
            state.create_buffer("line1\nline2\nline3");
        })
        .await;

    // Create a client
    let client_id = ClientId::new(1);
    session.add_client(client_id);

    // Modify the CLIENT's per-client state
    session.update_client_state(client_id, |state| {
        if let Some(window) = state.windows.active_mut() {
            window.viewport = Viewport::new(80, 24);
            // Line-wise selection for lines 0-1
            window.selection = Some(Selection::line(
                KernelPosition::new(0, 0),
                KernelPosition::new(2, 0), // exclusive end
            ));
        }
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetSelectionRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_selection(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert!(resp.has_selection);
    assert_eq!(resp.visual_mode, Some("line".to_string()));
}

#[tokio::test]
async fn test_get_selection_block_mode() {
    use {
        reovim_driver_session::{Viewport, api::Selection},
        reovim_kernel::api::v1::Position as KernelPosition,
    };

    let (registry, session) = test_registry_with_buffer_manager();

    // Create buffer first
    session
        .with_state_mut(|state| {
            state.create_buffer("ABC\nDEF\nGHI");
        })
        .await;

    // Create a client
    let client_id = ClientId::new(1);
    session.add_client(client_id);

    // Modify the CLIENT's per-client state
    session.update_client_state(client_id, |state| {
        if let Some(window) = state.windows.active_mut() {
            window.viewport = Viewport::new(80, 24);
            // Block selection from (0,0) to (1,2) - a 2x2 block
            window.selection = Some(Selection::block(
                KernelPosition::new(0, 0),
                KernelPosition::new(2, 2), // exclusive end
            ));
        }
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetSelectionRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_selection(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert!(resp.has_selection);
    assert_eq!(resp.visual_mode, Some("block".to_string()));
}

#[tokio::test]
async fn test_get_selection_reverse() {
    use {
        reovim_driver_session::{Viewport, api::Selection},
        reovim_kernel::api::v1::Position as KernelPosition,
    };

    let (registry, session) = test_registry_with_buffer_manager();

    // Create buffer first
    session
        .with_state_mut(|state| {
            state.create_buffer("hello world");
        })
        .await;

    // Create a client
    let client_id = ClientId::new(1);
    session.add_client(client_id);

    // Modify the CLIENT's per-client state
    session.update_client_state(client_id, |state| {
        if let Some(window) = state.windows.active_mut() {
            window.viewport = Viewport::new(80, 24);
            // Selection from column 2 to column 5 (already normalized)
            window.selection =
                Some(Selection::character(KernelPosition::new(0, 2), KernelPosition::new(0, 5)));
        }
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetSelectionRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_selection(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert!(resp.has_selection);

    let sel = resp.selection.unwrap();
    // start should be normalized (smaller position comes first)
    assert!(sel.start.as_ref().unwrap().column < sel.end.as_ref().unwrap().column);
    assert_eq!(sel.start.as_ref().unwrap().column, 2);
    assert_eq!(sel.end.as_ref().unwrap().column, 5);
}

// Per-client state (#471): Per-client mode isolation tests

#[tokio::test]
async fn test_get_mode_per_client_returns_client_mode() {
    use reovim_kernel::api::v1::{ModeId, ModuleId};

    let (registry, session) = test_registry_with_buffer_manager();

    // Add a client with custom mode stack
    let client_id = crate::session::ClientId::new(42);
    session.add_client(client_id);

    // Modify the client's per-client mode stack to INSERT mode
    let module = ModuleId::new("editor");
    session.update_client_state(client_id, |editing_state| {
        editing_state
            .mode_stack
            .push(ModeId::new(module.clone(), "insert"));
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // Query with client_id = 42 should return INSERT mode
    let request = authed_request(GetModeRequest { client_id: 42 }, ClientId::new(42));
    let response = service.get_mode(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert_eq!(resp.name, "insert");
    assert_eq!(resp.display, "INSERT");
    assert!(resp.is_insert);
}

// Note: test_get_mode_unknown_client_falls_back_to_shared was REMOVED in Phase #479.
// Unknown clients now return NotFound error (see test_get_mode_unknown_client_returns_not_found).
// client_id=0 now returns InvalidArgument (see test_get_mode_rejects_client_id_zero).

// =========================================================================
// Phase #471: Multi-Client Isolation Tests
// =========================================================================

#[tokio::test]
async fn test_cursor_isolation_between_clients() {
    use reovim_driver_session::CursorPosition;

    let (registry, session) = test_registry_with_buffer_manager();

    // Create buffer first
    session
        .with_state_mut(|state| {
            state.create_buffer("line1\nline2\nline3\nline4\nline5");
        })
        .await;

    // Create two clients
    let client_a = crate::session::ClientId::new(1);
    let client_b = crate::session::ClientId::new(2);
    session.add_client(client_a);
    session.add_client(client_b);

    // Client A moves cursor to (3, 5)
    session.update_client_state(client_a, |state| {
        if let Some(window) = state.windows.active_mut() {
            window.cursor = CursorPosition { line: 3, column: 5 };
        }
    });

    // Client B's cursor should still be at default (0, 0)
    let state_b = session.client_state(client_b).unwrap();
    let cursor_b = state_b.windows.active().unwrap().cursor;
    assert_eq!(cursor_b.line, 0, "Client B cursor line should be 0");
    assert_eq!(cursor_b.column, 0, "Client B cursor column should be 0");

    // Verify via gRPC service
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // Query Client A's cursor
    let request = authed_request(
        GetCursorRequest {
            window_id: None,
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_cursor(request).await.unwrap().into_inner();
    let pos = response.position.unwrap();
    assert_eq!(pos.line, 3, "Client A gRPC cursor line");
    assert_eq!(pos.column, 5, "Client A gRPC cursor column");

    // Query Client B's cursor - should be independent
    let request = authed_request(
        GetCursorRequest {
            window_id: None,
            client_id: 2,
        },
        ClientId::new(2),
    );
    let response = service.get_cursor(request).await.unwrap().into_inner();
    let pos = response.position.unwrap();
    assert_eq!(pos.line, 0, "Client B gRPC cursor line");
    assert_eq!(pos.column, 0, "Client B gRPC cursor column");
}

#[tokio::test]
async fn test_mode_isolation_between_clients() {
    use reovim_kernel::api::v1::{ModeId, ModuleId};

    let (registry, session) = test_registry_with_buffer_manager();

    // Create two clients
    let client_a = crate::session::ClientId::new(10);
    let client_b = crate::session::ClientId::new(20);
    session.add_client(client_a);
    session.add_client(client_b);

    // Client A enters INSERT mode
    let module = ModuleId::new("editor");
    session.update_client_state(client_a, |state| {
        state.mode_stack.push(ModeId::new(module.clone(), "insert"));
    });

    // Client B should still be in NORMAL mode (not affected by A)
    let mode_b = session.client_current_mode(client_b).unwrap();
    assert_eq!(mode_b.name(), "normal", "Client B should remain in normal mode");

    // Verify via gRPC service
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // Query Client A's mode - should be INSERT
    let request = authed_request(GetModeRequest { client_id: 10 }, ClientId::new(10));
    let response = service.get_mode(request).await.unwrap().into_inner();
    assert_eq!(response.name, "insert", "Client A gRPC mode");
    assert!(response.is_insert, "Client A should be in insert mode");

    // Query Client B's mode - should still be NORMAL
    let request = authed_request(GetModeRequest { client_id: 20 }, ClientId::new(20));
    let response = service.get_mode(request).await.unwrap().into_inner();
    assert_eq!(response.name, "normal", "Client B gRPC mode");
    assert!(!response.is_insert, "Client B should NOT be in insert mode");
}

#[tokio::test]
async fn test_layout_isolation_per_client() {
    use reovim_driver_session::Viewport;

    let (registry, session) = test_registry_with_buffer_manager();

    // Create buffer first
    session
        .with_state_mut(|state| {
            state.create_buffer("test content");
        })
        .await;

    // Create a client
    let client_a = crate::session::ClientId::new(100);
    session.add_client(client_a);

    // Modify client's window viewport
    session.update_client_state(client_a, |state| {
        if let Some(window) = state.windows.active_mut() {
            window.viewport = Viewport::new(120, 40);
        }
    });

    // Verify via gRPC with client_id
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(GetLayoutRequest { client_id: 100 }, ClientId::new(100));
    let response = service.get_layout(request).await.unwrap().into_inner();

    // Should get per-client layout with the modified viewport
    assert!(response.root.is_some(), "Should have a root node");
    if let Some(node) = response.root
        && let Some(Node::Leaf(leaf)) = node.node
        && let Some(rect) = leaf.rect
    {
        assert_eq!(rect.width, 120, "Per-client window width");
        assert_eq!(rect.height, 40, "Per-client window height");
    } else {
        panic!("Expected a leaf node with rect");
    }
}

#[tokio::test]
async fn test_get_visible_lines_with_specific_window_id() {
    let (registry, session) = test_registry_with_buffer_manager();

    session
        .with_state_mut(|state| {
            state.create_buffer("line0\nline1\nline2");
        })
        .await;

    let client_id = ClientId::new(1);
    session.add_client(client_id);

    // Get the window id from client state
    let window_id = session
        .client_state(client_id)
        .unwrap()
        .windows
        .active()
        .unwrap()
        .id
        .as_usize() as u64;

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetVisibleLinesRequest {
            window_id: Some(window_id),
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_visible_lines(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert_eq!(resp.window_id, window_id);
    assert_eq!(resp.first_line, 0);
}

#[tokio::test]
async fn test_get_visible_lines_with_invalid_window_id() {
    let (registry, session) = test_registry_with_buffer_manager();

    session
        .with_state_mut(|state| {
            state.create_buffer("content");
        })
        .await;

    let client_id = ClientId::new(1);
    session.add_client(client_id);

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetVisibleLinesRequest {
            window_id: Some(99999), // Non-existent window
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_visible_lines(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_layout_multi_window() {
    use reovim_driver_session::Window;

    let (registry, session) = test_registry_with_buffer_manager();

    session
        .with_state_mut(|state| {
            state.create_buffer("content");
        })
        .await;

    let client_id = ClientId::new(1);
    session.add_client(client_id);

    // Add a second window to the client
    let buffer_id2 = reovim_kernel::api::v1::BufferId::from_raw(99);
    session.update_client_state(client_id, |state| {
        let window2 = Window::with_buffer(buffer_id2);
        state.windows.add(window2);
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(GetLayoutRequest { client_id: 1 }, ClientId::new(1));
    let response = service.get_layout(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();

    // Should have a root node wrapping N>1 windows in a split
    assert!(resp.root.is_some());
    let root = resp.root.unwrap();
    match root.node {
        Some(Node::Split(split)) => {
            assert_eq!(split.direction, SplitDirection::Vertical as i32);
            assert_eq!(split.children.len(), 2);
        }
        _ => panic!("Expected split node for multi-window layout"),
    }
}

#[tokio::test]
async fn test_submit_capture_response() {
    let registry = test_registry();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    // Create a pending capture
    let session = registry.get(&SessionId::new("test")).unwrap();
    let (request_id, _rx) = session.capture_tracker().create_pending();

    let req = Request::new(SubmitCaptureRequest {
        request_id,
        width: 80,
        height: 24,
        format: "plain_text".to_string(),
        content: "Hello World".to_string(),
    });

    let response = service.submit_capture_response(req).await;
    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert!(resp.ok);
}

#[tokio::test]
async fn test_submit_capture_response_no_pending() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // Submit without a pending request
    let req = Request::new(SubmitCaptureRequest {
        request_id: 99999, // No such pending
        width: 80,
        height: 24,
        format: "plain_text".to_string(),
        content: "data".to_string(),
    });

    let response = service.submit_capture_response(req).await;
    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert!(!resp.ok); // No pending request to deliver to
}

#[tokio::test]
async fn test_get_registers_specific_nonexistent_register() {
    let (registry, session) = test_registry_with_session();
    session.add_client(ClientId::new(1));
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetRegistersRequest {
            names: vec!["z".to_string()],
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_registers(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    // Register 'z' doesn't exist so should be empty
    assert!(resp.registers.is_empty());
}

#[tokio::test]
async fn test_get_registers_linewise() {
    use reovim_kernel::api::v1::RegisterContent;

    let (registry, session) = test_registry_with_buffer_manager();
    session.add_client(ClientId::new(1));

    // Set register on per-client state (#515)
    session.update_client_state(ClientId::new(1), |state| {
        state
            .registers
            .set(RegisterContent::linewise("line content\n"));
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetRegistersRequest {
            names: vec![],
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_registers(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert_eq!(resp.registers.len(), 1);
    assert_eq!(resp.registers[0].yank_type, "line");
}

#[tokio::test]
async fn test_get_screen_content_invalid_format() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = Request::new(GetScreenContentRequest {
        format: "invalid_format".to_string(),
        client_id: 0,
    });
    let response = service.get_screen_content(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::InvalidArgument);
}

// Removed duplicate test_get_cursor_unknown_client — replaced by
// test_get_cursor_dangling_follower_not_found which also covers the
// ring buffer logging callback path.

#[tokio::test]
async fn test_get_layout_unknown_client() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(GetLayoutRequest { client_id: 999 }, ClientId::new(999));
    let response = service.get_layout(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_visible_lines_unknown_client() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetVisibleLinesRequest {
            window_id: None,
            client_id: 999,
        },
        ClientId::new(999),
    );
    let response = service.get_visible_lines(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_selection_unknown_client() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetSelectionRequest {
            window_id: None,
            client_id: 999,
        },
        ClientId::new(999),
    );
    let response = service.get_selection(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

// =========================================================================
// Coverage: Ring buffer logging for unknown clients (#497)
// =========================================================================

#[tokio::test]
async fn test_get_mode_following_client_triggers_ring_buffer_log() {
    // A Following client returns None from client_current_mode, which triggers
    // the ok_or_else closure that logs to the ring buffer (lines 109-115).
    use crate::session::ClientRelation;

    let (registry, session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    let owner_id = ClientId::new(1);
    let follower_id = ClientId::new(2);
    session.add_client(owner_id);
    session.add_client(follower_id);

    let _ = session
        .set_client_relation(follower_id, Some(ClientRelation::Following { target: owner_id }));

    // Following client -> client_current_mode returns None -> NotFound with ring buffer log
    let request = authed_request(GetModeRequest { client_id: 2 }, ClientId::new(2));
    let response = service.get_mode(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_cursor_following_client_triggers_ring_buffer_log() {
    // A Following client returns None from client_state, triggering
    // the ok_or_else closure with ring buffer logging (lines 153-159).
    use crate::session::ClientRelation;

    let (registry, session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    let owner_id = ClientId::new(1);
    let follower_id = ClientId::new(2);
    session.add_client(owner_id);
    session.add_client(follower_id);

    let _ = session
        .set_client_relation(follower_id, Some(ClientRelation::Following { target: owner_id }));

    // Note: client_state for Following returns target's state, so we need a case
    // where it actually fails. Use an unknown client ID that has a ring buffer.
    // Actually, Following clients DO return effective state from target.
    // So let's use a client that IS registered but has some state issue.
    // The real trigger is when client_state returns None, which happens when
    // the client is not found at all. But we want ring buffer log which requires
    // the client to exist.
    //
    // In practice, client_state returns None only when the client is not found.
    // The ring buffer log is best-effort (logs if client has ring buffer).
    // We just need the NotFound path.
    let request = authed_request(
        GetCursorRequest {
            window_id: None,
            client_id: 999,
        },
        ClientId::new(999),
    );
    let response = service.get_cursor(request).await;
    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_layout_following_client_not_found_logs() {
    // Test the ring buffer logging path in get_layout (lines 225-231).
    let (registry, session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    // Add a client so it exists (and has a ring buffer) but query different ID
    session.add_client(ClientId::new(1));

    let request = authed_request(GetLayoutRequest { client_id: 888 }, ClientId::new(888));
    let response = service.get_layout(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_visible_lines_client_not_found_logs() {
    // Test the ring buffer logging path in get_visible_lines (lines 306-312).
    let (registry, session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    session.add_client(ClientId::new(1));

    let request = authed_request(
        GetVisibleLinesRequest {
            window_id: None,
            client_id: 777,
        },
        ClientId::new(777),
    );
    let response = service.get_visible_lines(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_selection_client_not_found_logs() {
    // Test the ring buffer logging path in get_selection (lines 362-368).
    let (registry, session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    session.add_client(ClientId::new(1));

    let request = authed_request(
        GetSelectionRequest {
            window_id: None,
            client_id: 666,
        },
        ClientId::new(666),
    );
    let response = service.get_selection(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

// =========================================================================
// Coverage: get_screen_content capture error paths (#497)
// =========================================================================

#[test]
fn test_capture_error_to_status_all_variants() {
    use {super::capture_error_to_status, crate::session::CaptureError};

    // NoTuiClient → UNAVAILABLE
    let status = capture_error_to_status(CaptureError::NoTuiClient);
    assert_eq!(status.code(), tonic::Code::Unavailable);

    // Timeout → DEADLINE_EXCEEDED
    let status = capture_error_to_status(CaptureError::Timeout);
    assert_eq!(status.code(), tonic::Code::DeadlineExceeded);

    // Disconnected → ABORTED
    let status = capture_error_to_status(CaptureError::Disconnected);
    assert_eq!(status.code(), tonic::Code::Aborted);

    // InvalidResponse → INTERNAL
    let status = capture_error_to_status(CaptureError::InvalidResponse("bad data".into()));
    assert_eq!(status.code(), tonic::Code::Internal);
    assert!(status.message().contains("bad data"));
}

#[tokio::test]
async fn test_get_screen_content_default_format() {
    // Test the default format path (empty format -> "raw_ansi").
    // This will timeout/fail but tests the format validation path.
    let (registry, _session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    let request = Request::new(GetScreenContentRequest {
        format: String::new(), // empty -> defaults to "raw_ansi"
        client_id: 0,
    });
    // This will fail because no TUI client to deliver the capture,
    // but the format validation path is covered.
    let _response = service.get_screen_content(request).await;
    // We don't assert success because it depends on timing/capture delivery
}

#[tokio::test]
async fn test_get_screen_content_valid_formats() {
    // Test accepted format strings.
    let (registry, _session) = test_registry_with_session();
    let service = StateServiceImpl::new(Arc::clone(&registry), SessionId::new("test"));

    for format in &["plain_text", "raw_ansi", "cell_grid"] {
        let request = Request::new(GetScreenContentRequest {
            format: (*format).to_string(),
            client_id: 0,
        });
        // These will fail at capture delivery but format validation passes.
        let _response = service.get_screen_content(request).await;
    }
}

// =========================================================================
// Coverage: get_registers specific register with content (#497)
// =========================================================================

#[tokio::test]
async fn test_get_registers_specific_register_with_content() {
    // Test the specific register lookup path where
    // the register exists and has content.
    use reovim_kernel::api::v1::RegisterContent;

    let (registry, session) = test_registry_with_buffer_manager();
    session.add_client(ClientId::new(1));

    // Set a named register on per-client state (#515)
    session.update_client_state(ClientId::new(1), |state| {
        state
            .registers
            .set_named('a', RegisterContent::characterwise("hello world"));
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // Query register 'a' by name
    let request = authed_request(
        GetRegistersRequest {
            names: vec!["a".to_string()],
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_registers(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert_eq!(resp.registers.len(), 1);
    assert_eq!(resp.registers[0].name, "a");
    assert_eq!(resp.registers[0].content, "hello world");
    assert_eq!(resp.registers[0].yank_type, "char");
}

#[tokio::test]
async fn test_get_registers_specific_linewise_register() {
    // Test the linewise yank_type path in specific register lookup.
    use reovim_kernel::api::v1::RegisterContent;

    let (registry, session) = test_registry_with_buffer_manager();
    session.add_client(ClientId::new(1));

    session.update_client_state(ClientId::new(1), |state| {
        state
            .registers
            .set_named('b', RegisterContent::linewise("a full line\n"));
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetRegistersRequest {
            names: vec!["b".to_string()],
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_registers(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    assert_eq!(resp.registers.len(), 1);
    assert_eq!(resp.registers[0].yank_type, "line");
}

#[tokio::test]
async fn test_get_registers_multiple_specific() {
    // Test querying multiple specific registers.
    use reovim_kernel::api::v1::RegisterContent;

    let (registry, session) = test_registry_with_buffer_manager();
    session.add_client(ClientId::new(1));

    session.update_client_state(ClientId::new(1), |state| {
        state
            .registers
            .set_named('a', RegisterContent::characterwise("alpha"));
        state
            .registers
            .set_named('b', RegisterContent::linewise("beta\n"));
        // 'c' not set
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetRegistersRequest {
            names: vec!["a".to_string(), "b".to_string(), "c".to_string()],
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_registers(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    // 'a' and 'b' should be returned, 'c' is empty/missing
    assert_eq!(resp.registers.len(), 2);
}

#[tokio::test]
async fn test_get_registers_specific_empty_register_filtered_out() {
    // Test that a register with empty content is filtered out.
    use reovim_kernel::api::v1::RegisterContent;

    let (registry, session) = test_registry_with_buffer_manager();
    session.add_client(ClientId::new(1));

    session.update_client_state(ClientId::new(1), |state| {
        state
            .registers
            .set_named('x', RegisterContent::characterwise(""));
        state
            .registers
            .set_named('y', RegisterContent::characterwise("visible"));
    });

    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetRegistersRequest {
            names: vec!["x".to_string(), "y".to_string()],
            client_id: 1,
        },
        ClientId::new(1),
    );
    let response = service.get_registers(request).await;

    assert!(response.is_ok());
    let resp = response.unwrap().into_inner();
    // 'x' is empty and should be filtered out, only 'y' returned
    assert_eq!(resp.registers.len(), 1);
    assert_eq!(resp.registers[0].name, "y");
}

#[tokio::test]
async fn test_get_registers_client_not_found() {
    let registry = test_registry();
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // Non-existent client should return NotFound
    let request = authed_request(
        GetRegistersRequest {
            client_id: 999,
            names: vec![],
        },
        ClientId::new(999),
    );
    let response = service.get_registers(request).await;

    assert!(response.is_err());
    assert_eq!(response.unwrap_err().code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_selection_isolation_per_client() {
    use {
        reovim_driver_session::{Viewport, api::Selection},
        reovim_kernel::api::v1::Position as KernelPosition,
    };

    let (registry, session) = test_registry_with_buffer_manager();

    // Create buffer first
    session
        .with_state_mut(|state| {
            state.create_buffer("hello world");
        })
        .await;

    // Create two clients
    let client_a = crate::session::ClientId::new(50);
    let client_b = crate::session::ClientId::new(60);
    session.add_client(client_a);
    session.add_client(client_b);

    // Client A has a selection
    session.update_client_state(client_a, |state| {
        if let Some(window) = state.windows.active_mut() {
            window.viewport = Viewport::new(80, 24);
            window.selection =
                Some(Selection::character(KernelPosition::new(0, 0), KernelPosition::new(0, 5)));
        }
    });

    // Client B has no selection (just viewport)
    session.update_client_state(client_b, |state| {
        if let Some(window) = state.windows.active_mut() {
            window.viewport = Viewport::new(80, 24);
            window.selection = None;
        }
    });

    // Verify via gRPC service
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    // Query Client A's selection - should have selection
    let request = authed_request(
        GetSelectionRequest {
            window_id: None,
            client_id: 50,
        },
        ClientId::new(50),
    );
    let response = service.get_selection(request).await.unwrap().into_inner();
    assert!(response.has_selection, "Client A should have selection");
    assert_eq!(response.visual_mode, Some("char".to_string()), "Client A selection mode");

    // Query Client B's selection - should have NO selection
    let request = authed_request(
        GetSelectionRequest {
            window_id: None,
            client_id: 60,
        },
        ClientId::new(60),
    );
    let response = service.get_selection(request).await.unwrap().into_inner();
    assert!(!response.has_selection, "Client B should NOT have selection");
}

// =========================================================================
// Tests: CLIENT_NOT_FOUND error paths with ring buffer logging
// Client exists in session (has ring buffer) but effective_state() returns
// None because it's Following a non-existent target.
// Covers lines 154-158, 226-230, 307-311, 363-367.
// =========================================================================

/// Create a registry with a Following client whose target doesn't exist.
/// This makes `client_state()` return None while `with_client_ring_buffer()`
/// still calls the callback (client exists in map, has ring buffer).
fn test_registry_with_dangling_follower(client_id: ClientId) -> Arc<SessionRegistry> {
    use {
        crate::session::{Client, ClientMetadata, ClientRelation},
        reovim_kernel::api::v1::{ModeId, ModeStack, ModuleId},
    };

    let (registry, session) = test_registry_with_session();
    let mode = ModeId::new(ModuleId::new("test"), "normal");
    let mode_stack = ModeStack::new(mode);
    let metadata = ClientMetadata::default();
    let mut client = Client::with_mode_stack(client_id, metadata, mode_stack);
    // Point to a non-existent target so effective_state() returns None
    client.relation = Some(ClientRelation::Following {
        target: ClientId::new(99999),
    });
    session.add_client_with_state(client);
    registry
}

#[tokio::test]
async fn test_get_cursor_dangling_follower_not_found() {
    let cid = ClientId::new(50);
    let registry = test_registry_with_dangling_follower(cid);
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetCursorRequest {
            client_id: cid.as_usize() as u64,
            window_id: None,
        },
        cid,
    );
    let err = service.get_cursor(request).await.unwrap_err();
    assert_eq!(err.code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_layout_dangling_follower_not_found() {
    let cid = ClientId::new(51);
    let registry = test_registry_with_dangling_follower(cid);
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetLayoutRequest {
            client_id: cid.as_usize() as u64,
        },
        cid,
    );
    let err = service.get_layout(request).await.unwrap_err();
    assert_eq!(err.code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_visible_lines_dangling_follower_not_found() {
    let cid = ClientId::new(52);
    let registry = test_registry_with_dangling_follower(cid);
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetVisibleLinesRequest {
            client_id: cid.as_usize() as u64,
            window_id: None,
        },
        cid,
    );
    let err = service.get_visible_lines(request).await.unwrap_err();
    assert_eq!(err.code(), tonic::Code::NotFound);
}

#[tokio::test]
async fn test_get_selection_dangling_follower_not_found() {
    let cid = ClientId::new(53);
    let registry = test_registry_with_dangling_follower(cid);
    let service = StateServiceImpl::new(registry, SessionId::new("test"));

    let request = authed_request(
        GetSelectionRequest {
            client_id: cid.as_usize() as u64,
            window_id: None,
        },
        cid,
    );
    let err = service.get_selection(request).await.unwrap_err();
    assert_eq!(err.code(), tonic::Code::NotFound);
}