renkin 0.35.0

Ultra-fast retrosynthesis engine for computer-aided synthesis planning (CASP) — pure Rust, WASM-ready, Python bindings via PyO3
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
//! Top-level integration tests for the Synthesizability Kernel
//! (`docs/design/synthesizability-kernel-v0.md`), exercising only the
//! public API (`renkin::synthesizability::{assess_routes, AssessmentContext,
//! ...}`) exactly as an external caller would -- no `pub(crate)` internals
//! from `signals.rs`/`element_accounting.rs`/`provenance.rs` (those are
//! private modules not re-exported by `synthesizability::mod.rs`, so an
//! integration test in `tests/` genuinely cannot reach them; see this
//! agent's final report for what that means for design doc §9's fixture
//! plan).
//!
//! Section headers below follow the design doc §9 / task checklist
//! numbering (1-20), plus "Additional" tests for behavior found by reading
//! the merged code that the checklist didn't enumerate by name.

use renkin::chem_env::RetroRule;
use renkin::evidence::{ExampleMatch, ReactionExample, ResolvedReactionExample, StepEvidence};
use renkin::search::{AtomEconomyStatus, ReactionStep, Route};
use renkin::synthesizability::{
    AssessmentContext, AssessmentStatus, ElementAccountingStatus, EvidencePolicy,
    ForwardValidationPolicy, ForwardValidationStatus, HardFailure, SYNTHESIZABILITY_SCHEMA_VERSION,
    StockTerminationStatus, SynthesizabilityConfig, ValidationGap, assess_routes,
};
use renkin::validation::StepValidationStatus;

// ---------------------------------------------------------------------
// Shared builders -- mirrors the style already used in each
// src/synthesizability/*.rs file's own #[cfg(test)] module.
// ---------------------------------------------------------------------

fn no_rules() -> Vec<RetroRule> {
    vec![]
}

fn step(rule: &str, template_id: &str, target: &str, precursors: &[&str]) -> ReactionStep {
    ReactionStep {
        rule: rule.to_string(),
        template_id: template_id.to_string(),
        target: target.to_string(),
        precursors: precursors.iter().map(|s| s.to_string()).collect(),
        conditions: None,
        atom_economy: None,
        atom_economy_raw_percent: None,
        atom_economy_status: AtomEconomyStatus::NotEvaluable,
        step_confidence: 1.0,
        procedure_hint: None,
        reaction_family: None,
        metadata_source: None,
        metadata_scope: None,
        evidence: None,
    }
}

fn step_with_evidence(
    rule: &str,
    template_id: &str,
    target: &str,
    precursors: &[&str],
    evidence: StepEvidence,
) -> ReactionStep {
    ReactionStep {
        evidence: Some(evidence),
        ..step(rule, template_id, target, precursors)
    }
}

fn route(steps: Vec<ReactionStep>, building_blocks: &[&str]) -> Route {
    Route {
        depth: steps.len() as u32,
        steps,
        score: 0.0,
        building_blocks: building_blocks.iter().map(|s| s.to_string()).collect(),
        confidence: 1.0,
        convergency: 1.0,
        success_probability: 1.0,
        route_cost: 1.0,
    }
}

fn empty_context(rules: &[RetroRule]) -> AssessmentContext<'_> {
    AssessmentContext {
        stock: None,
        stock_source: None,
        template_metadata_hash: None,
        search_config_summary: None,
        git_commit: None,
        embedded_fallback_used: None,
        forward_validation: None,
        rules,
    }
}

fn resolved_example(match_kind: ExampleMatch, id: &str) -> ResolvedReactionExample {
    ResolvedReactionExample {
        match_kind,
        example: ReactionExample {
            id: id.to_string(),
            target_smiles: "CCO".to_string(),
            precursor_smiles: vec!["CC=O".to_string()],
            conditions: None,
            reported_yield: None,
            warnings: vec![],
            reference_ids: vec![],
            dataset_record_id: None,
            notes: None,
        },
    }
}

fn evidence_with(examples: Vec<ResolvedReactionExample>) -> StepEvidence {
    let total = examples.len();
    StepEvidence {
        condition_candidates: vec![],
        reported_yields: vec![],
        references: vec![],
        warnings: vec![],
        examples,
        template_examples_total: total,
    }
}

// ---------------------------------------------------------------------
// 1. Target parse failure -> InvalidTarget
// ---------------------------------------------------------------------

#[test]
fn invalid_target_smiles_is_invalid_target() {
    let rules = no_rules();
    let ctx = empty_context(&rules);
    let result = assess_routes(
        "not-a-smiles(((",
        &[],
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .expect("assess_routes must not Err for a bad target");
    assert_eq!(result.status, AssessmentStatus::InvalidTarget);
    assert_eq!(result.canonical_target, None);
    assert!(result.route_assessments.is_empty());
    assert_eq!(result.provenance.canonical_target, "");
}

// ---------------------------------------------------------------------
// 2. No routes supplied -> NoRouteFoundWithinBudget, never Indeterminate.
//
// Per design doc §3: today's `find_routes` has no time/node budget --
// depth and beam width *are* the budget -- so an empty route list can only
// mean the search frontier was exhausted. There is no signal anywhere in
// this schema version that could distinguish "space exhausted" from "search
// cut off early", so `AssessmentStatus::Indeterminate` is unreachable
// through the public API today, by construction. This test exists
// specifically so nobody adds a distinct "timeout" fixture later without
// first adding real budget tracking to `SearchConfig` (design doc §10 lists
// that as an explicit non-goal for this PR; §11.2 as a known limitation).
// ---------------------------------------------------------------------

#[test]
fn no_routes_is_always_no_route_found_within_budget_never_indeterminate() {
    let rules = no_rules();
    for search_config_summary in [
        None,
        Some("depth=6,beam=50,max_routes=20".to_string()),
        Some("depth=1,beam=1,max_routes=1".to_string()),
    ] {
        let ctx = AssessmentContext {
            search_config_summary,
            ..empty_context(&rules)
        };
        let result = assess_routes("CCO", &[], &ctx, &SynthesizabilityConfig::conservative())
            .expect("empty routes must not Err");
        assert_eq!(result.status, AssessmentStatus::NoRouteFoundWithinBudget);
        assert_ne!(result.status, AssessmentStatus::Indeterminate);
        assert!(result.canonical_target.is_some());
    }
}

// ---------------------------------------------------------------------
// 3. Stock: full termination -> AllLeavesVerifiedInConfiguredStock
// ---------------------------------------------------------------------

#[test]
fn stock_full_termination_all_leaves_verified() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step(
            "esterification_retro",
            "rule:esterification_retro",
            "CCOC(=O)c1ccccc1",
            &["CCO", "O=C(O)c1ccccc1"],
        )],
        &["CCO", "O=C(O)c1ccccc1"],
    )];
    let stock = vec!["CCO".to_string(), "O=C(O)c1ccccc1".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "CCOC(=O)c1ccccc1",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        result.route_assessments[0].stock_termination_status,
        StockTerminationStatus::AllLeavesVerifiedInConfiguredStock
    );
    assert!(result.route_assessments[0].hard_failures.is_empty());
    assert_eq!(result.status, AssessmentStatus::RouteSupported);
}

// ---------------------------------------------------------------------
// 4. Stock: leaf mismatch -> OneOrMoreLeavesNotInStock / HardFailure::
//    StockTerminalMismatch, using the exact 3 real Issue #71 false-positive
//    SMILES (see `data/comparison/results_100/per_target_audit.md` lines
//    36-38 and design doc §9). Note on what these fixtures do and don't
//    prove: none of the 3 leaves has any subgraph relationship to the
//    ("CCO") stock entry used below, so a reintroduced VF2-style matcher
//    would reject these too -- this fixture alone can't discriminate
//    "kernel does exact canonical-identity matching" from "kernel has some
//    other, still-buggy matcher that happens to also reject these
//    specific molecules." The actual guarantee that no VF2/subgraph
//    machinery exists in this module comes from its absence in
//    `signals.rs`/`element_accounting.rs` (grep for `find_matches`/
//    `parse_smarts`/subgraph), not from this fixture. What this fixture
//    *does* prove: the kernel's own independent stock check correctly
//    flags these three specific, previously-mis-accepted leaves as not in
//    stock -- a real, valuable regression guard, just not a general proof
//    of "no subgraph matching anywhere."
// ---------------------------------------------------------------------

/// Shared shape for all three Issue #71 fixtures: a single-step route whose
/// only leaf is the exact false-positive SMILES, checked against a stock
/// list that does not contain it (or any canonicalization of it). The
/// target/rule are fictitious pairings chosen only so the target's heavy
/// atoms are a strict subset of the leaf's (the one-directional element
/// accounting check, design doc §4.5, is satisfied trivially and does not
/// interfere with isolating the stock signal under test).
fn issue71_fixture_route(rule_name: &str, target: &str, false_positive_leaf: &str) -> Route {
    route(
        vec![step(
            rule_name,
            &format!("rule:{rule_name}"),
            target,
            &[false_positive_leaf],
        )],
        &[false_positive_leaf],
    )
}

#[test]
fn issue71_pentadiene_false_positive_is_not_in_stock() {
    // C=C/C/C=C claimed as leaf; real molecule is C=CCC=C (1,4-pentadiene).
    // Stock deliberately contains neither the raw string nor any
    // canonicalization of it.
    let rules = no_rules();
    let routes = vec![issue71_fixture_route(
        "cc_single_cleavage",
        "CC=C", // propene: C:3, a strict subset of the leaf's C:5
        "C=C/C/C=C",
    )];
    let stock = vec!["CCO".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "CC=C",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        result.route_assessments[0].stock_termination_status,
        StockTerminationStatus::OneOrMoreLeavesNotInStock
    );
    assert!(result.route_assessments[0].hard_failures.contains(
        &HardFailure::StockTerminalMismatch {
            leaf: "C=C/C/C=C".to_string()
        }
    ));
    assert_eq!(result.status, AssessmentStatus::RoutesFoundButRejected);
    assert!(result.selected_route.is_none());
}

#[test]
fn issue71_glyoxylic_acid_false_positive_is_not_in_stock() {
    // O=C/C(=O)O claimed as leaf; real molecule is O=CC(=O)O (glyoxylic acid).
    let rules = no_rules();
    let routes = vec![issue71_fixture_route(
        "wittig_retro",
        "O=CO", // formic acid: C:1, O:2 -- subset of the leaf's C:2, O:3
        "O=C/C(=O)O",
    )];
    let stock = vec!["CCO".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "O=CO",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        result.route_assessments[0].stock_termination_status,
        StockTerminationStatus::OneOrMoreLeavesNotInStock
    );
    assert!(result.route_assessments[0].hard_failures.contains(
        &HardFailure::StockTerminalMismatch {
            leaf: "O=C/C(=O)O".to_string()
        }
    ));
    assert_eq!(result.status, AssessmentStatus::RoutesFoundButRejected);
}

#[test]
fn issue71_phenylacetaldehyde_false_positive_is_not_in_stock() {
    // c1ccc(cc1)CC=O claimed as leaf; real molecule is O=CCc1ccccc1
    // (phenylacetaldehyde).
    let rules = no_rules();
    let routes = vec![issue71_fixture_route(
        "co_aliphatic_cleavage",
        "c1ccccc1", // benzene: C:6 -- subset of the leaf's C:8
        "c1ccc(cc1)CC=O",
    )];
    let stock = vec!["CCO".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "c1ccccc1",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        result.route_assessments[0].stock_termination_status,
        StockTerminationStatus::OneOrMoreLeavesNotInStock
    );
    assert!(result.route_assessments[0].hard_failures.contains(
        &HardFailure::StockTerminalMismatch {
            leaf: "c1ccc(cc1)CC=O".to_string()
        }
    ));
    assert_eq!(result.status, AssessmentStatus::RoutesFoundButRejected);
}

// ---------------------------------------------------------------------
// 5. Stock not supplied -> StockNotSupplied / ValidationGap::StockNotSupplied
//    (top-level-integration-test version of an existing
//    assessment.rs-internal test).
// ---------------------------------------------------------------------

#[test]
fn stock_not_supplied_is_a_gap_not_a_hard_failure_top_level() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step("rule:x", "rule:x", "CCO", &["CC=O"])],
        &["CC=O"],
    )];
    let ctx = empty_context(&rules); // stock: None
    let result = assess_routes(
        "CCO",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        result.route_assessments[0].stock_termination_status,
        StockTerminationStatus::StockNotSupplied
    );
    assert!(
        result.route_assessments[0]
            .validation_gaps
            .contains(&ValidationGap::StockNotSupplied)
    );
    assert!(result.route_assessments[0].hard_failures.is_empty());
    assert_eq!(
        result.status,
        AssessmentStatus::RouteSupportedWithValidationGaps
    );
}

// ---------------------------------------------------------------------
// 6. Stock check disabled by config -> StockCheckNotPerformed
// ---------------------------------------------------------------------

#[test]
fn stock_check_disabled_by_config_is_not_performed() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step("rule:x", "rule:x", "CCO", &["CC=O"])],
        &["CC=O"],
    )];
    let ctx = empty_context(&rules);
    let mut config = SynthesizabilityConfig::conservative();
    config.require_verified_stock_terminal = false;
    let result = assess_routes("CCO", &routes, &ctx, &config).unwrap();
    assert_eq!(
        result.route_assessments[0].stock_termination_status,
        StockTerminationStatus::StockCheckNotPerformed
    );
    assert!(result.route_assessments[0].hard_failures.is_empty());
    assert!(result.route_assessments[0].validation_gaps.is_empty());
    assert_eq!(result.status, AssessmentStatus::RouteSupported);
}

// ---------------------------------------------------------------------
// 7/8. Target-element accounting cross-language parity fixtures, mirrored
// verbatim from `scripts/tests/test_compare_validation.py`.
// ---------------------------------------------------------------------

/// Cross-language parity fixture, mirrored verbatim from
/// `scripts/tests/test_compare_validation.py::
/// test_esterification_is_accounted_despite_water_byproduct` (target
/// `TARGET = "CCOC(=O)c1ccccc1"`, precursors `ETHANOL = "CCO"` +
/// `BENZOIC_ACID = "O=C(O)c1ccccc1"`). The Python assertion is
/// `status == "accounted"`; the Rust equivalent is
/// `ElementAccountingStatus::Accounted`, which serializes (per
/// `#[serde(rename_all = "snake_case")]`) to exactly `"accounted"`.
#[test]
fn target_element_accounted_ethyl_benzoate_parity_with_python() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step(
            "esterification_retro",
            "rule:esterification_retro",
            "CCOC(=O)c1ccccc1",
            &["CCO", "O=C(O)c1ccccc1"],
        )],
        &["CCO", "O=C(O)c1ccccc1"],
    )];
    let stock = vec!["CCO".to_string(), "O=C(O)c1ccccc1".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "CCOC(=O)c1ccccc1",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        result.route_assessments[0].target_element_accounting_status,
        ElementAccountingStatus::Accounted
    );
    let json = serde_json::to_string(&result.route_assessments[0]).unwrap();
    assert!(json.contains("\"target_element_accounting_status\":\"accounted\""));
    assert_eq!(result.status, AssessmentStatus::RouteSupported);
}

/// Cross-language parity fixture, mirrored verbatim from
/// `scripts/tests/test_compare_validation.py::
/// test_atom_materializing_from_nowhere_is_unaccounted` (target
/// `"Clc1ccccc1"` from precursor `["Brc1ccccc1"]`: chlorobenzene's Cl has no
/// precursor source at all -- an MW-only check would wrongly pass this
/// since bromobenzene is heavier, but the per-element check must not). The
/// Python assertion is `status == "unaccounted_target_element"`; the Rust
/// equivalent is `ElementAccountingStatus::UnaccountedTargetElement`, which
/// serializes to exactly `"unaccounted_target_element"`.
#[test]
fn target_element_unaccounted_chlorobenzene_parity_with_python() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step(
            "some_extracted_rule",
            "rule:some_extracted_rule",
            "Clc1ccccc1",
            &["Brc1ccccc1"],
        )],
        &["Brc1ccccc1"],
    )];
    let stock = vec!["Brc1ccccc1".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "Clc1ccccc1",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        result.route_assessments[0].target_element_accounting_status,
        ElementAccountingStatus::UnaccountedTargetElement
    );
    let json = serde_json::to_string(&result.route_assessments[0]).unwrap();
    assert!(json.contains("\"target_element_accounting_status\":\"unaccounted_target_element\""));
    // Not on the reagent-omission allowlist -> conservative() hard-rejects.
    assert!(
        result.route_assessments[0]
            .hard_failures
            .contains(&HardFailure::UnaccountedTargetElement { step_index: 0 })
    );
    assert_eq!(result.status, AssessmentStatus::RoutesFoundButRejected);
}

// ---------------------------------------------------------------------
// 9/10/11. Forward validation
// ---------------------------------------------------------------------

#[test]
fn forward_validation_all_valid_end_to_end() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step("rule:x", "rule:x", "CCO", &["CC=O"])],
        &["CC=O"],
    )];
    let fv: Vec<Option<Vec<StepValidationStatus>>> = vec![Some(vec![StepValidationStatus::Valid])];
    let ctx = AssessmentContext {
        forward_validation: Some(&fv),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "CCO",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        result.route_assessments[0].forward_validation_status,
        ForwardValidationStatus::AllEvaluatedStepsValid
    );
    assert!(result.route_assessments[0].hard_failures.is_empty());
}

/// `OneOrMoreStepsInvalid` is recorded regardless of policy, but only
/// gates (becomes `HardFailure::ForwardValidationFailed`) when the policy
/// requires it -- default `Ignore` never gates.
#[test]
fn forward_validation_one_invalid_step_gated_only_when_policy_requires_it() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step("rule:x", "rule:x", "CCO", &["CC=O"])],
        &["CC=O"],
    )];
    let fv: Vec<Option<Vec<StepValidationStatus>>> =
        vec![Some(vec![StepValidationStatus::Invalid])];
    let ctx = AssessmentContext {
        forward_validation: Some(&fv),
        ..empty_context(&rules)
    };

    // Default policy (Ignore): recorded, but never gates.
    let ignored = assess_routes(
        "CCO",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        ignored.route_assessments[0].forward_validation_status,
        ForwardValidationStatus::OneOrMoreStepsInvalid
    );
    assert!(
        !ignored.route_assessments[0]
            .hard_failures
            .iter()
            .any(|hf| matches!(hf, HardFailure::ForwardValidationFailed { .. }))
    );

    // RequireNoInvalid: now a hard failure attributed to the invalid step.
    let mut config = SynthesizabilityConfig::conservative();
    config.forward_validation_policy = ForwardValidationPolicy::RequireNoInvalid;
    let strict = assess_routes("CCO", &routes, &ctx, &config).unwrap();
    assert!(
        strict.route_assessments[0]
            .hard_failures
            .contains(&HardFailure::ForwardValidationFailed { step_index: 0 })
    );
    assert_eq!(strict.status, AssessmentStatus::RoutesFoundButRejected);
}

/// `NotEvaluated` (per-route entry is `None`) is never treated as `Invalid`
/// -- there is no `HardFailure` variant for "not evaluated" at all, only a
/// confirmed `Invalid` step can ever produce
/// `HardFailure::ForwardValidationFailed`. Whether it surfaces as
/// `ValidationGap::ForwardValidationNotRun` depends on policy: **only**
/// `RequireAllValid` records that gap (see `assess_forward_validation` in
/// `assessment.rs`) -- default `Ignore` and `RequireNoInvalid` both tolerate
/// `NotEvaluated` silently (no gap, no failure). This is narrower than "not
/// evaluated always produces a gap" -- verified against the real merged
/// code, not assumed; see this agent's final report.
#[test]
fn forward_validation_not_evaluated_is_never_a_hard_failure_gap_depends_on_policy() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step("rule:x", "rule:x", "CCO", &["CC=O"])],
        &["CC=O"],
    )];
    let fv: Vec<Option<Vec<StepValidationStatus>>> = vec![None]; // per-route entry present but None
    let ctx = AssessmentContext {
        forward_validation: Some(&fv),
        ..empty_context(&rules)
    };

    // Default (Ignore): NotEvaluated, but no gap recorded at all.
    let ignored = assess_routes(
        "CCO",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        ignored.route_assessments[0].forward_validation_status,
        ForwardValidationStatus::NotEvaluated
    );
    assert!(
        !ignored.route_assessments[0]
            .validation_gaps
            .contains(&ValidationGap::ForwardValidationNotRun)
    );
    assert!(ignored.route_assessments[0].hard_failures.is_empty());

    // RequireAllValid: NotEvaluated now surfaces as a validation gap --
    // never as a hard failure.
    let mut require_all = SynthesizabilityConfig::conservative();
    require_all.forward_validation_policy = ForwardValidationPolicy::RequireAllValid;
    let strict = assess_routes("CCO", &routes, &ctx, &require_all).unwrap();
    assert!(
        strict.route_assessments[0]
            .validation_gaps
            .contains(&ValidationGap::ForwardValidationNotRun)
    );
    assert!(
        !strict.route_assessments[0]
            .hard_failures
            .iter()
            .any(|hf| matches!(hf, HardFailure::ForwardValidationFailed { .. }))
    );

    // RequireNoInvalid: also tolerated -- no gap, no failure.
    let mut require_no_invalid = SynthesizabilityConfig::conservative();
    require_no_invalid.forward_validation_policy = ForwardValidationPolicy::RequireNoInvalid;
    let tolerant = assess_routes("CCO", &routes, &ctx, &require_no_invalid).unwrap();
    assert!(
        !tolerant.route_assessments[0]
            .validation_gaps
            .contains(&ValidationGap::ForwardValidationNotRun)
    );
    assert!(tolerant.route_assessments[0].hard_failures.is_empty());
}

// ---------------------------------------------------------------------
// 12/13/14. Evidence coverage
// ---------------------------------------------------------------------

#[test]
fn evidence_exact_substrate_present_is_never_gated() {
    let rules = no_rules();
    let evidence = evidence_with(vec![resolved_example(ExampleMatch::ExactSubstrate, "ex1")]);
    let routes = vec![route(
        vec![step_with_evidence(
            "rule:x",
            "rule:x",
            "CCO",
            &["CC=O"],
            evidence,
        )],
        &["CC=O"],
    )];
    let ctx = empty_context(&rules);
    let mut config = SynthesizabilityConfig::conservative();
    config.evidence_policy = EvidencePolicy::RequireExactSubstrate;
    let result = assess_routes("CCO", &routes, &ctx, &config).unwrap();
    let ra = &result.route_assessments[0];
    assert_eq!(ra.evidence_coverage.exact_substrate_evidence_steps, 1);
    assert!(
        !ra.validation_gaps
            .contains(&ValidationGap::NoExactSubstrateEvidence)
    );
    assert!(!ra.validation_gaps.contains(&ValidationGap::NoEvidence));
}

#[test]
fn evidence_template_level_only_gap_present_under_require_exact_substrate_absent_under_ignore() {
    let rules = no_rules();
    let evidence = evidence_with(vec![resolved_example(ExampleMatch::TemplateOnly, "ex1")]);
    let routes = vec![route(
        vec![step_with_evidence(
            "rule:x",
            "rule:x",
            "CCO",
            &["CC=O"],
            evidence,
        )],
        &["CC=O"],
    )];
    let ctx = empty_context(&rules);

    // Default (Ignore): gap never surfaces even though coverage is
    // template-level only, not exact-substrate.
    let ignore_result = assess_routes(
        "CCO",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    let ra = &ignore_result.route_assessments[0];
    assert_eq!(ra.evidence_coverage.template_level_evidence_steps, 1);
    assert_eq!(ra.evidence_coverage.exact_substrate_evidence_steps, 0);
    assert!(
        !ra.validation_gaps
            .contains(&ValidationGap::NoExactSubstrateEvidence)
    );

    // RequireExactSubstrate: same route now produces the gap.
    let mut config = SynthesizabilityConfig::conservative();
    config.evidence_policy = EvidencePolicy::RequireExactSubstrate;
    let strict_result = assess_routes("CCO", &routes, &ctx, &config).unwrap();
    assert!(
        strict_result.route_assessments[0]
            .validation_gaps
            .contains(&ValidationGap::NoExactSubstrateEvidence)
    );
}

#[test]
fn evidence_none_at_all_gap_present_under_require_any_absent_under_ignore() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step("rule:x", "rule:x", "CCO", &["CC=O"])], // evidence: None
        &["CC=O"],
    )];
    let ctx = empty_context(&rules);

    let ignore_result = assess_routes(
        "CCO",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    let ra = &ignore_result.route_assessments[0];
    assert_eq!(ra.evidence_coverage.steps_without_evidence, 1);
    assert!(!ra.validation_gaps.contains(&ValidationGap::NoEvidence));

    let mut config = SynthesizabilityConfig::conservative();
    config.evidence_policy = EvidencePolicy::RequireAnyEvidence;
    let strict_result = assess_routes("CCO", &routes, &ctx, &config).unwrap();
    assert!(
        strict_result.route_assessments[0]
            .validation_gaps
            .contains(&ValidationGap::NoEvidence)
    );
}

// ---------------------------------------------------------------------
// 15. Route order independence: the *set* of routes assessed together
// produces the same selected_route/status/full assessment list regardless
// of which order they were handed in (route_id itself is already tested at
// the hash-function level by Agent C).
// ---------------------------------------------------------------------

#[test]
fn route_order_independence_selected_route_and_full_assessment_list_match() {
    let rules = no_rules();
    let clean = route(vec![step("rule:x", "rule:x", "CCO", &["CC=O"])], &["CC=O"]);
    let mismatched = route(
        vec![step("rule:y", "rule:y", "CCO", &["Oc1ccccc1"])],
        &["Oc1ccccc1"], // phenol -- not in the configured stock below
    );
    let stock = vec!["CC=O".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };
    // include_all_route_diagnostics: true -- this test is about the *full*
    // route_assessments list staying order-independent, not just the
    // selected route (which conservative()'s default single-route output
    // would trivially satisfy regardless of ordering).
    let mut config = SynthesizabilityConfig::conservative();
    config.include_all_route_diagnostics = true;

    let forward =
        assess_routes("CCO", &[clean.clone(), mismatched.clone()], &ctx, &config).unwrap();
    let backward = assess_routes("CCO", &[mismatched, clean], &ctx, &config).unwrap();

    assert_eq!(forward.status, backward.status);
    assert_eq!(forward.selected_route, backward.selected_route);
    assert_eq!(forward.route_assessments, backward.route_assessments);
    // Sanity: the sort actually did something (not a trivial 1-route case).
    assert_eq!(forward.route_assessments.len(), 2);
    assert!(forward.route_assessments[0].hard_failures.is_empty());
}

// ---------------------------------------------------------------------
// 16. Step/precursor order independence inside one route, through the real
// public assess_routes entry point (provenance.rs already unit-tests
// compute_route_id directly; this catches any wiring gap between
// assessment.rs and provenance.rs that the lower-level test would miss).
// ---------------------------------------------------------------------

#[test]
fn route_id_is_independent_of_precursor_order_within_a_step_via_public_api() {
    let rules = no_rules();
    let route_a = route(
        vec![step(
            "rule:x",
            "rule:x",
            "CCOC(=O)c1ccccc1",
            &["CCO", "O=C(O)c1ccccc1"],
        )],
        &["CCO", "O=C(O)c1ccccc1"],
    );
    let route_b = route(
        vec![step(
            "rule:x",
            "rule:x",
            "CCOC(=O)c1ccccc1",
            &["O=C(O)c1ccccc1", "CCO"],
        )],
        &["O=C(O)c1ccccc1", "CCO"],
    );
    let ctx = empty_context(&rules);
    let config = SynthesizabilityConfig::conservative();

    let result_a = assess_routes("CCOC(=O)c1ccccc1", &[route_a], &ctx, &config).unwrap();
    let result_b = assess_routes("CCOC(=O)c1ccccc1", &[route_b], &ctx, &config).unwrap();

    assert_eq!(
        result_a.route_assessments[0].route_id,
        result_b.route_assessments[0].route_id
    );
}

// ---------------------------------------------------------------------
// 17. Byte-identical JSON for byte-identical inputs -- nothing time-based
// is ever computed in this module (design doc §6), so this holds with zero
// exceptions. Deliberately NOT the thinnest possible fixture: a single
// clean route with zero hard failures and no sorting would never touch the
// `HashSet<String>` dedup loop in `assess_stock_termination` (whose
// iteration order is per-instance-random in Rust, not just per-process) or
// the §4.8 multi-route `sort_by`. This fixture has one route with TWO
// unmatched leaves (exercises the dedup/collection loop) plus a second,
// clean route (exercises cross-route sorting) so the strongest claim in §6
// actually gets exercised, not just assumed from a trivial case.
// ---------------------------------------------------------------------

#[test]
fn byte_identical_inputs_produce_byte_identical_json() {
    let rules = no_rules();
    let worse = route(
        vec![step(
            "rule:x",
            "rule:x",
            "CCOC(=O)c1ccccc1",
            &["CCN", "CCCl"],
        )],
        &["CCN", "CCCl"], // neither is in the configured stock below
    );
    let better = route(
        vec![step(
            "esterification_retro",
            "rule:esterification_retro",
            "CCOC(=O)c1ccccc1",
            &["CCO", "O=C(O)c1ccccc1"],
        )],
        &["CCO", "O=C(O)c1ccccc1"],
    );
    let routes = vec![worse, better];
    let stock = vec!["CCO".to_string(), "O=C(O)c1ccccc1".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        stock_source: Some("data/building_blocks.smi".to_string()),
        template_metadata_hash: Some("sha256:abc".to_string()),
        search_config_summary: Some("depth=6,beam=50,max_routes=20".to_string()),
        git_commit: Some("deadbeef".to_string()),
        embedded_fallback_used: Some(false),
        ..empty_context(&rules)
    };
    // include_all_route_diagnostics: true -- this test wants to see both
    // routes' full diagnostics (see the comment above), not just the
    // selected one.
    let mut config = SynthesizabilityConfig::conservative();
    config.include_all_route_diagnostics = true;

    let result_a = assess_routes("CCOC(=O)c1ccccc1", &routes, &ctx, &config).unwrap();
    let result_b = assess_routes("CCOC(=O)c1ccccc1", &routes, &ctx, &config).unwrap();

    // Sanity: the fixture actually exercises what the comment above claims.
    assert_eq!(result_a.route_assessments.len(), 2);
    assert!(result_a.route_assessments.iter().any(|ra| {
        ra.hard_failures
            .iter()
            .filter(|hf| matches!(hf, HardFailure::StockTerminalMismatch { .. }))
            .count()
            >= 2
    }));

    let json_a = serde_json::to_string(&result_a).unwrap();
    let json_b = serde_json::to_string(&result_b).unwrap();
    assert_eq!(json_a, json_b);
}

// ---------------------------------------------------------------------
// 18. Malformed provenance / kernel-integrity input -> EvaluationError
// (top-level-integration-test version of an existing assessment.rs-internal
// test).
// ---------------------------------------------------------------------

#[test]
fn forward_validation_length_mismatch_is_evaluation_error_top_level() {
    let rules = no_rules();
    let routes = vec![
        route(vec![step("rule:x", "rule:x", "CCO", &["CC=O"])], &["CC=O"]),
        route(vec![step("rule:y", "rule:y", "CCN", &["CCCl"])], &["CCCl"]),
    ];
    // Length 1 != routes.len() == 2 -- index correspondence cannot be trusted.
    let fv: Vec<Option<Vec<StepValidationStatus>>> = vec![Some(vec![StepValidationStatus::Valid])];
    let ctx = AssessmentContext {
        forward_validation: Some(&fv),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "CCO",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .expect("a malformed context must surface as a status, not an Err");
    assert_eq!(result.status, AssessmentStatus::EvaluationError);
    assert!(result.route_assessments.is_empty());
    assert!(result.selected_route.is_none());
    assert!(!result.warnings.is_empty());
}

// ---------------------------------------------------------------------
// 19. Embedded stock fallback is explicit, not silent: Some(true)/
// Some(false)/None are echoed verbatim into AssessmentProvenance with no
// substitution/defaulting logic anywhere.
// ---------------------------------------------------------------------

#[test]
fn embedded_fallback_used_is_echoed_verbatim_never_defaulted() {
    let rules = no_rules();
    for input in [None, Some(true), Some(false)] {
        let ctx = AssessmentContext {
            embedded_fallback_used: input,
            ..empty_context(&rules)
        };
        let result =
            assess_routes("CCO", &[], &ctx, &SynthesizabilityConfig::conservative()).unwrap();
        assert_eq!(result.provenance.embedded_fallback_used, input);
    }
}

// ---------------------------------------------------------------------
// 20. PR #70/#71-lineage regression class: a multi-step route where an
// INTERMEDIATE leaf (not the top-level target) is one of the mismatched
// SMILES -- confirms the hard failure surfaces with the correct leaf
// identity even when it's several steps deep. NB: `HardFailure::
// StockTerminalMismatch` carries only `leaf: String`, not a `step_index` --
// there is no per-step attribution field on this variant in the merged
// schema (unlike UnaccountedTargetElement/ForwardValidationFailed, which do
// carry step_index). See this agent's final report.
// ---------------------------------------------------------------------

#[test]
fn issue71_style_mismatch_surfaces_correctly_when_leaf_is_not_the_top_level_target() {
    let rules = no_rules();
    // step 0: overall target "CCO" from precursor "CC=O" (further reduced).
    // step 1: "CC=O" from the two real leaves -- one of which is the exact
    // 1,4-pentadiene false positive, several steps removed from the
    // top-level target "CCO".
    let routes = vec![route(
        vec![
            step("rule:step0", "rule:step0", "CCO", &["CC=O"]),
            step(
                "rule:step1",
                "rule:step1",
                "CC=O",
                &["C=C/C/C=C", "O=C/C(=O)O"],
            ),
        ],
        &["C=C/C/C=C", "O=C/C(=O)O"],
    )];
    // Stock verifies the OTHER leaf but not the false positive -- so exactly
    // one leaf, from the deeper step, must be flagged.
    let stock = vec!["O=C/C(=O)O".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "CCO",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();

    assert_eq!(
        result.route_assessments[0].stock_termination_status,
        StockTerminationStatus::OneOrMoreLeavesNotInStock
    );
    assert!(result.route_assessments[0].hard_failures.contains(
        &HardFailure::StockTerminalMismatch {
            leaf: "C=C/C/C=C".to_string()
        }
    ));
    assert!(!result.route_assessments[0].hard_failures.contains(
        &HardFailure::StockTerminalMismatch {
            leaf: "O=C/C(=O)O".to_string()
        }
    ));
    // The flagged leaf is not the top-level target -- this is the whole
    // point of the regression class (a leaf several steps deep, not the
    // molecule the caller asked about).
    assert_ne!(result.canonical_target.unwrap(), "C=C/C/C=C");
    assert_eq!(result.status, AssessmentStatus::RoutesFoundButRejected);
}

// ---------------------------------------------------------------------
// Additional: AccountingFailurePolicy::HardFailure vs ValidationGap
// end-to-end via the public API only (independent fixture from
// assessment.rs's own non_allowlisted_accounting_failure_.../
// allowlisted_accounting_failure_... tests -- same chlorobenzene/
// bromobenzene parity chemistry as items 7/8 above, but different template
// ids, so this is a genuinely separate fixture, not a copy).
// ---------------------------------------------------------------------

#[test]
fn allowlisted_accounting_failure_is_a_validation_gap_end_to_end() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step(
            "cbz_deprotection_retro",
            "rule:cbz_deprotection_retro",
            "Clc1ccccc1",
            &["Brc1ccccc1"],
        )],
        &["Brc1ccccc1"],
    )];
    let stock = vec!["Brc1ccccc1".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "Clc1ccccc1",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        result.status,
        AssessmentStatus::RouteSupportedWithValidationGaps
    );
    let selected = result.selected_route.unwrap();
    assert!(selected.hard_failures.is_empty());
    assert!(selected.validation_gaps.iter().any(|g| matches!(
        g,
        ValidationGap::ReagentOmissionAccountingGap { template_id, .. }
            if template_id == "rule:cbz_deprotection_retro"
    )));
}

#[test]
fn non_allowlisted_accounting_failure_is_hard_failure_under_conservative_and_gap_under_diagnostic_end_to_end()
 {
    let rules = no_rules();
    let routes = vec![route(
        vec![step(
            "custom_extracted_rule",
            "rule:custom_extracted_rule",
            "Clc1ccccc1",
            &["Brc1ccccc1"],
        )],
        &["Brc1ccccc1"],
    )];
    let stock = vec!["Brc1ccccc1".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };

    let conservative = assess_routes(
        "Clc1ccccc1",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(
        conservative.status,
        AssessmentStatus::RoutesFoundButRejected
    );
    assert!(
        conservative.route_assessments[0]
            .hard_failures
            .contains(&HardFailure::UnaccountedTargetElement { step_index: 0 })
    );

    let diagnostic = assess_routes(
        "Clc1ccccc1",
        &routes,
        &ctx,
        &SynthesizabilityConfig::diagnostic(),
    )
    .unwrap();
    assert_eq!(
        diagnostic.status,
        AssessmentStatus::RouteSupportedWithValidationGaps
    );
    assert!(
        diagnostic.route_assessments[0]
            .validation_gaps
            .contains(&ValidationGap::UnaccountedTargetElementNotEnforced { step_index: 0 })
    );
}

/// Design doc §9's explicit allowlist fixture *pair*: alongside the
/// allowlisted (`cbz_deprotection_retro`) and generic-non-allowlisted
/// (`custom_extracted_rule`) cases above, `rule:aryl_amine_retro`
/// specifically must ALSO be a hard failure under `conservative()` -- issue
/// #73 is unresolved, and unlike Boc/Cbz this rule has no existing
/// graph-rule exact-formula carve-out (see
/// `SynthesizabilityConfig::default_reagent_omission_allowlist` in
/// schema.rs, and `conservative_config_has_documented_defaults` in
/// schema.rs's own tests, which asserts its *absence* from the allowlist).
/// This test pins the behavioral *consequence* of that absence end-to-end:
/// a generic non-allowlisted-template test (like the one above) would keep
/// passing even if `aryl_amine_retro` were quietly added to the default
/// allowlist later -- only a test naming this exact template id catches
/// that regression.
#[test]
fn aryl_amine_retro_accounting_failure_is_a_hard_failure_not_allowlisted_per_issue_73() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step(
            "aryl_amine_retro",
            "rule:aryl_amine_retro",
            "Clc1ccccc1",
            &["Brc1ccccc1"],
        )],
        &["Brc1ccccc1"],
    )];
    let stock = vec!["Brc1ccccc1".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "Clc1ccccc1",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(result.status, AssessmentStatus::RoutesFoundButRejected);
    assert!(
        result.route_assessments[0]
            .hard_failures
            .contains(&HardFailure::UnaccountedTargetElement { step_index: 0 })
    );
    assert!(
        !result.route_assessments[0]
            .validation_gaps
            .iter()
            .any(|g| matches!(g, ValidationGap::ReagentOmissionAccountingGap { .. }))
    );
    // Belt-and-suspenders: pin the allowlist itself too, so this test fails
    // loudly (rather than silently passing for the wrong reason) if
    // aryl_amine_retro is ever added to the default allowlist without this
    // test being updated in lockstep.
    assert!(
        !SynthesizabilityConfig::conservative()
            .reagent_omission_template_allowlist
            .iter()
            .any(|t| t == "rule:aryl_amine_retro")
    );
}

// ---------------------------------------------------------------------
// Additional: max_route_diagnostics truncates the *sorted* (best-first)
// list, not the caller-supplied order -- independent fixture from
// assessment.rs's own max_route_diagnostics_truncation_never_drops_the_
// best_route test.
// ---------------------------------------------------------------------

#[test]
fn max_route_diagnostics_truncates_to_the_best_route_regardless_of_input_order() {
    let rules = no_rules();
    let worse = route(
        vec![step("rule:x", "rule:x", "CCO", &["CC=O", "CCN"])],
        &["CC=O", "CCN"], // "CCN" is not in the configured stock below
    );
    let better = route(vec![step("rule:y", "rule:y", "CCO", &["CC=O"])], &["CC=O"]);
    let stock = vec!["CC=O".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        ..empty_context(&rules)
    };
    let mut config = SynthesizabilityConfig::conservative();
    // Exercise max_route_diagnostics's own truncation, not
    // include_all_route_diagnostics' default single-route cap.
    config.include_all_route_diagnostics = true;
    config.max_route_diagnostics = 1;

    // Worse (broken) route supplied FIRST in caller order.
    let result = assess_routes("CCO", &[worse, better], &ctx, &config).unwrap();
    assert_eq!(result.route_assessments.len(), 1);
    let survivor = &result.route_assessments[0];
    assert!(survivor.hard_failures.is_empty());
    assert_eq!(
        survivor.stock_termination_status,
        StockTerminationStatus::AllLeavesVerifiedInConfiguredStock
    );
    assert_eq!(result.status, AssessmentStatus::RouteSupported);
    assert!(
        result
            .warnings
            .iter()
            .any(|w| w.contains("max_route_diagnostics"))
    );
}

// ---------------------------------------------------------------------
// Additional: stock_source echoed into provenance -- independent
// top-level version of an existing assessment.rs-internal test.
// ---------------------------------------------------------------------

#[test]
fn stock_source_label_echoed_into_provenance_top_level() {
    let rules = no_rules();
    let routes = vec![route(
        vec![step("rule:x", "rule:x", "CCO", &["CC=O"])],
        &["CC=O"],
    )];
    let stock = vec!["CC=O".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        stock_source: Some("embedded".to_string()),
        ..empty_context(&rules)
    };
    let result = assess_routes(
        "CCO",
        &routes,
        &ctx,
        &SynthesizabilityConfig::conservative(),
    )
    .unwrap();
    assert_eq!(result.provenance.stock_source, Some("embedded".to_string()));
}

// ---------------------------------------------------------------------
// Additional: full-provenance smoke test -- every AssessmentProvenance /
// SynthesizabilityConfigSummary field populated as expected for a normal,
// fully-supported run.
// ---------------------------------------------------------------------

#[test]
fn full_provenance_smoke_test_every_field_populated_for_a_normal_run() {
    let rules = vec![RetroRule {
        name: "esterification_retro".to_string(),
        template_id: "rule:esterification_retro".to_string(),
        smirks: "[C:1](=O)O.[O:2]>>[C:1](=O)[O:2]".to_string(),
        weight: 1.0,
        required_elements: 0,
    }];
    let routes = vec![route(
        vec![step(
            "esterification_retro",
            "rule:esterification_retro",
            "CCOC(=O)c1ccccc1",
            &["CCO", "O=C(O)c1ccccc1"],
        )],
        &["CCO", "O=C(O)c1ccccc1"],
    )];
    let stock = vec!["CCO".to_string(), "O=C(O)c1ccccc1".to_string()];
    let ctx = AssessmentContext {
        stock: Some(&stock),
        stock_source: Some("data/building_blocks.smi".to_string()),
        template_metadata_hash: Some("sha256:meta".to_string()),
        search_config_summary: Some("depth=6,beam=50,max_routes=20".to_string()),
        git_commit: Some("deadbeef".to_string()),
        embedded_fallback_used: Some(false),
        forward_validation: None,
        rules: &rules,
    };
    let config = SynthesizabilityConfig::conservative();
    let result = assess_routes("CCOC(=O)c1ccccc1", &routes, &ctx, &config).unwrap();

    assert_eq!(result.status, AssessmentStatus::RouteSupported);

    let prov = &result.provenance;
    assert!(!prov.renkin_version.is_empty());
    assert_eq!(
        prov.assessment_schema_version,
        SYNTHESIZABILITY_SCHEMA_VERSION
    );
    assert_eq!(
        prov.canonical_target,
        result.canonical_target.clone().unwrap()
    );
    assert_eq!(prov.rules_count, 1);
    assert!(prov.rules_hash.starts_with("sha256:"));
    assert_eq!(prov.stock_count, 2);
    assert!(prov.stock_hash.starts_with("sha256:"));
    assert_eq!(
        prov.stock_source,
        Some("data/building_blocks.smi".to_string())
    );
    assert_eq!(prov.template_metadata_hash, Some("sha256:meta".to_string()));
    assert_eq!(
        prov.search_config_summary,
        Some("depth=6,beam=50,max_routes=20".to_string())
    );
    assert!(prov.assessment_config_hash.starts_with("sha256:"));
    assert_eq!(prov.git_commit, Some("deadbeef".to_string()));
    assert_eq!(prov.embedded_fallback_used, Some(false));
    assert!(prov.reproducibility_hash.starts_with("sha256:"));
    assert!(!prov.reproducibility_exclusions.is_empty());
    assert!(
        prov.reproducibility_exclusions
            .contains(&"timing_ms".to_string())
    );
    assert!(
        prov.reproducibility_exclusions
            .contains(&"wall_clock_timestamp".to_string())
    );

    let cfg = &result.config_used;
    assert_eq!(
        cfg.require_verified_stock_terminal,
        config.require_verified_stock_terminal
    );
    assert_eq!(
        cfg.require_target_element_accounting,
        config.require_target_element_accounting
    );
    assert_eq!(cfg.max_route_diagnostics, config.max_route_diagnostics);
    assert_eq!(
        cfg.reagent_omission_template_allowlist,
        config.reagent_omission_template_allowlist
    );
}