remem-ai 0.5.96

Persistent memory for Claude Code and OpenAI Codex coding agents
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
use axum::{
    body::{to_bytes, Body},
    extract::{Path, Query, State},
    http::{header, Method, Request, StatusCode},
    response::IntoResponse,
};
use rusqlite::params;
use serde_json::Value;
use tower::ServiceExt;

use crate::db::test_support::ScopedTestDataDir;
use crate::{db, memory};

use super::handlers::{
    handle_get_memory, handle_graph, handle_list_candidates, handle_list_memories,
    handle_memory_detail, handle_search, handle_stats, handle_status, search_request_from_params,
};
use super::types::{CandidateParams, GraphParams, ListParams, SearchParams, ShowParams};
use super::DbState;

mod web_regressions;

fn authorized_request(method: Method, uri: &str, token: &str, body: Body) -> Request<Body> {
    Request::builder()
        .method(method)
        .uri(uri)
        .header(header::AUTHORIZATION, format!("Bearer {token}"))
        .body(body)
        .expect("request should build")
}

#[test]
fn db_state_is_stateless() {
    assert_eq!(std::mem::size_of::<DbState>(), 0);
}

#[test]
fn search_request_from_params_clamps_limit_and_offset() {
    let request = search_request_from_params(SearchParams {
        query: Some("hello".to_string()),
        project: None,
        memory_type: None,
        limit: Some(999),
        offset: Some(-5),
        include_stale: None,
        branch: None,
        multi_hop: None,
        explain: None,
    });

    assert_eq!(request.limit, 100);
    assert_eq!(request.offset, 0);
    // Canonical default hides stale and archived memories unless callers opt in.
    assert!(!request.include_stale);
    assert!(!request.multi_hop);
    assert!(!request.explain);
}

#[test]
fn search_request_from_params_preserves_filters() {
    let request = search_request_from_params(SearchParams {
        query: Some("hello".to_string()),
        project: Some("proj".to_string()),
        memory_type: Some("decision".to_string()),
        limit: Some(8),
        offset: Some(3),
        include_stale: Some(true),
        branch: Some("main".to_string()),
        multi_hop: Some(true),
        explain: Some(true),
    });

    assert_eq!(request.query.as_deref(), Some("hello"));
    assert_eq!(request.project.as_deref(), Some("proj"));
    assert_eq!(request.memory_type.as_deref(), Some("decision"));
    assert_eq!(request.limit, 8);
    assert_eq!(request.offset, 3);
    assert!(request.include_stale);
    assert_eq!(request.branch.as_deref(), Some("main"));
    assert!(request.multi_hop);
    assert!(request.explain);
}

#[tokio::test]
async fn search_handler_hides_inactive_memories_by_default() -> anyhow::Result<()> {
    let _test_dir = ScopedTestDataDir::new("api-search-default-active");
    let conn = db::open_db()?;

    memory::insert_memory(
        &conn,
        Some("session-active"),
        "proj-a",
        None,
        "aurora active",
        "aurora visible memory",
        "decision",
        None,
    )?;
    let stale_id = memory::insert_memory(
        &conn,
        Some("session-stale"),
        "proj-a",
        None,
        "aurora stale",
        "aurora stale memory",
        "decision",
        None,
    )?;
    let archived_id = memory::insert_memory(
        &conn,
        Some("session-archived"),
        "proj-a",
        None,
        "aurora archived",
        "aurora hidden memory",
        "decision",
        None,
    )?;
    conn.execute(
        "UPDATE memories SET status = 'stale' WHERE id = ?1",
        params![stale_id],
    )?;
    conn.execute(
        "UPDATE memories SET status = 'archived' WHERE id = ?1",
        params![archived_id],
    )?;
    drop(conn);

    let response = handle_search(
        State(DbState),
        axum::extract::Query(SearchParams {
            query: Some("aurora".to_string()),
            project: Some("proj-a".to_string()),
            memory_type: None,
            limit: Some(10),
            offset: None,
            include_stale: None,
            branch: None,
            multi_hop: None,
            explain: None,
        }),
    )
    .await
    .into_response();
    assert_eq!(response.status(), StatusCode::OK);

    let body = to_bytes(response.into_body(), usize::MAX).await?;
    let payload: Value = serde_json::from_slice(&body)?;
    let data = payload["data"]
        .as_array()
        .ok_or_else(|| anyhow::anyhow!("search response data should be an array"))?;
    let titles: Vec<&str> = data
        .iter()
        .map(|item| {
            item["title"]
                .as_str()
                .ok_or_else(|| anyhow::anyhow!("search item title should be a string"))
        })
        .collect::<anyhow::Result<Vec<_>>>()?;

    assert_eq!(titles, vec!["aurora active"]);
    Ok(())
}

#[tokio::test]
async fn get_memory_handler_marks_memory_accessed() -> anyhow::Result<()> {
    let _test_dir = ScopedTestDataDir::new("api-get-memory-usage");
    let conn = db::open_db()?;
    let memory_id = memory::insert_memory(
        &conn,
        Some("session-usage"),
        "proj-a",
        None,
        "usage target",
        "single-memory API detail reads should update usage columns",
        "decision",
        None,
    )?;
    drop(conn);

    let response = handle_get_memory(
        State(DbState),
        axum::extract::Query(ShowParams { id: memory_id }),
    )
    .await
    .into_response();
    assert_eq!(response.status(), StatusCode::OK);

    let conn = db::open_db()?;
    let usage: (i64, Option<i64>) = conn.query_row(
        "SELECT access_count, last_accessed_epoch FROM memories WHERE id = ?1",
        [memory_id],
        |row| Ok((row.get(0)?, row.get(1)?)),
    )?;
    assert_eq!(usage.0, 1);
    assert!(usage.1.is_some());
    Ok(())
}

#[tokio::test]
async fn status_handler_reopens_database_after_file_removal() {
    let test_dir = ScopedTestDataDir::new("api-status");

    let first = handle_status(State(DbState)).await.into_response();
    assert_eq!(first.status(), StatusCode::OK);
    assert!(test_dir.db_path().exists());

    test_dir.remove_db_files();
    assert!(!test_dir.db_path().exists());

    let second = handle_status(State(DbState)).await.into_response();
    assert_eq!(second.status(), StatusCode::OK);
    assert!(test_dir.db_path().exists());
}

#[tokio::test]
async fn router_rejects_missing_and_invalid_api_token() {
    let _test_dir = ScopedTestDataDir::new("api-auth");
    crate::api::ensure_api_token().expect("API token should be created");
    let token = crate::api::load_api_token().expect("API token should load");
    let app = super::build_router(0).with_state(DbState);

    let missing = app
        .clone()
        .oneshot(
            Request::builder()
                .method(Method::POST)
                .uri("/api/v1/memories")
                .header(header::CONTENT_TYPE, "application/json")
                .body(Body::from(r#"{"text":"x","local_copy_enabled":false}"#))
                .expect("request should build"),
        )
        .await
        .expect("request should complete");
    assert_eq!(missing.status(), StatusCode::UNAUTHORIZED);

    let invalid = app
        .clone()
        .oneshot(authorized_request(
            Method::GET,
            "/api/v1/status",
            "wrong-token",
            Body::empty(),
        ))
        .await
        .expect("request should complete");
    assert_eq!(invalid.status(), StatusCode::UNAUTHORIZED);

    let valid = app
        .oneshot(authorized_request(
            Method::GET,
            "/api/v1/status",
            &token,
            Body::empty(),
        ))
        .await
        .expect("request should complete");
    assert_eq!(valid.status(), StatusCode::OK);
}

#[tokio::test]
async fn save_memory_response_reports_durable_feedback_shape() {
    let _test_dir = ScopedTestDataDir::new("api-save-feedback");
    crate::api::ensure_api_token().expect("API token should be created");
    let token = crate::api::load_api_token().expect("API token should load");
    let app = super::build_router(0).with_state(DbState);

    let response = app
        .oneshot(
            Request::builder()
                .method(Method::POST)
                .uri("/api/v1/memories")
                .header(header::AUTHORIZATION, format!("Bearer {token}"))
                .header(header::CONTENT_TYPE, "application/json")
                .body(Body::from(
                    r#"{
                        "text":"API durable feedback body",
                        "title":"API feedback",
                        "project":"proj",
                        "topic_key":"api-feedback",
                        "memory_type":"decision",
                        "scope":"project",
                        "branch":"main",
                        "created_at_epoch":1700000789,
                        "reference_time_epoch":1600000456,
                        "local_copy_enabled":false
                    }"#,
                ))
                .expect("request should build"),
        )
        .await
        .expect("request should complete");
    assert_eq!(response.status(), StatusCode::CREATED);

    let body = to_bytes(response.into_body(), usize::MAX)
        .await
        .expect("response body should read");
    let payload: Value = serde_json::from_slice(&body).expect("save response should be valid json");

    assert_eq!(payload["status"], "saved");
    assert_eq!(payload["operation"], "add");
    assert_eq!(payload["upserted"], true);
    assert_eq!(payload["project"], "proj");
    assert_eq!(payload["scope"], "project");
    assert_eq!(payload["topic_key"], "api-feedback");
    assert_eq!(payload["branch"], "main");
    assert_eq!(payload["local_copy"]["status"], "disabled");
    assert_eq!(payload["local_status"], "disabled");
    assert!(payload["local_path"].is_null());
    assert_eq!(payload["claim_status"], "saved");
    assert!(payload["claim_id"].as_i64().is_some_and(|id| id > 0));
    assert!(payload["claim_error"].is_null());
    assert_eq!(payload["next_step"]["tool"], "get_observations");
    assert_eq!(payload["next_step"]["source"], "memory");
    assert_eq!(payload["next_step"]["ids"][0], payload["id"]);
    assert_eq!(payload["created_at_epoch"], 1_700_000_789);
    assert_eq!(payload["reference_time_epoch"], 1_600_000_456);
    assert!(payload["updated_at_epoch"]
        .as_i64()
        .is_some_and(|ts| ts > 0));
}

#[tokio::test]
async fn router_serves_get_api_v1_memories() -> anyhow::Result<()> {
    let _test_dir = ScopedTestDataDir::new("api-list-route");
    let conn = db::open_db()?;
    memory::insert_memory(
        &conn,
        Some("session-list-route"),
        "proj-a",
        None,
        "route target",
        "documented list route should serve this memory",
        "decision",
        None,
    )?;
    drop(conn);

    crate::api::ensure_api_token().expect("API token should be created");
    let token = crate::api::load_api_token().expect("token should load");
    let app = super::build_router(0).with_state(DbState);

    let response = app
        .oneshot(authorized_request(
            Method::GET,
            "/api/v1/memories?project=proj-a",
            &token,
            Body::empty(),
        ))
        .await
        .expect("request should complete");
    assert_eq!(response.status(), StatusCode::OK);

    let body = to_bytes(response.into_body(), usize::MAX).await?;
    let payload: Value = serde_json::from_slice(&body)?;
    assert_eq!(payload["meta"]["total"], 1);
    assert_eq!(payload["data"][0]["title"], "route target");
    Ok(())
}

#[tokio::test]
async fn list_memories_branch_filter_includes_null_branch() -> anyhow::Result<()> {
    let _test_dir = ScopedTestDataDir::new("api-list-branch-null");
    let conn = db::open_db()?;
    let branchless = memory::insert_memory(
        &conn,
        Some("session-branchless"),
        "proj-a",
        None,
        "branchless",
        "branch-agnostic memory",
        "decision",
        None,
    )?;
    let main_branch = memory::insert_memory_with_branch(
        &conn,
        Some("session-main"),
        "proj-a",
        None,
        "main branch",
        "main branch memory",
        "decision",
        None,
        Some("main"),
    )?;
    let other_branch = memory::insert_memory_with_branch(
        &conn,
        Some("session-other"),
        "proj-a",
        None,
        "other branch",
        "other branch memory",
        "decision",
        None,
        Some("other"),
    )?;
    drop(conn);

    let response = handle_list_memories(
        State(DbState),
        Query(ListParams {
            project: Some("proj-a".to_string()),
            memory_type: None,
            scope: None,
            status: None,
            branch: Some("main".to_string()),
            q: None,
            limit: Some(10),
            offset: None,
        }),
    )
    .await
    .into_response();
    assert_eq!(response.status(), StatusCode::OK);

    let body = to_bytes(response.into_body(), usize::MAX).await?;
    let payload: Value = serde_json::from_slice(&body)?;
    let ids: Vec<i64> = payload["data"]
        .as_array()
        .expect("data should be array")
        .iter()
        .map(|item| item["id"].as_i64().expect("id should be i64"))
        .collect();
    assert!(ids.contains(&branchless));
    assert!(ids.contains(&main_branch));
    assert!(!ids.contains(&other_branch));
    assert_eq!(payload["meta"]["total"], 2);
    Ok(())
}

#[tokio::test]
async fn list_memories_active_status_excludes_expired_rows() -> anyhow::Result<()> {
    let _test_dir = ScopedTestDataDir::new("api-list-active-current");
    let conn = db::open_db()?;
    let current_id = memory::insert_memory(
        &conn,
        Some("session-current-list"),
        "proj-a",
        None,
        "current list row",
        "current active memory",
        "decision",
        None,
    )?;
    let expired_id = memory::insert_memory(
        &conn,
        Some("session-expired-list"),
        "proj-a",
        None,
        "expired list row",
        "expired active memory",
        "decision",
        None,
    )?;
    conn.execute(
        "UPDATE memories SET expires_at_epoch = 1 WHERE id = ?1",
        params![expired_id],
    )?;
    drop(conn);

    let response = handle_list_memories(
        State(DbState),
        Query(ListParams {
            project: Some("proj-a".to_string()),
            memory_type: None,
            scope: None,
            status: Some("active".to_string()),
            branch: None,
            q: None,
            limit: Some(10),
            offset: None,
        }),
    )
    .await
    .into_response();
    assert_eq!(response.status(), StatusCode::OK);

    let body = to_bytes(response.into_body(), usize::MAX).await?;
    let payload: Value = serde_json::from_slice(&body)?;
    let ids: Vec<i64> = payload["data"]
        .as_array()
        .expect("data should be array")
        .iter()
        .map(|item| item["id"].as_i64().expect("id should be i64"))
        .collect();
    assert!(ids.contains(&current_id));
    assert!(!ids.contains(&expired_id));
    assert_eq!(payload["meta"]["total"], 1);
    Ok(())
}

#[tokio::test]
async fn list_candidates_defaults_to_pending_review() -> anyhow::Result<()> {
    let _test_dir = ScopedTestDataDir::new("api-candidates-pending-review");
    let conn = db::open_db()?;
    conn.execute(
        "INSERT INTO memory_candidates
          (scope, memory_type, topic_key, text, evidence_event_ids, confidence,
           risk_class, review_status, created_at_epoch, updated_at_epoch)
         VALUES
          ('project', 'decision', 'candidate-topic', 'needs review', '[]', 0.7,
           'low', 'pending_review', 1, 1)",
        [],
    )?;
    drop(conn);

    let response = handle_list_candidates(
        State(DbState),
        Query(CandidateParams {
            project: None,
            status: None,
            limit: Some(10),
            offset: None,
        }),
    )
    .await
    .into_response();
    assert_eq!(response.status(), StatusCode::OK);

    let body = to_bytes(response.into_body(), usize::MAX).await?;
    let payload: Value = serde_json::from_slice(&body)?;
    assert_eq!(payload["meta"]["total"], 1);
    assert_eq!(payload["data"][0]["review_status"], "pending_review");
    Ok(())
}

#[tokio::test]
async fn memory_detail_includes_incoming_and_outgoing_edges() -> anyhow::Result<()> {
    let _test_dir = ScopedTestDataDir::new("api-memory-detail-edges");
    let conn = db::open_db()?;
    let old_id = memory::insert_memory(
        &conn,
        Some("session-old"),
        "proj-a",
        Some("edge-old"),
        "old",
        "old memory",
        "decision",
        None,
    )?;
    let new_id = memory::insert_memory(
        &conn,
        Some("session-new"),
        "proj-a",
        Some("edge-new"),
        "new",
        "new memory",
        "decision",
        None,
    )?;
    conn.execute(
        "INSERT INTO memory_edges
          (edge_type, from_memory_id, to_memory_id, confidence, created_at_epoch)
         VALUES ('replaces', ?1, ?2, 0.9, 1)",
        params![old_id, new_id],
    )?;
    conn.execute(
        "INSERT INTO memory_edges
          (edge_type, from_memory_id, to_memory_id, confidence, created_at_epoch)
         VALUES ('derived_from', ?1, ?2, 0.8, 2)",
        params![new_id, old_id],
    )?;
    drop(conn);

    let response = handle_memory_detail(State(DbState), Path(new_id))
        .await
        .into_response();
    assert_eq!(response.status(), StatusCode::OK);

    let body = to_bytes(response.into_body(), usize::MAX).await?;
    let payload: Value = serde_json::from_slice(&body)?;
    let edges = payload["edges"].as_array().expect("edges should be array");
    assert_eq!(edges.len(), 2);
    assert!(edges.iter().any(|edge| {
        edge["edge_type"] == "replaces"
            && edge["from_memory_id"] == old_id
            && edge["to_memory_id"] == new_id
    }));
    assert!(edges.iter().any(|edge| {
        edge["edge_type"] == "derived_from"
            && edge["from_memory_id"] == new_id
            && edge["to_memory_id"] == old_id
    }));
    Ok(())
}

#[tokio::test]
async fn graph_limits_memory_fanout_per_entity() -> anyhow::Result<()> {
    let _test_dir = ScopedTestDataDir::new("api-graph-fanout");
    let conn = db::open_db()?;
    conn.execute(
        "INSERT INTO entities (id, canonical_name, entity_type, mention_count, created_at_epoch)
         VALUES (1, 'high degree', 'topic', 999, 1)",
        [],
    )?;
    for i in 1..=205 {
        let memory_id = memory::insert_memory(
            &conn,
            Some("session-graph"),
            "proj-a",
            None,
            &format!("graph memory {i}"),
            "graph memory fanout fixture",
            "decision",
            None,
        )?;
        conn.execute(
            "INSERT INTO memory_entities (memory_id, entity_id) VALUES (?1, 1)",
            params![memory_id],
        )?;
    }
    drop(conn);

    let response = handle_graph(
        State(DbState),
        Query(GraphParams {
            project: None,
            limit: Some(1),
        }),
    )
    .await
    .into_response();
    assert_eq!(response.status(), StatusCode::OK);

    let body = to_bytes(response.into_body(), usize::MAX).await?;
    let payload: Value = serde_json::from_slice(&body)?;
    assert_eq!(payload["nodes"][0]["mems"].as_array().unwrap().len(), 200);
    Ok(())
}

#[tokio::test]
async fn graph_uses_only_current_memories_for_links() -> anyhow::Result<()> {
    let _test_dir = ScopedTestDataDir::new("api-graph-current-memories");
    let conn = db::open_db()?;
    conn.execute(
        "INSERT INTO entities (id, canonical_name, entity_type, mention_count, created_at_epoch)
         VALUES
          (1, 'left', 'topic', 10, 1),
          (2, 'right', 'topic', 9, 1)",
        [],
    )?;
    let current_id = memory::insert_memory(
        &conn,
        Some("session-current-graph"),
        "proj-a",
        None,
        "current graph row",
        "current graph memory",
        "decision",
        None,
    )?;
    let expired_id = memory::insert_memory(
        &conn,
        Some("session-expired-graph"),
        "proj-a",
        None,
        "expired graph row",
        "expired graph memory",
        "decision",
        None,
    )?;
    let stale_id = memory::insert_memory(
        &conn,
        Some("session-stale-graph"),
        "proj-a",
        None,
        "stale graph row",
        "stale graph memory",
        "decision",
        None,
    )?;
    conn.execute(
        "UPDATE memories SET expires_at_epoch = 1 WHERE id = ?1",
        params![expired_id],
    )?;
    conn.execute(
        "UPDATE memories SET status = 'stale' WHERE id = ?1",
        params![stale_id],
    )?;
    conn.execute(
        "INSERT INTO memory_entities (memory_id, entity_id) VALUES
         (?1, 1), (?1, 2),
         (?2, 1), (?2, 2),
         (?3, 1)",
        params![current_id, expired_id, stale_id],
    )?;
    drop(conn);

    let response = handle_graph(
        State(DbState),
        Query(GraphParams {
            project: None,
            limit: Some(2),
        }),
    )
    .await
    .into_response();
    assert_eq!(response.status(), StatusCode::OK);

    let body = to_bytes(response.into_body(), usize::MAX).await?;
    let payload: Value = serde_json::from_slice(&body)?;
    let left_node = payload["nodes"]
        .as_array()
        .expect("nodes should be array")
        .iter()
        .find(|node| node["id"] == 1)
        .expect("left node should exist");
    let left_mems: Vec<i64> = left_node["mems"]
        .as_array()
        .expect("mems should be array")
        .iter()
        .map(|id| id.as_i64().expect("memory id should be i64"))
        .collect();
    assert_eq!(left_mems, vec![current_id]);
    assert!(!left_mems.contains(&expired_id));
    assert!(!left_mems.contains(&stale_id));
    assert_eq!(payload["edges"][0]["w"], 1);
    Ok(())
}

#[tokio::test]
async fn stats_excludes_expired_active_memories_and_counts_pending_review() -> anyhow::Result<()> {
    let _test_dir = ScopedTestDataDir::new("api-stats-current");
    let conn = db::open_db()?;
    memory::insert_memory(
        &conn,
        Some("session-current"),
        "proj-a",
        None,
        "current",
        "current memory",
        "decision",
        None,
    )?;
    let expired_id = memory::insert_memory(
        &conn,
        Some("session-expired"),
        "proj-a",
        None,
        "expired",
        "expired active memory",
        "procedure",
        None,
    )?;
    conn.execute(
        "UPDATE memories SET expires_at_epoch = 1 WHERE id = ?1",
        params![expired_id],
    )?;
    conn.execute(
        "INSERT INTO memory_candidates
          (scope, memory_type, topic_key, text, evidence_event_ids, confidence,
           risk_class, review_status, created_at_epoch, updated_at_epoch)
         VALUES
          ('project', 'decision', 'stats-topic', 'needs review', '[]', 0.7,
           'low', 'pending_review', 1, 1)",
        [],
    )?;
    drop(conn);

    let response = handle_stats(State(DbState)).await.into_response();
    assert_eq!(response.status(), StatusCode::OK);

    let body = to_bytes(response.into_body(), usize::MAX).await?;
    let payload: Value = serde_json::from_slice(&body)?;
    assert_eq!(payload["active_memories"], 1);
    assert_eq!(payload["pending_candidates"], 1);
    assert_eq!(payload["type_distribution"][0]["memory_type"], "decision");
    assert_eq!(payload["type_distribution"][0]["count"], 1);
    Ok(())
}

#[tokio::test]
async fn router_does_not_emit_cors_allow_origin_for_localhost_origin() {
    let _test_dir = ScopedTestDataDir::new("api-no-cors");
    crate::api::ensure_api_token().expect("API token should be created");
    let token = crate::api::load_api_token().expect("API token should load");
    let app = super::build_router(0).with_state(DbState);

    let response = app
        .oneshot(
            Request::builder()
                .method(Method::GET)
                .uri("/api/v1/status")
                .header(header::AUTHORIZATION, format!("Bearer {token}"))
                .header(header::ORIGIN, "http://localhost:3000")
                .body(Body::empty())
                .expect("request should build"),
        )
        .await
        .expect("request should complete");

    assert_eq!(response.status(), StatusCode::OK);
    assert!(response
        .headers()
        .get(header::ACCESS_CONTROL_ALLOW_ORIGIN)
        .is_none());
}

#[tokio::test]
async fn status_handler_matches_shared_system_stats() {
    let _test_dir = ScopedTestDataDir::new("api-status-stats");
    let conn = db::open_db().expect("db should open");

    memory::insert_memory(
        &conn,
        Some("session-1"),
        "proj-a",
        None,
        "active memory",
        "kept",
        "decision",
        None,
    )
    .expect("active memory insert should succeed");
    let archived_memory_id = memory::insert_memory(
        &conn,
        Some("session-2"),
        "proj-a",
        None,
        "archived memory",
        "hidden",
        "decision",
        None,
    )
    .expect("archived memory insert should succeed");
    conn.execute(
        "UPDATE memories SET status = 'archived' WHERE id = ?1",
        params![archived_memory_id],
    )
    .expect("memory archive update should succeed");

    db::insert_observation(
        &conn,
        "session-1",
        "proj-a",
        "feature",
        Some("active observation"),
        None,
        None,
        None,
        None,
        None,
        None,
        None,
        1,
    )
    .expect("active observation insert should succeed");
    let stale_observation_id = db::insert_observation(
        &conn,
        "session-2",
        "proj-a",
        "feature",
        Some("stale observation"),
        None,
        None,
        None,
        None,
        None,
        None,
        None,
        1,
    )
    .expect("stale observation insert should succeed");
    conn.execute(
        "UPDATE observations SET status = 'stale' WHERE id = ?1",
        params![stale_observation_id],
    )
    .expect("observation stale update should succeed");

    let stats = db::query_system_stats(&conn).expect("system stats should load");
    drop(conn);

    let response = handle_status(State(DbState)).await.into_response();
    assert_eq!(response.status(), StatusCode::OK);

    let body = to_bytes(response.into_body(), usize::MAX)
        .await
        .expect("response body should read");
    let payload: Value =
        serde_json::from_slice(&body).expect("status response should be valid json");
    assert_eq!(payload["memories"], stats.active_memories);
    assert_eq!(payload["observations"], stats.active_observations);
    assert_eq!(payload["captured_events"], stats.captured_events);
    assert_eq!(payload["total_observations"], stats.total_observations);
    assert_eq!(
        payload["pending_extraction_tasks"],
        stats.pending_extraction_tasks
    );
    assert_eq!(
        payload["pending_graph_candidates"],
        stats.pending_graph_candidates
    );
    assert_eq!(
        payload["promotion_funnel"]["captured_events"],
        stats.captured_events
    );
    assert_eq!(
        payload["promotion_funnel"]["observations"],
        stats.total_observations
    );
    assert_eq!(
        payload["promotion_funnel"]["candidates"],
        stats.total_memory_candidates
    );
    assert_eq!(
        payload["promotion_funnel"]["promoted"],
        stats.promoted_memory_candidates
    );
    assert_eq!(
        payload["promotion_funnel"]["pending_review"],
        stats.pending_review_memory_candidates
    );
    assert_eq!(
        payload["promotion_funnel"]["observation_rate_percent"],
        serde_json::json!(expected_percent(
            stats.total_observations,
            stats.captured_events
        ))
    );
    assert_eq!(
        payload["promotion_funnel"]["candidate_rate_percent"],
        serde_json::json!(expected_percent(
            stats.total_memory_candidates,
            stats.total_observations
        ))
    );
    assert_eq!(
        payload["promotion_funnel"]["promoted_rate_percent"],
        serde_json::json!(expected_percent(
            stats.promoted_memory_candidates,
            stats.total_memory_candidates
        ))
    );
    assert_eq!(
        payload["promotion_funnel"]["pending_review_rate_percent"],
        serde_json::json!(expected_percent(
            stats.pending_review_memory_candidates,
            stats.total_memory_candidates
        ))
    );
}

fn expected_percent(numerator: i64, denominator: i64) -> f64 {
    if denominator <= 0 {
        0.0
    } else {
        (numerator as f64 * 100.0) / denominator as f64
    }
}