relayrl_algorithms 0.3.0

A collection of Multi-Agent Deep Reinforcement Learning Algorithms (IPPO, MAPPO, etc.)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
use crate::templates::base_algorithm::{StepAction, StepKernelTrait, WeightProvider};

use burn_tensor::backend::Backend;
use burn_tensor::{BasicOps, Float, Tensor, TensorKind};

use relayrl_types::data::tensor::{BackendMatcher, TensorData, TensorError};

use std::collections::HashMap;
use std::marker::PhantomData;

#[derive(Clone, Copy, Debug, Default)]
pub struct TD3TrainMetrics {
    pub actor_loss: f32,
    pub critic_loss: f32,
    pub policy_updated: bool,
}

pub trait TD3KernelTrait<B: Backend + BackendMatcher, InK: TensorKind<B>, OutK: TensorKind<B>>:
    StepKernelTrait<B, InK, OutK>
{
    fn new_for_actor(obs_dim: usize, act_dim: usize) -> Self;

    /// One TD3 gradient step: update twin critics, delay actor update by policy_frequency.
    fn td3_train_step(
        &mut self,
        obs: &[TensorData],
        act: &[TensorData],
        next_obs: &[TensorData],
        rew: &[f32],
        done: &[f32],
        gamma: f32,
        tau: f32,
        policy_noise: f32,
        noise_clip: f32,
        policy_frequency: u32,
    ) -> TD3TrainMetrics;
}

// ── Inference actor (B backend) ────────────────────────────────────────────────

use burn_nn::{Linear, LinearConfig, Relu};

pub struct DeterministicActorNet<B: Backend + BackendMatcher> {
    pub layers: Vec<Linear<B>>,
    pub relu: Relu,
    pub input_dim: usize,
    pub output_dim: usize,
}

impl<B: Backend + BackendMatcher> DeterministicActorNet<B> {
    pub fn new(obs_dim: usize, hidden_sizes: &[usize], act_dim: usize, device: &B::Device) -> Self {
        let mut dims = vec![obs_dim];
        dims.extend_from_slice(hidden_sizes);
        dims.push(act_dim);
        let layers = dims
            .windows(2)
            .map(|w| LinearConfig::new(w[0], w[1]).init(device))
            .collect();
        Self {
            layers,
            relu: Relu::new(),
            input_dim: obs_dim,
            output_dim: act_dim,
        }
    }

    pub fn forward(&self, input: Tensor<B, 2, Float>) -> Tensor<B, 2, Float> {
        let mut x = input;
        for (i, layer) in self.layers.iter().enumerate() {
            x = layer.forward(x);
            if i < self.layers.len() - 1 {
                x = self.relu.forward(x);
            } else {
                x = x.tanh();
            }
        }
        x
    }
}

// ── DefaultTD3Kernel ──────────────────────────────────────────────────────────

pub struct DefaultTD3Kernel<B: Backend + BackendMatcher, InK: TensorKind<B>, OutK: TensorKind<B>> {
    pub inference_actor: DeterministicActorNet<B>,
    pub obs_dim: usize,
    pub act_dim: usize,
    #[cfg(feature = "ndarray-backend")]
    pub trainer: Option<training::TD3Trainer>,
    _phantom: PhantomData<(InK, OutK)>,
}

pub type PlaceholderTD3Kernel<B, InK, OutK> = DefaultTD3Kernel<B, InK, OutK>;

impl<B: Backend + BackendMatcher, InK: TensorKind<B>, OutK: TensorKind<B>>
    DefaultTD3Kernel<B, InK, OutK>
where
    InK: BasicOps<B>,
    OutK: BasicOps<B>,
{
    pub fn new(obs_dim: usize, act_dim: usize, actor_lr: f64, critic_lr: f64) -> Self {
        let device = B::Device::default();
        let hidden_sizes = vec![256usize, 256];
        Self {
            inference_actor: DeterministicActorNet::new(obs_dim, &hidden_sizes, act_dim, &device),
            obs_dim,
            act_dim,
            #[cfg(feature = "ndarray-backend")]
            trainer: Some(training::TD3Trainer::new(
                obs_dim,
                &hidden_sizes,
                act_dim,
                actor_lr,
                critic_lr,
            )),
            _phantom: PhantomData,
        }
    }
}

impl<B: Backend + BackendMatcher, InK: TensorKind<B>, OutK: TensorKind<B>> Default
    for DefaultTD3Kernel<B, InK, OutK>
where
    InK: BasicOps<B>,
    OutK: BasicOps<B>,
{
    fn default() -> Self {
        Self::new(1, 1, 3e-4, 3e-4)
    }
}

impl<B: Backend + BackendMatcher, InK: TensorKind<B>, OutK: TensorKind<B>>
    StepKernelTrait<B, InK, OutK> for DefaultTD3Kernel<B, InK, OutK>
where
    InK: BasicOps<B>,
    OutK: BasicOps<B>,
{
    fn step<const IN_D: usize, const OUT_D: usize>(
        &self,
        obs: Tensor<B, IN_D, InK>,
        _mask: Tensor<B, OUT_D, OutK>,
    ) -> Result<(StepAction<B>, HashMap<String, TensorData>), TensorError> {
        let batch = obs.dims()[0];
        let device = B::Device::default();
        let obs_data = obs.into_data();
        let obs_flat: Tensor<B, IN_D, Float> =
            Tensor::from_data(obs_data.convert::<f32>(), &device);
        let obs_2d: Tensor<B, 2, Float> = obs_flat.reshape([batch, self.obs_dim]);
        let action = self.inference_actor.forward(obs_2d);
        Ok((StepAction::Continuous(action), HashMap::new()))
    }

    fn get_input_dim(&self) -> usize {
        self.obs_dim
    }

    fn get_output_dim(&self) -> usize {
        self.act_dim
    }
}

impl<B: Backend + BackendMatcher, InK: TensorKind<B>, OutK: TensorKind<B>>
    TD3KernelTrait<B, InK, OutK> for DefaultTD3Kernel<B, InK, OutK>
where
    InK: BasicOps<B>,
    OutK: BasicOps<B>,
{
    fn new_for_actor(obs_dim: usize, act_dim: usize) -> Self {
        Self::new(obs_dim, act_dim, 3e-4, 3e-4)
    }

    fn td3_train_step(
        &mut self,
        obs: &[TensorData],
        act: &[TensorData],
        next_obs: &[TensorData],
        rew: &[f32],
        done: &[f32],
        gamma: f32,
        tau: f32,
        policy_noise: f32,
        noise_clip: f32,
        policy_frequency: u32,
    ) -> TD3TrainMetrics {
        #[cfg(feature = "ndarray-backend")]
        if let Some(trainer) = &mut self.trainer {
            return trainer.train_step(
                obs,
                act,
                next_obs,
                rew,
                done,
                gamma,
                tau,
                policy_noise,
                noise_clip,
                policy_frequency,
            );
        }
        TD3TrainMetrics::default()
    }
}

#[cfg(feature = "ndarray-backend")]
impl<B: Backend + BackendMatcher, InK: TensorKind<B>, OutK: TensorKind<B>> WeightProvider
    for DefaultTD3Kernel<B, InK, OutK>
where
    InK: BasicOps<B>,
    OutK: BasicOps<B>,
{
    fn get_pi_layer_specs(&self) -> Option<Vec<(usize, usize, Vec<f32>, Vec<f32>)>> {
        let trainer = self.trainer.as_ref()?;
        let actor = trainer.actor.as_ref()?;
        let mut specs = Vec::new();
        for layer in &actor.layers {
            let w = layer.weight.val();
            let dims = w.dims();
            let in_dim = dims[0];
            let out_dim = dims[1];
            let weights: Vec<f32> = w.into_data().to_vec::<f32>().unwrap_or_default();
            let biases: Vec<f32> = if let Some(bp) = &layer.bias {
                bp.val().into_data().to_vec::<f32>().unwrap_or_default()
            } else {
                vec![0.0; out_dim]
            };
            specs.push((in_dim, out_dim, weights, biases));
        }
        Some(specs)
    }
}

// ── Training backend ──────────────────────────────────────────────────────────

#[cfg(feature = "ndarray-backend")]
pub mod training {
    use super::TD3TrainMetrics;

    extern crate burn_core as burn;

    use burn_autodiff::Autodiff;
    use burn_core::module::{Module, Param, ParamId};
    use burn_ndarray::NdArray;
    use burn_nn::{Linear, LinearConfig, Relu};
    use burn_optim::adaptor::OptimizerAdaptor;
    use burn_optim::{Adam, AdamConfig, GradientsParams, Optimizer};
    use burn_tensor::backend::Backend;
    use burn_tensor::{Float, Tensor, TensorData as BurnTensorData};
    use rand::RngExt;
    use relayrl_types::prelude::tensor::relayrl::TensorData;

    pub type TB = Autodiff<NdArray>;

    // ── Actor MLP ────────────────────────────────────────────────────────────

    #[derive(Module, Debug)]
    pub struct ActorMlp<B: burn_tensor::backend::Backend> {
        pub layers: Vec<Linear<B>>,
        pub relu: Relu,
        pub obs_dim: usize,
        pub act_dim: usize,
    }

    impl<B: burn_tensor::backend::Backend> ActorMlp<B> {
        pub fn new(
            obs_dim: usize,
            hidden_sizes: &[usize],
            act_dim: usize,
            device: &B::Device,
        ) -> Self {
            let mut dims = vec![obs_dim];
            dims.extend_from_slice(hidden_sizes);
            dims.push(act_dim);
            let layers = dims
                .windows(2)
                .map(|w| LinearConfig::new(w[0], w[1]).init(device))
                .collect();
            Self {
                layers,
                relu: Relu::new(),
                obs_dim,
                act_dim,
            }
        }

        pub fn forward(&self, input: Tensor<B, 2, Float>) -> Tensor<B, 2, Float> {
            let mut x = input;
            for (i, layer) in self.layers.iter().enumerate() {
                x = layer.forward(x);
                if i < self.layers.len() - 1 {
                    x = self.relu.forward(x);
                } else {
                    x = x.tanh();
                }
            }
            x
        }
    }

    // ── Twin Critic MLP (Q1 + Q2) ────────────────────────────────────────────

    #[derive(Module, Debug)]
    pub struct TwinCriticMlp<B: burn_tensor::backend::Backend> {
        pub q1_layers: Vec<Linear<B>>,
        pub q2_layers: Vec<Linear<B>>,
        pub relu: Relu,
        pub input_dim: usize,
    }

    impl<B: burn_tensor::backend::Backend> TwinCriticMlp<B> {
        pub fn new(
            obs_dim: usize,
            act_dim: usize,
            hidden_sizes: &[usize],
            device: &B::Device,
        ) -> Self {
            let input_dim = obs_dim + act_dim;
            let mut dims = vec![input_dim];
            dims.extend_from_slice(hidden_sizes);
            dims.push(1);
            let q1_layers = dims
                .windows(2)
                .map(|w| LinearConfig::new(w[0], w[1]).init(device))
                .collect();
            let q2_layers = dims
                .windows(2)
                .map(|w| LinearConfig::new(w[0], w[1]).init(device))
                .collect();
            Self {
                q1_layers,
                q2_layers,
                relu: Relu::new(),
                input_dim,
            }
        }

        fn forward_q(
            layers: &[Linear<B>],
            relu: &Relu,
            obs: Tensor<B, 2, Float>,
            act: Tensor<B, 2, Float>,
        ) -> Tensor<B, 2, Float> {
            let mut x = Tensor::cat(vec![obs, act], 1);
            for (i, layer) in layers.iter().enumerate() {
                x = layer.forward(x);
                if i < layers.len() - 1 {
                    x = relu.forward(x);
                }
            }
            x
        }

        pub fn forward_both(
            &self,
            obs: Tensor<B, 2, Float>,
            act: Tensor<B, 2, Float>,
        ) -> (Tensor<B, 2, Float>, Tensor<B, 2, Float>) {
            let q1 = Self::forward_q(&self.q1_layers, &self.relu, obs.clone(), act.clone());
            let q2 = Self::forward_q(&self.q2_layers, &self.relu, obs, act);
            (q1, q2)
        }

        pub fn forward_q1(
            &self,
            obs: Tensor<B, 2, Float>,
            act: Tensor<B, 2, Float>,
        ) -> Tensor<B, 2, Float> {
            Self::forward_q(&self.q1_layers, &self.relu, obs, act)
        }
    }

    // ── Single Critic for targets (NdArray) ───────────────────────────────────

    #[derive(Module, Debug)]
    pub struct CriticMlp<B: burn_tensor::backend::Backend> {
        pub layers: Vec<Linear<B>>,
        pub relu: Relu,
        pub input_dim: usize,
    }

    impl<B: burn_tensor::backend::Backend> CriticMlp<B> {
        pub fn new(
            obs_dim: usize,
            act_dim: usize,
            hidden_sizes: &[usize],
            device: &B::Device,
        ) -> Self {
            let input_dim = obs_dim + act_dim;
            let mut dims = vec![input_dim];
            dims.extend_from_slice(hidden_sizes);
            dims.push(1);
            let layers = dims
                .windows(2)
                .map(|w| LinearConfig::new(w[0], w[1]).init(device))
                .collect();
            Self {
                layers,
                relu: Relu::new(),
                input_dim,
            }
        }

        pub fn forward(
            &self,
            obs: Tensor<B, 2, Float>,
            act: Tensor<B, 2, Float>,
        ) -> Tensor<B, 2, Float> {
            let mut x = Tensor::cat(vec![obs, act], 1);
            for (i, layer) in self.layers.iter().enumerate() {
                x = layer.forward(x);
                if i < self.layers.len() - 1 {
                    x = self.relu.forward(x);
                }
            }
            x
        }
    }

    // ── TD3Trainer ────────────────────────────────────────────────────────────

    pub struct TD3Trainer {
        pub actor: Option<ActorMlp<TB>>,
        pub actor_target: Option<ActorMlp<NdArray>>,
        pub critic: Option<TwinCriticMlp<TB>>,
        pub critic_target: Option<CriticMlp<NdArray>>,
        pub actor_optimizer: OptimizerAdaptor<Adam, ActorMlp<TB>, TB>,
        pub critic_optimizer: OptimizerAdaptor<Adam, TwinCriticMlp<TB>, TB>,
        pub actor_lr: f64,
        pub critic_lr: f64,
        pub obs_dim: usize,
        pub act_dim: usize,
        hidden_sizes: Vec<usize>,
        total_it: u64,
    }

    impl TD3Trainer {
        pub fn new(
            obs_dim: usize,
            hidden_sizes: &[usize],
            act_dim: usize,
            actor_lr: f64,
            critic_lr: f64,
        ) -> Self {
            let device_tb = <TB as Backend>::Device::default();
            let device_nd = <NdArray as Backend>::Device::default();
            Self {
                actor: Some(ActorMlp::new(obs_dim, hidden_sizes, act_dim, &device_tb)),
                actor_target: Some(ActorMlp::new(obs_dim, hidden_sizes, act_dim, &device_nd)),
                critic: Some(TwinCriticMlp::new(
                    obs_dim,
                    act_dim,
                    hidden_sizes,
                    &device_tb,
                )),
                critic_target: Some(CriticMlp::new(obs_dim, act_dim, hidden_sizes, &device_nd)),
                actor_optimizer: AdamConfig::new().init::<TB, ActorMlp<TB>>(),
                critic_optimizer: AdamConfig::new().init::<TB, TwinCriticMlp<TB>>(),
                actor_lr,
                critic_lr,
                obs_dim,
                act_dim,
                hidden_sizes: hidden_sizes.to_vec(),
                total_it: 0,
            }
        }

        pub fn train_step(
            &mut self,
            obs_tensors: &[TensorData],
            act_tensors: &[TensorData],
            next_obs_tensors: &[TensorData],
            rewards: &[f32],
            dones: &[f32],
            gamma: f32,
            tau: f32,
            policy_noise: f32,
            noise_clip: f32,
            policy_frequency: u32,
        ) -> TD3TrainMetrics {
            self.total_it += 1;
            let n = obs_tensors
                .len()
                .min(act_tensors.len())
                .min(next_obs_tensors.len())
                .min(rewards.len())
                .min(dones.len());
            if n == 0 {
                return TD3TrainMetrics::default();
            }

            let actor = match self.actor.take() {
                Some(a) => a,
                None => return TD3TrainMetrics::default(),
            };
            let critic = match self.critic.take() {
                Some(c) => c,
                None => {
                    self.actor = Some(actor);
                    return TD3TrainMetrics::default();
                }
            };
            let actor_target = match self.actor_target.take() {
                Some(a) => a,
                None => {
                    self.actor = Some(actor);
                    self.critic = Some(critic);
                    return TD3TrainMetrics::default();
                }
            };
            let critic_target = match self.critic_target.take() {
                Some(c) => c,
                None => {
                    self.actor = Some(actor);
                    self.critic = Some(critic);
                    self.actor_target = Some(actor_target);
                    return TD3TrainMetrics::default();
                }
            };

            let device_tb = <TB as Backend>::Device::default();
            let device_nd = <NdArray as Backend>::Device::default();

            let obs = Tensor::<TB, 2, Float>::from_data(
                BurnTensorData::new(tensor_flat(obs_tensors), [n, self.obs_dim]),
                &device_tb,
            );
            let act = Tensor::<TB, 2, Float>::from_data(
                BurnTensorData::new(tensor_flat(act_tensors), [n, self.act_dim]),
                &device_tb,
            );
            let next_obs_nd = Tensor::<NdArray, 2, Float>::from_data(
                BurnTensorData::new(tensor_flat(next_obs_tensors), [n, self.obs_dim]),
                &device_nd,
            );
            let rew = Tensor::<TB, 1, Float>::from_data(
                BurnTensorData::new(rewards[..n].to_vec(), [n]),
                &device_tb,
            );
            let done = Tensor::<TB, 1, Float>::from_data(
                BurnTensorData::new(dones[..n].to_vec(), [n]),
                &device_tb,
            );

            // Target policy smoothing: next_act = clamp(actor_target(s') + noise, -1, 1)
            let next_act_raw_nd = actor_target.forward(next_obs_nd.clone());
            let noise_nd: Vec<f32> = (0..n * self.act_dim)
                .map(|_| {
                    use rand::Rng;
                    let v: f32 = rand::rng().random::<f32>() * 2.0 - 1.0;
                    v.clamp(-noise_clip, noise_clip) * policy_noise
                })
                .collect();
            let noise_tensor_nd = Tensor::<NdArray, 2, Float>::from_data(
                BurnTensorData::new(noise_nd, [n, self.act_dim]),
                &device_nd,
            );
            let next_act_nd = (next_act_raw_nd + noise_tensor_nd).clamp(-1.0, 1.0);

            // Target Q: min(Q1_target, Q2_target) — approximate with single critic target
            let tgt_q1_nd = critic_target
                .forward(next_obs_nd.clone(), next_act_nd.clone())
                .reshape([n]);
            // Use same critic_target for Q2 approximation (single target critic for simplicity)
            let tgt_q2_nd = critic_target.forward(next_obs_nd, next_act_nd).reshape([n]);
            let tgt_q_vals: Vec<f32> = tgt_q1_nd
                .into_data()
                .to_vec::<f32>()
                .unwrap_or_else(|_| vec![0.0; n])
                .iter()
                .zip(
                    tgt_q2_nd
                        .into_data()
                        .to_vec::<f32>()
                        .unwrap_or_else(|_| vec![0.0; n])
                        .iter(),
                )
                .map(|(a, b)| a.min(*b))
                .collect();
            let tgt_q_tb =
                Tensor::<TB, 1, Float>::from_data(BurnTensorData::new(tgt_q_vals, [n]), &device_tb);
            let not_done = done.neg().add_scalar(1.0f32);
            let target = rew + not_done * tgt_q_tb * gamma;

            // ── Twin critic update ────────────────────────────────────────────
            let (q1, q2) = critic.forward_both(obs.clone(), act.clone());
            let critic_loss = (q1.reshape([n]) - target.clone()).powf_scalar(2.0).mean()
                + (q2.reshape([n]) - target).powf_scalar(2.0).mean();
            let critic_loss_val = scalar_f32(&critic_loss);
            let grads_c = critic_loss.backward();
            let critic_grads =
                GradientsParams::from_grads::<TB, TwinCriticMlp<TB>>(grads_c, &critic);
            let critic = self
                .critic_optimizer
                .step(self.critic_lr, critic, critic_grads);

            // ── Delayed actor update ──────────────────────────────────────────
            let policy_updated = self.total_it % policy_frequency as u64 == 0;
            let actor_loss_val;
            let actor = if policy_updated {
                let actor_actions = actor.forward(obs.clone());
                let actor_q = critic.forward_q1(obs, actor_actions).reshape([n]).mean();
                let actor_loss = actor_q.neg();
                actor_loss_val = scalar_f32(&actor_loss);
                let grads_a = actor_loss.backward();
                let actor_grads = GradientsParams::from_grads::<TB, ActorMlp<TB>>(grads_a, &actor);
                self.actor_optimizer.step(self.actor_lr, actor, actor_grads)
            } else {
                actor_loss_val = 0.0;
                actor
            };

            // ── Soft update targets ───────────────────────────────────────────
            if policy_updated {
                let mut actor_target = actor_target;
                soft_update_actor(&actor, &mut actor_target, tau);
                self.actor_target = Some(actor_target);
            } else {
                self.actor_target = Some(actor_target);
            }

            let mut critic_target = critic_target;
            soft_update_critic_target(&critic, &mut critic_target, tau);

            self.actor = Some(actor);
            self.critic = Some(critic);
            self.critic_target = Some(critic_target);

            TD3TrainMetrics {
                actor_loss: actor_loss_val,
                critic_loss: critic_loss_val,
                policy_updated,
            }
        }
    }

    fn soft_update_actor(actor: &ActorMlp<TB>, target: &mut ActorMlp<NdArray>, tau: f32) {
        for (a_layer, t_layer) in actor.layers.iter().zip(target.layers.iter_mut()) {
            let cur_w = a_layer.weight.val().inner();
            let tgt_w = t_layer.weight.val();
            t_layer.weight = Param::initialized(ParamId::new(), cur_w * tau + tgt_w * (1.0 - tau));
            if let (Some(cb), Some(tb)) = (&a_layer.bias, &mut t_layer.bias) {
                let cw = cb.val().inner();
                let tw = tb.val();
                *tb = Param::initialized(ParamId::new(), cw * tau + tw * (1.0 - tau));
            }
        }
    }

    fn soft_update_critic_target(
        critic: &TwinCriticMlp<TB>,
        target: &mut CriticMlp<NdArray>,
        tau: f32,
    ) {
        // Update target using Q1 layers from twin critic
        for (c_layer, t_layer) in critic.q1_layers.iter().zip(target.layers.iter_mut()) {
            let cur_w = c_layer.weight.val().inner();
            let tgt_w = t_layer.weight.val();
            t_layer.weight = Param::initialized(ParamId::new(), cur_w * tau + tgt_w * (1.0 - tau));
            if let (Some(cb), Some(tb)) = (&c_layer.bias, &mut t_layer.bias) {
                let cw = cb.val().inner();
                let tw = tb.val();
                *tb = Param::initialized(ParamId::new(), cw * tau + tw * (1.0 - tau));
            }
        }
    }

    fn scalar_f32(t: &Tensor<TB, 1, Float>) -> f32 {
        t.clone()
            .into_data()
            .to_vec::<f32>()
            .unwrap_or_else(|_| vec![0.0])[0]
    }

    pub fn tensor_flat(tensors: &[TensorData]) -> Vec<f32> {
        tensors
            .iter()
            .flat_map(|t| bytemuck::cast_slice::<u8, f32>(&t.data).to_vec())
            .collect()
    }
}