relay-knowledge 1.1.6

Graph-database-based knowledge graph project.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
use crate::domain::{CodeParseStatus, CodeRepositoryRegistration};

use super::*;

#[test]
fn gcc_recovery_tracks_multiline_body_delimiters() {
    let snapshot = parse_source_snapshot(
        "external_deps/sdk/multiline_policy.c",
        br#"
int pdp_helper(int value, int marker)
{
    return value + marker;
}

attribute((always_inline)) int pdp_multiline_policy(int value)
{
    return pdp_helper(
        value,
        '['
    );
}
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "multi-line valid statements should not block decorated recovery: {:?}",
        snapshot.diagnostics
    );
    assert!(
        snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "pdp_multiline_policy")
    );
}

#[test]
fn gcc_recovery_requires_decorator_for_function_error() {
    let snapshot = parse_source_snapshot(
        "src/plain_broken.c",
        br#"
int valid_plain_symbol(void)
{
    return 1;
}

int broken_plain_function(int left,, int right) @
{
    return left + right;
}
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Partial,
        "ordinary malformed function syntax must not be recovered as a compiler extension"
    );
    assert!(
        !recoverable_decorated_function_error_text(
            "int broken_plain_function(int left,, int right) { return left + right; }"
        ),
        "function ERROR recovery must require a compiler-extension decorator"
    );
    assert!(
        !snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "broken_plain_function"),
        "ordinary malformed C ERROR nodes must not be indexed as recovered functions: {:?}",
        snapshot.symbols
    );
}

#[test]
fn gcc_recovery_ignores_decorator_tokens_inside_parameters() {
    let snapshot = parse_source_snapshot(
        "src/plain_parameter_name.c",
        br#"
int valid_plain_symbol(void)
{
    return 1;
}

int broken_parameter_name(int attribute,, int right) @
{
    return right;
}
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Partial,
        "parameter names that match decorator tokens must not prove GCC recovery"
    );
    assert!(
        !snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "broken_parameter_name"),
        "ordinary malformed C ERROR nodes must not be indexed as decorated functions: {:?}",
        snapshot.symbols
    );
}

#[test]
fn gcc_recovery_ignores_literals_in_attribute_payloads() {
    let snapshot = parse_source_snapshot(
        "external_deps/sdk/annotated_policy.c",
        br#"
__attribute__((annotate("("))) int pdp_annotated_policy(void)
{
    return 1;
}

__declspec(dllexport) int pdp_exported_policy(void)
{
    return 1;
}

__attribute__((unused)) int pdp_unused_policy(void)
{
    return 1;
}
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "attribute payload literals should not hide the real function parameter list: {:?}",
        snapshot.diagnostics
    );
    assert!(
        snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "pdp_annotated_policy")
    );
    assert!(
        snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "pdp_exported_policy"),
        "decorator payload tokens before C return types should be accepted: {:?}",
        snapshot.symbols
    );
    assert!(
        snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "pdp_unused_policy"),
        "parsed C declarators should still be indexed when narrow recovery rejects a decorator: {:?}",
        snapshot.symbols
    );
}

#[test]
fn gcc_recovery_finds_body_after_attribute_payload_braces() {
    let snapshot = parse_source_snapshot(
        "external_deps/sdk/brace_annotated_policy.c",
        br#"
__attribute__((annotate("{"))) int pdp_brace_annotated_policy(void)
{
    return 1;
}
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "attribute payload braces should not hide the real function body: {:?}",
        snapshot.diagnostics
    );
    assert!(
        snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "pdp_brace_annotated_policy"),
        "decorated function symbol should be recovered from the real body head: {:?}",
        snapshot.symbols
    );
}

#[test]
fn gcc_recovery_keeps_postfix_attribute_payload_scanning_literal_aware() {
    let snapshot = parse_source_snapshot(
        "external_deps/sdk/postfix_literal_policy.c",
        br#"
int pdp_postfix_literal_policy(void) attribute((annotate(")")))
{
    return 1;
}
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "postfix attribute payload literals should not truncate the attribute tail: {:?}",
        snapshot.diagnostics
    );
    assert!(
        snapshot.symbols.iter().any(|symbol| {
            symbol.kind == "function" && symbol.name == "pdp_postfix_literal_policy"
        }),
        "postfix literal payload function should be recovered: {:?}",
        snapshot.symbols
    );
}

#[test]
fn gcc_recovery_handles_line_comments_in_multiline_parameter_lists() {
    let snapshot = parse_source_snapshot(
        "external_deps/sdk/commented_params.c",
        br#"
__always_inline int pdp_commented_parameters(
    int left, // primary value
    int right
)
{
    return left + right;
}
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "line comments in multiline parameter lists should not truncate recovery scans: {:?}",
        snapshot.diagnostics
    );
    assert!(
        snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "pdp_commented_parameters"),
        "commented multiline parameter function should be recovered: {:?}",
        snapshot.symbols
    );
}

#[test]
fn cpp_decorated_type_recovery_tracks_multiline_member_delimiters() {
    let snapshot = parse_source_snapshot(
        "external_deps/sdk/multiline_widget.hpp",
        br#"
#define RK_API __attribute__((visibility("default")))

RK_API class PdpMultilineWidget {
 public:
    void update(
        int value,
        const char *name
    );
};
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "multiline member declarations should not block decorated type recovery: {:?}",
        snapshot.diagnostics
    );
    assert!(
        snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "class" && symbol.name == "PdpMultilineWidget"),
        "decorated class symbol should still be recovered: {:?}",
        snapshot.symbols
    );
}

#[test]
fn gcc_recovery_accepts_labels_and_multiline_comments() {
    let snapshot = parse_source_snapshot(
        "external_deps/sdk/labeled_policy.c",
        br#"
attribute((always_inline)) int pdp_labeled_policy(int token)
{
    /* explain
     * branch mapping
     */
    switch (token) {
    case 1:
        return token;
    default:
        goto done;
    }
done:
    return 0;
}
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "labels and multiline comments should not block decorated recovery: {:?}",
        snapshot.diagnostics
    );
    assert!(
        snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "pdp_labeled_policy")
    );
}

#[test]
fn cpp_gcc_recovery_accepts_suffix_qualifiers_and_default_arguments() {
    let snapshot = parse_source_snapshot(
        "external_deps/sdk/qualified_policy.cpp",
        br#"
namespace ns {
class Policy {
 public:
    int size() const;
};
}

__always_inline int ns::Policy::size() const
{
    return 1;
}

__always_inline int limit_for(int value) noexcept
{
    if (value) {
    }
}
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "C++ default arguments and suffix qualifiers should remain recoverable: {:?}",
        snapshot.diagnostics
    );
    for name in ["size", "limit_for"] {
        assert!(
            snapshot.symbols.iter().any(|symbol| {
                matches!(symbol.kind.as_str(), "function" | "method") && symbol.name == name
            }),
            "{name} should be recovered from decorated C++ code: {:?}",
            snapshot.symbols
        );
    }
    assert!(
        recoverable_decorated_function_error_text(
            "__always_inline int limit_for(int value = 1) noexcept { return value; }"
        ),
        "decorated C++ recovery should allow default values inside the parameter list"
    );
    assert!(
        recoverable_decorated_function_error_text(
            "__always_inline int limit_for(const char *value = \")\") { return value[0]; }"
        ),
        "default-argument literals should not truncate the parameter list"
    );
}

#[test]
fn cpp_gcc_recovery_requires_decorator_for_error_functions() {
    let snapshot = parse_source_snapshot(
        "src/plain_broken.cpp",
        br#"
int valid_cpp_symbol()
{
    return 1;
}

int broken_cpp_function(int left,, int right) @
{
    return left + right;
}
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Partial,
        "ordinary malformed C++ functions must not be recovered as compiler extensions"
    );
    assert!(
        !snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "broken_cpp_function"),
        "ordinary malformed C++ ERROR nodes must not be indexed as recovered functions: {:?}",
        snapshot.symbols
    );
}

#[test]
fn cpp_gcc_recovery_accepts_template_return_types_and_operators() {
    let source = br#"
namespace ns {
class Policy {};
}

__always_inline std::vector<int> BuildPolicyIds()
{
    return {};
}

__always_inline bool ns::operator==(const ns::Policy &rhs)
{
    return &rhs != nullptr;
}
"#;
    let snapshot = parse_source_snapshot("external_deps/sdk/template_operator_policy.cpp", source);

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "template return types and operator declarators should remain recoverable: {:?}",
        snapshot.diagnostics
    );
    for name in ["BuildPolicyIds", "operator=="] {
        assert!(
            snapshot
                .symbols
                .iter()
                .any(|symbol| symbol.kind == "function" && symbol.name == name),
            "{name} should be recovered from decorated C++ code: {:?}",
            snapshot.symbols
        );
    }
}

#[test]
fn gcc_recovery_handles_literal_payloads_and_rejects_type_body_expressions() {
    let function_snapshot = parse_source_snapshot(
        "external_deps/sdk/key_value_policy.c",
        br#"
__attribute__((annotate("key=value"))) int key_value_policy(void)
{
    return 1;
}
"#,
    );
    assert_eq!(
        function_snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "attribute payload literals should not look like initializer syntax: {:?}",
        function_snapshot.diagnostics
    );
    assert!(
        function_snapshot
            .symbols
            .iter()
            .any(|symbol| { symbol.kind == "function" && symbol.name == "key_value_policy" })
    );

    let type_snapshot = parse_source_snapshot(
        "external_deps/sdk/literal_widget.hpp",
        br#"
__attribute__((annotate("{"))) class LiteralWidget {
 public:
    int value;
};
"#,
    );
    assert_eq!(
        type_snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "type attribute payload braces should not hide the real body: {:?}",
        type_snapshot.diagnostics
    );
    assert!(
        type_snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "class" && symbol.name == "LiteralWidget")
    );

    assert!(
        !recoverable_decorated_type_error_text(
            "RK_API class BrokenWidget { public: int value; value++; };"
        ),
        "expression statements inside decorated type bodies must not be recoverable"
    );

    let invalid_inline_body_snapshot = parse_source_snapshot(
        "include/broken_inline_exported.hpp",
        br#"
RK_API class BrokenWidget {
 public:
    int Run() { return @; }
};
"#,
    );
    assert_eq!(
        invalid_inline_body_snapshot.files[0].parse_status,
        CodeParseStatus::Partial,
        "invalid inline method bodies should keep diagnostics visible: symbols={:?}; diagnostics={:?}",
        invalid_inline_body_snapshot.symbols,
        invalid_inline_body_snapshot.diagnostics
    );
}

#[test]
fn cpp_gcc_recovery_scans_literals_and_skips_destructor_symbols() {
    let literal_snapshot = parse_source_snapshot(
        "external_deps/sdk/cpp_literal_policy.cpp",
        br#"
__attribute__((annotate("("))) int annotated_cpp_policy()
{
    return 1;
}
"#,
    );
    assert_eq!(
        literal_snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "C++ symbol recovery should ignore literal parentheses in attributes: {:?}",
        literal_snapshot.diagnostics
    );
    assert!(
        literal_snapshot
            .symbols
            .iter()
            .any(|symbol| { symbol.kind == "function" && symbol.name == "annotated_cpp_policy" })
    );

    let destructor_snapshot = parse_source_snapshot(
        "external_deps/sdk/destructor_policy.cpp",
        br#"
namespace ns {
class Policy {
 public:
    ~Policy();
};
}

__always_inline ns::Policy::~Policy()
{
}

void cleanup()
{
    log("~cleanup");
}

void cleanup_inline() { log("Policy::~Policy"); }
"#,
    );
    assert!(
        !destructor_snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "Policy"),
        "decorated destructors must not be indexed as class-named functions: {:?}",
        destructor_snapshot.symbols
    );
    assert!(
        destructor_snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "cleanup"),
        "normal functions mentioning destructor-like text in the body should still be indexed: {:?}",
        destructor_snapshot.symbols
    );
    assert!(
        destructor_snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "cleanup_inline"),
        "one-line functions mentioning destructor-like text in the signature excerpt should still be indexed: {:?}",
        destructor_snapshot.symbols
    );
}

#[test]
fn gcc_recovery_rejects_malformed_parameter_lists_and_c_suffixes() {
    let c_snapshot = parse_source_snapshot(
        "external_deps/sdk/malformed_tail.c",
        br#"
int valid_c_symbol(void) { return 1; }

int broken_plain_prototype(void)

int postfix_garbage(void) attribute((always_inline)) garbage
{
    return 1;
}

__always_inline int broken_slots(int left,, int right)
{
    return left + right;
}

__always_inline 123 malformed_head(void)
{
    return 1;
}

__always_inline int c_method_suffix(void) const
{
    return 1;
}

__always_inline int c_operator_syntax(int value)
{
    return value;
}

__always_inline int operator+(int value)
{
    return value;
}

__always_inline int invalid_body_token(void)
{
    return @;
}

__always_inline int pending_assignment(void)
{
    int value = // missing initializer
    ;
    return value;
}
"#,
    );

    assert_eq!(c_snapshot.files[0].parse_status, CodeParseStatus::Partial);
    for name in [
        "postfix_garbage",
        "broken_slots",
        "malformed_head",
        "c_method_suffix",
        "operator+",
        "invalid_body_token",
        "pending_assignment",
    ] {
        assert!(
            !c_snapshot
                .symbols
                .iter()
                .any(|symbol| symbol.kind == "function" && symbol.name == name),
            "{name} should not be recovered from malformed C syntax: {:?}",
            c_snapshot.symbols
        );
    }
    assert!(
        !recoverable_decorated_function_error_text(
            "__always_inline int invalid_body_token(void) { return @; }"
        ),
        "decorated function recovery must reject invalid body tokens"
    );
    assert!(
        !recoverable_decorated_function_error_text(
            "__always_inline int pending_assignment(void) { int value = // missing initializer\n; return value; }"
        ),
        "decorated function recovery must carry pending assignments across body lines"
    );
    assert!(
        c_snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "c_operator_syntax"),
        "ordinary valid C functions near invalid operator syntax should still be indexed: {:?}",
        c_snapshot.symbols
    );
    assert!(
        !recoverable_c_family_error_line("int broken_plain_prototype(void)"),
        "plain builtin prototypes without a terminator are ordinary syntax errors"
    );
}

#[test]
fn cpp_gcc_recovery_validates_tails_and_conversion_operators() {
    let snapshot = parse_source_snapshot(
        "external_deps/sdk/conversion_policy.cpp",
        br#"
namespace ns {
class Policy {};
}

__always_inline ns::Policy::operator bool() const
{
    return true;
}

__always_inline int malformed_tail() garbage
{
    return 1;
}

__always_inline int malformed_slots(int left,, int right)
{
    return left + right;
}

__always_inline int invalid_body_token()
{
    return @;
}
"#,
    );

    assert_eq!(snapshot.files[0].parse_status, CodeParseStatus::Partial);
    assert!(
        snapshot
            .symbols
            .iter()
            .any(|symbol| symbol.kind == "function" && symbol.name == "operator bool"),
        "conversion operator should be recovered: {:?}",
        snapshot.symbols
    );
    for name in ["malformed_tail", "malformed_slots", "invalid_body_token"] {
        assert!(
            !snapshot
                .symbols
                .iter()
                .any(|symbol| symbol.kind == "function" && symbol.name == name),
            "{name} should not be indexed from malformed C++ syntax: {:?}",
            snapshot.symbols
        );
    }
}

#[test]
fn gcc_recovery_accepts_arbitrary_attribute_payload_tokens() {
    let snapshot = parse_source_snapshot(
        "external_deps/sdk/attribute_payloads.c",
        br#"
__attribute__((nonnull(1))) int accepts_nonnull(char *value)
{
    return value != 0;
}

__attribute__((section(".init"))) int accepts_section(void)
{
    return 1;
}
"#,
    );

    assert_eq!(
        snapshot.files[0].parse_status,
        CodeParseStatus::Parsed,
        "valid attribute payloads should not block recovery: {:?}",
        snapshot.diagnostics
    );
    for name in ["accepts_nonnull", "accepts_section"] {
        assert!(
            snapshot
                .symbols
                .iter()
                .any(|symbol| symbol.kind == "function" && symbol.name == name),
            "{name} should be recovered from valid GCC attribute payloads: {:?}",
            snapshot.symbols
        );
    }
}

fn parse_source_snapshot(path: &str, source: &[u8]) -> crate::domain::CodeIndexSnapshot {
    let registration =
        CodeRepositoryRegistration::new("repo", "alias", "/tmp/repo", Vec::new(), Vec::new())
            .expect("registration should validate");
    let mut build = SnapshotBuild::new(
        &registration,
        "commit".to_owned(),
        "tree".to_owned(),
        true,
        1,
        0,
    );

    parse_indexed_file(&mut build, path, source).expect("file should parse");

    build.finish()
}