relay-knowledge 1.1.10

Graph-database-based knowledge graph project.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
use std::{
    ffi::OsString,
    fs,
    path::{Path, PathBuf},
    process::Command,
    sync::Arc,
    time::{SystemTime, UNIX_EPOCH},
};

use crate::{
    api::{
        CodeRepositoryFreshnessDiagnostics, CodeRepositoryFreshnessState, CodeRepositoryIndexLag,
        CodeRepositoryPendingIndexWork, CodeRepositoryRegisterRequest, InterfaceKind,
        RequestContext,
    },
    application::{RelayKnowledgeService, RuntimeConfiguration},
    code::{reset_tracked_entries_call_count_for_root, tracked_entries_call_count_for_root},
    domain::{
        CodeImpactRequest, CodeIndexMode, CodeIndexRequest, CodeIndexResourceBudget,
        CodeIndexSession, CodeQueryKind, CodeRepositorySelector, CodeRetrievalHit,
        CodeRetrievalLayer, CodeRetrievalRequest, FreshnessPolicy, RepositoryCodeRange,
        StalenessHint,
    },
    env::{EnvironmentConfig, PlatformKind},
    storage::{CodeIndexTaskSeed, CodeRepositoryStore, SqliteGraphStore},
};

static TRACKED_ENTRIES_TEST_LOCK: tokio::sync::Mutex<()> = tokio::sync::Mutex::const_new(());

#[tokio::test]
async fn git_fresh_full_index_skips_tracked_entry_plan_build() {
    let _guard = TRACKED_ENTRIES_TEST_LOCK.lock().await;
    let repo = FixtureRepo::create("git-full-noop-fast-path");
    repo.write("src/lib.rs", "pub fn stable_policy() -> u32 { 1 }\n");
    repo.git(["add", "."]);
    repo.git(["commit", "-m", "initial"]);
    let service = service_with_memory_store().await;
    let observed_root = repo
        .path
        .canonicalize()
        .expect("repo path should canonicalize");

    register_fixture_repo(&service, &repo, "register-git-full-noop-fast-path").await;
    reset_tracked_entries_call_count_for_root(observed_root.clone());
    let first = service
        .index_code_repository(request("fixture", "HEAD"), context("index-git-full-first"))
        .await
        .expect("initial full index should succeed");
    assert!(
        tracked_entries_call_count_for_root(&observed_root) > 0,
        "cold full index should enumerate tracked entries"
    );

    reset_tracked_entries_call_count_for_root(observed_root.clone());
    let second = service
        .index_code_repository(request("fixture", "HEAD"), context("index-git-full-second"))
        .await
        .expect("fresh full index should reuse scope");

    assert_eq!(second.summary.source_scope, first.summary.source_scope);
    assert_eq!(second.summary.progress.blob_read_count, 0);
    assert_eq!(tracked_entries_call_count_for_root(&observed_root), 0);
}

#[tokio::test]
async fn git_fresh_filtered_full_index_uses_scope_generated_symbol_counts() {
    let _guard = TRACKED_ENTRIES_TEST_LOCK.lock().await;
    let repo = FixtureRepo::create("git-filtered-fast-path-generated-counts");
    repo.write("src/narrow/lib.rs", "pub fn narrow_policy() -> u32 { 1 }\n");
    repo.write(
        "src/generated/api.pb.go",
        "package generated\nfunc GeneratedPolicy() int { return 1 }\n",
    );
    repo.git(["add", "."]);
    repo.git(["commit", "-m", "initial"]);
    let service = service_with_memory_store().await;
    let observed_root = repo
        .path
        .canonicalize()
        .expect("repo path should canonicalize");
    let narrow_request = CodeIndexRequest {
        repository: CodeRepositorySelector::new(
            "fixture",
            "HEAD",
            vec!["src/narrow".to_owned()],
            Vec::new(),
        )
        .expect("selector should validate"),
        mode: CodeIndexMode::Full,
        workspace_detection: Default::default(),
        freshness_policy: FreshnessPolicy::WaitUntilFresh,
    };

    register_fixture_repo(&service, &repo, "register-git-filtered-counts").await;
    let narrow = service
        .index_code_repository(
            narrow_request.clone(),
            context("index-filtered-counts-narrow"),
        )
        .await
        .expect("narrow index should succeed");
    service
        .index_code_repository(
            request("fixture", "HEAD"),
            context("index-filtered-counts-broad"),
        )
        .await
        .expect("broad index should succeed");

    reset_tracked_entries_call_count_for_root(observed_root.clone());
    let reused_narrow = service
        .index_code_repository(narrow_request, context("index-filtered-counts-reuse"))
        .await
        .expect("fresh narrow index should reuse scoped status");

    assert_eq!(
        reused_narrow.summary.source_scope,
        narrow.summary.source_scope
    );
    assert_eq!(reused_narrow.summary.progress.blob_read_count, 0);
    assert_eq!(reused_narrow.summary.handwritten_symbol_count, 1);
    assert_eq!(reused_narrow.summary.generated_symbol_count, 0);
    assert_eq!(tracked_entries_call_count_for_root(&observed_root), 0);
}

#[tokio::test]
async fn duplicate_active_full_index_start_skips_tracked_entry_plan_build() {
    let _guard = TRACKED_ENTRIES_TEST_LOCK.lock().await;
    let repo = FixtureRepo::create("git-active-duplicate-fast-path");
    repo.write("src/lib.rs", "pub fn queued_policy() -> u32 { 1 }\n");
    repo.git(["add", "."]);
    repo.git(["commit", "-m", "initial"]);
    let service = service_with_memory_store().await;
    let observed_root = repo
        .path
        .canonicalize()
        .expect("repo path should canonicalize");
    let request = CodeIndexRequest {
        repository: selector("fixture", "HEAD"),
        mode: CodeIndexMode::Full,
        workspace_detection: Default::default(),
        freshness_policy: FreshnessPolicy::AllowStale,
    };

    register_fixture_repo(&service, &repo, "register-git-active-duplicate-fast-path").await;
    reset_tracked_entries_call_count_for_root(observed_root.clone());
    let first = service
        .start_code_repository_index(request.clone(), context("start-git-active-first"))
        .await
        .expect("cold full index should queue");

    reset_tracked_entries_call_count_for_root(observed_root.clone());
    let duplicate = service
        .start_code_repository_index(request.clone(), context("start-git-active-duplicate"))
        .await
        .expect("duplicate full index should reuse queued task");

    assert_eq!(
        duplicate.task.as_ref().map(|task| task.task_id.as_str()),
        first.task.as_ref().map(|task| task.task_id.as_str())
    );
    assert_eq!(tracked_entries_call_count_for_root(&observed_root), 0);

    let workspace_request = CodeIndexRequest {
        workspace_detection: crate::domain::CodeWorkspaceDetectionConfig::enabled_all(),
        ..request.clone()
    };
    reset_tracked_entries_call_count_for_root(observed_root.clone());
    let workspace_distinct = service
        .start_code_repository_index(workspace_request, context("start-git-active-workspace"))
        .await
        .expect("workspace-aware full index request should queue separately");
    assert_ne!(
        workspace_distinct
            .task
            .as_ref()
            .map(|task| task.task_id.as_str()),
        first.task.as_ref().map(|task| task.task_id.as_str())
    );
    assert!(
        tracked_entries_call_count_for_root(&observed_root) > 0,
        "workspace-detection changes should still build a plan"
    );

    let distinct_request = CodeIndexRequest {
        repository: CodeRepositorySelector::new(
            "fixture",
            "HEAD",
            vec!["src".to_owned()],
            Vec::new(),
        )
        .expect("selector should validate"),
        mode: CodeIndexMode::Full,
        workspace_detection: Default::default(),
        freshness_policy: FreshnessPolicy::AllowStale,
    };
    reset_tracked_entries_call_count_for_root(observed_root.clone());
    service
        .start_code_repository_index(distinct_request, context("start-git-active-distinct"))
        .await
        .expect("distinct full index request should build a plan");
    assert!(
        tracked_entries_call_count_for_root(&observed_root) > 0,
        "non-identical active full-index starts should still build a plan"
    );
}

#[tokio::test]
async fn duplicate_active_filesystem_full_index_resolves_live_snapshot_before_reuse() {
    let source = FixtureSourceDir::create("filesystem-active-duplicate-current-ref");
    source.write("src/lib.rs", "pub fn queued_policy() -> u32 { 1 }\n");
    let service = service_with_memory_store().await;
    let request = CodeIndexRequest {
        repository: selector("fixture", "HEAD"),
        mode: CodeIndexMode::Full,
        workspace_detection: Default::default(),
        freshness_policy: FreshnessPolicy::AllowStale,
    };

    register_fixture_source(&service, &source, "register-filesystem-active-current-ref").await;
    let first = service
        .start_code_repository_index(request.clone(), context("start-filesystem-active-first"))
        .await
        .expect("cold filesystem full index should queue");
    source.write("src/lib.rs", "pub fn queued_policy() -> u32 { 2 }\n");
    let changed = service
        .start_code_repository_index(request, context("start-filesystem-active-changed"))
        .await
        .expect("changed filesystem full index should queue new snapshot");

    assert_ne!(
        changed.task.as_ref().map(|task| task.task_id.as_str()),
        first.task.as_ref().map(|task| task.task_id.as_str())
    );
    assert_ne!(
        changed
            .task
            .as_ref()
            .map(|task| task.resolved_commit_sha.as_str()),
        first
            .task
            .as_ref()
            .map(|task| task.resolved_commit_sha.as_str())
    );
}

#[tokio::test]
async fn queued_worktree_overlay_task_preserves_payload_ref_selector() {
    let repo = FixtureRepo::create("queued-worktree-overlay-payload-ref");
    repo.write("src/lib.rs", "pub fn overlay_policy() -> u32 { 1 }\n");
    repo.git(["add", "."]);
    repo.git(["commit", "-m", "initial"]);
    let store = Arc::new(SqliteGraphStore::open_in_memory().expect("store should open"));
    let service = service_with_store(Arc::clone(&store)).await;

    register_fixture_repo(&service, &repo, "register-queued-overlay").await;
    service
        .index_code_repository(
            request("fixture", "HEAD"),
            context("index-queued-overlay-base"),
        )
        .await
        .expect("base index should succeed");
    repo.write(
        "src/lib.rs",
        "pub fn overlay_policy() -> u32 { 2 }\npub fn overlay_policy_v2() -> u32 { overlay_policy() }\n",
    );
    let overlay_request = CodeIndexRequest {
        repository: selector("fixture", "HEAD"),
        mode: CodeIndexMode::WorktreeOverlay,
        workspace_detection: Default::default(),
        freshness_policy: FreshnessPolicy::WaitUntilFresh,
    };
    let payload_json =
        serde_json::to_string(&overlay_request).expect("overlay request should serialize");
    let status = store
        .code_repository_status("fixture".to_owned())
        .await
        .expect("status should load")
        .expect("repository should exist");
    let task = store
        .queue_code_index_task(CodeIndexTaskSeed {
            repository_id: status.repository_id.clone(),
            alias: status.alias.clone(),
            ref_selector: "HEAD".to_owned(),
            resolved_commit_sha: "invalid-ref-if-worker-overrides-payload".to_owned(),
            tree_hash: "worktree:pending:test".to_owned(),
            source_scope: format!("watcher:{}", status.repository_id),
            path_filters: status.path_filters.clone(),
            language_filters: status.language_filters.clone(),
            mode: CodeIndexMode::WorktreeOverlay,
            input_fingerprint: "queued-worktree-overlay-payload-ref".to_owned(),
            resource_budget: CodeIndexResourceBudget::default(),
            payload_json,
            now_ms: 1,
        })
        .await
        .expect("overlay task should queue");

    let completed = service
        .run_code_index_task_once(Some(task.task_id.clone()), context("run-queued-overlay"))
        .await
        .expect("worker should preserve payload ref for worktree overlay")
        .expect("worker should claim the queued task");

    assert_eq!(completed.task_id, task.task_id);
    let query = service
        .query_code_repository(
            CodeRetrievalRequest::new(
                "overlay_policy_v2",
                selector("fixture", "worktree"),
                CodeQueryKind::Definition,
                10,
                FreshnessPolicy::AllowStale,
            )
            .expect("query request should validate"),
            context("query-queued-overlay"),
        )
        .await
        .expect("explicit worktree query should succeed");
    assert!(query.results.iter().any(|hit| hit.path == "src/lib.rs"));
}

#[tokio::test]
async fn full_index_refreshes_running_watcher_after_initial_scope() {
    let repo = FixtureRepo::create("watcher-refresh-after-initial-index");
    repo.write("src/lib.rs", "pub fn watched_after_index() -> u32 { 1 }\n");
    repo.git(["add", "."]);
    repo.git(["commit", "-m", "initial"]);
    let store = Arc::new(SqliteGraphStore::open_in_memory().expect("store should open"));
    let service = service_with_store(Arc::clone(&store)).await;
    let handle = service
        .start_code_repository_watcher()
        .await
        .expect("watcher should start")
        .expect("watcher should be enabled");

    register_fixture_repo(&service, &repo, "register-watcher-refresh").await;
    assert_eq!(handle.repository_count().await, 0);

    service
        .index_code_repository(request("fixture", "HEAD"), context("index-watcher-refresh"))
        .await
        .expect("initial index should refresh watcher");

    assert_eq!(handle.repository_count().await, 1);
    handle.request_shutdown();
}

#[tokio::test]
async fn allow_stale_query_reports_pending_freshness_and_source_read_requirement() {
    let repo = FixtureRepo::create("code-query-pending-freshness");
    repo.write("src/lib.rs", "pub fn pending_policy() -> u32 { 1 }\n");
    repo.git(["add", "."]);
    repo.git(["commit", "-m", "initial"]);
    let service = service_with_memory_store().await;

    register_fixture_repo(&service, &repo, "register-code-query-pending-freshness").await;
    let indexed = service
        .index_code_repository(
            request("fixture", "HEAD"),
            context("index-code-query-pending-base"),
        )
        .await
        .expect("base index should succeed");
    repo.write("src/lib.rs", "pub fn pending_policy() -> u32 { 2 }\n");
    repo.git(["add", "."]);
    repo.git(["commit", "-m", "changed"]);
    let queued = service
        .start_code_repository_index(
            CodeIndexRequest {
                repository: selector("fixture", "HEAD"),
                mode: CodeIndexMode::Full,
                workspace_detection: Default::default(),
                freshness_policy: FreshnessPolicy::AllowStale,
            },
            context("start-code-query-pending-refresh"),
        )
        .await
        .expect("changed index should queue");

    let query = service
        .query_code_repository(
            CodeRetrievalRequest::new(
                "pending_policy",
                selector("fixture", "HEAD"),
                CodeQueryKind::Definition,
                5,
                FreshnessPolicy::AllowStale,
            )
            .expect("query request should validate"),
            context("query-code-query-pending-freshness"),
        )
        .await
        .expect("allow-stale query should return previous index");

    assert!(query.metadata.stale);
    assert!(query.scope.stale);
    assert_eq!(query.results[0].path, "src/lib.rs");
    assert!(query.results[0].stale);
    assert_eq!(
        query.results[0].staleness_hint,
        Some(StalenessHint::PendingIndex {})
    );
    assert_eq!(query.freshness.state, CodeRepositoryFreshnessState::Pending);
    assert!(query.freshness.direct_source_read_required);
    assert_eq!(
        query.freshness.index_lag.served_ref,
        indexed.summary.resolved_commit_sha
    );
    assert_ne!(
        query.freshness.index_lag.requested_resolved_ref,
        query.freshness.index_lag.served_ref
    );
    assert!(!query.freshness.index_lag.requested_ref_indexed);
    assert!(query.freshness.pending.active_matches_request);
    assert_eq!(
        query.freshness.pending.active_task_id.as_deref(),
        queued.task.as_ref().map(|task| task.task_id.as_str())
    );
    assert_eq!(
        query.freshness.direct_source_read_paths,
        vec!["src/lib.rs".to_owned()]
    );
    assert!(
        query
            .freshness
            .agent_instructions
            .iter()
            .any(|instruction| instruction.contains("read direct source"))
    );
}

#[tokio::test]
async fn fresh_ref_query_ignores_unmatched_active_task_checkpoint() {
    let repo = FixtureRepo::create("code-query-unmatched-active-checkpoint");
    repo.write("src/lib.rs", "pub fn stable_policy() -> u32 { 1 }\n");
    repo.git(["add", "."]);
    repo.git(["commit", "-m", "initial"]);
    let initial_commit = repo.git_text(["rev-parse", "HEAD"]);
    let store = Arc::new(SqliteGraphStore::open_in_memory().expect("store should open"));
    let service = service_with_store(Arc::clone(&store)).await;

    register_fixture_repo(&service, &repo, "register-unmatched-active-checkpoint").await;
    let indexed = service
        .index_code_repository(
            request("fixture", &initial_commit),
            context("index-unmatched-active-base"),
        )
        .await
        .expect("initial commit should index");
    repo.write("src/lib.rs", "pub fn stable_policy() -> u32 { 2 }\n");
    repo.git(["add", "."]);
    repo.git(["commit", "-m", "changed"]);
    let started = service
        .start_code_repository_index(
            CodeIndexRequest {
                repository: selector("fixture", "HEAD"),
                mode: CodeIndexMode::Full,
                workspace_detection: Default::default(),
                freshness_policy: FreshnessPolicy::AllowStale,
            },
            context("start-unmatched-active-head"),
        )
        .await
        .expect("head refresh should queue");
    let active_task = started.task.expect("active task should be queued");
    store
        .begin_code_index_session(CodeIndexSession {
            repository_id: active_task.repository_id.clone(),
            source_scope: active_task.source_scope.clone(),
            base_resolved_commit_sha: Some(initial_commit.clone()),
            resolved_commit_sha: active_task.resolved_commit_sha.clone(),
            tree_hash: active_task.tree_hash.clone(),
            path_filters: active_task.path_filters.clone(),
            language_filters: active_task.language_filters.clone(),
            full_replace: true,
            total_path_count: 8,
            changed_path_count: 8,
            skipped_unchanged_count: 0,
            deleted_paths: Vec::new(),
            tombstones: Vec::new(),
            workspaces: Vec::new(),
            resource_budget: CodeIndexResourceBudget::default(),
        })
        .await
        .expect("unmatched active checkpoint should begin");

    let query = service
        .query_code_repository(
            CodeRetrievalRequest::new(
                "stable_policy",
                selector("fixture", &initial_commit),
                CodeQueryKind::Definition,
                5,
                FreshnessPolicy::AllowStale,
            )
            .expect("query request should validate"),
            context("query-unmatched-active-base"),
        )
        .await
        .expect("fresh indexed ref should query while another ref is active");

    assert_eq!(query.freshness.state, CodeRepositoryFreshnessState::Fresh);
    assert!(query.freshness.pending.active_for_repository);
    assert!(!query.freshness.pending.active_matches_request);
    assert_eq!(
        query
            .freshness
            .cursor
            .as_ref()
            .map(|cursor| cursor.source_scope.as_str()),
        Some(indexed.summary.source_scope.as_str())
    );
    assert_ne!(
        query
            .freshness
            .cursor
            .as_ref()
            .map(|cursor| cursor.source_scope.as_str()),
        Some(active_task.source_scope.as_str())
    );
}

#[test]
fn active_pending_match_keeps_fresh_hit_when_source_read_is_not_required() {
    let mut hits = vec![test_hit()];
    let freshness = freshness_with_active_match(false);

    super::repository::annotate_query_result_staleness(&mut hits, &freshness);

    assert!(!hits[0].stale);
    assert_eq!(hits[0].staleness_hint, Some(StalenessHint::Fresh));
}

fn freshness_with_active_match(
    direct_source_read_required: bool,
) -> CodeRepositoryFreshnessDiagnostics {
    CodeRepositoryFreshnessDiagnostics {
        state: if direct_source_read_required {
            CodeRepositoryFreshnessState::Pending
        } else {
            CodeRepositoryFreshnessState::Fresh
        },
        freshness_policy: FreshnessPolicy::AllowStale,
        graph_version: 1,
        source_scope: Some("scope".to_owned()),
        scope_stale: direct_source_read_required,
        stale_reason: None,
        degraded_reason: None,
        index_lag: CodeRepositoryIndexLag {
            requested_ref: "HEAD".to_owned(),
            requested_resolved_ref: "commit".to_owned(),
            served_ref: if direct_source_read_required {
                "previous".to_owned()
            } else {
                "commit".to_owned()
            },
            requested_ref_indexed: !direct_source_read_required,
            pending_file_count: None,
            pending_task_count: 1,
        },
        pending: CodeRepositoryPendingIndexWork {
            active_for_repository: true,
            active_matches_request: true,
            active_task_id: Some("task".to_owned()),
            active_task_state: Some("running".to_owned()),
            active_task_source_scope: Some("scope".to_owned()),
            active_task_ref_selector: Some("HEAD".to_owned()),
            active_task_resolved_commit_sha: Some("commit".to_owned()),
            active_task_lease_expires_at_ms: Some(2),
            queue_depth: 1,
            queued_task_count: 0,
            running_task_count: 1,
            retrying_task_count: 0,
            dead_letter_task_count: 0,
            running_lease_count: 1,
            last_error: None,
        },
        cursor: None,
        direct_source_read_required,
        direct_source_read_paths: Vec::new(),
        agent_instructions: Vec::new(),
    }
}

fn test_hit() -> CodeRetrievalHit {
    let range = RepositoryCodeRange { start: 1, end: 2 };
    CodeRetrievalHit {
        repository_id: "repo".to_owned(),
        scope_id: "scope".to_owned(),
        resolved_commit_sha: "commit".to_owned(),
        tree_hash: "tree".to_owned(),
        path: "src/lib.rs".to_owned(),
        language_id: "rust".to_owned(),
        byte_range: range.clone(),
        line_range: range,
        symbol_snapshot_id: None,
        canonical_symbol_id: None,
        file_id: None,
        retrieval_layers: vec![CodeRetrievalLayer::Definition],
        index_versions: vec!["code:scope:tree".to_owned()],
        stale: false,
        staleness_hint: None,
        degraded_reason: None,
        edge_kind: None,
        edge_resolution_state: None,
        edge_target_hint: None,
        edge_confidence_basis_points: None,
        edge_confidence_tier: None,
        score: 1.0,
        excerpt: "pub fn stable_policy() -> u32 { 1 }".to_owned(),
    }
}

#[tokio::test]
async fn filesystem_impact_reports_deleted_base_paths_from_stored_fingerprints() {
    let source = FixtureSourceDir::create("filesystem-impact-deleted-base-path");
    source.write("src/lib.rs", "pub fn unchanged_policy() -> u32 { 1 }\n");
    source.write("src/api.rs", "pub fn removed_policy() -> u32 { 1 }\n");
    let service = service_with_memory_store().await;

    register_fixture_source(&service, &source, "register-filesystem-impact-delete").await;
    let base = service
        .index_code_repository(request("fixture", "HEAD"), context("index-filesystem-base"))
        .await
        .expect("base filesystem index should succeed");
    fs::remove_file(source.path.join("src/api.rs")).expect("fixture source should delete");
    service
        .index_code_repository(request("fixture", "HEAD"), context("index-filesystem-head"))
        .await
        .expect("head filesystem index should succeed");

    let impact = service
        .impact_code_repository(
            CodeImpactRequest::new(
                selector("fixture", "HEAD"),
                base.summary.resolved_commit_sha,
                "HEAD",
                10,
            )
            .expect("impact request should validate"),
            context("impact-filesystem-delete"),
        )
        .await
        .expect("filesystem impact should succeed");

    assert_eq!(
        impact.path_groups.in_scope_changed_paths,
        ["src/api.rs".to_owned()]
    );
}

async fn register_fixture_repo(service: &RelayKnowledgeService, repo: &FixtureRepo, name: &str) {
    service
        .register_code_repository(
            CodeRepositoryRegisterRequest {
                root_path: repo.path.display().to_string(),
                alias: "fixture".to_owned(),
                path_filters: vec!["src".to_owned()],
                language_filters: Vec::new(),
            },
            context(name),
        )
        .await
        .expect("repository should register");
}

async fn register_fixture_source(
    service: &RelayKnowledgeService,
    source: &FixtureSourceDir,
    name: &str,
) {
    service
        .register_code_repository(
            CodeRepositoryRegisterRequest {
                root_path: source.path.display().to_string(),
                alias: "fixture".to_owned(),
                path_filters: vec!["src".to_owned()],
                language_filters: Vec::new(),
            },
            context(name),
        )
        .await
        .expect("source directory should register");
}

fn request(alias: &str, ref_selector: &str) -> CodeIndexRequest {
    CodeIndexRequest {
        repository: selector(alias, ref_selector),
        mode: CodeIndexMode::Full,
        workspace_detection: Default::default(),
        freshness_policy: FreshnessPolicy::WaitUntilFresh,
    }
}

fn selector(alias: &str, ref_selector: &str) -> CodeRepositorySelector {
    CodeRepositorySelector::new(alias, ref_selector, Vec::new(), Vec::new())
        .expect("selector should validate")
}

fn context(name: &str) -> RequestContext {
    RequestContext::with_ids(
        InterfaceKind::Cli,
        format!("req-{name}"),
        format!("trace-{name}"),
    )
}

async fn service_with_memory_store() -> RelayKnowledgeService {
    let store = Arc::new(SqliteGraphStore::open_in_memory().expect("store should open"));
    service_with_store(store).await
}

async fn service_with_store(store: Arc<SqliteGraphStore>) -> RelayKnowledgeService {
    let runtime_root = std::env::temp_dir().join("relay-knowledge-code-repository-runtime");
    let home_dir = runtime_root.join("home");
    let temp_dir = runtime_root.join("tmp");
    let relay_home = runtime_root.join("relay");
    for directory in [&home_dir, &temp_dir, &relay_home] {
        fs::create_dir_all(directory).expect("runtime test directory should be created");
    }
    let environment = EnvironmentConfig::from_pairs(
        PlatformKind::current(),
        [
            (OsString::from("HOME"), home_dir.into_os_string()),
            (OsString::from("TEMP"), temp_dir.clone().into_os_string()),
            (OsString::from("TMP"), temp_dir.clone().into_os_string()),
            (OsString::from("TMPDIR"), temp_dir.into_os_string()),
            (
                OsString::from("RELAY_KNOWLEDGE_HOME"),
                relay_home.into_os_string(),
            ),
        ],
    )
    .expect("environment should parse");
    let runtime = RuntimeConfiguration::from_environment(&environment)
        .await
        .expect("runtime should compose");

    RelayKnowledgeService::with_store(runtime, store)
}

struct FixtureRepo {
    path: PathBuf,
}

impl FixtureRepo {
    fn create(name: &str) -> Self {
        let nanos = SystemTime::now()
            .duration_since(UNIX_EPOCH)
            .expect("clock should be after epoch")
            .as_nanos();
        let path = std::env::temp_dir().join(format!("relay-knowledge-{name}-{nanos}"));
        fs::create_dir_all(path.join("src")).expect("repo directory should be created");
        let repo = Self { path };
        repo.git(["init"]);
        repo.git(["config", "user.email", "relay@example.invalid"]);
        repo.git(["config", "user.name", "Relay Test"]);
        repo
    }

    fn write(&self, relative: &str, content: &str) {
        let path = self.path.join(relative);
        if let Some(parent) = path.parent() {
            fs::create_dir_all(parent).expect("parent directory should exist");
        }
        fs::write(path, content).expect("fixture file should be written");
    }

    fn git<const N: usize>(&self, args: [&str; N]) {
        let output = git_command(&self.path, args)
            .output()
            .expect("git should run");
        assert!(
            output.status.success(),
            "git failed: {}",
            String::from_utf8_lossy(&output.stderr)
        );
    }

    fn git_text<const N: usize>(&self, args: [&str; N]) -> String {
        let output = git_command(&self.path, args)
            .output()
            .expect("git should run");
        assert!(output.status.success());
        String::from_utf8_lossy(&output.stdout).trim().to_owned()
    }
}

fn git_command<const N: usize>(path: &Path, args: [&str; N]) -> Command {
    let mut command = Command::new("git");
    command.current_dir(path).args(args);
    command
}

struct FixtureSourceDir {
    path: PathBuf,
}

impl FixtureSourceDir {
    fn create(name: &str) -> Self {
        let nanos = SystemTime::now()
            .duration_since(UNIX_EPOCH)
            .expect("clock should be after epoch")
            .as_nanos();
        let path = std::env::temp_dir().join(format!("relay-knowledge-{name}-{nanos}"));
        fs::create_dir_all(path.join("src")).expect("source directory should be created");
        Self { path }
    }

    fn write(&self, relative: &str, content: &str) {
        let path = self.path.join(relative);
        if let Some(parent) = path.parent() {
            fs::create_dir_all(parent).expect("parent directory should exist");
        }
        fs::write(path, content).expect("fixture file should be written");
    }
}