reinhardt-middleware 0.1.0

Middleware system for request/response processing pipeline
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
//! HTTPS Redirect Middleware
//!
//! Automatically redirects HTTP requests to HTTPS.
//! Similar to Django's SECURE_SSL_REDIRECT setting.

use async_trait::async_trait;
use hyper::StatusCode;
use reinhardt_http::{Handler, Middleware, Request, Response, Result};
use std::sync::Arc;

/// Configuration for HTTPS redirect middleware
#[non_exhaustive]
#[derive(Debug, Clone)]
pub struct HttpsRedirectConfig {
	/// Enable HTTPS redirect
	pub enabled: bool,
	/// Exempt paths from HTTPS redirect (e.g., health checks)
	pub exempt_paths: Vec<String>,
	/// Redirect status code (301 or 302)
	pub status_code: StatusCode,
	/// Allowed host names for redirect (prevents host header injection).
	/// If empty, all requests without a valid allowed host are rejected with 400 Bad Request.
	pub allowed_hosts: Vec<String>,
}

impl Default for HttpsRedirectConfig {
	fn default() -> Self {
		Self {
			enabled: true,
			exempt_paths: vec![],
			status_code: StatusCode::MOVED_PERMANENTLY, // 301
			allowed_hosts: vec![],
		}
	}
}

/// Middleware to redirect HTTP requests to HTTPS
pub struct HttpsRedirectMiddleware {
	config: HttpsRedirectConfig,
}

impl HttpsRedirectMiddleware {
	/// Create a new HttpsRedirectMiddleware with the given configuration
	///
	/// # Arguments
	///
	/// * `config` - HTTPS redirect configuration
	///
	/// # Examples
	///
	/// ```
	/// use std::sync::Arc;
	/// use reinhardt_middleware::{HttpsRedirectMiddleware, HttpsRedirectConfig};
	/// use reinhardt_http::{Handler, Middleware, Request, Response};
	/// use hyper::{StatusCode, Method, Version, HeaderMap};
	/// use bytes::Bytes;
	///
	/// struct TestHandler;
	///
	/// #[async_trait::async_trait]
	/// impl Handler for TestHandler {
	///     async fn handle(&self, _request: Request) -> reinhardt_core::exception::Result<Response> {
	///         Ok(Response::new(StatusCode::OK))
	///     }
	/// }
	///
	/// # tokio_test::block_on(async {
	/// let mut config = HttpsRedirectConfig::default();
	/// config.enabled = true;
	/// config.exempt_paths = vec!["/health".to_string()];
	/// config.status_code = StatusCode::MOVED_PERMANENTLY;
	/// config.allowed_hosts = vec!["example.com".to_string()];
	///
	/// let middleware = HttpsRedirectMiddleware::new(config);
	/// let handler = Arc::new(TestHandler);
	///
	/// let mut headers = HeaderMap::new();
	/// headers.insert(hyper::header::HOST, "example.com".parse().unwrap());
	///
	/// let request = Request::builder()
	///     .method(Method::GET)
	///     .uri("/api/data")
	///     .version(Version::HTTP_11)
	///     .headers(headers)
	///     .body(Bytes::new())
	///     .build()
	///     .unwrap();
	///
	/// let response = middleware.process(request, handler).await.unwrap();
	/// assert_eq!(response.status, StatusCode::MOVED_PERMANENTLY);
	/// assert_eq!(response.headers.get("Location").unwrap(), "https://example.com/api/data");
	/// # });
	/// ```
	pub fn new(config: HttpsRedirectConfig) -> Self {
		Self { config }
	}
	/// Create with default configuration
	///
	/// Default configuration enables HTTPS redirect with 301 status code and no exempt paths.
	///
	/// # Examples
	///
	/// ```
	/// use std::sync::Arc;
	/// use reinhardt_middleware::{HttpsRedirectConfig, HttpsRedirectMiddleware};
	/// use reinhardt_http::{Handler, Middleware, Request, Response};
	/// use hyper::{StatusCode, Method, Version, HeaderMap};
	/// use bytes::Bytes;
	///
	/// struct TestHandler;
	///
	/// #[async_trait::async_trait]
	/// impl Handler for TestHandler {
	///     async fn handle(&self, _request: Request) -> reinhardt_core::exception::Result<Response> {
	///         Ok(Response::new(StatusCode::OK))
	///     }
	/// }
	///
	/// # tokio_test::block_on(async {
	/// let mut config = HttpsRedirectConfig::default();
	/// config.allowed_hosts = vec!["api.example.com".to_string()];
	/// let middleware = HttpsRedirectMiddleware::new(config);
	/// let handler = Arc::new(TestHandler);
	///
	/// let mut headers = HeaderMap::new();
	/// headers.insert(hyper::header::HOST, "api.example.com".parse().unwrap());
	///
	/// let request = Request::builder()
	///     .method(Method::GET)
	///     .uri("/users?page=1")
	///     .version(Version::HTTP_11)
	///     .headers(headers)
	///     .body(Bytes::new())
	///     .build()
	///     .unwrap();
	///
	/// let response = middleware.process(request, handler).await.unwrap();
	/// assert_eq!(response.status, StatusCode::MOVED_PERMANENTLY);
	/// assert_eq!(response.headers.get("Location").unwrap(), "https://api.example.com/users?page=1");
	/// # });
	/// ```
	pub fn default_config() -> Self {
		Self {
			config: HttpsRedirectConfig::default(),
		}
	}

	/// Check if a path is exempt from HTTPS redirect
	fn is_exempt(&self, path: &str) -> bool {
		self.config
			.exempt_paths
			.iter()
			.any(|exempt| path.starts_with(exempt))
	}

	/// Validate host header against allowed hosts list.
	/// Returns the validated host string if valid, or None if the host is not allowed.
	fn validate_host<'a>(&self, host: Option<&'a str>) -> Option<&'a str> {
		let host = host?;

		// Reject hosts containing path separators or whitespace (injection attempts)
		if host.contains('/') || host.contains('\\') || host.contains(char::is_whitespace) {
			return None;
		}

		// If no allowed hosts configured, reject all (secure by default)
		if self.config.allowed_hosts.is_empty() {
			return None;
		}

		// Strip port for comparison (e.g., "example.com:8080" -> "example.com")
		let host_without_port = host.split(':').next().unwrap_or(host);

		// Check against allowed hosts list
		let is_allowed = self.config.allowed_hosts.iter().any(|allowed| {
			let allowed_lower = allowed.to_lowercase();
			let host_lower = host_without_port.to_lowercase();
			allowed_lower == host_lower
		});

		if is_allowed { Some(host) } else { None }
	}
}

#[async_trait]
impl Middleware for HttpsRedirectMiddleware {
	async fn process(&self, request: Request, handler: Arc<dyn Handler>) -> Result<Response> {
		// If HTTPS redirect is disabled, just pass through
		if !self.config.enabled {
			return handler.handle(request).await;
		}

		// If request is already secure, pass through
		if request.is_secure() {
			return handler.handle(request).await;
		}

		// If path is exempt, pass through
		if self.is_exempt(request.path()) {
			return handler.handle(request).await;
		}

		// Validate host header against allowed hosts to prevent host header injection
		let host_value = request
			.headers
			.get(hyper::header::HOST)
			.and_then(|h| h.to_str().ok());

		let validated_host = match self.validate_host(host_value) {
			Some(host) => host,
			None => {
				// Reject requests with invalid or disallowed host headers
				return Ok(Response::new(StatusCode::BAD_REQUEST));
			}
		};

		// Build HTTPS redirect URL with validated host
		let https_url = format!(
			"https://{}{}",
			validated_host,
			request
				.uri
				.path_and_query()
				.map(|pq| pq.as_str())
				.unwrap_or("/")
		);

		// Return redirect response
		let mut response = Response::new(self.config.status_code);
		response.headers.insert(
			hyper::header::LOCATION,
			https_url
				.parse()
				.unwrap_or_else(|_| hyper::header::HeaderValue::from_static("/")),
		);
		Ok(response)
	}
}

#[cfg(test)]
mod tests {
	use super::*;
	use bytes::Bytes;
	use hyper::{HeaderMap, Method, StatusCode, Version};
	use reinhardt_http::Request;
	use rstest::rstest;

	struct TestHandler;

	#[async_trait]
	impl Handler for TestHandler {
		async fn handle(&self, _request: Request) -> Result<Response> {
			Ok(Response::ok().with_body(Bytes::from("test")))
		}
	}

	fn config_with_allowed_hosts(hosts: Vec<&str>) -> HttpsRedirectConfig {
		HttpsRedirectConfig {
			enabled: true,
			exempt_paths: vec![],
			status_code: StatusCode::MOVED_PERMANENTLY,
			allowed_hosts: hosts.into_iter().map(String::from).collect(),
		}
	}

	#[rstest]
	#[tokio::test]
	async fn test_redirect_http_to_https_with_allowed_host() {
		// Arrange
		let config = config_with_allowed_hosts(vec!["example.com"]);
		let middleware = HttpsRedirectMiddleware::new(config);
		let handler = Arc::new(TestHandler);

		let mut headers = HeaderMap::new();
		headers.insert(hyper::header::HOST, "example.com".parse().unwrap());

		let request = Request::builder()
			.method(Method::GET)
			.uri("/test")
			.version(Version::HTTP_11)
			.headers(headers)
			.body(Bytes::new())
			.build()
			.unwrap();

		// Act
		let response = middleware.process(request, handler).await.unwrap();

		// Assert
		assert_eq!(response.status, StatusCode::MOVED_PERMANENTLY);
		assert_eq!(
			response.headers.get("Location").unwrap(),
			"https://example.com/test"
		);
	}

	#[rstest]
	#[tokio::test]
	async fn test_no_redirect_for_https() {
		// Arrange
		let config = config_with_allowed_hosts(vec!["example.com"]);
		let middleware = HttpsRedirectMiddleware::new(config);
		let handler = Arc::new(TestHandler);

		let mut headers = HeaderMap::new();
		headers.insert(hyper::header::HOST, "example.com".parse().unwrap());

		let request = Request::builder()
			.method(Method::GET)
			.uri("/test")
			.version(Version::HTTP_11)
			.headers(headers)
			.body(Bytes::new())
			.secure(true)
			.build()
			.unwrap();

		// Act
		let response = middleware.process(request, handler).await.unwrap();

		// Assert
		assert_eq!(response.status, StatusCode::OK);
	}

	#[rstest]
	#[tokio::test]
	async fn test_exempt_paths() {
		// Arrange
		let config = HttpsRedirectConfig {
			enabled: true,
			exempt_paths: vec!["/health".to_string()],
			status_code: StatusCode::MOVED_PERMANENTLY,
			allowed_hosts: vec!["example.com".to_string()],
		};
		let middleware = HttpsRedirectMiddleware::new(config);
		let handler = Arc::new(TestHandler);

		let mut headers = HeaderMap::new();
		headers.insert(hyper::header::HOST, "example.com".parse().unwrap());

		let request = Request::builder()
			.method(Method::GET)
			.uri("/health")
			.version(Version::HTTP_11)
			.headers(headers)
			.body(Bytes::new())
			.build()
			.unwrap();

		// Act
		let response = middleware.process(request, handler).await.unwrap();

		// Assert - should not redirect exempt paths
		assert_eq!(response.status, StatusCode::OK);
	}

	#[rstest]
	#[tokio::test]
	async fn test_reject_disallowed_host() {
		// Arrange
		let config = config_with_allowed_hosts(vec!["example.com"]);
		let middleware = HttpsRedirectMiddleware::new(config);
		let handler = Arc::new(TestHandler);

		let mut headers = HeaderMap::new();
		headers.insert(hyper::header::HOST, "evil.com".parse().unwrap());

		let request = Request::builder()
			.method(Method::GET)
			.uri("/test")
			.version(Version::HTTP_11)
			.headers(headers)
			.body(Bytes::new())
			.build()
			.unwrap();

		// Act
		let response = middleware.process(request, handler).await.unwrap();

		// Assert - should reject with 400 Bad Request
		assert_eq!(response.status, StatusCode::BAD_REQUEST);
		assert!(response.headers.get("Location").is_none());
	}

	#[rstest]
	#[tokio::test]
	async fn test_reject_host_with_path_separator() {
		// Arrange - host header injection attempt with path separator
		let config = config_with_allowed_hosts(vec!["example.com"]);
		let middleware = HttpsRedirectMiddleware::new(config);
		let handler = Arc::new(TestHandler);

		let mut headers = HeaderMap::new();
		headers.insert(hyper::header::HOST, "evil.com/redirect".parse().unwrap());

		let request = Request::builder()
			.method(Method::GET)
			.uri("/test")
			.version(Version::HTTP_11)
			.headers(headers)
			.body(Bytes::new())
			.build()
			.unwrap();

		// Act
		let response = middleware.process(request, handler).await.unwrap();

		// Assert - should reject host with path separator
		assert_eq!(response.status, StatusCode::BAD_REQUEST);
	}

	#[rstest]
	#[tokio::test]
	async fn test_reject_missing_host_header() {
		// Arrange - no host header at all
		let config = config_with_allowed_hosts(vec!["example.com"]);
		let middleware = HttpsRedirectMiddleware::new(config);
		let handler = Arc::new(TestHandler);

		let request = Request::builder()
			.method(Method::GET)
			.uri("/test")
			.version(Version::HTTP_11)
			.body(Bytes::new())
			.build()
			.unwrap();

		// Act
		let response = middleware.process(request, handler).await.unwrap();

		// Assert - should reject when no host header present
		assert_eq!(response.status, StatusCode::BAD_REQUEST);
	}

	#[rstest]
	#[tokio::test]
	async fn test_reject_empty_allowed_hosts() {
		// Arrange - default config has empty allowed_hosts (secure by default)
		let middleware = HttpsRedirectMiddleware::default_config();
		let handler = Arc::new(TestHandler);

		let mut headers = HeaderMap::new();
		headers.insert(hyper::header::HOST, "example.com".parse().unwrap());

		let request = Request::builder()
			.method(Method::GET)
			.uri("/test")
			.version(Version::HTTP_11)
			.headers(headers)
			.body(Bytes::new())
			.build()
			.unwrap();

		// Act
		let response = middleware.process(request, handler).await.unwrap();

		// Assert - should reject when no allowed hosts configured
		assert_eq!(response.status, StatusCode::BAD_REQUEST);
	}

	#[rstest]
	#[tokio::test]
	async fn test_allowed_host_with_port() {
		// Arrange - host header includes port
		let config = config_with_allowed_hosts(vec!["example.com"]);
		let middleware = HttpsRedirectMiddleware::new(config);
		let handler = Arc::new(TestHandler);

		let mut headers = HeaderMap::new();
		headers.insert(hyper::header::HOST, "example.com:8080".parse().unwrap());

		let request = Request::builder()
			.method(Method::GET)
			.uri("/test")
			.version(Version::HTTP_11)
			.headers(headers)
			.body(Bytes::new())
			.build()
			.unwrap();

		// Act
		let response = middleware.process(request, handler).await.unwrap();

		// Assert - should allow host with port when hostname matches
		assert_eq!(response.status, StatusCode::MOVED_PERMANENTLY);
		assert_eq!(
			response.headers.get("Location").unwrap(),
			"https://example.com:8080/test"
		);
	}

	#[rstest]
	#[tokio::test]
	async fn test_case_insensitive_host_matching() {
		// Arrange
		let config = config_with_allowed_hosts(vec!["Example.COM"]);
		let middleware = HttpsRedirectMiddleware::new(config);
		let handler = Arc::new(TestHandler);

		let mut headers = HeaderMap::new();
		headers.insert(hyper::header::HOST, "example.com".parse().unwrap());

		let request = Request::builder()
			.method(Method::GET)
			.uri("/test")
			.version(Version::HTTP_11)
			.headers(headers)
			.body(Bytes::new())
			.build()
			.unwrap();

		// Act
		let response = middleware.process(request, handler).await.unwrap();

		// Assert - host matching should be case-insensitive
		assert_eq!(response.status, StatusCode::MOVED_PERMANENTLY);
	}
}