recursive-agent 0.6.0

A minimal, orthogonal, self-improving coding agent kernel in Rust
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
//! In-process agent backend for the TUI.
//!
//! [`Backend`] owns one tokio task that holds an [`recursive::AgentRuntime`].
//! The UI thread sends [`UserAction`]s into the worker via `action_tx` and
//! the worker pushes [`UiEvent`]s back via `event_rx`.
//!
//! Runtime construction and bash-mode dispatch live in sibling modules
//! (`runtime_builder`, `bash`) to keep this file focused on event bridging.

use std::sync::atomic::{AtomicBool, AtomicU64, Ordering};
use std::sync::Arc;

use crate::event::CompositeSink;
use crate::session::{SessionPersistenceSink, SessionWriter};
use crate::tools::PermissionHook;
use crate::{AgentEvent, AgentRuntime, EventSink};
use async_trait::async_trait;
use tokio::sync::mpsc;
use tokio::task::JoinHandle;

use crate::tui::bash::{build_bash_registry, resolve_workspace_root, run_bash_command};
#[cfg(feature = "weixin")]
use crate::tui::events::WeixinBackendRequest;
use crate::tui::events::{PermissionRequest, UiEvent, UserAction};
use crate::tui::runtime_builder::{build_runtime, RuntimeBuild};

/// Local helper to fan-out from two channels in the worker loop.
enum Either<L, R> {
    Left(L),
    #[allow(dead_code)]
    Right(R),
}

/// A handle to the agent worker task.
pub struct Backend {
    pub action_tx: mpsc::UnboundedSender<UserAction>,
    pub event_rx: mpsc::UnboundedReceiver<UiEvent>,
    /// Shared cancel flag: the UI flips this to `true` to interrupt an
    /// in-flight turn; the worker's `tokio::select!` wakes and aborts.
    pub cancel_flag: Arc<AtomicBool>,
    /// Goal-161: side-channel for runtime permission requests.
    /// Separate from `event_rx` because `PermissionRequest` carries a
    /// `oneshot::Sender<bool>` which is not `PartialEq`/`Clone`.
    pub perm_rx: mpsc::UnboundedReceiver<PermissionRequest>,
    /// Goal-161: shared flag that enables/disables the runtime permission
    /// hook. The UI thread can flip this via `/permissions on|off`.
    pub permission_enabled: Arc<AtomicBool>,
    /// WeChat side-channel: the daemon sends `WeixinBackendRequest`s here.
    /// The UI loop passes this into [`Backend::weixin_tx`] to the daemon.
    #[cfg(feature = "weixin")]
    pub weixin_tx: mpsc::UnboundedSender<WeixinBackendRequest>,
    _worker: JoinHandle<()>,
}

impl Backend {
    pub fn spawn() -> Self {
        Self::spawn_with_state(build_runtime())
    }

    pub fn spawn_with_runtime(rt: AgentRuntime) -> Self {
        Self::spawn_with_state(RuntimeBuild::Ready(Some(Box::new(rt))))
    }

    fn spawn_with_state(state: RuntimeBuild) -> Self {
        let (action_tx, action_rx) = mpsc::unbounded_channel::<UserAction>();
        let (event_tx, event_rx) = mpsc::unbounded_channel::<UiEvent>();
        let (perm_tx, perm_rx) = mpsc::unbounded_channel::<PermissionRequest>();
        let cancel_flag = Arc::new(AtomicBool::new(false));
        let permission_enabled = Arc::new(AtomicBool::new(false));
        #[cfg(feature = "weixin")]
        let (weixin_tx, weixin_rx) = mpsc::unbounded_channel::<WeixinBackendRequest>();

        let worker = tokio::spawn(worker_loop(
            state,
            action_rx,
            event_tx,
            perm_tx,
            cancel_flag.clone(),
            permission_enabled.clone(),
            #[cfg(feature = "weixin")]
            weixin_rx,
        ));

        Self {
            action_tx,
            event_rx,
            perm_rx,
            cancel_flag,
            permission_enabled,
            #[cfg(feature = "weixin")]
            weixin_tx,
            _worker: worker,
        }
    }
}

struct TuiEventSink {
    tx: mpsc::UnboundedSender<UiEvent>,
}

#[async_trait]
impl EventSink for TuiEventSink {
    async fn emit(&self, event: AgentEvent) {
        if let Some(ev) = map_agent_event(event) {
            let _ = self.tx.send(ev);
        }
    }
}

pub fn map_agent_event(event: AgentEvent) -> Option<UiEvent> {
    match event {
        AgentEvent::PartialToken { text, .. } => Some(UiEvent::AssistantPartial { text }),
        AgentEvent::Reasoning { text, .. } => Some(UiEvent::Reasoning { content: text }),
        AgentEvent::AssistantText { text, .. } => Some(UiEvent::AssistantMessage { content: text }),
        AgentEvent::ToolCall {
            id,
            name,
            arguments,
            ..
        } => Some(UiEvent::ToolCall {
            id,
            name,
            arguments,
        }),
        AgentEvent::ToolResult {
            id, name, output, ..
        } => {
            let success = !output.starts_with("ERROR: ");
            Some(UiEvent::ToolResult {
                id,
                name,
                output,
                success,
            })
        }
        AgentEvent::Usage {
            input_tokens,
            output_tokens,
            ..
        } => Some(UiEvent::Usage {
            input_tokens: input_tokens as u64,
            output_tokens: output_tokens as u64,
        }),
        AgentEvent::Latency { llm_ms, .. } => Some(UiEvent::Latency { llm_ms }),
        AgentEvent::Compacted { removed, kept, .. } => Some(UiEvent::Compacted { removed, kept }),
        AgentEvent::TurnFinished { .. } => Some(UiEvent::TurnFinished),
        AgentEvent::PlanProposed {
            plan_text,
            tool_calls,
        } => Some(UiEvent::PlanProposed {
            plan_text,
            tool_calls,
        }),
        AgentEvent::PlanConfirmed => Some(UiEvent::PlanConfirmed),
        AgentEvent::PlanRejected { reason } => Some(UiEvent::PlanRejected { reason }),
        // Goal-202: plan-mode pre-confirmation events.
        AgentEvent::PlanModeRequested { reason } => Some(UiEvent::PlanModeRequested { reason }),
        AgentEvent::PlanModeApproved => Some(UiEvent::PlanModeApproved),
        AgentEvent::PlanModeRejected { reason } => Some(UiEvent::PlanModeRejected { reason }),
        // Goal-167: forward todo updates to the UI.
        AgentEvent::TodoUpdated { todos } => Some(UiEvent::TodoUpdated { todos }),

        // Goal-168: forward goal-loop events.
        AgentEvent::GoalContinuing { reason, turns } => {
            Some(UiEvent::GoalContinuing { reason, turns })
        }
        AgentEvent::GoalAchieved { condition, turns } => {
            Some(UiEvent::GoalAchieved { condition, turns })
        }
        AgentEvent::GoalCleared => Some(UiEvent::GoalCleared),

        // Goal-210: hook progress events.
        AgentEvent::HookStarted {
            hook_event,
            hook_name,
            status_message,
        } => Some(UiEvent::HookStarted {
            hook_event,
            hook_name,
            status_message,
        }),
        AgentEvent::HookProgress {
            hook_event,
            hook_name,
            last_line,
        } => Some(UiEvent::HookProgress {
            hook_event,
            hook_name,
            last_line,
        }),
        AgentEvent::HookFinished {
            hook_event,
            hook_name,
            outcome,
            duration_ms,
        } => Some(UiEvent::HookFinished {
            hook_event,
            hook_name,
            outcome,
            duration_ms,
        }),
        AgentEvent::HookSystemMessage { text } => Some(UiEvent::HookSystemMessage { text }),

        _ => None,
    }
}

// ── Goal-161: TuiPermissionHook ──────────────────────────────────────────────

/// Forwards tool-permission requests to the UI via a side-channel and blocks
/// until the user responds. When `enabled` is `false`, auto-allows all calls.
struct TuiPermissionHook {
    tx: mpsc::UnboundedSender<PermissionRequest>,
    enabled: Arc<AtomicBool>,
}

#[async_trait]
impl PermissionHook for TuiPermissionHook {
    async fn check(
        &self,
        tool_name: &str,
        args: &serde_json::Value,
    ) -> crate::agent::PermissionDecision {
        use crate::agent::PermissionDecision;
        if !self.enabled.load(Ordering::Relaxed) {
            return PermissionDecision::Allow;
        }
        let args_preview = crate::tools::args_preview_for_permission(args);
        let (reply_tx, reply_rx) = tokio::sync::oneshot::channel::<bool>();
        let req = PermissionRequest {
            tool_name: tool_name.to_string(),
            args_preview,
            reply: reply_tx,
        };
        if self.tx.send(req).is_err() {
            return PermissionDecision::Allow; // UI dropped — allow so agent isn't stuck.
        }
        if reply_rx.await.unwrap_or(false) {
            PermissionDecision::Allow
        } else {
            PermissionDecision::Deny("denied by user".to_string())
        }
    }
}

async fn worker_loop(
    mut state: RuntimeBuild,
    mut action_rx: mpsc::UnboundedReceiver<UserAction>,
    event_tx: mpsc::UnboundedSender<UiEvent>,
    perm_tx: mpsc::UnboundedSender<PermissionRequest>,
    cancel_flag: Arc<AtomicBool>,
    permission_enabled: Arc<AtomicBool>,
    #[cfg(feature = "weixin")] mut weixin_rx: mpsc::UnboundedReceiver<WeixinBackendRequest>,
) {
    if let RuntimeBuild::Ready(rt_opt) = &mut state {
        let rt = rt_opt.as_mut().unwrap();
        rt.set_event_sink(Arc::new(TuiEventSink {
            tx: event_tx.clone(),
        }));
        // Goal-161: wire up the permission hook.
        rt.set_permission_hook(Arc::new(TuiPermissionHook {
            tx: perm_tx,
            enabled: permission_enabled,
        }));
    }

    let bash_registry = build_bash_registry(&resolve_workspace_root());
    let bash_seq = AtomicU64::new(0);

    // Lazily-created session writer for TUI interactive sessions.
    // Created on the first SendMessage so that sessions without any
    // actual user messages don't leave empty files on disk.
    // Wrapped in Arc<Mutex<>> so SessionPersistenceSink can share it
    // and write to disk in real-time on every MessageAppended event.
    let mut session_writer: Option<Arc<std::sync::Mutex<SessionWriter>>> = None;

    loop {
        // Select on both the user-action channel and the WeChat side-channel.
        // WeChat messages processed here behave like SendMessage turns but
        // without plan-mode interaction.
        let action = {
            #[cfg(feature = "weixin")]
            {
                tokio::select! {
                    action = action_rx.recv() => {
                        match action {
                            Some(a) => Either::Left(a),
                            None => break,
                        }
                    }
                    wx_req = weixin_rx.recv() => {
                        match wx_req {
                            Some(r) => Either::Right(r),
                            None => continue,
                        }
                    }
                }
            }
            #[cfg(not(feature = "weixin"))]
            {
                match action_rx.recv().await {
                    Some(a) => Either::<UserAction, ()>::Left(a),
                    None => break,
                }
            }
        };

        #[cfg(feature = "weixin")]
        if let Either::Right(wx_req) = action {
            // Notify TUI of the incoming WeChat message.
            let _ = event_tx.send(UiEvent::WeixinMessage {
                user_id: wx_req.user_id.clone(),
                text: wx_req.text.clone(),
            });
            // Run the turn and send response back to WeChat daemon.
            if let RuntimeBuild::Ready(rt_opt) = &mut state {
                let text = wx_req.text.clone();
                let rt = rt_opt.take().unwrap();
                let rt_shared = Arc::new(tokio::sync::Mutex::new(rt));
                let rt_clone = rt_shared.clone();
                let handle = tokio::task::spawn(async move {
                    let mut g = rt_clone.lock().await;
                    g.enqueue(text).await
                });
                let result = handle.await;
                let recovered = Arc::try_unwrap(rt_shared)
                    .expect("single owner after weixin task")
                    .into_inner();
                *rt_opt = Some(recovered);
                let _ = event_tx.send(UiEvent::TurnFinished);
                let final_text = match result {
                    Ok(Ok(Some(outcome))) => outcome.final_text,
                    _ => None,
                };
                let _ = wx_req.reply_tx.send(final_text);
            } else {
                let _ = wx_req.reply_tx.send(None);
            }
            continue;
        }

        let action = match action {
            Either::Left(a) => a,
            Either::Right(_) => unreachable!("weixin Right handled above"),
        };

        match action {
            UserAction::Shutdown => {
                if let Some(sw_arc) = session_writer.take() {
                    if let Ok(mut sw) = sw_arc.lock() {
                        let _ = sw.finish("success");
                    }
                }
                break;
            }

            UserAction::SendMessage(text) => {
                if let RuntimeBuild::Ready(rt_opt) = &mut state {
                    let pre_turn_len = rt_opt.as_ref().unwrap().transcript().len();

                    // On the first user message, create a SessionWriter and wire
                    // it into the runtime's event sink via SessionPersistenceSink
                    // so every MessageAppended event is written to disk in real-time.
                    if session_writer.is_none() {
                        let ws = resolve_workspace_root();
                        let goal: String = text.chars().take(200).collect();
                        let model = crate::tui::cost::detect_model_name();
                        if let Ok(sw) = SessionWriter::create(&ws, &goal, &model, "tui") {
                            let sw_arc = Arc::new(std::sync::Mutex::new(sw));
                            // Build a composite sink: TUI display + session persistence.
                            let composite = Arc::new(CompositeSink::new([
                                Box::new(TuiEventSink {
                                    tx: event_tx.clone(),
                                }) as Box<dyn EventSink>,
                                Box::new(SessionPersistenceSink::new(sw_arc.clone())),
                            ]));
                            rt_opt.as_mut().unwrap().set_event_sink(composite);
                            session_writer = Some(sw_arc);
                        }
                    }

                    let rt = rt_opt.take().unwrap();
                    // Clone the gate before moving the runtime into the spawned task.
                    // This lets us signal plan approval/rejection via action_rx while
                    // the task is blocked inside exit_plan_mode.
                    let gate = rt.plan_approval_gate();
                    let rt_shared = Arc::new(tokio::sync::Mutex::new(rt));
                    let rt_clone = rt_shared.clone();
                    cancel_flag.store(false, Ordering::SeqCst);
                    let cancel_clone = cancel_flag.clone();
                    let mut handle = tokio::task::spawn(async move {
                        let mut g = rt_clone.lock().await;
                        g.enqueue(text).await.map(|_| ())
                    });
                    let aborted = run_turn_select_loop(
                        &mut handle,
                        &mut action_rx,
                        &event_tx,
                        &cancel_flag,
                        cancel_clone,
                        &gate,
                    )
                    .await;
                    let mut recovered = Arc::try_unwrap(rt_shared)
                        .expect("single owner after task end")
                        .into_inner();
                    if aborted {
                        recovered.truncate_transcript(pre_turn_len);
                    }
                    *rt_opt = Some(recovered);
                    let _ = event_tx.send(UiEvent::TurnFinished);
                    cancel_flag.store(false, Ordering::SeqCst);
                } else if let RuntimeBuild::Offline { reason } = &state {
                    let _ = event_tx.send(UiEvent::Error {
                        message: reason.clone(),
                    });
                    let _ = event_tx.send(UiEvent::TurnFinished);
                }
            }

            UserAction::RunShell(cmd) => {
                run_bash_command(&bash_registry, &bash_seq, cmd, &event_tx).await;
            }

            UserAction::ConfirmPlan => {
                if let RuntimeBuild::Ready(rt_opt) = &mut state {
                    rt_opt.as_mut().unwrap().confirm_plan();
                    let pre_turn_len = rt_opt.as_ref().unwrap().transcript().len();
                    let rt = rt_opt.take().unwrap();
                    let gate = rt.plan_approval_gate();
                    let rt_shared = Arc::new(tokio::sync::Mutex::new(rt));
                    let rt_clone = rt_shared.clone();
                    cancel_flag.store(false, Ordering::SeqCst);
                    let cancel_clone = cancel_flag.clone();
                    let mut handle = tokio::task::spawn(async move {
                        let mut g = rt_clone.lock().await;
                        g.run("").await.map(|_| ())
                    });
                    let aborted = run_turn_select_loop(
                        &mut handle,
                        &mut action_rx,
                        &event_tx,
                        &cancel_flag,
                        cancel_clone,
                        &gate,
                    )
                    .await;
                    let mut recovered = Arc::try_unwrap(rt_shared)
                        .expect("single owner after task end")
                        .into_inner();
                    if aborted {
                        recovered.truncate_transcript(pre_turn_len);
                    }
                    *rt_opt = Some(recovered);
                    let _ = event_tx.send(UiEvent::TurnFinished);
                    cancel_flag.store(false, Ordering::SeqCst);
                }
            }

            UserAction::RejectPlan(reason) => {
                if let RuntimeBuild::Ready(rt_opt) = &mut state {
                    rt_opt.as_mut().unwrap().reject_plan(&reason);
                }
            }

            // Goal-202: plan-mode pre-confirmation responses.
            UserAction::ApprovePlanMode => {
                if let RuntimeBuild::Ready(rt_opt) = &mut state {
                    rt_opt.as_ref().unwrap().approve_plan_mode_request();
                }
            }
            UserAction::RejectPlanMode(reason) => {
                if let RuntimeBuild::Ready(rt_opt) = &mut state {
                    rt_opt.as_ref().unwrap().reject_plan_mode_request(&reason);
                }
            }

            UserAction::Compact => match &mut state {
                RuntimeBuild::Ready(rt_opt) => {
                    if let Err(e) = rt_opt.as_mut().unwrap().compact_now().await {
                        let _ = event_tx.send(UiEvent::Error {
                            message: format!("compact failed: {e}"),
                        });
                    }
                }
                RuntimeBuild::Offline { .. } => {
                    let _ = event_tx.send(UiEvent::Error {
                        message: "compact unavailable in offline mode".into(),
                    });
                }
            },

            UserAction::SetPlanningMode(on) => {
                if let RuntimeBuild::Ready(rt_opt) = &mut state {
                    let mode = if on {
                        crate::PlanningMode::PlanFirst
                    } else {
                        crate::PlanningMode::Immediate
                    };
                    rt_opt.as_mut().unwrap().set_planning_mode(mode);
                }
            }

            UserAction::Interrupt => {
                cancel_flag.store(true, Ordering::SeqCst);
            }

            // Goal-168: start a condition-based autonomous loop.
            UserAction::SetGoal {
                condition,
                max_turns,
            } => {
                if let RuntimeBuild::Ready(rt_opt) = &mut state {
                    let pre_turn_len = rt_opt.as_ref().unwrap().transcript().len();
                    let rt = rt_opt.take().unwrap();
                    let gate = rt.plan_approval_gate();
                    let rt_shared = Arc::new(tokio::sync::Mutex::new(rt));
                    let rt_clone = rt_shared.clone();
                    cancel_flag.store(false, Ordering::SeqCst);
                    let cancel_clone = cancel_flag.clone();
                    let prompt = format!(
                        "Start working towards the following goal: {condition}\n\nContinue until the goal is achieved."
                    );
                    let mut handle = tokio::task::spawn(async move {
                        let mut g = rt_clone.lock().await;
                        g.run_goal_loop(prompt, condition, max_turns)
                            .await
                            .map(|_| ())
                    });
                    let aborted = run_turn_select_loop(
                        &mut handle,
                        &mut action_rx,
                        &event_tx,
                        &cancel_flag,
                        cancel_clone,
                        &gate,
                    )
                    .await;
                    // Suppress goal-loop errors; they are surfaced via GoalContinuing/GoalAchieved.
                    let mut recovered = Arc::try_unwrap(rt_shared)
                        .expect("single owner after task end")
                        .into_inner();
                    if aborted {
                        recovered.truncate_transcript(pre_turn_len);
                    }
                    *rt_opt = Some(recovered);
                    let _ = event_tx.send(UiEvent::TurnFinished);
                    cancel_flag.store(false, Ordering::SeqCst);
                } else if let RuntimeBuild::Offline { reason } = &state {
                    let _ = event_tx.send(UiEvent::Error {
                        message: reason.clone(),
                    });
                }
            }

            // Goal-168: clear the active goal.
            UserAction::ClearGoal => {
                if let RuntimeBuild::Ready(rt_opt) = &mut state {
                    rt_opt.as_mut().unwrap().clear_goal().await;
                }
            }

            // Goal-171: load a saved session transcript into the runtime.
            UserAction::ResumeSession { session_dir } => {
                if let RuntimeBuild::Ready(rt_opt) = &mut state {
                    let rt = rt_opt.as_mut().unwrap();
                    match crate::session::SessionReader::load_messages(&session_dir) {
                        Ok(messages) => {
                            let turn_count = messages.len();
                            rt.set_transcript(messages);
                            let session_id = session_dir
                                .file_name()
                                .and_then(|n| n.to_str())
                                .unwrap_or("unknown")
                                .to_string();
                            let _ = event_tx.send(UiEvent::SessionResumed {
                                session_id,
                                turn_count,
                            });
                        }
                        Err(e) => {
                            let _ = event_tx.send(UiEvent::Error {
                                message: format!("Failed to load session: {e}"),
                            });
                        }
                    }
                }
            }

            // Goal-173: list MCP servers.
            UserAction::ListMcpServers => {
                let workspace = resolve_workspace_root();
                let tx = event_tx.clone();
                tokio::spawn(async move {
                    let servers = crate::mcp::discover_mcp_servers(&workspace)
                        .await
                        .unwrap_or_default();
                    let entries: Vec<crate::tui::ui::modal::McpEntry> = servers
                        .iter()
                        .map(|s| {
                            let transport = if s.url.is_some() {
                                "http".to_string()
                            } else if !s.command.is_empty() {
                                "stdio".to_string()
                            } else {
                                "unknown".to_string()
                            };
                            crate::tui::ui::modal::McpEntry {
                                name: s.name.clone(),
                                transport,
                                enabled: true,
                            }
                        })
                        .collect();
                    let _ = tx.send(UiEvent::McpServersLoaded { entries });
                });
            }

            // Goal-169: run an already-expanded skill prompt.
            UserAction::RunSkillPrompt { prompt } => {
                if let RuntimeBuild::Ready(rt_opt) = &mut state {
                    let pre_turn_len = rt_opt.as_ref().unwrap().transcript().len();
                    let rt = rt_opt.take().unwrap();
                    let rt_shared = Arc::new(tokio::sync::Mutex::new(rt));
                    let rt_clone = rt_shared.clone();
                    cancel_flag.store(false, Ordering::SeqCst);
                    let cancel_clone = cancel_flag.clone();
                    let mut handle = tokio::task::spawn(async move {
                        let mut g = rt_clone.lock().await;
                        g.run(prompt).await.map(|_| ())
                    });
                    let aborted = tokio::select! {
                        res = &mut handle => {
                            if let Err(e) = res
                                .map_err(|e| crate::Error::Other(e.to_string()))
                                .and_then(|r| r)
                            {
                                let _ = event_tx.send(UiEvent::Error { message: e.to_string() });
                            }
                            false
                        },
                        _ = wait_for_cancel(cancel_clone) => {
                            handle.abort();
                            let _ = handle.await;
                            let _ = event_tx.send(UiEvent::Interrupted);
                            true
                        }
                    };
                    let mut recovered = Arc::try_unwrap(rt_shared)
                        .expect("single owner after task end")
                        .into_inner();
                    if aborted {
                        recovered.truncate_transcript(pre_turn_len);
                    }
                    *rt_opt = Some(recovered);
                    let _ = event_tx.send(UiEvent::TurnFinished);
                    cancel_flag.store(false, Ordering::SeqCst);
                } else if let RuntimeBuild::Offline { reason } = &state {
                    let _ = event_tx.send(UiEvent::Error {
                        message: reason.clone(),
                    });
                    let _ = event_tx.send(UiEvent::TurnFinished);
                }
            }
        }
    }
}

pub async fn wait_for_cancel(flag: Arc<AtomicBool>) {
    loop {
        if flag.load(Ordering::SeqCst) {
            return;
        }
        tokio::time::sleep(std::time::Duration::from_millis(100)).await;
    }
}

/// Drive a spawned agent turn to completion while remaining responsive to
/// plan-approval and interrupt actions from the UI.
///
/// Returns `true` if the turn was aborted (cancel flag set or Shutdown received),
/// `false` if the task completed normally.
///
/// While a turn runs, `action_rx` is polled concurrently so that
/// `UserAction::ConfirmPlan` / `UserAction::RejectPlan` can signal the
/// `PlanApprovalGate` directly — unblocking `exit_plan_mode` without
/// requiring a new turn. `UserAction::Interrupt` sets the cancel flag.
/// Any other actions received during the turn are silently discarded
/// (they cannot be acted on without the runtime, which is inside the task).
async fn run_turn_select_loop(
    handle: &mut tokio::task::JoinHandle<Result<(), crate::Error>>,
    action_rx: &mut tokio::sync::mpsc::UnboundedReceiver<UserAction>,
    event_tx: &tokio::sync::mpsc::UnboundedSender<UiEvent>,
    cancel_flag: &Arc<AtomicBool>,
    cancel_clone: Arc<AtomicBool>,
    gate: &Arc<crate::tools::plan_mode::PlanApprovalGate>,
) -> bool {
    loop {
        tokio::select! {
            biased;
            res = &mut *handle => {
                if let Err(e) = res
                    .map_err(|e| crate::Error::Other(e.to_string()))
                    .and_then(|r| r)
                {
                    let _ = event_tx.send(UiEvent::Error { message: e.to_string() });
                }
                return false;
            }
            _ = wait_for_cancel(cancel_clone.clone()) => {
                handle.abort();
                let _ = handle.await;
                let _ = event_tx.send(UiEvent::Interrupted);
                return true;
            }
            maybe_action = action_rx.recv() => {
                match maybe_action {
                    Some(UserAction::ConfirmPlan) => gate.approve(),
                    Some(UserAction::RejectPlan(reason)) => gate.reject(&reason),
                    Some(UserAction::Interrupt) => {
                        cancel_flag.store(true, Ordering::SeqCst);
                    }
                    Some(UserAction::Shutdown) => {
                        handle.abort();
                        let _ = handle.await;
                        return true;
                    }
                    // Other actions cannot be serviced while the runtime is
                    // inside the spawned task. Discard them — in normal usage
                    // only plan/interrupt actions arrive during a running turn.
                    Some(_) => {}
                    None => return false,
                }
            }
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::tui::bash::build_bash_registry;

    #[test]
    fn map_partial_token_to_assistant_partial() {
        let ev = AgentEvent::PartialToken {
            text: "hel".into(),
            step: 0,
        };
        assert_eq!(
            map_agent_event(ev),
            Some(UiEvent::AssistantPartial { text: "hel".into() })
        );
    }

    #[test]
    fn map_assistant_text_to_assistant_message() {
        let ev = AgentEvent::AssistantText {
            text: "hi".into(),
            step: 0,
        };
        assert_eq!(
            map_agent_event(ev),
            Some(UiEvent::AssistantMessage {
                content: "hi".into()
            })
        );
    }

    #[test]
    fn map_tool_result_error_prefix_marks_failure() {
        let ev = AgentEvent::ToolResult {
            id: "1".into(),
            name: "read_file".into(),
            output: "ERROR: missing".into(),
            step: 0,
        };
        let mapped = map_agent_event(ev).unwrap();
        match mapped {
            UiEvent::ToolResult { success, .. } => assert!(!success),
            other => panic!("expected ToolResult, got {other:?}"),
        }
    }

    #[test]
    fn map_compacted_event() {
        let ev = AgentEvent::Compacted {
            removed: 5,
            kept: 2,
            summary_chars: 800,
            step: 0,
        };
        assert_eq!(
            map_agent_event(ev),
            Some(UiEvent::Compacted {
                removed: 5,
                kept: 2
            })
        );
    }

    #[test]
    fn map_plan_proposed_is_forwarded() {
        let ev = AgentEvent::PlanProposed {
            plan_text: "p".into(),
            tool_calls: vec![],
        };
        match map_agent_event(ev) {
            Some(UiEvent::PlanProposed {
                plan_text,
                tool_calls,
            }) => {
                assert_eq!(plan_text, "p");
                assert!(tool_calls.is_empty());
            }
            other => panic!("expected PlanProposed forward, got {other:?}"),
        }
    }

    #[test]
    fn map_plan_confirmed_is_forwarded() {
        let mapped = map_agent_event(AgentEvent::PlanConfirmed);
        assert_eq!(mapped, Some(UiEvent::PlanConfirmed));
    }

    #[test]
    fn map_plan_rejected_is_forwarded() {
        let mapped = map_agent_event(AgentEvent::PlanRejected {
            reason: "user rejected".into(),
        });
        assert_eq!(
            mapped,
            Some(UiEvent::PlanRejected {
                reason: "user rejected".into(),
            })
        );
    }

    #[tokio::test]
    #[cfg_attr(target_os = "windows", ignore)]
    async fn run_shell_action_dispatches_tool_and_emits_events() {
        let tmp = tempfile::TempDir::new().unwrap();
        let registry = build_bash_registry(tmp.path());
        let (tx, mut rx) = mpsc::unbounded_channel::<UiEvent>();
        let seq = AtomicU64::new(0);
        run_bash_command(&registry, &seq, "echo bash-mode-works".into(), &tx).await;

        let call = rx.recv().await.expect("ToolCall event");
        match call {
            UiEvent::ToolCall {
                ref name,
                ref id,
                ref arguments,
            } => {
                assert_eq!(name, "run_shell");
                assert!(id.starts_with("ui-bash-"));
                assert!(
                    arguments.contains("echo bash-mode-works"),
                    "arguments missing command: {arguments}"
                );
            }
            other => panic!("expected ToolCall, got {other:?}"),
        }

        let res = rx.recv().await.expect("ToolResult event");
        match res {
            UiEvent::ToolResult {
                ref name,
                ref output,
                success,
                ..
            } => {
                assert_eq!(name, "run_shell");
                assert!(success, "shell command should succeed");
                assert!(
                    output.contains("bash-mode-works"),
                    "output missing stdout: {output}"
                );
            }
            other => panic!("expected ToolResult, got {other:?}"),
        }
    }

    #[tokio::test]
    async fn run_shell_action_works_when_runtime_offline() {
        let tmp = tempfile::TempDir::new().unwrap();
        let registry = build_bash_registry(tmp.path());
        let (tx, mut rx) = mpsc::unbounded_channel::<UiEvent>();
        let seq = AtomicU64::new(42);
        run_bash_command(&registry, &seq, "echo offline".into(), &tx).await;

        let call = rx.recv().await.expect("ToolCall event");
        if let UiEvent::ToolCall { id, .. } = call {
            assert_eq!(id, "ui-bash-42");
        } else {
            panic!("expected ToolCall, got {call:?}");
        }
        let _ = rx.recv().await;
    }

    #[tokio::test]
    async fn run_with_cancel_flag_true_returns_quickly() {
        let flag = Arc::new(AtomicBool::new(true));
        let started = std::time::Instant::now();
        let timed = tokio::time::timeout(
            std::time::Duration::from_millis(500),
            wait_for_cancel(flag.clone()),
        )
        .await;
        let elapsed = started.elapsed();
        assert!(timed.is_ok(), "wait_for_cancel didn't return in time");
        assert!(
            elapsed < std::time::Duration::from_millis(500),
            "wait_for_cancel was too slow: {elapsed:?}"
        );
    }

    #[tokio::test]
    async fn interrupt_action_sets_cancel_flag() {
        let prev_recursive = std::env::var("RECURSIVE_API_KEY").ok();
        let prev_openai = std::env::var("OPENAI_API_KEY").ok();
        std::env::remove_var("RECURSIVE_API_KEY");
        std::env::remove_var("OPENAI_API_KEY");

        let backend = Backend::spawn();
        assert!(!backend.cancel_flag.load(Ordering::SeqCst));
        backend.action_tx.send(UserAction::Interrupt).unwrap();

        let deadline = tokio::time::Instant::now() + std::time::Duration::from_secs(2);
        while tokio::time::Instant::now() < deadline {
            if backend.cancel_flag.load(Ordering::SeqCst) {
                break;
            }
            tokio::time::sleep(std::time::Duration::from_millis(20)).await;
        }
        assert!(
            backend.cancel_flag.load(Ordering::SeqCst),
            "Interrupt should set cancel_flag"
        );
        let _ = backend.action_tx.send(UserAction::Shutdown);

        if let Some(v) = prev_recursive {
            std::env::set_var("RECURSIVE_API_KEY", v);
        }
        if let Some(v) = prev_openai {
            std::env::set_var("OPENAI_API_KEY", v);
        }
    }
}