read-structure 0.3.0

Library for parsing and working with read structure descriptions
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
//! Read Structures
//!
//! Type [`ReadStructure`] describes the structure of a given read.  A read
//! contains one or more read segments. A read segment describes a contiguous
//! stretch of bases of the same type (e.g. template bases).
//!
//! At most one segment may be the indefinite-length (`+`) segment meaning "the rest
//! of the read"; it can appear in any position, not just the terminal one.

use crate::ErrorMessageParts;
use crate::ReadStructureError;
use crate::read_segment::ANY_LENGTH_BYTE;
use crate::read_segment::ReadSegment;
use crate::segment_type::SegmentType;
use std::iter::FusedIterator;
use std::ops::Index;

/// Controls whether [`SegmentType::Skip`] segments are emitted by
/// [`ReadStructure::extract`].
#[derive(Debug, Copy, Clone, Eq, PartialEq, Hash)]
pub enum SkipHandling {
    /// Emit every segment, including those of type [`SegmentType::Skip`].
    Include,
    /// Skip over [`SegmentType::Skip`] segments in the output iterator.
    Exclude,
}

/// A read structure made up of one or more [`ReadSegment`]s.
///
/// Internally, in addition to the segments themselves, we cache per-segment start
/// offsets (signed) and enough summary information to resolve the indefinite-length
/// (`+`) segment's end position at extract time without another pass over the
/// segments.
#[derive(Debug, Clone, PartialEq)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
#[cfg_attr(feature = "serde", serde(into = "String", try_from = "String"))]
pub struct ReadStructure {
    /// The elements that make up the [`ReadStructure`].
    elements: Vec<ReadSegment>,
    /// Sum of lengths across all fixed-length (non-`+`) segments.
    length_of_fixed_segments: usize,
    /// Index of the indefinite-length (`+`) segment, if any.
    plus_index: Option<usize>,
    /// Sum of fixed-length-segment lengths strictly AFTER the `+` segment. Zero when
    /// there is no `+` or when `+` is terminal. Allows the end of the `+` segment to
    /// be located as `read_len - post_plus_len` at extract time.
    post_plus_len: usize,
    /// Per-element start offset.
    ///
    /// Sign carries the frame of reference:
    /// - `>= 0` — offset from the start of the read. Used for segments before or
    ///   at the `+`, and for every segment when there is no `+`.
    /// - `<  0` — distance from the end of the read, stored as a negative number.
    ///   Used for segments strictly after a non-terminal `+`. The actual start
    ///   position in a read of length `L` is `L + offset` (i.e., `L - (-offset)`).
    offsets: Vec<isize>,
}

impl ReadStructure {
    /// Builds a new [`ReadStructure`] from a vector of [`ReadSegment`]s.
    ///
    /// At most one segment may have an indefinite length (`+`); it may appear in any
    /// position.
    ///
    /// # Errors
    ///
    /// - Returns `Err` if no elements exist.
    /// - Returns `Err` if more than one segment has an indefinite length.
    #[allow(clippy::missing_panics_doc)]
    pub fn new(segments: Vec<ReadSegment>) -> Result<Self, ReadStructureError> {
        if segments.is_empty() {
            return Err(ReadStructureError::ReadStructureContainsZeroElements);
        }

        let mut num_indefinite = 0;
        let mut length_of_fixed_segments = 0;
        let mut plus_index: Option<usize> = None;
        for (i, s) in segments.iter().enumerate() {
            if let Some(len) = s.length {
                length_of_fixed_segments += len;
            } else {
                num_indefinite += 1;
                if plus_index.is_none() {
                    plus_index = Some(i);
                }
            }
        }

        if num_indefinite > 1 {
            return Err(ReadStructureError::ReadStructureMultipleIndefiniteLengthSegments(
                *segments.iter().find(|s| !s.has_length()).unwrap(),
            ));
        }

        // Compute per-element offsets. Two-pass: forward for pre-and-at-`+` (and
        // for every segment when there is no `+`), then backward for segments
        // strictly after the `+`.
        let n = segments.len();
        let mut offsets = vec![0isize; n];

        // Forward pass up to and including the `+` (or the whole vec if no `+`).
        let forward_end = plus_index.map_or(n, |p| p + 1);
        let mut off: usize = 0;
        for (i, seg) in segments.iter().take(forward_end).enumerate() {
            offsets[i] = off as isize;
            off += seg.length.unwrap_or(0);
        }

        // Backward pass for segments strictly after the `+`, if any.
        let mut post_plus_len: usize = 0;
        if let Some(p) = plus_index {
            // `dist_from_end` is the total number of bases from the *start* of the
            // current segment to the end of the read. We walk from the end back.
            let mut dist_from_end: usize = 0;
            for (i, seg) in segments.iter().enumerate().skip(p + 1).rev() {
                // Fixed length — invariants: non-`+` segments always have a length.
                let len = seg.length.expect("post-+ segments must be fixed length");
                dist_from_end += len;
                offsets[i] = -(dist_from_end as isize);
            }
            post_plus_len = dist_from_end;
        }

        Ok(ReadStructure {
            elements: segments,
            length_of_fixed_segments,
            plus_index,
            post_plus_len,
            offsets,
        })
    }

    /// Extracts the bases and quality scores for every segment in this read structure.
    ///
    /// Returns a no-alloc iterator over `(&ReadSegment, &[u8] bases, &[u8] quals)` triples.
    /// All error conditions are checked up front, so the returned iterator is infallible
    /// and can be cheaply `.collect()`ed into a `Vec` when an owned collection is needed.
    ///
    /// `skip_handling` controls whether [`SegmentType::Skip`] segments are emitted
    /// ([`SkipHandling::Include`]) or silently dropped ([`SkipHandling::Exclude`]).
    ///
    /// # Errors
    ///
    /// - [`ReadStructureError::MismatchingBasesAndQualsLen`] if `bases.len() != quals.len()`.
    /// - [`ReadStructureError::ReadTooShort`] if the read cannot accommodate every fixed
    ///   segment. When the structure also has a `+` segment, the read must be strictly
    ///   longer than the sum of the fixed-segment lengths (since `+` means at least
    ///   one base).
    /// - [`ReadStructureError::ReadTooLong`] if the structure has no `+` segment and
    ///   `bases.len()` does not exactly match `length_of_fixed_segments`. Silently
    ///   truncating trailing bases is almost always a bug (wrong structure, stray
    ///   adapter, etc.), so we require an exact match.
    pub fn extract<'rs, 'b>(
        &'rs self,
        bases: &'b [u8],
        quals: &'b [u8],
        skip_handling: SkipHandling,
    ) -> Result<ExtractedSegments<'rs, 'b>, ReadStructureError> {
        if bases.len() != quals.len() {
            return Err(ReadStructureError::MismatchingBasesAndQualsLen {
                bases_len: bases.len(),
                quals_len: quals.len(),
            });
        }

        let required = if self.plus_index.is_some() {
            self.length_of_fixed_segments + 1
        } else {
            self.length_of_fixed_segments
        };
        if bases.len() < required {
            return Err(ReadStructureError::ReadTooShort { read_len: bases.len(), required });
        }
        if self.plus_index.is_none() && bases.len() > self.length_of_fixed_segments {
            return Err(ReadStructureError::ReadTooLong {
                read_len: bases.len(),
                expected: self.length_of_fixed_segments,
            });
        }

        Ok(ExtractedSegments {
            elements: &self.elements,
            offsets: &self.offsets,
            plus_index: self.plus_index,
            post_plus_len: self.post_plus_len,
            bases,
            quals,
            skip_handling,
            next_index: 0,
        })
    }

    /// Returns `true` if the [`ReadStructure`] has a fixed (i.e. non-variable) length,
    /// `false` if any segment has an indefinite length.
    pub fn has_fixed_length(&self) -> bool {
        self.plus_index.is_none()
    }

    /// Returns the fixed length if there is one.
    pub fn fixed_length(&self) -> Option<usize> {
        if self.has_fixed_length() { Some(self.length_of_fixed_segments) } else { None }
    }

    /// Returns the number of segments in this read structure.
    pub fn number_of_segments(&self) -> usize {
        self.elements.len()
    }

    /// Returns the underlying elements in this read structure.
    pub fn segments(&self) -> &[ReadSegment] {
        &self.elements
    }

    /// Returns an iterator over the read segments.
    pub fn iter(&self) -> impl Iterator<Item = &ReadSegment> {
        self.elements.iter()
    }

    /// Returns the [`ReadSegment`]s in this read structure of the given kind.
    pub fn segments_by_type(&self, kind: SegmentType) -> impl Iterator<Item = &ReadSegment> {
        self.elements.iter().filter(move |seg| seg.kind == kind)
    }

    /// Returns the template [`ReadSegment`]s in this read structure.
    pub fn templates(&self) -> impl Iterator<Item = &ReadSegment> {
        self.segments_by_type(SegmentType::Template)
    }

    /// Returns the sample barcode [`ReadSegment`]s in this read structure.
    pub fn sample_barcodes(&self) -> impl Iterator<Item = &ReadSegment> {
        self.segments_by_type(SegmentType::SampleBarcode)
    }

    /// Returns the molecular barcode [`ReadSegment`]s in this read structure.
    pub fn molecular_barcodes(&self) -> impl Iterator<Item = &ReadSegment> {
        self.segments_by_type(SegmentType::MolecularBarcode)
    }

    /// Returns the skip [`ReadSegment`]s in this read structure.
    pub fn skips(&self) -> impl Iterator<Item = &ReadSegment> {
        self.segments_by_type(SegmentType::Skip)
    }

    /// Returns the cellular barcode [`ReadSegment`]s in this read structure.
    pub fn cellular_barcodes(&self) -> impl Iterator<Item = &ReadSegment> {
        self.segments_by_type(SegmentType::CellularBarcode)
    }

    /// Returns the first [`ReadSegment`] in this read structure.
    pub fn first(&self) -> Option<&ReadSegment> {
        self.elements.first()
    }

    /// Returns the last [`ReadSegment`] in this read structure.
    pub fn last(&self) -> Option<&ReadSegment> {
        self.elements.last()
    }
}

/// Iterator returned by [`ReadStructure::extract`].
///
/// Yields `(&ReadSegment, &[u8] bases, &[u8] quals)` triples — one per segment in
/// the underlying read structure, in order (with `Skip` segments optionally filtered
/// per [`SkipHandling`]). The iterator is infallible: all error checks are performed
/// up front in [`ReadStructure::extract`].
#[derive(Debug, Clone)]
pub struct ExtractedSegments<'rs, 'b> {
    elements: &'rs [ReadSegment],
    offsets: &'rs [isize],
    plus_index: Option<usize>,
    post_plus_len: usize,
    bases: &'b [u8],
    quals: &'b [u8],
    skip_handling: SkipHandling,
    next_index: usize,
}

impl<'rs, 'b> Iterator for ExtractedSegments<'rs, 'b> {
    type Item = (&'rs ReadSegment, &'b [u8], &'b [u8]);

    fn next(&mut self) -> Option<Self::Item> {
        while self.next_index < self.elements.len() {
            let i = self.next_index;
            self.next_index += 1;
            let seg = &self.elements[i];
            if self.skip_handling == SkipHandling::Exclude && seg.kind == SegmentType::Skip {
                continue;
            }
            let (start, end) = if Some(i) == self.plus_index {
                // The indefinite-length segment: runs from its stored start offset
                // to just before the post-`+` fixed region.
                (self.offsets[i] as usize, self.bases.len() - self.post_plus_len)
            } else {
                let off = self.offsets[i];
                let start =
                    if off >= 0 { off as usize } else { self.bases.len() - ((-off) as usize) };
                // Non-`+` segments always have a fixed length.
                let len = seg.length.expect("non-`+` segment must have a length");
                (start, start + len)
            };
            return Some((seg, &self.bases[start..end], &self.quals[start..end]));
        }
        None
    }
}

impl FusedIterator for ExtractedSegments<'_, '_> {}

impl IntoIterator for ReadStructure {
    type Item = ReadSegment;

    type IntoIter = std::vec::IntoIter<Self::Item>;

    fn into_iter(self) -> Self::IntoIter {
        self.elements.into_iter()
    }
}

impl Index<usize> for ReadStructure {
    type Output = ReadSegment;

    /// Returns the [`ReadSegment`] at the given index in the read structure.
    fn index(&self, idx: usize) -> &Self::Output {
        &self.elements[idx]
    }
}

impl std::fmt::Display for ReadStructure {
    /// Formats this read structure as a string.
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        for e in &self.elements {
            write!(f, "{}", e)?;
        }
        Ok(())
    }
}

impl std::str::FromStr for ReadStructure {
    type Err = ReadStructureError;

    /// Returns a new read structure from a string, or `Err` if parsing failed.
    fn from_str(rs: &str) -> Result<Self, Self::Err> {
        let mut i = 0;
        let mut segs: Vec<ReadSegment> = Vec::new();
        let chars: Vec<char> = rs.to_uppercase().chars().filter(|c| !c.is_whitespace()).collect();
        while i < chars.len() {
            // Stash the beginning position of our parsing so we can highlight what we're having trouble with
            let parse_i = i;

            // Parse out the length segment which many be 1 or more digits or the AnyLengthChar
            let length = if chars[i] as u8 == ANY_LENGTH_BYTE {
                i += 1;
                None
            } else if chars[i].is_ascii_digit() {
                let mut len: usize = 0;
                while i < chars.len() && chars[i].is_ascii_digit() {
                    // Unwrap is safe since we've checked `is_ascii_digit` already
                    let digit = chars[i].to_digit(10).unwrap() as usize;
                    len = (len * 10) + digit;
                    i += 1;
                }
                Some(len)
            } else {
                return Err(ReadStructureError::ReadStructureMissingLengthInformation(
                    ErrorMessageParts::new(&chars, parse_i, parse_i + 1),
                ));
            };

            // Parse out the operator and make a segment
            if chars.len() == i {
                return Err(ReadStructureError::ReadStructureMissingOperator(
                    ErrorMessageParts::new(&chars, parse_i, i),
                ));
            } else if let Ok(kind) = SegmentType::try_from(chars[i]) {
                if length == Some(0) {
                    return Err(ReadStructureError::ReadSegmentLengthZero(ErrorMessageParts::new(
                        &chars, parse_i, i,
                    )));
                }
                i += 1;
                segs.push(ReadSegment { length, kind });
            } else {
                return Err(ReadStructureError::ReadStructureHadUnknownType(
                    ErrorMessageParts::new(&chars, parse_i, i + 1),
                ));
            }
        }

        ReadStructure::new(segs)
    }
}

impl TryFrom<&[ReadSegment]> for ReadStructure {
    type Error = ReadStructureError;
    /// Builds a new read structure from a slice of elements.
    fn try_from(elements: &[ReadSegment]) -> Result<Self, Self::Error> {
        Self::new(elements.to_vec())
    }
}

impl TryFrom<String> for ReadStructure {
    type Error = ReadStructureError;
    /// Parses a read structure from an owned string; equivalent to [`FromStr`].
    fn try_from(s: String) -> Result<Self, Self::Error> {
        s.parse()
    }
}

impl From<ReadStructure> for String {
    /// Renders the read structure to its canonical string form (e.g. `"8B+M10T"`).
    fn from(rs: ReadStructure) -> Self {
        rs.to_string()
    }
}

#[cfg(test)]
mod test {
    use crate::ReadStructureError;
    use crate::read_structure::{ReadStructure, SkipHandling};
    use crate::segment_type::SegmentType;
    use std::str::FromStr;

    #[test]
    fn test_read_structure_from_str() {
        let rss =
            ["1T", "1B", "1M", "1S", "101T", "5B101T", "123456789T", "10T10B10B10S10M", "5B2C3T"];
        for rs in &rss {
            assert_eq!(ReadStructure::from_str(rs).unwrap().to_string(), *rs);
        }
    }

    #[test]
    fn test_read_structure_from_str_with_whitespace() {
        let rss = ["75T 8B 8B 75T", " 75T 8B 8B\t75T  "];
        for rs in &rss {
            assert_eq!(ReadStructure::from_str(rs).unwrap().to_string(), "75T8B8B75T");
        }
    }

    #[test]
    fn test_read_structure_accepts_plus_at_any_position_once() {
        assert_eq!(ReadStructure::from_str("5M+T").unwrap().to_string(), "5M+T");
        assert_eq!(ReadStructure::from_str("+M").unwrap().to_string(), "+M");
    }

    macro_rules! test_read_structure_from_str_err {
        ($($name:ident: $value:expr_2021,)*) => {
        $(
            #[test]
            fn $name() {
                 assert!(ReadStructure::from_str($value).is_err());
            }
        )*
        }
    }

    test_read_structure_from_str_err! {
        test_read_structure_rejects_multiple_plus_0: "++M",
        test_read_structure_rejects_multiple_plus_1: "5M++T",
        test_read_structure_rejects_multiple_plus_2: "5M70+T",
        test_read_structure_rejects_multiple_plus_3: "+M+T",
        test_read_structure_rejects_multiple_plus_4: "5M+T+B",
    }

    macro_rules! test_read_structure_from_str_invalid {
        ($($name:ident: $value:expr_2021,)*) => {
        $(
            #[test]
            fn $name() {
                let (input, expected) = $value;
                let actual = ReadStructure::from_str(input);
                assert!(actual.unwrap_err().to_string().ends_with(expected));
            }
        )*
        }
    }

    test_read_structure_from_str_invalid! {
        test_read_structure_from_str_invalid_0: ("9R", "[9R]"),
        test_read_structure_from_str_invalid_1: ("T", "[T]"),
        test_read_structure_from_str_invalid_2: ("23TT", "23T[T]"),
        test_read_structure_from_str_invalid_3: ("23T2", "23T[2]"),
        test_read_structure_from_str_invalid_4: ("23T2TT23T", "23T2T[T]23T"),
    }

    #[test]
    fn test_read_structure_collect_segments() {
        let rs = ReadStructure::from_str("10M9T8B7S3C10M9T8B7S2C").unwrap();
        let templates: String = rs.templates().map(|s| s.to_string()).collect();
        assert_eq!(templates, "9T9T");
        let sample_barcodes: String = rs.sample_barcodes().map(|s| s.to_string()).collect();
        assert_eq!(sample_barcodes, "8B8B");
        let molecular_barcodes: String = rs.molecular_barcodes().map(|s| s.to_string()).collect();
        assert_eq!(molecular_barcodes, "10M10M");
        let skips: String = rs.skips().map(|s| s.to_string()).collect();
        assert_eq!(skips, "7S7S");
        let cellular_barcodes: String = rs.cellular_barcodes().map(|s| s.to_string()).collect();
        assert_eq!(cellular_barcodes, "3C2C");
    }

    macro_rules! test_read_structure_length {
        ($($name:ident: $value:expr_2021,)*) => {
        $(
            #[test]
            fn $name() {
                let (input, expected) = $value;
                let actual = ReadStructure::from_str(input).unwrap().number_of_segments();
                assert_eq!(actual, expected);
            }
        )*
        }
    }

    test_read_structure_length! {
        test_read_structure_length_0: ("1T", 1),
        test_read_structure_length_1: ("1B", 1),
        test_read_structure_length_2: ("1M", 1),
        test_read_structure_length_3: ("1S", 1),
        test_read_structure_length_4: ("101T", 1),
        test_read_structure_length_5: ("5B101T", 2),
        test_read_structure_length_6: ("123456789T", 1),
        test_read_structure_length_7: ("10T10B10B10S10M", 5),
    }

    macro_rules! test_read_structure_index {
        ($($name:ident: $value:expr_2021,)*) => {
        $(
            #[test]
            fn $name() {
                let (string, index, exp_string) = $value;
                let read_structure = ReadStructure::from_str(string).unwrap();
                let read_segment = read_structure[index];
                assert_eq!(read_segment.to_string(), exp_string);
            }
        )*
        }
    }

    test_read_structure_index! {
        test_read_structure_index_0: ("1T", 0, "1T"),
        test_read_structure_index_1: ("1B", 0, "1B"),
        test_read_structure_index_2: ("1M", 0, "1M"),
        test_read_structure_index_3: ("1S", 0, "1S"),
        test_read_structure_index_4: ("101T", 0, "101T"),
        test_read_structure_index_5: ("5B101T", 0, "5B"),
        test_read_structure_index_6: ("5B101T", 1, "101T"),
        test_read_structure_index_7: ("123456789T", 0, "123456789T"),
        test_read_structure_index_8: ("10T10B10B10S10M", 0, "10T"),
        test_read_structure_index_9: ("10T10B10B10S10M", 1, "10B"),
        test_read_structure_index_10: ("10T10B10B10S10M", 2, "10B"),
        test_read_structure_index_11: ("10T10B10B10S10M", 3, "10S"),
        test_read_structure_index_12: ("10T10B10B10S10M", 4, "10M"),
        test_read_structure_index_32: ("10T10B10B10S10C10M", 4, "10C"),
    }

    #[test]
    #[cfg(feature = "serde")]
    fn test_serde() {
        let rs = ReadStructure::from_str("10T10B10B10S10M").unwrap();
        let rs_json = serde_json::to_string(&rs).unwrap();
        let rs2 = serde_json::from_str(&rs_json).unwrap();
        assert_eq!(rs, rs2);
    }

    #[test]
    #[cfg(feature = "serde")]
    fn test_serde_middle_plus_round_trip() {
        let rs = ReadStructure::from_str("8B+M10T").unwrap();
        let rs_json = serde_json::to_string(&rs).unwrap();
        let rs2: ReadStructure = serde_json::from_str(&rs_json).unwrap();
        assert_eq!(rs, rs2);
    }

    #[test]
    #[cfg(feature = "serde")]
    fn test_serde_wire_format_is_canonical_string() {
        // Pin the serialized form: a `ReadStructure` encodes as a single JSON
        // string, not as an object with internal cached fields.
        let rs = ReadStructure::from_str("8B+M10T").unwrap();
        let rs_json = serde_json::to_string(&rs).unwrap();
        assert_eq!(rs_json, "\"8B+M10T\"");
    }

    #[test]
    #[cfg(feature = "serde")]
    fn test_serde_rejects_invalid_string() {
        let err = serde_json::from_str::<ReadStructure>("\"not a read structure\"").unwrap_err();
        // Any deserialization error is acceptable here; just ensure it doesn't
        // silently produce an inconsistent structure.
        assert!(!err.to_string().is_empty());
    }

    // ---- non-terminal `+` acceptance (parsing + round-trip) ----

    #[test]
    fn test_accepts_middle_plus() {
        let rs = ReadStructure::from_str("8B+M10T").unwrap();
        assert_eq!(rs.to_string(), "8B+M10T");
        assert_eq!(rs.number_of_segments(), 3);
    }

    #[test]
    fn test_accepts_leading_plus() {
        let rs = ReadStructure::from_str("+B10T").unwrap();
        assert_eq!(rs.to_string(), "+B10T");
        assert_eq!(rs.number_of_segments(), 2);
    }

    #[test]
    fn test_accepts_middle_plus_between_fixed_runs() {
        let rs = ReadStructure::from_str("10T8B+M10T").unwrap();
        assert_eq!(rs.to_string(), "10T8B+M10T");
        assert_eq!(rs.number_of_segments(), 4);
    }

    // ---- has_fixed_length / fixed_length ----

    #[test]
    fn test_has_fixed_length_strict() {
        assert!(ReadStructure::from_str("10T8B").unwrap().has_fixed_length());
        assert!(!ReadStructure::from_str("10T+M").unwrap().has_fixed_length());
    }

    #[test]
    fn test_has_fixed_length_middle_plus() {
        assert!(!ReadStructure::from_str("8B+M10T").unwrap().has_fixed_length());
    }

    #[test]
    fn test_fixed_length_none_for_middle_plus() {
        assert!(ReadStructure::from_str("8B+M10T").unwrap().fixed_length().is_none());
    }

    // ---- extraction via ReadStructure::extract ----

    #[test]
    fn test_extract_fixed_length() {
        let rs = ReadStructure::from_str("10T8B").unwrap();
        let bases = b"AAAAAAAAAAGGGGGGGG";
        let quals = b"IIIIIIIIIIJJJJJJJJ";
        let out: Vec<_> = rs.extract(bases, quals, SkipHandling::Include).unwrap().collect();
        assert_eq!(out.len(), 2);
        assert_eq!(out[0].0.kind, SegmentType::Template);
        assert_eq!(out[0].1, b"AAAAAAAAAA");
        assert_eq!(out[0].2, b"IIIIIIIIII");
        assert_eq!(out[1].0.kind, SegmentType::SampleBarcode);
        assert_eq!(out[1].1, b"GGGGGGGG");
        assert_eq!(out[1].2, b"JJJJJJJJ");
    }

    #[test]
    fn test_extract_trailing_plus() {
        let rs = ReadStructure::from_str("10T+M").unwrap();
        let bases = b"AAAAAAAAAAGGGGGGGGGG";
        let quals = b"IIIIIIIIIIJJJJJJJJJJ";
        let out: Vec<_> = rs.extract(bases, quals, SkipHandling::Include).unwrap().collect();
        assert_eq!(out.len(), 2);
        assert_eq!(out[0].1, b"AAAAAAAAAA");
        assert_eq!(out[1].1, b"GGGGGGGGGG");
        assert_eq!(out[1].2, b"JJJJJJJJJJ");
    }

    #[test]
    fn test_extract_leading_plus() {
        let rs = ReadStructure::from_str("+B10T").unwrap();
        let bases = b"BBBBBTTTTTTTTTT";
        let quals = b"!!!!!##########";
        let out: Vec<_> = rs.extract(bases, quals, SkipHandling::Include).unwrap().collect();
        assert_eq!(out.len(), 2);
        assert_eq!(out[0].0.kind, SegmentType::SampleBarcode);
        assert_eq!(out[0].1, b"BBBBB");
        assert_eq!(out[0].2, b"!!!!!");
        assert_eq!(out[1].0.kind, SegmentType::Template);
        assert_eq!(out[1].1, b"TTTTTTTTTT");
        assert_eq!(out[1].2, b"##########");
    }

    #[test]
    fn test_extract_middle_plus() {
        let rs = ReadStructure::from_str("8B+M10T").unwrap();
        let bases = b"BBBBBBBBUUUUUUUUUUUUTTTTTTTTTT";
        let quals = b"!!!!!!!!@@@@@@@@@@@@##########";
        assert_eq!(bases.len(), 30);
        let out: Vec<_> = rs.extract(bases, quals, SkipHandling::Include).unwrap().collect();
        assert_eq!(out.len(), 3);
        assert_eq!(out[0].1, b"BBBBBBBB");
        assert_eq!(out[0].2, b"!!!!!!!!");
        assert_eq!(out[1].0.kind, SegmentType::MolecularBarcode);
        assert_eq!(out[1].1, b"UUUUUUUUUUUU");
        assert_eq!(out[1].2, b"@@@@@@@@@@@@");
        assert_eq!(out[2].1, b"TTTTTTTTTT");
        assert_eq!(out[2].2, b"##########");
    }

    #[test]
    fn test_extract_multiple_pre_plus_and_post_plus() {
        // Two pre-plus, one middle plus, one post-plus.
        let rs = ReadStructure::from_str("10T8B+M10T").unwrap();
        let bases = b"TTTTTTTTTTBBBBBBBBUUUUUUUUUUUUTTTTTTTTTT";
        let quals = b"IIIIIIIIII!!!!!!!!@@@@@@@@@@@@##########";
        assert_eq!(bases.len(), 40);
        let out: Vec<_> = rs.extract(bases, quals, SkipHandling::Include).unwrap().collect();
        assert_eq!(out.len(), 4);
        assert_eq!(out[0].1, b"TTTTTTTTTT");
        assert_eq!(out[1].1, b"BBBBBBBB");
        assert_eq!(out[2].1, b"UUUUUUUUUUUU");
        assert_eq!(out[3].1, b"TTTTTTTTTT");
    }

    #[test]
    fn test_extract_include_skips_false_drops_skip() {
        let rs = ReadStructure::from_str("8S+M10T").unwrap();
        let bases = b"SSSSSSSSUUUUUUUUUUUUTTTTTTTTTT";
        let quals = b"????????@@@@@@@@@@@@##########";
        let out: Vec<_> = rs.extract(bases, quals, SkipHandling::Exclude).unwrap().collect();
        assert_eq!(out.len(), 2);
        assert_eq!(out[0].0.kind, SegmentType::MolecularBarcode);
        assert_eq!(out[1].0.kind, SegmentType::Template);
    }

    #[test]
    fn test_extract_include_skips_true_keeps_skip() {
        let rs = ReadStructure::from_str("8S+M10T").unwrap();
        let bases = b"SSSSSSSSUUUUUUUUUUUUTTTTTTTTTT";
        let quals = b"????????@@@@@@@@@@@@##########";
        let out: Vec<_> = rs.extract(bases, quals, SkipHandling::Include).unwrap().collect();
        assert_eq!(out.len(), 3);
        assert_eq!(out[0].0.kind, SegmentType::Skip);
        assert_eq!(out[0].1, b"SSSSSSSS");
    }

    #[test]
    fn test_extract_errors_on_bases_quals_length_mismatch() {
        let rs = ReadStructure::from_str("10T").unwrap();
        let err = rs.extract(b"AAAAAAAAAA", b"III", SkipHandling::Include).unwrap_err();
        assert!(matches!(err, ReadStructureError::MismatchingBasesAndQualsLen { .. }));
    }

    #[test]
    fn test_extract_errors_when_read_too_short_for_fixed() {
        let rs = ReadStructure::from_str("10T8B").unwrap();
        let err = rs.extract(b"AAAA", b"IIII", SkipHandling::Include).unwrap_err();
        match err {
            ReadStructureError::ReadTooShort { read_len, required } => {
                assert_eq!(read_len, 4);
                assert_eq!(required, 18);
            }
            other => panic!("expected ReadTooShort, got {:?}", other),
        }
    }

    #[test]
    fn test_extract_errors_when_read_too_long_for_fixed() {
        // Fixed structures must get an exact-length read. Trailing bases are almost
        // always a bug (wrong structure, stray adapter), not data to quietly drop.
        let rs = ReadStructure::from_str("10T8B").unwrap();
        let bases = vec![b'X'; 20]; // fixed length is 18
        let quals = vec![b'#'; 20];
        let err = rs.extract(&bases, &quals, SkipHandling::Include).unwrap_err();
        match err {
            ReadStructureError::ReadTooLong { read_len, expected } => {
                assert_eq!(read_len, 20);
                assert_eq!(expected, 18);
            }
            other => panic!("expected ReadTooLong, got {:?}", other),
        }
    }

    #[test]
    fn test_extract_allows_extra_bases_when_plus_present() {
        // With a `+`, extra bases are by definition absorbed by the `+` segment.
        let rs = ReadStructure::from_str("8B+M10T").unwrap();
        let bases = b"BBBBBBBBUUUUUUUUUUUUUUUUUUUUUUUUTTTTTTTTTT";
        let quals = b"!!!!!!!!@@@@@@@@@@@@@@@@@@@@@@@@##########";
        assert_eq!(bases.len(), 42);
        let out: Vec<_> = rs.extract(bases, quals, SkipHandling::Include).unwrap().collect();
        assert_eq!(out.len(), 3);
        assert_eq!(out[1].1.len(), 24); // 42 - 8 - 10
    }

    #[test]
    fn test_extract_errors_when_read_exactly_fixed_len_but_plus_present() {
        // `+` requires at least one base, so read length must exceed fixed-length total.
        let rs = ReadStructure::from_str("8B+M10T").unwrap();
        let bases = vec![b'X'; 18]; // == length_of_fixed_segments
        let quals = vec![b'#'; 18];
        let err = rs.extract(&bases, &quals, SkipHandling::Include).unwrap_err();
        match err {
            ReadStructureError::ReadTooShort { read_len, required } => {
                assert_eq!(read_len, 18);
                assert_eq!(required, 19);
            }
            other => panic!("expected ReadTooShort, got {:?}", other),
        }
    }

    #[test]
    fn test_extract_allows_read_exactly_fixed_len_when_no_plus() {
        let rs = ReadStructure::from_str("10T8B").unwrap();
        let bases = vec![b'X'; 18];
        let quals = vec![b'#'; 18];
        let out: Vec<_> = rs.extract(&bases, &quals, SkipHandling::Include).unwrap().collect();
        assert_eq!(out.len(), 2);
    }

    #[test]
    fn test_extract_plus_only_structure() {
        // Entire read is one indefinite-length template segment.
        let rs = ReadStructure::from_str("+T").unwrap();
        let bases = b"AAAAAAAAAA";
        let quals = b"IIIIIIIIII";
        let out: Vec<_> = rs.extract(bases, quals, SkipHandling::Include).unwrap().collect();
        assert_eq!(out.len(), 1);
        assert_eq!(out[0].0.kind, SegmentType::Template);
        assert_eq!(out[0].1, bases);
        assert_eq!(out[0].2, quals);
    }

    #[test]
    fn test_extract_plus_yields_one_base_at_minimum_length() {
        // For `"8B+M10T"` the minimum read length is fixed + 1 = 19; at that length
        // the `+M` segment must contain exactly one base.
        let rs = ReadStructure::from_str("8B+M10T").unwrap();
        let bases = b"BBBBBBBBMTTTTTTTTTT";
        let quals = b"!!!!!!!!@##########";
        assert_eq!(bases.len(), 19);
        let out: Vec<_> = rs.extract(bases, quals, SkipHandling::Include).unwrap().collect();
        assert_eq!(out.len(), 3);
        assert_eq!(out[0].1, b"BBBBBBBB");
        assert_eq!(out[1].0.kind, SegmentType::MolecularBarcode);
        assert_eq!(out[1].1, b"M");
        assert_eq!(out[1].2, b"@");
        assert_eq!(out[2].1, b"TTTTTTTTTT");
    }

    #[test]
    fn test_extract_multiple_post_plus_segments() {
        // Two fixed segments after the `+` exercise the backward offset pass.
        let rs = ReadStructure::from_str("8B+M5T5S").unwrap();
        let bases = b"BBBBBBBBUUUUUUUUUUUUTTTTTSSSSS";
        let quals = b"!!!!!!!!@@@@@@@@@@@@#####?????";
        assert_eq!(bases.len(), 30);
        let out: Vec<_> = rs.extract(bases, quals, SkipHandling::Include).unwrap().collect();
        assert_eq!(out.len(), 4);
        assert_eq!(out[0].1, b"BBBBBBBB");
        assert_eq!(out[1].0.kind, SegmentType::MolecularBarcode);
        assert_eq!(out[1].1, b"UUUUUUUUUUUU");
        assert_eq!(out[2].0.kind, SegmentType::Template);
        assert_eq!(out[2].1, b"TTTTT");
        assert_eq!(out[3].0.kind, SegmentType::Skip);
        assert_eq!(out[3].1, b"SSSSS");
    }
}