raz-override 0.2.4

Override management system for raz with stable key generation
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
use crate::{
    CommandOverride, OverrideEntry, OverrideMetadata, ValidationStatus,
    detector::FunctionDetector,
    error::{OverrideError, Result},
    key::{FunctionContext, OverrideKey},
    preview::OverridePreview,
    resolver::{OverrideResolver, ResolutionStrategy},
    storage::OverrideStorage,
};
use std::path::{Path, PathBuf};

/// Parameters for creating an override preview
pub struct PreviewParams<'a> {
    pub override_config: &'a CommandOverride,
    pub context: &'a FunctionContext,
    pub base_command: &'a str,
    pub base_env: &'a indexmap::IndexMap<String, String>,
    pub base_cargo_options: &'a [String],
    pub base_rustc_options: &'a [String],
    pub base_args: &'a [String],
}

/// Main override system that coordinates all components
pub struct OverrideSystem {
    workspace_path: PathBuf,
    pub(crate) storage: OverrideStorage,
    detector: FunctionDetector,
}

impl OverrideSystem {
    /// Create a new override system for testing (bypasses hierarchy)
    #[cfg(test)]
    pub fn new_for_test(workspace_path: &Path) -> Result<Self> {
        let storage = OverrideStorage::new_for_test(workspace_path)?;
        let detector = FunctionDetector::new()?;

        Ok(Self {
            workspace_path: workspace_path.to_path_buf(),
            storage,
            detector,
        })
    }

    /// Create a new override system for a workspace
    pub fn new(workspace_path: &Path) -> Result<Self> {
        let storage = OverrideStorage::new(workspace_path)?;
        let detector = FunctionDetector::new()?;

        Ok(Self {
            workspace_path: workspace_path.to_path_buf(),
            storage,
            detector,
        })
    }

    /// Generate a stable key from context
    pub fn generate_key(&mut self, context: &FunctionContext) -> Result<OverrideKey> {
        // Try to enhance context with detected function name if not provided
        let enhanced_context = if context.function_name.is_none() {
            if let Ok(source) = std::fs::read_to_string(&context.file_path) {
                if let Some(func_info) = self
                    .detector
                    .find_function_at_line(&source, context.line_number)?
                {
                    FunctionContext {
                        function_name: Some(func_info.name),
                        ..context.clone()
                    }
                } else {
                    context.clone()
                }
            } else {
                context.clone()
            }
        } else {
            context.clone()
        };

        OverrideKey::new(&enhanced_context)
    }

    /// Save an override with the given key
    pub fn save_override(
        &self,
        key: OverrideKey,
        override_config: CommandOverride,
        context: &FunctionContext,
    ) -> Result<()> {
        let entry = OverrideEntry {
            key,
            override_config,
            metadata: OverrideMetadata {
                created_at: chrono::Utc::now(),
                modified_at: chrono::Utc::now(),
                file_path: context.file_path.clone(),
                function_name: context.function_name.clone(),
                original_line: Some(context.line_number),
                notes: None,
                validation_status: crate::ValidationStatus::Pending,
                last_execution_time: None,
                last_execution_success: None,
                failure_count: 0,
            },
        };

        self.storage.save(&entry)
    }

    /// Save an override with validation
    pub fn save_override_with_validation(
        &self,
        key: OverrideKey,
        override_config: CommandOverride,
        context: &FunctionContext,
        command: &str,
    ) -> Result<()> {
        // Create entry
        let entry = OverrideEntry {
            key,
            override_config: override_config.clone(),
            metadata: OverrideMetadata {
                created_at: chrono::Utc::now(),
                modified_at: chrono::Utc::now(),
                file_path: context.file_path.clone(),
                function_name: context.function_name.clone(),
                original_line: Some(context.line_number),
                notes: None,
                validation_status: crate::ValidationStatus::Pending,
                last_execution_time: None,
                last_execution_success: None,
                failure_count: 0,
            },
        };

        // Validate before saving
        self.storage.save_with_validation(&entry, |entry| {
            use crate::parser::OverrideParser;

            // Create parser with validation
            let parser = OverrideParser::new(command);

            // Convert CommandOverride to ParsedOverride for validation
            let mut parsed = crate::parser::ParsedOverride::new();

            // Convert env vars
            for (k, v) in &entry.override_config.env {
                parsed.env.insert(k.clone(), v.clone());
            }

            // Convert cargo options
            for opt in &entry.override_config.cargo_options {
                let parts: Vec<&str> = opt.splitn(2, ' ').collect();
                if parts.len() == 2 {
                    parsed.options.insert(
                        parts[0].to_string(),
                        crate::parser::OptionValue::Single(parts[1].to_string()),
                    );
                } else {
                    parsed
                        .options
                        .insert(opt.clone(), crate::parser::OptionValue::Flag(true));
                }
            }

            // Add args
            parsed.extra_args = entry.override_config.args.clone();

            // Validate
            parser.validate(&parsed)
        })
    }

    /// Resolve an override from context
    pub fn resolve_override(
        &mut self,
        context: &FunctionContext,
    ) -> Result<Option<CommandOverride>> {
        let mut resolver = OverrideResolver::new(OverrideStorage::new(&self.workspace_path)?)?;
        match resolver.resolve(context)? {
            Some((entry, _strategy)) => Ok(Some(entry.override_config)),
            None => Ok(None),
        }
    }

    /// Resolve an override using the existing storage (for tests)
    #[cfg(test)]
    pub fn resolve_override_with_storage(
        &mut self,
        context: &FunctionContext,
    ) -> Result<Option<CommandOverride>> {
        // For tests, directly check the storage instead of creating a new resolver
        let entries = self.storage.list_all()?;
        for entry in entries {
            if entry.metadata.file_path == context.file_path {
                if let Some(ref function_name) = context.function_name {
                    if entry.metadata.function_name.as_ref() == Some(function_name) {
                        return Ok(Some(entry.override_config));
                    }
                } else if entry.metadata.original_line == Some(context.line_number) {
                    return Ok(Some(entry.override_config));
                }
            }
        }
        Ok(None)
    }

    /// Resolve override with strategy information
    pub fn resolve_with_strategy(
        &mut self,
        context: &FunctionContext,
    ) -> Result<Option<(CommandOverride, ResolutionStrategy)>> {
        let mut resolver = OverrideResolver::new(OverrideStorage::new(&self.workspace_path)?)?;
        match resolver.resolve(context)? {
            Some((entry, strategy)) => Ok(Some((entry.override_config, strategy))),
            None => Ok(None),
        }
    }

    /// Create a preview of changes
    pub fn preview_override(&self, params: PreviewParams) -> Result<OverridePreview> {
        let key = OverrideKey::new(params.context)?;

        let entry = OverrideEntry {
            key,
            override_config: params.override_config.clone(),
            metadata: OverrideMetadata {
                created_at: chrono::Utc::now(),
                modified_at: chrono::Utc::now(),
                file_path: params.context.file_path.clone(),
                function_name: params.context.function_name.clone(),
                original_line: Some(params.context.line_number),
                notes: None,
                validation_status: ValidationStatus::Pending,
                failure_count: 0,
                last_execution_success: None,
                last_execution_time: None,
            },
        };

        OverridePreview::new(
            entry,
            params.base_command,
            params.base_env,
            params.base_cargo_options,
            params.base_rustc_options,
            params.base_args,
        )
    }

    /// List all overrides
    pub fn list_all(&self) -> Result<Vec<OverrideEntry>> {
        self.storage.list_all()
    }

    /// List overrides for a specific file
    pub fn list_by_file(&self, file_path: &Path) -> Result<Vec<OverrideEntry>> {
        self.storage.get_by_file(file_path)
    }

    /// Delete an override by key
    pub fn delete_override(&self, key: &str) -> Result<bool> {
        self.storage.delete(key)
    }

    /// Clear all overrides
    pub fn clear_all(&self) -> Result<()> {
        self.storage.clear()
    }

    /// Clear overrides for a specific file
    pub fn clear_by_file(&self, file_path: &Path) -> Result<usize> {
        self.storage.clear_by_file(file_path)
    }

    /// Export overrides for backup
    pub fn export(&self) -> Result<String> {
        self.storage.export()
    }

    /// Import overrides from backup
    pub fn import(&self, data: &str) -> Result<usize> {
        self.storage.import(data)
    }

    /// Debug: Get resolution candidates
    pub fn debug_resolution(
        &mut self,
        context: &FunctionContext,
    ) -> Result<Vec<(OverrideEntry, ResolutionStrategy, f32)>> {
        let mut resolver = OverrideResolver::new(OverrideStorage::new(&self.workspace_path)?)?;
        resolver.get_resolution_candidates(context)
    }

    /// Get function context from file position
    pub fn get_function_context(
        &mut self,
        file_path: &Path,
        line: usize,
        column: Option<usize>,
    ) -> Result<FunctionContext> {
        let source = std::fs::read_to_string(file_path)?;

        let function_name = self
            .detector
            .find_function_at_line(&source, line)?
            .map(|f| f.name);

        Ok(FunctionContext {
            file_path: file_path.to_path_buf(),
            function_name,
            line_number: line,
            context: column.map(|c| format!("column:{c}")),
        })
    }

    /// Update execution status of an override
    pub fn update_execution_status(&self, key: &str, success: bool) -> Result<()> {
        self.storage.update_execution_status(key, success)
    }

    /// Rollback to last backup
    pub fn rollback_to_last_backup(&self) -> Result<()> {
        self.storage.rollback_to_last_backup()
    }

    /// Get overrides that have failed multiple times
    pub fn get_problematic_overrides(&self, failure_threshold: u32) -> Result<Vec<OverrideEntry>> {
        let all_overrides = self.list_all()?;
        Ok(all_overrides
            .into_iter()
            .filter(|entry| entry.metadata.failure_count >= failure_threshold)
            .collect())
    }

    /// Check if an override should be auto-rolled back
    pub fn should_auto_rollback(&self, key: &str, threshold: u32) -> Result<bool> {
        if let Some(entry) = self.storage.get_by_primary_key(key)? {
            Ok(entry.metadata.failure_count >= threshold)
        } else {
            Ok(false)
        }
    }
}

/// Convenience function to create override system from current directory
pub fn create_override_system() -> Result<OverrideSystem> {
    let cwd = std::env::current_dir().map_err(|e| {
        OverrideError::StorageError(format!("Failed to get current directory: {e}"))
    })?;
    OverrideSystem::new(&cwd)
}

#[cfg(test)]
mod tests {
    use super::*;
    use tempfile::TempDir;

    #[test]
    fn test_override_system_workflow() {
        let temp_dir = TempDir::new().unwrap();
        let mut system = OverrideSystem::new_for_test(temp_dir.path()).unwrap();

        // Create context
        let context = FunctionContext {
            file_path: PathBuf::from("src/main.rs"),
            function_name: Some("handle_request".to_string()),
            line_number: 42,
            context: None,
        };

        // Generate key
        let key = system.generate_key(&context).unwrap();
        assert_eq!(key.primary, "src/main.rs:handle_request");

        // Save override
        let mut override_config = CommandOverride::new("test".to_string());
        override_config
            .env
            .insert("RUST_LOG".to_string(), "debug".to_string());

        system
            .save_override(key.clone(), override_config.clone(), &context)
            .unwrap();

        // Resolve override (use test method that works with test storage)
        let resolved = system.resolve_override_with_storage(&context).unwrap();
        assert!(resolved.is_some());

        let resolved_config = resolved.unwrap();
        assert_eq!(resolved_config.key, "test");
        assert_eq!(
            resolved_config.env.get("RUST_LOG"),
            Some(&"debug".to_string())
        );

        // List overrides
        let all_overrides = system.list_all().unwrap();
        assert_eq!(all_overrides.len(), 1);

        // Delete override
        assert!(system.delete_override(&key.primary).unwrap());

        // Verify deleted
        let resolved_after = system.resolve_override_with_storage(&context).unwrap();
        assert!(resolved_after.is_none());
    }

    #[test]
    fn test_function_detection_integration() {
        let temp_dir = TempDir::new().unwrap();
        let mut system = OverrideSystem::new_for_test(temp_dir.path()).unwrap();

        // Create a test file
        let test_file = temp_dir.path().join("test.rs");
        std::fs::write(
            &test_file,
            r#"
fn process_data(input: &str) -> String {
    input.to_uppercase()
}

fn main() {
    let result = process_data("hello");
    println!("{}", result);
}
"#,
        )
        .unwrap();

        // Get context for line inside process_data
        let context = system.get_function_context(&test_file, 2, None).unwrap();
        assert_eq!(context.function_name.as_deref(), Some("process_data"));

        // Get context for line inside main
        let context = system.get_function_context(&test_file, 6, None).unwrap();
        assert_eq!(context.function_name.as_deref(), Some("main"));
    }
}