raz-override 0.1.2

Override management system for raz with stable key generation
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
use crate::{CommandOverride, FunctionContext, OverrideError, OverrideSystem, Result};
use colored::*;
use indexmap::IndexMap;
use serde::{Deserialize, Serialize};
use std::path::{Path, PathBuf};

/// Legacy override format (cursor position-based)
#[derive(Debug, Clone, Serialize, Deserialize)]
struct LegacyOverride {
    #[serde(flatten)]
    config: CommandOverride,
}

/// Legacy storage format
#[derive(Debug, Clone, Serialize, Deserialize)]
struct LegacyStorageFormat {
    overrides: IndexMap<String, LegacyOverride>,
}

/// Migration report entry
#[derive(Debug, Clone)]
pub struct MigrationEntry {
    pub old_key: String,
    pub new_key: String,
    pub status: MigrationStatus,
    pub message: String,
}

#[derive(Debug, Clone, PartialEq)]
pub enum MigrationStatus {
    Success,
    Warning,
    Failed,
}

/// Migration report
#[derive(Debug)]
pub struct MigrationReport {
    pub entries: Vec<MigrationEntry>,
    pub total: usize,
    pub successful: usize,
    pub warnings: usize,
    pub failed: usize,
}

impl MigrationReport {
    fn new() -> Self {
        Self {
            entries: Vec::new(),
            total: 0,
            successful: 0,
            warnings: 0,
            failed: 0,
        }
    }

    fn add_entry(&mut self, entry: MigrationEntry) {
        match &entry.status {
            MigrationStatus::Success => self.successful += 1,
            MigrationStatus::Warning => self.warnings += 1,
            MigrationStatus::Failed => self.failed += 1,
        }
        self.entries.push(entry);
        self.total += 1;
    }

    pub fn print_summary(&self) {
        println!("{}", "Migration Report:".bold().blue());
        println!();
        println!("Total overrides: {}", self.total);
        println!("Successful: {}", self.successful.to_string().green());
        if self.warnings > 0 {
            println!("Warnings: {}", self.warnings.to_string().yellow());
        }
        if self.failed > 0 {
            println!("Failed: {}", self.failed.to_string().red());
        }
        println!();

        if !self.entries.is_empty() {
            println!("{}", "Details:".bold());
            for (idx, entry) in self.entries.iter().enumerate() {
                let status_symbol = match entry.status {
                    MigrationStatus::Success => "✓".green(),
                    MigrationStatus::Warning => "âš ".yellow(),
                    MigrationStatus::Failed => "✗".red(),
                };

                println!(
                    "{}. {} {} → {}",
                    idx + 1,
                    status_symbol,
                    entry.old_key.dimmed(),
                    entry.new_key
                );
                if !entry.message.is_empty() {
                    println!("   {}", entry.message.dimmed());
                }
            }
        }
    }
}

/// Override migrator for converting legacy overrides to new format
pub struct OverrideMigrator {
    system: OverrideSystem,
}

impl OverrideMigrator {
    /// Create a new migrator
    pub fn new(workspace_path: &Path) -> Result<Self> {
        let system = OverrideSystem::new(workspace_path)?;
        Ok(Self { system })
    }

    /// Parse legacy key format: "file:line:column" or "file:line"
    fn parse_legacy_key(key: &str) -> Result<(PathBuf, usize, Option<usize>)> {
        let parts: Vec<&str> = key.rsplitn(3, ':').collect();

        match parts.len() {
            3 => {
                // file:line:column
                let column = parts[0]
                    .parse::<usize>()
                    .map_err(|_| OverrideError::InvalidKey("Invalid column number".to_string()))?;
                let line = parts[1]
                    .parse::<usize>()
                    .map_err(|_| OverrideError::InvalidKey("Invalid line number".to_string()))?;
                let file_path = PathBuf::from(parts[2]);
                Ok((file_path, line, Some(column)))
            }
            2 => {
                // file:line or Windows path like C:\file
                if let Ok(line) = parts[0].parse::<usize>() {
                    let file_path = PathBuf::from(parts[1]);
                    Ok((file_path, line, None))
                } else {
                    Err(OverrideError::InvalidKey(format!(
                        "Invalid legacy key format: {key}"
                    )))
                }
            }
            _ => Err(OverrideError::InvalidKey(format!(
                "Invalid legacy key format: {key}"
            ))),
        }
    }

    /// Migrate a single legacy override
    fn migrate_single(
        &mut self,
        legacy_key: &str,
        legacy_override: &LegacyOverride,
    ) -> MigrationEntry {
        // Parse the legacy key
        let (file_path, line, column) = match Self::parse_legacy_key(legacy_key) {
            Ok(parsed) => parsed,
            Err(e) => {
                return MigrationEntry {
                    old_key: legacy_key.to_string(),
                    new_key: String::new(),
                    status: MigrationStatus::Failed,
                    message: format!("Failed to parse legacy key: {e}"),
                };
            }
        };

        // Try to get function context
        let context = match self.system.get_function_context(&file_path, line, column) {
            Ok(ctx) => ctx,
            Err(_) => {
                // Fallback to line-based key
                FunctionContext {
                    file_path: file_path.clone(),
                    function_name: None,
                    line_number: line,
                    context: column.map(|c| format!("column:{c}")),
                }
            }
        };

        // Generate new key
        let new_key = match self.system.generate_key(&context) {
            Ok(key) => key,
            Err(e) => {
                return MigrationEntry {
                    old_key: legacy_key.to_string(),
                    new_key: String::new(),
                    status: MigrationStatus::Failed,
                    message: format!("Failed to generate new key: {e}"),
                };
            }
        };

        // Check if function was detected successfully
        let had_function_detection_error = self
            .system
            .get_function_context(&file_path, line, column)
            .is_err();

        // Save the override with new key
        match self
            .system
            .save_override(new_key.clone(), legacy_override.config.clone(), &context)
        {
            Ok(_) => {
                let status = if had_function_detection_error {
                    MigrationStatus::Warning
                } else {
                    MigrationStatus::Success
                };

                let message = if context.function_name.is_some() {
                    "Migrated to function-based key".to_string()
                } else if had_function_detection_error {
                    "Could not detect function, migrated to line-based key".to_string()
                } else {
                    "Migrated to line-based key".to_string()
                };

                MigrationEntry {
                    old_key: legacy_key.to_string(),
                    new_key: new_key.primary,
                    status,
                    message,
                }
            }
            Err(e) => MigrationEntry {
                old_key: legacy_key.to_string(),
                new_key: new_key.primary,
                status: MigrationStatus::Failed,
                message: format!("Failed to save override: {e}"),
            },
        }
    }

    /// Migrate overrides from a legacy file
    pub fn migrate_from_file(&mut self, legacy_file: &Path) -> Result<MigrationReport> {
        if !legacy_file.exists() {
            return Err(OverrideError::MigrationError(format!(
                "Legacy file not found: {}",
                legacy_file.display()
            )));
        }

        let content = std::fs::read_to_string(legacy_file)?;
        self.migrate_from_string(&content)
    }

    /// Migrate overrides from a legacy string
    pub fn migrate_from_string(&mut self, content: &str) -> Result<MigrationReport> {
        let legacy_format: LegacyStorageFormat = toml::from_str(content).map_err(|e| {
            OverrideError::MigrationError(format!("Failed to parse legacy format: {e}"))
        })?;

        let mut report = MigrationReport::new();

        for (legacy_key, legacy_override) in &legacy_format.overrides {
            let entry = self.migrate_single(legacy_key, legacy_override);
            report.add_entry(entry);
        }

        Ok(report)
    }

    /// Auto-detect and migrate legacy overrides
    pub fn auto_migrate(&mut self, workspace_path: &Path) -> Result<Option<MigrationReport>> {
        let legacy_file = workspace_path.join(".raz").join("overrides.toml");

        if !legacy_file.exists() {
            return Ok(None);
        }

        // Check if it's already in new format
        let content = std::fs::read_to_string(&legacy_file)?;
        if content.contains("version") && content.contains("[[overrides]]") {
            // Already in new format
            return Ok(None);
        }

        // Backup the old file
        let backup_file = workspace_path.join(".raz").join("overrides.toml.backup");
        std::fs::copy(&legacy_file, &backup_file)?;

        println!(
            "{}",
            format!(
                "Found legacy overrides. Backing up to: {}",
                backup_file.display()
            )
            .yellow()
        );

        // Perform migration
        let report = self.migrate_from_file(&legacy_file)?;

        Ok(Some(report))
    }

    /// Dry run migration to preview changes
    pub fn dry_run(&mut self, legacy_file: &Path) -> Result<MigrationReport> {
        if !legacy_file.exists() {
            return Err(OverrideError::MigrationError(format!(
                "Legacy file not found: {}",
                legacy_file.display()
            )));
        }

        let content = std::fs::read_to_string(legacy_file)?;
        let legacy_format: LegacyStorageFormat = toml::from_str(&content).map_err(|e| {
            OverrideError::MigrationError(format!("Failed to parse legacy format: {e}"))
        })?;

        let mut report = MigrationReport::new();

        for (legacy_key, _) in &legacy_format.overrides {
            let (file_path, line, column) = match Self::parse_legacy_key(legacy_key) {
                Ok(parsed) => parsed,
                Err(e) => {
                    report.add_entry(MigrationEntry {
                        old_key: legacy_key.to_string(),
                        new_key: String::new(),
                        status: MigrationStatus::Failed,
                        message: format!("Failed to parse legacy key: {e}"),
                    });
                    continue;
                }
            };

            // Try to get function context
            let (new_key, status, message) =
                match self.system.get_function_context(&file_path, line, column) {
                    Ok(ctx) => match self.system.generate_key(&ctx) {
                        Ok(key) => {
                            let msg = if ctx.function_name.is_some() {
                                "Will migrate to function-based key".to_string()
                            } else {
                                "Will migrate to line-based key".to_string()
                            };
                            (key.primary, MigrationStatus::Success, msg)
                        }
                        Err(e) => (
                            String::new(),
                            MigrationStatus::Failed,
                            format!("Failed to generate key: {e}"),
                        ),
                    },
                    Err(e) => {
                        // Try fallback
                        let fallback_context = FunctionContext {
                            file_path: file_path.clone(),
                            function_name: None,
                            line_number: line,
                            context: column.map(|c| format!("column:{c}")),
                        };

                        match self.system.generate_key(&fallback_context) {
                            Ok(key) => (
                                key.primary,
                                MigrationStatus::Warning,
                                format!("Could not detect function ({e}), will use line-based key"),
                            ),
                            Err(e) => (
                                String::new(),
                                MigrationStatus::Failed,
                                format!("Failed to generate key: {e}"),
                            ),
                        }
                    }
                };

            report.add_entry(MigrationEntry {
                old_key: legacy_key.to_string(),
                new_key,
                status,
                message,
            });
        }

        Ok(report)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use tempfile::TempDir;

    #[test]
    fn test_parse_legacy_key() {
        // Test file:line:column format
        let (file, line, column) = OverrideMigrator::parse_legacy_key("src/main.rs:42:10").unwrap();
        assert_eq!(file, PathBuf::from("src/main.rs"));
        assert_eq!(line, 42);
        assert_eq!(column, Some(10));

        // Test file:line format
        let (file, line, column) = OverrideMigrator::parse_legacy_key("src/lib.rs:100").unwrap();
        assert_eq!(file, PathBuf::from("src/lib.rs"));
        assert_eq!(line, 100);
        assert_eq!(column, None);
    }

    #[test]
    fn test_migration_basic() {
        let temp_dir = TempDir::new().unwrap();
        let mut migrator = OverrideMigrator::new(temp_dir.path()).unwrap();

        // Create a test file
        let test_file = temp_dir.path().join("test.rs");
        std::fs::write(
            &test_file,
            r#"
fn process_data(input: &str) -> String {
    input.to_uppercase()
}

fn main() {
    let result = process_data("hello");
    println!("{}", result);
}
"#,
        )
        .unwrap();

        // Create legacy format
        let legacy_content = r#"
[overrides."test.rs:2:5"]
key = "test-override"
mode = "replace"
cargo_options = []
rustc_options = []
args = []
created_at = "2024-01-01T00:00:00Z"

[overrides."test.rs:2:5".env]
RUST_LOG = "debug"
"#;

        let report = migrator.migrate_from_string(legacy_content).unwrap();
        assert_eq!(report.total, 1);

        // Should have 1 warning (file doesn't exist so function detection fails)
        assert_eq!(report.warnings, 1);
        assert_eq!(report.failed, 0);

        // Verify the new key - should be line-based since function detection failed
        let entry = &report.entries[0];
        assert_eq!(entry.old_key, "test.rs:2:5");
        assert!(entry.new_key.contains("test.rs:L2"));
    }
}