rash_core 2.20.0

Declarative shell scripting using Rust native bindings
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
mod handler;
mod new;
mod valid;

pub use handler::{Handlers, PendingHandlers, parse_notify_value};

use crate::context::{BecomeMethod, GlobalParams};
use crate::error::{Error, ErrorKind, Result};
use crate::jinja::{
    is_render_string, merge_option, render, render_force_string, render_map, render_string,
};
use crate::job::{JobStatus, get_job_info, register_job};
use crate::logger::is_json_output;
use crate::modules::{Module, ModuleResult};
use crate::task::new::TaskNew;

use rash_derive::FieldNames;

use std::collections::HashMap;
use std::env;
use std::fs::{self, File};
use std::io::Write;
use std::path::PathBuf;
use std::process::{Command as StdCommand, Output, Stdio, exit};
use std::result::Result as StdResult;
use std::thread;
use std::time::Duration;

use ipc_channel::ipc::{self, IpcReceiver, IpcSender};
use minijinja::{Value, context};
use nix::sys::wait::{WaitStatus, waitpid};
use nix::unistd::{ForkResult, Uid, User, fork, setgid, setuid};
use serde::{Deserialize, Serialize};
use serde_error::Error as SerdeError;
use serde_norway::Value as YamlValue;

#[derive(Debug, Clone, Default, Serialize, Deserialize)]
pub struct TaskExecResult {
    changed: bool,
    vars: Option<Value>,
    flush_handlers: bool,
}

#[derive(Debug, Clone, Serialize)]
struct JsonResult {
    changed: bool,
    output: Option<String>,
    extra: Option<serde_json::Value>,
}

impl JsonResult {
    fn new(changed: bool, output: Option<String>, extra: Option<YamlValue>) -> Self {
        Self {
            changed,
            output,
            extra: extra.and_then(|v| serde_json::to_value(v).ok()),
        }
    }
}

impl TaskExecResult {
    pub fn new(changed: bool, vars: Option<Value>) -> Self {
        TaskExecResult {
            changed,
            vars,
            flush_handlers: false,
        }
    }

    pub fn with_flush_handlers(mut self) -> Self {
        self.flush_handlers = true;
        self
    }

    pub fn get_changed(&self) -> bool {
        self.changed
    }

    pub fn get_vars(&self) -> Option<&Value> {
        self.vars.as_ref()
    }

    pub fn take_vars(self) -> Option<Value> {
        self.vars
    }

    pub fn is_flush_handlers(&self) -> bool {
        self.flush_handlers
    }
}

/// Internal task serialization for sudo become method.
/// This structure is used to pass task data to a child rash process.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct InternalTaskData {
    /// Original script path for rash.path builtin
    pub original_path: Option<String>,
    /// Original script args for rash.args builtin
    pub args: Option<Vec<String>>,
    /// Accumulated variables from parent execution
    pub vars: Value,
    /// The task to execute
    pub task: YamlValue,
}

/// Environment variable name for internal task file path
pub const RASH_INTERNAL_TASK_ENV: &str = "RASH_INTERNAL_TASK_FILE";

/// Environment variable name for result file path
pub const RASH_INTERNAL_RESULT_ENV: &str = "RASH_INTERNAL_RESULT_FILE";

/// Environment variable name for output format
pub const RASH_INTERNAL_OUTPUT_ENV: &str = "RASH_INTERNAL_OUTPUT";

/// Environment variable name to indicate internal task (suppresses task header)
pub const RASH_INTERNAL_TASK_FLAG: &str = "RASH_INTERNAL";

/// Check if we're running as an internal task execution (for sudo become)
pub fn is_internal_task_execution() -> Option<PathBuf> {
    env::var(RASH_INTERNAL_TASK_ENV).ok().map(PathBuf::from)
}

/// Get the result file path for internal task execution
pub fn get_internal_result_path() -> Option<PathBuf> {
    env::var(RASH_INTERNAL_RESULT_ENV).ok().map(PathBuf::from)
}

/// Get the output format for internal task execution
pub fn get_internal_output() -> Option<String> {
    env::var(RASH_INTERNAL_OUTPUT_ENV).ok()
}

/// Check if this is an internal task execution (should suppress task headers)
pub fn is_internal_execution() -> bool {
    env::var(RASH_INTERNAL_TASK_FLAG).is_ok()
}

fn log_module_result(changed: bool, result: &ModuleResult) {
    if is_json_output() {
        let json_result = JsonResult::new(changed, result.get_output(), result.get_extra());
        match serde_json::to_string(&json_result) {
            Ok(json_str) => {
                let target = if changed { "changed" } else { "ok" };
                info!(target: target, "{}", json_str);
            }
            Err(e) => {
                error!("Failed to serialize JSON result: {}", e);
            }
        }
    } else {
        let output = result.get_output();
        let target = match changed {
            true => "changed",
            false => "ok",
        };
        let target_empty = &format!("{}{}", target, if output.is_none() { "_empty" } else { "" });
        info!(target: target_empty,
            "{}",
            output.unwrap_or_else(|| "".to_owned())
        );
    }
}

/// Main structure at definition level which prepares [`Module`] executions.
///
/// It implements a state machine using Rust Generics to enforce well done definitions.
/// Inspired by [Kanidm Entries](https://fy.blackhats.net.au/blog/html/2019/04/13/using_rust_generics_to_enforce_db_record_state.html).
///
/// [`Module`]: ../modules/trait.Module.html
#[derive(Debug, Clone, FieldNames)]
// ANCHOR: task
pub struct Task<'a> {
    /// Run operations with become (does not imply password prompting).
    r#become: bool,
    /// Run operations as this user (just works with become enabled).
    become_user: String,
    /// Privilege escalation method: syscall or sudo.
    become_method: BecomeMethod,
    /// Path to sudo executable (used when become_method is sudo).
    become_exe: String,
    /// Password for privilege escalation (used when become_method is sudo).
    become_password: Option<String>,
    /// Run task in dry-run mode without modifications.
    check_mode: bool,
    /// Module could be any [`Module`] accessible by its name.
    ///
    /// [`Module`]: ../modules/trait.Module.html
    module: &'static dyn Module,
    /// Params are module execution params passed to [`Module::exec`].
    ///
    /// [`Module::exec`]: ../modules/trait.Module.html#method.exec
    params: YamlValue,
    /// Template expression passed directly without {{ }};
    /// Overwrite changed field in [`ModuleResult`].
    ///
    /// [`ModuleResult`]: ../modules/struct.ModuleResult.html
    changed_when: Option<String>,
    /// Template expression passed directly without {{ }}; if true errors are ignored.
    ignore_errors: Option<bool>,
    /// Task name.
    name: Option<String>,
    /// `loop` receives a Template (with {{ }}) or a list to iterate over it.
    r#loop: Option<YamlValue>,
    /// Variable name to store [`ModuleResult`].
    ///
    /// [`ModuleResult`]: ../modules/struct.ModuleResult.html
    register: Option<String>,
    /// Variables definition with task scope.
    vars: Option<YamlValue>,
    /// Template expression passed directly without {{ }}; if false skip task execution.
    when: Option<String>,
    /// Rescue tasks to execute if the main task or block fails.
    rescue: Option<YamlValue>,
    /// Always tasks to execute regardless of success or failure.
    always: Option<YamlValue>,
    /// Environment variables to inject for this task.
    environment: Option<YamlValue>,
    /// Handler names to notify when this task reports changed.
    notify: Option<Vec<String>>,
    /// Number of retries before giving up. Default is 3 when `until` is specified.
    retries: Option<u32>,
    /// Delay between retries in seconds. Default is 0.
    delay: Option<u64>,
    /// Template expression passed directly without {{ }}; repeat task until this is true.
    until: Option<String>,
    /// Maximum runtime in seconds for async execution. If set, task runs in background.
    r#async: Option<u64>,
    /// Poll interval in seconds for async task status. 0 = fire and forget.
    poll: Option<u64>,
    /// Global parameters.
    global_params: &'a GlobalParams<'a>,
}
// ANCHOR_END: task

/// A lists of [`Task`]
///
/// [`Task`]: struct.Task.html
pub type Tasks<'a> = Vec<Task<'a>>;

impl<'a> Task<'a> {
    /// Create a new Task from [`Value`].
    /// Enforcing all key values are valid using TaskNew and TaskValid internal states.
    ///
    /// All final values must be convertible to String and all keys must contain one module and
    /// [`Task`] fields.
    ///
    /// [`Task`]: struct.Task.html
    /// [`Value`]: ../../serde_norway/enum.Value.html
    pub fn new(yaml: &YamlValue, global_params: &'a GlobalParams) -> Result<Self> {
        trace!("new task: {yaml:?}");
        TaskNew::from(yaml)
            .validate_attrs()?
            .get_task(global_params)
    }

    #[inline(always)]
    fn is_attr(attr: &str) -> bool {
        Self::get_field_names().contains(attr)
    }

    #[inline(always)]
    fn extend_vars(&self, additional_vars: Value) -> Result<Value> {
        match self.vars.clone() {
            Some(v) => {
                trace!("extend vars: {:?}", &v);
                let rendered_value = match render(v.clone(), &additional_vars) {
                    Ok(v) => Value::from_serialize(v),
                    Err(e) if e.kind() == ErrorKind::OmitParam => context! {},
                    Err(e) => return Err(e),
                };
                Ok(context! { ..rendered_value, ..additional_vars})
            }
            None => Ok(additional_vars),
        }
    }

    fn render_params(&self, vars: Value) -> Result<YamlValue> {
        let extended_vars = self.extend_vars(vars)?;

        let original_params = self.params.clone();
        match original_params {
            YamlValue::Mapping(x) => render_map(
                x.clone(),
                &extended_vars,
                self.module.force_string_on_params(),
            ),
            YamlValue::String(s) => Ok(YamlValue::String(render_string(&s, &extended_vars)?)),
            YamlValue::Null => Ok(YamlValue::Mapping(serde_norway::Mapping::new())),
            YamlValue::Sequence(_) => {
                // For sequence parameters (like block tasks), pass through without string rendering
                if self.module.get_name() == "block" {
                    Ok(original_params)
                } else {
                    Err(Error::new(
                        ErrorKind::InvalidData,
                        format!("{original_params:?} must be a mapping or a string"),
                    ))
                }
            }
            _ => Err(Error::new(
                ErrorKind::InvalidData,
                format!("{original_params:?} must be a mapping or a string"),
            )),
        }
    }

    fn render_environment(&self, vars: &Value) -> Result<Vec<(String, String)>> {
        trace!("environment: {:?}", &self.environment);
        match &self.environment {
            Some(env_yaml) => {
                let extended_vars = self.extend_vars(vars.clone())?;
                match env_yaml.as_mapping() {
                    Some(mapping) => {
                        let mut env_vars = Vec::new();
                        for (key, value) in mapping.iter() {
                            let key_str = key.as_str().ok_or_else(|| {
                                Error::new(
                                    ErrorKind::InvalidData,
                                    format!("Environment key must be a string: {key:?}"),
                                )
                            })?;
                            let rendered_value = match value.as_str() {
                                Some(s) => render_string(s, &extended_vars)?,
                                None => {
                                    // For non-string values, convert to string
                                    serde_json::to_string(value)
                                        .map_err(|e| Error::new(ErrorKind::InvalidData, e))?
                                }
                            };
                            env_vars.push((key_str.to_owned(), rendered_value));
                        }
                        Ok(env_vars)
                    }
                    None => Err(Error::new(
                        ErrorKind::InvalidData,
                        "environment must be a mapping",
                    )),
                }
            }
            None => Ok(Vec::new()),
        }
    }

    fn is_exec(&self, vars: &Value) -> Result<bool> {
        trace!("when: {:?}", &self.when);
        match &self.when {
            Some(s) => {
                let extended_vars = self.extend_vars(vars.clone())?;
                is_render_string(s, &extended_vars)
            }
            None => Ok(true),
        }
    }

    fn get_iterator(value: &YamlValue, vars: Value) -> Result<Vec<YamlValue>> {
        match value.as_sequence() {
            Some(v) => Ok(v
                .iter()
                .filter_map(|item| match render_force_string(item.clone(), &vars) {
                    Ok(rendered) => Some(Ok(rendered)),
                    Err(e) if e.kind() == ErrorKind::OmitParam => None,
                    Err(e) => Some(Err(e)),
                })
                .collect::<Result<Vec<YamlValue>>>()?),
            None => Err(Error::new(ErrorKind::NotFound, "loop is not iterable")),
        }
    }

    fn render_iterator(&self, vars: Value) -> Result<Vec<YamlValue>> {
        // safe unwrap, previous verification self.r#loop.is_some()
        let loop_some = self.r#loop.clone().unwrap();

        let extended_vars = self.extend_vars(context! {item => "",..vars})?;
        match loop_some.as_str() {
            Some(s) => {
                let value: YamlValue = serde_norway::from_str(&render_string(s, &extended_vars)?)?;
                match value.as_str() {
                    Some(_) => Ok(vec![value]),
                    None => Task::get_iterator(&value, extended_vars),
                }
            }
            None => Task::get_iterator(&loop_some, extended_vars),
        }
    }

    fn is_changed(&self, result: &ModuleResult, vars: &Value) -> Result<bool> {
        trace!("changed_when: {:?}", &self.changed_when);
        match &self.changed_when {
            Some(s) => is_render_string(s, vars),
            None => Ok(result.get_changed()),
        }
    }

    fn is_until_satisfied(&self, vars: &Value) -> Result<bool> {
        trace!("until: {:?}", &self.until);
        match &self.until {
            Some(s) => is_render_string(s, vars),
            None => Ok(true),
        }
    }

    fn exec_with_retry(&self, vars: Value) -> Result<TaskExecResult> {
        let max_retries = self.retries.unwrap_or(3);
        let delay_secs = self.delay.unwrap_or(0);

        for attempt in 0..=max_retries {
            let result = self.exec_module(vars.clone())?;

            if self.until.is_some() {
                let result_vars = result.clone().take_vars().unwrap_or(context! {});
                let check_vars =
                    context! {..vars.clone(), ..result_vars, ..context! {retries => attempt}};

                if self.is_until_satisfied(&check_vars)? {
                    debug!("until condition satisfied on attempt {}", attempt);
                    return Ok(result);
                }

                if attempt < max_retries {
                    debug!(
                        "until condition not satisfied on attempt {}, retrying in {} seconds",
                        attempt, delay_secs
                    );
                    if delay_secs > 0 {
                        std::thread::sleep(std::time::Duration::from_secs(delay_secs));
                    }
                } else {
                    warn!(
                        "until condition not satisfied after {} retries",
                        max_retries
                    );
                    return Err(Error::new(
                        ErrorKind::Other,
                        format!(
                            "Task failed: until condition not satisfied after {} retries",
                            max_retries
                        ),
                    ));
                }
            } else {
                return Ok(result);
            }
        }

        Ok(TaskExecResult::new(false, None))
    }

    fn is_async(&self) -> bool {
        self.r#async.is_some()
    }

    fn get_async_timeout(&self) -> Option<Duration> {
        self.r#async.map(Duration::from_secs)
    }

    fn get_poll_interval(&self) -> u64 {
        self.poll.unwrap_or(0)
    }

    fn spawn_async_command(&self, rendered_params: &YamlValue, vars: &Value) -> Result<u64> {
        let extended_vars = self.extend_vars(vars.clone())?;
        let env_vars = self.render_environment(&extended_vars)?;

        let module_name = self.module.get_name();
        if module_name != "command" && module_name != "shell" {
            return Err(Error::new(
                ErrorKind::InvalidData,
                format!(
                    "Async execution only supported for command/shell modules, got: {module_name}"
                ),
            ));
        }

        let cmd_str = match rendered_params.as_str() {
            Some(s) => s.to_owned(),
            None => match rendered_params.get("cmd") {
                Some(cmd) => cmd
                    .as_str()
                    .ok_or_else(|| Error::new(ErrorKind::InvalidData, "cmd must be a string"))?
                    .to_owned(),
                None => return Err(Error::new(ErrorKind::InvalidData, "No command specified")),
            },
        };

        let chdir = rendered_params.get("chdir").and_then(|d| d.as_str());

        let mut cmd = StdCommand::new("/bin/sh");
        cmd.arg("-c").arg(&cmd_str);
        if let Some(dir) = chdir {
            cmd.current_dir(dir);
        }
        cmd.stdout(Stdio::piped()).stderr(Stdio::piped());

        for (key, value) in &env_vars {
            cmd.env(key, value);
        }

        let child = cmd.spawn().map_err(|e| {
            Error::new(
                ErrorKind::SubprocessFail,
                format!("Failed to spawn async command: {e}"),
            )
        })?;

        let job_id = register_job(self.get_async_timeout(), child);

        info!(target: "async",
            "Started async job {} with timeout {:?}",
            job_id,
            self.get_async_timeout()
        );

        Ok(job_id)
    }

    fn poll_job(&self, job_id: u64, poll_interval: u64) -> Result<TaskExecResult> {
        let sleep_duration = Duration::from_secs(poll_interval);

        loop {
            let info = get_job_info(job_id).ok_or_else(|| {
                Error::new(ErrorKind::NotFound, format!("Job {job_id} not found"))
            })?;

            match info.status {
                JobStatus::Finished => {
                    let result = ModuleResult::new(info.changed, None, info.output.clone());
                    let register_vars = self.register.clone().map(|register| {
                        [(register.clone(), Value::from_serialize(&result))]
                            .into_iter()
                            .collect::<Value>()
                    });
                    return Ok(TaskExecResult::new(info.changed, register_vars));
                }
                JobStatus::Failed => {
                    return Err(Error::new(
                        ErrorKind::SubprocessFail,
                        format!(
                            "Async job {job_id} failed: {}",
                            info.error.unwrap_or_default()
                        ),
                    ));
                }
                JobStatus::Running | JobStatus::Pending => {
                    trace!(
                        "Job {} still running ({}s elapsed), sleeping for {}s",
                        job_id,
                        info.elapsed.as_secs(),
                        poll_interval
                    );
                    thread::sleep(sleep_duration);
                }
            }
        }
    }

    fn exec_module_rendered_with_user(
        &self,
        rendered_params: &YamlValue,
        vars: &Value,
        user: User,
    ) -> Result<TaskExecResult> {
        // Environment variables need to be set before changing user
        let extended_vars = self.extend_vars(vars.clone())?;
        let env_vars = self.render_environment(&extended_vars)?;

        for (key, value) in &env_vars {
            trace!(
                "setting environment variable (with user): {}={}",
                key, value
            );
            // SAFETY: We're setting environment variables for task execution.
            // This is safe as long as no other threads are modifying env vars concurrently.
            unsafe {
                env::set_var(key, value);
            }
        }

        match setgid(user.gid) {
            Ok(_) => match setuid(user.uid) {
                Ok(_) => {
                    // After changing user, call the inner module exec directly
                    let module_name = self.module.get_name();

                    let result = self.module.exec(
                        self.global_params,
                        rendered_params.clone(),
                        &extended_vars,
                        self.check_mode,
                    );

                    match result {
                        Ok((result, result_vars)) => {
                            let changed = self.is_changed(&result, &extended_vars)?;

                            if module_name != "include"
                                && module_name != "block"
                                && module_name != "meta"
                            {
                                log_module_result(changed, &result);
                            }

                            let register_vars = self.register.clone().map(|register| {
                                trace!("register {:?} in {:?}", &result, register);
                                [(register, Value::from_serialize(&result))]
                                    .into_iter()
                                    .collect::<Value>()
                            });

                            let new_vars_value = [result_vars, register_vars]
                                .into_iter()
                                .fold(context! {}, merge_option);
                            let new_vars = if new_vars_value == context! {} {
                                None
                            } else {
                                Some(new_vars_value)
                            };

                            Ok(TaskExecResult::new(changed, new_vars))
                        }
                        Err(e) => match self.ignore_errors {
                            Some(is_true) if is_true => {
                                info!(target: "ignoring", "{e}");
                                Ok(TaskExecResult::new(false, None))
                            }
                            _ => Err(e),
                        },
                    }
                }
                Err(_) => Err(Error::new(
                    ErrorKind::Other,
                    format!("uid cannot be changed to {}", user.uid),
                )),
            },
            Err(_) => Err(Error::new(
                ErrorKind::Other,
                format!("gid cannot be changed to {}", user.gid),
            )),
        }
    }

    fn exec_module_via_sudo(
        &self,
        rendered_params: &YamlValue,
        vars: &Value,
    ) -> Result<TaskExecResult> {
        let temp_dir = std::env::temp_dir();
        let task_file = temp_dir.join(format!("rash_task_{}.yaml", uuid::Uuid::new_v4()));
        let result_file = temp_dir.join(format!("rash_result_{}.json", uuid::Uuid::new_v4()));

        let internal_data = InternalTaskData {
            original_path: vars
                .get_attr("rash")
                .ok()
                .and_then(|r| r.get_attr("path").ok())
                .and_then(|p| p.as_str().map(String::from)),
            args: None,
            vars: vars.clone(),
            task: serde_norway::to_value(serde_json::json!({
                "name": self.name,
                self.module.get_name(): rendered_params,
            }))
            .map_err(|e| Error::new(ErrorKind::Other, e))?,
        };

        let task_content =
            serde_yaml::to_string(&internal_data).map_err(|e| Error::new(ErrorKind::Other, e))?;

        let mut file = File::create(&task_file).map_err(|e| {
            Error::new(
                ErrorKind::Other,
                format!("Failed to create task file: {}", e),
            )
        })?;
        file.write_all(task_content.as_bytes())
            .map_err(|e| Error::new(ErrorKind::Other, e))?;

        let rash_path = std::env::current_exe().map_err(|e| {
            Error::new(
                ErrorKind::Other,
                format!("Failed to get current exe path: {}", e),
            )
        })?;

        let output = if let Some(ref password) = self.become_password {
            // With password: use -S flag and write password to stdin
            trace!(
                "exec_module_via_sudo: RASH_INTERNAL_OUTPUT_ENV = {:?}",
                env::var(RASH_INTERNAL_OUTPUT_ENV)
            );
            let mut child = StdCommand::new(&self.become_exe)
                .arg("-H")
                .arg("-S")
                .arg("-E")
                .arg("-u")
                .arg(&self.become_user)
                .arg("--")
                .arg(&rash_path)
                .arg("--internal-task")
                .arg(&task_file)
                .env(RASH_INTERNAL_RESULT_ENV, &result_file)
                .env(RASH_INTERNAL_TASK_FLAG, "1")
                .stdin(Stdio::piped())
                .stdout(Stdio::inherit())
                .stderr(Stdio::piped())
                .spawn()
                .map_err(|e| {
                    Error::new(
                        ErrorKind::SubprocessFail,
                        format!("Failed to spawn {}: {}", self.become_exe, e),
                    )
                })?;

            // Write password to stdin
            if let Some(mut stdin) = child.stdin.take() {
                use std::io::Write as IoWrite;
                stdin
                    .write_all(format!("{}\n", password).as_bytes())
                    .map_err(|e| {
                        Error::new(ErrorKind::Other, format!("Failed to write password: {}", e))
                    })?;
            }

            let output = child.wait_with_output().map_err(|e| {
                Error::new(
                    ErrorKind::SubprocessFail,
                    format!("Failed to wait for {}: {}", self.become_exe, e),
                )
            })?;
            Output {
                status: output.status,
                stdout: Vec::new(),
                stderr: output.stderr,
            }
        } else {
            // Without password: simple execution with inherited stdout/stderr
            trace!(
                "exec_module_via_sudo: RASH_INTERNAL_OUTPUT_ENV = {:?}",
                env::var(RASH_INTERNAL_OUTPUT_ENV)
            );
            let status = StdCommand::new(&self.become_exe)
                .arg("-H")
                .arg("-E")
                .arg("-u")
                .arg(&self.become_user)
                .arg("--")
                .arg(&rash_path)
                .arg("--internal-task")
                .arg(&task_file)
                .env(RASH_INTERNAL_RESULT_ENV, &result_file)
                .env(RASH_INTERNAL_TASK_FLAG, "1")
                .status()
                .map_err(|e| {
                    Error::new(
                        ErrorKind::SubprocessFail,
                        format!("Failed to execute {}: {}", self.become_exe, e),
                    )
                })?;
            Output {
                status,
                stdout: Vec::new(),
                stderr: Vec::new(),
            }
        };

        // Cleanup temp files
        let _ = fs::remove_file(&task_file);

        if !output.status.success() {
            let _ = fs::remove_file(&result_file);
            let stderr = String::from_utf8_lossy(&output.stderr);
            return Err(Error::new(
                ErrorKind::SubprocessFail,
                format!(
                    "{} failed with exit code {}: {}",
                    self.become_exe,
                    output.status.code().unwrap_or(-1),
                    stderr
                ),
            ));
        }

        let result_content = fs::read_to_string(&result_file).map_err(|e| {
            Error::new(
                ErrorKind::Other,
                format!("Failed to read result file: {}", e),
            )
        })?;
        let _ = fs::remove_file(&result_file);

        let result: TaskExecResult = serde_json::from_str(&result_content).map_err(|e| {
            Error::new(
                ErrorKind::Other,
                format!("Failed to parse result JSON: {}", e),
            )
        })?;

        Ok(result)
    }

    fn exec_module_rendered(
        &self,
        rendered_params: &YamlValue,
        vars: &Value,
    ) -> Result<TaskExecResult> {
        let module_name = self.module.get_name();
        let extended_vars = self.extend_vars(vars.clone())?;

        // Render and set environment variables
        let env_vars = self.render_environment(&extended_vars)?;
        let mut original_env: HashMap<String, Option<String>> = HashMap::new();

        for (key, value) in &env_vars {
            trace!("setting environment variable: {}={}", key, value);
            // Save original value (if it exists)
            original_env.insert(key.clone(), env::var(key).ok());
            // Set new value
            // SAFETY: We're setting environment variables for task execution.
            // This is safe as long as no other threads are modifying env vars concurrently.
            unsafe {
                env::set_var(key, value);
            }
        }

        let result = self.module.exec(
            self.global_params,
            rendered_params.clone(),
            &extended_vars,
            self.check_mode,
        );

        // Restore original environment
        for (key, original_value) in original_env {
            // SAFETY: Restoring environment variables to their original state.
            unsafe {
                match original_value {
                    Some(value) => env::set_var(&key, value),
                    None => env::remove_var(&key),
                }
            }
        }

        match result {
            Ok((result, result_vars)) => {
                let changed = self.is_changed(&result, &extended_vars)?;
                let is_meta_flush = module_name == "meta"
                    && result
                        .get_extra()
                        .and_then(|v| v.as_str().map(|s| s.to_string()))
                        == Some("flush_handlers".to_string());

                // Don't show output for control flow modules like include and block
                if module_name != "include" && module_name != "block" && module_name != "meta" {
                    log_module_result(changed, &result);
                }

                let register_vars = self.register.clone().map(|register| {
                    trace!("register {:?} in {:?}", &result, register);
                    [(register, Value::from_serialize(&result))]
                        .into_iter()
                        .collect::<Value>()
                });

                let new_vars_value = [result_vars, register_vars]
                    .into_iter()
                    .fold(context! {}, merge_option);
                let new_vars = if new_vars_value == context! {} {
                    None
                } else {
                    Some(new_vars_value)
                };

                let mut exec_result = TaskExecResult::new(changed, new_vars);
                if is_meta_flush {
                    exec_result = exec_result.with_flush_handlers();
                }
                Ok(exec_result)
            }
            Err(e) => match self.ignore_errors {
                Some(is_true) if is_true => {
                    info!(target: "ignoring", "{e}");
                    Ok(TaskExecResult::new(false, None))
                }
                _ => Err(e),
            },
        }
    }

    fn exec_module(&self, vars: Value) -> Result<TaskExecResult> {
        if self.is_exec(&vars)? {
            let rendered_params = self.render_params(vars.clone())?;

            // Handle async execution
            if self.is_async() {
                let job_id = self.spawn_async_command(&rendered_params, &vars)?;
                let poll_interval = self.get_poll_interval();

                if poll_interval == 0 {
                    // Fire and forget - return immediately with async job info
                    let result =
                        ModuleResult::new(true, None, Some(format!("async job started: {job_id}")));
                    let register_vars = self.register.clone().map(|register| {
                        [(register, Value::from_serialize(&result))]
                            .into_iter()
                            .collect::<Value>()
                    });
                    return Ok(TaskExecResult::new(true, register_vars));
                }

                // Poll for completion
                let poll_result = self.poll_job(job_id, poll_interval);
                return match poll_result {
                    Ok(exec_result) => Ok(exec_result),
                    Err(e) => match self.ignore_errors {
                        Some(true) => {
                            info!(target: "ignoring", "{e}");
                            Ok(TaskExecResult::new(false, None))
                        }
                        _ => Err(e),
                    },
                };
            }

            match self.r#become && !self.check_mode {
                true => {
                    // Handle sudo method separately
                    if self.become_method == BecomeMethod::Sudo {
                        return self.exec_module_via_sudo(&rendered_params, &vars);
                    }

                    // Syscall method (default)
                    let user_not_found_error = || {
                        Error::new(
                            ErrorKind::Other,
                            format!("User {:?} not found.", self.become_user),
                        )
                    };
                    let user = match User::from_name(&self.become_user)
                        .map_err(|_| user_not_found_error())?
                    {
                        Some(user) => Ok(user),
                        None => match self.become_user.parse::<u32>().map(Uid::from_raw) {
                            Ok(uid) => match User::from_uid(uid)? {
                                Some(user) => Ok(user),
                                None => Err(user_not_found_error()),
                            },
                            Err(_) => Err(user_not_found_error()),
                        },
                    }?;

                    if user.uid != Uid::current() {
                        if self.module.get_name() == "command"
                            && rendered_params["transfer_pid"].as_bool().unwrap_or(false)
                        {
                            return self.exec_module_rendered_with_user(
                                &rendered_params,
                                &vars,
                                user,
                            );
                        }

                        // Type is complex but precise - needed for IPC channel with serialized results
                        #[allow(clippy::type_complexity)]
                        let (tx, rx): (
                            IpcSender<StdResult<String, SerdeError>>,
                            IpcReceiver<StdResult<String, SerdeError>>,
                        ) = ipc::channel().map_err(|e| Error::new(ErrorKind::Other, e))?;

                        match unsafe { fork() } {
                            Ok(ForkResult::Child) => {
                                trace!("change uid to: {}", user.uid);
                                trace!("change gid to: {}", user.gid);
                                let result = self.exec_module_rendered_with_user(
                                    &rendered_params,
                                    &vars,
                                    user,
                                );

                                trace!("send result: {result:?}");
                                tx.send(
                                    result
                                        .map(|v| serde_json::to_string(&v))?
                                        .map_err(|e| SerdeError::new(&e)),
                                )
                                .unwrap_or_else(|e| {
                                    error!("child failed to send result: {e}");
                                    exit(1)
                                });
                                exit(0);
                            }
                            Ok(ForkResult::Parent { child, .. }) => {
                                match waitpid(child, None) {
                                    Ok(WaitStatus::Exited(_, 0)) => Ok(()),
                                    Ok(WaitStatus::Exited(_, exit_code)) => Err(Error::new(
                                        ErrorKind::SubprocessFail,
                                        format!("child failed with exit_code {exit_code}"),
                                    )),
                                    Err(e) => Err(Error::new(ErrorKind::Other, e)),
                                    _ => Err(Error::new(
                                        ErrorKind::SubprocessFail,
                                        format!("child {child} unknown status"),
                                    )),
                                }?;
                                trace!("receive result");
                                rx.recv()
                                    .map_err(|e| Error::new(ErrorKind::Other, format!("{e:?}")))
                                    .and_then(|result| {
                                        result.map_err(|e| {
                                            Error::new(ErrorKind::Other, format!("{e:?}"))
                                        })
                                    })
                                    .and_then(|s| {
                                        serde_json::from_str::<TaskExecResult>(&s)
                                            .map_err(|e| Error::new(ErrorKind::Other, e))
                                    })
                            }
                            Err(e) => Err(Error::new(ErrorKind::Other, e)),
                        }
                    } else {
                        self.exec_module_rendered(&rendered_params, &vars)
                    }
                }
                false => self.exec_module_rendered(&rendered_params, &vars),
            }
        } else {
            debug!("skipping");
            Ok(TaskExecResult::new(false, None))
        }
    }

    /// Execute [`Module`] rendering `self.params` with [`Vars`].
    ///
    /// [`Module`]: ../modules/trait.Module.html
    /// [`Vars`]: ../vars/struct.Vars.html
    pub fn exec(&self, vars: Value) -> Result<TaskExecResult> {
        debug!("Module: {}", self.module.get_name());
        debug!("Params: {:?}", self.params);

        if self.rescue.is_some() || self.always.is_some() {
            return self.exec_with_rescue_always(vars);
        }

        self.exec_main_task(vars)
    }

    /// Return name.
    pub fn get_name(&self) -> Option<String> {
        self.name.clone()
    }

    /// Return name rendered with [`Vars`].
    ///
    /// [`Vars`]: ../vars/struct.Vars.html
    pub fn get_rendered_name(&self, vars: Value) -> Result<String> {
        render_string(
            &self
                .name
                .clone()
                .ok_or_else(|| Error::new(ErrorKind::NotFound, "no name found"))?,
            &vars,
        )
    }

    /// Return [`Module`].
    ///
    /// [`Module`]: ../modules/trait.Module.html
    pub fn get_module(&self) -> &dyn Module {
        self.module
    }

    /// Return notify handlers.
    pub fn get_notify(&self) -> Option<&[String]> {
        self.notify.as_deref()
    }

    /// Execute a task with comprehensive rescue and always handling.
    ///
    /// This method implements a try-catch-finally pattern similar to exception handling:
    /// - Try: Execute the main task (any module type)
    /// - Catch: If task fails, execute rescue tasks (if defined)
    /// - Finally: Always execute always tasks (if defined)
    ///
    /// The method uses functional programming patterns to handle each stage
    /// and provides detailed error context for debugging.
    fn exec_with_rescue_always(&self, vars: Value) -> Result<TaskExecResult> {
        let initial_vars = vars;

        // Stage 1: Execute main task and capture result
        let (main_result, main_exec_result) = match self.exec_main_task(initial_vars.clone()) {
            Ok(exec_result) => {
                trace!("Main task execution succeeded");
                (Ok(()), exec_result)
            }
            Err(task_error) => {
                warn!("Main task execution failed: {task_error}");
                (Err(task_error), TaskExecResult::new(false, None))
            }
        };

        let main_changed = main_exec_result.get_changed();
        let main_vars = main_exec_result.take_vars();
        let post_main_vars = merge_option(initial_vars, main_vars.clone());
        let (rescue_result, rescue_exec_result) = match (&main_result, &self.rescue) {
            (Err(_), Some(rescue_tasks)) => {
                info!("Executing rescue tasks due to main task failure");
                match self.execute_task_sequence(rescue_tasks, post_main_vars.clone()) {
                    Ok(rescue_result) => {
                        info!("Rescue tasks executed successfully");
                        (Ok(()), rescue_result)
                    }
                    Err(rescue_error) => {
                        error!("Rescue tasks failed: {rescue_error}");
                        (Err(rescue_error), TaskExecResult::new(false, None))
                    }
                }
            }
            (Err(_), None) => {
                trace!("Main task failed but no rescue tasks defined");
                (Ok(()), TaskExecResult::new(main_changed, main_vars.clone())) // No rescue available, but continue to always
            }
            (Ok(_), _) => {
                trace!("Main task succeeded, skipping rescue tasks");
                (Ok(()), TaskExecResult::new(main_changed, main_vars.clone())) // Task succeeded, no rescue needed
            }
        };

        let rescue_changed = rescue_exec_result.get_changed();
        let rescue_vars_taken = rescue_exec_result.take_vars();
        let post_rescue_vars = merge_option(post_main_vars, rescue_vars_taken.clone());
        let always_exec_result = match &self.always {
            Some(always_tasks) => {
                trace!("Executing always tasks");
                match self.execute_task_sequence(always_tasks, post_rescue_vars) {
                    Ok(always_result) => {
                        trace!("Always tasks executed successfully");
                        always_result
                    }
                    Err(always_error) => {
                        error!("Always tasks failed: {always_error}");
                        // Always tasks failing is critical - propagate the error
                        return Err(Error::new(
                            ErrorKind::Other,
                            format!("Always section failed: {always_error}"),
                        ));
                    }
                }
            }
            None => {
                trace!("No always tasks to execute");
                TaskExecResult::new(false, None)
            }
        };

        let always_vars = always_exec_result.take_vars();
        let all_vars_value = [main_vars, rescue_vars_taken, always_vars]
            .into_iter()
            .fold(context! {}, merge_option);
        let all_vars = if all_vars_value == context! {} {
            None
        } else {
            Some(all_vars_value)
        };

        // Stage 4: Determine final result based on execution stages
        match (&main_result, &rescue_result) {
            (Ok(_), Ok(_)) => Ok(TaskExecResult::new(main_changed, all_vars)),
            (Ok(_), Err(_)) => {
                warn!("Unexpected state: main task succeeded but rescue reported failure");
                Ok(TaskExecResult::new(main_changed, all_vars))
            }
            (Err(_main_error), Ok(_)) => {
                debug!("Task execution recovered through rescue tasks");
                Ok(TaskExecResult::new(rescue_changed, all_vars))
            }
            (Err(main_error), Err(_)) => {
                if self.rescue.is_some() {
                    Err(Error::new(
                        ErrorKind::Other,
                        format!(
                            "Task execution failed and rescue tasks could not recover: {main_error}"
                        ),
                    ))
                } else {
                    Err(Error::new(
                        ErrorKind::Other,
                        format!("Task execution failed with no rescue defined: {main_error}"),
                    ))
                }
            }
        }
    }

    /// Execute a sequence of tasks defined in YAML format.
    ///
    /// This is a helper method that provides consistent task sequence execution
    /// for rescue and always sections. It includes proper error handling and
    /// variable propagation.
    fn execute_task_sequence(&self, tasks_yaml: &YamlValue, vars: Value) -> Result<TaskExecResult> {
        match tasks_yaml {
            YamlValue::Sequence(tasks) => {
                if tasks.is_empty() {
                    warn!("Empty task sequence provided");
                    return Ok(TaskExecResult::new(false, None));
                }

                let mut current_vars = vars;
                let mut current_new_vars = context! {};
                let mut any_changed = false;
                for (index, task_yaml) in tasks.iter().enumerate() {
                    match Task::new(task_yaml, self.global_params) {
                        Ok(task) => {
                            info!(target: "task",
                                "[{}:{}] - ",
                                current_vars.get_attr("rash")?.get_attr("path")?,
                                task.get_rendered_name(current_vars.clone())
                                    .unwrap_or_else(|_| task.get_module().get_name().to_owned()),
                            );
                            match task.exec(current_vars.clone()) {
                                Ok(exec_result) => {
                                    if exec_result.get_changed() {
                                        any_changed = true;
                                    }
                                    if let Some(new_vars) = exec_result.take_vars() {
                                        current_vars =
                                            context! {..current_vars, ..new_vars.clone()};
                                        current_new_vars =
                                            context! {..current_new_vars, ..new_vars.clone()};
                                    }
                                    trace!("Task {index} in sequence completed successfully");
                                }
                                Err(task_error) => {
                                    error!("Task {index} in sequence failed: {task_error}");
                                    return Err(Error::new(
                                        ErrorKind::Other,
                                        format!(
                                            "Task sequence failed at index {index}: {task_error}"
                                        ),
                                    ));
                                }
                            }
                        }
                        Err(parse_error) => {
                            error!("Failed to parse task {index} in sequence: {parse_error}");
                            return Err(Error::new(
                                ErrorKind::InvalidData,
                                format!("Invalid task at index {index}: {parse_error}"),
                            ));
                        }
                    }
                }
                let final_vars = if current_new_vars == context! {} {
                    None
                } else {
                    Some(current_new_vars)
                };
                Ok(TaskExecResult::new(any_changed, final_vars))
            }
            _ => Err(Error::new(
                ErrorKind::InvalidData,
                format!("Task sequence must be a YAML array, got: {tasks_yaml:?}"),
            )),
        }
    }

    /// Execute rescue tasks - this is now just an alias for consistency.
    #[deprecated(note = "Use execute_task_sequence instead for better error handling")]
    #[allow(dead_code)]
    fn execute_rescue_tasks(
        &self,
        rescue_tasks: &YamlValue,
        vars: Value,
    ) -> Result<TaskExecResult> {
        self.execute_task_sequence(rescue_tasks, vars)
    }

    /// Execute always tasks - this is now just an alias for consistency.
    #[deprecated(note = "Use execute_task_sequence instead for better error handling")]
    #[allow(dead_code)]
    fn execute_always_tasks(
        &self,
        always_tasks: &YamlValue,
        vars: Value,
    ) -> Result<TaskExecResult> {
        self.execute_task_sequence(always_tasks, vars)
    }

    /// Execute a task list - this is now just an alias for consistency.
    #[deprecated(note = "Use execute_task_sequence instead for better error handling")]
    #[allow(dead_code)]
    fn execute_task_list(&self, tasks_yaml: &YamlValue, vars: Value) -> Result<TaskExecResult> {
        self.execute_task_sequence(tasks_yaml, vars)
    }

    /// Execute the main task with proper loop handling.
    ///
    /// This method handles both single task execution and looped task execution,
    /// providing the foundation for rescue/always error handling patterns.
    /// When async is enabled, tasks run in background and can be polled.
    fn exec_main_task(&self, vars: Value) -> Result<TaskExecResult> {
        if self.r#loop.is_some() && self.is_async() {
            self.exec_parallel_loop(vars)
        } else if self.r#loop.is_some() && self.until.is_some() {
            self.exec_loop_with_retry(vars)
        } else if self.r#loop.is_some() {
            self.exec_sequential_loop(vars)
        } else if self.is_async() {
            self.exec_async_single(vars)
        } else if self.until.is_some() {
            self.exec_with_retry(vars)
        } else {
            self.exec_module(vars)
        }
    }

    fn exec_sequential_loop(&self, vars: Value) -> Result<TaskExecResult> {
        let mut changed = false;
        let mut all_new_vars = context! {};
        let mut flush_handlers = false;

        for item in self.render_iterator(vars.clone())?.into_iter() {
            let ctx = context! {item => &item, ..vars.clone()};
            trace!("pre execute loop: {:?}", &ctx);
            let exec_result = self.exec_module(ctx)?;
            if exec_result.get_changed() {
                changed = true;
            }
            if exec_result.is_flush_handlers() {
                flush_handlers = true;
            }
            if let Some(v) = exec_result.take_vars() {
                all_new_vars = context! {..all_new_vars, ..v};
            }
            trace!("post execute loop: {:?}", &all_new_vars);
        }

        let final_vars = if all_new_vars == context! {} {
            None
        } else {
            Some(all_new_vars)
        };

        let mut result = TaskExecResult::new(changed, final_vars);
        if flush_handlers {
            result = result.with_flush_handlers();
        }
        Ok(result)
    }

    fn exec_loop_with_retry(&self, vars: Value) -> Result<TaskExecResult> {
        let mut changed = false;
        let mut all_new_vars = context! {};
        let mut flush_handlers = false;

        for item in self.render_iterator(vars.clone())?.into_iter() {
            let ctx = context! {item => &item, ..vars.clone()};
            trace!("pre execute loop with retry: {:?}", &ctx);
            let exec_result = self.exec_with_retry(ctx)?;
            if exec_result.get_changed() {
                changed = true;
            }
            if exec_result.is_flush_handlers() {
                flush_handlers = true;
            }
            if let Some(v) = exec_result.take_vars() {
                all_new_vars = context! {..all_new_vars, ..v};
            }
            trace!("post execute loop with retry: {:?}", &all_new_vars);
        }

        let final_vars = if all_new_vars == context! {} {
            None
        } else {
            Some(all_new_vars)
        };

        let mut result = TaskExecResult::new(changed, final_vars);
        if flush_handlers {
            result = result.with_flush_handlers();
        }
        Ok(result)
    }

    fn exec_parallel_loop(&self, vars: Value) -> Result<TaskExecResult> {
        let items = self.render_iterator(vars.clone())?;
        let poll_interval = self.get_poll_interval();

        let mut job_ids: Vec<(u64, YamlValue)> = Vec::new();

        for item in items.into_iter() {
            let ctx = context! {item => &item, ..vars.clone()};
            let rendered_params = self.render_params(ctx.clone())?;

            if self.is_exec(&ctx)? {
                let job_id = self.spawn_async_command(&rendered_params, &ctx)?;
                job_ids.push((job_id, item));
            }
        }

        if poll_interval == 0 {
            let mut results = Vec::new();
            for (job_id, _item) in &job_ids {
                results.push(*job_id);
            }
            let job_ids_value: Vec<Value> = results.iter().map(|id| Value::from(*id)).collect();
            let register_vars = self.register.clone().map(|register| {
                [(
                    register.clone(),
                    Value::from_serialize(serde_json::json!({
                        "rash_job_ids": job_ids_value,
                        "changed": true,
                    })),
                )]
                .into_iter()
                .collect::<Value>()
            });
            return Ok(TaskExecResult::new(true, register_vars));
        }

        let sleep_duration = Duration::from_secs(poll_interval);
        let mut completed = vec![false; job_ids.len()];
        let mut outputs = vec![None; job_ids.len()];
        let mut errors = vec![None; job_ids.len()];
        let mut changed = vec![false; job_ids.len()];

        while !completed.iter().all(|&c| c) {
            for (idx, (job_id, _)) in job_ids.iter().enumerate() {
                if completed[idx] {
                    continue;
                }
                if let Some(info) = get_job_info(*job_id) {
                    match info.status {
                        JobStatus::Finished => {
                            completed[idx] = true;
                            outputs[idx] = info.output;
                            changed[idx] = info.changed;
                        }
                        JobStatus::Failed => {
                            completed[idx] = true;
                            errors[idx] = info.error;
                        }
                        JobStatus::Running | JobStatus::Pending => {}
                    }
                }
            }
            if !completed.iter().all(|&c| c) {
                thread::sleep(sleep_duration);
            }
        }

        let has_failures = errors.iter().any(|e| e.is_some());
        if has_failures {
            let error_msg = format!(
                "Async job(s) failed: {:?}",
                errors.iter().filter_map(|e| e.clone()).collect::<Vec<_>>()
            );
            match self.ignore_errors {
                Some(true) => {
                    info!(target: "ignoring", "{}", error_msg);
                }
                _ => {
                    return Err(Error::new(ErrorKind::SubprocessFail, error_msg));
                }
            }
        }

        let any_changed = changed.iter().any(|&c| c);
        let job_ids_value: Vec<Value> = job_ids.iter().map(|(id, _)| Value::from(*id)).collect();

        let register_vars = self.register.clone().map(|register| {
            [(
                register.clone(),
                Value::from_serialize(serde_json::json!({
                    "rash_job_ids": job_ids_value,
                    "changed": any_changed,
                })),
            )]
            .into_iter()
            .collect::<Value>()
        });

        Ok(TaskExecResult::new(any_changed, register_vars))
    }

    fn exec_async_single(&self, vars: Value) -> Result<TaskExecResult> {
        let rendered_params = self.render_params(vars.clone())?;
        let poll_interval = self.get_poll_interval();

        let job_id = self.spawn_async_command(&rendered_params, &vars)?;

        if poll_interval == 0 {
            let register_vars = self.register.clone().map(|register| {
                [(
                    register.clone(),
                    Value::from_serialize(serde_json::json!({
                        "rash_job_id": job_id,
                        "changed": true,
                    })),
                )]
                .into_iter()
                .collect::<Value>()
            });
            return Ok(TaskExecResult::new(true, register_vars));
        }

        let poll_result = self.poll_job(job_id, poll_interval);
        match poll_result {
            Ok(exec_result) => Ok(exec_result),
            Err(e) => match self.ignore_errors {
                Some(true) => {
                    info!(target: "ignoring", "{e}");
                    Ok(TaskExecResult::new(false, None))
                }
                _ => Err(e),
            },
        }
    }
}

#[cfg(test)]
use crate::context::GLOBAL_PARAMS;

#[cfg(test)]
impl From<YamlValue> for Task<'_> {
    fn from(value: YamlValue) -> Self {
        TaskNew::from(&value)
            .validate_attrs()
            .unwrap()
            .get_task(&GLOBAL_PARAMS)
            .unwrap()
    }
}

/// Parse a YAML file returning Tasks.
///
/// Works with files that contain only a task list (no handlers section).
pub fn parse_file<'a>(
    file_content: &str,
    global_params: &'a GlobalParams<'a>,
) -> Result<Tasks<'a>> {
    let yaml: YamlValue = serde_norway::from_str(file_content)?;

    match yaml {
        YamlValue::Sequence(tasks_yaml) => {
            trace!("Parsing {} tasks from file", tasks_yaml.len());
            tasks_yaml
                .iter()
                .map(|task_yaml| Task::new(task_yaml, global_params))
                .collect::<Result<Tasks>>()
        }
        _ => Err(Error::new(
            ErrorKind::InvalidData,
            format!("Expected a YAML sequence of tasks, got: {yaml:?}"),
        )),
    }
}

/// Parsed result containing tasks and optional handlers.
#[derive(Debug)]
pub struct ParsedFile<'a> {
    pub tasks: Tasks<'a>,
    pub handlers: Option<Handlers<'a>>,
}

/// Parse a YAML file that may contain tasks and handlers sections.
///
/// This function supports files with the following structure:
/// ```yaml
/// tasks:
///   - name: First task
///     ...
/// handlers:
///   - name: Handler name
///     ...
/// ```
pub fn parse_file_with_handlers<'a>(
    file_content: &str,
    global_params: &'a GlobalParams,
) -> Result<ParsedFile<'a>> {
    let yaml: YamlValue = serde_norway::from_str(file_content)?;

    match yaml {
        YamlValue::Mapping(ref mapping) => {
            let tasks_yaml = mapping.get(YamlValue::String("tasks".to_string()));
            let handlers_yaml = mapping.get(YamlValue::String("handlers".to_string()));

            let tasks = match tasks_yaml {
                Some(YamlValue::Sequence(tasks_seq)) => tasks_seq
                    .iter()
                    .map(|task_yaml| Task::new(task_yaml, global_params))
                    .collect::<Result<Tasks>>()?,
                Some(_) => {
                    return Err(Error::new(
                        ErrorKind::InvalidData,
                        "tasks must be a YAML sequence".to_string(),
                    ));
                }
                None => {
                    return Err(Error::new(
                        ErrorKind::InvalidData,
                        "No tasks section found in file".to_string(),
                    ));
                }
            };

            let handlers = match handlers_yaml {
                Some(YamlValue::Sequence(handlers_seq)) => {
                    Some(Handlers::from_yaml(handlers_seq, global_params)?)
                }
                Some(_) => {
                    return Err(Error::new(
                        ErrorKind::InvalidData,
                        "handlers must be a YAML sequence".to_string(),
                    ));
                }
                None => None,
            };

            Ok(ParsedFile { tasks, handlers })
        }
        _ => Err(Error::new(
            ErrorKind::InvalidData,
            format!("Expected a YAML mapping with tasks (and optional handlers), got: {yaml:?}"),
        )),
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use minijinja::context;
    use std::sync::LazyLock;

    pub static GLOBAL_PARAMS: LazyLock<GlobalParams> = LazyLock::new(GlobalParams::default);

    #[test]
    fn test_from_yaml() {
        let s: String = r#"
            name: 'Test task'
            command: 'example'
            "#
        .to_owned();
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);

        assert_eq!(task.name.unwrap(), "Test task");
        assert_eq!(&task.module.get_name(), &"command");
    }

    #[test]
    fn test_from_yaml_no_module() {
        let s = r#"
            name: 'Test task'
            no_module: 'example'
            "#
        .to_owned();
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task_err = Task::new(&yaml, &GlobalParams::default()).unwrap_err();
        assert_eq!(task_err.kind(), ErrorKind::InvalidData);
    }

    #[test]
    fn test_from_yaml_invalid_attr() {
        let s = r#"
            name: 'Test task'
            command: 'example'
            invalid_attr: 'foo'
            "#
        .to_owned();
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task_err = Task::new(&yaml, &GlobalParams::default()).unwrap_err();
        assert_eq!(task_err.kind(), ErrorKind::InvalidData);
    }

    #[test]
    fn test_is_exec() {
        let s: String = r#"
            when: "boo == 'test'"
            command: 'example'
            "#
        .to_owned();
        let vars = context! { boo => "test"};
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);
        assert!(task.is_exec(&vars).unwrap());
    }

    #[test]
    fn test_is_exec_parsed_bool() {
        let s: String = r#"
            when: "boo | bool"
            command: 'example'
            "#
        .to_owned();
        let vars = context! { boo => "" };
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);
        assert!(!task.is_exec(&vars).unwrap());
    }

    #[test]
    fn test_is_exec_false() {
        let s: String = r#"
            when: "boo != 'test'"
            command: 'example'
            "#
        .to_owned();
        let vars = context! { boo => "test"};
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);
        assert!(!task.is_exec(&vars).unwrap());
    }

    #[test]
    fn test_is_exec_bool_false() {
        let s: String = r#"
            when: false
            command: 'example'
            "#
        .to_owned();
        let vars = context! {};
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);
        assert!(!task.is_exec(&vars).unwrap());
    }

    #[test]
    fn test_is_exec_array() {
        let s: String = r#"
            when:
              - true
              - "boo == 'test'"
            command: 'example'
            "#
        .to_owned();
        let vars = context! { boo => "test"};
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);
        assert!(task.is_exec(&vars).unwrap());
    }

    #[test]
    fn test_is_exec_array_one_false() {
        let s: String = r#"
            when:
              - false
              - "boo == 'test'"
            command: 'example'
            "#
        .to_owned();
        let vars = context! { boo => "test"};
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);
        assert!(!task.is_exec(&vars).unwrap());

        let s: String = r#"
            command: 'example'
            when:
              - true
              - false
              - true
            "#
        .to_owned();
        let vars = context! {};
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);
        assert!(!task.is_exec(&vars).unwrap());

        let s: String = r#"
            command: 'example'
            when:
              - true
              - true
              - true
            "#
        .to_owned();
        let vars = context! {};
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);
        assert!(task.is_exec(&vars).unwrap());

        let s: String = r#"
            command: 'example'
            when:
              - true or true or true
              - false
              - true
            "#
        .to_owned();
        let vars = context! {};
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);
        assert!(!task.is_exec(&vars).unwrap());
    }

    #[test]
    fn test_is_exec_array_with_or_operator() {
        let s: String = r#"
            command: 'example'
            when:
              - true
              - boo == 'test' or false
            "#
        .to_owned();
        let vars = context! { boo => "test"};
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);
        assert!(task.is_exec(&vars).unwrap());
    }

    #[test]
    fn test_render_iterator() {
        let s: String = r#"
            command: 'example'
            loop:
              - 1
              - 2
              - 3
            "#
        .to_owned();
        let yaml: YamlValue = serde_norway::from_str(&s).unwrap();
        let task = Task::from(yaml);
        let vars = context! {};
        let iterator = task.render_iterator(vars).unwrap();
        assert_eq!(iterator.len(), 3);
    }

    #[test]
    fn test_task_new() {
        let yaml_str = r#"
        name: test task
        debug:
          msg: "hello"
        "#;
        let yaml: YamlValue = serde_norway::from_str(yaml_str).unwrap();
        let task = Task::new(&yaml, &GLOBAL_PARAMS).unwrap();
        assert_eq!(task.name, Some("test task".to_string()));
    }

    #[test]
    fn test_parse_file() {
        let file_content = r#"
        - name: task 1
          debug:
            msg: "first"
        - name: task 2
          debug:
            msg: "second"
        "#;
        let tasks = parse_file(file_content, &GLOBAL_PARAMS).unwrap();
        assert_eq!(tasks.len(), 2);
    }

    #[test]
    fn test_parse_file_with_handlers() {
        let file_content = r#"
        tasks:
          - name: task 1
            debug:
              msg: "first"
            notify: handler1
        handlers:
          - name: handler1
            debug:
              msg: "handler"
        "#;
        let parsed = parse_file_with_handlers(file_content, &GLOBAL_PARAMS).unwrap();
        assert_eq!(parsed.tasks.len(), 1);
        assert!(parsed.handlers.is_some());
        let handlers = parsed.handlers.unwrap();
        assert!(handlers.get("handler1").is_some());
    }

    #[test]
    fn test_notify_parsing() {
        let yaml_str = r#"
        name: test notify
        debug:
          msg: "hello"
        notify: my_handler
        "#;
        let yaml: YamlValue = serde_norway::from_str(yaml_str).unwrap();
        let task = Task::new(&yaml, &GLOBAL_PARAMS).unwrap();
        assert_eq!(task.notify, Some(vec!["my_handler".to_string()]));
    }

    #[test]
    fn test_notify_list_parsing() {
        let yaml_str = r#"
        name: test notify list
        debug:
          msg: "hello"
        notify:
          - handler1
          - handler2
        "#;
        let yaml: YamlValue = serde_norway::from_str(yaml_str).unwrap();
        let task = Task::new(&yaml, &GLOBAL_PARAMS).unwrap();
        assert_eq!(
            task.notify,
            Some(vec!["handler1".to_string(), "handler2".to_string()])
        );
    }

    #[test]
    fn test_check_mode_skips_become() {
        let global_params = GlobalParams {
            r#become: true,
            become_user: "root",
            become_method: BecomeMethod::default(),
            become_exe: "sudo",
            become_password: None,
            check_mode: true,
        };
        let yaml_str = r#"
        name: test check mode with become
        command: whoami
        "#;
        let yaml: YamlValue = serde_norway::from_str(yaml_str).unwrap();
        let task = Task::new(&yaml, &global_params).unwrap();
        assert!(task.r#become);
        assert!(task.check_mode);

        let result = task.exec(context! {}).unwrap();
        assert!(result.get_changed());
    }
}