rapx 0.7.31

A static analysis platform for Rust program analysis and verification
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65

use annotate_snippets::Level;

use crate::{
    analysis::dataflow::*,
    check::opt::OptCheck,
};
use rustc_middle::{mir::Local, ty::TyCtxt};
use rustc_span::Span;

use crate::check::opt::report::OptReport;
use crate::check::opt::check_utils::node_matches_any_call;

crate::def_paths! {
    hashset_new: "std::collections::HashSet::new",
    hashset_with_capacity: "std::collections::HashSet::with_capacity",
    hashmap_new: "std::collections::HashMap::new",
    hashmap_with_capacity: "std::collections::HashMap::with_capacity",
    btreeset_new: "std::collections::BTreeSet::new",
    btreemap_new: "std::collections::BTreeMap::new",
}

pub struct LocalSetCheck {
    record: Vec<Span>,
}

impl OptCheck for LocalSetCheck {
    fn new() -> Self {
        Self { record: Vec::new() }
    }

    fn check(&mut self, graph: &Graph, tcx: &TyCtxt) {
        let def_paths = &DEFPATHS.get_or_init(|| DefPaths::new(tcx));
        for (node_idx, node) in graph.nodes.iter_enumerated() {
            if node_matches_any_call(node, |id| {
                id == def_paths.hashset_new.last_def_id()
                    || id == def_paths.hashmap_new.last_def_id()
                    || id == def_paths.btreemap_new.last_def_id()
                    || id == def_paths.btreeset_new.last_def_id()
                    || id == def_paths.hashmap_with_capacity.last_def_id()
                    || id == def_paths.hashset_with_capacity.last_def_id()
            }) && !graph.is_connected(Local::from_usize(0), node_idx) {
                self.record.push(node.span);
            }
        }
    }

    fn report(&self, graph: &Graph) {
        for span in self.record.iter() {
            report_local_set(graph, *span);
        }
    }

    fn cnt(&self) -> usize {
        self.record.len()
    }
}

fn report_local_set(graph: &Graph, span: Span) {
    OptReport::from_graph(graph)
        .file_name(span)
        .title("Unnecessary data collection initialization detected")
        .annotate(Level::Error, span, "Initialization happens here")
        .footer("Move it into parameter list and use hash table to save allocation.")
        .emit();
}