rama-http 0.4.0

rama http layers, services and other utilities
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
//! HTTP Upgrades.
//!
//! This module deals with managing [HTTP Upgrades][mdn] in rama_http_core. Since
//! several concepts in HTTP allow for first talking HTTP, and then converting
//! to a different protocol, this module conflates them into a single API.
//! Those include:
//!
//! - HTTP/1.1 Upgrades
//! - HTTP `CONNECT`
//!
//! You are responsible for any other pre-requisites to establish an upgrade,
//! such as sending the appropriate headers, methods, and status codes. You can
//! then use [`handle_upgrade`] to grab a `Future` which will resolve to the upgraded
//! connection object, or an error if the upgrade fails.
//!
//! [mdn]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Protocol_upgrade_mechanism
//!
//! # Client
//!
//! Sending an HTTP upgrade from the client involves setting
//! either the appropriate method, if wanting to `CONNECT`, or headers such as
//! `Upgrade` and `Connection`, on the `http::Request`. Once receiving the
//! `http::Response` back, you must check for the specific information that the
//! upgrade is agreed upon by the server (such as a `101` status code), and then
//! get the `Future` from the `Response`.
//!
//! # Server
//!
//! Receiving upgrade requests in a server requires you to check the relevant
//! headers in a `Request`, and if an upgrade should be done, you then send the
//! corresponding headers in a response. To then wait for rama_http_core to finish the
//! upgrade, you call `on()` with the `Request`, and then can spawn a task
//! awaiting it.

use rama_core::error::BoxErrorExt as _;
use std::any::TypeId;
use std::fmt;
use std::io;
use std::pin::Pin;
use std::sync::Arc;
use std::task::{Context, Poll};

use parking_lot::Mutex;
use tokio::io::{AsyncRead, AsyncWrite, ReadBuf};
use tokio::sync::oneshot;

use rama_core::bytes::Bytes;
use rama_core::error::BoxError;
use rama_core::extensions::Extension;
use rama_core::extensions::Extensions;
use rama_core::extensions::ExtensionsRef;
use rama_core::io::Io;
use rama_core::io::rewind::Rewind;
use rama_core::telemetry::tracing::trace;
use rama_net::extensions::StreamTransformed;
use rama_utils::macros::generate_set_and_with;

/// An upgraded HTTP connection.
///
/// This type holds a trait object internally of the original IO that
/// was used to speak HTTP before the upgrade. It can be used directly
/// as a [`AsyncRead`] or [`AsyncWrite`] for convenience.
///
/// Alternatively, if the exact type is known, this can be deconstructed
/// into its parts.
pub struct Upgraded {
    io: Rewind<Box<dyn UpgradeIo>>,
    extensions: Extensions,
    _guards: Vec<OpaqueGuard>,
}

struct OpaqueGuard {
    _guard: Box<dyn Send + 'static>,
}

impl fmt::Debug for OpaqueGuard {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("OpaqueGuard").finish_non_exhaustive()
    }
}

/// A future for a possible HTTP upgrade.
///
/// If no upgrade was available, or it doesn't succeed, yields an `Error`.
#[derive(Clone, Extension)]
#[extension(tags(http))]
pub struct OnUpgrade {
    rx: Arc<Mutex<oneshot::Receiver<Result<Upgraded, BoxError>>>>,
}

/// The deconstructed parts of an [`Upgraded`] type.
///
/// Includes the original IO type, and a read buffer of bytes that the
/// HTTP state machine may have already read before completing an upgrade.
#[derive(Debug)]
#[non_exhaustive]
pub struct Parts<T> {
    /// The original IO object used before the upgrade.
    pub io: T,
    /// A buffer of bytes that have been read but not processed as HTTP.
    ///
    /// For instance, if the `Connection` is used for an HTTP upgrade request,
    /// it is possible the server sent back the first bytes of the new protocol
    /// along with the response upgrade.
    ///
    /// You will want to check for any existing bytes if you plan to continue
    /// communicating on the IO object.
    pub read_buf: Bytes,
    /// Extensions associated with this upgrade
    pub extensions: Extensions,
    /// Opaque resources whose lifetime is bound to the upgraded transport.
    _guards: Vec<OpaqueGuard>,
}

/// Gets a pending HTTP upgrade from this message and handles it.
///
/// This can be called on types implementing [`ExtensionsRef`]:
///
/// Some notable examples are:
/// - `http::Request<B>`
/// - `http::Response<B>`
/// - `&rama_http::Request<B>`
/// - `&rama_http::Response<B>`
pub fn handle_upgrade<T: ExtensionsRef>(
    msg: T,
) -> impl Future<Output = Result<Upgraded, BoxError>> + 'static {
    let msg_ext = msg.extensions().clone();
    let on_upgrade = match msg_ext.get_ref::<OnUpgrade>().cloned() {
        Some(on_upgrade) => {
            trace!("upgrading this: {:?}", on_upgrade);
            if on_upgrade.has_handled_upgrade() {
                Err(BoxError::from_static_str(
                    "upgraded has already been handled",
                ))
            } else {
                Ok(on_upgrade)
            }
        }
        None => Err(BoxError::from_static_str("no pending update found")),
    };

    async move {
        let upgraded = match on_upgrade {
            Ok(on_upgrade) => on_upgrade.await?,
            Err(err) => return Err(err),
        };
        Ok(upgraded)
    }
}

/// A pending upgrade, created with [`pending`].
pub struct Pending {
    tx: oneshot::Sender<Result<Upgraded, BoxError>>,
}

/// Initiate an upgrade.
#[must_use]
pub fn pending() -> (Pending, OnUpgrade) {
    let (tx, rx) = oneshot::channel();

    (
        Pending { tx },
        OnUpgrade {
            rx: Arc::new(Mutex::new(rx)),
        },
    )
}

// ===== impl Upgraded =====

impl Upgraded {
    /// Create a new [`Upgraded`] from an IO stream and existing buffer.
    ///
    /// The [`Upgraded`] starts with the io [`Extensions`]s. Message extensions
    /// are not copied by [`handle_upgrade`]: they can contain structural
    /// `Ingress` / `Egress` links back to this same io. A protocol-specific
    /// upgrade handler can explicitly transfer the typed message extensions it
    /// needs.
    pub fn new<T>(io: T, read_buf: Bytes) -> Self
    where
        T: Io + Unpin + ExtensionsRef,
    {
        let extensions = io.extensions().clone();
        extensions.insert(StreamTransformed {
            by: "rama-http::Upgraded",
        });
        Self {
            extensions,
            io: Rewind::new_buffered(Box::new(io), read_buf),
            _guards: Vec::new(),
        }
    }

    generate_set_and_with! {
        pub fn extensions(mut self, extensions: Extensions) -> Self {
            self.extensions = extensions;
            self
        }
    }

    /// Bind an opaque resource to the lifetime of this upgraded transport.
    ///
    /// The resource is retained when the transport is downcast into [`Parts`]
    /// and is released when the upgraded transport, or those parts, are
    /// dropped. This is useful for leases that must remain active for as long
    /// as the upgraded protocol is using the underlying connection.
    #[must_use]
    pub fn with_guard<G>(mut self, guard: G) -> Self
    where
        G: Send + 'static,
    {
        self._guards.push(OpaqueGuard {
            _guard: Box::new(guard),
        });
        self
    }

    /// Tries to downcast the internal trait object to the type passed.
    ///
    /// On success, returns the downcasted parts.
    ///
    /// # Errors
    ///
    /// On error, returns the `Upgraded` back.
    pub fn downcast<T: Io + Unpin>(self) -> Result<Parts<T>, Self> {
        let Self {
            io,
            extensions,
            _guards: guards,
        } = self;
        let (io, buf) = io.into_inner();
        match io.__downcast() {
            Ok(t) => Ok(Parts {
                io: *t,
                read_buf: buf,
                extensions,
                _guards: guards,
            }),
            Err(io) => Err(Self {
                io: Rewind::new_buffered(io, buf),
                extensions,
                _guards: guards,
            }),
        }
    }
}

trait UpgradeIo: Io + Unpin {
    fn __type_id(&self) -> TypeId {
        TypeId::of::<Self>()
    }
}

impl<T: Io + Unpin> UpgradeIo for T {}

impl dyn UpgradeIo {
    fn __is<T: UpgradeIo>(&self) -> bool {
        let t = TypeId::of::<T>();
        self.__type_id() == t
    }

    /// downcast a Box wrapped Type to a Box<T>
    /// implemented by raw pointer cast.
    fn __downcast<T: UpgradeIo>(self: Box<Self>) -> Result<Box<T>, Box<Self>> {
        if self.__is::<T>() {
            // Taken from `std::error::Error::downcast()`.
            // SAFETY:
            // 1. `self.__is::<T>()` performs a runtime type check (typically via `TypeId`),
            //    guaranteeing that the underlying concrete type is indeed `T`.
            // 2. We use `Box::into_raw` to obtain a pointer to the trait object, which
            //    has the same memory layout as the underlying concrete type `T` at the
            //    location identified by the runtime check.
            // 3. `Box::from_raw` is safe to call here because we are reconstructing the
            //    box from the pointer that was originally created by `Box::into_raw`,
            //    and the type `T` matches the original type of the allocated memory.
            unsafe {
                let raw: *mut dyn UpgradeIo = Box::into_raw(self);
                Ok(Box::from_raw(raw.cast()))
            }
        } else {
            Err(self)
        }
    }
}

impl ExtensionsRef for Upgraded {
    fn extensions(&self) -> &Extensions {
        &self.extensions
    }
}

#[warn(clippy::missing_trait_methods)]
impl AsyncRead for Upgraded {
    fn poll_read(
        mut self: Pin<&mut Self>,
        cx: &mut Context<'_>,
        buf: &mut ReadBuf<'_>,
    ) -> Poll<io::Result<()>> {
        Pin::new(&mut self.io).poll_read(cx, buf)
    }
}

#[warn(clippy::missing_trait_methods)]
impl AsyncWrite for Upgraded {
    fn poll_write(
        mut self: Pin<&mut Self>,
        cx: &mut Context<'_>,
        buf: &[u8],
    ) -> Poll<io::Result<usize>> {
        Pin::new(&mut self.io).poll_write(cx, buf)
    }

    fn poll_write_vectored(
        mut self: Pin<&mut Self>,
        cx: &mut Context<'_>,
        bufs: &[io::IoSlice<'_>],
    ) -> Poll<io::Result<usize>> {
        Pin::new(&mut self.io).poll_write_vectored(cx, bufs)
    }

    fn poll_flush(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<io::Result<()>> {
        Pin::new(&mut self.io).poll_flush(cx)
    }

    fn poll_shutdown(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<io::Result<()>> {
        Pin::new(&mut self.io).poll_shutdown(cx)
    }

    fn is_write_vectored(&self) -> bool {
        self.io.is_write_vectored()
    }
}

impl fmt::Debug for Upgraded {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("Upgraded").finish()
    }
}

impl fmt::Debug for Pending {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("Pending").finish()
    }
}

// ===== impl OnUpgrade =====

impl OnUpgrade {
    /// Returns true if there was an upgrade and the upgrade has already been handled
    #[must_use]
    pub fn has_handled_upgrade(&self) -> bool {
        self.rx.lock().is_terminated()
    }
}

impl Future for OnUpgrade {
    type Output = Result<Upgraded, BoxError>;

    fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
        Pin::new(&mut *self.rx.lock())
            .poll(cx)
            .map(|res| match res {
                Ok(Ok(upgraded)) => Ok(upgraded),
                Ok(Err(err)) => Err(err),
                Err(_oneshot_canceled) => Err(BoxError::from_static_str(
                    "OnUpgrade: cancelled while expecting upgrade",
                )),
            })
    }
}

impl fmt::Debug for OnUpgrade {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("OnUpgrade").field("rx", &self.rx).finish()
    }
}

// ===== impl Pending =====

impl Pending {
    /// fulfill the pending upgrade with the given [`Upgraded`] stream.
    pub fn fulfill(self, upgraded: Upgraded) {
        trace!("pending upgrade fulfill");
        _ = self.tx.send(Ok(upgraded));
    }

    /// Don't fulfill the pending Upgrade, but instead signal that
    /// upgrades are handled manually.
    pub fn manual(self) {
        trace!("pending upgrade handled manually");
        _ = self.tx.send(Err(BoxError::from_static_str(
            "OnUpgrade: manual upgrade failed",
        )));
    }
}

#[cfg(test)]
mod tests {
    use rama_core::ServiceInput;
    use rama_core::extensions::Extension;
    use std::sync::{
        Arc,
        atomic::{AtomicBool, Ordering},
    };
    use tokio_test::io::{Builder, Mock};

    use super::*;

    #[test]
    fn upgraded_downcast() {
        let io = Builder::default().build();
        let io = ServiceInput::new(io);
        let upgraded = Upgraded::new(io, Bytes::new());
        let upgraded = upgraded.downcast::<std::io::Cursor<Vec<u8>>>().unwrap_err();
        upgraded.downcast::<ServiceInput<Mock>>().unwrap();
    }

    #[test]
    fn upgraded_carries_stream_transformed_marker() {
        let io = ServiceInput::new(Builder::default().build());
        let upgraded = Upgraded::new(io, Bytes::new());
        let marker = upgraded
            .extensions()
            .get_ref::<StreamTransformed>()
            .expect("Upgraded::new must insert the StreamTransformed marker");
        assert_eq!(marker.by, "rama-http::Upgraded");
    }

    #[test]
    fn upgraded_guard_survives_downcast() {
        struct DropFlag(Arc<AtomicBool>);

        impl Drop for DropFlag {
            fn drop(&mut self) {
                self.0.store(true, Ordering::Release);
            }
        }

        let dropped = Arc::new(AtomicBool::new(false));
        let io = ServiceInput::new(Builder::default().build());
        let upgraded = Upgraded::new(io, Bytes::new()).with_guard(DropFlag(dropped.clone()));

        let upgraded = upgraded.downcast::<std::io::Cursor<Vec<u8>>>().unwrap_err();
        assert!(!dropped.load(Ordering::Acquire));

        let parts = upgraded.downcast::<ServiceInput<Mock>>().unwrap();
        assert!(!dropped.load(Ordering::Acquire));
        drop(parts);
        assert!(dropped.load(Ordering::Acquire));
    }

    #[derive(Debug, Clone, PartialEq, Eq, Extension)]
    struct MessageExtension(&'static str);

    #[tokio::test]
    async fn handle_upgrade_keeps_message_extensions_out_of_transport() {
        let (pending, on_upgrade) = pending();
        let extensions = Extensions::new();
        extensions.insert(on_upgrade);
        extensions.insert(MessageExtension("middleware"));
        let io = ServiceInput::new(Builder::default().build());
        pending.fulfill(Upgraded::new(io, Bytes::new()));

        let upgraded = handle_upgrade(&extensions).await.unwrap();
        assert!(
            upgraded
                .extensions()
                .get_ref::<MessageExtension>()
                .is_none(),
            "message extensions may contain links back to the upgraded transport"
        );
    }
}