ralph-workflow 0.7.18

PROMPT-driven multi-agent orchestrator for git repos
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
use super::*;
use crate::config::Config;
use crate::executor::{MockProcessExecutor, ProcessExecutor};
use crate::logger::{Colors, Logger};
use crate::runtime::streaming::STDOUT_PUMP_CHANNEL_CAPACITY;
use crate::workspace::MemoryWorkspace;
use crate::workspace::Workspace;

use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::mpsc;
use std::sync::Arc;
use std::time::Duration;

#[derive(Debug)]
struct ControlledReader {
    stop: Arc<AtomicBool>,
}

impl io::Read for ControlledReader {
    fn read(&mut self, buf: &mut [u8]) -> io::Result<usize> {
        if self.stop.load(Ordering::Acquire) {
            return Ok(0);
        }
        if buf.is_empty() {
            return Ok(0);
        }
        buf[0] = b'x';
        Ok(1)
    }
}

#[derive(Debug)]
struct FastReader {
    remaining: usize,
}

impl FastReader {
    fn new(total_bytes: usize) -> Self {
        Self {
            remaining: total_bytes,
        }
    }
}

impl io::Read for FastReader {
    fn read(&mut self, buf: &mut [u8]) -> io::Result<usize> {
        if self.remaining == 0 {
            return Ok(0);
        }

        let n = buf.len().min(self.remaining);
        buf[..n].fill(b'a');
        self.remaining -= n;
        Ok(n)
    }
}

#[test]
fn stdout_pump_applies_backpressure_when_receiver_is_not_consuming() {
    // Bounded-memory invariant: the stdout pump must not enqueue unbounded chunks when the
    // downstream parser stalls. A bounded channel forces backpressure (blocking on send).
    let timestamp = crate::pipeline::idle_timeout::new_activity_timestamp();
    let cancel = Arc::new(AtomicBool::new(false));

    // Large enough to exceed any bounded queue (4096 bytes per chunk).
    let reader: Box<dyn io::Read + Send> = Box::new(FastReader::new(10 * 1024 * 1024));
    let (tx, rx) = mpsc::sync_channel(STDOUT_PUMP_CHANNEL_CAPACITY);

    let handle = spawn_stdout_pump(reader, timestamp, tx, Arc::clone(&cancel));

    std::thread::sleep(Duration::from_millis(20));

    // With an unbounded channel, the pump can usually enqueue everything and exit.
    // With a bounded channel, it should block and remain alive.
    assert!(
        !handle.is_finished(),
        "stdout pump finished despite receiver not consuming"
    );

    cancel.store(true, Ordering::Release);
    drop(rx);
    let _ = handle.join();
}

#[test]
fn stdout_pump_exits_when_receiver_dropped() {
    let stop = Arc::new(AtomicBool::new(false));
    let reader: Box<dyn io::Read + Send> = Box::new(ControlledReader {
        stop: Arc::clone(&stop),
    });

    let timestamp = crate::pipeline::idle_timeout::new_activity_timestamp();
    let (tx, rx) = mpsc::sync_channel(STDOUT_PUMP_CHANNEL_CAPACITY);
    let cancel = Arc::new(AtomicBool::new(false));

    let handle = spawn_stdout_pump(reader, timestamp, tx, cancel);
    drop(rx);

    let test_result = {
        let handle_ref = &handle;
        std::panic::catch_unwind(std::panic::AssertUnwindSafe(move || {
            let deadline = std::time::Instant::now() + Duration::from_millis(200);
            while std::time::Instant::now() < deadline {
                if handle_ref.is_finished() {
                    return;
                }
                std::thread::sleep(Duration::from_millis(10));
            }
            panic!("stdout pump thread did not exit after receiver drop");
        }))
    };

    // Always stop and join so the test doesn't leak threads.
    stop.store(true, Ordering::Release);
    let _ = handle.join();

    if let Err(payload) = test_result {
        std::panic::resume_unwind(payload);
    }
}

#[test]
fn cleanup_stdout_pump_sets_cancel_on_parse_error() {
    let colors = Colors::with_enabled(false);
    let logger = Logger::new(colors);
    let config = Config::default();
    let workspace = MemoryWorkspace::new_test();

    let executor_arc: Arc<dyn ProcessExecutor> = Arc::new(MockProcessExecutor::new());
    let executor: &dyn ProcessExecutor = executor_arc.as_ref();

    let _ = (executor, colors, config, workspace); // Suppress unused warnings

    let cancel = Arc::new(AtomicBool::new(false));
    let pump_handle = std::thread::spawn(|| {});
    let parse_result: io::Result<()> = Err(io::Error::other("parse error"));

    cleanup_stdout_pump(pump_handle, &cancel, &logger, &parse_result);

    assert!(
        cancel.load(Ordering::Acquire),
        "cancel should be set on parse error to stop the pump thread promptly"
    );
}

#[test]
fn test_extract_error_message_from_json_line_opencode_usage_limit() {
    let line = r#"{"type":"error","timestamp":1768191346712,"sessionID":"ses_123","error":{"message":"usage limit reached"}}"#;
    let result = extract_error_message_from_json_line(line);
    assert_eq!(result, Some("usage limit reached".to_string()));
}

#[test]
fn test_extract_error_message_from_json_line_opencode_data_message() {
    let line = r#"{"type":"error","error":{"data":{"message":"Invalid API key"}}}"#;
    let result = extract_error_message_from_json_line(line);
    assert_eq!(result, Some("Invalid API key".to_string()));
}

#[test]
fn test_extract_error_message_from_json_line_opencode_error_name() {
    let line = r#"{"type":"error","error":{"name":"APIError"}}"#;
    let result = extract_error_message_from_json_line(line);
    assert_eq!(result, Some("APIError".to_string()));
}

#[test]
fn test_extract_error_message_from_json_line_claude_format() {
    let line = r#"{"type":"error","message":"Rate limit exceeded"}"#;
    let result = extract_error_message_from_json_line(line);
    assert_eq!(result, Some("Rate limit exceeded".to_string()));
}

#[test]
fn test_extract_error_message_from_json_line_not_error_event() {
    let line = r#"{"type":"init","session_id":"abc123"}"#;
    let result = extract_error_message_from_json_line(line);
    assert_eq!(result, None);
}

#[test]
fn test_extract_error_message_from_json_line_invalid_json() {
    let line = "This is not JSON";
    let result = extract_error_message_from_json_line(line);
    assert_eq!(result, None);
}

#[test]
fn test_extract_error_message_from_json_line_requires_explicit_error_type() {
    // Regression test: JSON without a top-level type marker should not be treated
    // as an error event, even if it contains an `error` object.
    let line = r#"{"error":{"message":"not actually an error event"}}"#;
    let result = extract_error_message_from_json_line(line);
    assert_eq!(result, None);
}

#[test]
fn test_extract_error_message_from_logfile_opencode_usage_limit() {
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    // Create a test workspace with a logfile containing OpenCode JSON output
    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));
    let logfile_path = std::path::Path::new(".agent/tmp/opencode.log");

    // Simulate OpenCode JSON output with multiple events including error
    let log_content = r#"{"type":"init","timestamp":1768191346000,"sessionID":"ses_123","model":"claude-3.5-sonnet"}
{"type":"message","timestamp":1768191346100,"content":"Processing request..."}
{"type":"message","timestamp":1768191346200,"content":"Analyzing code..."}
{"type":"error","timestamp":1768191346712,"sessionID":"ses_123","error":{"message":"usage limit reached"}}
"#;

    workspace.write(logfile_path, log_content).unwrap();

    // Extract error message from logfile
    let result = extract_error_message_from_logfile(logfile_path.to_str().unwrap(), &workspace);

    assert_eq!(result, Some("usage limit reached".to_string()));
}

#[test]
fn test_extract_error_message_from_logfile_no_error() {
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));
    let logfile_path = std::path::Path::new(".agent/tmp/opencode.log");

    // Logfile with no error events
    let log_content = r#"{"type":"init","timestamp":1768191346000,"sessionID":"ses_123"}
{"type":"message","timestamp":1768191346100,"content":"All good"}
{"type":"completion","timestamp":1768191346200,"status":"success"}
"#;

    workspace.write(logfile_path, log_content).unwrap();

    let result = extract_error_message_from_logfile(logfile_path.to_str().unwrap(), &workspace);

    assert_eq!(result, None);
}

#[test]
fn test_extract_error_message_from_logfile_file_not_found() {
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));

    // Try to extract from non-existent file
    let result = extract_error_message_from_logfile(".agent/tmp/nonexistent.log", &workspace);

    assert_eq!(result, None);
}

#[test]
fn test_extract_error_message_from_logfile_empty_file() {
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));
    let logfile_path = std::path::Path::new(".agent/tmp/empty.log");

    workspace.write(logfile_path, "").unwrap();

    let result = extract_error_message_from_logfile(logfile_path.to_str().unwrap(), &workspace);

    assert_eq!(result, None);
}

#[test]
fn test_extract_error_message_from_logfile_error_on_first_line() {
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));
    let logfile_path = std::path::Path::new(".agent/tmp/opencode.log");

    // Error on first line
    let log_content = r#"{"type":"error","error":{"message":"Invalid API key"}}
{"type":"init","timestamp":1768191346000,"sessionID":"ses_123"}
"#;

    workspace.write(logfile_path, log_content).unwrap();

    let result = extract_error_message_from_logfile(logfile_path.to_str().unwrap(), &workspace);

    assert_eq!(result, Some("Invalid API key".to_string()));
}

#[test]
fn test_extract_error_message_from_logfile_multiple_errors() {
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));
    let logfile_path = std::path::Path::new(".agent/tmp/opencode.log");

    // Multiple error events - should return the LAST one (most recent)
    let log_content = r#"{"type":"error","error":{"message":"First error"}}
{"type":"message","timestamp":1768191346100,"content":"Retrying..."}
{"type":"error","error":{"message":"Second error"}}
{"type":"message","timestamp":1768191346200,"content":"Retrying again..."}
{"type":"error","error":{"message":"Final error"}}
"#;

    workspace.write(logfile_path, log_content).unwrap();

    let result = extract_error_message_from_logfile(logfile_path.to_str().unwrap(), &workspace);

    // Should return the last error (searched in reverse, take last 50 lines)
    assert_eq!(result, Some("Final error".to_string()));
}

#[test]
fn test_extract_error_message_from_logfile_claude_format() {
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));
    let logfile_path = std::path::Path::new(".agent/tmp/claude.log");

    // Claude error format
    let log_content = r#"{"type":"init","session_id":"abc123"}
{"type":"message","content":"Working..."}
{"type":"error","message":"Rate limit exceeded"}
"#;

    workspace.write(logfile_path, log_content).unwrap();

    let result = extract_error_message_from_logfile(logfile_path.to_str().unwrap(), &workspace);

    assert_eq!(result, Some("Rate limit exceeded".to_string()));
}

#[test]
fn test_extract_error_message_from_logfile_opencode_data_format() {
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));
    let logfile_path = std::path::Path::new(".agent/tmp/opencode.log");

    // OpenCode nested data format
    let log_content = r#"{"type":"init","sessionID":"ses_123"}
{"type":"error","error":{"data":{"message":"Nested error message"}}}
"#;

    workspace.write(logfile_path, log_content).unwrap();

    let result = extract_error_message_from_logfile(logfile_path.to_str().unwrap(), &workspace);

    assert_eq!(result, Some("Nested error message".to_string()));
}

#[test]
fn test_extract_error_from_json_line_opencode_error_code() {
    // Test extraction of OpenCode error codes (usage_limit_exceeded, etc.)
    // Error codes are more stable than message text for detection
    let line = r#"{"type":"error","timestamp":1768191346712,"sessionID":"ses_123","error":{"code":"usage_limit_exceeded","message":"Usage limit reached"}}"#;
    let result = extract_error_identifier_from_json_line(line);
    assert_eq!(result, Some("usage_limit_exceeded".to_string()));
}

#[test]
fn test_extract_error_from_json_line_opencode_quota_exceeded_code() {
    // Test extraction of quota_exceeded error code
    let line =
        r#"{"type":"error","error":{"code":"quota_exceeded","message":"Quota limit reached"}}"#;
    let result = extract_error_identifier_from_json_line(line);
    assert_eq!(result, Some("quota_exceeded".to_string()));
}

#[test]
fn test_extract_error_from_json_line_opencode_usage_limit_reached_code() {
    // Test extraction of usage_limit_reached error code
    let line = r#"{"type":"error","error":{"code":"usage_limit_reached"}}"#;
    let result = extract_error_identifier_from_json_line(line);
    assert_eq!(result, Some("usage_limit_reached".to_string()));
}

#[test]
fn test_extract_error_from_json_line_opencode_provider_error() {
    // Test extraction of provider-specific errors (e.g., "anthropic: usage limit reached")
    // OpenCode multi-provider gateway forwards errors with provider prefix
    let line = r#"{"type":"error","timestamp":1768191346712,"sessionID":"ses_123","error":{"provider":"anthropic","message":"usage limit reached"}}"#;
    let result = extract_error_identifier_from_json_line(line);
    assert_eq!(result, Some("anthropic: usage limit reached".to_string()));
}

#[test]
fn test_extract_error_from_json_line_opencode_provider_error_openai() {
    // Test provider-specific error for OpenAI
    let line = r#"{"type":"error","error":{"provider":"openai","message":"usage limit exceeded"}}"#;
    let result = extract_error_identifier_from_json_line(line);
    assert_eq!(result, Some("openai: usage limit exceeded".to_string()));
}

#[test]
fn test_extract_error_from_json_line_opencode_provider_error_google() {
    // Test provider-specific error for Google
    let line = r#"{"type":"error","error":{"provider":"google","message":"quota exceeded"}}"#;
    let result = extract_error_identifier_from_json_line(line);
    assert_eq!(result, Some("google: quota exceeded".to_string()));
}

#[test]
fn test_extract_error_from_json_line_opencode_zen_error() {
    // Test OpenCode Zen usage limit error
    let line = r#"{"type":"error","timestamp":1768191346712,"error":{"message":"OpenCode Zen usage limit has been reached"}}"#;
    let result = extract_error_message_from_json_line(line);
    assert_eq!(
        result,
        Some("OpenCode Zen usage limit has been reached".to_string())
    );
}

#[test]
fn test_extract_error_from_json_line_error_code_priority() {
    // Test that error codes are extracted even when message is present
    // Error codes should have priority as they're more stable
    let line = r#"{"type":"error","error":{"code":"usage_limit_exceeded","message":"The usage limit has been reached [retryin]"}}"#;
    let result = extract_error_identifier_from_json_line(line);
    assert_eq!(result, Some("usage_limit_exceeded".to_string()));
}

#[test]
fn test_extract_error_message_from_logfile_multiple_formats() {
    // Test that we correctly extract errors from logs with multiple event types
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));
    let logfile_path = std::path::Path::new(".agent/tmp/test.log");

    let log_content = r#"{"type":"text","text":"Processing request..."}
{"type":"tool_use","tool":"read","state":{"status":"completed"}}
{"type":"error","error":{"code":"usage_limit_exceeded","message":"Usage limit reached"}}
{"type":"text","text":"Operation failed"}
"#;

    workspace.write(logfile_path, log_content).unwrap();

    let result = extract_error_message_from_logfile(logfile_path.to_str().unwrap(), &workspace);

    assert_eq!(result, Some("Usage limit reached".to_string()));
}

#[test]
fn test_extract_error_identifier_from_logfile_prefers_code() {
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));
    let logfile_path = std::path::Path::new(".agent/tmp/test.log");

    let log_content = r#"{"type":"error","error":{"code":"usage_limit_exceeded","message":"Usage limit reached"}}"#;
    workspace.write(logfile_path, log_content).unwrap();

    let result = extract_error_identifier_from_logfile(logfile_path.to_str().unwrap(), &workspace);

    assert_eq!(result, Some("usage_limit_exceeded".to_string()));
}

#[test]
fn test_extract_error_message_from_logfile_provider_specific() {
    // Test extraction of provider-specific error from logfile
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));
    let logfile_path = std::path::Path::new(".agent/tmp/opencode.log");

    let log_content = r#"{"type":"init","sessionID":"ses_123"}
{"type":"message","content":"Working..."}
{"type":"error","error":{"provider":"anthropic","message":"usage limit reached"}}
"#;

    workspace.write(logfile_path, log_content).unwrap();

    let result = extract_error_message_from_logfile(logfile_path.to_str().unwrap(), &workspace);

    assert_eq!(result, Some("anthropic: usage limit reached".to_string()));
}

#[test]
fn test_extract_error_message_from_logfile_opencode_zen() {
    // Test extraction of OpenCode Zen usage limit error from logfile
    use crate::workspace::MemoryWorkspace;
    use std::path::PathBuf;

    let workspace = MemoryWorkspace::new(PathBuf::from("/tmp/test"));
    let logfile_path = std::path::Path::new(".agent/tmp/opencode.log");

    let log_content = r#"{"type":"init","sessionID":"ses_123"}
{"type":"message","content":"Processing..."}
{"type":"error","error":{"message":"OpenCode Zen usage limit has been reached"}}
"#;

    workspace.write(logfile_path, log_content).unwrap();

    let result = extract_error_message_from_logfile(logfile_path.to_str().unwrap(), &workspace);

    assert_eq!(
        result,
        Some("OpenCode Zen usage limit has been reached".to_string())
    );
}