1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
//! Queue health checks and repair for the doctor command.
//!
//! Responsibilities:
//! - Validate queue file existence and format
//! - Check done archive integrity
//! - Apply automatic queue repairs when requested
//!
//! Not handled here:
//! - Queue modification outside of repair context
//! - Lock directory management (see lock.rs)
//!
//! Invariants/assumptions:
//! - Queue validation failures can be repaired via queue::repair module
//! - Repairs are idempotent and safe to retry
use crate::commands::doctor::types::{CheckResult, DoctorReport};
use crate::config;
use crate::contracts::BlockingState;
use crate::queue;
fn queue_recovery_state(
reason: &str,
message: impl Into<String>,
detail: impl Into<String>,
) -> BlockingState {
BlockingState::runner_recovery("queue", reason, None, message, detail)
}
pub(crate) fn check_queue(report: &mut DoctorReport, resolved: &config::Resolved, auto_fix: bool) {
if !resolved.queue_path.exists() {
report.add(
CheckResult::error(
"queue",
"queue_exists",
&format!("queue file missing at {}", resolved.queue_path.display()),
false,
Some("Run 'ralph init' to create a new queue"),
)
.with_blocking(queue_recovery_state(
"queue_missing",
"Ralph is stalled because the queue is missing.",
format!("Expected queue file at {}.", resolved.queue_path.display()),
)),
);
return;
}
match queue::load_queue(&resolved.queue_path) {
Ok(q) => {
match queue::validate_queue(&q, &resolved.id_prefix, resolved.id_width) {
Ok(_) => {
report.add(CheckResult::success(
"queue",
"queue_valid",
&format!("queue valid ({} tasks)", q.tasks.len()),
));
}
Err(e) => {
// Queue validation failed - offer repair as auto-fix
let fix_available = true;
if auto_fix && fix_available {
match apply_queue_repair(resolved) {
Ok(repair_report) => {
log::info!(
"Queue repair applied: {} tasks fixed, {} timestamps fixed, {} IDs remapped",
repair_report.fixed_tasks,
repair_report.fixed_timestamps,
repair_report.remapped_ids.len()
);
// Re-validate the queue after repair
match queue::load_queue(&resolved.queue_path) {
Ok(repaired_q) => {
match queue::validate_queue(
&repaired_q,
&resolved.id_prefix,
resolved.id_width,
) {
Ok(_) => {
// Repair succeeded and queue is now valid
report.add(CheckResult::success(
"queue",
"queue_valid",
&format!(
"queue valid after repair ({} tasks)",
repaired_q.tasks.len()
),
));
}
Err(reval_err) => {
// Repair was applied but validation still fails
report.add(
CheckResult::error(
"queue",
"queue_valid",
&format!(
"queue validation failed: {}",
reval_err
),
false,
Some("Manual repair required"),
)
.with_fix_applied(false)
.with_blocking(queue_recovery_state(
"queue_invalid",
"Ralph is stalled because the queue needs recovery.",
format!(
"Queue validation failed at {}: {}",
resolved.queue_path.display(),
reval_err
),
)),
);
}
}
}
Err(load_err) => {
report.add(
CheckResult::error(
"queue",
"queue_load",
&format!("failed to load queue after repair: {}", load_err),
false,
Some("Check queue file format or restore from backup"),
)
.with_fix_applied(false)
.with_blocking(queue_recovery_state(
"queue_load_failed",
"Ralph is stalled because the queue cannot be loaded.",
format!(
"Queue load failed at {} after repair: {}",
resolved.queue_path.display(),
load_err
),
)),
);
}
}
}
Err(repair_err) => {
log::error!("Failed to repair queue: {}", repair_err);
report.add(
CheckResult::error(
"queue",
"queue_valid",
&format!("queue validation failed: {}", e),
fix_available,
Some("Run 'ralph queue repair' to repair"),
)
.with_fix_applied(false)
.with_blocking(
queue_recovery_state(
"queue_invalid",
"Ralph is stalled because the queue needs recovery.",
format!(
"Queue validation failed at {}: {}",
resolved.queue_path.display(),
e
),
),
),
);
}
}
} else {
// No auto-fix, report the error
report.add(
CheckResult::error(
"queue",
"queue_valid",
&format!("queue validation failed: {}", e),
fix_available,
Some("Run 'ralph queue repair' or use --auto-fix to repair automatically"),
)
.with_blocking(queue_recovery_state(
"queue_invalid",
"Ralph is stalled because the queue needs recovery.",
format!(
"Queue validation failed at {}: {}",
resolved.queue_path.display(),
e
),
)),
);
}
}
}
}
Err(e) => {
report.add(
CheckResult::error(
"queue",
"queue_load",
&format!("failed to load queue: {}", e),
false,
Some("Check queue file format or restore from backup"),
)
.with_blocking(queue_recovery_state(
"queue_load_failed",
"Ralph is stalled because the queue cannot be loaded.",
format!(
"Queue load failed at {}: {}",
resolved.queue_path.display(),
e
),
)),
);
}
}
}
pub(crate) fn check_done_archive(report: &mut DoctorReport, resolved: &config::Resolved) {
if !resolved.done_path.exists() {
log::info!("done archive missing (optional)");
return;
}
match queue::load_queue(&resolved.done_path) {
Ok(d) => match queue::validate_queue(&d, &resolved.id_prefix, resolved.id_width) {
Ok(_) => {
report.add(CheckResult::success(
"queue",
"done_archive_valid",
&format!("done archive valid ({} tasks)", d.tasks.len()),
));
}
Err(e) => {
report.add(
CheckResult::error(
"queue",
"done_archive_valid",
&format!("done archive validation failed: {}", e),
false,
Some("Run 'ralph queue repair' to repair the done archive"),
)
.with_blocking(queue_recovery_state(
"done_archive_invalid",
"Ralph is stalled because queue history data needs recovery.",
format!(
"Done archive validation failed at {}: {}",
resolved.done_path.display(),
e
),
)),
);
}
},
Err(e) => {
report.add(
CheckResult::error(
"queue",
"done_archive_load",
&format!("failed to load done archive: {}", e),
false,
Some("Check done file format or restore from backup"),
)
.with_blocking(queue_recovery_state(
"done_archive_load_failed",
"Ralph is stalled because queue history data cannot be loaded.",
format!(
"Done archive load failed at {}: {}",
resolved.done_path.display(),
e
),
)),
);
}
}
}
/// Apply queue repair for auto-fix.
pub(crate) fn apply_queue_repair(
resolved: &config::Resolved,
) -> anyhow::Result<queue::repair::RepairReport> {
queue::repair::repair_queue(
&resolved.queue_path,
&resolved.done_path,
&resolved.id_prefix,
resolved.id_width,
false, // not dry run
)
}