radix-transactions 1.3.1

use crate::manifest::ast::ValueKind;
use crate::manifest::ast::*;
use crate::manifest::compiler::CompileErrorDiagnosticsStyle;
use crate::manifest::diagnostic_snippets::create_snippet;
use crate::manifest::manifest_enums::KNOWN_ENUM_DISCRIMINATORS;
use crate::manifest::token::{Position, Span, Token, TokenWithSpan};
use crate::manifest::*;
use radix_common::data::manifest::MANIFEST_SBOR_V1_MAX_DEPTH;
use sbor::prelude::*;

// For values greater than below it is not possible to encode compiled manifest due to
//   EncodeError::MaxDepthExceeded(MANIFEST_SBOR_V1_MAX_DEPTH)
pub const PARSER_MAX_DEPTH: usize = MANIFEST_SBOR_V1_MAX_DEPTH - 4;

#[derive(Debug, Clone, PartialEq, Eq)]
pub enum ParserErrorKind {
    UnexpectedEof,
    UnexpectedToken { expected: TokenType, actual: Token },
    InvalidArgument { expected: TokenType, actual: Token },
    InvalidNumberOfValues { expected: usize, actual: usize },
    InvalidNumberOfTypes { expected: usize, actual: usize },
    UnknownEnumDiscriminator { actual: String },
    MaxDepthExceeded { actual: usize, max: usize },
}

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct ParserError {
    pub error_kind: ParserErrorKind,
    pub span: Span,
}

impl ParserError {
    fn unexpected_token(token: TokenWithSpan, expected: TokenType) -> Self {
        Self {
            error_kind: ParserErrorKind::UnexpectedToken {
                expected,
                actual: token.token,
            },
            span: token.span,
        }
    }
}

#[derive(Debug, Clone, PartialEq, Eq)]
pub enum TokenType {
    Instruction,
    Value,
    ValueKind,
    EnumDiscriminator,
    Exact(Token),
}

impl fmt::Display for TokenType {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        match self {
            TokenType::Instruction => write!(f, "an instruction"),
            TokenType::Value => write!(f, "a manifest SBOR value"),
            TokenType::ValueKind => write!(f, "a manifest SBOR value kind"),
            TokenType::EnumDiscriminator => {
                write!(f, "a u8 enum discriminator or valid discriminator alias")
            }
            TokenType::Exact(token) => write!(f, "exactly {}", token),
        }
    }
}

pub enum InstructionIdent {
    // ==============
    // Pseudo-instructions
    // ==============
    UsePreallocatedAddress,
    UseChild,

    // ==============
    // Standard instructions (in canonical order)
    // ==============

    // Bucket Lifecycle
    TakeFromWorktop,
    TakeNonFungiblesFromWorktop,
    TakeAllFromWorktop,
    ReturnToWorktop,
    BurnResource,

    // Resource Assertions
    AssertWorktopContainsAny,
    AssertWorktopContains,
    AssertWorktopContainsNonFungibles,
    AssertWorktopIsEmpty, // An alias
    AssertWorktopResourcesOnly,
    AssertWorktopResourcesInclude,
    AssertNextCallReturnsOnly,
    AssertNextCallReturnsInclude,
    AssertBucketContents,

    // Proof Lifecycle
    CreateProofFromBucketOfAmount,
    CreateProofFromBucketOfNonFungibles,
    CreateProofFromBucketOfAll,
    CreateProofFromAuthZoneOfAmount,
    CreateProofFromAuthZoneOfNonFungibles,
    CreateProofFromAuthZoneOfAll,
    CloneProof,
    DropProof,
    PushToAuthZone,
    PopFromAuthZone,
    DropAuthZoneProofs,
    DropAuthZoneRegularProofs,
    DropAuthZoneSignatureProofs,
    DropNamedProofs,
    DropAllProofs,

    // Invocations
    CallFunction,
    CallMethod,
    CallRoyaltyMethod,
    CallMetadataMethod,
    CallRoleAssignmentMethod,
    CallDirectVaultMethod,

    // Address Allocation
    AllocateGlobalAddress,

    // Interactions with other intents
    YieldToParent,
    YieldToChild,
    VerifyParent,

    // ==============
    // Call direct vault method aliases
    // ==============
    RecallFromVault,
    FreezeVault,
    UnfreezeVault,
    RecallNonFungiblesFromVault,

    // ==============
    // Call function aliases
    // ==============
    PublishPackage,
    PublishPackageAdvanced,
    CreateFungibleResource,
    CreateFungibleResourceWithInitialSupply,
    CreateNonFungibleResource,
    CreateNonFungibleResourceWithInitialSupply,
    CreateAccessController,
    CreateIdentity,
    CreateIdentityAdvanced,
    CreateAccount,
    CreateAccountAdvanced,

    // ==============
    // Call non-main-method aliases
    // ==============
    SetMetadata,
    RemoveMetadata,
    LockMetadata,
    SetComponentRoyalty,
    LockComponentRoyalty,
    ClaimComponentRoyalties,
    SetOwnerRole,
    LockOwnerRole,
    SetRole,

    // ==============
    // Call main-method aliases
    // ==============
    ClaimPackageRoyalties,
    MintFungible,
    MintNonFungible,
    MintRuidNonFungible,
    CreateValidator,
}

impl InstructionIdent {
    pub fn from_ident(ident: &str) -> Option<Self> {
        let value = match ident {
            // ==============
            // Pseudo-instructions
            // ==============
            "USE_CHILD" => InstructionIdent::UseChild,
            "USE_PREALLOCATED_ADDRESS" => InstructionIdent::UsePreallocatedAddress,

            // ==============
            // Standard instructions (in canonical order)
            // ==============

            // Bucket Lifecycle
            TakeFromWorktop::IDENT => InstructionIdent::TakeFromWorktop,
            TakeNonFungiblesFromWorktop::IDENT => InstructionIdent::TakeNonFungiblesFromWorktop,
            TakeAllFromWorktop::IDENT => InstructionIdent::TakeAllFromWorktop,
            ReturnToWorktop::IDENT => InstructionIdent::ReturnToWorktop,
            BurnResource::IDENT => InstructionIdent::BurnResource,

            // Resource Assertions
            AssertWorktopContains::IDENT => InstructionIdent::AssertWorktopContains,
            AssertWorktopContainsNonFungibles::IDENT => {
                InstructionIdent::AssertWorktopContainsNonFungibles
            }
            AssertWorktopContainsAny::IDENT => InstructionIdent::AssertWorktopContainsAny,
            "ASSERT_WORKTOP_IS_EMPTY" => InstructionIdent::AssertWorktopIsEmpty,
            AssertWorktopResourcesOnly::IDENT => InstructionIdent::AssertWorktopResourcesOnly,
            AssertWorktopResourcesInclude::IDENT => InstructionIdent::AssertWorktopResourcesInclude,
            AssertNextCallReturnsOnly::IDENT => InstructionIdent::AssertNextCallReturnsOnly,
            AssertNextCallReturnsInclude::IDENT => InstructionIdent::AssertNextCallReturnsInclude,
            AssertBucketContents::IDENT => InstructionIdent::AssertBucketContents,

            // Proof Lifecycle
            CreateProofFromBucketOfAmount::IDENT => InstructionIdent::CreateProofFromBucketOfAmount,
            CreateProofFromBucketOfNonFungibles::IDENT => {
                InstructionIdent::CreateProofFromBucketOfNonFungibles
            }
            CreateProofFromBucketOfAll::IDENT => InstructionIdent::CreateProofFromBucketOfAll,
            CreateProofFromAuthZoneOfAmount::IDENT => {
                InstructionIdent::CreateProofFromAuthZoneOfAmount
            }
            CreateProofFromAuthZoneOfNonFungibles::IDENT => {
                InstructionIdent::CreateProofFromAuthZoneOfNonFungibles
            }
            CreateProofFromAuthZoneOfAll::IDENT => InstructionIdent::CreateProofFromAuthZoneOfAll,
            CloneProof::IDENT => InstructionIdent::CloneProof,
            DropProof::IDENT => InstructionIdent::DropProof,
            PushToAuthZone::IDENT => InstructionIdent::PushToAuthZone,
            PopFromAuthZone::IDENT => InstructionIdent::PopFromAuthZone,
            DropAuthZoneProofs::IDENT => InstructionIdent::DropAuthZoneProofs,
            DropAuthZoneSignatureProofs::IDENT => InstructionIdent::DropAuthZoneSignatureProofs,
            DropAuthZoneRegularProofs::IDENT => InstructionIdent::DropAuthZoneRegularProofs,
            DropNamedProofs::IDENT => InstructionIdent::DropNamedProofs,
            DropAllProofs::IDENT => InstructionIdent::DropAllProofs,

            // Invocation
            CallFunction::IDENT => InstructionIdent::CallFunction,
            CallMethod::IDENT => InstructionIdent::CallMethod,
            CallRoyaltyMethod::IDENT => InstructionIdent::CallRoyaltyMethod,
            CallMetadataMethod::IDENT => InstructionIdent::CallMetadataMethod,
            CallRoleAssignmentMethod::IDENT => InstructionIdent::CallRoleAssignmentMethod,
            CallDirectVaultMethod::IDENT => InstructionIdent::CallDirectVaultMethod,

            // Address Allocation
            AllocateGlobalAddress::IDENT => InstructionIdent::AllocateGlobalAddress,

            // Interaction with other intents
            YieldToParent::IDENT => InstructionIdent::YieldToParent,
            YieldToChild::IDENT => InstructionIdent::YieldToChild,
            VerifyParent::IDENT => InstructionIdent::VerifyParent,

            // ==============
            // Call direct vault method aliases
            // ==============
            "RECALL_FROM_VAULT" => InstructionIdent::RecallFromVault,
            "FREEZE_VAULT" => InstructionIdent::FreezeVault,
            "UNFREEZE_VAULT" => InstructionIdent::UnfreezeVault,
            "RECALL_NON_FUNGIBLES_FROM_VAULT" => InstructionIdent::RecallNonFungiblesFromVault,

            // ==============
            // Call function aliases
            // ==============
            "PUBLISH_PACKAGE" => InstructionIdent::PublishPackage,
            "PUBLISH_PACKAGE_ADVANCED" => InstructionIdent::PublishPackageAdvanced,
            "CREATE_FUNGIBLE_RESOURCE" => InstructionIdent::CreateFungibleResource,
            "CREATE_FUNGIBLE_RESOURCE_WITH_INITIAL_SUPPLY" => {
                InstructionIdent::CreateFungibleResourceWithInitialSupply
            }
            "CREATE_NON_FUNGIBLE_RESOURCE" => InstructionIdent::CreateNonFungibleResource,
            "CREATE_NON_FUNGIBLE_RESOURCE_WITH_INITIAL_SUPPLY" => {
                InstructionIdent::CreateNonFungibleResourceWithInitialSupply
            }
            "CREATE_IDENTITY" => InstructionIdent::CreateIdentity,
            "CREATE_IDENTITY_ADVANCED" => InstructionIdent::CreateIdentityAdvanced,
            "CREATE_ACCOUNT" => InstructionIdent::CreateAccount,
            "CREATE_ACCOUNT_ADVANCED" => InstructionIdent::CreateAccountAdvanced,
            "CREATE_ACCESS_CONTROLLER" => InstructionIdent::CreateAccessController,

            // ==============
            // Call non-main-method aliases
            // ==============
            "SET_METADATA" => InstructionIdent::SetMetadata,
            "REMOVE_METADATA" => InstructionIdent::RemoveMetadata,
            "LOCK_METADATA" => InstructionIdent::LockMetadata,
            "SET_COMPONENT_ROYALTY" => InstructionIdent::SetComponentRoyalty,
            "LOCK_COMPONENT_ROYALTY" => InstructionIdent::LockComponentRoyalty,
            "CLAIM_COMPONENT_ROYALTIES" => InstructionIdent::ClaimComponentRoyalties,
            "SET_OWNER_ROLE" => InstructionIdent::SetOwnerRole,
            "LOCK_OWNER_ROLE" => InstructionIdent::LockOwnerRole,
            "SET_ROLE" => InstructionIdent::SetRole,

            // ==============
            // Call main-method aliases
            // ==============
            "MINT_FUNGIBLE" => InstructionIdent::MintFungible,
            "MINT_NON_FUNGIBLE" => InstructionIdent::MintNonFungible,
            "MINT_RUID_NON_FUNGIBLE" => InstructionIdent::MintRuidNonFungible,
            "CLAIM_PACKAGE_ROYALTIES" => InstructionIdent::ClaimPackageRoyalties,
            "CREATE_VALIDATOR" => InstructionIdent::CreateValidator,

            _ => {
                return None;
            }
        };
        Some(value)
    }
}

pub enum ManifestValueIdent {
    // ==============
    // SBOR composite value types
    // ==============
    Enum,
    Array,
    Tuple,
    Map,
    // ==============
    // SBOR aliases
    // ==============
    Some,
    None,
    Ok,
    Err,
    Bytes,
    NonFungibleGlobalId,
    // ==============
    // SBOR custom types
    // ==============
    Address,
    Bucket,
    Proof,
    Expression,
    Blob,
    Decimal,
    PreciseDecimal,
    NonFungibleLocalId,
    AddressReservation,
    NamedAddress,
    Intent,
    NamedIntent,
}

impl ManifestValueIdent {
    pub fn from_ident(ident: &str) -> Option<Self> {
        let value = match ident {
            // ==============
            // SBOR composite value types
            // ==============
            "Enum" => Self::Enum,
            "Array" => Self::Array,
            "Tuple" => Self::Tuple,
            "Map" => Self::Map,
            // ==============
            // SBOR aliases
            // ==============
            "Some" => Self::Some,
            "None" => Self::None,
            "Ok" => Self::Ok,
            "Err" => Self::Err,
            "Bytes" => Self::Bytes,
            "NonFungibleGlobalId" => Self::NonFungibleGlobalId,
            // ==============
            // Custom types
            // ==============
            "Address" => Self::Address,
            "Bucket" => Self::Bucket,
            "Proof" => Self::Proof,
            "Expression" => Self::Expression,
            "Blob" => Self::Blob,
            "Decimal" => Self::Decimal,
            "PreciseDecimal" => Self::PreciseDecimal,
            "NonFungibleLocalId" => Self::NonFungibleLocalId,
            "AddressReservation" => Self::AddressReservation,
            "NamedAddress" => Self::NamedAddress,
            "Intent" => Self::Intent,
            "NamedIntent" => Self::NamedIntent,
            _ => {
                return None;
            }
        };
        Some(value)
    }
}

pub struct Parser {
    tokens: Vec<TokenWithSpan>,
    current: usize,
    max_depth: usize,
    stack_depth: usize,
}

impl Parser {
    pub fn new(tokens: Vec<TokenWithSpan>, max_depth: usize) -> Result<Self, ParserError> {
        if tokens.is_empty() {
            Err(ParserError {
                error_kind: ParserErrorKind::UnexpectedEof,
                span: Span {
                    start: Position {
                        full_index: 0,
                        line_idx: 0,
                        line_char_index: 0,
                    },
                    end: Position {
                        full_index: 0,
                        line_idx: 0,
                        line_char_index: 0,
                    },
                },
            })
        } else {
            Ok(Self {
                tokens,
                current: 0,
                max_depth,
                stack_depth: 0,
            })
        }
    }

    #[inline]
    fn track_stack_depth_increase(&mut self) -> Result<(), ParserError> {
        self.stack_depth += 1;
        if self.stack_depth > self.max_depth {
            let token = self.peek()?;

            return Err(ParserError {
                error_kind: ParserErrorKind::MaxDepthExceeded {
                    actual: self.stack_depth,
                    max: self.max_depth,
                },
                span: token.span,
            });
        }
        Ok(())
    }

    #[inline]
    fn track_stack_depth_decrease(&mut self) -> Result<(), ParserError> {
        self.stack_depth -= 1;
        Ok(())
    }

    pub fn is_eof(&self) -> bool {
        self.current == self.tokens.len()
    }

    pub fn peek(&mut self) -> Result<TokenWithSpan, ParserError> {
        match self.tokens.get(self.current) {
            Some(token) => Ok(token.clone()),
            None => Err(ParserError {
                error_kind: ParserErrorKind::UnexpectedEof,
                span: {
                    let position = self.tokens[self.current - 1].span.end;
                    Span {
                        start: position,
                        end: position,
                    }
                },
            }),
        }
    }

    pub fn advance(&mut self) -> Result<TokenWithSpan, ParserError> {
        let token = self.peek()?;
        self.current += 1;
        Ok(token)
    }

    fn advance_exact(&mut self, expected: Token) -> Result<TokenWithSpan, ParserError> {
        let token = self.advance()?;

        if token.token != expected {
            Err(ParserError::unexpected_token(
                token,
                TokenType::Exact(expected),
            ))
        } else {
            Ok(token)
        }
    }

    pub fn parse_manifest(&mut self) -> Result<Vec<InstructionWithSpan>, ParserError> {
        let mut instructions = Vec::<InstructionWithSpan>::new();

        while !self.is_eof() {
            instructions.push(self.parse_instruction()?);
        }

        Ok(instructions)
    }

    fn parse_instruction_arguments(&mut self) -> Result<Vec<ValueWithSpan>, ParserError> {
        let mut args = Vec::new();
        while self.peek()?.token != Token::Semicolon {
            let stack_depth = self.stack_depth;
            let result = self.parse_value();
            match result {
                Ok(value) => args.push(value),
                Err(err) => match err.error_kind {
                    // We wish to return a more specific error if the instruction's argument list is invalid.
                    // We check if the error from parse_value comes from parsing the argument itself
                    // by verifying it:
                    // (a) Was an UnexpectedToken error when a Value was expected.
                    // (b) It originated at a stack_depth directly under the argument list, so the expected
                    // value was an argument rather than an internal value inside an argument.
                    ParserErrorKind::UnexpectedToken { expected, actual }
                        if expected == TokenType::Value
                            && (stack_depth + 1 == self.stack_depth) =>
                    {
                        return Err(ParserError {
                            error_kind: ParserErrorKind::InvalidArgument { expected, actual },
                            span: err.span,
                        })
                    }
                    _ => return Err(err),
                },
            }
        }
        Ok(args)
    }

    pub fn parse_instruction(&mut self) -> Result<InstructionWithSpan, ParserError> {
        let token = self.advance()?;
        let instruction_ident = match &token.token {
            Token::Ident(ident_str) => InstructionIdent::from_ident(ident_str).ok_or(
                ParserError::unexpected_token(token.clone(), TokenType::Instruction),
            )?,
            _ => {
                return Err(ParserError::unexpected_token(token, TokenType::Instruction));
            }
        };
        let instruction_start = token.span.start;

        let instruction = match instruction_ident {
            //===============
            // Pseudo-instructions
            //===============
            InstructionIdent::UsePreallocatedAddress => Instruction::UsePreallocatedAddress {
                package_address: self.parse_value()?,
                blueprint_name: self.parse_value()?,
                address_reservation: self.parse_value()?,
                preallocated_address: self.parse_value()?,
            },
            InstructionIdent::UseChild => Instruction::UseChild {
                named_intent: self.parse_value()?,
                subintent_hash: self.parse_value()?,
            },

            //===============
            // Standard instructions (in canonical order)
            //===============

            // Bucket Lifecycle
            InstructionIdent::TakeFromWorktop => Instruction::TakeFromWorktop {
                resource_address: self.parse_value()?,
                amount: self.parse_value()?,
                new_bucket: self.parse_value()?,
            },
            InstructionIdent::TakeNonFungiblesFromWorktop => {
                Instruction::TakeNonFungiblesFromWorktop {
                    resource_address: self.parse_value()?,
                    ids: self.parse_value()?,
                    new_bucket: self.parse_value()?,
                }
            }
            InstructionIdent::TakeAllFromWorktop => Instruction::TakeAllFromWorktop {
                resource_address: self.parse_value()?,
                new_bucket: self.parse_value()?,
            },
            InstructionIdent::ReturnToWorktop => Instruction::ReturnToWorktop {
                bucket: self.parse_value()?,
            },
            InstructionIdent::BurnResource => Instruction::BurnResource {
                bucket: self.parse_value()?,
            },

            // Resource Assertions
            InstructionIdent::AssertWorktopContainsAny => Instruction::AssertWorktopContainsAny {
                resource_address: self.parse_value()?,
            },
            InstructionIdent::AssertWorktopContains => Instruction::AssertWorktopContains {
                resource_address: self.parse_value()?,
                amount: self.parse_value()?,
            },
            InstructionIdent::AssertWorktopContainsNonFungibles => {
                Instruction::AssertWorktopContainsNonFungibles {
                    resource_address: self.parse_value()?,
                    ids: self.parse_value()?,
                }
            }
            InstructionIdent::AssertWorktopIsEmpty => Instruction::AssertWorktopIsEmpty,
            InstructionIdent::AssertWorktopResourcesOnly => {
                Instruction::AssertWorktopResourcesOnly {
                    constraints: self.parse_value()?,
                }
            }
            InstructionIdent::AssertWorktopResourcesInclude => {
                Instruction::AssertWorktopResourcesInclude {
                    constraints: self.parse_value()?,
                }
            }
            InstructionIdent::AssertNextCallReturnsOnly => Instruction::AssertNextCallReturnsOnly {
                constraints: self.parse_value()?,
            },
            InstructionIdent::AssertNextCallReturnsInclude => {
                Instruction::AssertNextCallReturnsInclude {
                    constraints: self.parse_value()?,
                }
            }
            InstructionIdent::AssertBucketContents => Instruction::AssertBucketContents {
                bucket: self.parse_value()?,
                constraint: self.parse_value()?,
            },

            // Proof Lifecycle
            InstructionIdent::CreateProofFromBucketOfAmount => {
                Instruction::CreateProofFromBucketOfAmount {
                    bucket: self.parse_value()?,
                    amount: self.parse_value()?,
                    new_proof: self.parse_value()?,
                }
            }
            InstructionIdent::CreateProofFromBucketOfNonFungibles => {
                Instruction::CreateProofFromBucketOfNonFungibles {
                    bucket: self.parse_value()?,
                    ids: self.parse_value()?,
                    new_proof: self.parse_value()?,
                }
            }
            InstructionIdent::CreateProofFromBucketOfAll => {
                Instruction::CreateProofFromBucketOfAll {
                    bucket: self.parse_value()?,
                    new_proof: self.parse_value()?,
                }
            }
            InstructionIdent::CreateProofFromAuthZoneOfAmount => {
                Instruction::CreateProofFromAuthZoneOfAmount {
                    resource_address: self.parse_value()?,
                    amount: self.parse_value()?,
                    new_proof: self.parse_value()?,
                }
            }
            InstructionIdent::CreateProofFromAuthZoneOfNonFungibles => {
                Instruction::CreateProofFromAuthZoneOfNonFungibles {
                    resource_address: self.parse_value()?,
                    ids: self.parse_value()?,
                    new_proof: self.parse_value()?,
                }
            }
            InstructionIdent::CreateProofFromAuthZoneOfAll => {
                Instruction::CreateProofFromAuthZoneOfAll {
                    resource_address: self.parse_value()?,
                    new_proof: self.parse_value()?,
                }
            }
            InstructionIdent::CloneProof => Instruction::CloneProof {
                proof: self.parse_value()?,
                new_proof: self.parse_value()?,
            },
            InstructionIdent::DropProof => Instruction::DropProof {
                proof: self.parse_value()?,
            },
            InstructionIdent::PushToAuthZone => Instruction::PushToAuthZone {
                proof: self.parse_value()?,
            },
            InstructionIdent::PopFromAuthZone => Instruction::PopFromAuthZone {
                new_proof: self.parse_value()?,
            },
            InstructionIdent::DropAuthZoneProofs => Instruction::DropAuthZoneProofs,
            InstructionIdent::DropAuthZoneRegularProofs => Instruction::DropAuthZoneRegularProofs,
            InstructionIdent::DropAuthZoneSignatureProofs => {
                Instruction::DropAuthZoneSignatureProofs
            }
            InstructionIdent::DropNamedProofs => Instruction::DropNamedProofs,
            InstructionIdent::DropAllProofs => Instruction::DropAllProofs,

            // Invocations
            InstructionIdent::CallFunction => Instruction::CallFunction {
                package_address: self.parse_value()?,
                blueprint_name: self.parse_value()?,
                function_name: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CallMethod => Instruction::CallMethod {
                address: self.parse_value()?,
                method_name: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CallRoyaltyMethod => Instruction::CallRoyaltyMethod {
                address: self.parse_value()?,
                method_name: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CallMetadataMethod => Instruction::CallMetadataMethod {
                address: self.parse_value()?,
                method_name: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CallRoleAssignmentMethod => Instruction::CallRoleAssignmentMethod {
                address: self.parse_value()?,
                method_name: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CallDirectVaultMethod => Instruction::CallDirectVaultMethod {
                address: self.parse_value()?,
                method_name: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },

            // Address Allocation
            InstructionIdent::AllocateGlobalAddress => Instruction::AllocateGlobalAddress {
                package_address: self.parse_value()?,
                blueprint_name: self.parse_value()?,
                address_reservation: self.parse_value()?,
                named_address: self.parse_value()?,
            },

            // Interaction with other intents
            InstructionIdent::YieldToParent => Instruction::YieldToParent {
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::YieldToChild => Instruction::YieldToChild {
                child: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::VerifyParent => Instruction::VerifyParent {
                access_rule: self.parse_value()?,
            },

            //===============
            // Direct vault aliases
            //===============
            InstructionIdent::RecallFromVault => Instruction::RecallFromVault {
                vault_id: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::FreezeVault => Instruction::FreezeVault {
                vault_id: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::UnfreezeVault => Instruction::UnfreezeVault {
                vault_id: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::RecallNonFungiblesFromVault => {
                Instruction::RecallNonFungiblesFromVault {
                    vault_id: self.parse_value()?,
                    args: self.parse_instruction_arguments()?,
                }
            }

            //===============
            // Call function aliases
            //===============
            InstructionIdent::PublishPackage => Instruction::PublishPackage {
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::PublishPackageAdvanced => Instruction::PublishPackageAdvanced {
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CreateFungibleResource => Instruction::CreateFungibleResource {
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CreateFungibleResourceWithInitialSupply => {
                Instruction::CreateFungibleResourceWithInitialSupply {
                    args: self.parse_instruction_arguments()?,
                }
            }
            InstructionIdent::CreateNonFungibleResource => Instruction::CreateNonFungibleResource {
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CreateNonFungibleResourceWithInitialSupply => {
                Instruction::CreateNonFungibleResourceWithInitialSupply {
                    args: self.parse_instruction_arguments()?,
                }
            }
            InstructionIdent::CreateAccessController => Instruction::CreateAccessController {
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CreateIdentity => Instruction::CreateIdentity {
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CreateIdentityAdvanced => Instruction::CreateIdentityAdvanced {
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CreateAccount => Instruction::CreateAccount {
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CreateAccountAdvanced => Instruction::CreateAccountAdvanced {
                args: self.parse_instruction_arguments()?,
            },

            //===============
            // Call non-main method aliases
            //===============
            InstructionIdent::SetMetadata => Instruction::SetMetadata {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::RemoveMetadata => Instruction::RemoveMetadata {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::LockMetadata => Instruction::LockMetadata {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::SetComponentRoyalty => Instruction::SetComponentRoyalty {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::LockComponentRoyalty => Instruction::LockComponentRoyalty {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::ClaimComponentRoyalties => Instruction::ClaimComponentRoyalties {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::SetOwnerRole => Instruction::SetOwnerRole {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::LockOwnerRole => Instruction::LockOwnerRole {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::SetRole => Instruction::SetRole {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },

            //===============
            // Call main method aliases
            //===============
            InstructionIdent::MintFungible => Instruction::MintFungible {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::MintNonFungible => Instruction::MintNonFungible {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::MintRuidNonFungible => Instruction::MintRuidNonFungible {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::ClaimPackageRoyalties => Instruction::ClaimPackageRoyalties {
                address: self.parse_value()?,
                args: self.parse_instruction_arguments()?,
            },
            InstructionIdent::CreateValidator => Instruction::CreateValidator {
                args: self.parse_instruction_arguments()?,
            },
        };

        let instruction_end = self.advance_exact(Token::Semicolon)?.span.end;

        Ok(InstructionWithSpan {
            instruction,
            span: Span {
                start: instruction_start,
                end: instruction_end,
            },
        })
    }

    pub fn parse_value(&mut self) -> Result<ValueWithSpan, ParserError> {
        self.track_stack_depth_increase()?;
        let token = self.advance()?;
        let value = match &token.token {
            // ==============
            // Basic Types
            // ==============
            Token::BoolLiteral(value) => Value::Bool(*value),
            Token::U8Literal(value) => Value::U8(*value),
            Token::U16Literal(value) => Value::U16(*value),
            Token::U32Literal(value) => Value::U32(*value),
            Token::U64Literal(value) => Value::U64(*value),
            Token::U128Literal(value) => Value::U128(*value),
            Token::I8Literal(value) => Value::I8(*value),
            Token::I16Literal(value) => Value::I16(*value),
            Token::I32Literal(value) => Value::I32(*value),
            Token::I64Literal(value) => Value::I64(*value),
            Token::I128Literal(value) => Value::I128(*value),
            Token::StringLiteral(value) => Value::String(value.clone()),
            Token::Ident(ident_str) => {
                let value_ident = ManifestValueIdent::from_ident(ident_str).ok_or(
                    ParserError::unexpected_token(token.clone(), TokenType::Value),
                )?;
                match value_ident {
                    ManifestValueIdent::Enum => self.parse_enum_content()?,
                    ManifestValueIdent::Array => self.parse_array_content()?,
                    ManifestValueIdent::Tuple => self.parse_tuple_content()?,
                    ManifestValueIdent::Map => self.parse_map_content()?,

                    // ==============
                    // Aliases
                    // ==============
                    ManifestValueIdent::Some => Value::Some(Box::new(self.parse_values_one()?)),
                    ManifestValueIdent::None => Value::None,
                    ManifestValueIdent::Ok => Value::Ok(Box::new(self.parse_values_one()?)),
                    ManifestValueIdent::Err => Value::Err(Box::new(self.parse_values_one()?)),
                    ManifestValueIdent::Bytes => Value::Bytes(Box::new(self.parse_values_one()?)),
                    ManifestValueIdent::NonFungibleGlobalId => {
                        Value::NonFungibleGlobalId(Box::new(self.parse_values_one()?))
                    }

                    // ==============
                    // Custom Types
                    // ==============
                    ManifestValueIdent::Address => Value::Address(self.parse_values_one()?.into()),
                    ManifestValueIdent::Bucket => Value::Bucket(self.parse_values_one()?.into()),
                    ManifestValueIdent::Proof => Value::Proof(self.parse_values_one()?.into()),
                    ManifestValueIdent::Expression => {
                        Value::Expression(self.parse_values_one()?.into())
                    }
                    ManifestValueIdent::Blob => Value::Blob(self.parse_values_one()?.into()),
                    ManifestValueIdent::Decimal => Value::Decimal(self.parse_values_one()?.into()),
                    ManifestValueIdent::PreciseDecimal => {
                        Value::PreciseDecimal(self.parse_values_one()?.into())
                    }
                    ManifestValueIdent::NonFungibleLocalId => {
                        Value::NonFungibleLocalId(self.parse_values_one()?.into())
                    }
                    ManifestValueIdent::AddressReservation => {
                        Value::AddressReservation(self.parse_values_one()?.into())
                    }
                    ManifestValueIdent::NamedAddress => {
                        Value::NamedAddress(self.parse_values_one()?.into())
                    }
                    ManifestValueIdent::Intent => Value::Intent(self.parse_values_one()?.into()),
                    ManifestValueIdent::NamedIntent => {
                        Value::NamedIntent(self.parse_values_one()?.into())
                    }
                }
            }
            _ => {
                return Err(ParserError::unexpected_token(token, TokenType::Value));
            }
        };
        self.track_stack_depth_decrease()?;
        Ok(ValueWithSpan {
            value,
            span: token.span,
        })
    }

    pub fn parse_enum_content(&mut self) -> Result<Value, ParserError> {
        self.advance_exact(Token::LessThan)?;

        let discriminator_token = self.advance()?;
        let discriminator = match discriminator_token.token {
            Token::U8Literal(discriminator) => discriminator,
            Token::Ident(discriminator) => KNOWN_ENUM_DISCRIMINATORS
                .get(discriminator.as_str())
                .cloned()
                .ok_or(ParserError {
                    error_kind: ParserErrorKind::UnknownEnumDiscriminator {
                        actual: discriminator.clone(),
                    },
                    span: discriminator_token.span,
                })?,
            _ => {
                return Err(ParserError::unexpected_token(
                    discriminator_token,
                    TokenType::EnumDiscriminator,
                ))
            }
        };
        self.advance_exact(Token::GreaterThan)?;

        let fields = self.parse_values_any(Token::OpenParenthesis, Token::CloseParenthesis)?;

        Ok(Value::Enum(discriminator, fields))
    }

    pub fn parse_array_content(&mut self) -> Result<Value, ParserError> {
        let generics = self.parse_generics(1)?;
        Ok(Value::Array(
            generics[0].clone(),
            self.parse_values_any(Token::OpenParenthesis, Token::CloseParenthesis)?,
        ))
    }

    pub fn parse_tuple_content(&mut self) -> Result<Value, ParserError> {
        Ok(Value::Tuple(self.parse_values_any(
            Token::OpenParenthesis,
            Token::CloseParenthesis,
        )?))
    }

    pub fn parse_map_content(&mut self) -> Result<Value, ParserError> {
        let generics = self.parse_generics(2)?;
        self.advance_exact(Token::OpenParenthesis)?;
        let mut entries = Vec::new();

        while self.peek()?.token != Token::CloseParenthesis {
            let key = self.parse_value()?;
            self.advance_exact(Token::FatArrow)?;
            let value = self.parse_value()?;
            entries.push((key, value));
            if self.peek()?.token != Token::CloseParenthesis {
                self.advance_exact(Token::Comma)?;
            }
        }
        self.advance_exact(Token::CloseParenthesis)?;
        Ok(Value::Map(
            generics[0].clone(),
            generics[1].clone(),
            entries,
        ))
    }

    /// Parse a comma-separated value list, enclosed by a pair of marks.
    fn parse_values_any(
        &mut self,
        open: Token,
        close: Token,
    ) -> Result<Vec<ValueWithSpan>, ParserError> {
        self.parse_values_any_with_open_close_spans(open, close)
            .map(|(values, _, _)| values)
    }

    /// Parse a comma-separated value list, enclosed by a pair of marks.
    /// Return values and opening and closing span
    fn parse_values_any_with_open_close_spans(
        &mut self,
        open: Token,
        close: Token,
    ) -> Result<(Vec<ValueWithSpan>, Span, Span), ParserError> {
        let open_token = self.advance_exact(open)?;
        let mut values = Vec::new();
        while self.peek()?.token != close {
            values.push(self.parse_value()?);
            if self.peek()?.token != close {
                self.advance_exact(Token::Comma)?;
            }
        }
        let close_token = self.advance_exact(close)?;
        Ok((values, open_token.span, close_token.span))
    }

    fn parse_values_one(&mut self) -> Result<ValueWithSpan, ParserError> {
        let (values, open_span, close_span) = self.parse_values_any_with_open_close_spans(
            Token::OpenParenthesis,
            Token::CloseParenthesis,
        )?;
        match values.len() {
            1 => Ok(values[0].clone()),
            _ => Err(ParserError {
                error_kind: ParserErrorKind::InvalidNumberOfValues {
                    actual: values.len(),
                    expected: 1,
                },
                span: Span {
                    start: open_span.end,
                    end: close_span.start,
                },
            }),
        }
    }

    fn parse_generics(&mut self, n: usize) -> Result<Vec<ValueKindWithSpan>, ParserError> {
        let mut span_start = self.advance_exact(Token::LessThan)?.span.start;
        let mut value_kinds = Vec::new();

        while self.peek()?.token != Token::GreaterThan {
            let token_value_kind = self.parse_value_kind()?;
            value_kinds.push(token_value_kind);
            if self.peek()?.token != Token::GreaterThan {
                self.advance_exact(Token::Comma)?;
            }
        }

        let mut span_end = self.advance_exact(Token::GreaterThan)?.span.end;

        if !value_kinds.is_empty() {
            span_start = value_kinds[0].span.start;
            span_end = value_kinds[value_kinds.len() - 1].span.end;
        }

        if value_kinds.len() != n {
            Err(ParserError {
                error_kind: ParserErrorKind::InvalidNumberOfTypes {
                    expected: n,
                    actual: value_kinds.len(),
                },
                span: Span {
                    start: span_start,
                    end: span_end,
                },
            })
        } else {
            Ok(value_kinds)
        }
    }

    fn parse_value_kind(&mut self) -> Result<ValueKindWithSpan, ParserError> {
        let token = self.advance()?;
        let value_kind = match &token.token {
            Token::Ident(ident_str) => ValueKind::from_ident(ident_str).ok_or(
                ParserError::unexpected_token(token.clone(), TokenType::ValueKind),
            )?,
            _ => {
                return Err(ParserError::unexpected_token(token, TokenType::ValueKind));
            }
        };
        Ok(ValueKindWithSpan {
            value_kind,
            span: token.span,
        })
    }
}

pub fn parser_error_diagnostics(
    s: &str,
    err: ParserError,
    style: CompileErrorDiagnosticsStyle,
) -> String {
    let (title, label) = match err.error_kind {
        ParserErrorKind::UnexpectedEof => (
            "unexpected end of file".to_string(),
            "unexpected end of file".to_string(),
        ),
        ParserErrorKind::UnexpectedToken { expected, actual } => {
            let title = format!("expected {}, found {}", expected, actual);
            let label = format!("expected {}", expected);
            (title, label)
        }
        ParserErrorKind::InvalidArgument { expected, actual } => {
            let title = format!(
                "expected {} or ';' to end an argument list, found {}",
                expected, actual
            );
            let label = format!("expected {} or ';' to end an argument list", expected);
            (title, label)
        }
        ParserErrorKind::InvalidNumberOfValues { expected, actual } => {
            let title = format!("expected {} number of values, found {}", expected, actual);
            let label = format!("expected {} number of values", expected);
            (title, label)
        }
        ParserErrorKind::InvalidNumberOfTypes { expected, actual } => {
            let title = format!("expected {} number of types, found {}", expected, actual);
            let label = format!("expected {} number of types", expected);
            (title, label)
        }
        ParserErrorKind::MaxDepthExceeded { actual, max } => {
            let title = format!("manifest actual depth {} exceeded max {}", actual, max);
            (title, "max depth exceeded".to_string())
        }
        ParserErrorKind::UnknownEnumDiscriminator { actual } => {
            let title = format!("unknown enum discriminator found '{}'", actual);
            (title, "unknown enum discriminator".to_string())
        }
    };

    create_snippet(s, &err.span, &title, &label, style)
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::manifest::lexer::tokenize;
    use crate::{position, span};

    #[macro_export]
    macro_rules! parse_instruction_ok {
        ( $s:expr, $expected:expr ) => {{
            let mut parser = Parser::new(tokenize($s).unwrap(), PARSER_MAX_DEPTH).unwrap();
            assert_eq!(parser.parse_instruction(), Ok($expected));
            assert!(parser.is_eof());
        }};
    }

    #[macro_export]
    macro_rules! parse_value_ok {
        ( $s:expr, $expected:expr ) => {{
            let mut parser = Parser::new(tokenize($s).unwrap(), PARSER_MAX_DEPTH).unwrap();
            assert_eq!(parser.parse_value().map(|tv| tv.value), Ok($expected));
            assert!(parser.is_eof());
        }};
    }

    #[macro_export]
    macro_rules! parse_value_error {
        ( $s:expr, $expected:expr ) => {{
            let mut parser = Parser::new(tokenize($s).unwrap(), PARSER_MAX_DEPTH).unwrap();
            match parser.parse_value() {
                Ok(_) => {
                    panic!("Expected {:?} but no error is thrown", $expected);
                }
                Err(e) => {
                    assert_eq!(e, $expected);
                }
            }
        }};
    }

    #[test]
    fn test_literals() {
        parse_value_ok!(r#"true"#, Value::Bool(true));
        parse_value_ok!(r#"false"#, Value::Bool(false));
        parse_value_ok!(r#"1i8"#, Value::I8(1));
        parse_value_ok!(r#"1i16"#, Value::I16(1));
        parse_value_ok!(r#"1i32"#, Value::I32(1));
        parse_value_ok!(r#"1i64"#, Value::I64(1));
        parse_value_ok!(r#"1i128"#, Value::I128(1));
        parse_value_ok!(r#"1u8"#, Value::U8(1));
        parse_value_ok!(r#"1u16"#, Value::U16(1));
        parse_value_ok!(r#"1u32"#, Value::U32(1));
        parse_value_ok!(r#"1u64"#, Value::U64(1));
        parse_value_ok!(r#"1u128"#, Value::U128(1));
        parse_value_ok!(r#""test""#, Value::String("test".into()));
    }

    #[test]
    fn test_enum() {
        parse_value_ok!(
            r#"Enum<0u8>("Hello", 123u8)"#,
            Value::Enum(
                0,
                vec![
                    ValueWithSpan {
                        value: Value::String("Hello".into()),
                        span: span!(start = (10, 0, 10), end = (17, 0, 17)),
                    },
                    ValueWithSpan {
                        value: Value::U8(123),
                        span: span!(start = (19, 0, 19), end = (24, 0, 24)),
                    },
                ],
            )
        );
        parse_value_ok!(r#"Enum<0u8>()"#, Value::Enum(0, Vec::new()));
        parse_value_ok!(
            r#"Enum<PublicKey::Secp256k1>()"#,
            Value::Enum(0, Vec::new())
        );
        // Check we allow trailing commas
        parse_value_ok!(
            r#"Enum<0u8>("Hello", 123u8,)"#,
            Value::Enum(
                0,
                vec![
                    ValueWithSpan {
                        value: Value::String("Hello".into()),
                        span: span!(start = (10, 0, 10), end = (17, 0, 17)),
                    },
                    ValueWithSpan {
                        value: Value::U8(123),
                        span: span!(start = (19, 0, 19), end = (24, 0, 24)),
                    },
                ],
            )
        );
    }

    #[test]
    fn test_array() {
        parse_value_ok!(
            r#"Array<U8>(1u8, 2u8)"#,
            Value::Array(
                ValueKindWithSpan {
                    value_kind: ValueKind::U8,
                    span: span!(start = (6, 0, 6), end = (8, 0, 8)),
                },
                vec![
                    ValueWithSpan {
                        value: Value::U8(1),
                        span: span!(start = (10, 0, 10), end = (13, 0, 13)),
                    },
                    ValueWithSpan {
                        value: Value::U8(2),
                        span: span!(start = (15, 0, 15), end = (18, 0, 18)),
                    }
                ],
            )
        );
        parse_value_ok!(
            r#"Array<U8>()"#,
            Value::Array(
                ValueKindWithSpan {
                    value_kind: ValueKind::U8,
                    span: span!(start = (6, 0, 6), end = (8, 0, 8)),
                },
                vec![]
            )
        );
        // Check we allow trailing commas
        parse_value_ok!(
            r#"Array<U8>(1u8, 2u8,)"#,
            Value::Array(
                ValueKindWithSpan {
                    value_kind: ValueKind::U8,
                    span: span!(start = (6, 0, 6), end = (8, 0, 8)),
                },
                vec![
                    ValueWithSpan {
                        value: Value::U8(1),
                        span: span!(start = (10, 0, 10), end = (13, 0, 13)),
                    },
                    ValueWithSpan {
                        value: Value::U8(2),
                        span: span!(start = (15, 0, 15), end = (18, 0, 18)),
                    }
                ],
            )
        );
    }

    #[test]
    fn test_tuple() {
        parse_value_ok!(r#"Tuple()"#, Value::Tuple(vec![]));
        parse_value_ok!(
            r#"Tuple("Hello", 123u8)"#,
            Value::Tuple(vec![
                ValueWithSpan {
                    value: Value::String("Hello".into()),
                    span: span!(start = (6, 0, 6), end = (13, 0, 13)),
                },
                ValueWithSpan {
                    value: Value::U8(123),
                    span: span!(start = (15, 0, 15), end = (20, 0, 20)),
                },
            ])
        );
        parse_value_ok!(
            r#"Tuple(1u8, 2u8)"#,
            Value::Tuple(vec![
                ValueWithSpan {
                    value: Value::U8(1),
                    span: span!(start = (6, 0, 6), end = (9, 0, 9)),
                },
                ValueWithSpan {
                    value: Value::U8(2),
                    span: span!(start = (11, 0, 11), end = (14, 0, 14)),
                },
            ])
        );

        // Check we allow trailing commas
        parse_value_ok!(
            r#"Tuple(1u8, 2u8,)"#,
            Value::Tuple(vec![
                ValueWithSpan {
                    value: Value::U8(1),
                    span: span!(start = (6, 0, 6), end = (9, 0, 9)),
                },
                ValueWithSpan {
                    value: Value::U8(2),
                    span: span!(start = (11, 0, 11), end = (14, 0, 14)),
                },
            ])
        );
    }

    #[test]
    fn test_map() {
        parse_value_ok!(
            r#"Map<String, U8>("Hello" => 123u8)"#,
            Value::Map(
                ValueKindWithSpan {
                    value_kind: ValueKind::String,
                    span: span!(start = (4, 0, 4), end = (10, 0, 10)),
                },
                ValueKindWithSpan {
                    value_kind: ValueKind::U8,
                    span: span!(start = (12, 0, 12), end = (14, 0, 14)),
                },
                vec![(
                    ValueWithSpan {
                        value: Value::String("Hello".into()),
                        span: span!(start = (16, 0, 16), end = (23, 0, 23)),
                    },
                    ValueWithSpan {
                        value: Value::U8(123),
                        span: span!(start = (27, 0, 27), end = (32, 0, 32)),
                    }
                )]
            )
        );
        parse_value_ok!(
            r#"Map<String, U8>("Hello" => 123u8, "world!" => 1u8)"#,
            Value::Map(
                ValueKindWithSpan {
                    value_kind: ValueKind::String,
                    span: span!(start = (4, 0, 4), end = (10, 0, 10)),
                },
                ValueKindWithSpan {
                    value_kind: ValueKind::U8,
                    span: span!(start = (12, 0, 12), end = (14, 0, 14)),
                },
                vec![
                    (
                        ValueWithSpan {
                            value: Value::String("Hello".into()),
                            span: span!(start = (16, 0, 16), end = (23, 0, 23)),
                        },
                        ValueWithSpan {
                            value: Value::U8(123),
                            span: span!(start = (27, 0, 27), end = (32, 0, 32)),
                        }
                    ),
                    (
                        ValueWithSpan {
                            value: Value::String("world!".into()),
                            span: span!(start = (34, 0, 34), end = (42, 0, 42)),
                        },
                        ValueWithSpan {
                            value: Value::U8(1),
                            span: span!(start = (46, 0, 46), end = (49, 0, 49)),
                        }
                    )
                ]
            )
        );

        // Check we allow trailing commas
        parse_value_ok!(
            r#"Map<String, U8>("Hello" => 123u8, "world!" => 1u8,)"#,
            Value::Map(
                ValueKindWithSpan {
                    value_kind: ValueKind::String,
                    span: span!(start = (4, 0, 4), end = (10, 0, 10)),
                },
                ValueKindWithSpan {
                    value_kind: ValueKind::U8,
                    span: span!(start = (12, 0, 12), end = (14, 0, 14)),
                },
                vec![
                    (
                        ValueWithSpan {
                            value: Value::String("Hello".into()),
                            span: span!(start = (16, 0, 16), end = (23, 0, 23)),
                        },
                        ValueWithSpan {
                            value: Value::U8(123),
                            span: span!(start = (27, 0, 27), end = (32, 0, 32)),
                        }
                    ),
                    (
                        ValueWithSpan {
                            value: Value::String("world!".into()),
                            span: span!(start = (34, 0, 34), end = (42, 0, 42)),
                        },
                        ValueWithSpan {
                            value: Value::U8(1),
                            span: span!(start = (46, 0, 46), end = (49, 0, 49)),
                        }
                    )
                ]
            )
        );
    }

    #[test]
    fn test_failures() {
        parse_value_error!(
            r#"Enum<0u8"#,
            ParserError {
                error_kind: ParserErrorKind::UnexpectedEof,
                span: span!(start = (8, 0, 8), end = (8, 0, 8))
            }
        );
        parse_value_error!(
            r#"Enum<0u8)"#,
            ParserError {
                error_kind: ParserErrorKind::UnexpectedToken {
                    expected: TokenType::Exact(Token::GreaterThan),
                    actual: Token::CloseParenthesis,
                },
                span: span!(start = (8, 0, 8), end = (9, 0, 9))
            }
        );
        parse_value_error!(
            r#"Address("abc", "def")"#,
            ParserError {
                error_kind: ParserErrorKind::InvalidNumberOfValues {
                    actual: 2,
                    expected: 1,
                },
                span: span!(start = (8, 0, 8), end = (20, 0, 20)),
            }
        );
        parse_value_error!(
            r#"Address()"#,
            ParserError {
                error_kind: ParserErrorKind::InvalidNumberOfValues {
                    actual: 0,
                    expected: 1,
                },
                span: span!(start = (8, 0, 8), end = (8, 0, 8)),
            }
        );
        parse_value_error!(
            r#"Address(   )"#,
            ParserError {
                error_kind: ParserErrorKind::InvalidNumberOfValues {
                    actual: 0,
                    expected: 1,
                },
                span: span!(start = (8, 0, 8), end = (11, 0, 11)),
            }
        );
    }

    #[test]
    fn test_deep_value_does_not_panic_with_stack_overflow() {
        let depth: usize = 1000;
        let mut value_string = "".to_string();
        for _ in 0..depth {
            value_string.push_str("Tuple(");
        }
        value_string.push_str("0u8");
        for _ in 0..depth {
            value_string.push(')');
        }

        // Should actually be an error not a panic
        parse_value_error!(
            &value_string,
            ParserError {
                error_kind: ParserErrorKind::MaxDepthExceeded {
                    actual: 21,
                    max: 20,
                },
                span: span!(start = (120, 0, 120), end = (125, 0, 125))
            }
        );
    }

    // Instruction parsing tests have been removed as they're largely outdated (inconsistent with the data model),
    // which may lead developers to invalid syntax.
    //
    // It's also not very useful as instruction parsing basically calls `parse_value` recursively
    //
    // That said, all manifest instructions should be tested in `generator.rs` and `e2e.rs`.
}