1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
use std::io::{self, Write};
use crate::tui::focusable::CURSOR_MARKER;
/// The diff renderer - maintains previous frame and emits minimal ANSI updates.
pub struct Screen {
prev_lines: Vec<String>,
prev_width: u16,
prev_height: u16,
cursor_row: usize,
hardware_cursor_row: usize,
prev_viewport_top: usize,
max_lines_rendered: usize,
full_redraw_count: usize,
clear_on_shrink: bool,
/// Whether to use synchronized output markers (\x1b[?2026h / \x1b[?2026l).
/// Enabled by default (matching pi) to prevent flicker during differential renders.
use_sync_output: bool,
}
impl Screen {
pub fn new() -> Self {
Self {
prev_lines: Vec::new(),
prev_width: 0,
prev_height: 0,
cursor_row: 0,
hardware_cursor_row: 0,
prev_viewport_top: 0,
max_lines_rendered: 0,
full_redraw_count: 0,
clear_on_shrink: true,
use_sync_output: true,
}
}
/// Viewport top position (first visible line in terminal)
pub fn prev_viewport_top(&self) -> usize {
self.prev_viewport_top
}
/// The current hardware cursor row tracking.
pub fn hardware_cursor_row(&self) -> usize {
self.hardware_cursor_row
}
/// Update the hardware cursor row after TUI repositions the cursor.
/// This keeps Screen's delta calculations in sync with the actual cursor position.
pub fn set_hardware_cursor_row(&mut self, row: usize) {
self.hardware_cursor_row = row;
}
pub fn prev_width(&self) -> usize {
self.prev_width as usize
}
pub fn prev_height(&self) -> usize {
self.prev_height as usize
}
pub fn full_redraw_count(&self) -> usize {
self.full_redraw_count
}
/// Total number of lines in the last rendered frame.
pub fn total_lines(&self) -> usize {
self.prev_lines.len()
}
/// Move cursor to one line past all rendered content (for clean program exit).
/// Writes the ANSI cursor-positioning sequences and `\r\n` so that subsequent
/// shell output appears on a fresh line after all TUI content.
pub fn finalize(&mut self, writer: &mut dyn Write) -> io::Result<()> {
if self.prev_lines.is_empty() {
return Ok(());
}
let target_row = self.prev_lines.len(); // one past the last content line
let line_diff = target_row as i64 - self.hardware_cursor_row as i64;
let mut buf = String::new();
if line_diff > 0 {
buf.push_str(&format!("\x1b[{}B", line_diff));
} else if line_diff < 0 {
buf.push_str(&format!("\x1b[{}A", -line_diff));
}
buf.push_str("\r\n");
write!(writer, "{}", buf)?;
writer.flush()?;
Ok(())
}
pub fn set_clear_on_shrink(&mut self, enabled: bool) {
self.clear_on_shrink = enabled;
}
/// Enable or disable synchronized output markers (\x1b[?2026h / \x1b[?2026l).
/// Enabled by default (matching pi's always-on approach).
pub fn set_use_sync_output(&mut self, enabled: bool) {
self.use_sync_output = enabled;
}
/// Emit synchronized output begin marker if enabled.
fn sync_begin(&self, buf: &mut String) {
if self.use_sync_output {
buf.push_str("\x1b[?2026h");
}
}
/// Emit synchronized output end marker if enabled.
fn sync_end(&self, buf: &mut String) {
if self.use_sync_output {
buf.push_str("\x1b[?2026l");
}
}
fn full_render(
&mut self,
lines: &[String],
w: &mut dyn Write,
clear: bool,
width: usize,
height: usize,
) -> io::Result<()> {
self.full_redraw_count += 1;
let mut buf = String::new();
if clear {
buf.push_str("\x1b[2J\x1b[H\x1b[3J");
}
if lines.is_empty() {
self.sync_begin(&mut buf);
self.sync_end(&mut buf);
write!(w, "{}", buf)?;
w.flush()?;
self.cursor_row = 0;
self.hardware_cursor_row = 0;
self.max_lines_rendered = 0;
self.prev_viewport_top = 0;
self.prev_lines = lines.to_vec();
self.prev_width = width as u16;
self.prev_height = height as u16;
return Ok(());
}
self.sync_begin(&mut buf);
for (i, line) in lines.iter().enumerate() {
if i > 0 {
buf.push_str("\r\n");
}
buf.push_str(line);
}
self.sync_end(&mut buf);
write!(w, "{}", buf)?;
w.flush()?;
self.cursor_row = lines.len().saturating_sub(1);
self.hardware_cursor_row = self.cursor_row;
if clear {
self.max_lines_rendered = lines.len();
} else {
self.max_lines_rendered = self.max_lines_rendered.max(lines.len());
}
let buffer_len = height.max(lines.len());
self.prev_viewport_top = buffer_len.saturating_sub(height);
self.prev_lines = lines.to_vec();
self.prev_width = width as u16;
self.prev_height = height as u16;
Ok(())
}
/// Render new lines to the terminal using differential updates.
/// `writer` should be the terminal's stdout (in raw mode).
/// `width` and `height` are the current terminal dimensions.
pub fn render(
&mut self,
new_lines: Vec<String>,
width: u16,
height: u16,
writer: &mut dyn Write,
) -> io::Result<()> {
let width_usize = width as usize;
let height_usize = height as usize;
let width_changed = self.prev_width != 0 && self.prev_width as usize != width_usize;
let height_changed = self.prev_height != 0 && self.prev_height as usize != height_usize;
let prev_buffer_len = if self.prev_height > 0 {
self.prev_viewport_top + self.prev_height as usize
} else {
height_usize
};
let prev_viewport_top = if height_changed {
prev_buffer_len.saturating_sub(height_usize)
} else {
self.prev_viewport_top
};
let mut viewport_top = prev_viewport_top;
// First render - output everything without clearing (assumes clean screen)
if self.prev_lines.is_empty() && !width_changed && !height_changed {
return self.full_render(&new_lines, writer, false, width_usize, height_usize);
}
// Width/height changes need a full redraw
if width_changed || height_changed {
return self.full_render(&new_lines, writer, true, width_usize, height_usize);
}
// Content shrunk - full redraw to clear empty rows
if self.clear_on_shrink && new_lines.len() < self.max_lines_rendered {
return self.full_render(&new_lines, writer, true, width_usize, height_usize);
}
// Find changed range
let mut first_changed: i32 = -1;
let mut last_changed: i32 = -1;
let max_lines = new_lines.len().max(self.prev_lines.len());
for i in 0..max_lines {
let old = if i < self.prev_lines.len() {
&self.prev_lines[i]
} else {
""
};
let new = if i < new_lines.len() {
&new_lines[i]
} else {
""
};
if old != new {
if first_changed == -1 {
first_changed = i as i32;
}
last_changed = i as i32;
}
}
let appended = new_lines.len() > self.prev_lines.len();
if appended && first_changed == -1 {
first_changed = self.prev_lines.len() as i32;
last_changed = new_lines.len() as i32 - 1;
}
// No changes
if first_changed == -1 {
self.prev_height = height_usize as u16;
self.prev_viewport_top = prev_viewport_top;
return Ok(());
}
// All changes are in deleted lines
let first = first_changed as usize;
let last = last_changed as usize;
if first >= new_lines.len() {
let mut buf = String::new();
// Move cursor to end of new content
let target_row = new_lines.len().saturating_sub(1);
let line_diff = if target_row >= prev_viewport_top {
(target_row - prev_viewport_top) as i32
- (self.hardware_cursor_row.saturating_sub(prev_viewport_top)) as i32
} else {
// Target is above viewport - need full redraw
return self.full_render(&new_lines, writer, true, width_usize, height_usize);
};
self.sync_begin(&mut buf);
if line_diff > 0 {
buf.push_str(&format!("\x1b[{}B", line_diff));
} else if line_diff < 0 {
buf.push_str(&format!("\x1b[{}A", -line_diff));
}
buf.push('\r');
// Clear extra lines
let extra = self.prev_lines.len().saturating_sub(new_lines.len());
if extra > height_usize {
return self.full_render(&new_lines, writer, true, width_usize, height_usize);
}
if extra > 0 && !new_lines.is_empty() {
buf.push_str("\x1b[1B");
}
for i in 0..extra {
buf.push_str("\r\x1b[2K");
if i + 1 < extra {
buf.push_str("\x1b[1B");
}
}
let move_back = extra.saturating_sub(1) + if new_lines.is_empty() { 0 } else { 1 };
if move_back > 0 {
buf.push_str(&format!("\x1b[{}A", move_back));
}
self.sync_end(&mut buf);
write!(writer, "{}", buf)?;
writer.flush()?;
self.cursor_row = target_row;
self.hardware_cursor_row = target_row;
self.prev_lines = new_lines;
self.prev_viewport_top = prev_viewport_top;
self.prev_height = height_usize as u16;
return Ok(());
}
// First changed line is above viewport - need full redraw
if first < prev_viewport_top {
return self.full_render(&new_lines, writer, true, width_usize, height_usize);
}
// Differential render: update changed lines in place
let mut buf = String::new();
self.sync_begin(&mut buf);
let move_target = if appended && first == self.prev_lines.len() && first > 0 {
first - 1
} else {
first
};
// Handle scrolling if needed
let prev_viewport_bottom = prev_viewport_top + height_usize - 1;
if move_target > prev_viewport_bottom {
let scroll = move_target - prev_viewport_bottom;
// Move to bottom of screen
let current_screen_row =
(self.hardware_cursor_row.saturating_sub(prev_viewport_top)).min(height_usize - 1);
let to_bottom = height_usize - 1 - current_screen_row;
if to_bottom > 0 {
buf.push_str(&format!("\x1b[{}B", to_bottom));
}
// Scroll
for _ in 0..scroll {
buf.push_str("\r\n");
}
self.hardware_cursor_row = move_target;
// Advance viewport_top to reflect the scroll (lines scrolled off top)
viewport_top += scroll;
}
// Move to first changed line
// Use viewport_top (potentially updated by scroll) for both calculations
// so they stay consistent even after content scrolled below viewport.
let current_screen_row = self.hardware_cursor_row.saturating_sub(viewport_top);
let target_screen_row = move_target.saturating_sub(viewport_top);
let line_diff = target_screen_row as i32 - current_screen_row as i32;
if line_diff > 0 {
buf.push_str(&format!("\x1b[{}B", line_diff));
} else if line_diff < 0 {
buf.push_str(&format!("\x1b[{}A", -line_diff));
}
if appended && first == self.prev_lines.len() {
buf.push_str("\r\n");
} else {
buf.push('\r');
}
// Write changed lines
let mut render_end = last.min(new_lines.len() - 1);
for (i, line) in new_lines
.iter()
.enumerate()
.skip(first)
.take(render_end + 1 - first)
{
if i > first {
buf.push_str("\r\n");
}
// Extract cursor marker if present
let line_without_marker = if line.contains(CURSOR_MARKER) {
line.replace(CURSOR_MARKER, "")
} else {
line.clone()
};
buf.push_str("\x1b[2K"); // clear line
buf.push_str(&line_without_marker);
}
// Clear any trailing old lines beyond the new content.
// This is needed when content shrinks (e.g. autocomplete list narrows)
// and clear_on_shrink is disabled (the app sets it to false to avoid
// full redraws during streaming).
if new_lines.len() < self.prev_lines.len() {
let extra = self.prev_lines.len() - new_lines.len();
if extra > height_usize {
// Too many extra lines - fall back to full redraw
self.sync_end(&mut buf);
write!(writer, "{}", buf)?;
writer.flush()?;
return self.full_render(&new_lines, writer, true, width_usize, height_usize);
}
// Move from render_end to the first extra line = new_lines.len()
let move_to_first_extra = new_lines.len() - render_end;
if move_to_first_extra > 0 {
buf.push_str(&format!("\x1b[{}B", move_to_first_extra));
}
// Clear each extra line
for i in 0..extra {
buf.push_str("\r\x1b[2K");
if i + 1 < extra {
buf.push_str("\x1b[1B");
}
}
// Move cursor back to new_lines.len() - 1 (end of new content).
// After the last clear, cursor is at prev_lines.len() - 1.
// Set render_end to final cursor position since we're moving there.
if extra > 0 {
buf.push_str(&format!("\x1b[{}A", extra));
render_end = new_lines.len().saturating_sub(1);
}
}
self.sync_end(&mut buf);
write!(writer, "{}", buf)?;
writer.flush()?;
self.cursor_row = new_lines.len().saturating_sub(1);
self.hardware_cursor_row = render_end;
self.max_lines_rendered = self.max_lines_rendered.max(new_lines.len());
self.prev_lines = new_lines;
// Advance viewport_top if cursor ended up below the viewport
// (matching pi's Math.max(prevViewportTop, finalCursorRow - height + 1)).
self.prev_viewport_top = viewport_top.max(render_end.saturating_sub(height_usize - 1));
self.prev_height = height_usize as u16;
self.prev_width = width_usize as u16;
Ok(())
}
}
impl Default for Screen {
fn default() -> Self {
Self::new()
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_new_screen() {
let screen = Screen::new();
assert_eq!(screen.full_redraw_count(), 0);
}
#[test]
fn test_clear_on_shrink_default() {
let screen = Screen::new();
assert!(screen.clear_on_shrink);
}
#[test]
fn test_first_render() {
let mut screen = Screen::new();
let lines = vec!["hello".to_string(), "world".to_string()];
let mut output = Vec::new();
screen.render(lines.clone(), 80, 24, &mut output).unwrap();
let output_str = String::from_utf8(output).unwrap();
assert!(output_str.contains("hello"));
assert!(output_str.contains("world"));
}
#[test]
fn test_differential_update() {
let mut screen = Screen::new();
let mut output = Vec::new();
// First render
let lines1 = vec!["hello".to_string(), "world".to_string()];
screen.render(lines1.clone(), 80, 24, &mut output).unwrap();
output.clear();
// Second render with same content - no output
screen.render(lines1.clone(), 80, 24, &mut output).unwrap();
assert!(output.is_empty());
// Third render with changed content
let lines2 = vec!["hello".to_string(), "rust".to_string()];
screen.render(lines2.clone(), 80, 24, &mut output).unwrap();
let output_str = String::from_utf8(output.clone()).unwrap();
assert!(output_str.contains("rust"));
}
#[test]
fn test_type_character_single_line_change() {
let mut screen = Screen::new();
let mut output = Vec::new();
// Simulate compose_ui: 12 lines, editor content at index 7
let mut initial: Vec<String> = Vec::new();
for i in 0..12 {
initial.push(format!("line {:02}", i));
}
screen.render(initial.clone(), 40, 24, &mut output).unwrap();
output.clear();
// Type "/" - only index 7 changes
let mut after = initial.clone();
after[7] = "line 07/".to_string();
screen.render(after, 40, 24, &mut output).unwrap();
let text = String::from_utf8_lossy(&output);
// Should contain the changed text
assert!(
text.contains("line 07/"),
"Missing changed text in: {}",
text
);
// Should NOT do a full clear
assert!(
!text.contains("\x1b[2J"),
"Should not full-clear on single line change"
);
}
#[test]
fn test_screen_append_no_duplicate_content() {
let mut screen = Screen::new();
let mut output = Vec::new();
// First frame: 4 lines
let frame1 = vec!["a", "b", "c", "d"]
.into_iter()
.map(String::from)
.collect::<Vec<_>>();
screen.render(frame1, 40, 24, &mut output).unwrap();
output.clear();
// Second frame: content appended at end (exactly prev_lines.len())
let frame2 = vec!["a", "b", "c", "d", "e"]
.into_iter()
.map(String::from)
.collect::<Vec<_>>();
screen.render(frame2, 40, 24, &mut output).unwrap();
let content = String::from_utf8_lossy(&output);
eprintln!("Append-only diff output: {:?}", content);
// The diff output should only contain the new line "e" plus ANSI codes
// It must not repeat any of the unchanged lines ("a", "b", "c", "d")
let counts = ["a", "b", "c", "d"];
for &ch in &counts {
let n = content.matches(ch).count();
assert!(
n <= 1,
"'{}' should appear at most once in diff, got {}: {:?}",
ch,
n,
content
);
}
// "e" must appear exactly once
let e_count = content.matches('e').count();
assert_eq!(
e_count, 1,
"'e' should appear exactly once, got {}",
e_count
);
}
#[test]
fn test_screen_insert_line_mid_content_no_duplicates() {
let mut screen = Screen::new();
let mut output = Vec::new();
// First frame: 3 lines
let frame1 = vec!["a", "c", "d"]
.into_iter()
.map(String::from)
.collect::<Vec<_>>();
screen.render(frame1, 40, 24, &mut output).unwrap();
output.clear();
// Second frame: "b" inserted between "a" and "c"
let frame2 = vec!["a", "b", "c", "d"]
.into_iter()
.map(String::from)
.collect::<Vec<_>>();
screen.render(frame2, 40, 24, &mut output).unwrap();
let content = String::from_utf8_lossy(&output);
eprintln!("Insert-mid diff output: {:?}", content);
// "a" should appear at most once (unchanged line shouldn't be re-written)
assert!(
content.matches('a').count() <= 1,
"'a' should appear at most once: {:?}",
content
);
// "b", "c", "d" should appear (changed/new lines)
assert!(content.contains('b'), "Should contain 'b'");
assert!(content.contains('c'), "Should contain 'c'");
assert!(content.contains('d'), "Should contain 'd'");
}
#[test]
fn test_screen_editor_appended_empty_line_no_duplicate() {
// Simulates pressing Ctrl+J on "hello" → "hello\n"
// Editor renders change from 3 lines to 4 lines:
// [border, "hello", border] → [border, "hello", "", border]
let mut screen = Screen::new();
let mut output = Vec::new();
let frame1 = vec![
"header".to_string(),
"── editor border ──".to_string(),
"hello".to_string(),
"── editor border ──".to_string(),
"footer".to_string(),
];
screen.render(frame1, 30, 24, &mut output).unwrap();
output.clear();
// After Ctrl+J: "hello" → "hello\n"
let frame2 = vec![
"header".to_string(),
"── editor border ──".to_string(),
"hello".to_string(),
"".to_string(), // new empty line
"── editor border ──".to_string(),
"footer".to_string(),
];
screen.render(frame2, 30, 24, &mut output).unwrap();
let content = String::from_utf8_lossy(&output);
eprintln!("Editor append empty line diff: {:?}", content);
// "hello" should NOT be in the diff output (it didn't change)
let hello_count = content.matches("hello").count();
assert!(
hello_count <= 1,
"'hello' should appear at most once in diff, got {}: {:?}",
hello_count,
content
);
// "footer" should NOT be duplicated (it just shifted down, should appear once)
let footer_count = content.matches("footer").count();
assert!(
footer_count <= 1,
"'footer' should appear at most once in diff, got {}: {:?}",
footer_count,
content
);
}
#[test]
fn test_screen_wrapping_no_overwrite_of_unchanged_line() {
// Reproduces the exact bug: when text wraps in the editor, Screen's
// hardware_cursor_row is out of sync with the actual cursor position.
// This causes subsequent diffs to write on the wrong line, overwriting
// the first content line with the second content line's text.
let mut screen = Screen::new();
let mut output = Vec::new();
// Frame 1: editor with "hello world" (fits in 1 line at this width)
let frame1 = vec![
"──── editor ────".to_string(),
" hello world ".to_string(), // content, cursor at end
"──── editor ────".to_string(),
];
screen.render(frame1.clone(), 18, 24, &mut output).unwrap();
output.clear();
// Simulate TUI extracting cursor marker and repositioning hardware cursor.
// Cursor is on line 1 (content line). Screen's hardware_cursor_row=2 (bottom border).
// Call set_hardware_cursor_row to simulate the fix:
screen.set_hardware_cursor_row(1);
// Frame 2: text wraps to 2 content lines (e.g. "hello world is" at width 14)
// "hello world is" wraps to ["hello world", "is"]
let frame2 = vec![
"──── editor ────".to_string(),
" hello world ".to_string(), // first wrapped chunk
" is ".to_string(), // second wrapped chunk, cursor here
"──── editor ────".to_string(),
];
screen.render(frame2.clone(), 18, 24, &mut output).unwrap();
eprintln!(
"After wrap diff output: {:?}",
String::from_utf8_lossy(&output)
);
// The diff should NOT write " hello world" again (it's unchanged from frame 1)
let output_str = String::from_utf8_lossy(&output);
// Check that "hello world" (the UNCHANGED first content line)
// does NOT appear in the diff output. It should only appear in the
// full render output, not in a differential update.
let hw_count = output_str.matches("hello world").count();
assert!(
hw_count <= 1,
"'hello world' should appear at most once in diff, got {}: {:?}",
hw_count,
output_str
);
output.clear();
// Simulate TUI: cursor marker is on line 2 (" is" line), reposition cursor.
screen.set_hardware_cursor_row(2);
// Frame 3: user types another char -> " is" -> " iss"
let frame3 = vec![
"──── editor ────".to_string(),
" hello world ".to_string(), // unchanged
" iss ".to_string(), // changed
"──── editor ────".to_string(),
];
screen.render(frame3.clone(), 18, 24, &mut output).unwrap();
let output_str2 = String::from_utf8_lossy(&output);
eprintln!("After typing diff output: {:?}", output_str2);
// " hello world" must NOT appear in this diff - it's unchanged
let hw_count2 = output_str2.matches("hello world").count();
assert!(
hw_count2 <= 1,
"'hello world' should NOT be rewritten in diff, got {}: {:?}",
hw_count2,
output_str2
);
}
#[test]
fn test_screen_wrapping_overwrite_bug_without_fix() {
// SAME as above but WITHOUT calling set_hardware_cursor_row
// Demonstrates the bug: first content line gets overwritten.
let mut screen = Screen::new();
let mut output = Vec::new();
let frame1 = vec![
"──── editor ────".to_string(),
" hello world ".to_string(),
"──── editor ────".to_string(),
];
screen.render(frame1.clone(), 18, 24, &mut output).unwrap();
output.clear();
// WITHOUT the fix - Screen still thinks hardware cursor is at line 2
// (because Screen.render set it there as the last rendered line)
let frame2 = vec![
"──── editor ────".to_string(),
" hello world ".to_string(),
" is ".to_string(),
"──── editor ────".to_string(),
];
screen.render(frame2.clone(), 18, 24, &mut output).unwrap();
let output_str = String::from_utf8_lossy(&output);
eprintln!("Without fix - after wrap: {:?}", output_str);
// The BUG: hardware_cursor_row is 2, but the diff needs to write line 1
// (first changed line). Since cursor is at line 2, diff emits \x1b[1A
// to move up to line 1. But the hardware cursor is actually at line 1
// (TUI already placed it there), so the move-up overshoots to line 0.
// The diff output may write " hello world" at the wrong position.
//
// We can detect the bug by checking if the Screen's internal tracking
// is incorrect after this frame.
//
// After this render, Screen should have hardware_cursor_row = 3 (render_end)
// But the actual terminal cursor ended up at line 2 (the cursor marker position).
// We check that the internal tracking is wrong:
assert_eq!(
screen.hardware_cursor_row(),
3,
"Without fix: hardware_cursor_row should be 3 (bottom border render_end)"
);
output.clear();
// Frame 3: type char on second line
screen.set_hardware_cursor_row(2); // Simulate TUI repositioning (but Screen doesn't know)
let frame3 = vec![
"──── editor ────".to_string(),
" hello world ".to_string(),
" iss ".to_string(),
"──── editor ────".to_string(),
];
screen.render(frame3.clone(), 18, 24, &mut output).unwrap();
let output_str2 = String::from_utf8_lossy(&output);
eprintln!("Without fix - after typing: {:?}", output_str2);
// Without fix: the diff for frame 3 calculates move_target=2, but
// hardware_cursor_row is still 3 (Screen doesn't know TUI moved it).
// current_screen_row=3, target=2, diff=-1 → write on line 1 instead of line 2
// This means " hello world" gets overwritten or " iss" appears on wrong line.
// The bug symptom: " hello world" text would be overwritten.
// We can detect this by checking that the output would corrupt line 1.
// The output should contain " iss" (the changed content).
// But if the bug is present, " iss" gets written on the wrong line.
// The exact assertion depends on terminal state, but the key check:
// "hello world" should NOT be in the diff for frame 3 (unchanged line)
let hw_count = output_str2.matches("hello world").count();
assert!(
hw_count <= 1,
"BUG: 'hello world' appears in frame 3 diff, got {}: {:?}",
hw_count,
output_str2
);
}
}