quorum-cli 0.4.0

Quorum CLI: the quorum binary.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
//! `quorum convention` โ€” Phase 1C Stage 3 read surface.
//!
//! Stage 3 ships `list`, `show`, `history`. The write subcommands
//! (`promote`, `demote`, `prune`) land in Stage 4 and are intentionally
//! absent from the clap surface here โ€” they're cleaner absent than stubbed.

use std::io::Write;
use std::path::{Path, PathBuf};

use quorum_core::conventions::{
    atomic_write, build_block_set, detect_orphans, parse_conventions_md, render_conventions_md,
    BlockSetChange, CanonicalBlock, LineEnding, OrphanReport, ParsedConventionsMd,
};
use quorum_core::memory::{
    DemoteOutcome, Dismissal, LocalSqliteMemoryStore, MemoryStore, PromoteOutcome, PromotionState,
    ShortHashResolution, StateTransitionRow, TransitionTrigger,
};

use crate::exit::{CliError, Exit};

/// Resolve the directory under which `.quorum/` lives. Honors the
/// `--quorum-dir` flag (spec ยง5.1: "all `convention` subcommands honor
/// `--quorum-dir <path>` for tests"). Otherwise it is the working tree of
/// the repository holding the current directory, found as `quorum review`
/// finds it (`Repository::discover`, then `workdir`), so a subdirectory
/// reaches the same store and conventions.md. Outside a repository, or in
/// a bare one, it falls back to the current directory, as before.
fn resolve_quorum_root(quorum_dir: Option<&PathBuf>) -> Result<PathBuf, CliError> {
    if let Some(p) = quorum_dir {
        return Ok(p.clone());
    }
    let cwd = std::env::current_dir().map_err(|e| CliError::Io(e.to_string()))?;
    Ok(git2::Repository::discover(&cwd)
        .ok()
        .and_then(|repo| repo.workdir().map(Path::to_path_buf))
        .unwrap_or(cwd))
}

fn open_store(root: &std::path::Path) -> Result<LocalSqliteMemoryStore, CliError> {
    LocalSqliteMemoryStore::new(root).map_err(|e| CliError::Io(e.to_string()))
}

// ---------------------------------------------------------------------------
// `list`
// ---------------------------------------------------------------------------

pub fn list(
    quorum_dir: Option<&PathBuf>,
    state: Option<PromotionState>,
    orphans: bool,
    json: bool,
) -> Result<Exit, CliError> {
    let root = resolve_quorum_root(quorum_dir)?;
    if orphans {
        return list_orphans(&root, json);
    }
    let store = open_store(&root)?;
    let rows = store
        .list_by_state(state)
        .map_err(|e| CliError::Io(format!("dismissals query failed: {e}")))?;
    if json {
        emit_list_json(&rows);
    } else {
        emit_list_text(&rows);
    }
    Ok(Exit::Ok)
}

/// Stable JSON shape โ€” order: `hash`, `short_hash`, `state`,
/// `recurrence_count`, `title`, `dismissed_at`, `last_seen_at`. Same row
/// order as the default text output so `jq` pipelines are deterministic.
fn emit_list_json(rows: &[Dismissal]) {
    let mut buf = String::from("[");
    for (i, d) in rows.iter().enumerate() {
        if i > 0 {
            buf.push(',');
        }
        let hex = d.finding_identity_hash.to_hex();
        let short = &hex[..12];
        let dismissed = d
            .dismissed_at
            .format(&time::format_description::well_known::Rfc3339)
            .unwrap_or_default();
        let last_seen = d
            .last_seen_at
            .format(&time::format_description::well_known::Rfc3339)
            .unwrap_or_default();
        // Hand-assemble so we never serialise body/note (audit-leak guard
        // โ€” Stage 2 ยง4.6: notes are sensitive and stay off-disk-outside-DB).
        buf.push_str(&format!(
            "{{\"hash\":{},\"short_hash\":{},\"state\":{},\"recurrence_count\":{},\"title\":{},\"dismissed_at\":{},\"last_seen_at\":{}}}",
            json_str(&hex),
            json_str(short),
            json_str(d.promotion_state.as_db_str()),
            d.recurrence_count,
            json_str(&d.title_snapshot),
            json_str(&dismissed),
            json_str(&last_seen),
        ));
    }
    buf.push(']');
    println!("{buf}");
}

fn json_str(s: &str) -> String {
    let mut out = String::with_capacity(s.len() + 2);
    out.push('"');
    for c in s.chars() {
        match c {
            '"' => out.push_str("\\\""),
            '\\' => out.push_str("\\\\"),
            '\n' => out.push_str("\\n"),
            '\r' => out.push_str("\\r"),
            '\t' => out.push_str("\\t"),
            c if (c as u32) < 0x20 => out.push_str(&format!("\\u{:04x}", c as u32)),
            c => out.push(c),
        }
    }
    out.push('"');
    out
}

const TITLE_DISPLAY_WIDTH: usize = 60;

fn emit_list_text(rows: &[Dismissal]) {
    if rows.is_empty() {
        println!("(no dismissals)");
        return;
    }
    println!("{:<12}  {:<20}  {:>5}  TITLE", "HASH", "STATE", "RECUR");
    for d in rows {
        let hex = d.finding_identity_hash.to_hex();
        let short = &hex[..12];
        let title = truncate_for_display(&d.title_snapshot, TITLE_DISPLAY_WIDTH);
        println!(
            "{:<12}  {:<20}  {:>5}  {}",
            short,
            d.promotion_state.as_db_str(),
            d.recurrence_count,
            title
        );
    }
}

fn truncate_for_display(s: &str, max_chars: usize) -> String {
    let mut out = String::new();
    for (n, c) in s.chars().enumerate() {
        if n >= max_chars {
            out.push('โ€ฆ');
            return out;
        }
        out.push(c);
    }
    out
}

// ---------------------------------------------------------------------------
// `--orphans` (AC 169; AC 168 stderr-warning partial)
// ---------------------------------------------------------------------------

fn list_orphans(root: &std::path::Path, json: bool) -> Result<Exit, CliError> {
    let store = open_store(root)?;
    let rows = store
        .list_conventions()
        .map_err(|e| CliError::Io(format!("conventions read failed: {e}")))?;
    let conv_md_path = root.join(".quorum").join("conventions.md");
    let report = detect_orphans(&conv_md_path, &rows);

    // AC 168 partial โ€” emit parser diagnostics as stderr warnings.
    for d in &report.parser_diagnostics {
        eprintln!("warning: {}", format_diagnostic(d));
    }

    if json {
        emit_orphan_report_json(&report);
    } else {
        emit_orphan_report_text(&report);
    }
    Ok(Exit::Ok)
}

pub fn format_diagnostic(d: &quorum_core::conventions::ConventionParseError) -> String {
    use quorum_core::conventions::ConventionParseError::*;
    match d {
        UnclosedBlock { id, start_byte } => format!(
            ".quorum/conventions.md: block id={id} at byte {start_byte} has no closing marker"
        ),
        BadBlockId { raw, start_byte } => {
            format!(".quorum/conventions.md: bad block id {raw:?} at byte {start_byte}")
        }
        BadBlockVersion { raw, start_byte } => {
            format!(".quorum/conventions.md: bad block version {raw:?} at byte {start_byte}")
        }
        DuplicateManagedSection { start_byte } => format!(
            ".quorum/conventions.md: duplicate managed-section marker at byte {start_byte}; \
             only the first section is parsed"
        ),
        UnclosedManagedSection { start_byte } => format!(
            ".quorum/conventions.md: managed-section marker at byte {start_byte} has no closing \
             marker; the section is ignored"
        ),
        UnopenedManagedSection { start_byte } => format!(
            ".quorum/conventions.md: managed-section closing marker at byte {start_byte} has no \
             opening marker line; the section is ignored"
        ),
    }
}

fn emit_orphan_report_text(report: &OrphanReport) {
    if report.file_missing {
        println!("(.quorum/conventions.md not found)");
    } else if report.fence_absent {
        println!("(no quorum-managed-section in .quorum/conventions.md)");
    }
    if report.file_orphans.is_empty() && report.db_orphans.is_empty() {
        if !report.file_missing && !report.fence_absent {
            println!("(no orphans)");
        }
        return;
    }
    if !report.file_orphans.is_empty() {
        println!("file orphans (block in conventions.md, no SQLite row):");
        for o in &report.file_orphans {
            let header = if o.header_line.is_empty() {
                "(no header)"
            } else {
                &o.header_line
            };
            println!("  {}  {}", o.id, header);
        }
    }
    if !report.db_orphans.is_empty() {
        println!("db orphans (SQLite row, no block in conventions.md):");
        for o in &report.db_orphans {
            println!("  {}  {}", o.conventions_md_block_id, o.title_snapshot);
        }
    }
}

fn emit_orphan_report_json(report: &OrphanReport) {
    let mut buf = String::new();
    buf.push('{');
    buf.push_str(&format!("\"file_missing\":{},", report.file_missing));
    buf.push_str(&format!("\"fence_absent\":{},", report.fence_absent));
    buf.push_str("\"file_orphans\":[");
    for (i, o) in report.file_orphans.iter().enumerate() {
        if i > 0 {
            buf.push(',');
        }
        buf.push_str(&format!(
            "{{\"id\":{},\"header_line\":{},\"byte_start\":{},\"byte_end\":{}}}",
            json_str(&o.id),
            json_str(&o.header_line),
            o.byte_range_in_file.start,
            o.byte_range_in_file.end
        ));
    }
    buf.push_str("],\"db_orphans\":[");
    for (i, o) in report.db_orphans.iter().enumerate() {
        if i > 0 {
            buf.push(',');
        }
        buf.push_str(&format!(
            "{{\"hash\":{},\"conventions_md_block_id\":{},\"title\":{}}}",
            json_str(&o.finding_identity_hash_hex),
            json_str(&o.conventions_md_block_id),
            json_str(&o.title_snapshot)
        ));
    }
    buf.push_str("]}");
    println!("{buf}");
}

// ---------------------------------------------------------------------------
// Short-hash resolution helper (WI-5; AC 163).
// ---------------------------------------------------------------------------

const MIN_SHORT_HASH_LEN: usize = 8;

/// Resolve a hex-prefix CLI argument to a single dismissal row, or emit a
/// `CliError::Config` (exit 2) with a precise diagnostic on rejection /
/// ambiguity / not-found. Pure presentation concern โ€” wraps
/// `MemoryStore::find_by_short_hash`. Stage 4 will re-use this helper for
/// `promote` / `demote`.
pub fn resolve_short_hash(
    store: &LocalSqliteMemoryStore,
    prefix: &str,
) -> Result<Dismissal, CliError> {
    if prefix.len() < MIN_SHORT_HASH_LEN {
        return Err(CliError::Config(format!(
            "short-hash must be โ‰ฅ {} hex chars, got {}",
            MIN_SHORT_HASH_LEN,
            prefix.len()
        )));
    }
    if !prefix
        .bytes()
        .all(|b| matches!(b, b'0'..=b'9' | b'a'..=b'f'))
    {
        return Err(CliError::Config(format!(
            "short-hash must be lowercase hex, got '{prefix}'"
        )));
    }
    match store
        .find_by_short_hash(prefix)
        .map_err(|e| CliError::Io(format!("short-hash lookup failed: {e}")))?
    {
        ShortHashResolution::Exact(d) => Ok(*d),
        ShortHashResolution::NotFound => {
            Err(CliError::Config(format!("no dismissal matches '{prefix}'")))
        }
        ShortHashResolution::Ambiguous(matches) => {
            let mut msg = format!("short-hash '{prefix}' is ambiguous; matches:\n");
            let shown = matches.iter().take(10);
            for d in shown {
                let hex = d.finding_identity_hash.to_hex();
                msg.push_str(&format!(
                    "  {}  {}\n",
                    &hex[..12],
                    truncate_for_display(&d.title_snapshot, TITLE_DISPLAY_WIDTH)
                ));
            }
            if matches.len() > 10 {
                msg.push_str(&format!("  ... and {} more\n", matches.len() - 10));
            }
            msg.pop(); // strip trailing newline so CliError display is tidy
            Err(CliError::Config(msg))
        }
    }
}

// ---------------------------------------------------------------------------
// `show <hash>` / `history <hash>` (WI-6).
// ---------------------------------------------------------------------------

pub fn show(quorum_dir: Option<&PathBuf>, hash_prefix: &str) -> Result<Exit, CliError> {
    let root = resolve_quorum_root(quorum_dir)?;
    let store = open_store(&root)?;
    let row = resolve_short_hash(&store, hash_prefix)?;
    let transitions = store
        .load_transitions(&row.finding_identity_hash)
        .map_err(|e| CliError::Io(format!("transition log read: {e}")))?;
    emit_show(&row, &transitions);
    Ok(Exit::Ok)
}

pub fn history(quorum_dir: Option<&PathBuf>, hash_prefix: &str) -> Result<Exit, CliError> {
    let root = resolve_quorum_root(quorum_dir)?;
    let store = open_store(&root)?;
    let row = resolve_short_hash(&store, hash_prefix)?;
    let transitions = store
        .load_transitions(&row.finding_identity_hash)
        .map_err(|e| CliError::Io(format!("transition log read: {e}")))?;
    emit_history(&transitions, row.promotion_state);
    Ok(Exit::Ok)
}

fn emit_show(row: &Dismissal, transitions: &[StateTransitionRow]) {
    let hex = row.finding_identity_hash.to_hex();
    let short = &hex[..12];
    println!("hash:        {hex}");
    println!("short-hash:  {short}");
    println!("title:       {}", row.title_snapshot);
    match &row.body_snapshot {
        Some(b) if !b.is_empty() => println!("body:        {b}"),
        _ => println!("body:        <no body snapshot>"),
    }
    println!("state:       {}", row.promotion_state.as_db_str());
    println!("recurrence:  {}", row.recurrence_count);
    let first_seen = row
        .dismissed_at
        .format(&time::format_description::well_known::Rfc3339)
        .unwrap_or_default();
    let last_seen = row
        .last_seen_at
        .format(&time::format_description::well_known::Rfc3339)
        .unwrap_or_default();
    println!("first-seen:  {first_seen}");
    println!("last-seen:   {last_seen}");
    println!();
    println!("transitions:");
    emit_history(transitions, row.promotion_state);
}

fn emit_history(transitions: &[StateTransitionRow], current_state: PromotionState) {
    if transitions.is_empty() {
        // Distinguish a fresh v2 candidate row (initial state โ€” no
        // transition row is ever written when entering `candidate`) from
        // a row whose state advanced past candidate without leaving a
        // transition trail (only possible for pre-v2 rows migrated under
        // the schema v2 epoch). BUG 3 fix: the old code reported every
        // empty-transitions row as "predates schema v2", which is
        // misleading on the most common case (fresh v2 candidates).
        if current_state == PromotionState::Candidate {
            println!("(no transitions yet โ€” dismissal is in initial state)");
        } else {
            println!("(no transition history โ€” dismissal predates schema v2)");
        }
        return;
    }
    for t in transitions {
        let ts = format_ts_ms(t.ts_ms);
        let rec = t
            .recurrence_at_transition
            .map(|n| format!(" (recurrence={n} at transition)"))
            .unwrap_or_default();
        println!(
            "  {ts}  {} โ†’ {}  via {}{}",
            t.from_state.as_db_str(),
            t.to_state.as_db_str(),
            trigger_label(t.trigger),
            rec
        );
    }
}

fn trigger_label(t: TransitionTrigger) -> &'static str {
    t.as_db_str()
}

fn format_ts_ms(ms: i64) -> String {
    // `ms` is unix epoch millis. Render in ISO-8601 UTC for human read.
    let secs = ms / 1000;
    let nanos = ((ms % 1000) * 1_000_000) as i128;
    let dt =
        time::OffsetDateTime::from_unix_timestamp_nanos((secs as i128) * 1_000_000_000 + nanos)
            .unwrap_or(time::OffsetDateTime::UNIX_EPOCH);
    dt.format(&time::format_description::well_known::Rfc3339)
        .unwrap_or_else(|_| format!("{ms}ms"))
}

// ---------------------------------------------------------------------------
// Stage 4 write surface: `promote`, `demote`, `prune` (AC 137/139/140/141/142).
// ---------------------------------------------------------------------------

/// Source for `quorum convention promote --text` / `--from-editor` /
/// (neither). Title-only promote (ยง4.4: no auto-body from `body_snapshot`)
/// is `BodySource::TitleOnly`.
#[derive(Debug, Clone)]
pub enum BodySource {
    /// `--text "<s>"`: use the supplied string verbatim.
    Text(String),
    /// `--from-editor`: spawn `$EDITOR` (test seam: `QUORUM_TEST_EDITOR_BODY`
    /// env var overrides the spawn and supplies the body directly).
    FromEditor,
    /// Neither flag โ€” block carries only the title-derived `### Convention: โ€ฆ`
    /// header line; no body paragraph (ยง4.4, AC 139).
    TitleOnly,
}

/// Test-only env var for hermetic `--from-editor` coverage. When set,
/// supplies the body directly instead of spawning `$EDITOR`. Documented
/// inline so close-report readers see the seam choice.
const TEST_EDITOR_BODY_ENV: &str = "QUORUM_TEST_EDITOR_BODY";

/// Resolve a `BodySource` into the body string actually written to the
/// managed block. `TitleOnly` produces an empty body; `Text(s)` returns `s`
/// directly; `FromEditor` consults `QUORUM_TEST_EDITOR_BODY` (test seam)
/// then falls back to spawning `$EDITOR` on a temp template.
fn resolve_body(src: &BodySource, title: &str, quorum_dir: &Path) -> Result<String, CliError> {
    match src {
        BodySource::TitleOnly => Ok(String::new()),
        BodySource::Text(s) => {
            if s.is_empty() {
                return Err(CliError::Config(
                    "--text value is empty; pass --text \"<body>\" or omit --text for a \
                     title-only block"
                        .into(),
                ));
            }
            Ok(s.clone())
        }
        BodySource::FromEditor => {
            // Hermetic test seam.
            if let Ok(canned) = std::env::var(TEST_EDITOR_BODY_ENV) {
                if canned.trim().is_empty() {
                    return Err(CliError::Config(
                        "$QUORUM_TEST_EDITOR_BODY produced empty body".into(),
                    ));
                }
                return Ok(canned);
            }
            spawn_editor_for_body(title, quorum_dir)
        }
    }
}

fn spawn_editor_for_body(title: &str, quorum_dir: &Path) -> Result<String, CliError> {
    let editor = std::env::var("EDITOR").map_err(|_| {
        CliError::Config(
            "$EDITOR not set; cannot launch editor for --from-editor. Set EDITOR or use \
             --text \"<body>\" instead."
                .into(),
        )
    })?;
    let dir = quorum_dir.join(".quorum");
    std::fs::create_dir_all(&dir).map_err(|e| CliError::Io(e.to_string()))?;
    let template_path = dir.join(format!(
        ".convention_edit.{}.{}.md",
        std::process::id(),
        std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .map(|d| d.as_nanos())
            .unwrap_or(0)
    ));
    // Template: a comment header + a blank line for the user to type the
    // body into. The title-derived comment line is stripped on read so
    // it doesn't leak into the committed block.
    let template = format!(
        "# Title: {title}\n# Lines starting with '#' will be ignored.\n# Enter the convention body below this line; save and exit.\n\n"
    );
    std::fs::write(&template_path, &template).map_err(|e| CliError::Io(e.to_string()))?;

    let status = std::process::Command::new(&editor)
        .arg(&template_path)
        .status()
        .map_err(|e| CliError::Io(format!("could not spawn $EDITOR={editor}: {e}")))?;
    if !status.success() {
        let _ = std::fs::remove_file(&template_path);
        return Err(CliError::Config(format!(
            "$EDITOR exited with status {status:?}; aborting promote"
        )));
    }
    let content =
        std::fs::read_to_string(&template_path).map_err(|e| CliError::Io(e.to_string()))?;
    let _ = std::fs::remove_file(&template_path);
    let body = strip_editor_comment_lines(&content);
    if body.trim().is_empty() {
        return Err(CliError::Config(
            "editor produced empty body; aborting promote".into(),
        ));
    }
    Ok(body)
}

fn strip_editor_comment_lines(content: &str) -> String {
    content
        .lines()
        .filter(|l| !l.trim_start().starts_with('#'))
        .collect::<Vec<_>>()
        .join("\n")
        .trim()
        .to_string()
}

/// Promote a dismissal from `local_only` to `promoted_convention` (T2).
/// File-then-SQLite ordering per spec ยง3.2 T2 + dispatch ยง2 (B5).
pub fn promote(
    quorum_dir: Option<&PathBuf>,
    hash_prefix: &str,
    body_source: BodySource,
) -> Result<Exit, CliError> {
    let root = resolve_quorum_root(quorum_dir)?;
    let store = open_store(&root)?;
    let row = resolve_short_hash(&store, hash_prefix)?;

    // 1. State guard: only local_only promotes (spec ยง3.2 T2 + AC 137).
    let hex = row.finding_identity_hash.to_hex();
    let short_hash = &hex[..12];
    match row.promotion_state {
        PromotionState::Candidate => {
            return Err(CliError::Config(format!(
                "{short_hash} is still a candidate (recurrence={n}); dismissed too few times to \
                 promote โ€” wait for auto-promote after the next dismissal",
                n = row.recurrence_count
            )));
        }
        PromotionState::PromotedConvention => {
            return Err(CliError::Config(format!(
                "{short_hash} is already a promoted_convention; run \
                 `quorum convention demote {short_hash}` first to update its text"
            )));
        }
        PromotionState::LocalOnly => { /* fall through */ }
    }

    // 2. Body resolution (--text / --from-editor / title-only).
    let body = resolve_body(&body_source, &row.title_snapshot, &root)?;
    // DL 2.4: take the store's write lock before reading conventions.md and
    // hold it through the rename to the commit, so a concurrent promote or
    // demote waits instead of rendering from the same read. Taken after
    // the body, which may wait on $EDITOR.
    let lock = store
        .begin_convention_write()
        .map_err(|e| CliError::Io(format!("lock the dismissals store: {e}")))?;

    // 3. Pre-flight on conventions.md: refuse a broken structure before
    //    anything is written (a rewrite would delete the text the parser
    //    lost track of, and there is deliberately no override), then
    //    surface orphan drift via stderr (AC 168 promote-side closure).
    let conv_path = root.join(".quorum").join("conventions.md");
    let existing_bytes = match std::fs::read(&conv_path) {
        Ok(b) => b,
        Err(e) if e.kind() == std::io::ErrorKind::NotFound => Vec::new(),
        Err(e) => return Err(CliError::Io(format!("read {conv_path:?}: {e}"))),
    };
    let le = LineEnding::detect(&existing_bytes);
    quorum_core::conventions::check_writable(&conv_path, &existing_bytes)
        .map_err(|r| CliError::Config(r.to_string()))?;
    let (parsed, _) = parse_conventions_md(&existing_bytes);
    preflight_dirty_warning(&store, &parsed)?;

    // 4. Build the new block set. Idempotent re-promote: if a block for
    //    this hash already exists in the file (file-ahead-of-SQLite
    //    recovery), it is replaced; otherwise the new block is appended.
    //    Every other block is kept byte for byte, whatever its layout.
    let title_for_block = &row.title_snapshot;
    let block_id: String = hex[..12].to_string();
    let to_write = build_block_set(
        &parsed,
        BlockSetChange::Promote(CanonicalBlock {
            id: &block_id,
            version: 1,
            title: title_for_block,
            body: &body,
        }),
    );

    // 5. Render bytes + atomic_write. File-first-rename, then SQLite.
    let new_bytes = render_conventions_md(&parsed, &to_write, le);
    std::fs::create_dir_all(root.join(".quorum")).map_err(|e| CliError::Io(e.to_string()))?;
    atomic_write(&conv_path, &new_bytes).map_err(|e| CliError::Io(e.to_string()))?;

    // 6. AC 175 test seam โ€” panic harness fires between rename and COMMIT.
    // The seam is a no-op in production (the AtomicBool is always false
    // unless a test sets it). See `stage4_test_seam` for context.
    quorum_core::conventions::stage4_test_seam::maybe_panic_after_rename();

    // 7. SQLite-side commit.
    //    Title-only resolution: when `body` is empty (title-only block per
    //    ยง4.4), the `conventions.convention_text` CHECK demands โ‰ฅ 1 byte.
    //    Spec ยง4.4 is silent on what to store in this case; resolution per
    //    dispatch ยง2 halt-threshold-2 (obvious-from-context): store the
    //    title verbatim so the SQLite row carries the canonical
    //    convention text. Surfaced in the Stage 4 close report.
    let convention_text_for_db: &str = if body.is_empty() {
        title_for_block
    } else {
        body.as_str()
    };
    let ts_ms = current_unix_millis();
    let outcome = lock
        .commit_promote(
            &row.finding_identity_hash,
            convention_text_for_db,
            &block_id,
            ts_ms,
        )
        .map_err(|e| CliError::Io(format!("commit_promote: {e}")))?;
    match outcome {
        PromoteOutcome::Committed => {
            println!(
                "promoted {short_hash} to convention: {title}",
                title = row.title_snapshot
            );
            eprintln!(
                "note: commit .quorum/conventions.md to move it from the memory section to the \
                 conventions section"
            );
            Ok(Exit::Ok)
        }
        PromoteOutcome::StateDrifted => Err(CliError::Config(format!(
            "{short_hash}: SQLite state was not local_only at COMMIT time (concurrent writer \
             or state drift); file write happened but DB did not advance. Re-run \
             `quorum convention promote {short_hash}` after `list --orphans` reconciliation."
        ))),
    }
}

/// Demote a dismissal from `promoted_convention` to `local_only` (T3).
pub fn demote(quorum_dir: Option<&PathBuf>, hash_prefix: &str) -> Result<Exit, CliError> {
    let root = resolve_quorum_root(quorum_dir)?;
    let store = open_store(&root)?;
    // DL 2.4: the store's write lock, held from the state check through
    // the rename to the commit, as in `promote`.
    let lock = store
        .begin_convention_write()
        .map_err(|e| CliError::Io(format!("lock the dismissals store: {e}")))?;
    let row = resolve_short_hash(&store, hash_prefix)?;

    let hex = row.finding_identity_hash.to_hex();
    let short_hash = &hex[..12];
    if row.promotion_state != PromotionState::PromotedConvention {
        return Err(CliError::Config(format!(
            "{short_hash} is not in promoted_convention state (current: {}); demote requires \
             a previously-promoted row",
            row.promotion_state.as_db_str()
        )));
    }

    let conv_path = root.join(".quorum").join("conventions.md");
    let existing_bytes_opt = match std::fs::read(&conv_path) {
        Ok(b) => Some(b),
        Err(e) if e.kind() == std::io::ErrorKind::NotFound => None,
        Err(e) => return Err(CliError::Io(format!("read {conv_path:?}: {e}"))),
    };

    let block_id: String = hex[..12].to_string();

    if let Some(existing_bytes) = existing_bytes_opt {
        // File present โ€” refuse a broken structure, as promote does; then
        // parse, remove the matching block, atomic-write.
        let le = LineEnding::detect(&existing_bytes);
        quorum_core::conventions::check_writable(&conv_path, &existing_bytes)
            .map_err(|r| CliError::Config(r.to_string()))?;
        let (parsed, _) = parse_conventions_md(&existing_bytes);
        preflight_dirty_warning(&store, &parsed)?;

        let to_write = build_block_set(&parsed, BlockSetChange::Demote { id: &block_id });
        let new_bytes = render_conventions_md(&parsed, &to_write, le);
        atomic_write(&conv_path, &new_bytes).map_err(|e| CliError::Io(e.to_string()))?;
    } else {
        // ยง10 Q7 lean: missing conventions.md โ†’ stderr warning + SQLite
        // state still proceeds. No file write to attempt.
        eprintln!(
            "warning: .quorum/conventions.md not found; SQLite state will advance but no file \
             write performed"
        );
    }

    let ts_ms = current_unix_millis();
    let outcome = lock
        .commit_demote(&row.finding_identity_hash, ts_ms)
        .map_err(|e| CliError::Io(format!("commit_demote: {e}")))?;
    match outcome {
        DemoteOutcome::Committed => {
            println!("demoted {short_hash} (now local_only)");
            Ok(Exit::Ok)
        }
        DemoteOutcome::StateDrifted => Err(CliError::Config(format!(
            "{short_hash}: SQLite state was not promoted_convention at COMMIT time; \
             concurrent writer or state drift. File side has been updated; re-run \
             after `list --orphans` reconciliation."
        ))),
    }
}

/// Prune candidate dismissals older than the configured threshold (T4).
pub fn prune(quorum_dir: Option<&PathBuf>, dry_run: bool, yes: bool) -> Result<Exit, CliError> {
    let root = resolve_quorum_root(quorum_dir)?;
    let store = open_store(&root)?;

    // [memory] candidate_expire_days fallback (config absent โ†’ defaults).
    let candidate_expire_days = match quorum_core::config::read(&root) {
        Ok(cfg) => cfg.memory.candidate_expire_days,
        Err(quorum_core::config::ConfigError::NotFound(_)) => {
            quorum_core::config::MemoryConfig::default().candidate_expire_days
        }
        Err(e) => return Err(CliError::Config(format!("config: {e}"))),
    };
    if candidate_expire_days == 0 {
        eprintln!("prune disabled (candidate_expire_days=0); no rows pruned");
        return Ok(Exit::Ok);
    }
    let cutoff =
        time::OffsetDateTime::now_utc() - time::Duration::days(candidate_expire_days as i64);

    // Always preview candidates first (used by both --dry-run output and
    // the interactive confirmation prompt).
    let candidates = store
        .list_by_state(Some(PromotionState::Candidate))
        .map_err(|e| CliError::Io(format!("list_by_state: {e}")))?;
    let stale: Vec<&Dismissal> = candidates
        .iter()
        .filter(|d| d.last_seen_at < cutoff)
        .collect();

    if stale.is_empty() {
        println!(
            "no candidates older than {} days; nothing to prune",
            candidate_expire_days
        );
        return Ok(Exit::Ok);
    }

    if dry_run {
        println!(
            "would prune {} candidate(s) older than {} days:",
            stale.len(),
            candidate_expire_days
        );
        for d in &stale {
            let hex = d.finding_identity_hash.to_hex();
            println!(
                "  {}  {}",
                &hex[..12],
                truncate_for_display(&d.title_snapshot, TITLE_DISPLAY_WIDTH)
            );
        }
        return Ok(Exit::Ok);
    }

    if !yes && !confirm_prompt(stale.len(), candidate_expire_days)? {
        println!("aborted; no rows pruned");
        return Ok(Exit::Ok);
    }

    let pruned = store
        .prune_candidates(cutoff)
        .map_err(|e| CliError::Io(format!("prune_candidates: {e}")))?;
    println!("pruned {} candidate(s)", pruned);
    Ok(Exit::Ok)
}

fn confirm_prompt(count: usize, days: u32) -> Result<bool, CliError> {
    eprint!("Prune {count} candidate(s) older than {days} days? [y/N] ");
    std::io::stderr()
        .flush()
        .map_err(|e| CliError::Io(e.to_string()))?;
    let mut line = String::new();
    std::io::stdin()
        .read_line(&mut line)
        .map_err(|e| CliError::Io(e.to_string()))?;
    let ans = line.trim();
    Ok(ans.eq_ignore_ascii_case("y") || ans.eq_ignore_ascii_case("yes"))
}

/// AC 168 promote/demote pre-flight: surface in-file/SQLite divergence to
/// stderr. The Stage 4 dispatch ยง"WI-3 pre-flight" Q15 lean is simplified
/// per the dispatch's ยง2 latitude: any pre-flight discrepancy
/// (orphan blocks, missing rows) emits a warn-only stderr message.
/// Inside-vs-outside-fence detection is non-AC and deferred โ€” surfaced in
/// the Stage 4 close report.
fn preflight_dirty_warning(
    store: &LocalSqliteMemoryStore,
    parsed: &ParsedConventionsMd<'_>,
) -> Result<(), CliError> {
    let db_rows = store
        .list_conventions()
        .map_err(|e| CliError::Io(format!("preflight list_conventions: {e}")))?;
    let file_block_ids: std::collections::HashSet<&str> =
        parsed.blocks.iter().map(|b| b.id).collect();
    let db_block_ids: std::collections::HashSet<&str> = db_rows
        .iter()
        .map(|r| r.conventions_md_block_id.as_str())
        .collect();
    for pb in &parsed.blocks {
        if !db_block_ids.contains(pb.id) {
            eprintln!(
                "warning: .quorum/conventions.md: orphan managed block id={} (no SQLite row); \
                 run `quorum convention list --orphans` for full report",
                pb.id
            );
        }
    }
    for r in &db_rows {
        if !file_block_ids.contains(r.conventions_md_block_id.as_str()) {
            eprintln!(
                "warning: SQLite row {} has no managed block in .quorum/conventions.md",
                r.conventions_md_block_id
            );
        }
    }
    Ok(())
}

fn current_unix_millis() -> i64 {
    (time::OffsetDateTime::now_utc().unix_timestamp_nanos() / 1_000_000) as i64
}

#[cfg(test)]
mod tests {
    //! The CLI orchestrators run in-process here: `tests/convention_write.rs`
    //! drives the binary, but two `promote` processes started together are
    //! too far apart (each first waits out the other's store open) to race
    //! reliably. Threads calling `promote` each open their own store, so
    //! each has its own SQLite connection, as two processes would.

    use super::*;
    use quorum_core::memory::identity::finding_identity_hash;
    use quorum_core::memory::DismissalReason;
    use quorum_core::review::{Finding, FindingSource, Severity};

    fn seed_local_only(store: &LocalSqliteMemoryStore, title: &str) -> String {
        let f = Finding {
            severity: Severity::High,
            title: title.to_string(),
            body: format!("Body for {title}."),
            source: FindingSource::Divergence,
            supported_by: vec!["m".into()],
            confidence: Some(0.9),
        };
        store
            .dismiss(
                &f,
                "head",
                "main",
                DismissalReason::FalsePositive,
                None,
                None,
            )
            .unwrap();
        let hex = finding_identity_hash(&f).to_hex();
        let conn = rusqlite::Connection::open(store.path()).unwrap();
        conn.execute(
            "UPDATE dismissals SET promotion_state = 'local_only' WHERE finding_identity_hash = ?1",
            [&hex],
        )
        .unwrap();
        hex[..12].to_string()
    }

    #[test]
    fn concurrent_promotes_of_different_hashes_keep_both_blocks() {
        // DL 2.4. Without serialization both promotes read the same file,
        // both write N+1 blocks, and the later rename deletes the other's
        // block while both rows say promoted_convention.
        const TRIALS: usize = 20;
        let mut failures = Vec::new();
        for trial in 0..TRIALS {
            let td = tempfile::TempDir::new().unwrap();
            let root = td.path().to_path_buf();
            let store = LocalSqliteMemoryStore::new(&root).unwrap();
            let shorts = [
                seed_local_only(&store, &format!("first {trial}")),
                seed_local_only(&store, &format!("second {trial}")),
            ];
            drop(store);
            let barrier = std::sync::Barrier::new(2);
            let results: Vec<Result<Exit, CliError>> = std::thread::scope(|s| {
                let handles: Vec<_> = shorts
                    .iter()
                    .map(|short| {
                        let (root, barrier) = (&root, &barrier);
                        s.spawn(move || {
                            barrier.wait();
                            promote(Some(root), short, BodySource::Text("body".into()))
                        })
                    })
                    .collect();
                handles.into_iter().map(|h| h.join().unwrap()).collect()
            });
            for r in results {
                if let Err(e) = r {
                    failures.push(format!("trial {trial}: promote failed: {e}"));
                }
            }
            let conv = std::fs::read_to_string(root.join(".quorum").join("conventions.md"))
                .unwrap_or_default();
            for short in &shorts {
                if !conv.contains(&format!("id={short}")) {
                    failures.push(format!("trial {trial}: block {short} lost"));
                }
            }
        }
        assert!(failures.is_empty(), "{failures:#?}");
    }

    #[test]
    fn a_demote_racing_a_promote_keeps_the_promoted_block() {
        // DL 2.4 โ€” demote takes the same lock. Unserialized, both read
        // [Y]; the promote writes [Y, X], the demote writes [], and X's
        // block is lost behind a promoted_convention row.
        const TRIALS: usize = 20;
        let mut failures = Vec::new();
        for trial in 0..TRIALS {
            let td = tempfile::TempDir::new().unwrap();
            let root = td.path().to_path_buf();
            let store = LocalSqliteMemoryStore::new(&root).unwrap();
            let x = seed_local_only(&store, &format!("promoted {trial}"));
            let y = seed_local_only(&store, &format!("demoted {trial}"));
            drop(store);
            promote(Some(&root), &y, BodySource::Text("y".into())).unwrap();
            let barrier = std::sync::Barrier::new(2);
            let results: Vec<Result<Exit, CliError>> = std::thread::scope(|s| {
                let (root, barrier, x, y) = (&root, &barrier, &x, &y);
                let a = s.spawn(move || {
                    barrier.wait();
                    promote(Some(root), x, BodySource::Text("x".into()))
                });
                let b = s.spawn(move || {
                    barrier.wait();
                    demote(Some(root), y)
                });
                vec![a.join().unwrap(), b.join().unwrap()]
            });
            for r in results {
                if let Err(e) = r {
                    failures.push(format!("trial {trial}: failed: {e}"));
                }
            }
            let conv = std::fs::read_to_string(root.join(".quorum").join("conventions.md"))
                .unwrap_or_default();
            if !conv.contains(&format!("id={x}")) {
                failures.push(format!("trial {trial}: promoted block {x} lost"));
            }
            if conv.contains(&format!("id={y}")) {
                failures.push(format!("trial {trial}: demoted block {y} kept"));
            }
        }
        assert!(failures.is_empty(), "{failures:#?}");
    }
}