quill 0.2.0

use crate::elements::{Axis, Grid, Scale, Tick, MinorGrid};
use crate::style::*;
use svg::Document;
use svg::node::Text as SvgNodeText;
use svg::node::element::{Line as SvgLine, Text};

/// Generate minor tick values for logarithmic scale between major ticks
fn generate_minor_log_ticks(major_ticks: &[f32]) -> Vec<f32> {
    let mut minor_ticks = Vec::new();
    
    for i in 0..major_ticks.len().saturating_sub(1) {
        let current_major = major_ticks[i];
        let next_major = major_ticks[i + 1];
        
        // Calculate the order of magnitude for current major tick
        if current_major > 0.0 && next_major > 0.0 {
            let current_log = current_major.log10();
            let next_log = next_major.log10();
            
            // Only add minor ticks if we're moving by exactly one order of magnitude
            if (next_log - current_log - 1.0).abs() < 0.1 {
                let magnitude = 10.0_f32.powi(current_log.floor() as i32);
                
                // Add minor ticks at 2×10^n, 3×10^n, ..., 9×10^n
                for factor in 2..=9 {
                    let minor_tick = (factor as f32) * magnitude;
                    if minor_tick > current_major && minor_tick < next_major {
                        minor_ticks.push(minor_tick);
                    }
                }
            }
        }
    }
    
    minor_ticks
}

/// Generate minor tick values for linear scales between major ticks
fn generate_minor_linear_ticks(major_ticks: &[f32], num_minor_per_major: usize) -> Vec<f32> {
    let mut minor_ticks = Vec::new();
    
    for i in 0..major_ticks.len().saturating_sub(1) {
        let current_major = major_ticks[i];
        let next_major = major_ticks[i + 1];
        let interval = (next_major - current_major) / (num_minor_per_major + 1) as f32;
        
        // Add minor ticks between current and next major tick
        for j in 1..=num_minor_per_major {
            let minor_tick = current_major + interval * j as f32;
            minor_ticks.push(minor_tick);
        }
    }
    
    minor_ticks
}

/// Generate tick values for Pi scale based on nice π fractions
fn generate_pi_ticks(range_min: f32, range_max: f32) -> Vec<f32> {
    const PI: f32 = std::f32::consts::PI;
    let mut ticks = Vec::new();
    
    // Common π fractions: 0, π/6, π/4, π/3, π/2, 2π/3, 3π/4, 5π/6, π, 7π/6, 5π/4, 4π/3, 3π/2, 5π/3, 7π/4, 11π/6, 2π, etc.
    let pi_fractions = [
        0.0,           // 0
        1.0/6.0,       // π/6
        1.0/4.0,       // π/4
        1.0/3.0,       // π/3
        1.0/2.0,       // π/2
        2.0/3.0,       // 2π/3
        3.0/4.0,       // 3π/4
        5.0/6.0,       // 5π/6
        1.0,           // π
        7.0/6.0,       // 7π/6
        5.0/4.0,       // 5π/4
        4.0/3.0,       // 4π/3
        3.0/2.0,       // 3π/2
        5.0/3.0,       // 5π/3
        7.0/4.0,       // 7π/4
        11.0/6.0,      // 11π/6
        2.0,           // 2π
    ];
    
    // Determine the range in terms of π
    let min_pi_ratio = range_min / PI;
    let max_pi_ratio = range_max / PI;
    
    // Find appropriate scale - determine how many π periods we span
    let pi_range = max_pi_ratio - min_pi_ratio;
    
    if pi_range <= 0.5 {
        // Very small range - use π/8, π/6, π/4 increments
        let fine_fractions = [0.0, 1.0/8.0, 1.0/6.0, 1.0/4.0, 1.0/3.0, 3.0/8.0, 1.0/2.0, 5.0/8.0, 2.0/3.0, 3.0/4.0, 5.0/6.0, 7.0/8.0, 1.0];
        for &frac in &fine_fractions {
            let tick_value = frac * PI;
            if tick_value >= range_min && tick_value <= range_max {
                ticks.push(tick_value);
            }
            // Also check negative values
            let neg_tick_value = -frac * PI;
            if neg_tick_value >= range_min && neg_tick_value <= range_max {
                ticks.push(neg_tick_value);
            }
        }
    } else if pi_range <= 3.0 {
        // Medium range - use standard π fractions
        for &frac in &pi_fractions {
            // Check multiple periods
            for period in -3..=3 {
                let tick_value = (frac + period as f32 * 2.0) * PI;
                if tick_value >= range_min && tick_value <= range_max {
                    ticks.push(tick_value);
                }
            }
        }
    } else {
        // Large range - use integer multiples of π
        let start_multiple = (min_pi_ratio.floor() as i32).max(-10);
        let end_multiple = (max_pi_ratio.ceil() as i32).min(10);
        
        for multiple in start_multiple..=end_multiple {
            let tick_value = multiple as f32 * PI;
            if tick_value >= range_min && tick_value <= range_max {
                ticks.push(tick_value);
            }
            // Also add half-π values for better granularity
            let half_tick = (multiple as f32 + 0.5) * PI;
            if half_tick >= range_min && half_tick <= range_max {
                ticks.push(half_tick);
            }
        }
    }
    
    // Remove duplicates and sort
    ticks.sort_by(|a, b| a.partial_cmp(b).unwrap());
    ticks.dedup_by(|a, b| (*a - *b).abs() < 1e-6);
    
    ticks
}

/// Generate minor tick values for Pi scale between major ticks
fn generate_minor_pi_ticks(major_ticks: &[f32]) -> Vec<f32> {
    const PI: f32 = std::f32::consts::PI;
    let mut minor_ticks = Vec::new();
    
    for i in 0..major_ticks.len().saturating_sub(1) {
        let current_major = major_ticks[i];
        let next_major = major_ticks[i + 1];
        let interval = next_major - current_major;
        
        // Determine appropriate minor tick spacing based on the interval
        if interval <= PI / 4.0 {
            // Small interval - add one minor tick in the middle
            let minor_tick = (current_major + next_major) / 2.0;
            minor_ticks.push(minor_tick);
        } else if interval <= PI / 2.0 {
            // Medium interval - add π/8 increments
            let num_subdivisions = 2;
            for j in 1..num_subdivisions {
                let minor_tick = current_major + (interval * j as f32) / num_subdivisions as f32;
                minor_ticks.push(minor_tick);
            }
        } else {
            // Large interval - add more subdivisions
            let num_subdivisions = 4;
            for j in 1..num_subdivisions {
                let minor_tick = current_major + (interval * j as f32) / num_subdivisions as f32;
                minor_ticks.push(minor_tick);
            }
        }
    }
    
    minor_ticks
}

/// Format a value in terms of π for display
fn format_pi_value(value: f32) -> String {
    const PI: f32 = std::f32::consts::PI;
    
    if value.abs() < 1e-6 {
        return "0".to_string();
    }
    
    let pi_ratio = value / PI;
    let tolerance = 1e-3;
    
    // Check for simple fractions with denominators 1, 2, 3, 4, 6, 8
    let common_denominators = [1, 2, 3, 4, 6, 8];
    
    for &denom in &common_denominators {
        let numerator_f = pi_ratio * denom as f32;
        let numerator = numerator_f.round() as i32;
        
        if (numerator_f - numerator as f32).abs() < tolerance {
            if numerator == 0 {
                return "0".to_string();
            }
            
            match (numerator, denom) {
                (n, 1) if n == 1 => return "π".to_string(),
                (n, 1) if n == -1 => return "-π".to_string(),
                (n, 1) => return format!("{}π", n),
                (n, d) if n.abs() == 1 && d == 2 => return if n > 0 { "π/2".to_string() } else { "-π/2".to_string() },
                (n, d) if n.abs() == 1 => return if n > 0 { format!("π/{}", d) } else { format!("-π/{}", d) },
                (n, d) => return format!("{}π/{}", n, d),
            }
        }
    }
    
    // If no simple fraction found, use decimal approximation
    format!("{:.2}π", pi_ratio)
}

pub fn draw_ticks_and_grids<FX, FY>(
    document: Document,
    axis: Axis,
    tick: Tick,
    grid: Grid,
    minor_grid: MinorGrid,
    x_scale: Scale,
    y_scale: Scale,
    tick_config: &TickConfig,
    grid_config: &GridConfig,
    font: &str,
    plot_area_x_start: f32,
    plot_area_y_start: f32,
    plot_area_width: f32,
    plot_area_height: f32,
    x_ticks: &[f32],
    y_ticks: &[f32],
    map_x: FX,
    map_y: FY,
) -> Document
where
    FX: Fn(f32) -> f32,
    FY: Fn(f32) -> f32,
{
    let tick_label_color_svg = tick_config.label_color.to_hex_string();
    let tick_line_color_svg = tick_config.line_color.to_hex_string();
    let minor_tick_color_svg = tick_config.minor_tick_color.to_hex_string();
    let grid_line_color_svg = grid_config.color.to_hex_string();
    let minor_grid_color_svg = grid_config.minor_color.to_hex_string();
    let mut document = document;

    // Override ticks with Pi-appropriate values when Pi scale is used
    let actual_x_ticks = if x_scale == Scale::Pi {
        // Calculate range from provided ticks and generate Pi ticks
        let x_min = x_ticks.iter().copied().fold(f32::INFINITY, f32::min);
        let x_max = x_ticks.iter().copied().fold(f32::NEG_INFINITY, f32::max);
        generate_pi_ticks(x_min, x_max)
    } else {
        x_ticks.to_vec()
    };

    let actual_y_ticks = if y_scale == Scale::Pi {
        // Calculate range from provided ticks and generate Pi ticks
        let y_min = y_ticks.iter().copied().fold(f32::INFINITY, f32::min);
        let y_max = y_ticks.iter().copied().fold(f32::NEG_INFINITY, f32::max);
        generate_pi_ticks(y_min, y_max)
    } else {
        y_ticks.to_vec()
    };

    // Generate minor ticks for all scale types when enabled
    let x_minor_ticks = match minor_grid {
        MinorGrid::XAxis | MinorGrid::Both => {
            match x_scale {
                Scale::Log => generate_minor_log_ticks(&actual_x_ticks),
                Scale::Pi => generate_minor_pi_ticks(&actual_x_ticks),
                _ => generate_minor_linear_ticks(&actual_x_ticks, 4), // 4 minor ticks between major ticks for linear scales
            }
        }
        _ => Vec::new(),
    };
    
    let y_minor_ticks = match minor_grid {
        MinorGrid::YAxis | MinorGrid::Both => {
            match y_scale {
                Scale::Log => generate_minor_log_ticks(&actual_y_ticks),
                Scale::Pi => generate_minor_pi_ticks(&actual_y_ticks),
                _ => generate_minor_linear_ticks(&actual_y_ticks, 4), // 4 minor ticks between major ticks for linear scales
            }
        }
        _ => Vec::new(),
    };

    // Determine Y-axis scaling factor
    let mut y_scale_factor = 1.0;
    let mut y_scale_exponent = 0;

    match y_scale {
        Scale::None => {
            // No scaling, factor remains 1.0, exponent 0
        }
        Scale::Log => {
            // For logarithmic scale, we don't use a simple scaling factor
            // The tick values should already be in log space if using log scale
            // This will need more comprehensive implementation in the future
        }
        Scale::Pi => {
            // For Pi scale, no scaling factor needed as formatting is handled separately
        }
        Scale::Scientific | Scale::Engineering => {
            let mut max_tick_abs = 0.0;
            for &tick_val in actual_y_ticks.iter() {
                if tick_val.abs() > max_tick_abs {
                    max_tick_abs = tick_val.abs();
                }
            }

            if max_tick_abs > 0.0 {
                let mut current_power = 0;
                let temp_max = max_tick_abs;

                if y_scale == Scale::Scientific {
                    // Scientific: normalize to 1.xxxx
                    if temp_max >= 10.0 || (temp_max < 1.0 && temp_max > 0.0) {
                        current_power = temp_max.log10().floor() as i32;
                    }
                } else {
                    // Engineering: normalize to xxx.xxxx with exponent multiple of 3
                    let exp = temp_max.log10().floor() as i32;
                    current_power = (exp / 3) * 3;
                    // Adjust temp_max to reflect the engineering scaling for the following format call, if needed
                    // This ensures that the number of digits before decimal is between 1 and 3.
                    let scaled_val_check = temp_max / 10.0_f32.powi(current_power);
                    if scaled_val_check >= 1000.0 {
                        current_power += 3;
                    } else if scaled_val_check < 1.0 && scaled_val_check > 0.0 {
                        // this case should ideally not be hit if numbers are typical positives
                        // but if max_tick_abs was < 1 initially, engineering might make it 0.xxx * 10^0
                        // or for very small numbers like 0.000123 -> 123 * 10^-6
                        // if current_power is 0 and val is < 1, we might want to shift to e.g. 123u * 10^-3
                        if current_power == 0 && scaled_val_check < 1.0 {
                            let sub_exp = scaled_val_check.log10().floor() as i32;
                            current_power = ((sub_exp - 2) / 3) * 3; // Aim for xxx.yyy, so shift by 2 more than usual
                        }
                    }
                }

                if current_power != 0 {
                    y_scale_factor = 10.0_f32.powi(current_power);
                    y_scale_exponent = current_power;
                }
            }
        }
    }

    // Determine X-axis scaling factor
    let mut x_scale_factor = 1.0;
    let mut x_scale_exponent = 0;

    match x_scale {
        Scale::None => {
            // No scaling, factor remains 1.0, exponent 0
        }
        Scale::Log => {
            // For logarithmic scale, we don't use a simple scaling factor
            // The tick values should already be in log space if using log scale
            // This will need more comprehensive implementation in the future
        }
        Scale::Pi => {
            // For Pi scale, no scaling factor needed as formatting is handled separately
        }
        Scale::Scientific | Scale::Engineering => {
            let mut max_tick_abs = 0.0;
            for &tick_val in actual_x_ticks.iter() {
                if tick_val.abs() > max_tick_abs {
                    max_tick_abs = tick_val.abs();
                }
            }

            if max_tick_abs > 0.0 {
                let mut current_power = 0;
                let temp_max = max_tick_abs;

                if x_scale == Scale::Scientific {
                    // Scientific: normalize to 1.xxxx
                    if temp_max >= 10.0 || (temp_max < 1.0 && temp_max > 0.0) {
                        current_power = temp_max.log10().floor() as i32;
                    }
                } else {
                    // Engineering: normalize to xxx.xxxx with exponent multiple of 3
                    let exp = temp_max.log10().floor() as i32;
                    current_power = (exp / 3) * 3;
                    let scaled_val_check = temp_max / 10.0_f32.powi(current_power);
                    if scaled_val_check >= 1000.0 {
                        current_power += 3;
                    } else if scaled_val_check < 1.0 && scaled_val_check > 0.0 {
                        if current_power == 0 && scaled_val_check < 1.0 {
                            let sub_exp = scaled_val_check.log10().floor() as i32;
                            current_power = ((sub_exp - 2) / 3) * 3;
                        }
                    }
                }

                if current_power != 0 {
                    x_scale_factor = 10.0_f32.powi(current_power);
                    x_scale_exponent = current_power;
                }
            }
        }
    }

    for &tick_val in actual_x_ticks.iter() {
        let screen_x = map_x(tick_val);
        let is_origin = (screen_x - plot_area_x_start).abs() < 0.1;
        if screen_x >= plot_area_x_start - 0.1
            && screen_x <= plot_area_x_start + plot_area_width + 0.1
        {
            match grid {
                Grid::None => {}
                Grid::Solid | Grid::Dashed | Grid::Dotted => {
                    let mut skip_grid_line = false;
                    if is_origin {
                        skip_grid_line = true;
                    }
                    if axis == Axis::Box
                        && (screen_x - (plot_area_x_start + plot_area_width)).abs() < 0.1
                    {
                        skip_grid_line = true;
                    }
                    if !skip_grid_line {
                        let mut grid_line = SvgLine::new()
                            .set("x1", screen_x)
                            .set("y1", plot_area_y_start)
                            .set("x2", screen_x)
                            .set("y2", plot_area_y_start + plot_area_height)
                            .set("stroke", grid_line_color_svg.clone())
                            .set("stroke-width", grid_config.line_width);
                        match grid {
                            Grid::Dotted => {
                                grid_line = grid_line.set("stroke-dasharray", "1 2");
                            }
                            Grid::Dashed => {
                                grid_line = grid_line.set("stroke-dasharray", "4 4");
                            }
                            Grid::Solid | Grid::None => {}
                        }
                        document = document.add(grid_line);
                    }
                }
            }
            if tick != Tick::None {
                let tick_direction = if tick == Tick::Inward { -1.0 } else { 1.0 };
                let tick_y_bottom = plot_area_y_start + plot_area_height;
                let tick_y_top = plot_area_y_start;
                let tick_label_offset = tick_config.font_size * 0.4 + 5.0;
                match axis {
                    Axis::BottomLeft | Axis::Box => {
                        let tick_line_bottom = SvgLine::new()
                            .set("x1", screen_x)
                            .set("y1", tick_y_bottom)
                            .set("x2", screen_x)
                            .set("y2", tick_y_bottom + tick_config.length * tick_direction)
                            .set("stroke", tick_line_color_svg.clone())
                            .set("stroke-width", 1.0);
                        document = document.add(tick_line_bottom);
                        let tick_label_text_bottom = if x_scale == Scale::Log {
                            // For log scale, always use scientific notation like "10³"
                            let abs_value = tick_val.abs();
                            if abs_value == 0.0 {
                                "0".to_string()
                            } else {
                                let log_value = abs_value.log10();
                                if (log_value.round() - log_value).abs() < 0.001 {
                                    let exponent = log_value.round() as i32;
                                    // Always use scientific notation: "10^exponent"
                                    format!("10^{}", exponent)
                                } else {
                                    // For intermediate values, use coefficient·10^exponent format
                                    let coefficient = tick_val / 10.0_f32.powi(log_value.floor() as i32);
                                    let exponent = log_value.floor() as i32;
                                    if (coefficient - 1.0).abs() < 0.001 {
                                        format!("10^{}", exponent)
                                    } else {
                                        format!("{:.1}·10^{}", coefficient, exponent)
                                    }
                                }
                            }
                        } else if x_scale == Scale::Pi {
                            // For Pi scale, format values in terms of π
                            format_pi_value(tick_val)
                        } else {
                            format!("{:.1}", tick_val / x_scale_factor)
                        };

                        // Handle logarithmic labels with proper superscript formatting for x-axis
                        if x_scale == Scale::Log && (tick_label_text_bottom.contains("10^") || tick_label_text_bottom.contains("·10^")) {
                            // Handle both "10^exponent" and "coefficient·10^exponent" formats
                            if let Some(cap) = tick_label_text_bottom.strip_prefix("10^") {
                                // Simple "10^exponent" format
                                let exponent = cap.parse::<i32>().unwrap_or(0);
                                
                                let base_text_node = SvgNodeText::new("10");
                                let exponent_tspan = svg::node::element::TSpan::new()
                                    .set("dy", "-0.4em") // Shift exponent upwards
                                    .set("dx", "-0.2em") // Shift left to align with base
                                    .add(SvgNodeText::new(exponent.to_string()));
                                
                                let tick_label_svg_bottom = Text::new()
                                    .set("x", screen_x)
                                    .set("y", tick_y_bottom + tick_label_offset)
                                    .set("font-family", font)
                                    .set("font-size", tick_config.font_size)
                                    .set("fill", tick_label_color_svg.clone())
                                    .set("text-anchor", "middle")
                                    .set("dominant-baseline", "hanging")
                                    .add(base_text_node)
                                    .add(exponent_tspan);
                                document = document.add(tick_label_svg_bottom);
                            } else if let Some(pos) = tick_label_text_bottom.find("·10^") {
                                // "coefficient·10^exponent" format
                                let coefficient = &tick_label_text_bottom[..pos];
                                let exponent_str = &tick_label_text_bottom[pos + 4..]; // Skip "·10^"
                                let exponent = exponent_str.parse::<i32>().unwrap_or(0);
                                
                                let base_text_node = SvgNodeText::new(&format!("{}·10", coefficient));
                                let exponent_tspan = svg::node::element::TSpan::new()
                                    .set("dy", "-0.4em") // Shift exponent upwards
                                    .set("dx", "-0.2em") // Shift left to align with base
                                    .add(SvgNodeText::new(exponent.to_string()));
                                
                                let tick_label_svg_bottom = Text::new()
                                    .set("x", screen_x)
                                    .set("y", tick_y_bottom + tick_label_offset)
                                    .set("font-family", font)
                                    .set("font-size", tick_config.font_size)
                                    .set("fill", tick_label_color_svg.clone())
                                    .set("text-anchor", "middle")
                                    .set("dominant-baseline", "hanging")
                                    .add(base_text_node)
                                    .add(exponent_tspan);
                                document = document.add(tick_label_svg_bottom);
                            } else {
                                // Fallback to simple text
                                let tick_label_svg_bottom = Text::new()
                                    .set("x", screen_x)
                                    .set("y", tick_y_bottom + tick_label_offset)
                                    .set("font-family", font)
                                    .set("font-size", tick_config.font_size)
                                    .set("fill", tick_label_color_svg.clone())
                                    .set("text-anchor", "middle")
                                    .set("dominant-baseline", "hanging")
                                    .add(SvgNodeText::new(tick_label_text_bottom));
                                document = document.add(tick_label_svg_bottom);
                            }
                        } else if x_scale == Scale::Pi && tick_label_text_bottom.contains("π") {
                            // Handle Pi scale labels with proper Unicode π symbol
                            let tick_label_svg_bottom = Text::new()
                                .set("x", screen_x)
                                .set("y", tick_y_bottom + tick_label_offset)
                                .set("font-family", font)
                                .set("font-size", tick_config.font_size)
                                .set("fill", tick_label_color_svg.clone())
                                .set("text-anchor", "middle")
                                .set("dominant-baseline", "hanging")
                                .add(SvgNodeText::new(tick_label_text_bottom));
                            document = document.add(tick_label_svg_bottom);
                        } else {
                            // Normal text formatting for non-logarithmic or simple logarithmic labels
                            let tick_label_svg_bottom = Text::new()
                                .set("x", screen_x)
                                .set("y", tick_y_bottom + tick_label_offset)
                                .set("font-family", font)
                                .set("font-size", tick_config.font_size)
                                .set("fill", tick_label_color_svg.clone())
                                .set("text-anchor", "middle")
                                .set("dominant-baseline", "hanging")
                                .add(SvgNodeText::new(tick_label_text_bottom));
                            document = document.add(tick_label_svg_bottom);
                        }
                    }
                }
                if axis == Axis::Box {
                    let tick_line_top = SvgLine::new()
                        .set("x1", screen_x)
                        .set("y1", tick_y_top)
                        .set("x2", screen_x)
                        .set("y2", tick_y_top - tick_config.length * tick_direction)
                        .set("stroke", tick_line_color_svg.clone())
                        .set("stroke-width", 1.0);
                    document = document.add(tick_line_top);
                }
            }
        }
    }
    // Draw Y-axis scale factor label if needed
    if y_scale_factor != 1.0 && y_scale != Scale::None && y_scale != Scale::Log && y_scale != Scale::Pi {
        let exponent_str = y_scale_exponent;
        let base_text_node = SvgNodeText::new("·10");

        let exponent_tspan = svg::node::element::TSpan::new()
            .set("dy", "-0.4em") // Shift exponent upwards. Adjust value if needed.
            .set("dx", "-0.2em") // Shift left to align with base
            .add(SvgNodeText::new(exponent_str.to_string()));

        let scale_label_svg = Text::new()
            .set("x", plot_area_x_start + tick_config.text_padding)
            .set("y", plot_area_y_start - tick_config.text_padding)
            .set("font-family", font)
            .set("font-size", tick_config.font_size)
            .set("fill", tick_label_color_svg.clone())
            .set("text-anchor", "start")
            .set("dominant-baseline", "text-after-edge")
            .add(base_text_node)
            .add(exponent_tspan);
        document = document.add(scale_label_svg);
    }

    // Draw X-axis scale factor label if needed
    if x_scale_factor != 1.0 && x_scale != Scale::None && x_scale != Scale::Log && x_scale != Scale::Pi {
        let exponent_str = x_scale_exponent;
        let base_text_node = SvgNodeText::new("·10");

        let exponent_tspan = svg::node::element::TSpan::new()
            .set("dy", "-0.4em") // Shift exponent upwards
            .set("dx", "-0.2em") // Shift left to align with base
            .add(SvgNodeText::new(exponent_str.to_string()));

        let scale_label_svg = Text::new()
            .set("x", plot_area_x_start + plot_area_width - tick_config.text_padding)
            .set("y", plot_area_y_start + plot_area_height + tick_config.font_size + tick_config.text_padding * 2.0)
            .set("font-family", font)
            .set("font-size", tick_config.font_size)
            .set("fill", tick_label_color_svg.clone())
            .set("text-anchor", "end")
            .set("dominant-baseline", "text-before-edge")
            .add(base_text_node)
            .add(exponent_tspan);
        document = document.add(scale_label_svg);
    }

    // Draw X-axis minor ticks and grids
    for &minor_tick_val in x_minor_ticks.iter() {
        let screen_x = map_x(minor_tick_val);
        if screen_x >= plot_area_x_start - 0.1
            && screen_x <= plot_area_x_start + plot_area_width + 0.1
        {
            // Draw minor grid lines
            if matches!(minor_grid, MinorGrid::XAxis | MinorGrid::Both) {
                match grid {
                    Grid::None => {}
                    Grid::Solid | Grid::Dashed | Grid::Dotted => {
                        let mut minor_grid_line = SvgLine::new()
                            .set("x1", screen_x)
                            .set("y1", plot_area_y_start)
                            .set("x2", screen_x)
                            .set("y2", plot_area_y_start + plot_area_height)
                            .set("stroke", minor_grid_color_svg.clone())
                            .set("stroke-width", grid_config.minor_line_width);
                        
                        // Apply the same dash pattern as the major grid
                        match grid {
                            Grid::Dotted => {
                                minor_grid_line = minor_grid_line.set("stroke-dasharray", "1 2");
                            }
                            Grid::Dashed => {
                                minor_grid_line = minor_grid_line.set("stroke-dasharray", "4 4");
                            }
                            Grid::Solid | Grid::None => {}
                        }
                        
                        document = document.add(minor_grid_line);
                    }
                }
            }

            // Draw minor tick marks
            if tick != Tick::None {
                let tick_direction = if tick == Tick::Inward { -1.0 } else { 1.0 };
                let tick_y_bottom = plot_area_y_start + plot_area_height;
                match axis {
                    Axis::BottomLeft | Axis::Box => {
                        let minor_tick_line_bottom = SvgLine::new()
                            .set("x1", screen_x)
                            .set("y1", tick_y_bottom)
                            .set("x2", screen_x)
                            .set("y2", tick_y_bottom + tick_config.minor_tick_length * tick_direction)
                            .set("stroke", minor_tick_color_svg.clone())
                            .set("stroke-width", 0.5);
                        document = document.add(minor_tick_line_bottom);
                    }
                }
                if axis == Axis::Box {
                    let tick_y_top = plot_area_y_start;
                    let minor_tick_line_top = SvgLine::new()
                        .set("x1", screen_x)
                        .set("y1", tick_y_top)
                        .set("x2", screen_x)
                        .set("y2", tick_y_top - tick_config.minor_tick_length * tick_direction)
                        .set("stroke", minor_tick_color_svg.clone())
                        .set("stroke-width", 0.5);
                    document = document.add(minor_tick_line_top);
                }
            }
        }
    }

    for &tick_val in actual_y_ticks.iter() {
        let screen_y = map_y(tick_val);
        if screen_y >= plot_area_y_start - 0.1
            && screen_y <= plot_area_y_start + plot_area_height + 0.1
        {
            match grid {
                Grid::None => {}
                Grid::Solid | Grid::Dashed | Grid::Dotted => {
                    let mut skip_grid_line = false;
                    if (screen_y - (plot_area_y_start + plot_area_height)).abs() < 0.1 {
                        skip_grid_line = true;
                    }
                    if axis == Axis::Box && (screen_y - plot_area_y_start).abs() < 0.1 {
                        skip_grid_line = true;
                    }
                    if !skip_grid_line {
                        let mut grid_line = SvgLine::new()
                            .set("x1", plot_area_x_start)
                            .set("y1", screen_y)
                            .set("x2", plot_area_x_start + plot_area_width)
                            .set("y2", screen_y)
                            .set("stroke", grid_line_color_svg.clone())
                            .set("stroke-width", grid_config.line_width);
                        match grid {
                            Grid::Dotted => {
                                grid_line = grid_line.set("stroke-dasharray", "1 2");
                            }
                            Grid::Dashed => {
                                grid_line = grid_line.set("stroke-dasharray", "4 4");
                            }
                            Grid::Solid | Grid::None => {}
                        }
                        document = document.add(grid_line);
                    }
                }
            }
            if tick != Tick::None {
                let tick_direction = if tick == Tick::Inward { -1.0 } else { 1.0 };
                let tick_x_left = plot_area_x_start;
                let tick_x_right = plot_area_x_start + plot_area_width;
                match axis {
                    Axis::BottomLeft | Axis::Box => {
                        let tick_line_left = SvgLine::new()
                            .set("x1", tick_x_left)
                            .set("y1", screen_y)
                            .set("x2", tick_x_left - tick_config.length * tick_direction)
                            .set("y2", screen_y)
                            .set("stroke", tick_line_color_svg.clone())
                            .set("stroke-width", 1.0);
                        document = document.add(tick_line_left);
                    }
                }
                if axis == Axis::Box {
                    let tick_line_right = SvgLine::new()
                        .set("x1", tick_x_right)
                        .set("y1", screen_y)
                        .set("x2", tick_x_right + tick_config.length * tick_direction)
                        .set("y2", screen_y)
                        .set("stroke", tick_line_color_svg.clone())
                        .set("stroke-width", 1.0);
                    document = document.add(tick_line_right);
                }
                let display_val = tick_val / y_scale_factor;
                let tick_label_text = if y_scale == Scale::Log {
                    // For log scale, always use scientific notation like "10³"
                    let abs_value = tick_val.abs();
                    if abs_value == 0.0 {
                        "0".to_string()
                    } else {
                        let log_value = abs_value.log10();
                        if (log_value.round() - log_value).abs() < 0.001 {
                            let exponent = log_value.round() as i32;
                            // Always use scientific notation: "10^exponent"
                            format!("10^{}", exponent)
                        } else {
                            // For intermediate values, use coefficient·10^exponent format
                            let coefficient = tick_val / 10.0_f32.powi(log_value.floor() as i32);
                            let exponent = log_value.floor() as i32;
                            if (coefficient - 1.0).abs() < 0.001 {
                                format!("10^{}", exponent)
                            } else {
                                format!("{:.1}·10^{}", coefficient, exponent)
                            }
                        }
                    }
                } else if y_scale == Scale::Pi {
                    // For Pi scale, format values in terms of π
                    format_pi_value(tick_val)
                } else {
                    format!("{:.1}", display_val)
                };

                // Handle logarithmic labels with proper superscript formatting
                if y_scale == Scale::Log && (tick_label_text.contains("10^") || tick_label_text.contains("·10^")) {
                    // Handle both "10^exponent" and "coefficient·10^exponent" formats
                    if let Some(cap) = tick_label_text.strip_prefix("10^") {
                        // Simple "10^exponent" format
                        let exponent = cap.parse::<i32>().unwrap_or(0);
                        
                        let base_text_node = SvgNodeText::new("10");
                        let exponent_tspan = svg::node::element::TSpan::new()
                            .set("dy", "-0.4em") // Shift exponent upwards
                            .set("dx", "-0.2em") // Shift left to align with base
                            .add(SvgNodeText::new(exponent.to_string()));
                        
                        let tick_label_svg = Text::new()
                            .set(
                                "x",
                                tick_x_left
                                    - tick_config.text_padding
                                    - (if tick_direction > 0.0 {
                                        tick_config.length
                                    } else {
                                        tick_config.length
                                    }),
                            )
                            .set("y", screen_y)
                            .set("font-family", font)
                            .set("font-size", tick_config.font_size)
                            .set("fill", tick_label_color_svg.clone())
                            .set("text-anchor", "end")
                            .set("dominant-baseline", "middle")
                            .add(base_text_node)
                            .add(exponent_tspan);
                        document = document.add(tick_label_svg);
                    } else if let Some(pos) = tick_label_text.find("·10^") {
                        // "coefficient·10^exponent" format
                        let coefficient = &tick_label_text[..pos];
                        let exponent_str = &tick_label_text[pos + 4..]; // Skip "·10^"
                        let exponent = exponent_str.parse::<i32>().unwrap_or(0);
                        
                        let base_text_node = SvgNodeText::new(&format!("{}·10", coefficient));
                        let exponent_tspan = svg::node::element::TSpan::new()
                            .set("dy", "-0.4em") // Shift exponent upwards
                            .set("dx", "-0.2em") // Shift left to align with base
                            .add(SvgNodeText::new(exponent.to_string()));
                        
                        let tick_label_svg = Text::new()
                            .set(
                                "x",
                                tick_x_left
                                    - tick_config.text_padding
                                    - (if tick_direction > 0.0 {
                                        tick_config.length
                                    } else {
                                        tick_config.length
                                    }),
                            )
                            .set("y", screen_y)
                            .set("font-family", font)
                            .set("font-size", tick_config.font_size)
                            .set("fill", tick_label_color_svg.clone())
                            .set("text-anchor", "end")
                            .set("dominant-baseline", "middle")
                            .add(base_text_node)
                            .add(exponent_tspan);
                        document = document.add(tick_label_svg);
                    } else {
                        // Fallback to simple text
                        let tick_label_svg = Text::new()
                            .set(
                                "x",
                                tick_x_left
                                    - tick_config.text_padding
                                    - (if tick_direction > 0.0 {
                                        tick_config.length
                                    } else {
                                        tick_config.length
                                    }),
                            )
                            .set("y", screen_y)
                            .set("font-family", font)
                            .set("font-size", tick_config.font_size)
                            .set("fill", tick_label_color_svg.clone())
                            .set("text-anchor", "end")
                            .set("dominant-baseline", "middle")
                            .add(SvgNodeText::new(tick_label_text));
                        document = document.add(tick_label_svg);
                    }
                } else if y_scale == Scale::Pi && tick_label_text.contains("π") {
                    // Handle Pi scale labels with proper Unicode π symbol
                    let tick_label_svg = Text::new()
                        .set(
                            "x",
                            tick_x_left
                                - tick_config.text_padding
                                - (if tick_direction > 0.0 {
                                    tick_config.length
                                } else {
                                    tick_config.length
                                }),
                        )
                        .set("y", screen_y)
                        .set("font-family", font)
                        .set("font-size", tick_config.font_size)
                        .set("fill", tick_label_color_svg.clone())
                        .set("text-anchor", "end")
                        .set("dominant-baseline", "middle")
                        .add(SvgNodeText::new(tick_label_text));
                    document = document.add(tick_label_svg);
                } else {
                    // Normal text formatting for non-logarithmic or simple logarithmic labels
                    let tick_label_svg = Text::new()
                        .set(
                            "x",
                            tick_x_left
                                - tick_config.text_padding
                                - (if tick_direction > 0.0 {
                                    tick_config.length
                                } else {
                                    tick_config.length
                                }),
                        )
                        .set("y", screen_y)
                        .set("font-family", font)
                        .set("font-size", tick_config.font_size)
                        .set("fill", tick_label_color_svg.clone())
                        .set("text-anchor", "end")
                        .set("dominant-baseline", "middle")
                        .add(SvgNodeText::new(tick_label_text));
                    document = document.add(tick_label_svg);
                }
            }
        }
    }

    // Draw Y-axis minor ticks and grids
    for &minor_tick_val in y_minor_ticks.iter() {
        let screen_y = map_y(minor_tick_val);
        if screen_y >= plot_area_y_start - 0.1
            && screen_y <= plot_area_y_start + plot_area_height + 0.1
        {
            // Draw minor grid lines
            if matches!(minor_grid, MinorGrid::YAxis | MinorGrid::Both) {
                match grid {
                    Grid::None => {}
                    Grid::Solid | Grid::Dashed | Grid::Dotted => {
                        let mut minor_grid_line = SvgLine::new()
                            .set("x1", plot_area_x_start)
                            .set("y1", screen_y)
                            .set("x2", plot_area_x_start + plot_area_width)
                            .set("y2", screen_y)
                            .set("stroke", minor_grid_color_svg.clone())
                            .set("stroke-width", grid_config.minor_line_width);
                        
                        // Apply the same dash pattern as the major grid
                        match grid {
                            Grid::Dotted => {
                                minor_grid_line = minor_grid_line.set("stroke-dasharray", "1 2");
                            }
                            Grid::Dashed => {
                                minor_grid_line = minor_grid_line.set("stroke-dasharray", "4 4");
                            }
                            Grid::Solid | Grid::None => {}
                        }
                        
                        document = document.add(minor_grid_line);
                    }
                }
            }

            // Draw minor tick marks
            if tick != Tick::None {
                let tick_direction = if tick == Tick::Inward { -1.0 } else { 1.0 };
                let tick_x_left = plot_area_x_start;
                let tick_x_right = plot_area_x_start + plot_area_width;
                match axis {
                    Axis::BottomLeft | Axis::Box => {
                        let minor_tick_line_left = SvgLine::new()
                            .set("x1", tick_x_left)
                            .set("y1", screen_y)
                            .set("x2", tick_x_left - tick_config.minor_tick_length * tick_direction)
                            .set("y2", screen_y)
                            .set("stroke", minor_tick_color_svg.clone())
                            .set("stroke-width", 0.5);
                        document = document.add(minor_tick_line_left);
                    }
                }
                if axis == Axis::Box {
                    let minor_tick_line_right = SvgLine::new()
                        .set("x1", tick_x_right)
                        .set("y1", screen_y)
                        .set("x2", tick_x_right + tick_config.minor_tick_length * tick_direction)
                        .set("y2", screen_y)
                        .set("stroke", minor_tick_color_svg.clone())
                        .set("stroke-width", 0.5);
                    document = document.add(minor_tick_line_right);
                }
            }
        }
    }

    document
}