quill-sql 0.2.0

A tiny yet serious SQL database in Rust with ARIES-style WAL, 2PL, and B+Tree indexes.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
//! BufferManager coordinates replacement, dirty tracking, and WAL with a shared BufferPool.

use std::sync::Arc;

use bytes::Bytes;
use dashmap::{DashMap, DashSet};
use parking_lot::{Mutex, RwLock};

use crate::buffer::buffer_pool::{BufferPool, FrameId};
use crate::buffer::page::{self, PageId, ReadPageGuard, WritePageGuard, INVALID_PAGE_ID};
use crate::catalog::SchemaRef;
use crate::config::BufferPoolConfig;
use crate::error::{QuillSQLError, QuillSQLResult};
use crate::recovery::{Lsn, WalManager};
use crate::storage::codec::{
    BPlusTreeHeaderPageCodec, BPlusTreeInternalPageCodec, BPlusTreeLeafPageCodec,
    BPlusTreePageCodec, TablePageCodec,
};
use crate::storage::disk_scheduler::DiskScheduler;
use crate::storage::page::{
    BPlusTreeHeaderPage, BPlusTreeInternalPage, BPlusTreeLeafPage, BPlusTreePage, TablePage,
};
use crate::utils::cache::lru_k::LRUKReplacer;
use crate::utils::cache::tiny_lfu::TinyLFU;
use crate::utils::cache::Replacer;

#[derive(Debug)]
pub struct BufferManager {
    pool: Arc<BufferPool>,
    replacer: Arc<RwLock<LRUKReplacer>>,
    inflight_loads: DashMap<PageId, Arc<Mutex<()>>>,
    tiny_lfu: Option<Arc<RwLock<TinyLFU>>>,
    dirty_pages: DashSet<PageId>,
    dirty_page_table: DashMap<PageId, Lsn>,
    wal_manager: Arc<RwLock<Option<Arc<WalManager>>>>,
}

impl BufferManager {
    pub fn new(num_pages: usize, disk_scheduler: Arc<DiskScheduler>) -> Self {
        Self::new_with_config(
            BufferPoolConfig {
                buffer_pool_size: num_pages,
                ..Default::default()
            },
            disk_scheduler,
        )
    }

    pub fn new_with_config(config: BufferPoolConfig, disk_scheduler: Arc<DiskScheduler>) -> Self {
        let pool = Arc::new(BufferPool::new_with_config(config, disk_scheduler));
        let replacer = Arc::new(RwLock::new(LRUKReplacer::new(pool.capacity())));
        let tiny_lfu = if config.tiny_lfu_enable {
            Some(Arc::new(RwLock::new(TinyLFU::new(
                pool.capacity().next_power_of_two(),
                config.tiny_lfu_counters,
            ))))
        } else {
            None
        };

        Self {
            pool,
            replacer,
            inflight_loads: DashMap::new(),
            tiny_lfu,
            dirty_pages: DashSet::new(),
            dirty_page_table: DashMap::new(),
            wal_manager: Arc::new(RwLock::new(None)),
        }
    }

    pub fn buffer_pool(&self) -> Arc<BufferPool> {
        self.pool.clone()
    }

    pub fn replacer_arc(&self) -> Arc<RwLock<LRUKReplacer>> {
        self.replacer.clone()
    }

    pub fn set_wal_manager(&self, wal_manager: Arc<WalManager>) {
        *self.wal_manager.write() = Some(wal_manager);
    }

    pub fn wal_manager(&self) -> Option<Arc<WalManager>> {
        self.wal_manager.read().clone()
    }

    pub fn dirty_page_ids(&self) -> Vec<PageId> {
        self.dirty_pages.iter().map(|entry| *entry.key()).collect()
    }

    pub fn dirty_page_table_snapshot(&self) -> Vec<(PageId, Lsn)> {
        self.dirty_page_table
            .iter()
            .map(|entry| (*entry.key(), *entry.value()))
            .collect()
    }

    fn note_dirty_page(&self, page_id: PageId, rec_lsn: Lsn) {
        self.dirty_pages.insert(page_id);
        self.dirty_page_table.entry(page_id).or_insert(rec_lsn);
    }

    pub fn new_page(self: &Arc<Self>) -> QuillSQLResult<WritePageGuard> {
        if !self.pool.has_free_frame() && self.replacer.read().size() == 0 {
            return Err(QuillSQLError::Storage(
                "Cannot new page because buffer pool is full and no page to evict".to_string(),
            ));
        }

        let frame_id = self.allocate_frame()?;
        let page_id = self.pool.allocate_page_id()?;
        self.pool.insert_mapping(page_id, frame_id);

        {
            let meta = self.pool.frame_meta(frame_id);
            meta.initialize(page_id);
            meta.increment_pin();
        }

        self.pool.reset_frame(frame_id);
        self.replacer_record_access(frame_id)?;
        self.mark_non_evictable(frame_id)?;
        Ok(page::new_write_guard(Arc::clone(self), frame_id))
    }

    pub fn fetch_page_read(self: &Arc<Self>, page_id: PageId) -> QuillSQLResult<ReadPageGuard> {
        if page_id == INVALID_PAGE_ID {
            return Err(QuillSQLError::Storage(
                "fetch_page_read: invalid page id".to_string(),
            ));
        }

        let frame_id = self.ensure_frame(page_id)?;
        {
            let meta = self.pool.frame_meta(frame_id);
            meta.increment_pin();
        }
        self.replacer_record_access(frame_id)?;
        self.mark_non_evictable(frame_id)?;
        Ok(page::new_read_guard(Arc::clone(self), frame_id))
    }

    pub fn fetch_page_write(self: &Arc<Self>, page_id: PageId) -> QuillSQLResult<WritePageGuard> {
        if page_id == INVALID_PAGE_ID {
            return Err(QuillSQLError::Storage(
                "fetch_page_write: invalid page id".to_string(),
            ));
        }

        let frame_id = self.ensure_frame(page_id)?;
        {
            let meta = self.pool.frame_meta(frame_id);
            meta.increment_pin();
        }
        self.replacer_record_access(frame_id)?;
        self.mark_non_evictable(frame_id)?;
        Ok(page::new_write_guard(Arc::clone(self), frame_id))
    }

    pub fn complete_unpin(
        &self,
        page_id: PageId,
        is_dirty: bool,
        rec_lsn_hint: Option<Lsn>,
    ) -> QuillSQLResult<()> {
        if let Some(frame_id) = self.pool.lookup_frame(page_id) {
            let meta = self.pool.frame_meta(frame_id);
            let new_pin_count = if meta.pin_count() > 0 {
                meta.try_decrement_pin().unwrap_or(0)
            } else {
                0
            };
            if is_dirty {
                meta.mark_dirty();
                if let Some(lsn) = rec_lsn_hint {
                    meta.set_lsn(lsn);
                }
                let rec_lsn = rec_lsn_hint.unwrap_or_else(|| meta.lsn());
                self.note_dirty_page(page_id, rec_lsn);
            }
            if new_pin_count == 0 {
                self.mark_evictable(frame_id)?;
            }
        }
        Ok(())
    }

    pub fn fetch_table_page(
        self: &Arc<Self>,
        page_id: PageId,
        schema: SchemaRef,
    ) -> QuillSQLResult<(ReadPageGuard, TablePage)> {
        let guard = self.fetch_page_read(page_id)?;
        let (page, _) = TablePageCodec::decode(guard.data(), schema)?;
        Ok((guard, page))
    }

    pub fn fetch_tree_page(
        self: &Arc<Self>,
        page_id: PageId,
        key_schema: SchemaRef,
    ) -> QuillSQLResult<(ReadPageGuard, BPlusTreePage)> {
        let guard = self.fetch_page_read(page_id)?;
        let (page, _) = BPlusTreePageCodec::decode(guard.data(), key_schema.clone())?;
        Ok((guard, page))
    }

    pub fn fetch_tree_internal_page(
        self: &Arc<Self>,
        page_id: PageId,
        key_schema: SchemaRef,
    ) -> QuillSQLResult<(ReadPageGuard, BPlusTreeInternalPage)> {
        let guard = self.fetch_page_read(page_id)?;
        let (page, _) = BPlusTreeInternalPageCodec::decode(guard.data(), key_schema.clone())?;
        Ok((guard, page))
    }

    pub fn fetch_tree_leaf_page(
        self: &Arc<Self>,
        page_id: PageId,
        key_schema: SchemaRef,
    ) -> QuillSQLResult<(ReadPageGuard, BPlusTreeLeafPage)> {
        let guard = self.fetch_page_read(page_id)?;
        let (page, _) = BPlusTreeLeafPageCodec::decode(guard.data(), key_schema.clone())?;
        Ok((guard, page))
    }

    pub fn fetch_header_page(
        self: &Arc<Self>,
        page_id: PageId,
    ) -> QuillSQLResult<(ReadPageGuard, BPlusTreeHeaderPage)> {
        let guard = self.fetch_page_read(page_id)?;
        let (header, _) = BPlusTreeHeaderPageCodec::decode(guard.data())?;
        Ok((guard, header))
    }

    pub fn prefetch_page(self: &Arc<Self>, page_id: PageId) -> QuillSQLResult<()> {
        if let Ok(g) = self.fetch_page_read(page_id) {
            drop(g);
        }
        Ok(())
    }

    pub fn flush_page(&self, page_id: PageId) -> QuillSQLResult<bool> {
        let Some(frame_id) = self.pool.lookup_frame(page_id) else {
            return Ok(false);
        };
        let meta = self.pool.frame_meta(frame_id);
        if !meta.is_dirty() {
            self.dirty_pages.remove(&page_id);
            self.dirty_page_table.remove(&page_id);
            return Ok(false);
        }
        let lsn = meta.lsn();
        self.ensure_wal_durable(lsn)?;
        let bytes = {
            let _lock = self.pool.frame_lock(frame_id).read();
            let slice = unsafe { self.pool.frame_slice(frame_id) };
            Bytes::copy_from_slice(slice)
        };
        self.pool.write_page_to_disk(page_id, bytes)?;
        meta.clear_dirty();
        self.dirty_pages.remove(&page_id);
        self.dirty_page_table.remove(&page_id);
        Ok(true)
    }

    pub fn flush_all_pages(&self) -> QuillSQLResult<()> {
        if let Some(wal) = self.wal_manager.read().clone() {
            wal.flush(None)?;
        }
        let dirty_ids: Vec<PageId> = self.dirty_pages.iter().map(|entry| *entry.key()).collect();
        for page_id in dirty_ids {
            let _ = self.flush_page(page_id)?;
        }
        Ok(())
    }

    pub fn delete_page(&self, page_id: PageId) -> QuillSQLResult<bool> {
        let (guard, created_here) = if let Some(existing) = self.inflight_loads.get(&page_id) {
            (existing.clone(), false)
        } else {
            let arc = Arc::new(Mutex::new(()));
            self.inflight_loads.insert(page_id, arc.clone());
            (arc, true)
        };
        let lock = guard.lock();
        let result = self.delete_page_inner(page_id);
        drop(lock);
        if created_here {
            self.inflight_loads.remove(&page_id);
        }
        result
    }

    fn delete_page_inner(&self, page_id: PageId) -> QuillSQLResult<bool> {
        if let Some(frame_id) = self.pool.lookup_frame(page_id) {
            let lock = self.pool.frame_lock(frame_id);
            let guard = match lock.try_write() {
                Some(g) => g,
                None => return Ok(false),
            };
            drop(guard);
            let meta = self.pool.frame_meta(frame_id);
            if meta.page_id() != page_id {
                self.pool.remove_mapping_if(page_id, frame_id);
                return self.delete_page_inner(page_id);
            }
            if meta.pin_count() > 0 {
                return Ok(false);
            }
            if !self.pool.remove_mapping_if(page_id, frame_id) {
                return self.delete_page_inner(page_id);
            }
            self.pool.reset_frame(frame_id);
            self.dirty_pages.remove(&page_id);
            self.dirty_page_table.remove(&page_id);
            self.pool.clear_frame_meta(frame_id);
            {
                let mut rep = self.replacer.write();
                let _ = rep.set_evictable(frame_id, true);
                rep.remove(frame_id);
            }
            self.pool.push_free_frame(frame_id);
            self.pool
                .disk_scheduler()
                .schedule_deallocate(page_id)?
                .recv()
                .map_err(|e| QuillSQLError::Internal(format!("Channel disconnected: {}", e)))??;
            Ok(true)
        } else {
            self.pool
                .disk_scheduler()
                .schedule_deallocate(page_id)?
                .recv()
                .map_err(|e| QuillSQLError::Internal(format!("Channel disconnected: {}", e)))??;
            Ok(true)
        }
    }

    fn ensure_frame(&self, page_id: PageId) -> QuillSQLResult<FrameId> {
        if let Some(frame_id) = self.pool.lookup_frame(page_id) {
            self.replacer_record_access(frame_id)?;
            if let Some(lfu) = &self.tiny_lfu {
                lfu.write().admit_record(page_id as u64);
            }
            return Ok(frame_id);
        }

        let (guard, created_here) = if let Some(existing) = self.inflight_loads.get(&page_id) {
            (existing.clone(), false)
        } else {
            let arc = Arc::new(Mutex::new(()));
            self.inflight_loads.insert(page_id, arc.clone());
            (arc, true)
        };
        let _lock = guard.lock();

        if let Some(frame_id) = self.pool.lookup_frame(page_id) {
            if created_here {
                self.inflight_loads.remove(&page_id);
            }
            self.replacer_record_access(frame_id)?;
            if let Some(lfu) = &self.tiny_lfu {
                lfu.write().admit_record(page_id as u64);
            }
            return Ok(frame_id);
        }

        if let Some(lfu) = &self.tiny_lfu {
            let estimate = lfu.read().estimate(page_id as u64);
            if estimate == 0 && !self.pool.has_free_frame() && self.replacer.read().size() == 0 {
                if created_here {
                    self.inflight_loads.remove(&page_id);
                }
                return Err(QuillSQLError::Storage(
                    "Cannot allocate frame: admission denied and no space".to_string(),
                ));
            }
        }

        let frame_id = self.allocate_frame()?;
        self.pool.load_page_into_frame(page_id, frame_id)?;
        self.pool.insert_mapping(page_id, frame_id);

        if let Some(lfu) = &self.tiny_lfu {
            lfu.write().admit_record(page_id as u64);
        }
        if created_here {
            self.inflight_loads.remove(&page_id);
        }
        self.replacer_record_access(frame_id)?;
        Ok(frame_id)
    }

    fn allocate_frame(&self) -> QuillSQLResult<FrameId> {
        if let Some(frame_id) = self.pool.pop_free_frame() {
            return Ok(frame_id);
        }
        self.evict_victim_frame()
    }

    fn replacer_record_access(&self, frame_id: FrameId) -> QuillSQLResult<()> {
        let mut rep = self.replacer.write();
        let _ = rep.record_access(frame_id);
        Ok(())
    }

    fn evict_victim_frame(&self) -> QuillSQLResult<FrameId> {
        loop {
            let victim = {
                let mut rep = self.replacer.write();
                match rep.evict() {
                    Some(frame_id) => frame_id,
                    None => {
                        return Err(QuillSQLError::Storage(
                            "Cannot allocate frame: buffer pool is full".to_string(),
                        ))
                    }
                }
            };

            let snapshot = self.pool.frame_meta(victim).snapshot();
            let page_id = snapshot.page_id;
            let pin_count = snapshot.pin_count;
            let is_dirty = snapshot.is_dirty;
            let lsn = snapshot.lsn;

            if pin_count > 0 {
                let mut rep = self.replacer.write();
                let _ = rep.record_access(victim);
                let _ = rep.set_evictable(victim, false);
                continue;
            }

            if page_id != INVALID_PAGE_ID {
                if is_dirty {
                    self.ensure_wal_durable(lsn)?;
                    let bytes = Bytes::copy_from_slice(unsafe { self.pool.frame_slice(victim) });
                    self.pool.write_page_to_disk(page_id, bytes)?;
                    self.dirty_pages.remove(&page_id);
                    self.dirty_page_table.remove(&page_id);
                }
                self.pool.remove_mapping(page_id);
            }

            self.pool.clear_frame_meta(victim);
            self.pool.reset_frame(victim);
            return Ok(victim);
        }
    }

    fn mark_evictable(&self, frame_id: FrameId) -> QuillSQLResult<()> {
        let mut rep = self.replacer.write();
        let _ = rep.set_evictable(frame_id, true);
        Ok(())
    }

    fn mark_non_evictable(&self, frame_id: FrameId) -> QuillSQLResult<()> {
        let mut rep = self.replacer.write();
        let _ = rep.set_evictable(frame_id, false);
        Ok(())
    }

    fn ensure_wal_durable(&self, lsn: Lsn) -> QuillSQLResult<()> {
        if lsn == 0 {
            return Ok(());
        }
        if let Some(wal) = self.wal_manager.read().clone() {
            if lsn > wal.durable_lsn() {
                wal.flush(Some(lsn))?;
                if wal.durable_lsn() < lsn {
                    return Err(QuillSQLError::Internal(format!(
                        "Flush blocked: page_lsn={} > durable_lsn={}",
                        lsn,
                        wal.durable_lsn()
                    )));
                }
            }
        }
        Ok(())
    }

    pub fn clone_arc(self: &Arc<Self>) -> Arc<Self> {
        self.clone()
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::storage::disk_manager::DiskManager;
    use crate::storage::disk_scheduler::DiskScheduler;
    use std::sync::{Arc, Barrier};
    use std::thread;
    use tempfile::TempDir;

    fn setup_manager(num_pages: usize) -> (TempDir, Arc<BufferManager>) {
        let temp_dir = TempDir::new().unwrap();
        let db_file = temp_dir.path().join("test.db");
        let disk_manager = Arc::new(DiskManager::try_new(db_file).unwrap());
        let disk_scheduler = Arc::new(DiskScheduler::new(disk_manager));
        let manager = Arc::new(BufferManager::new(num_pages, disk_scheduler));
        (temp_dir, manager)
    }

    #[test]
    fn new_page_initializes_frame() {
        let (_tmp, manager) = setup_manager(2);
        let guard = manager.new_page().unwrap();
        let page_id = guard.page_id();
        let frame_id = guard.frame_id();

        // Page should be zeroed
        assert!(guard.data().iter().all(|b| *b == 0));
        assert!(!guard.is_dirty());
        assert_eq!(guard.lsn(), 0);

        drop(guard);

        let meta = manager.buffer_pool().frame_meta(frame_id).snapshot();
        assert_eq!(meta.page_id, page_id);
        assert_eq!(meta.pin_count, 0);
        assert!(!meta.is_dirty);
    }

    #[test]
    fn fetch_page_read_increments_pin_and_resets_on_drop() {
        let (_tmp, manager) = setup_manager(2);
        let guard = manager.new_page().unwrap();
        let page_id = guard.page_id();
        let frame_id = guard.frame_id();
        drop(guard);

        {
            let read_guard = manager.fetch_page_read(page_id).unwrap();
            assert_eq!(read_guard.pin_count(), 1);
            assert_eq!(read_guard.frame_id(), frame_id);
        }

        let meta = manager.buffer_pool().frame_meta(frame_id).snapshot();
        assert_eq!(meta.pin_count, 0);
    }

    #[test]
    fn fetch_page_write_marks_dirty_and_tracks_lsn() {
        let (_tmp, manager) = setup_manager(2);
        let mut guard = manager.new_page().unwrap();
        let page_id = guard.page_id();
        guard.data_mut()[0] = 7;
        guard.set_lsn(99);
        guard.mark_dirty();
        drop(guard);

        let mut write_guard = manager.fetch_page_write(page_id).unwrap();
        assert!(write_guard.is_dirty());
        assert_eq!(write_guard.lsn(), 99);
        write_guard.data_mut()[1] = 8;
        drop(write_guard);

        let meta = manager
            .buffer_pool()
            .frame_meta(manager.buffer_pool().lookup_frame(page_id).unwrap())
            .snapshot();
        assert!(meta.is_dirty);
        assert_eq!(meta.lsn, 99);
        assert_eq!(meta.pin_count, 0);
    }

    #[test]
    fn flush_page_writes_back_and_clears_dirty_flag() {
        let (_tmp, manager) = setup_manager(2);
        let mut guard = manager.new_page().unwrap();
        let page_id = guard.page_id();
        guard.data_mut()[0] = 42;
        guard.set_lsn(123);
        guard.mark_dirty();
        drop(guard);

        assert!(manager.flush_page(page_id).unwrap());

        let meta = manager
            .buffer_pool()
            .frame_meta(manager.buffer_pool().lookup_frame(page_id).unwrap())
            .snapshot();
        assert!(!meta.is_dirty);
    }

    #[test]
    fn delete_page_releases_frame() {
        let (_tmp, manager) = setup_manager(2);
        let page_id = {
            let guard = manager.new_page().unwrap();
            guard.page_id()
        };

        assert!(manager.delete_page(page_id).unwrap());
        assert!(manager.buffer_pool().lookup_frame(page_id).is_none());
        assert!(manager.buffer_pool().has_free_frame());

        // Ensure subsequent allocation succeeds and pool remains operational
        let new_guard = manager.new_page().unwrap();
        assert!(new_guard.frame_id() < manager.buffer_pool().capacity());
    }

    #[test]
    fn concurrent_reads_do_not_leak_pins() {
        const THREADS: usize = 8;
        let (_tmp, manager) = setup_manager(4);
        let (page_id, frame_id) = {
            let mut guard = manager.new_page().unwrap();
            guard.data_mut()[0] = 42;
            (guard.page_id(), guard.frame_id())
        };

        let barrier = Arc::new(Barrier::new(THREADS));
        let mut handles = Vec::with_capacity(THREADS);
        for _ in 0..THREADS {
            let mgr = manager.clone();
            let barrier = barrier.clone();
            handles.push(thread::spawn(move || {
                barrier.wait();
                for _ in 0..50 {
                    let guard = mgr.fetch_page_read(page_id).expect("read page");
                    assert_eq!(guard.data()[0], 42);
                }
            }));
        }

        for handle in handles {
            handle.join().unwrap();
        }

        let pool = manager.buffer_pool();
        let meta = pool.frame_meta(frame_id).snapshot();
        assert_eq!(meta.pin_count, 0);
        assert_eq!(meta.page_id, page_id);
    }

    #[test]
    fn concurrent_writes_mark_dirty_and_flush_once() {
        const THREADS: usize = 4;
        let (_tmp, manager) = setup_manager(4);
        let (page_id, frame_id) = {
            let guard = manager.new_page().unwrap();
            (guard.page_id(), guard.frame_id())
        };

        let barrier = Arc::new(Barrier::new(THREADS));
        let mut handles = Vec::with_capacity(THREADS);
        for tid in 0..THREADS {
            let mgr = manager.clone();
            let barrier = barrier.clone();
            handles.push(thread::spawn(move || {
                let lsn = (tid as Lsn) + 1;
                barrier.wait();
                for _ in 0..25 {
                    let mut guard = mgr.fetch_page_write(page_id).expect("write guard");
                    guard.data_mut()[tid] = (tid as u8) + 1;
                    guard.set_lsn(lsn);
                    guard.mark_dirty();
                }
            }));
        }

        for handle in handles {
            handle.join().unwrap();
        }

        {
            let pool = manager.buffer_pool();
            let meta = pool.frame_meta(frame_id).snapshot();
            assert!(meta.is_dirty);
            assert_eq!(meta.pin_count, 0);
            assert_eq!(meta.page_id, page_id);
        }

        assert!(manager.flush_page(page_id).unwrap());
        {
            let pool = manager.buffer_pool();
            let meta = pool.frame_meta(frame_id).snapshot();
            assert!(!meta.is_dirty);
            assert_eq!(meta.pin_count, 0);
        }

        let read_back = manager
            .buffer_pool()
            .disk_scheduler()
            .schedule_read(page_id)
            .unwrap()
            .recv()
            .unwrap()
            .unwrap();
        for tid in 0..THREADS {
            assert_eq!(read_back[tid], (tid as u8) + 1);
        }
    }
}