queue-runtime 0.2.0

Multi-provider queue runtime for Queue-Keeper
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
//! NATS provider implementation using JetStream.
//!
//! This module provides production-ready NATS integration via the `async-nats` client
//! with JetStream.  It implements the [`QueueProvider`] and [`SessionProvider`] traits,
//! enabling NATS to be used as a drop-in backend in the queue-runtime abstraction layer.
//!
//! ## Key Features
//!
//! - **JetStream**: Persistent, at-least-once message delivery with ack/nak semantics
//! - **Pull consumers**: Explicit message fetch with configurable ack-wait (visibility
//!   timeout analog)
//! - **Dead letter support**: Failed messages forwarded to a configurable DLQ stream
//! - **Session emulation**: Sessions emulated via per-session filter subjects within a
//!   shared stream
//! - **Batch operations**: Up to 100 messages per batch
//!
//! ## Stream and Subject Naming
//!
//! The provider creates one JetStream stream per queue.  Naming conventions:
//!
//! - Stream name: `{stream_prefix}-{queue_name}` (hyphens replace underscores for
//!   NATS compatibility)
//! - Subject: `{stream_prefix}.{queue_name}`
//! - Session subject: `{stream_prefix}.{queue_name}.session.{session_id}`
//!
//! ## Dead Letter Support
//!
//! When `enable_dead_letter` is `true` and `dead_letter_subject_prefix` is set,
//! messages dead-lettered via [`dead_letter_message`] are published to
//! `{prefix}.{queue_name}` using a separate JetStream stream for DLQ messages.
//!
//! ## Session Support
//!
//! Sessions are emulated via JetStream subject filtering.  Each session gets its own
//! subject (`{prefix}.{queue}.session.{session_id}`), and a [`NatsSessionProvider`]
//! creates a per-session pull consumer filtered to that subject.
//!
//! ## Connection
//!
//! The provider uses the `async-nats` client which reconnects automatically on
//! connection loss.  Optional NATS credentials can be loaded from a `.creds` file
//! via the `credentials_path` configuration field.
//!
//! ## Testing
//!
//! ```rust,no_run
//! use queue_runtime::providers::NatsProvider;
//! use queue_runtime::NatsConfig;
//!
//! # async fn test_example() {
//! let config = NatsConfig {
//!     url: "nats://localhost:4222".to_string(),
//!     ..NatsConfig::default()
//! };
//!
//! let provider = NatsProvider::new(config).await.unwrap();
//! # }
//! ```

use crate::client::{QueueProvider, SessionProvider};
use crate::error::QueueError;
use crate::message::{
    Message, MessageId, QueueName, ReceiptHandle, ReceivedMessage, SessionId, Timestamp,
};
use crate::provider::{ProviderType, SessionSupport};
use async_nats::jetstream::{
    self, consumer::pull::Config as ConsumerConfig, stream::Config as StreamConfig, AckKind,
    Context as JetStreamContext,
};
use async_trait::async_trait;
use bytes::Bytes;
use chrono::Duration;
use futures::StreamExt;
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::sync::Arc;
use tokio::sync::Mutex;
use tracing::{debug, instrument, warn};

#[cfg(test)]
#[path = "nats_tests.rs"]
mod tests;

// ============================================================================
// Configuration
// ============================================================================

/// NATS provider configuration using JetStream
///
/// # Examples
///
/// ```rust
/// use queue_runtime::NatsConfig;
/// use chrono::Duration;
///
/// let config = NatsConfig {
///     url: "nats://localhost:4222".to_string(),
///     stream_prefix: "queue-runtime".to_string(),
///     max_deliver: Some(3),
///     ack_wait: Duration::seconds(30),
///     session_lock_duration: Duration::minutes(5),
///     enable_dead_letter: true,
///     dead_letter_subject_prefix: Some("dlq".to_string()),
///     credentials_path: None,
/// };
/// ```
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct NatsConfig {
    /// NATS server URL (e.g. `nats://localhost:4222` or `nats://user:pass@host:port`)
    pub url: String,
    /// Prefix for JetStream stream names (stream name = `{prefix}-{queue_name}`)
    pub stream_prefix: String,
    /// Maximum number of delivery attempts before giving up (None = unlimited)
    pub max_deliver: Option<i64>,
    /// Duration to wait for ack before re-delivering (visibility timeout analog)
    pub ack_wait: Duration,
    /// Duration to hold a session lock before expiry
    pub session_lock_duration: Duration,
    /// Whether to enable dead letter queue routing via a separate stream
    pub enable_dead_letter: bool,
    /// Subject prefix for dead letter messages (`{prefix}.{queue}`)
    pub dead_letter_subject_prefix: Option<String>,
    /// Path to NATS credentials file (`.creds` format)
    pub credentials_path: Option<String>,
}

impl Default for NatsConfig {
    fn default() -> Self {
        Self {
            url: "nats://localhost:4222".to_string(),
            stream_prefix: "queue-runtime".to_string(),
            max_deliver: Some(3),
            ack_wait: Duration::seconds(30),
            session_lock_duration: Duration::minutes(5),
            enable_dead_letter: true,
            dead_letter_subject_prefix: Some("dlq".to_string()),
            credentials_path: None,
        }
    }
}

// ============================================================================
// Error types
// ============================================================================

/// NATS-specific error type.
#[derive(Debug)]
pub struct NatsError {
    message: String,
}

impl NatsError {
    fn new(message: impl Into<String>) -> Self {
        Self {
            message: message.into(),
        }
    }

    /// Convert to a [`QueueError`].
    pub fn to_queue_error(&self) -> QueueError {
        QueueError::ProviderError {
            provider: "nats".to_string(),
            code: "NATS_ERROR".to_string(),
            message: self.message.clone(),
        }
    }
}

impl std::fmt::Display for NatsError {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "NATS error: {}", self.message)
    }
}

impl std::error::Error for NatsError {}

// ============================================================================
// Internal helpers
// ============================================================================

/// An in-flight JetStream message pending acknowledgement.
struct InFlightEntry {
    /// The JetStream message (contains ack/nak methods)
    js_message: async_nats::jetstream::Message,
    /// Lock expiry (maps to the JetStream ack-wait on the consumer)
    lock_expires_at: Timestamp,
    /// Dead letter subject for this message's queue
    dead_letter_subject: Option<String>,
}

// ============================================================================
// Helper functions
// ============================================================================

/// Redact any userinfo (username and password) from a URL, keeping host and path.
///
/// Used to prevent credential leakage in log fields and error messages when
/// connection URLs contain embedded credentials
/// (e.g. `nats://user:pass@host:4222` → `nats://***:***@host:4222`).
fn redact_url(url: &str) -> String {
    match url::Url::parse(url) {
        Ok(mut parsed) => {
            let has_credentials = !parsed.username().is_empty() || parsed.password().is_some();
            if has_credentials {
                let _ = parsed.set_username("***");
                let _ = parsed.set_password(Some("***"));
            }
            parsed.to_string()
        }
        Err(_) => "<invalid-url>".to_string(),
    }
}

/// Sanitise a queue name for use in NATS subject/stream identifiers.
///
/// NATS subjects use `.` as a separator and do not allow spaces.
fn nats_safe(s: &str) -> String {
    s.replace(['-', ' '], "_")
}

/// Build the NATS subject for a queue.
fn queue_subject(config: &NatsConfig, queue: &QueueName) -> String {
    format!(
        "{}.{}",
        nats_safe(&config.stream_prefix),
        nats_safe(queue.as_str())
    )
}

/// Sanitise a session ID for use in NATS subject and consumer name identifiers.
///
/// NATS subjects use `.` as a wildcard-separator and consumer/stream names must
/// contain only alphanumeric characters, underscores, or hyphens.  This helper
/// replaces every character that is not an ASCII alphanumeric or `_` with `_`,
/// covering all NATS-invalid characters (`.`, `/`, ` `, `*`, `>`, etc.).
fn nats_safe_session_id(id: &str) -> String {
    id.chars()
        .map(|c| {
            if c.is_ascii_alphanumeric() || c == '_' {
                c
            } else {
                '_'
            }
        })
        .collect()
}

/// Build the NATS subject for a session within a queue.
fn session_subject(config: &NatsConfig, queue: &QueueName, session_id: &SessionId) -> String {
    let safe_session = nats_safe_session_id(session_id.as_str());
    format!(
        "{}.{}.session.{}",
        nats_safe(&config.stream_prefix),
        nats_safe(queue.as_str()),
        safe_session
    )
}

/// Build the JetStream stream name for a queue.
fn stream_name(config: &NatsConfig, queue: &QueueName) -> String {
    // JetStream stream names may not contain dots.
    format!(
        "{}-{}",
        nats_safe(&config.stream_prefix),
        nats_safe(queue.as_str())
    )
}

/// Build a stable durable consumer name for a queue.
///
/// Using a named durable consumer (rather than an ephemeral one) means that
/// `Info::delivered` increments across successive `receive_message` calls,
/// even when each call creates a fresh handle to the server-side consumer.
/// With ephemeral consumers the server issues a new consumer-sequence on each
/// call, and `num_delivered` is always 1 from the new consumer's perspective.
fn consumer_name(config: &NatsConfig, queue: &QueueName) -> String {
    format!(
        "{}-{}-consumer",
        nats_safe(&config.stream_prefix),
        nats_safe(queue.as_str())
    )
}

/// Build a stable durable consumer name for a session consumer.
///
/// Session consumers must have a name that is distinct from the queue-level
/// consumer returned by [`consumer_name`].  NATS enforces config consistency
/// on named durable consumers: if the same name is submitted with a different
/// `filter_subject` the server returns an error (or silently reuses the old
/// consumer, routing messages through the wrong filter).  Incorporating the
/// session ID into the name keeps each session consumer independent.
fn session_consumer_name(config: &NatsConfig, queue: &QueueName, session_id: &SessionId) -> String {
    let safe_sid = nats_safe_session_id(session_id.as_str());
    format!(
        "{}-{}-session-{}-consumer",
        nats_safe(&config.stream_prefix),
        nats_safe(queue.as_str()),
        safe_sid
    )
}

/// Build the dead-letter subject for a queue if DLQ is enabled.
fn dead_letter_subject(config: &NatsConfig, queue: &QueueName) -> Option<String> {
    if !config.enable_dead_letter {
        return None;
    }
    config
        .dead_letter_subject_prefix
        .as_ref()
        .map(|prefix| format!("{}.{}", nats_safe(prefix), nats_safe(queue.as_str())))
}

// ============================================================================
// NatsProvider
// ============================================================================

/// NATS queue provider using JetStream for persistent, at-least-once delivery.
///
/// Each queue maps to a JetStream stream created on demand.  Messages are published
/// to per-queue subjects and consumed via pull consumers.
pub struct NatsProvider {
    client: async_nats::Client,
    jetstream: JetStreamContext,
    config: NatsConfig,
    /// In-flight messages indexed by their receipt handle UUID.
    in_flight: Arc<Mutex<HashMap<String, InFlightEntry>>>,
}

impl NatsProvider {
    /// Create a new [`NatsProvider`] and connect to the NATS server.
    ///
    /// # Errors
    ///
    /// Returns [`NatsError`] if the connection cannot be established or the
    /// credentials file cannot be read.
    ///
    /// # Examples
    ///
    /// ```rust,no_run
    /// use queue_runtime::providers::NatsProvider;
    /// use queue_runtime::NatsConfig;
    ///
    /// # async fn example() {
    /// let config = NatsConfig::default();
    /// let provider = NatsProvider::new(config).await.unwrap();
    /// # }
    /// ```
    pub async fn new(config: NatsConfig) -> Result<Self, NatsError> {
        let connect_options = if let Some(ref creds_path) = config.credentials_path {
            async_nats::ConnectOptions::with_credentials_file(creds_path.as_str())
                .await
                .map_err(|e| NatsError::new(format!("failed to load NATS credentials: {}", e)))?
        } else {
            async_nats::ConnectOptions::new()
        };

        let client = connect_options.connect(&config.url).await.map_err(|e| {
            NatsError::new(format!(
                "failed to connect to NATS at '{}': {}",
                redact_url(&config.url),
                e
            ))
        })?;

        let jetstream = jetstream::new(client.clone());

        debug!(url = %redact_url(&config.url), "Connected to NATS");

        Ok(Self {
            client,
            jetstream,
            config,
            in_flight: Arc::new(Mutex::new(HashMap::new())),
        })
    }

    /// Ensure a JetStream stream exists for the given queue, creating it if needed.
    ///
    /// Streams are created with the `WorkQueue` retention policy so each message
    /// is delivered to exactly one consumer.
    async fn ensure_stream(&self, queue: &QueueName) -> Result<(), QueueError> {
        let name = stream_name(&self.config, queue);
        let subject = queue_subject(&self.config, queue);

        // Subject wildcard: capture both the main subject and all session subjects.
        let subjects = vec![subject.clone(), format!("{}.session.>", subject)];

        let stream_config = StreamConfig {
            name: name.clone(),
            subjects,
            retention: async_nats::jetstream::stream::RetentionPolicy::WorkQueue,
            storage: async_nats::jetstream::stream::StorageType::File,
            ..Default::default()
        };

        self.jetstream
            .get_or_create_stream(stream_config)
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "STREAM_CREATE_FAILED".to_string(),
                message: format!("failed to ensure JetStream stream '{}': {}", name, e),
            })?;

        // Also ensure the DLQ stream exists if dead letter is enabled.
        self.ensure_dlq_stream(queue).await?;

        Ok(())
    }

    /// Ensure a JetStream stream exists for the dead letter queue.
    async fn ensure_dlq_stream(&self, queue: &QueueName) -> Result<(), QueueError> {
        let dlq_subject = match dead_letter_subject(&self.config, queue) {
            Some(s) => s,
            None => return Ok(()),
        };

        let dlq_stream_name = format!(
            "dlq-{}-{}",
            nats_safe(&self.config.stream_prefix),
            nats_safe(queue.as_str())
        );

        let stream_config = StreamConfig {
            name: dlq_stream_name.clone(),
            subjects: vec![dlq_subject],
            storage: async_nats::jetstream::stream::StorageType::File,
            ..Default::default()
        };

        self.jetstream
            .get_or_create_stream(stream_config)
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "DLQ_STREAM_CREATE_FAILED".to_string(),
                message: format!("failed to ensure DLQ stream '{}': {}", dlq_stream_name, e),
            })?;

        Ok(())
    }

    /// Create or retrieve a named durable pull consumer for the given subject filter.
    ///
    /// Using named durable consumers means the server tracks delivery count across
    /// successive `receive_message` calls (each call reuses the same server-side
    /// consumer, so `Info::delivered` increments correctly on redelivery).
    ///
    /// The `name` parameter must be unique per `filter_subject`.  Queue-level
    /// consumers and per-session consumers must use distinct names (see
    /// [`consumer_name`] and [`session_consumer_name`]) to avoid the NATS server
    /// rejecting a name reuse with a different filter.
    async fn create_consumer(
        &self,
        queue: &QueueName,
        name: &str,
        filter_subject: &str,
    ) -> Result<async_nats::jetstream::consumer::Consumer<ConsumerConfig>, QueueError> {
        let stream_name = stream_name(&self.config, queue);
        let ack_wait_std = self
            .config
            .ack_wait
            .to_std()
            .unwrap_or(std::time::Duration::from_secs(30));

        let consumer_config = ConsumerConfig {
            name: Some(name.to_string()),
            durable_name: Some(name.to_string()),
            filter_subject: filter_subject.to_string(),
            ack_policy: async_nats::jetstream::consumer::AckPolicy::Explicit,
            ack_wait: ack_wait_std,
            max_deliver: self.config.max_deliver.unwrap_or(-1),
            // Expire session consumers after twice the session lock duration so
            // they are cleaned up automatically by the server once a session is
            // no longer in use.  Without this, named durable consumers accumulate
            // indefinitely on the server (one per unique session ID).  Queue-level
            // consumers also benefit: if the process dies, the server reclaims the
            // consumer slot after the inactive window instead of keeping it forever.
            inactive_threshold: self
                .config
                .session_lock_duration
                .to_std()
                .unwrap_or(std::time::Duration::from_secs(300))
                .saturating_mul(2),
            ..Default::default()
        };

        let stream = self.jetstream.get_stream(&stream_name).await.map_err(|e| {
            QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "STREAM_GET_FAILED".to_string(),
                message: format!("failed to get stream '{}': {}", stream_name, e),
            }
        })?;

        let consumer = stream
            .get_or_create_consumer(name, consumer_config)
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "CONSUMER_CREATE_FAILED".to_string(),
                message: format!(
                    "failed to get or create pull consumer on '{}': {}",
                    stream_name, e
                ),
            })?;

        Ok(consumer)
    }

    /// Encode message metadata into NATS message headers.
    fn build_headers(message: &Message) -> async_nats::header::HeaderMap {
        let mut headers = async_nats::header::HeaderMap::new();

        if let Some(ref sid) = message.session_id {
            headers.insert("x-session-id", sid.as_str());
        }
        if let Some(ref corr_id) = message.correlation_id {
            headers.insert("x-correlation-id", corr_id.as_str());
        }
        for (k, v) in &message.attributes {
            // Prefix user attributes to distinguish from provider headers.
            headers.insert(format!("x-attr-{}", k).as_str(), v.as_str());
        }

        headers
    }

    /// Extract message attributes from NATS headers.
    fn extract_attributes(
        headers: &Option<async_nats::header::HeaderMap>,
    ) -> HashMap<String, String> {
        let mut attrs = HashMap::new();
        if let Some(hm) = headers {
            for (name, values) in hm.iter() {
                // HeaderName implements AsRef<str> for &str access
                let key: &str = name.as_ref();
                if let Some(attr_key) = key.strip_prefix("x-attr-") {
                    if let Some(val) = values.first() {
                        attrs.insert(attr_key.to_string(), val.as_str().to_string());
                    }
                }
            }
        }
        attrs
    }

    /// Extract the session ID from NATS headers.
    fn extract_session_id(headers: &Option<async_nats::header::HeaderMap>) -> Option<SessionId> {
        if let Some(hm) = headers {
            if let Some(val) = hm.get("x-session-id") {
                let id = val.as_str().to_string();
                return SessionId::new(id).ok();
            }
        }
        None
    }

    /// Extract the correlation ID from NATS headers.
    fn extract_correlation_id(headers: &Option<async_nats::header::HeaderMap>) -> Option<String> {
        if let Some(hm) = headers {
            if let Some(val) = hm.get("x-correlation-id") {
                return Some(val.as_str().to_string());
            }
        }
        None
    }

    /// Register a JetStream message in the in-flight map and return a [`ReceivedMessage`].
    async fn register_js_message(
        &self,
        js_message: async_nats::jetstream::Message,
        queue: &QueueName,
    ) -> ReceivedMessage {
        let headers = js_message.message.headers.clone();
        let session_id = Self::extract_session_id(&headers);
        let attributes = Self::extract_attributes(&headers);
        let correlation_id = Self::extract_correlation_id(&headers);
        let delivery_count = js_message.info().map(|i| i.delivered as u32).unwrap_or(1);
        let body = Bytes::copy_from_slice(&js_message.message.payload);

        let now = Timestamp::now();
        let lock_expires_at =
            Timestamp::from_datetime(now.as_datetime() + self.config.session_lock_duration);

        let receipt_id = uuid::Uuid::new_v4().to_string();
        let message_id = MessageId::new();

        let dlq_subject = dead_letter_subject(&self.config, queue);

        self.in_flight.lock().await.insert(
            receipt_id.clone(),
            InFlightEntry {
                js_message,
                lock_expires_at,
                dead_letter_subject: dlq_subject,
            },
        );

        ReceivedMessage {
            message_id,
            body,
            attributes,
            session_id,
            correlation_id,
            receipt_handle: ReceiptHandle::new(receipt_id, lock_expires_at, ProviderType::Nats),
            delivery_count,
            first_delivered_at: now,
            delivered_at: now,
        }
    }
}

// ============================================================================
// QueueProvider implementation
// ============================================================================

#[async_trait]
impl QueueProvider for NatsProvider {
    #[instrument(skip(self, message), fields(queue = %queue))]
    async fn send_message(
        &self,
        queue: &QueueName,
        message: &Message,
    ) -> Result<MessageId, QueueError> {
        let size = message.body.len();
        let max_size = self.provider_type().max_message_size();
        if size > max_size {
            return Err(QueueError::MessageTooLarge { size, max_size });
        }

        self.ensure_stream(queue).await?;

        // Route to session subject if session_id is set, otherwise main subject.
        let subject = if let Some(ref sid) = message.session_id {
            session_subject(&self.config, queue, sid)
        } else {
            queue_subject(&self.config, queue)
        };

        let headers = Self::build_headers(message);
        let payload = Bytes::copy_from_slice(&message.body);

        self.jetstream
            .publish_with_headers(subject.clone(), headers, payload)
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "PUBLISH_FAILED".to_string(),
                message: format!("failed to publish to subject '{}': {}", subject, e),
            })?
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "PUBLISH_ACK_FAILED".to_string(),
                message: format!("JetStream publish ack failed: {}", e),
            })?;

        let message_id = MessageId::new();
        debug!(%message_id, %queue, "Published message to NATS JetStream");
        Ok(message_id)
    }

    #[instrument(skip(self, messages), fields(queue = %queue, count = messages.len()))]
    async fn send_messages(
        &self,
        queue: &QueueName,
        messages: &[Message],
    ) -> Result<Vec<MessageId>, QueueError> {
        if messages.len() > self.max_batch_size() as usize {
            return Err(QueueError::BatchTooLarge {
                size: messages.len(),
                max_size: self.max_batch_size() as usize,
            });
        }

        // JetStream has no multi-message publish; messages are sent sequentially.
        // This satisfies the batch API contract (multiple IDs returned in one call)
        // but does not reduce the number of network round-trips compared with
        // individual send_message calls.  The NATS protocol does not expose a
        // PublishBatch primitive, so sequential sending is the best achievable
        // implementation.  See docs/spec/assertions.md Assertion 20 for context.
        let mut ids = Vec::with_capacity(messages.len());
        for message in messages {
            ids.push(self.send_message(queue, message).await?);
        }
        Ok(ids)
    }

    #[instrument(skip(self), fields(queue = %queue))]
    async fn receive_message(
        &self,
        queue: &QueueName,
        timeout: Duration,
    ) -> Result<Option<ReceivedMessage>, QueueError> {
        self.ensure_stream(queue).await?;

        let subject = queue_subject(&self.config, queue);
        let name = consumer_name(&self.config, queue);
        let consumer = self.create_consumer(queue, &name, &subject).await?;

        let timeout_std = timeout
            .to_std()
            .unwrap_or(std::time::Duration::from_secs(30));

        let mut messages = consumer
            .fetch()
            .max_messages(1)
            .expires(timeout_std)
            .messages()
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "FETCH_FAILED".to_string(),
                message: format!("failed to fetch from JetStream: {}", e),
            })?;

        match tokio::time::timeout(timeout_std, messages.next()).await {
            Ok(Some(Ok(js_msg))) => {
                let msg = self.register_js_message(js_msg, queue).await;
                Ok(Some(msg))
            }
            Ok(Some(Err(e))) => Err(QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "MESSAGE_ERROR".to_string(),
                message: format!("error reading JetStream message: {}", e),
            }),
            Ok(None) | Err(_) => Ok(None),
        }
    }

    #[instrument(skip(self), fields(queue = %queue, max = max_messages))]
    async fn receive_messages(
        &self,
        queue: &QueueName,
        max_messages: u32,
        timeout: Duration,
    ) -> Result<Vec<ReceivedMessage>, QueueError> {
        self.ensure_stream(queue).await?;

        let subject = queue_subject(&self.config, queue);
        let name = consumer_name(&self.config, queue);
        let consumer = self.create_consumer(queue, &name, &subject).await?;

        let timeout_std = timeout
            .to_std()
            .unwrap_or(std::time::Duration::from_secs(30));

        let mut js_messages = consumer
            .fetch()
            .max_messages(max_messages as usize)
            .expires(timeout_std)
            .messages()
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "FETCH_FAILED".to_string(),
                message: format!("failed to fetch from JetStream: {}", e),
            })?;

        let mut result = Vec::new();
        let deadline = tokio::time::Instant::now() + timeout_std;

        loop {
            let remaining = deadline.saturating_duration_since(tokio::time::Instant::now());
            if remaining.is_zero() || result.len() >= max_messages as usize {
                break;
            }

            match tokio::time::timeout(remaining, js_messages.next()).await {
                Ok(Some(Ok(js_msg))) => {
                    let msg = self.register_js_message(js_msg, queue).await;
                    result.push(msg);
                }
                Ok(Some(Err(e))) => {
                    return Err(QueueError::ProviderError {
                        provider: "nats".to_string(),
                        code: "MESSAGE_ERROR".to_string(),
                        message: format!("error reading JetStream message: {}", e),
                    });
                }
                Ok(None) | Err(_) => break,
            }
        }

        Ok(result)
    }

    #[instrument(skip(self, receipt))]
    async fn complete_message(&self, receipt: &ReceiptHandle) -> Result<(), QueueError> {
        let mut in_flight = self.in_flight.lock().await;

        // Check existence and expiry before removal so callers receive a
        // meaningful error and the JetStream message is not abandoned silently.
        match in_flight.get(receipt.handle()) {
            None => {
                return Err(QueueError::MessageNotFound {
                    receipt: receipt.handle().to_string(),
                });
            }
            Some(entry) if Timestamp::now() > entry.lock_expires_at => {
                in_flight.remove(receipt.handle());
                return Err(QueueError::MessageNotFound {
                    receipt: format!("{}(expired)", receipt.handle()),
                });
            }
            Some(_) => {}
        }

        let entry = in_flight
            .remove(receipt.handle())
            .expect("entry present after pre-check");

        entry
            .js_message
            .ack()
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "ACK_FAILED".to_string(),
                message: format!("JetStream ack failed: {}", e),
            })?;

        Ok(())
    }

    #[instrument(skip(self, receipt))]
    async fn abandon_message(&self, receipt: &ReceiptHandle) -> Result<(), QueueError> {
        let mut in_flight = self.in_flight.lock().await;

        match in_flight.get(receipt.handle()) {
            None => {
                return Err(QueueError::MessageNotFound {
                    receipt: receipt.handle().to_string(),
                });
            }
            Some(entry) if Timestamp::now() > entry.lock_expires_at => {
                in_flight.remove(receipt.handle());
                return Err(QueueError::MessageNotFound {
                    receipt: format!("{}(expired)", receipt.handle()),
                });
            }
            Some(_) => {}
        }

        let entry = in_flight
            .remove(receipt.handle())
            .expect("entry present after pre-check");

        entry
            .js_message
            .ack_with(AckKind::Nak(None))
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "NAK_FAILED".to_string(),
                message: format!("JetStream nak failed: {}", e),
            })?;

        Ok(())
    }

    #[instrument(skip(self, receipt), fields(reason = %reason))]
    async fn dead_letter_message(
        &self,
        receipt: &ReceiptHandle,
        reason: &str,
    ) -> Result<(), QueueError> {
        let mut in_flight = self.in_flight.lock().await;

        match in_flight.get(receipt.handle()) {
            None => {
                return Err(QueueError::MessageNotFound {
                    receipt: receipt.handle().to_string(),
                });
            }
            Some(entry) if Timestamp::now() > entry.lock_expires_at => {
                in_flight.remove(receipt.handle());
                return Err(QueueError::MessageNotFound {
                    receipt: format!("{}(expired)", receipt.handle()),
                });
            }
            Some(_) => {}
        }

        let entry = in_flight
            .remove(receipt.handle())
            .expect("entry present after pre-check");

        // Terminate delivery so JetStream stops redelivering this message.
        // This must happen before the DLQ publish so that even if DLQ write
        // fails the message is not stuck in re-delivery.
        entry
            .js_message
            .ack_with(async_nats::jetstream::AckKind::Term)
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "TERM_FAILED".to_string(),
                message: format!("JetStream term ack failed: {}", e),
            })?;

        // Publish to DLQ stream if configured.  The Term above is the
        // authoritative action; DLQ publishing is best-effort.  If the
        // publish fails the message has still been terminated from JetStream
        // (it will not be redelivered), so we log the error and return Ok
        // rather than signalling failure to the caller.
        if let Some(ref dlq_subject) = entry.dead_letter_subject {
            let mut headers = async_nats::header::HeaderMap::new();
            headers.insert("x-dead-letter-reason", reason);
            let payload = entry.js_message.message.payload.clone();
            if let Some(msg_headers) = &entry.js_message.message.headers {
                for (name, values) in msg_headers.iter() {
                    // HeaderName implements AsRef<str>
                    let key: &str = name.as_ref();
                    for val in values.iter() {
                        headers.insert(key, val.as_str());
                    }
                }
            }

            if let Err(e) = self
                .client
                .publish_with_headers(dlq_subject.clone(), headers, payload)
                .await
            {
                // Log the failure but do not surface it — the message has
                // already been terminated from JetStream.
                warn!(
                    reason,
                    dlq_subject,
                    error = %e,
                    "Failed to publish dead-lettered message to DLQ (message already terminated)"
                );
            } else {
                debug!(
                    reason,
                    dlq_subject, "Message dead-lettered and published to DLQ"
                );
            }
        } else {
            debug!(reason, "Message terminated (no DLQ configured)");
        }

        Ok(())
    }

    #[instrument(skip(self), fields(queue = %queue))]
    async fn create_session_client(
        &self,
        queue: &QueueName,
        session_id: Option<SessionId>,
    ) -> Result<Box<dyn SessionProvider>, QueueError> {
        let sid = match session_id {
            Some(id) => id,
            None => {
                // NATS does not enumerate active sessions; an explicit ID is required.
                return Err(QueueError::SessionNotFound {
                    session_id: "<any>".to_string(),
                });
            }
        };

        self.ensure_stream(queue).await?;

        let subject = session_subject(&self.config, queue, &sid);
        let name = session_consumer_name(&self.config, queue, &sid);
        let consumer = self.create_consumer(queue, &name, &subject).await?;

        let now = Timestamp::now();
        let lock_expires_at =
            Timestamp::from_datetime(now.as_datetime() + self.config.session_lock_duration);

        Ok(Box::new(NatsSessionProvider {
            consumer: Arc::new(Mutex::new(consumer)),
            client: self.client.clone(),
            session_id: sid,
            queue_name: queue.clone(),
            in_flight: self.in_flight.clone(),
            lock_expires_at: Arc::new(std::sync::Mutex::new(lock_expires_at)),
            config: self.config.clone(),
        }))
    }

    fn provider_type(&self) -> ProviderType {
        ProviderType::Nats
    }

    fn supports_sessions(&self) -> SessionSupport {
        SessionSupport::Emulated
    }

    fn supports_batching(&self) -> bool {
        true
    }

    fn max_batch_size(&self) -> u32 {
        100
    }
}

// ============================================================================
// NatsSessionProvider
// ============================================================================

/// Session provider for NATS using a per-session JetStream pull consumer.
///
/// Messages for the session are filtered by a dedicated subject
/// (`{prefix}.{queue}.session.{session_id}`), ensuring ordered, exclusive delivery
/// within the session.
pub struct NatsSessionProvider {
    consumer: Arc<Mutex<async_nats::jetstream::consumer::Consumer<ConsumerConfig>>>,
    client: async_nats::Client,
    session_id: SessionId,
    queue_name: QueueName,
    in_flight: Arc<Mutex<HashMap<String, InFlightEntry>>>,
    /// Current session-lock expiry; shared so `renew_session_lock` can update it.
    lock_expires_at: Arc<std::sync::Mutex<Timestamp>>,
    config: NatsConfig,
}

#[async_trait]
impl SessionProvider for NatsSessionProvider {
    #[instrument(skip(self), fields(session_id = %self.session_id))]
    async fn receive_message(
        &self,
        timeout: Duration,
    ) -> Result<Option<ReceivedMessage>, QueueError> {
        self.check_lock()?;

        let timeout_std = timeout
            .to_std()
            .unwrap_or(std::time::Duration::from_secs(30));

        let consumer = self.consumer.lock().await;

        let mut messages = consumer
            .fetch()
            .max_messages(1)
            .expires(timeout_std)
            .messages()
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "FETCH_FAILED".to_string(),
                message: format!("session fetch failed: {}", e),
            })?;

        match tokio::time::timeout(timeout_std, messages.next()).await {
            Ok(Some(Ok(js_msg))) => {
                let msg = self.register_session_message(js_msg).await;
                Ok(Some(msg))
            }
            Ok(Some(Err(e))) => Err(QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "MESSAGE_ERROR".to_string(),
                message: format!("session message error: {}", e),
            }),
            Ok(None) | Err(_) => Ok(None),
        }
    }

    #[instrument(skip(self, receipt))]
    async fn complete_message(&self, receipt: &ReceiptHandle) -> Result<(), QueueError> {
        self.check_lock()?;
        self.ack_message(receipt, SettlementKind::Ack).await
    }

    #[instrument(skip(self, receipt))]
    async fn abandon_message(&self, receipt: &ReceiptHandle) -> Result<(), QueueError> {
        self.check_lock()?;
        self.ack_message(receipt, SettlementKind::Nak).await
    }

    #[instrument(skip(self, receipt), fields(reason = %reason))]
    async fn dead_letter_message(
        &self,
        receipt: &ReceiptHandle,
        reason: &str,
    ) -> Result<(), QueueError> {
        self.check_lock()?;

        let mut in_flight = self.in_flight.lock().await;

        // Check existence and expiry before removal.
        match in_flight.get(receipt.handle()) {
            None => {
                return Err(QueueError::MessageNotFound {
                    receipt: receipt.handle().to_string(),
                });
            }
            Some(entry) if Timestamp::now() > entry.lock_expires_at => {
                in_flight.remove(receipt.handle());
                return Err(QueueError::MessageNotFound {
                    receipt: format!("{}(expired)", receipt.handle()),
                });
            }
            Some(_) => {}
        }

        let entry = in_flight
            .remove(receipt.handle())
            .expect("entry present after pre-check");

        entry
            .js_message
            .ack_with(async_nats::jetstream::AckKind::Term)
            .await
            .map_err(|e| QueueError::ProviderError {
                provider: "nats".to_string(),
                code: "TERM_FAILED".to_string(),
                message: format!("session term ack failed: {}", e),
            })?;

        // Forward to DLQ if configured.  Best-effort: Term above is canonical;
        // if the DLQ publish fails we log and do not propagate the error.
        if let Some(ref dlq_subject) = entry.dead_letter_subject {
            let mut headers = async_nats::header::HeaderMap::new();
            headers.insert("x-dead-letter-reason", reason);
            let payload = entry.js_message.message.payload.clone();

            if let Err(e) = self
                .client
                .publish_with_headers(dlq_subject.clone(), headers, payload)
                .await
            {
                warn!(
                    reason,
                    dlq_subject,
                    error = %e,
                    "Session: failed to publish dead-lettered message to DLQ (message already terminated)"
                );
            } else {
                debug!(reason, dlq_subject, "Session message dead-lettered");
            }
        }

        Ok(())
    }

    async fn renew_session_lock(&self) -> Result<(), QueueError> {
        advance_session_lock(&self.lock_expires_at, self.config.session_lock_duration)?;
        debug!(session_id = %self.session_id, "NATS session lock renewed");
        Ok(())
    }

    async fn close_session(&self) -> Result<(), QueueError> {
        // Pull consumers are ephemeral and cleaned up by the server; nothing to do.
        Ok(())
    }

    fn session_id(&self) -> &SessionId {
        &self.session_id
    }

    fn session_expires_at(&self) -> Timestamp {
        // Recover from a poisoned lock by using the last known value.
        *self
            .lock_expires_at
            .lock()
            .unwrap_or_else(|e| e.into_inner())
    }
}

// ============================================================================
// Session lock helpers — module-level so they are testable without a live server
// ============================================================================

/// Return an error when the session lock timestamp has expired.
///
/// Extracted from [`NatsSessionProvider::check_lock`] so the expiry logic can be
/// verified in unit tests without constructing a full provider.
fn check_session_lock(
    lock_expires_at: &std::sync::Mutex<Timestamp>,
    session_id: &SessionId,
) -> Result<(), QueueError> {
    let expires = *lock_expires_at
        .lock()
        .map_err(|_| QueueError::ProviderError {
            provider: "nats".to_string(),
            code: "INTERNAL_ERROR".to_string(),
            message: "session lock mutex poisoned".to_string(),
        })?;
    if Timestamp::now() > expires {
        return Err(QueueError::SessionLocked {
            session_id: session_id.as_str().to_string(),
            locked_until: expires,
        });
    }
    Ok(())
}

/// Advance the session lock by `duration` from now and return the new expiry.
///
/// Extracted from [`NatsSessionProvider::renew_session_lock`] for the same reason.
fn advance_session_lock(
    lock_expires_at: &std::sync::Mutex<Timestamp>,
    duration: Duration,
) -> Result<Timestamp, QueueError> {
    let new_expiry = Timestamp::from_datetime(Timestamp::now().as_datetime() + duration);
    *lock_expires_at
        .lock()
        .map_err(|_| QueueError::ProviderError {
            provider: "nats".to_string(),
            code: "INTERNAL_ERROR".to_string(),
            message: "session lock mutex poisoned".to_string(),
        })? = new_expiry;
    Ok(new_expiry)
}

/// Internal settlement kind for session operations.
enum SettlementKind {
    Ack,
    Nak,
}

impl NatsSessionProvider {
    /// Return an error if the session lock has expired.
    fn check_lock(&self) -> Result<(), QueueError> {
        check_session_lock(&self.lock_expires_at, &self.session_id)
    }

    /// Ack or nak a message identified by its receipt handle.
    async fn ack_message(
        &self,
        receipt: &ReceiptHandle,
        kind: SettlementKind,
    ) -> Result<(), QueueError> {
        let mut in_flight = self.in_flight.lock().await;

        // Check existence and expiry before removal (same pattern as NatsProvider).
        match in_flight.get(receipt.handle()) {
            None => {
                return Err(QueueError::MessageNotFound {
                    receipt: receipt.handle().to_string(),
                });
            }
            Some(entry) if Timestamp::now() > entry.lock_expires_at => {
                in_flight.remove(receipt.handle());
                return Err(QueueError::MessageNotFound {
                    receipt: format!("{}(expired)", receipt.handle()),
                });
            }
            Some(_) => {}
        }

        let entry = in_flight
            .remove(receipt.handle())
            .expect("entry present after pre-check");

        match kind {
            SettlementKind::Ack => {
                entry
                    .js_message
                    .ack()
                    .await
                    .map_err(|e| QueueError::ProviderError {
                        provider: "nats".to_string(),
                        code: "ACK_FAILED".to_string(),
                        message: format!("session ack failed: {}", e),
                    })
            }
            SettlementKind::Nak => {
                entry
                    .js_message
                    .ack_with(AckKind::Nak(None))
                    .await
                    .map_err(|e| QueueError::ProviderError {
                        provider: "nats".to_string(),
                        code: "NAK_FAILED".to_string(),
                        message: format!("session nak failed: {}", e),
                    })
            }
        }
    }

    /// Register a JetStream message in the in-flight map and build a [`ReceivedMessage`].
    async fn register_session_message(
        &self,
        js_message: async_nats::jetstream::Message,
    ) -> ReceivedMessage {
        let headers = js_message.message.headers.clone();
        let attributes = NatsProvider::extract_attributes(&headers);
        let correlation_id = NatsProvider::extract_correlation_id(&headers);
        let delivery_count = js_message.info().map(|i| i.delivered as u32).unwrap_or(1);
        let body = Bytes::copy_from_slice(&js_message.message.payload);

        let now = Timestamp::now();
        let lock_expires_at =
            Timestamp::from_datetime(now.as_datetime() + self.config.session_lock_duration);

        let receipt_id = uuid::Uuid::new_v4().to_string();
        let message_id = MessageId::new();

        let dlq_subject = dead_letter_subject(&self.config, &self.queue_name);

        self.in_flight.lock().await.insert(
            receipt_id.clone(),
            InFlightEntry {
                js_message,
                lock_expires_at,
                dead_letter_subject: dlq_subject,
            },
        );

        ReceivedMessage {
            message_id,
            body,
            attributes,
            session_id: Some(self.session_id.clone()),
            correlation_id,
            receipt_handle: ReceiptHandle::new(receipt_id, lock_expires_at, ProviderType::Nats),
            delivery_count,
            first_delivered_at: now,
            delivered_at: now,
        }
    }
}