queue-runtime 0.2.0

Multi-provider queue runtime for Queue-Keeper
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
//! Tests for the NATS queue provider.
//!
//! These tests verify configuration, naming logic, header encoding/decoding,
//! and error-handling paths that do not require a live NATS server.
//! Integration tests that need a server should live in a separate suite.

use super::*;
use chrono::Duration;

// ============================================================================
// Configuration tests
// ============================================================================

mod config_tests {
    use super::*;

    /// Verify that the default configuration has sensible values.
    #[test]
    fn test_default_config_values() {
        let config = NatsConfig::default();
        assert_eq!(config.url, "nats://localhost:4222");
        assert_eq!(config.stream_prefix, "queue-runtime");
        assert_eq!(config.max_deliver, Some(3));
        assert_eq!(config.ack_wait, Duration::seconds(30));
        assert!(config.enable_dead_letter);
        assert_eq!(config.dead_letter_subject_prefix, Some("dlq".to_string()));
        assert!(config.credentials_path.is_none());
    }

    /// Verify that the default session lock duration is sensible.
    #[test]
    fn test_default_session_lock_duration() {
        let config = NatsConfig::default();
        assert_eq!(config.session_lock_duration, Duration::minutes(5));
    }

    /// Verify custom configuration can be constructed.
    #[test]
    fn test_custom_config() {
        let config = NatsConfig {
            url: "nats://user:pass@nats.example.com:4222".to_string(),
            stream_prefix: "myapp".to_string(),
            max_deliver: Some(5),
            ack_wait: Duration::seconds(60),
            session_lock_duration: Duration::minutes(10),
            enable_dead_letter: false,
            dead_letter_subject_prefix: None,
            credentials_path: Some("/etc/nats/app.creds".to_string()),
        };

        assert_eq!(config.stream_prefix, "myapp");
        assert_eq!(config.max_deliver, Some(5));
        assert!(!config.enable_dead_letter);
    }

    /// Verify that the provider type is correct.
    #[test]
    fn test_provider_type() {
        assert_eq!(ProviderType::Nats.max_message_size(), 1024 * 1024);
        assert!(ProviderType::Nats.supports_batching());
        assert_eq!(
            ProviderType::Nats.supports_sessions(),
            crate::provider::SessionSupport::Emulated
        );
    }
}

// ============================================================================
// Naming helper tests
// ============================================================================

mod naming_tests {
    use super::*;

    fn default_config() -> NatsConfig {
        NatsConfig::default()
    }

    /// Verify that queue subjects use the expected format.
    #[test]
    fn test_queue_subject_format() {
        let config = default_config();
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let subject = queue_subject(&config, &queue);
        assert_eq!(subject, "queue_runtime.my_queue");
    }

    /// Verify that session subjects use the expected format.
    #[test]
    fn test_session_subject_format() {
        let config = default_config();
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let session = SessionId::new("session-123".to_string()).unwrap();
        let subject = session_subject(&config, &queue, &session);
        assert_eq!(subject, "queue_runtime.my_queue.session.session_123");
    }

    /// Verify that session subjects with slashes are sanitised.
    #[test]
    fn test_session_subject_sanitises_slashes() {
        let config = default_config();
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let session = SessionId::new("owner/repo/pr/42".to_string()).unwrap();
        let subject = session_subject(&config, &queue, &session);
        assert!(!subject.contains('/'));
        assert!(subject.contains("session."));
    }

    /// Verify that stream names use the expected format.
    #[test]
    fn test_stream_name_format() {
        let config = default_config();
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let name = stream_name(&config, &queue);
        assert_eq!(name, "queue_runtime-my_queue");
        // Stream names must not contain dots
        assert!(!name.contains('.'));
    }

    /// Verify that dead letter subject uses the expected format.
    #[test]
    fn test_dead_letter_subject_format() {
        let config = default_config();
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let subject = dead_letter_subject(&config, &queue);
        assert_eq!(subject, Some("dlq.my_queue".to_string()));
    }

    /// Verify that dead letter subject is None when DLQ is disabled.
    #[test]
    fn test_dead_letter_subject_disabled() {
        let config = NatsConfig {
            enable_dead_letter: false,
            ..NatsConfig::default()
        };
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let subject = dead_letter_subject(&config, &queue);
        assert!(subject.is_none());
    }

    /// Verify that dead letter subject is None when prefix is not set.
    #[test]
    fn test_dead_letter_subject_no_prefix() {
        let config = NatsConfig {
            enable_dead_letter: true,
            dead_letter_subject_prefix: None,
            ..NatsConfig::default()
        };
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let subject = dead_letter_subject(&config, &queue);
        assert!(subject.is_none());
    }

    /// Verify that NATS-safe name transformation works correctly.
    #[test]
    fn test_nats_safe_transformation() {
        assert_eq!(nats_safe("my-name"), "my_name");
        assert_eq!(nats_safe("my name"), "my_name");
        assert_eq!(nats_safe("already_safe"), "already_safe");
        assert_eq!(nats_safe("multi-word-name"), "multi_word_name");
    }

    /// Verify that different queues produce different stream names.
    #[test]
    fn test_different_queues_different_streams() {
        let config = default_config();
        let q1 = QueueName::new("queue-one".to_string()).unwrap();
        let q2 = QueueName::new("queue-two".to_string()).unwrap();
        assert_ne!(stream_name(&config, &q1), stream_name(&config, &q2));
    }

    /// Verify that different sessions produce different subjects.
    #[test]
    fn test_different_sessions_different_subjects() {
        let config = default_config();
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let s1 = SessionId::new("session-1".to_string()).unwrap();
        let s2 = SessionId::new("session-2".to_string()).unwrap();
        assert_ne!(
            session_subject(&config, &queue, &s1),
            session_subject(&config, &queue, &s2)
        );
    }

    /// Verify that session consumer names use the expected format.
    #[test]
    fn test_session_consumer_name_format() {
        let config = default_config();
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let session = SessionId::new("session-123".to_string()).unwrap();
        let name = session_consumer_name(&config, &queue, &session);
        assert_eq!(name, "queue_runtime-my_queue-session-session_123-consumer");
        // Consumer names must not contain dots.
        assert!(!name.contains('.'));
    }

    /// Verify that session consumer names are distinct from queue consumer names.
    #[test]
    fn test_session_consumer_name_distinct_from_queue_consumer() {
        let config = default_config();
        let queue = QueueName::new("q".to_string()).unwrap();
        let session = SessionId::new("s".to_string()).unwrap();
        assert_ne!(
            consumer_name(&config, &queue),
            session_consumer_name(&config, &queue, &session),
            "session and queue consumer names must be distinct on the same queue"
        );
    }

    /// Verify that different sessions produce different consumer names.
    #[test]
    fn test_different_sessions_different_consumer_names() {
        let config = default_config();
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let s1 = SessionId::new("session-1".to_string()).unwrap();
        let s2 = SessionId::new("session-2".to_string()).unwrap();
        assert_ne!(
            session_consumer_name(&config, &queue, &s1),
            session_consumer_name(&config, &queue, &s2),
            "different sessions must produce distinct consumer names"
        );
    }

    /// Verify that dots and other NATS-invalid chars in session IDs are sanitised.
    #[test]
    fn test_session_consumer_name_sanitises_dots_and_special_chars() {
        let config = default_config();
        let queue = QueueName::new("q".to_string()).unwrap();
        // Dots appear in GitHub repo names (e.g. "org.name/repo.name")
        let session = SessionId::new("org.name/repo.name".to_string()).unwrap();
        let name = session_consumer_name(&config, &queue, &session);
        assert!(
            !name.contains('.'),
            "dots must be replaced in consumer name"
        );
        assert!(
            !name.contains('/'),
            "slashes must be replaced in consumer name"
        );
    }
}

// ============================================================================
// Header encode/decode tests
// ============================================================================

mod header_tests {
    use super::*;

    /// Verify that attributes are encoded into NATS headers and decoded back.
    #[test]
    fn test_attribute_roundtrip() {
        let mut message = Message::new(bytes::Bytes::from("test body"));
        message = message.with_attribute("color".to_string(), "blue".to_string());
        message = message.with_attribute("size".to_string(), "large".to_string());

        let headers = NatsProvider::build_headers(&message);

        // Re-wrap in Option as the extract functions expect
        let opt_headers = Some(headers);
        let attrs = NatsProvider::extract_attributes(&opt_headers);

        assert_eq!(attrs.get("color").map(String::as_str), Some("blue"));
        assert_eq!(attrs.get("size").map(String::as_str), Some("large"));
    }

    /// Verify that session ID is encoded and decoded correctly.
    #[test]
    fn test_session_id_header_roundtrip() {
        let session = SessionId::new("test-session".to_string()).unwrap();
        let message = Message::new(bytes::Bytes::from("body")).with_session_id(session.clone());

        let headers = NatsProvider::build_headers(&message);
        let opt_headers = Some(headers);
        let extracted = NatsProvider::extract_session_id(&opt_headers);

        assert_eq!(extracted, Some(session));
    }

    /// Verify that session ID is absent when not set.
    #[test]
    fn test_no_session_id_when_none() {
        let message = Message::new(bytes::Bytes::from("body"));
        let headers = NatsProvider::build_headers(&message);
        let opt_headers = Some(headers);
        let extracted = NatsProvider::extract_session_id(&opt_headers);
        assert!(extracted.is_none());
    }

    /// Verify that correlation ID is encoded and decoded correctly.
    #[test]
    fn test_correlation_id_header_roundtrip() {
        let message =
            Message::new(bytes::Bytes::from("body")).with_correlation_id("corr-xyz".to_string());

        let headers = NatsProvider::build_headers(&message);
        let opt_headers = Some(headers);
        let extracted = NatsProvider::extract_correlation_id(&opt_headers);

        assert_eq!(extracted, Some("corr-xyz".to_string()));
    }

    /// Verify that correlation ID is None when not set.
    #[test]
    fn test_no_correlation_id_when_none() {
        let message = Message::new(bytes::Bytes::from("body"));
        let headers = NatsProvider::build_headers(&message);
        let opt_headers = Some(headers);
        let extracted = NatsProvider::extract_correlation_id(&opt_headers);
        assert!(extracted.is_none());
    }

    /// Verify that provider headers are not returned as user attributes.
    #[test]
    fn test_provider_headers_not_in_attributes() {
        let session = SessionId::new("s1".to_string()).unwrap();
        let message = Message::new(bytes::Bytes::from("body"))
            .with_session_id(session)
            .with_correlation_id("corr-1".to_string())
            .with_attribute("my-key".to_string(), "my-value".to_string());

        let headers = NatsProvider::build_headers(&message);
        let opt_headers = Some(headers);
        let attrs = NatsProvider::extract_attributes(&opt_headers);

        // Provider headers must not appear as user attributes
        assert!(!attrs.contains_key("x-session-id"));
        assert!(!attrs.contains_key("x-correlation-id"));
        // User attribute prefixed with x-attr- must be accessible without prefix
        assert_eq!(attrs.get("my-key").map(String::as_str), Some("my-value"));
    }

    /// Verify extraction from None headers returns empty map / None.
    #[test]
    fn test_extract_from_none_headers() {
        let attrs = NatsProvider::extract_attributes(&None);
        assert!(attrs.is_empty());

        let session = NatsProvider::extract_session_id(&None);
        assert!(session.is_none());

        let corr = NatsProvider::extract_correlation_id(&None);
        assert!(corr.is_none());
    }
}

// ============================================================================
// Error conversion tests
// ============================================================================

mod error_tests {
    use super::*;

    /// Verify that NatsError converts to a provider QueueError.
    #[test]
    fn test_error_conversion() {
        let err = NatsError::new("connection refused");
        let queue_err = err.to_queue_error();

        match queue_err {
            QueueError::ProviderError {
                provider,
                code,
                message,
            } => {
                assert_eq!(provider, "nats");
                assert_eq!(code, "NATS_ERROR");
                assert!(message.contains("connection refused"));
            }
            other => panic!("unexpected error variant: {:?}", other),
        }
    }

    /// Verify that NatsError implements Display.
    #[test]
    fn test_error_display() {
        let err = NatsError::new("test error");
        let display = format!("{}", err);
        assert!(display.contains("test error"));
    }
}

// ============================================================================
// Additional coverage tests
// ============================================================================

mod additional_tests {
    use super::*;

    /// Verify that nats_safe handles a string that is already safe.
    #[test]
    fn test_nats_safe_no_change() {
        assert_eq!(nats_safe("already_safe_123"), "already_safe_123");
    }

    /// Verify that nats_safe replaces hyphens and spaces.
    #[test]
    fn test_nats_safe_replaces_hyphens_and_spaces() {
        assert_eq!(nats_safe("my-queue name"), "my_queue_name");
    }

    /// Verify that queue_subject uses nats_safe on both parts.
    #[test]
    fn test_queue_subject_normalises_special_chars() {
        let config = NatsConfig {
            stream_prefix: "my-app".to_string(),
            ..NatsConfig::default()
        };
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let subject = queue_subject(&config, &queue);
        assert_eq!(subject, "my_app.my_queue");
    }

    /// Verify that stream_name uses hyphens as separator (no dots).
    #[test]
    fn test_stream_name_has_no_dots() {
        let config = NatsConfig::default();
        let queue = QueueName::new("test-queue".to_string()).unwrap();
        let name = stream_name(&config, &queue);
        assert!(!name.contains('.'), "Stream names must not contain dots");
    }

    /// Verify that dead_letter_subject uses nats_safe on both prefix and queue.
    #[test]
    fn test_dead_letter_subject_custom_prefix() {
        let config = NatsConfig {
            dead_letter_subject_prefix: Some("my-dlq".to_string()),
            ..NatsConfig::default()
        };
        let queue = QueueName::new("my-queue".to_string()).unwrap();
        let subject = dead_letter_subject(&config, &queue);
        assert_eq!(subject, Some("my_dlq.my_queue".to_string()));
    }

    /// Verify that build_headers produces no headers for a minimal message.
    #[test]
    fn test_build_headers_empty_message() {
        let message = Message::new(bytes::Bytes::from("body"));
        let headers = NatsProvider::build_headers(&message);
        // No session_id, correlation_id, or attributes → no headers set
        assert!(headers.get("x-session-id").is_none());
        assert!(headers.get("x-correlation-id").is_none());
    }

    /// Verify that multiple attributes all survive a header roundtrip.
    #[test]
    fn test_multiple_attributes_roundtrip() {
        let mut message = Message::new(bytes::Bytes::from("body"));
        for i in 0..5 {
            message = message.with_attribute(format!("key-{}", i), format!("val-{}", i));
        }

        let headers = NatsProvider::build_headers(&message);
        let opt_headers = Some(headers);
        let attrs = NatsProvider::extract_attributes(&opt_headers);

        for i in 0..5 {
            assert_eq!(
                attrs.get(&format!("key-{}", i)).map(String::as_str),
                Some(format!("val-{}", i).as_str())
            );
        }
    }

    /// Verify that NatsConfig with no credentials path has None.
    #[test]
    fn test_config_no_credentials() {
        let config = NatsConfig::default();
        assert!(config.credentials_path.is_none());
    }

    /// Verify that NatsConfig with max_deliver None works.
    #[test]
    fn test_config_unlimited_deliver() {
        let config = NatsConfig {
            max_deliver: None,
            ..NatsConfig::default()
        };
        assert!(config.max_deliver.is_none());
    }

    /// Verify that the session lock duration is used correctly.
    #[test]
    fn test_session_lock_duration_default() {
        let config = NatsConfig::default();
        assert_eq!(config.session_lock_duration, Duration::minutes(5));
    }

    /// Verify that a custom session lock duration is respected.
    #[test]
    fn test_session_lock_duration_custom() {
        let config = NatsConfig {
            session_lock_duration: Duration::minutes(20),
            ..NatsConfig::default()
        };
        assert_eq!(config.session_lock_duration, Duration::minutes(20));
    }
}

// ============================================================================
// URL redaction tests
// ============================================================================

mod url_redaction_tests {
    use super::*;

    /// Verify that credentials embedded in a NATS URL are replaced with `***`.
    #[test]
    fn test_redact_url_with_credentials() {
        let redacted = redact_url("nats://user:pass@localhost:4222");
        assert!(
            !redacted.contains("user"),
            "Username must be redacted: {redacted}"
        );
        assert!(
            !redacted.contains("pass"),
            "Password must be redacted: {redacted}"
        );
        assert!(
            redacted.contains("localhost"),
            "Host must be preserved: {redacted}"
        );
        assert!(
            redacted.contains("4222"),
            "Port must be preserved: {redacted}"
        );
        assert!(
            redacted.contains("***"),
            "Redaction marker must appear: {redacted}"
        );
    }

    /// Verify that a URL without credentials is returned unchanged.
    #[test]
    fn test_redact_url_without_credentials() {
        let url = "nats://localhost:4222";
        let redacted = redact_url(url);
        assert_eq!(redacted.trim_end_matches('/'), url.trim_end_matches('/'));
    }

    /// Verify that an invalid URL returns the sentinel string.
    #[test]
    fn test_redact_url_invalid_url() {
        let redacted = redact_url("not a url !!!");
        assert_eq!(redacted, "<invalid-url>");
    }

    /// Verify that only the username is present in the URL (no password).
    #[test]
    fn test_redact_url_username_only() {
        let redacted = redact_url("nats://mytoken@nats.example.com:4222");
        assert!(
            !redacted.contains("mytoken"),
            "Token must be redacted: {redacted}"
        );
        assert!(
            redacted.contains("nats.example.com"),
            "Host must be preserved: {redacted}"
        );
    }
}

// ============================================================================
// Session lock helper tests (require no live NATS server)
// ============================================================================

mod session_lock_tests {
    use super::*;
    use std::sync::Mutex;

    fn lock_expiring_in(minutes: i64) -> Mutex<Timestamp> {
        let ts =
            Timestamp::from_datetime(Timestamp::now().as_datetime() + Duration::minutes(minutes));
        Mutex::new(ts)
    }

    fn lock_expired_since(minutes: i64) -> Mutex<Timestamp> {
        let ts =
            Timestamp::from_datetime(Timestamp::now().as_datetime() - Duration::minutes(minutes));
        Mutex::new(ts)
    }

    /// A valid (non-expired) lock returns Ok.
    #[test]
    fn test_check_session_lock_valid() {
        let lock = lock_expiring_in(5);
        let session = SessionId::new("test-session".to_string()).unwrap();
        assert!(check_session_lock(&lock, &session).is_ok());
    }

    /// An expired lock returns SessionLocked with the correct session ID.
    #[test]
    fn test_check_session_lock_expired() {
        let lock = lock_expired_since(1);
        let session = SessionId::new("expired-session".to_string()).unwrap();

        let result = check_session_lock(&lock, &session);

        assert!(result.is_err());
        match result.unwrap_err() {
            QueueError::SessionLocked { session_id, .. } => {
                assert_eq!(session_id, "expired-session");
            }
            other => panic!("expected SessionLocked, got: {:?}", other),
        }
    }

    /// Renewing an expired lock makes it valid again.
    #[test]
    fn test_advance_session_lock_from_expired() {
        let lock = lock_expired_since(1); // already expired
        let session = SessionId::new("test-session".to_string()).unwrap();

        // Confirm it's expired before renewal.
        assert!(check_session_lock(&lock, &session).is_err());

        // Renew for 5 minutes.
        let new_expiry = advance_session_lock(&lock, Duration::minutes(5))
            .expect("advance_session_lock should succeed");

        // New expiry is in the future.
        assert!(
            new_expiry.as_datetime() > Timestamp::now().as_datetime(),
            "new expiry must be in the future"
        );

        // Lock is now valid.
        assert!(check_session_lock(&lock, &session).is_ok());
    }

    /// Renewing an already-valid lock extends it further into the future.
    #[test]
    fn test_advance_session_lock_extends_valid_lock() {
        let lock = lock_expiring_in(1); // valid but close to expiry

        let before = { *lock.lock().unwrap() };

        advance_session_lock(&lock, Duration::minutes(5))
            .expect("advance_session_lock should succeed");

        let after = { *lock.lock().unwrap() };

        assert!(
            after.as_datetime() > before.as_datetime(),
            "renewal must extend the expiry"
        );
    }
}