qubit-http 0.5.2

General-purpose HTTP infrastructure for Rust with unified client semantics, secure logging, and built-in SSE decoding
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
/*******************************************************************************
 *
 *    Copyright (c) 2025 - 2026 Haixing Hu.
 *
 *    SPDX-License-Identifier: Apache-2.0
 *
 *    Licensed under the Apache License, Version 2.0.
 *
 ******************************************************************************/

use std::error::Error as StdError;
use std::sync::{
    atomic::{
        AtomicUsize,
        Ordering,
    },
    Arc,
    Mutex,
};
use std::time::Duration;

use http::{
    HeaderMap,
    HeaderName,
    HeaderValue,
    Method,
    StatusCode,
};
use qubit_http::{
    HttpClientFactory,
    HttpClientOptions,
    HttpError,
    HttpErrorKind,
    HttpHeaderInjector,
    HttpRequestInterceptor,
    HttpResponseInterceptor,
};
use tokio::time::timeout;

use crate::common::{
    spawn_one_shot_server,
    ResponsePlan,
};

fn retry_abort_inner_http(error: &HttpError) -> &HttpError {
    let boxed = error
        .source
        .as_ref()
        .expect("retry abort should chain inner error");
    (boxed.as_ref() as &(dyn StdError + 'static))
        .downcast_ref::<HttpError>()
        .expect("inner should be HttpError")
}

#[test]
fn test_http_client_debug_includes_options_and_injectors() {
    let mut client = HttpClientFactory::new()
        .create_default()
        .expect("default options should create client");
    client.add_header_injector(HttpHeaderInjector::new(|_headers: &mut HeaderMap| Ok(())));

    let output = format!("{:?}", client);

    assert!(output.contains("HttpClient"));
    assert!(output.contains("options"));
    assert!(output.contains("injectors"));
}

#[tokio::test]
async fn test_absolute_url_request_bypasses_base_url_join() {
    let target_server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;

    let mut options = HttpClientOptions::default();
    // Deliberately points to a non-existing host; absolute URL should bypass this.
    options.base_url = Some(url::Url::parse("http://127.0.0.1:1/").unwrap());
    let client = HttpClientFactory::new().create(options).unwrap();

    let path = format!("{}absolute", target_server.base_url());
    let request = client.request(Method::GET, path.as_str()).build();
    let response = timeout(Duration::from_secs(3), client.execute(request))
        .await
        .expect("execute timed out")
        .unwrap();
    assert_eq!(response.meta.status.as_u16(), 200);

    let captured = timeout(Duration::from_secs(3), target_server.finish())
        .await
        .expect("server finish timed out");
    assert_eq!(captured.target, "/absolute");
}

#[tokio::test]
async fn test_execute_returns_invalid_url_for_bad_relative_path() {
    let mut options = HttpClientOptions::default();
    options.base_url = Some(
        url::Url::parse("https://example.com/api/").expect("static base_url in test should parse"),
    );
    let client = HttpClientFactory::new()
        .create(options)
        .expect("valid options should create client");
    let request = client.request(Method::GET, "http://[::1").build();

    let error = timeout(Duration::from_secs(3), client.execute(request))
        .await
        .expect("execute timed out")
        .expect_err("invalid relative path should fail before request is sent");

    assert_eq!(error.kind, HttpErrorKind::InvalidUrl);
    assert!(error
        .message
        .contains("Failed to resolve path 'http://[::1'"));
}

#[tokio::test]
async fn test_header_injector_order_is_stable_and_clear_works() {
    let server1 = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server1.base_url());
    let mut client = HttpClientFactory::new().create(options).unwrap();
    client.add_header_injector(HttpHeaderInjector::new(|headers: &mut HeaderMap| {
        headers.insert(
            HeaderName::from_static("x-seq"),
            HeaderValue::from_static("A"),
        );
        Ok(())
    }));
    client.add_header_injector(HttpHeaderInjector::new(|headers: &mut HeaderMap| {
        headers.insert(
            HeaderName::from_static("x-seq"),
            HeaderValue::from_static("B"),
        );
        Ok(())
    }));

    let request = client.request(Method::GET, "/ordered").build();
    let _ = client.execute(request).await.unwrap();
    let captured = server1.finish().await;
    assert_eq!(captured.headers.get("x-seq"), Some(&"B".to_string()));

    let server2 = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options2 = HttpClientOptions::default();
    options2.base_url = Some(server2.base_url());
    let mut client2 = HttpClientFactory::new().create(options2).unwrap();
    client2.add_header_injector(HttpHeaderInjector::new(|headers: &mut HeaderMap| {
        headers.insert(
            HeaderName::from_static("x-seq"),
            HeaderValue::from_static("A"),
        );
        Ok(())
    }));
    client2.clear_header_injectors();
    let request2 = client2.request(Method::GET, "/cleared").build();
    let _ = client2.execute(request2).await.unwrap();
    let captured2 = server2.finish().await;
    assert!(!captured2.headers.contains_key("x-seq"));
}

#[tokio::test]
async fn test_failing_header_injector_short_circuits_request() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let mut client = HttpClientFactory::new().create(options).unwrap();
    client.add_header_injector(HttpHeaderInjector::new(|_headers: &mut HeaderMap| {
        Err(HttpError::other("inject failed"))
    }));

    let request = client.request(Method::GET, "/will-not-send").build();
    let error = client.execute(request).await.unwrap_err();
    assert_eq!(error.kind, HttpErrorKind::Other);
    assert!(error.message.contains("inject failed"));
}

#[tokio::test]
async fn test_request_interceptor_order_is_stable_and_clear_works() {
    let server1 = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server1.base_url());
    let mut client = HttpClientFactory::new().create(options).unwrap();
    client.add_request_interceptor(HttpRequestInterceptor::new(|request| {
        request.set_typed_header(
            HeaderName::from_static("x-request-seq"),
            HeaderValue::from_static("A"),
        );
        request.add_query_param("request_interceptor", "first");
        Ok(())
    }));
    client.add_request_interceptor(HttpRequestInterceptor::new(|request| {
        request.set_typed_header(
            HeaderName::from_static("x-request-seq"),
            HeaderValue::from_static("B"),
        );
        request.add_query_param("request_interceptor", "second");
        Ok(())
    }));

    let request = client
        .request(Method::GET, "/request-order")
        .query_param("initial", "1")
        .build();
    let _ = client.execute(request).await.unwrap();
    let captured = server1.finish().await;
    assert_eq!(
        captured.headers.get("x-request-seq"),
        Some(&"B".to_string())
    );
    assert!(captured.target.contains("initial=1"));
    assert!(captured.target.contains("request_interceptor=first"));
    assert!(captured.target.contains("request_interceptor=second"));

    let server2 = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options2 = HttpClientOptions::default();
    options2.base_url = Some(server2.base_url());
    let mut client2 = HttpClientFactory::new().create(options2).unwrap();
    client2.add_request_interceptor(HttpRequestInterceptor::new(|request| {
        request.set_typed_header(
            HeaderName::from_static("x-request-cleared"),
            HeaderValue::from_static("yes"),
        );
        Ok(())
    }));
    client2.clear_request_interceptors();

    let request2 = client2.request(Method::GET, "/request-clear").build();
    let _ = client2.execute(request2).await.unwrap();
    let captured2 = server2.finish().await;
    assert!(!captured2.headers.contains_key("x-request-cleared"));
}

#[tokio::test]
async fn test_failing_request_interceptor_short_circuits_before_url_resolution() {
    let mut client = HttpClientFactory::new()
        .create_default()
        .expect("default options should create client");
    client.add_request_interceptor(HttpRequestInterceptor::new(|_request| {
        Err(HttpError::other("request blocked by interceptor"))
    }));

    let request = client
        .request(
            Method::GET,
            "http://127.0.0.1:1/request-interceptor-blocked",
        )
        .build();
    let error = client.execute(request).await.unwrap_err();
    assert_eq!(error.kind, HttpErrorKind::Other);
    assert!(error.message.contains("request blocked by interceptor"));
    assert_eq!(error.method, Some(Method::GET));
    let error_url = error
        .url
        .expect("request interceptor error should include URL");
    assert_eq!(
        error_url.as_str(),
        "http://127.0.0.1:1/request-interceptor-blocked"
    );
}

#[tokio::test]
async fn test_response_interceptor_order_is_stable_and_short_circuits() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let mut client = HttpClientFactory::new().create(options).unwrap();

    let events = Arc::new(Mutex::new(Vec::new()));
    let first_events = Arc::clone(&events);
    client.add_response_interceptor(HttpResponseInterceptor::new(move |_meta| {
        first_events
            .lock()
            .expect("lock response interceptor events for first")
            .push("first".to_string());
        Ok(())
    }));
    let second_events = Arc::clone(&events);
    client.add_response_interceptor(HttpResponseInterceptor::new(move |_meta| {
        second_events
            .lock()
            .expect("lock response interceptor events for second")
            .push("second".to_string());
        Err(HttpError::other("response blocked by interceptor"))
    }));

    let request = client.request(Method::GET, "/response-order").build();
    let error = client.execute(request).await.unwrap_err();
    assert_eq!(error.kind, HttpErrorKind::Other);
    assert_eq!(error.status.map(|status| status.as_u16()), Some(200));
    assert_eq!(error.method, Some(Method::GET));
    assert!(error.url.is_some());
    assert!(error.message.contains("response blocked by interceptor"));
    assert_eq!(
        *events
            .lock()
            .expect("lock response interceptor events for assertion"),
        vec!["first".to_string(), "second".to_string()]
    );
}

#[tokio::test]
async fn test_clear_response_interceptors_restores_success_path() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let mut client = HttpClientFactory::new().create(options).unwrap();
    client.add_response_interceptor(HttpResponseInterceptor::new(|_meta| {
        Err(HttpError::other("should be cleared"))
    }));
    client.clear_response_interceptors();

    let request = client.request(Method::GET, "/response-clear").build();
    let response = client.execute(request).await.unwrap();
    assert_eq!(response.meta.status.as_u16(), 200);
}

#[tokio::test]
async fn test_execute_applies_response_interceptor_for_unconsumed_body() {
    let server = spawn_one_shot_server(ResponsePlan::Chunked {
        status: 200,
        headers: vec![],
        chunks: vec![],
        finish: true,
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let mut client = HttpClientFactory::new().create(options).unwrap();
    let called = Arc::new(AtomicUsize::new(0));
    let called_for_interceptor = Arc::clone(&called);
    client.add_response_interceptor(HttpResponseInterceptor::new(move |_meta| {
        called_for_interceptor.fetch_add(1, Ordering::Relaxed);
        Ok(())
    }));

    let request = client
        .request(Method::GET, "/stream-response-interceptor")
        .build();
    let response = client.execute(request).await.unwrap();
    assert_eq!(response.status().as_u16(), 200);
    assert_eq!(called.load(Ordering::Relaxed), 1);
}

#[tokio::test]
async fn test_request_url_can_differ_from_response_meta_url() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let mut client = HttpClientFactory::new()
        .create(options)
        .expect("valid options should create client");
    let rewritten_url = url::Url::parse("https://interceptor.example/rewritten")
        .expect("static interceptor URL should parse");
    let rewritten_url_for_interceptor = rewritten_url.clone();
    client.add_response_interceptor(HttpResponseInterceptor::new(move |meta| {
        meta.url = rewritten_url_for_interceptor.clone();
        Ok(())
    }));

    let request = client.request(Method::GET, "/request-url-diff").build();
    let response = client
        .execute(request)
        .await
        .expect("request should succeed");
    let expected_request_url = server
        .base_url()
        .join("request-url-diff")
        .expect("request URL should join");

    assert_eq!(response.request_url(), &expected_request_url);
    assert_eq!(response.url(), &rewritten_url);
    assert_ne!(response.request_url(), response.url());

    let captured = server.finish().await;
    assert_eq!(captured.target, "/request-url-diff");
}

#[tokio::test]
async fn test_request_url_includes_builder_query_params() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let client = HttpClientFactory::new()
        .create(options)
        .expect("valid options should create client");

    let request = client
        .request(Method::GET, "/request-url-query?existing=1")
        .query_param("added", "two words")
        .build();
    let response = client
        .execute(request)
        .await
        .expect("request should succeed");
    let mut expected_request_url = server
        .base_url()
        .join("request-url-query?existing=1")
        .expect("request URL should join");
    expected_request_url
        .query_pairs_mut()
        .append_pair("added", "two words");

    assert_eq!(response.request_url(), &expected_request_url);

    let captured = server.finish().await;
    assert_eq!(
        captured.target,
        "/request-url-query?existing=1&added=two+words"
    );
}

#[tokio::test]
async fn test_status_error_url_includes_builder_query_params() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: StatusCode::SERVICE_UNAVAILABLE.as_u16(),
        headers: vec![],
        body: b"retry later".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let client = HttpClientFactory::new()
        .create(options)
        .expect("valid options should create client");

    let request = client
        .request(Method::GET, "/status-query")
        .query_param("attempt", "1")
        .build();
    let error = client
        .execute(request)
        .await
        .expect_err("status should be returned as error");
    let expected_url = server
        .base_url()
        .join("status-query?attempt=1")
        .expect("request URL should join");

    assert_eq!(error.kind, HttpErrorKind::Status);
    assert_eq!(error.url, Some(expected_url));

    let captured = server.finish().await;
    assert_eq!(captured.target, "/status-query?attempt=1");
}

#[tokio::test]
async fn test_request_url_is_used_in_buffered_read_error() {
    let server = spawn_one_shot_server(ResponsePlan::Chunked {
        status: 200,
        headers: vec![],
        chunks: vec![
            crate::common::ResponseChunk {
                delay: Duration::from_millis(0),
                bytes: b"partial".to_vec(),
            },
            crate::common::ResponseChunk {
                delay: Duration::from_millis(200),
                bytes: b"later".to_vec(),
            },
        ],
        finish: true,
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    options.timeouts.read_timeout = Duration::from_millis(50);
    let mut client = HttpClientFactory::new()
        .create(options)
        .expect("valid options should create client");
    let interceptor_url = url::Url::parse("https://interceptor.example/context-url-rewritten")
        .expect("static interceptor URL should parse");
    let expected_request_url = server
        .base_url()
        .join("context-url-timeout")
        .expect("request URL should join");
    let expected_url_for_interceptor = interceptor_url.clone();
    client.add_response_interceptor(HttpResponseInterceptor::new(move |meta| {
        meta.url = expected_url_for_interceptor.clone();
        Ok(())
    }));

    let request = client.request(Method::GET, "/context-url-timeout").build();
    let mut response = client.execute(request).await.expect("request should start");
    let error = response
        .bytes()
        .await
        .expect_err("buffered read should timeout");

    assert_eq!(error.kind, HttpErrorKind::ReadTimeout);
    assert_eq!(error.url, Some(expected_request_url));
    let captured = server.finish().await;
    assert_eq!(captured.target, "/context-url-timeout");
}

#[tokio::test]
async fn test_retry_status_code_allowlist_can_disable_retry_for_503() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: StatusCode::SERVICE_UNAVAILABLE.as_u16(),
        headers: vec![],
        body: b"retry later".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    options.logging.enabled = false;
    options.retry.enabled = true;
    options.retry.max_attempts = 3;
    options.retry.retry_status_codes = Some(vec![StatusCode::TOO_MANY_REQUESTS]);
    let mut client = HttpClientFactory::new().create(options).unwrap();
    let attempts = Arc::new(AtomicUsize::new(0));
    let attempts_for_interceptor = Arc::clone(&attempts);
    client.add_request_interceptor(HttpRequestInterceptor::new(move |_request| {
        attempts_for_interceptor.fetch_add(1, Ordering::Relaxed);
        Ok(())
    }));

    let request = client.request(Method::GET, "/retry-status-filter").build();
    let error = client.execute(request).await.unwrap_err();
    assert_eq!(error.kind, HttpErrorKind::RetryAborted);
    let inner = retry_abort_inner_http(&error);
    assert_eq!(inner.kind, HttpErrorKind::Status);
    assert_eq!(inner.status, Some(StatusCode::SERVICE_UNAVAILABLE));
    assert_eq!(attempts.load(Ordering::Relaxed), 1);
}

#[tokio::test]
async fn test_retry_status_code_allowlist_can_enable_retry_for_503() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: StatusCode::SERVICE_UNAVAILABLE.as_u16(),
        headers: vec![],
        body: b"retry later".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    options.logging.enabled = false;
    options.retry.enabled = true;
    options.retry.max_attempts = 3;
    options.retry.retry_status_codes = Some(vec![StatusCode::SERVICE_UNAVAILABLE]);
    options.retry.retry_error_kinds = Some(vec![HttpErrorKind::Status]);
    let mut client = HttpClientFactory::new().create(options).unwrap();
    let attempts = Arc::new(AtomicUsize::new(0));
    let attempts_for_interceptor = Arc::clone(&attempts);
    client.add_request_interceptor(HttpRequestInterceptor::new(move |_request| {
        attempts_for_interceptor.fetch_add(1, Ordering::Relaxed);
        Ok(())
    }));

    let request = client.request(Method::GET, "/retry-status-allow").build();
    let error = client.execute(request).await.unwrap_err();
    assert_eq!(error.kind, HttpErrorKind::RetryAborted);
    let inner = retry_abort_inner_http(&error);
    assert_eq!(inner.kind, HttpErrorKind::Transport);
    assert_eq!(attempts.load(Ordering::Relaxed), 2);
}

#[tokio::test]
async fn test_retry_error_kind_allowlist_can_disable_transport_retry() {
    let mut options = HttpClientOptions::default();
    options.logging.enabled = false;
    options.retry.enabled = true;
    options.retry.max_attempts = 3;
    options.retry.retry_error_kinds = Some(vec![HttpErrorKind::ReadTimeout]);
    let mut client = HttpClientFactory::new().create(options).unwrap();
    let attempts = Arc::new(AtomicUsize::new(0));
    let attempts_for_interceptor = Arc::clone(&attempts);
    client.add_request_interceptor(HttpRequestInterceptor::new(move |_request| {
        attempts_for_interceptor.fetch_add(1, Ordering::Relaxed);
        Ok(())
    }));

    let request = client
        .request(Method::GET, "http://127.0.0.1:9/retry-kind-filter")
        .build();
    let error = timeout(Duration::from_secs(3), client.execute(request))
        .await
        .expect("execute timed out")
        .unwrap_err();
    assert_eq!(error.kind, HttpErrorKind::RetryAborted);
    let inner = retry_abort_inner_http(&error);
    assert_eq!(inner.kind, HttpErrorKind::Transport);
    assert_eq!(attempts.load(Ordering::Relaxed), 1);
}

#[tokio::test]
async fn test_add_header_applies_client_default_header() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let mut client = HttpClientFactory::new().create(options).unwrap();
    client.add_header("x-client", "default").unwrap();

    let request = client.request(Method::GET, "/default-header").build();
    let _ = client.execute(request).await.unwrap();
    let captured = server.finish().await;
    assert_eq!(
        captured.headers.get("x-client"),
        Some(&"default".to_string())
    );
}

#[tokio::test]
async fn test_add_headers_is_atomic_and_request_header_still_overrides() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let mut client = HttpClientFactory::new().create(options).unwrap();
    client
        .add_headers(&[
            ("x-batch-a", "value-a"),
            ("x-order", "client"),
            ("x-batch-b", "value-b"),
        ])
        .unwrap();

    let request = client
        .request(Method::GET, "/batch-headers")
        .header("x-order", "request")
        .unwrap()
        .build();
    let _ = client.execute(request).await.unwrap();
    let captured = server.finish().await;
    assert_eq!(
        captured.headers.get("x-batch-a"),
        Some(&"value-a".to_string())
    );
    assert_eq!(
        captured.headers.get("x-batch-b"),
        Some(&"value-b".to_string())
    );
    assert_eq!(
        captured.headers.get("x-order"),
        Some(&"request".to_string())
    );
}

#[tokio::test]
async fn test_add_headers_invalid_batch_does_not_partially_apply() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let mut client = HttpClientFactory::new().create(options).unwrap();

    let error = client
        .add_headers(&[("x-valid", "kept-out"), ("bad header", "boom")])
        .unwrap_err();
    assert_eq!(error.kind, HttpErrorKind::Other);
    assert!(error.message.contains("Invalid header name"));

    let request = client.request(Method::GET, "/atomic").build();
    let _ = client.execute(request).await.unwrap();
    let captured = server.finish().await;
    assert!(!captured.headers.contains_key("x-valid"));
}

#[tokio::test]
async fn test_add_header_invalid_value_does_not_apply() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let mut client = HttpClientFactory::new().create(options).unwrap();

    let error = client.add_header("x-bad", "line1\nline2").unwrap_err();
    assert_eq!(error.kind, HttpErrorKind::Other);
    assert!(error.message.contains("Invalid header value"));

    let request = client.request(Method::GET, "/invalid-value").build();
    let _ = client.execute(request).await.unwrap();
    let captured = server.finish().await;
    assert!(!captured.headers.contains_key("x-bad"));
}

#[tokio::test]
async fn test_add_header_injector_still_overrides_client_default_header() {
    let server = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let mut options = HttpClientOptions::default();
    options.base_url = Some(server.base_url());
    let mut client = HttpClientFactory::new().create(options).unwrap();
    client.add_header("x-order", "client").unwrap();
    client.add_header_injector(HttpHeaderInjector::new(|headers: &mut HeaderMap| {
        headers.insert(
            HeaderName::from_static("x-order"),
            HeaderValue::from_static("injector"),
        );
        Ok(())
    }));

    let request = client.request(Method::GET, "/injector-overrides").build();
    let _ = client.execute(request).await.unwrap();
    let captured = server.finish().await;
    assert_eq!(
        captured.headers.get("x-order"),
        Some(&"injector".to_string())
    );
}

#[tokio::test]
async fn test_clone_default_headers_are_independent_after_creation() {
    let server_original = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;
    let server_clone = spawn_one_shot_server(ResponsePlan::Immediate {
        status: 200,
        headers: vec![],
        body: b"ok".to_vec(),
    })
    .await;

    let mut client = HttpClientFactory::new().create_default().unwrap();
    client.add_header("x-shared", "base").unwrap();

    let mut cloned = client.clone();
    cloned.add_header("x-clone-only", "yes").unwrap();
    client.add_header("x-origin-only", "yes").unwrap();

    let path = format!("{}origin", server_original.base_url());
    let request_original = client.request(Method::GET, path.as_str()).build();
    let path = format!("{}clone", server_clone.base_url());
    let request_clone = cloned.request(Method::GET, path.as_str()).build();

    let _ = client.execute(request_original).await.unwrap();
    let _ = cloned.execute(request_clone).await.unwrap();

    let captured_original = server_original.finish().await;
    let captured_clone = server_clone.finish().await;

    assert_eq!(
        captured_original.headers.get("x-shared"),
        Some(&"base".to_string())
    );
    assert_eq!(
        captured_clone.headers.get("x-shared"),
        Some(&"base".to_string())
    );
    assert_eq!(
        captured_original.headers.get("x-origin-only"),
        Some(&"yes".to_string())
    );
    assert!(!captured_original.headers.contains_key("x-clone-only"));
    assert_eq!(
        captured_clone.headers.get("x-clone-only"),
        Some(&"yes".to_string())
    );
    assert!(!captured_clone.headers.contains_key("x-origin-only"));
}