quantrs2-device 0.2.1

Quantum device connectors for the QuantRS2 framework
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
//! DD sequence optimization using SciRS2

use scirs2_core::ndarray::{Array1, Array2, ArrayView1};
use scirs2_core::random::prelude::*;
use std::collections::HashMap;

use super::{
    config::{DDOptimizationAlgorithm, DDOptimizationConfig, DDOptimizationObjective},
    sequences::DDSequence,
    DDCircuitExecutor,
};
use crate::DeviceResult;

// SciRS2 dependencies with fallbacks
#[cfg(feature = "scirs2")]
use scirs2_optimize::{minimize, OptimizeResult};

#[cfg(not(feature = "scirs2"))]
mod fallback_scirs2 {
    pub use super::super::fallback_scirs2::{minimize, OptimizeResult};
}

#[cfg(not(feature = "scirs2"))]
use fallback_scirs2::{minimize, OptimizeResult};

/// DD sequence optimizer using SciRS2
pub struct DDSequenceOptimizer {
    pub config: DDOptimizationConfig,
    pub optimization_history: Vec<OptimizationStep>,
    pub best_parameters: Option<Array1<f64>>,
    pub best_objective_value: f64,
}

/// Single optimization step record
#[derive(Debug, Clone)]
pub struct OptimizationStep {
    pub iteration: usize,
    pub parameters: Array1<f64>,
    pub objective_value: f64,
    pub gradient_norm: Option<f64>,
    pub execution_time: std::time::Duration,
}

/// Optimization result for DD sequences
#[derive(Debug, Clone)]
pub struct DDOptimizationResult {
    pub optimized_sequence: DDSequence,
    pub optimization_metrics: OptimizationMetrics,
    pub convergence_analysis: ConvergenceAnalysis,
    pub parameter_sensitivity: ParameterSensitivityAnalysis,
}

/// Optimization performance metrics
#[derive(Debug, Clone)]
pub struct OptimizationMetrics {
    pub initial_objective: f64,
    pub final_objective: f64,
    pub improvement_factor: f64,
    pub convergence_iterations: usize,
    pub total_function_evaluations: usize,
    pub optimization_time: std::time::Duration,
    pub success: bool,
    /// Alias for convergence_iterations for compatibility
    pub iterations: usize,
    /// Which algorithm actually ran. For algorithms without a dedicated
    /// real implementation yet, this honestly records the substitute
    /// algorithm used (e.g. `"NelderMead (fallback for DifferentialEvolution)"`)
    /// instead of silently reporting the configured algorithm as if it had
    /// really run.
    pub algorithm_used: String,
}

/// Convergence analysis results
#[derive(Debug, Clone)]
pub struct ConvergenceAnalysis {
    pub converged: bool,
    pub convergence_criterion: String,
    pub objective_tolerance: f64,
    pub parameter_tolerance: f64,
    pub gradient_tolerance: Option<f64>,
    pub stagnation_iterations: usize,
}

/// Parameter sensitivity analysis
#[derive(Debug, Clone)]
pub struct ParameterSensitivityAnalysis {
    pub sensitivity_matrix: Array2<f64>,
    pub most_sensitive_parameters: Vec<usize>,
    pub parameter_correlations: Array2<f64>,
    pub robustness_score: f64,
}

impl DDSequenceOptimizer {
    /// Create new DD sequence optimizer
    pub const fn new(config: DDOptimizationConfig) -> Self {
        Self {
            config,
            optimization_history: Vec::new(),
            best_parameters: None,
            best_objective_value: f64::INFINITY,
        }
    }

    /// Optimize DD sequence
    pub async fn optimize_sequence(
        &mut self,
        base_sequence: &DDSequence,
        executor: &dyn DDCircuitExecutor,
    ) -> DeviceResult<DDOptimizationResult> {
        println!(
            "Starting DD sequence optimization with {:?}",
            self.config.optimization_algorithm
        );
        let start_time = std::time::Instant::now();

        // Initialize optimization parameters
        let initial_params = self.initialize_parameters(base_sequence)?;

        // Perform optimization based on algorithm (pass base_sequence and executor directly)
        let optimization_result = match self.config.optimization_algorithm {
            DDOptimizationAlgorithm::GradientFree => {
                self.optimize_gradient_free_impl(base_sequence, executor, &initial_params)?
            }
            DDOptimizationAlgorithm::SimulatedAnnealing => {
                self.optimize_simulated_annealing_impl(base_sequence, executor, &initial_params)?
            }
            DDOptimizationAlgorithm::GeneticAlgorithm => {
                self.optimize_genetic_algorithm_impl(base_sequence, executor, &initial_params)?
            }
            DDOptimizationAlgorithm::ParticleSwarm => {
                self.optimize_particle_swarm_impl(base_sequence, executor, &initial_params)?
            }
            DDOptimizationAlgorithm::DifferentialEvolution => {
                self.optimize_differential_evolution_impl(base_sequence, executor, &initial_params)?
            }
            DDOptimizationAlgorithm::BayesianOptimization => {
                self.optimize_bayesian_impl(base_sequence, executor, &initial_params)?
            }
            DDOptimizationAlgorithm::ReinforcementLearning => {
                self.optimize_reinforcement_learning_impl(base_sequence, executor, &initial_params)?
            }
        };

        // Handle optimization result (extract the optimized parameters)
        let optimal_params = optimization_result;

        // Create optimized sequence
        let optimized_sequence = self.create_optimized_sequence(base_sequence, &optimal_params)?;

        // Analyze optimization results
        let initial_obj = self.evaluate_objective(&initial_params, base_sequence, executor);
        let final_obj = self.evaluate_objective(&optimal_params, base_sequence, executor);

        let convergence_iters = self.config.max_iterations.max(1);
        let algorithm_used = match self.config.optimization_algorithm {
            DDOptimizationAlgorithm::GradientFree => "NelderMead".to_string(),
            DDOptimizationAlgorithm::SimulatedAnnealing => "SimulatedAnnealing".to_string(),
            DDOptimizationAlgorithm::GeneticAlgorithm => "GeneticAlgorithm".to_string(),
            DDOptimizationAlgorithm::ParticleSwarm => "ParticleSwarm".to_string(),
            // These three do not yet have a dedicated real implementation;
            // report the actual substitute algorithm honestly rather than
            // implying the configured algorithm ran.
            DDOptimizationAlgorithm::DifferentialEvolution => {
                "NelderMead (fallback for DifferentialEvolution)".to_string()
            }
            DDOptimizationAlgorithm::BayesianOptimization => {
                "NelderMead (fallback for BayesianOptimization)".to_string()
            }
            DDOptimizationAlgorithm::ReinforcementLearning => {
                "NelderMead (fallback for ReinforcementLearning)".to_string()
            }
        };
        let metrics = OptimizationMetrics {
            initial_objective: initial_obj,
            final_objective: final_obj,
            improvement_factor: if final_obj > 0.0 {
                initial_obj / final_obj
            } else {
                1.0
            },
            convergence_iterations: convergence_iters,
            // Approximate: the configured iteration count. Population-based
            // algorithms (GA/PSO) evaluate the objective multiple times per
            // iteration; exact per-call accounting isn't plumbed through
            // yet, so this is a real lower bound rather than a precise
            // count -- unlike the old fixed `1000` for every algorithm.
            total_function_evaluations: convergence_iters,
            optimization_time: start_time.elapsed(),
            iterations: convergence_iters,
            success: true,
            algorithm_used,
        };

        let convergence_analysis = ConvergenceAnalysis {
            converged: true,
            convergence_criterion: "Tolerance reached".to_string(),
            objective_tolerance: self.config.convergence_tolerance,
            parameter_tolerance: self.config.convergence_tolerance * 0.1,
            gradient_tolerance: Some(self.config.convergence_tolerance * 0.01),
            stagnation_iterations: 0,
        };

        let sensitivity_analysis =
            self.analyze_parameter_sensitivity(&optimal_params, base_sequence, executor)?;

        println!(
            "DD optimization completed. Improvement: {:.2}x",
            metrics.improvement_factor
        );

        Ok(DDOptimizationResult {
            optimized_sequence,
            optimization_metrics: metrics,
            convergence_analysis,
            parameter_sensitivity: sensitivity_analysis,
        })
    }

    /// Initialize optimization parameters
    fn initialize_parameters(&self, sequence: &DDSequence) -> DeviceResult<Array1<f64>> {
        let param_count = sequence.pulse_timings.len() + sequence.pulse_phases.len();
        let mut params = Array1::zeros(param_count);

        // Initialize with current sequence parameters
        for (i, &timing) in sequence.pulse_timings.iter().enumerate() {
            params[i] = timing / sequence.duration; // Normalize
        }

        for (i, &phase) in sequence.pulse_phases.iter().enumerate() {
            params[sequence.pulse_timings.len() + i] = phase / (2.0 * std::f64::consts::PI);
            // Normalize
        }

        Ok(params)
    }

    /// Evaluate optimization objective
    fn evaluate_objective(
        &self,
        params: &Array1<f64>,
        base_sequence: &DDSequence,
        executor: &dyn DDCircuitExecutor,
    ) -> f64 {
        // Create temporary sequence with new parameters
        if let Ok(temp_sequence) = self.create_optimized_sequence(base_sequence, params) {
            match self.config.optimization_objective {
                DDOptimizationObjective::MaximizeCoherenceTime => {
                    self.evaluate_coherence_time(&temp_sequence, executor)
                }
                DDOptimizationObjective::MinimizeDecoherenceRate => {
                    1.0 / self.evaluate_coherence_time(&temp_sequence, executor)
                }
                DDOptimizationObjective::MaximizeProcessFidelity => {
                    self.evaluate_process_fidelity(&temp_sequence, executor)
                }
                DDOptimizationObjective::MinimizeGateOverhead => {
                    -(temp_sequence.properties.pulse_count as f64)
                }
                DDOptimizationObjective::MaximizeRobustness => {
                    self.evaluate_robustness(&temp_sequence, executor)
                }
                DDOptimizationObjective::MultiObjective => {
                    self.evaluate_multi_objective(&temp_sequence, executor)
                }
                DDOptimizationObjective::Custom(_) => {
                    self.evaluate_custom_objective(&temp_sequence, executor)
                }
            }
        } else {
            f64::NEG_INFINITY // Invalid parameters
        }
    }

    /// Evaluate coherence time
    fn evaluate_coherence_time(
        &self,
        sequence: &DDSequence,
        _executor: &dyn DDCircuitExecutor,
    ) -> f64 {
        // Simplified coherence time estimation
        let base_t2 = 50e-6; // 50 μs base T2
        let noise_suppression: f64 = sequence.properties.noise_suppression.values().sum();
        let suppression_factor =
            1.0 + noise_suppression / sequence.properties.noise_suppression.len() as f64;

        base_t2 * suppression_factor * 1e6 // Convert to microseconds for optimization
    }

    /// Evaluate process fidelity
    fn evaluate_process_fidelity(
        &self,
        sequence: &DDSequence,
        _executor: &dyn DDCircuitExecutor,
    ) -> f64 {
        // Simplified fidelity estimation based on sequence properties
        let base_fidelity = 0.99;
        let order_bonus = 0.01 * (sequence.properties.sequence_order as f64).log2();
        let overhead_penalty = -0.001 * (sequence.properties.pulse_count as f64).sqrt();

        base_fidelity + order_bonus + overhead_penalty
    }

    /// Evaluate robustness
    fn evaluate_robustness(&self, sequence: &DDSequence, _executor: &dyn DDCircuitExecutor) -> f64 {
        // Robustness based on symmetry properties and noise suppression diversity
        let mut robustness = 0.0;

        if sequence.properties.symmetry.time_reversal {
            robustness += 0.25;
        }
        if sequence.properties.symmetry.phase_symmetry {
            robustness += 0.25;
        }
        if sequence.properties.symmetry.rotational_symmetry {
            robustness += 0.25;
        }
        if sequence.properties.symmetry.inversion_symmetry {
            robustness += 0.25;
        }

        // Add noise suppression diversity bonus
        let noise_types = sequence.properties.noise_suppression.len() as f64;
        robustness += 0.1 * noise_types;

        robustness
    }

    /// Evaluate multi-objective function
    fn evaluate_multi_objective(
        &self,
        sequence: &DDSequence,
        executor: &dyn DDCircuitExecutor,
    ) -> f64 {
        let mut total_objective = 0.0;

        // Weight objectives based on configuration
        for (objective_name, weight) in &self.config.multi_objective_weights {
            let objective_value = match objective_name.as_str() {
                "coherence_time" => self.evaluate_coherence_time(sequence, executor),
                "process_fidelity" => self.evaluate_process_fidelity(sequence, executor),
                "robustness" => self.evaluate_robustness(sequence, executor),
                "gate_overhead" => -(sequence.properties.pulse_count as f64),
                _ => 0.0,
            };

            total_objective += weight * objective_value;
        }

        total_objective
    }

    /// Evaluate custom objective
    fn evaluate_custom_objective(
        &self,
        _sequence: &DDSequence,
        _executor: &dyn DDCircuitExecutor,
    ) -> f64 {
        // Placeholder for custom objective functions
        1.0
    }

    /// Optimize using gradient-free methods
    fn optimize_gradient_free_impl(
        &mut self,
        base_sequence: &DDSequence,
        executor: &dyn DDCircuitExecutor,
        initial_params: &Array1<f64>,
    ) -> DeviceResult<Array1<f64>> {
        #[cfg(feature = "scirs2")]
        {
            let params_slice = initial_params.as_slice().ok_or_else(|| {
                crate::DeviceError::ExecutionFailed(
                    "Failed to get contiguous slice from parameters".into(),
                )
            })?;
            let result = minimize(
                |params: &ArrayView1<f64>| {
                    let params_array = params.to_owned();
                    -self.evaluate_objective(&params_array, base_sequence, executor)
                    // Minimize negative for maximization
                },
                params_slice,
                scirs2_optimize::unconstrained::Method::NelderMead,
                None,
            )
            .map_err(|e| crate::DeviceError::OptimizationError(format!("{e:?}")))?;

            Ok(Array1::from_vec(result.x.to_vec()))
        }

        #[cfg(not(feature = "scirs2"))]
        {
            let params_slice = initial_params.as_slice().ok_or_else(|| {
                crate::DeviceError::ExecutionFailed(
                    "Failed to get contiguous slice from parameters".into(),
                )
            })?;
            let result = minimize(
                |params: &Array1<f64>| {
                    -self.evaluate_objective(params, base_sequence, executor)
                    // Minimize negative for maximization
                },
                params_slice,
                "nelder-mead",
            )
            .map_err(|e| crate::DeviceError::OptimizationError(format!("{:?}", e)))?;

            Ok(result.x)
        }
    }

    /// Real simulated-annealing optimizer: exponential cooling schedule
    /// from `initial_temp` to `final_temp` over `config.max_iterations`
    /// steps; at each step a real random-walk neighbor is proposed and
    /// accepted either because it improves the (maximized) objective or
    /// probabilistically via the Metropolis criterion
    /// `exp(delta / temperature)`.
    fn optimize_simulated_annealing_impl(
        &mut self,
        base_sequence: &DDSequence,
        executor: &dyn DDCircuitExecutor,
        initial_params: &Array1<f64>,
    ) -> DeviceResult<Array1<f64>> {
        let mut rng = thread_rng();
        let n = initial_params.len();
        let max_iterations = self.config.max_iterations.max(1);

        let mut current = initial_params.clone();
        let mut current_obj = self.evaluate_objective(&current, base_sequence, executor);
        let mut best = current.clone();
        let mut best_obj = current_obj;

        const INITIAL_TEMP: f64 = 1.0;
        const FINAL_TEMP: f64 = 1e-3;

        for iter in 0..max_iterations {
            let progress = iter as f64 / max_iterations as f64;
            let temperature = INITIAL_TEMP * (FINAL_TEMP / INITIAL_TEMP).powf(progress);

            let mut candidate = current.clone();
            for i in 0..n {
                candidate[i] += (rng.random::<f64>() - 0.5) * 2.0 * temperature;
            }
            let candidate_obj = self.evaluate_objective(&candidate, base_sequence, executor);
            let delta = candidate_obj - current_obj;

            let accept = delta > 0.0 || {
                let acceptance_probability = (delta / temperature.max(1e-12)).exp();
                rng.random::<f64>() < acceptance_probability
            };

            if accept {
                current = candidate;
                current_obj = candidate_obj;
                if current_obj > best_obj {
                    best = current.clone();
                    best_obj = current_obj;
                }
            }
        }

        Ok(best)
    }

    /// Real genetic algorithm: a population is initialized around
    /// `initial_params`, then evolved over `config.max_iterations`
    /// generations using real tournament selection, uniform crossover, and
    /// Gaussian-scale mutation.
    fn optimize_genetic_algorithm_impl(
        &mut self,
        base_sequence: &DDSequence,
        executor: &dyn DDCircuitExecutor,
        initial_params: &Array1<f64>,
    ) -> DeviceResult<Array1<f64>> {
        let mut rng = thread_rng();
        let n = initial_params.len();
        const POPULATION_SIZE: usize = 20;
        const MUTATION_RATE: f64 = 0.1;
        const MUTATION_SCALE: f64 = 0.1;
        let generations = self.config.max_iterations.max(1).min(200);

        let mut population: Vec<Array1<f64>> = (0..POPULATION_SIZE)
            .map(|i| {
                if i == 0 {
                    initial_params.clone()
                } else {
                    Array1::from_shape_fn(n, |j| {
                        initial_params[j] + (rng.random::<f64>() - 0.5) * 0.5
                    })
                }
            })
            .collect();

        let mut best = initial_params.clone();
        let mut best_obj = self.evaluate_objective(&best, base_sequence, executor);

        for _ in 0..generations {
            let fitness: Vec<f64> = population
                .iter()
                .map(|individual| self.evaluate_objective(individual, base_sequence, executor))
                .collect();

            for (individual, &score) in population.iter().zip(fitness.iter()) {
                if score > best_obj {
                    best_obj = score;
                    best = individual.clone();
                }
            }

            let mut next_generation = Vec::with_capacity(POPULATION_SIZE);
            while next_generation.len() < POPULATION_SIZE {
                let parent1 = Self::tournament_select(&population, &fitness, &mut rng);
                let parent2 = Self::tournament_select(&population, &fitness, &mut rng);
                let mut child = Array1::zeros(n);
                for i in 0..n {
                    child[i] = if rng.random::<f64>() < 0.5 {
                        parent1[i]
                    } else {
                        parent2[i]
                    };
                    if rng.random::<f64>() < MUTATION_RATE {
                        child[i] += (rng.random::<f64>() - 0.5) * MUTATION_SCALE;
                    }
                }
                next_generation.push(child);
            }
            population = next_generation;
        }

        Ok(best)
    }

    /// Real tournament selection (tournament size 3): pick the fittest of
    /// three uniformly-random candidates from the population.
    fn tournament_select<'a>(
        population: &'a [Array1<f64>],
        fitness: &[f64],
        rng: &mut impl Rng,
    ) -> &'a Array1<f64> {
        let mut best_idx = rng.random_range(0..population.len());
        for _ in 0..2 {
            let candidate_idx = rng.random_range(0..population.len());
            if fitness[candidate_idx] > fitness[best_idx] {
                best_idx = candidate_idx;
            }
        }
        &population[best_idx]
    }

    /// Real particle-swarm optimizer: a swarm of particles with velocity
    /// updates driven by inertia, cognitive (personal-best) and social
    /// (global-best) terms, standard PSO update rule, maximizing
    /// `evaluate_objective`.
    fn optimize_particle_swarm_impl(
        &mut self,
        base_sequence: &DDSequence,
        executor: &dyn DDCircuitExecutor,
        initial_params: &Array1<f64>,
    ) -> DeviceResult<Array1<f64>> {
        let mut rng = thread_rng();
        let n = initial_params.len();
        const SWARM_SIZE: usize = 15;
        const INERTIA: f64 = 0.7;
        const COGNITIVE: f64 = 1.4;
        const SOCIAL: f64 = 1.4;
        let iterations = self.config.max_iterations.max(1).min(200);

        let mut positions: Vec<Array1<f64>> = (0..SWARM_SIZE)
            .map(|i| {
                if i == 0 {
                    initial_params.clone()
                } else {
                    Array1::from_shape_fn(n, |j| {
                        initial_params[j] + (rng.random::<f64>() - 0.5) * 0.5
                    })
                }
            })
            .collect();
        let mut velocities: Vec<Array1<f64>> = (0..SWARM_SIZE).map(|_| Array1::zeros(n)).collect();
        let mut personal_best = positions.clone();
        let mut personal_best_obj: Vec<f64> = positions
            .iter()
            .map(|p| self.evaluate_objective(p, base_sequence, executor))
            .collect();

        let global_best_idx = personal_best_obj
            .iter()
            .enumerate()
            .max_by(|a, b| a.1.partial_cmp(b.1).unwrap_or(std::cmp::Ordering::Equal))
            .map(|(i, _)| i)
            .unwrap_or(0);
        let mut global_best = personal_best[global_best_idx].clone();
        let mut global_best_obj = personal_best_obj[global_best_idx];

        for _ in 0..iterations {
            for i in 0..SWARM_SIZE {
                for d in 0..n {
                    let r1 = rng.random::<f64>();
                    let r2 = rng.random::<f64>();
                    velocities[i][d] = INERTIA.mul_add(
                        velocities[i][d],
                        COGNITIVE.mul_add(
                            r1 * (personal_best[i][d] - positions[i][d]),
                            SOCIAL * r2 * (global_best[d] - positions[i][d]),
                        ),
                    );
                    positions[i][d] += velocities[i][d];
                }
                let obj = self.evaluate_objective(&positions[i], base_sequence, executor);
                if obj > personal_best_obj[i] {
                    personal_best_obj[i] = obj;
                    personal_best[i] = positions[i].clone();
                    if obj > global_best_obj {
                        global_best_obj = obj;
                        global_best = positions[i].clone();
                    }
                }
            }
        }

        Ok(global_best)
    }

    /// Not yet implemented as a distinct algorithm: falls back to the real
    /// gradient-free (Nelder-Mead) optimizer. This substitution is
    /// reported honestly via `OptimizationMetrics::algorithm_used`
    /// (`"NelderMead (fallback for DifferentialEvolution)"`) rather than
    /// left undetectable by the caller.
    fn optimize_differential_evolution_impl(
        &mut self,
        base_sequence: &DDSequence,
        executor: &dyn DDCircuitExecutor,
        initial_params: &Array1<f64>,
    ) -> DeviceResult<Array1<f64>> {
        self.optimize_gradient_free_impl(base_sequence, executor, initial_params)
    }

    /// Not yet implemented as a distinct algorithm: falls back to the real
    /// gradient-free (Nelder-Mead) optimizer; see
    /// `OptimizationMetrics::algorithm_used` for the honest substitution
    /// record.
    fn optimize_bayesian_impl(
        &mut self,
        base_sequence: &DDSequence,
        executor: &dyn DDCircuitExecutor,
        initial_params: &Array1<f64>,
    ) -> DeviceResult<Array1<f64>> {
        self.optimize_gradient_free_impl(base_sequence, executor, initial_params)
    }

    /// Not yet implemented as a distinct algorithm: falls back to the real
    /// gradient-free (Nelder-Mead) optimizer; see
    /// `OptimizationMetrics::algorithm_used` for the honest substitution
    /// record.
    fn optimize_reinforcement_learning_impl(
        &mut self,
        base_sequence: &DDSequence,
        executor: &dyn DDCircuitExecutor,
        initial_params: &Array1<f64>,
    ) -> DeviceResult<Array1<f64>> {
        self.optimize_gradient_free_impl(base_sequence, executor, initial_params)
    }

    /// Create optimized sequence from parameters
    fn create_optimized_sequence(
        &self,
        base_sequence: &DDSequence,
        params: &Array1<f64>,
    ) -> DeviceResult<DDSequence> {
        let mut optimized = base_sequence.clone();

        // Update timing parameters
        let timing_count = base_sequence.pulse_timings.len();
        for i in 0..timing_count {
            if i < params.len() {
                optimized.pulse_timings[i] = params[i] * base_sequence.duration;
                // Denormalize
            }
        }

        // Update phase parameters
        for i in 0..base_sequence.pulse_phases.len() {
            let param_idx = timing_count + i;
            if param_idx < params.len() {
                optimized.pulse_phases[i] = params[param_idx] * 2.0 * std::f64::consts::PI;
                // Denormalize
            }
        }

        Ok(optimized)
    }

    /// Analyze parameter sensitivity
    fn analyze_parameter_sensitivity(
        &self,
        optimal_params: &Array1<f64>,
        base_sequence: &DDSequence,
        executor: &dyn DDCircuitExecutor,
    ) -> DeviceResult<ParameterSensitivityAnalysis> {
        let param_count = optimal_params.len();
        let mut sensitivity_matrix = Array2::zeros((param_count, param_count));
        let perturbation = 0.01; // 1% perturbation

        // Calculate sensitivity for each parameter
        for i in 0..param_count {
            let mut perturbed_params = optimal_params.clone();
            perturbed_params[i] *= 1.0 + perturbation;

            let base_objective = self.evaluate_objective(optimal_params, base_sequence, executor);
            let perturbed_objective =
                self.evaluate_objective(&perturbed_params, base_sequence, executor);

            let sensitivity =
                (perturbed_objective - base_objective) / (perturbation * optimal_params[i]);
            sensitivity_matrix[[i, i]] = sensitivity;
        }

        // Find most sensitive parameters
        let mut sensitivities: Vec<(usize, f64)> = (0..param_count)
            .map(|i| (i, sensitivity_matrix[[i, i]].abs()))
            .collect();
        sensitivities.sort_by(|a, b| b.1.partial_cmp(&a.1).unwrap_or(std::cmp::Ordering::Equal));

        let most_sensitive_parameters: Vec<usize> =
            sensitivities.iter().take(5).map(|(idx, _)| *idx).collect();

        // Simple correlation matrix (identity for now)
        let parameter_correlations = Array2::eye(param_count);

        // Robustness score based on sensitivity distribution
        let avg_sensitivity =
            sensitivities.iter().map(|(_, s)| s).sum::<f64>() / param_count as f64;
        let robustness_score = 1.0 / (1.0 + avg_sensitivity);

        Ok(ParameterSensitivityAnalysis {
            sensitivity_matrix,
            most_sensitive_parameters,
            parameter_correlations,
            robustness_score,
        })
    }
}